Re: [libvirt] [PATCH v2 0/4] Add a domain masterKey secret for qemu,

On 03/29/2016 07:11 PM, John Ferlan wrote: > v1: http://www.redhat.com/archives/libvir-list/2016-March/msg01206.html > > Patch 1 is already ACK'd. I assume this code won't go into 1.3.3, but > would hopefully be early in 1.3.4 and I didn't want to break up the > capability bits across

Re: [libvirt] [PATCH] libxl: libxl_domain_create_restore has an extra argument

On 4/5/16 9:20 AM, Wei Liu wrote: > In the latest libxenlight code, libxl_domain_create_restore accepts a > new argument. Update libvirt's libxl driver for that. Use the macro > provided by libxenlight to detect which version should be used. > > The new parameter (send_back_fd) is set to -1

[libvirt] 200ms delay waiting for qemu monitor

[Thanks to Dan Berrangé for doing the analysis of this one] I was investigating a 200+ millisecond delay when libvirt starts a qemu guest. You can see the traces here: http://oirase.annexia.org/tmp/libvirt.log http://oirase.annexia.org/tmp/libvirtd.log The delay happens at around

Re: [libvirt] [PATCH] Link xen driver against libxl

On Wed, Apr 06, 2016 at 09:53:06AM +0200, Jiri Denemark wrote: > On Tue, Apr 05, 2016 at 18:16:29 +0200, Guido Günther wrote: > > >From 4e302ea482d58c5ae034f85ea27d0318cb0b59c5 Mon Sep 17 00:00:00 2001 > > Message-Id: > > <4e302ea482d58c5ae034f85ea27d0318cb0b59c5.1459872920.git@sigxcpu.org> >

Re: [libvirt] [PATCH 2/2] qemu: alias: Fix calculation of memory device aliases

On Wed, Apr 06, 2016 at 05:52:49PM +0200, Peter Krempa wrote: > For device hotplug, the new alias ID needs to be checked in the list > rather than using the count of devices. Unplugging a device that is not > last in the array will make further hotplug impossible due to alias > collision. > >

Re: [libvirt] [PATCH 1/2] qemu: alias: Fix calculation of RNG device aliases

On Wed, Apr 06, 2016 at 05:52:48PM +0200, Peter Krempa wrote: > For device hotplug, the new alias ID needs to be checked in the list > rather than using the count of devices. Unplugging a device that is not > last in the array will make further hotplug impossible due to alias > collision. > >

[libvirt] [PATCH 6/8] qemu: driver: Reuse qemuDomainGetMonitor in qemuDomainMemoryStats

--- src/qemu/qemu_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a00268b..8b9801a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -11471,7 +11471,6 @@ qemuDomainMemoryStats(virDomainPtr dom,

[libvirt] [PATCH 7/8] qemu: process: Simplify condition in qemuProcessRefreshBalloonState

No need to store failure and re-check right away. --- src/qemu/qemu_process.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 4911c1d..a8c5139 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@

[libvirt] [PATCH 3/8] qemu: command: Drop obsolete comment

The change that made qemu not add the memballoon by default happened prior to 0.12.0. Additionaly the comment was misleading due to the code that was added below. Since we always need to add a balloon on the commandline drop the comment. --- src/qemu/qemu_command.c | 7 +-- 1 file changed, 1

[libvirt] [PATCH 8/8] qemu: hotplug: Properly recalculate/reload balloon size after hot(un)plug

Rather than trying some magic calculations on our side query the monitor for the current size of the memory balloon both on hotplug and hotunplug. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1220702 --- src/qemu/qemu_hotplug.c | 15 ++- src/qemu/qemu_process.c | 2 +-

[libvirt] [PATCH 4/8] qemu: command: Refactor memballoon command line formatting

Now that there is just one format of the memory balloon command line used the code can be merged into a single function. Additionally with some tweaks to the control flow the code is easier to read. --- src/qemu/qemu_command.c | 76 +++--

[libvirt] [PATCH 5/8] qemu: domain: Add helper to determine presence of memory baloon

--- src/qemu/qemu_command.c | 3 +-- src/qemu/qemu_domain.c | 11 +-- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 12 src/qemu/qemu_process.c | 9 +++-- 5 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_command.c

[libvirt] [PATCH 2/8] qemu: caps: Deprecate QEMU_CAPS_BALLOON

The flag is now unused and all qemus supported by libvirt already support it. --- src/qemu/qemu_capabilities.c | 3 --- src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 1 - tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 1 -

[libvirt] [PATCH 0/8] qemu: Fix current ballooned size after memory hot(un)plug

Clean up some of the memory balloon code and fix the calculation of size after hotplug. Peter Krempa (8): qemu: command: Assume QEMU_CAPS_DEVICE when building memballoon args qemu: caps: Deprecate QEMU_CAPS_BALLOON qemu: command: Drop obsolete comment qemu: command: Refactor memballoon

[libvirt] [PATCH 1/8] qemu: command: Assume QEMU_CAPS_DEVICE when building memballoon args

--- src/qemu/qemu_command.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a6afaec..bcd2408 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3452,6 +3452,7 @@

Re: [libvirt] [PATCH 06/18] domain_conf: cleanup error paths for graphics parser

On Mon, Apr 04, 2016 at 03:20:23PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 100 > ++--- > 1 file changed, 45 insertions(+), 55 deletions(-) > @@ -10846,17 +10845,19 @@ >

[libvirt] [PATCH 0/2] Fix alias asignment code for hotplugged RNGs/memory

I messed up the original impl and then copied it to memory devices. Sigh. Peter Krempa (2): qemu: alias: Fix calculation of RNG device aliases qemu: alias: Fix calculation of memory device aliases src/qemu/qemu_alias.c | 47 +--

[libvirt] [PATCH 1/2] qemu: alias: Fix calculation of RNG device aliases

For device hotplug, the new alias ID needs to be checked in the list rather than using the count of devices. Unplugging a device that is not last in the array will make further hotplug impossible due to alias collision. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1324551 ---

[libvirt] [PATCH 2/2] qemu: alias: Fix calculation of memory device aliases

For device hotplug, the new alias ID needs to be checked in the list rather than using the count of devices. Unplugging a device that is not last in the array will make further hotplug impossible due to alias collision. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1324551 ---

Re: [libvirt] [PATCH 05/18] domain_conf: split graphics xml parser into multiple functions

On Mon, Apr 04, 2016 at 03:20:22PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 835 > +++-- > 1 file changed, 453 insertions(+), 382 deletions(-) > s/ParseXMLVnc/ParseXMLVNC/g

Re: [libvirt] [RFC 6/6] qemu: Cache GIC capabilities

On Wed, 2016-03-30 at 16:29 -0400, John Ferlan wrote: > On 03/21/2016 01:28 PM, Andrea Bolognani wrote: > > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c > > index 64007f0..23c3740 100644 > > --- a/src/qemu/qemu_capabilities.c > > +++ b/src/qemu/qemu_capabilities.c > >

Re: [libvirt] [PATCH 04/18] domain_conf: cleanup virDomainGraphicsListensParseXML

On Mon, Apr 04, 2016 at 03:20:21PM +0200, Pavel Hrdina wrote: > Refactor the listen parser to use only one loop. > > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 117 > + > 1 file changed, 50 insertions(+), 67

Re: [libvirt] [RFC 5/6] qemu: Fill in GIC capabilities

On Wed, 2016-03-30 at 16:12 -0400, John Ferlan wrote: > On 03/21/2016 01:28 PM, Andrea Bolognani wrote: > > +static int > > +virQEMUCapsFillDomainFeatureGICCaps(virQEMUCapsPtr qemuCaps, > > +virDomainCapsPtr domCaps) > > +{ > > +virDomainCapsFeatureGICPtr

Re: [libvirt] [PATCH 01/18] tests: remove unwanted VIR_FREE of spice and vnc default listen

On Mon, Apr 04, 2016 at 03:20:18PM +0200, Pavel Hrdina wrote: > After the test and qemu_process refactor now we can benefit from default > listen address for spice and vnc in tests. > > Signed-off-by: Pavel Hrdina > --- >

Re: [libvirt] [PATCH 03/18] domain_conf: introduce virDomainGraphicsListensParseXML

On Mon, Apr 04, 2016 at 03:20:20PM +0200, Pavel Hrdina wrote: > Move code, that parses graphics listens, to it's own function. s/it's/its/ > > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 79 > ++ > 1 file

Re: [libvirt] [RFC 4/6] conf: Expose GIC capabilities

On Wed, 2016-03-30 at 16:10 -0400, John Ferlan wrote: > > diff --git a/tests/domaincapsschemadata/domaincaps-qemu_1.6.50-1.xml > > b/tests/domaincapsschemadata/domaincaps- > > qemu_1.6.50-1.xml > > index 37d2102..990661b 100644 > > --- a/tests/domaincapsschemadata/domaincaps-qemu_1.6.50-1.xml > >

Re: [libvirt] [PATCH v2] secret: Introduce virSecretGetSecretString

On Mon, Apr 04, 2016 at 10:19:58PM -0400, John Ferlan wrote: > Commit id 'fb2bd208' essentially copied the qemuGetSecretString > creating an libxlGetSecretString. Rather than have multiple copies > of the same code, create src/secret/secret_util.{c,h} files and > place the common function in

Re: [libvirt] [PATCH 6/7] storage:dir: adapts .refreshVol .refreshPool for ploop volumes

On 06/04/16 16:07, Ján Tomko wrote: On Wed, Apr 06, 2016 at 03:57:17PM +0300, Olga Krishtal wrote: On 06/04/16 15:11, Ján Tomko wrote: On Wed, Apr 06, 2016 at 11:18:22AM +0300, Olga Krishtal wrote: The thing is that if we changed the size, the content of root.hds and had left the old

Re: [libvirt] [PATCH 6/7] storage:dir: adapts .refreshVol .refreshPool for ploop volumes

On Wed, Apr 06, 2016 at 03:57:17PM +0300, Olga Krishtal wrote: > On 06/04/16 15:11, Ján Tomko wrote: > > On Wed, Apr 06, 2016 at 11:18:22AM +0300, Olga Krishtal wrote: > >> The thing is that if we changed the size, the content of root.hds and > >> had left the old DiskDeskriptor.xml - it becomes

Re: [libvirt] [PATCH] virt-admin: get rid of LIBVIRT_DEFAULT_ADMIN_URI env var

On 06/04/16 15:00, Ján Tomko wrote: > There is a LIBVIRT_ADMIN_DEFAULT_URI environment variable > which is honored by virAdmConnectOpen and documented > in the virt-admin man page. > > LIBVIRT_DEFAULT_ADMIN_URI is undocumented and this is its > only occurrence. > --- > tools/virt-admin.c | 4

[libvirt] [PATCH] virt-admin: get rid of LIBVIRT_DEFAULT_ADMIN_URI env var

There is a LIBVIRT_ADMIN_DEFAULT_URI environment variable which is honored by virAdmConnectOpen and documented in the virt-admin man page. LIBVIRT_DEFAULT_ADMIN_URI is undocumented and this is its only occurrence. --- tools/virt-admin.c | 4 1 file changed, 4 deletions(-) diff --git

Re: [libvirt] [PATCH 6/7] storage:dir: adapts .refreshVol .refreshPool for ploop volumes

On 06/04/16 15:11, Ján Tomko wrote: On Wed, Apr 06, 2016 at 11:18:22AM +0300, Olga Krishtal wrote: On 05/04/16 18:01, Ján Tomko wrote: On Mon, Mar 14, 2016 at 07:00:39PM +0300, Olga Krishtal wrote: Refreshes meta-information such as allocation, capacity, format, etc. Ploop volumes differ from

Re: [libvirt] [PATCH 6/7] storage:dir: adapts .refreshVol .refreshPool for ploop volumes

On Wed, Apr 06, 2016 at 11:18:22AM +0300, Olga Krishtal wrote: > On 05/04/16 18:01, Ján Tomko wrote: > > On Mon, Mar 14, 2016 at 07:00:39PM +0300, Olga Krishtal wrote: > >> Refreshes meta-information such as allocation, capacity, format, etc. > >> Ploop volumes differ from other volume types. Path

Re: [libvirt] [RFC 3/6] schema: Validate GIC capabilities

On Wed, 2016-03-30 at 15:36 -0400, John Ferlan wrote: > On 03/21/2016 01:28 PM, Andrea Bolognani wrote: > >  > > We need to expose GIC capabilities in the domain capabilities > > XML: update the schema to validate documents that contain the > > new information. > > --- > >  

Re: [libvirt] [PATCH 3/3] libvirt-admin: do not crash on URI without a scheme

On 06/04/16 10:51, Ján Tomko wrote: > --- > src/libvirt-admin.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c > index 54af90c..6577c87 100644 > --- a/src/libvirt-admin.c > +++ b/src/libvirt-admin.c > @@ -121,10 +121,10 @@

[libvirt] [PATCH 1/3] vz: simplify getting strings from vzsdk

SDK does not allocate memory when getting strings thus we need to call every function that returns string twice. First to obtain string length, second to obtain string itself. It is tedious. Let's move this logic into macro that generates wrapper. Luckily all functions we need to wrap have 3

[libvirt] [PATCH 3/3] vz: simplify getting fixed size strings from vzsdk

Getting strings of predictable length from vz SDK is still not convinient. We don't need length feedback from sdk function but still need to allocate and set length variable just to be able to call the function. Let's introduce another macro that generates suitable wrapper in this case.

[libvirt] [PATCH 0/3] vz: simplify getting strings from vz sdk

Nikolay Shirokovskiy (3): vz: simplify getting strings from vzsdk vz: fix memory leak vz: simplify getting fixed size strings from vzsdk src/vz/vz_sdk.c | 203 +--- 1 file changed, 77 insertions(+), 126 deletions(-) -- 1.8.3.1 --

[libvirt] [PATCH 2/3] vz: fix memory leak

we don't need to allocate mastr at all as it is array and already have the the space it needs. Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_sdk.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 0d853d0..443f753

Re: [libvirt] [PATCH] spec: Include KVM support on RHEL 7 ppc64 and newer

On Wed, 2016-04-06 at 13:24 +0200, Jiri Denemark wrote: > > So can I amend the commit with your proposed version > > and push it? >  > Yeah, thanks. Done, thanks :) -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] spec: Include KVM support on RHEL 7 ppc64 and newer

On Wed, Apr 06, 2016 at 13:21:03 +0200, Andrea Bolognani wrote: > On Wed, 2016-04-06 at 12:17 +0200, Jiri Denemark wrote: > > > diff --git a/libvirt.spec.in b/libvirt.spec.in > > > index 03e2438..fdea12a 100644 > > > --- a/libvirt.spec.in > > > +++ b/libvirt.spec.in > > > @@ -77,7 +77,11 @@ > > >  

Re: [libvirt] [PATCH] libxl: libxl_domain_create_restore has an extra argument

On Tue, Apr 05, 2016 at 04:12:57PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH] libxl: libxl_domain_create_restore has an extra > argument"): > > CC Jim as well > > > > On Tue, Apr 05, 2016 at 03:20:12PM +0100, Wei Liu wrote: > > > In the latest libxenlight code,

Re: [libvirt] [PATCH] spec: Include KVM support on RHEL 7 ppc64 and newer

On Wed, 2016-04-06 at 12:17 +0200, Jiri Denemark wrote: > > diff --git a/libvirt.spec.in b/libvirt.spec.in > > index 03e2438..fdea12a 100644 > > --- a/libvirt.spec.in > > +++ b/libvirt.spec.in > > @@ -77,7 +77,11 @@ > >   > >  %if 0%{?rhel} > >  %define with_qemu_tcg 0 > > -%define

Re: [libvirt] [PATCH 2/3] tools: remove unnecessary defaultConn variable

On 06/04/16 10:51, Ján Tomko wrote: > vshStrdup returns NULL without exiting on NULL input. > --- > tools/virsh.c | 4 +--- > tools/virt-admin.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c > index 8c616d6..fe33839 100644 > ---

Re: [libvirt] [PATCH 1/3] tools: read default connection uri from env later

On 06/04/16 10:51, Ján Tomko wrote: > Postpone filling out the default connection in ctl->connname > after calling virshInit. > > This allows printing help without a connection to the daemon. > --- > tools/virsh.c | 6 +++--- > tools/virt-admin.c | 6 +++--- > 2 files changed, 6

[libvirt] Release of libvirt-1.3.3

With a bit of delay the release is now out and git is open again, I tagged the release in head, and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ UI also tagged and pushed signed tarball and rpms for the python bindings for 1.3.3 at:

Re: [libvirt] [PATCH] spec: Include KVM support on RHEL 7 ppc64 and newer

On Thu, Mar 17, 2016 at 11:24:34 +0100, Andrea Bolognani wrote: > --- > Definitely not an expert on spec files, but I did a test build > on RHEL 7.2 ppc64le and it resulted in > > libvirt-daemon-driver-qemu-1.3.3-1.el7.ppc64le.rpm > libvirt-daemon-kvm-1.3.3-1.el7.ppc64le.rpm >

Re: [libvirt] [PATCH] spec: Include KVM support on RHEL 7 ppc64 and newer

On Thu, 2016-03-17 at 11:24 +0100, Andrea Bolognani wrote: > --- > Definitely not an expert on spec files, but I did a test build > on RHEL 7.2 ppc64le and it resulted in > >   libvirt-daemon-driver-qemu-1.3.3-1.el7.ppc64le.rpm >   libvirt-daemon-kvm-1.3.3-1.el7.ppc64le.rpm >  

[libvirt] [PATCH 2/3] tools: remove unnecessary defaultConn variable

vshStrdup returns NULL without exiting on NULL input. --- tools/virsh.c | 4 +--- tools/virt-admin.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 8c616d6..fe33839 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -908,7 +908,6

[libvirt] [PATCH 3/3] libvirt-admin: do not crash on URI without a scheme

--- src/libvirt-admin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c index 54af90c..6577c87 100644 --- a/src/libvirt-admin.c +++ b/src/libvirt-admin.c @@ -121,10 +121,10 @@ getSocketPath(virURIPtr uri) } if

[libvirt] [PATCH 0/3] tools: virsh/virt-admin uri handling spring series 2016

*** <""/.a... *** Ján Tomko (3): tools: read default connection uri from env later tools: remove unnecessary defaultConn variable libvirt-admin: do not crash on URI without a scheme src/libvirt-admin.c | 4 ++-- tools/virsh.c | 6 ++ tools/virt-admin.c | 6 ++ 3 files

[libvirt] [PATCH 1/3] tools: read default connection uri from env later

Postpone filling out the default connection in ctl->connname after calling virshInit. This allows printing help without a connection to the daemon. --- tools/virsh.c | 6 +++--- tools/virt-admin.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/virsh.c

Re: [libvirt] [PATCH 6/7] storage:dir: adapts .refreshVol .refreshPool for ploop volumes

On 05/04/16 18:01, Ján Tomko wrote: On Mon, Mar 14, 2016 at 07:00:39PM +0300, Olga Krishtal wrote: Refreshes meta-information such as allocation, capacity, format, etc. Ploop volumes differ from other volume types. Path to volume is the path to directory with image file root.hds and

[libvirt] [PATCH] makefile: Move include/Makefile.am to include/libvirt/Makefile.am

The reason for this is to fix the automatic rebuild of libvirt-common.h.in. All *.in files should be automatically rebuilt each time they're modified. It works well for makefiles and pkgconfig files, since they do have a valid dependency in the top-level Makefile. However, with libvirt-common.h.in

Re: [libvirt] [PATCH] Link xen driver against libxl

On Tue, Apr 05, 2016 at 18:16:29 +0200, Guido Günther wrote: > >From 4e302ea482d58c5ae034f85ea27d0318cb0b59c5 Mon Sep 17 00:00:00 2001 > Message-Id: > <4e302ea482d58c5ae034f85ea27d0318cb0b59c5.1459872920.git@sigxcpu.org> > From: =?UTF-8?q?Guido=20G=C3=BCnther?= > Date: Thu,

Re: [libvirt] [PATCH 0/2] boot order storage/parsing cleanup

On Tue, Apr 05, 2016 at 17:36:27 +0200, Ján Tomko wrote: > On Thu, Mar 31, 2016 at 04:05:01PM +0200, Peter Krempa wrote: ... > ACK to both Pushed; Thanks. Peter signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com