[libvirt] esx: What does "No storage volume with key or path" mean?

We've had a report of a particular vCenter server (using VMware clustering, we think) where virStorageVolInfo of a guest volume fails with: Storage volume not found: No storage volume with key or path '[...] ...' The error comes from esxVI_LookupFileInfoByDatastorePath:

[libvirt] [PATCH 0/3] Couple of patches to resolve recent Coverity issues

Recent changes have tripped my Coverity checker. John Ferlan (3): Use virGetLastErrorMessage to avoid Coverity message admin: Clean up error path in adminServerListClients conf: Fix error path in virNodeDevPCICapabilityParseXML daemon/admin_server.c | 3 +--

[libvirt] [PATCH 1/3] Use virGetLastErrorMessage to avoid Coverity message

Both instances use VIR_WARN() to print the error from a failed virDBusGetSystemBus() call. Rather than use the virGetLastError and need to check for valid return err pointer, just use the virGetLastErrorMessage. Signed-off-by: John Ferlan --- src/network/bridge_driver.c

[libvirt] [PATCH 2/3] admin: Clean up error path in adminServerListClients

Coverity noted that in adminServerListClients if virNetServerGetClients returns a -1 into ret, then the call virObjectListFreeCount in cleanup will not be very happy. Adjust the code to skip the cleanup label and just return -1 if virNetServerGetClients fails. Signed-off-by: John Ferlan

[libvirt] [PATCH 3/3] conf: Fix error path in virNodeDevPCICapabilityParseXML

If the call to virXPathNodeSet to set naddresses fails, Coverity notes that the subsequent VIR_ALLOC_N cannot have a negative value (well it probably wouldn't be negative per se). Signed-off-by: John Ferlan --- src/conf/node_device_conf.c | 5 - 1 file changed, 4

Re: [libvirt] [PATCH] util: set vlan tag for macvtap passthrough mode on SRIOV VFs

On 05/05/2016 12:39 PM, Laine Stump wrote: > SRIOV VFs used in macvtap passthrough mode can take advantage of the > SRIOV card's transparent vlan tagging. All the code was there to set > the vlan tag, and it has been used for SRIOV VFs used for hostdev > interfaces for several years, but for

[libvirt] [PATCH 4/9] target-i386: List CPU models using subclass list

Instead of using the builtin_x86_defs array, use the QOM subclass list to list CPU models on "-cpu ?" and "query-cpu-definitions". Signed-off-by: Andreas Färber [ehabkost: copied code from a patch by Andreas: "target-i386: QOM'ify CPU", from March 2012] Signed-off-by: Eduardo

[libvirt] [PATCH 9/9] target-i386: Return runnability information on query-cpu-definitions

Fill the "runnable" and "unavailable-features" fields on the x86 implementation of query-cpu-definitions. Example command output: { "return": [ { "runnable": true, "name": "host"}, { "runnable": true, "name": "qemu64"}, { "runnable": true, "name": "qemu32"},

[libvirt] [PATCH 6/9] target-i386: Define CPUID filtering functions before x86_cpu_list()

Just move code to another place so the it can be reused by the query-cpu-definitions code. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 68 +++ 1 file changed, 34 insertions(+), 34 deletions(-) diff --git

[libvirt] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names

This makes the feature name tables in feature_word_info all match the actual QOM property names we use. This will make the command-line interface more consistent, allowing the QOM property names to be used as "-cpu" arguments directly. Add extra feat2prop() calls to x86_cpu_parse_featurestr() to

[libvirt] [PATCH 1/9] target-i386: Move TCG initialization check to tcg_x86_init()

Instead of requiring cpu.c to check if TCG was already initialized, simply let the function be called multiple times. Suggested-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 +--- target-i386/translate.c | 6 ++ 2

[libvirt] [PATCH 2/9] target-i386: Move TCG initialization to realize time

QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Move TCG initialization to realize time so it won't be called when just doing object_new() on a X86CPU subclass.

[libvirt] [PATCH 5/9] target-i386: Move warning code outside x86_cpu_filter_features()

x86_cpu_filter_features() will be reused by code that shouldn't print any warning. Move the warning code to a new x86_cpu_report_filtered_features() function, and call it from x86_cpu_realizefn(). Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 28

[libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

Extend query-cpu-definitions schema to allow it to return two new optional fields: "runnable" and "unavailable-features". "runnable" will tell if the CPU model can be run in the current host. "unavailable-features" will contain a list of CPU properties that are preventing the CPU model from

[libvirt] [PATCH 3/9] target-i386: Call cpu_exec_init() on realize

QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Calling cpu_exec_init() also affects QEMU's ability to handle errors during CPU creation, as some actions done

[libvirt] [PATCH 0/9] Add runnability info to query-cpu-definitions

This series extends query-cpu-definitions to include two extra fields: "runnable", and "unavailable-features". This will return information based on the current machine and accelerator only. In the future we may extend these mechanisms to allow querying other machines and other accelerators

Re: [libvirt] [PATCH 0/4] qemu_monitor_json: Refactor even more

On 05/04/2016 08:33 AM, Michal Privoznik wrote: > All these patches will be squashed into one, but I've split them > into multiple because of easier review. > > Michal Privoznik (4): > qemu_monitor_json: Follow refactor > qemu_monitor_json: Follow refactor > qemu_monitor_json: Follow

Re: [libvirt] [PATCH 06/17] genericxml2xml: add several graphics tests

On Fri, May 06, 2016 at 02:33:03PM +0200, Peter Krempa wrote: > On Thu, May 05, 2016 at 18:20:25 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > [...] > > > diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c > > index 70a5203..70ecd2d

Re: [libvirt] [PATCH] qemu: domain: Don't treat unknown storage type as not having backing chain

On 05/06/2016 09:48 AM, Peter Krempa wrote: > qemuDomainCheckDiskPresence has short-circuit code to skip the > determination of the disk backing chain for storage formats that can't > have backing volumes. The code treats VIR_STORAGE_FILE_NONE as not > having backing chain and skips the call to

Re: [libvirt] [PATCH 8/8] Revert "conf: Validate disk lun using correct types"

On 05/02/2016 10:32 AM, Peter Krempa wrote: > This reverts commit c79ebf53b5fe0a33bf407b3bcb49e3a27ec97eb4. > > We can't just add checks to the XML parser once we've accepted such > configuration in the past. > --- > src/conf/domain_conf.c | 22 -- >

Re: [libvirt] [PATCH 7/8] qemu: Reject invalid block copy targets for

On 05/02/2016 10:32 AM, Peter Krempa wrote: > Extract the relevant parts of the existing checker and reuse them for > blockcopy since copying to a non-block device creates an invalid > configuration. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1209802 > --- >

Re: [libvirt] [PATCH 6/8] qemu: command: Remove unnecessary label in qemuCheckDiskConfig

On 05/02/2016 10:32 AM, Peter Krempa wrote: > --- > src/qemu/qemu_command.c | 18 -- > 1 file changed, 8 insertions(+), 10 deletions(-) > ACK John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 5/8] conf: Kill now unused virDomainDiskSourceIsBlockType

On 05/02/2016 10:32 AM, Peter Krempa wrote: > --- > src/conf/domain_conf.c | 52 > > src/conf/domain_conf.h | 3 --- > src/libvirt_private.syms | 1 - > 3 files changed, 56 deletions(-) > ACK John -- libvir-list mailing list

Re: [libvirt] [PATCH 4/8] qemu: command: Use more appropriate checking function for block devices

On 05/02/2016 10:32 AM, Peter Krempa wrote: > In qemuCheckDiskConfig would now use virDomainDiskSourceIsBlockType just > as a glorified version of virStorageSourceIsBlockLocal that reports > error messages. Replace it with the latter including the message for > clarity. > --- >

Re: [libvirt] [PATCH 3/8] qemu: Support for iSCSI direct mapped volumes

On 05/02/2016 10:32 AM, Peter Krempa wrote: > Commit c820fbff9fbfe1f2549a5b60967496587f8d8bfc added support for iSCSI > disk as backing for . We would not use it for a disk > type="volume" with direct access mode which basically maps to direct > iSCSI usage. Fix it by adding the storage source

Re: [libvirt] [PATCH 2/8] lxc: Fix wrong error message on disk hotplug

On 05/02/2016 10:32 AM, Peter Krempa wrote: > Commit 36025c552 tried to improve error reporting for > but reused the code in LXC which doesn't care about the actual disk > type. The error messages would then contain a bogous hint that the > config for the 'lun' device is invalid which might not

Re: [libvirt] [PATCH 1/8] util: Replace virDomainDiskSourceIsBlockType with a new helper

On 05/02/2016 10:32 AM, Peter Krempa wrote: > For disks sources described by a libvirt volume we don't need to do a > complicated check since virStorageTranslateDiskSourcePool already > correctly determines the actual disk type. > > Replace the checks using a new accessor that does not

[libvirt] [PATCH] qemu: domain: Don't treat unknown storage type as not having backing chain

qemuDomainCheckDiskPresence has short-circuit code to skip the determination of the disk backing chain for storage formats that can't have backing volumes. The code treats VIR_STORAGE_FILE_NONE as not having backing chain and skips the call to qemuDomainDetermineDiskChain. This is wrong as

Re: [libvirt] [PATCH 06/17] genericxml2xml: add several graphics tests

On 05/06/2016 09:21 AM, Pavel Hrdina wrote: > On Fri, May 06, 2016 at 08:43:25AM -0400, Cole Robinson wrote: >> On 05/05/2016 12:20 PM, Pavel Hrdina wrote: >>> Signed-off-by: Pavel Hrdina >>> --- >>> .../generic-graphics-vnc-listen-attr-only.xml | 28 >>>

Re: [libvirt] [PATCH 06/17] genericxml2xml: add several graphics tests

On Fri, May 06, 2016 at 08:43:25AM -0400, Cole Robinson wrote: > On 05/05/2016 12:20 PM, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > .../generic-graphics-vnc-listen-attr-only.xml | 28 > > > >

Re: [libvirt] [PATCH 05/17] qemu_hotplug: cleanup qemuDomainChangeGraphics

On Fri, May 06, 2016 at 02:30:35PM +0200, Peter Krempa wrote: > On Thu, May 05, 2016 at 18:20:24 +0200, Pavel Hrdina wrote: > > In subject: This mostly improves error messages, so cleanup is not > really a spot-on description of this patch. Not exactly, the error messages are the same, but to

Re: [libvirt] [PATCH 02/17] qemu_process: move listen code out of qemuProcessSetupGraphics

On Fri, May 06, 2016 at 14:52:02 +0200, Pavel Hrdina wrote: > On Fri, May 06, 2016 at 02:10:10PM +0200, Peter Krempa wrote: > > On Thu, May 05, 2016 at 18:20:21 +0200, Pavel Hrdina wrote: > > > Move adding the config listen type=address if there is none in > > > qemuProcessPrepareDomain and move

Re: [libvirt] [PATCH 02/17] qemu_process: move listen code out of qemuProcessSetupGraphics

On Fri, May 06, 2016 at 02:10:10PM +0200, Peter Krempa wrote: > On Thu, May 05, 2016 at 18:20:21 +0200, Pavel Hrdina wrote: > > Move adding the config listen type=address if there is none in > > qemuProcessPrepareDomain and move check for multiple listens to > > qemuProcessStartValidate. > > > >

Re: [libvirt] [PATCH v2 4/4] qemu: command: Use -name guest= if available

On 05/06/2016 07:54 AM, John Ferlan wrote: > > > On 05/04/2016 10:56 AM, Cole Robinson wrote: >> -name guest= is the explicit parameter for passing a VM name. Using >> it is required to allow a VM with an '=' in the name >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1276485 >> --- >>

Re: [libvirt] [PATCH 06/17] genericxml2xml: add several graphics tests

On 05/05/2016 12:20 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > .../generic-graphics-vnc-listen-attr-only.xml | 28 > ...generic-graphics-vnc-listen-element-minimal.xml | 30 > ++ >

Re: [libvirt] [PATCH] domain_conf: fix migration/managedsave with usb keyboad

On Fri, May 06, 2016 at 14:19:39 +0200, Pavel Hrdina wrote: > Commint 36785c7e refactored the code for input devices but introduced a commit > bug that we removed all keyboard from migratable XML. We have to remove bug where > only implicit keyboards like PS2 or XEN. > > Signed-off-by: Pavel

Re: [libvirt] [PATCH 06/17] genericxml2xml: add several graphics tests

On Thu, May 05, 2016 at 18:20:25 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- [...] > diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c > index 70a5203..70ecd2d 100644 > --- a/tests/genericxml2xmltest.c > +++ b/tests/genericxml2xmltest.c

Re: [libvirt] [PATCH 05/17] qemu_hotplug: cleanup qemuDomainChangeGraphics

On Thu, May 05, 2016 at 18:20:24 +0200, Pavel Hrdina wrote: In subject: This mostly improves error messages, so cleanup is not really a spot-on description of this patch. > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_hotplug.c | 33 + >

Re: [libvirt] [PATCH 04/17] graphics: generate fake ports also for tests

On Thu, May 05, 2016 at 18:20:23 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_driver.c | 12 > src/qemu/qemu_process.c | 13 > + >

[libvirt] [PATCH] domain_conf: fix migration/managedsave with usb keyboad

Commint 36785c7e refactored the code for input devices but introduced a bug that we removed all keyboard from migratable XML. We have to remove only implicit keyboards like PS2 or XEN. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 6 -- 1 file changed, 4

Re: [libvirt] [PATCH 03/17] qemu_process: handle port allocation for VNC the same way as for Spice

On Thu, May 05, 2016 at 18:20:22 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_driver.c | 6 +++--- > src/qemu/qemu_process.c | 29 - > src/qemu/qemu_process.h | 3 +++ > 3 files changed, 30 insertions(+), 8

Re: [libvirt] [PATCH v2 0/4] qemu: handle ',' and '=' in VM name

On 05/06/2016 07:54 AM, John Ferlan wrote: > > > On 05/04/2016 10:56 AM, Cole Robinson wrote: >> This series adds qemu cli comma escaping to several places that >> are dependent on the VM name, to enable names with embedded commas. >> >> Patch 4 makes use of qemu -name guest=X value to allow

Re: [libvirt] [PATCH v2 3/4] qemu: command: escape commas in chardev socket path

On 05/06/2016 07:54 AM, John Ferlan wrote: > > > On 05/04/2016 10:56 AM, Cole Robinson wrote: >> After this, a default virt-manager VM will startup with a comma >> in the VM name: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=639926 >> --- >> src/qemu/qemu_command.c

Re: [libvirt] [PATCH 02/17] qemu_process: move listen code out of qemuProcessSetupGraphics

On Thu, May 05, 2016 at 18:20:21 +0200, Pavel Hrdina wrote: > Move adding the config listen type=address if there is none in > qemuProcessPrepareDomain and move check for multiple listens to > qemuProcessStartValidate. > > Signed-off-by: Pavel Hrdina > --- >

Re: [libvirt] [PATCH] virCgroupValidateMachineGroup: Reflect change in CGroup struct naming

On 05/05/2016 11:56 AM, Michal Privoznik wrote: > Fron c3bd0019c0e on instead of creating the following path for > cgroups: > > /sys/fs/cgroupX/$name.libvirt-$driver > > we generate rather more verbose one: > > /sys/fs/cgroupX/$driver-$id-$name.libvirt-$driver > > where $name is optional

Re: [libvirt] [PATCH v2 3/4] qemu: command: escape commas in chardev socket path

On 05/04/2016 10:56 AM, Cole Robinson wrote: > After this, a default virt-manager VM will startup with a comma > in the VM name: > > https://bugzilla.redhat.com/show_bug.cgi?id=639926 > --- > src/qemu/qemu_command.c | 9 - >

Re: [libvirt] [PATCH v2 0/4] qemu: handle ',' and '=' in VM name

On 05/04/2016 10:56 AM, Cole Robinson wrote: > This series adds qemu cli comma escaping to several places that > are dependent on the VM name, to enable names with embedded commas. > > Patch 4 makes use of qemu -name guest=X value to allow names with > '=' in them. > >

Re: [libvirt] [PATCH v2 4/4] qemu: command: Use -name guest= if available

On 05/04/2016 10:56 AM, Cole Robinson wrote: > -name guest= is the explicit parameter for passing a VM name. Using > it is required to allow a VM with an '=' in the name > > https://bugzilla.redhat.com/show_bug.cgi?id=1276485 > --- > src/qemu/qemu_capabilities.c | 2 ++

Re: [libvirt] [PATCH v5 0/2] qemu: Support for QXL heads

On Fri, May 06, 2016 at 01:27:15PM +0200, Pavel Hrdina wrote: > On Thu, May 05, 2016 at 07:18:51PM -0400, John Ferlan wrote: > > [...] > > > Been sitting on list for a while > > > > Obviously I think you know you have to update to top of tree > > > > Would be nice to perhaps add a few

Re: [libvirt] [PATCH v5 0/2] qemu: Support for QXL heads

On Thu, May 05, 2016 at 07:18:51PM -0400, John Ferlan wrote: [...] > Been sitting on list for a while > > Obviously I think you know you have to update to top of tree > > Would be nice to perhaps add a few intro comments to > qemuMigratePrepareDomain at least with respect to what the

Re: [libvirt] [PATCH 11/12] qemucapabilitiestest: Add tests for aarch64 and ppc64le

On Fri, May 06, 2016 at 12:29:34 +0200, Peter Krempa wrote: > On Fri, May 06, 2016 at 12:23:04 +0200, Jiri Denemark wrote: > > On Fri, May 06, 2016 at 10:02:12 +0200, Peter Krempa wrote: > > > On Thu, May 05, 2016 at 18:42:13 +0200, Jiri Denemark wrote: > > > > Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH 11/12] qemucapabilitiestest: Add tests for aarch64 and ppc64le

On Fri, May 06, 2016 at 06:39:15 -0400, John Ferlan wrote: > > > On 05/06/2016 06:29 AM, Peter Krempa wrote: > > On Fri, May 06, 2016 at 12:23:04 +0200, Jiri Denemark wrote: > >> On Fri, May 06, 2016 at 10:02:12 +0200, Peter Krempa wrote: > >>> On Thu, May 05, 2016 at 18:42:13 +0200, Jiri

Re: [libvirt] [PATCH] cpu: add ABM to Haswell* and Broadwell* CPU models

On Fri, May 06, 2016 at 17:53:04 +0800, Eli Qiao wrote: > Corresponding QEMU commits: > becb66673ec30cb604926d247ab9449a60ad8b11 > > Signed-off-by: Eli Qiao > --- > src/cpu/cpu_map.xml | 4 > 1 file changed, 4 insertions(+) NACK. We don't add features to models

Re: [libvirt] [PATCH 11/12] qemucapabilitiestest: Add tests for aarch64 and ppc64le

On 05/06/2016 06:29 AM, Peter Krempa wrote: > On Fri, May 06, 2016 at 12:23:04 +0200, Jiri Denemark wrote: >> On Fri, May 06, 2016 at 10:02:12 +0200, Peter Krempa wrote: >>> On Thu, May 05, 2016 at 18:42:13 +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark >>>

Re: [libvirt] [PATCH 11/12] qemucapabilitiestest: Add tests for aarch64 and ppc64le

On Fri, May 06, 2016 at 12:23:04 +0200, Jiri Denemark wrote: > On Fri, May 06, 2016 at 10:02:12 +0200, Peter Krempa wrote: > > On Thu, May 05, 2016 at 18:42:13 +0200, Jiri Denemark wrote: > > > Signed-off-by: Jiri Denemark > > > > Please explain the difference between

Re: [libvirt] [PATCH 11/12] qemucapabilitiestest: Add tests for aarch64 and ppc64le

On Fri, May 06, 2016 at 10:02:12 +0200, Peter Krempa wrote: > On Thu, May 05, 2016 at 18:42:13 +0200, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > Please explain the difference between caps_2.6.0-1.aarch64.replies > caps_2.6.0-2.aarch64.replies. At least the

[libvirt] [PATCH] cpu: add ABM to Haswell* and Broadwell* CPU models

Corresponding QEMU commits: becb66673ec30cb604926d247ab9449a60ad8b11 Signed-off-by: Eli Qiao --- src/cpu/cpu_map.xml | 4 1 file changed, 4 insertions(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 0b6d424..d9eb729 100644 ---

Re: [libvirt] [PATCH 01/17] graphics: use enums instead of int

On Thu, May 05, 2016 at 18:20:20 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 2 ++ > src/conf/domain_conf.h | 14 +++--- > src/libxl/libxl_conf.c | 8 > src/qemu/qemu_command.c | 14 +- > 4 files

Re: [libvirt] [PATCH 12/12] domaincapstest: Add tests for QEMU 2.6

On Thu, May 05, 2016 at 18:42:14 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > .../domaincaps-qemu_2.6.0-1.xml| 63 > .../domaincaps-qemu_2.6.0-2.xml| 63 >

Re: [libvirt] [PATCH 11/12] qemucapabilitiestest: Add tests for aarch64 and ppc64le

On Thu, May 05, 2016 at 18:42:13 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark Please explain the difference between caps_2.6.0-1.aarch64.replies caps_2.6.0-2.aarch64.replies. At least the difference how they were obtained. > --- >

Re: [libvirt] [PATCH 10/12] domaincapstest: Use default machine type

On Thu, May 05, 2016 at 18:42:12 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark A little bit of explanation would be preferred. > --- > tests/domaincapsschemadata/domaincaps-qemu_1.6.50-1.xml | 2 +- > tests/domaincapstest.c |

Re: [libvirt] [PATCH 09/12] qemucapabilitiestest: Rename *.caps to *.xml

On Thu, May 05, 2016 at 18:42:11 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- ACK signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 08/12] qemucapabilitiestest: Test all capabilities

On Thu, May 05, 2016 at 18:42:10 +0200, Jiri Denemark wrote: > Enhance the test to cover all capabilities we probe for rather than > testing the flags only. > > Signed-off-by: Jiri Denemark > --- [...] > diff --git a/tests/qemucapabilitiestest.c

Re: [libvirt] [PATCH 07/12] qemucapabilitiestest: Reorder flags in caps files

On Thu, May 05, 2016 at 18:42:09 +0200, Jiri Denemark wrote: > The flags should follow the order in which they are defined in > virQEMUCaps enum. > > Signed-off-by: Jiri Denemark > --- > tests/qemucapabilitiesdata/caps_1.5.3-1.x86_64.caps | 2 +- >

Re: [libvirt] [PATCH 06/12] qemucapabilitiestest: Reindent *.caps files

On Thu, May 05, 2016 at 18:42:08 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- ACK signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 05/12] qemucapabilitiestest: Uses consistent names

On Thu, May 05, 2016 at 18:42:07 +0200, Jiri Denemark wrote: > In other tests we use "expected" and "actual" to refer to the expected > outcome of the tested API and the result we got, respectively. > > Signed-off-by: Jiri Denemark > --- > tests/qemucapabilitiestest.c | 31

Re: [libvirt] [PATCH 04/12] qemu: Export caps cache APIs for tests

On Thu, May 05, 2016 at 18:42:06 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_capabilities.c | 4 ++-- > src/qemu/qemu_capspriv.h | 9 + > 2 files changed, 11 insertions(+), 2 deletions(-) ACK signature.asc Description:

Re: [libvirt] [PATCH 03/12] qemu: Separate formatting from saving into caps cache

On Thu, May 05, 2016 at 18:42:05 +0200, Jiri Denemark wrote: > We will need to use the formatter directly for testing QEMU capabilities > code. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_capabilities.c | 32 ++-- > 1 file changed, 22

Re: [libvirt] [PATCH 02/12] qemucapabilitiestest: Prepare for testing non-x86_64 archs

On Thu, May 05, 2016 at 18:42:04 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- ACK signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 01/12] tests: Refactor domaincapstest

On Thu, May 05, 2016 at 18:42:03 +0200, Jiri Denemark wrote: > The test was just a big mess passing callbacks and their data through > data for another callback. > > Signed-off-by: Jiri Denemark > --- > tests/domaincapstest.c | 176 >

Re: [libvirt] [PATCH] virCgroupValidateMachineGroup: Reflect change in CGroup struct naming

On Thu, May 05, 2016 at 05:56:55PM +0200, Michal Privoznik wrote: > Fron c3bd0019c0e on instead of creating the following path for > cgroups: > > /sys/fs/cgroupX/$name.libvirt-$driver > > we generate rather more verbose one: > > /sys/fs/cgroupX/$driver-$id-$name.libvirt-$driver > > where