Re: [libvirt] Availability of libvirt-2.0.0-rc2

On Wed, Jun 29, 2016 at 05:31:12PM +0200, Daniel Veillard wrote: >So as planned I just pushed signed tarball and rpms and tagged the > Release Candidate 2 in git, it's available from the usual place: > >ftp://libvirt.org/libvirt/ > > The rc2 seems to work for me with my limited testing,

Re: [libvirt] [PATCH 0/2] option to disable default gateway in IPv6 RA

On 06/30/2016 08:02 AM, Maxim Perevedentsev wrote: Laine, many thanks for such a detailed reply. On 06/29/2016 08:55 PM, Laine Stump wrote: * Beyond that, I think it would make more sense to have the option defined in the element for the IPv6 address rather than at the toplevel Why may we

Re: [libvirt] [PATCH 0/5] Some USB hotplug and alias cleanups

On 06/29/2016 05:37 PM, John Ferlan wrote: > A post 2.0.0 type adjustment... > > While answering a question for bz 1289391 regarding the USB path - I figured > that making the code be more the virtio and scsi code paths would at least > have a better look'n'feel. Then I tripped in to the alias

Re: [libvirt] [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

On Thu, Jun 30, 2016 at 09:32:04AM +0200, David Hildenbrand wrote: > > Are there any further comments, especially on patches 23-25, introducing new > QOM interfaces? > > Also, if anybody is planning to look into this, please speak up :) I am still planning to look at this (I didn't look at the

Re: [libvirt] [PATCH 2/2] Add support for preallocated memory - xml2argv

> -Original Message- > From: Safka, JaroslavX > Sent: Thursday, June 23, 2016 2:47 PM > To: Martin Kletzander > Cc: libvir-list@redhat.com; Mooney, Sean K ; > Ptacek, MichalX > Subject: RE: [libvirt] [PATCH 2/2]

Re: [libvirt] [PATCH] dist: Speed up distribution compression

On Thu, Jun 30, 2016 at 04:10:01PM +0200, Martin Kletzander wrote: > This almost reverts b7200d723648. The size is increased from 11M to 13M > and the compression is sped up from 2 minutes to 17 seconds. The > compression level is removed because -9 doesn't allow multiple threads > to be

[libvirt] [PATCH] dist: Speed up distribution compression

This almost reverts b7200d723648. The size is increased from 11M to 13M and the compression is sped up from 2 minutes to 17 seconds. The compression level is removed because -9 doesn't allow multiple threads to be spawned. Effectively speeds up distcheck as well. Signed-off-by: Martin

Re: [libvirt] [PATCH] A description error about libvirtd manpage

On Thu, Jun 30, 2016 at 07:32:53PM +0800, Jingjing Shao wrote: To fix the bug The description of --timeout should be updated in libvirtd manpage https://bugzilla.redhat.com/show_bug.cgi?id=1325066 According to the description, delete the part: "Be aware that resources such as autostart

[libvirt] RFC: add recreate option to domain events conf

Hi, all. Does it make sense to anybody else that rebooting and resetting a persistent domain from outside or from inside should bring upon pending configuration changes? For this purpose we can add another option to on_reboot and other events, say 'recreate'. From technical POV qemu has enough

Re: [libvirt] [PATCH] conf: Don't free the constructed string in virDomainGetBlkioParametersAssignFromDef

On Thu, Jun 30, 2016 at 02:39:09PM +0200, Peter Krempa wrote: virTypedParameterAssign steals the string rather than copying it into the typed parameter and thus freeing it leads to a crash when attempting to serialize the results. This was introduced in commit 9f50f6e2 and later made an

Re: [libvirt] [PATCH v2] conf: def: Avoid unnecessary allocation of 'perf' events definition

On Thu, Jun 30, 2016 at 09:45:05AM +0200, Peter Krempa wrote: Some code paths already assume that it is allocated since it was always allocated by virDomainPerfDefParseXML. Make it member of virDomainDef directly so that we don't have to allocate it all the time. This fixes crash when

[libvirt] [PATCH] conf: Don't free the constructed string in virDomainGetBlkioParametersAssignFromDef

virTypedParameterAssign steals the string rather than copying it into the typed parameter and thus freeing it leads to a crash when attempting to serialize the results. This was introduced in commit 9f50f6e2 and later made an universal helper in 32e6339c. Resolves:

Re: [libvirt] [PATCH 0/2] option to disable default gateway in IPv6 RA

Laine, many thanks for such a detailed reply. On 06/29/2016 08:55 PM, Laine Stump wrote: * Beyond that, I think it would make more sense to have the option defined in the element for the IPv6 address rather than at the toplevel Why may we need it? We are talking about isolated networks, so

Re: [libvirt] [PATCH] qemu: Avoid needless copies of static strings

On 30/06/16 10:03, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_hotplug.c | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c > index bf6430d..f88520f

Re: [libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

On Thu, Jun 30, 2016 at 12:34 PM +0200, Peter Krempa wrote: >> qemuDomainObjPrivatePtr priv = vm->privateData; >> +virDomainControllerDefPtr cont = NULL; > > This variable isn't necessary. >> +/* Let's make sure the disk has a controller defined and loaded before

Re: [libvirt] [PATCH 0/3] qemu: Fix auto-generation of SCSI controllers for hot-plugged SCSI disks and add tests

On Thu, Jun 30, 2016 at 10:57:16 +0200, Kashyap Chamarthy wrote: > On Thu, Jun 30, 2016 at 09:44:47AM +0100, Daniel P. Berrange wrote: > > On Mon, Jun 27, 2016 at 04:43:45PM +0200, Marc Hartmayer wrote: > > > This patch series fixes the auto-generation of SCSI controllers for > > > hot-plugged >

[libvirt] [PATCH] A description error about libvirtd manpage

To fix the bug The description of --timeout should be updated in libvirtd manpage https://bugzilla.redhat.com/show_bug.cgi?id=1325066 According to the description, delete the part: "Be aware that resources such as autostart networks will result in never reaching the timeout, even when there are

Re: [libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

On Mon, Jun 27, 2016 at 04:43:46PM +0200, Marc Hartmayer wrote: > The commit "qemu: hot-plug: Assume support for -device in > qemuDomainAttachSCSIDisk" dropped the code for the automatic SCSI > controller creation used in SCSI disk hot-plugging. If we are > hot-plugging a SCSI disk to a domain and

Re: [libvirt] libvirt on up-for-grabs.net?

On Thu, 2016-06-30 at 10:27 +0100, Daniel P. Berrange wrote: > > You need to set the upforgrabs/name property with the label > > that your GitHub issues are tagged with; we could then have > > zero GitHub issues tagged with that label, but then the > > up-for-grabs website would show a issue count

Re: [libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

On Mon, Jun 27, 2016 at 16:43:46 +0200, Marc Hartmayer wrote: > The commit "qemu: hot-plug: Assume support for -device in > qemuDomainAttachSCSIDisk" dropped the code for the automatic SCSI > controller creation used in SCSI disk hot-plugging. If we are > hot-plugging a SCSI disk to a domain and

Re: [libvirt] [PATCH 2/3] qemu: SCSI hostdev hot-plug: Fix automatic creation of SCSI controllers

On Mon, Jun 27, 2016 at 16:43:47 +0200, Marc Hartmayer wrote: > Ensure that the given controller and all controllers with a smaller > index exist; there must not be any missing index in between. > > Reviewed-by: Boris Fiuczynski > Reviewed-by: Bjoern Walk

[libvirt] [PATCH v2] Introduce Smack security driver for Libvirt

Thanks Daniel and Laine for the feedback so far. Below is a brief list of changes since v1 as well as the patch which should be complete this time. For others, introduction and background can be found here along with latest response:

[libvirt] [PATCH] qemu: don't set fake reboot if it will not be used

The use case is similar to e2b86f580. First call shutdown with reboot semantics in agent mode. As a result fake reboot flag is set. Next issue shutdown from guest and you will get reboot due to fake reboot flag set. Signed-off-by: Nikolay Shirokovskiy ---

Re: [libvirt] libvirt on up-for-grabs.net?

On Thu, Jun 30, 2016 at 11:04:47AM +0200, Andrea Bolognani wrote: > On Thu, 2016-06-30 at 09:20 +0100, Daniel P. Berrange wrote: > > On Thu, Jun 30, 2016 at 10:17:10AM +0200, Andrea Bolognani wrote: > > > I just bumped into this website: > > >  > > >   http://up-for-grabs.net/ > > >  > > > I

Re: [libvirt] [PATCH] docs: Warn against locked memory limit too high

On 28/06/16 14:01, Jiri Denemark wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1046833 > > Signed-off-by: Jiri Denemark > --- > docs/formatdomain.html.in | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/docs/formatdomain.html.in

Re: [libvirt] [PATCH 0/8] Fix build with clang

On Wed, Jun 29, 2016 at 07:37:03PM +0200, Andrea Bolognani wrote: On Wed, 2016-06-29 at 15:53 +0200, Ján Tomko wrote: I am not proud of the first patch.   I wrote the temporary bump for -Wframe-larger-than thinking splitting it out would be too intrusive for the freeze, but it did not turn out

Re: [libvirt] libvirt on up-for-grabs.net?

On Thu, 2016-06-30 at 09:20 +0100, Daniel P. Berrange wrote: > On Thu, Jun 30, 2016 at 10:17:10AM +0200, Andrea Bolognani wrote: > > I just bumped into this website: > >  > >   http://up-for-grabs.net/ > >  > > I wonder if we could try to get our Bite-sized Tasks[1] in > > the list... > >  > > Of

Re: [libvirt] [PATCH 0/3] qemu: Fix auto-generation of SCSI controllers for hot-plugged SCSI disks and add tests

On Thu, Jun 30, 2016 at 09:44:47AM +0100, Daniel P. Berrange wrote: > On Mon, Jun 27, 2016 at 04:43:45PM +0200, Marc Hartmayer wrote: > > This patch series fixes the auto-generation of SCSI controllers for > > hot-plugged > > SCSI disks and hot-plugged SCSI hostdevs. > > > > Additionally this

Re: [libvirt] [PATCH 0/3] qemu: Fix auto-generation of SCSI controllers for hot-plugged SCSI disks and add tests

On Mon, Jun 27, 2016 at 04:43:45PM +0200, Marc Hartmayer wrote: > This patch series fixes the auto-generation of SCSI controllers for > hot-plugged > SCSI disks and hot-plugged SCSI hostdevs. > > Additionally this patch series adds test cases for the auto-generation of SCSI > controllers to the

Re: [libvirt] [PATCH] qemu: Let empty default VNC password work as documented

On Thu, Jun 30, 2016 at 09:15:25 +0100, Daniel P. Berrange wrote: > On Thu, Jun 30, 2016 at 09:28:24AM +0200, Jiri Denemark wrote: > > CVE-2016-5008 > > > > Setting an empty graphics password is documented as a way to disable > > VNC/SPICE access, but QEMU does not always behaves like that. VNC

Re: [libvirt] [PATCH 3/3] tests: Add test cases for SCSI disk hot-plug with QEMU

On Mon, Jun 27, 2016 at 04:43:48PM +0200, Marc Hartmayer wrote: > Verify that SCSI controllers get created automatically when a SCSI disk > is hot-plugged to a domain that doesn't have a matching SCSI controller > defined already. > > Reviewed-by: Boris Fiuczynski >

Re: [libvirt] [PATCH 2/3] qemu: SCSI hostdev hot-plug: Fix automatic creation of SCSI controllers

On Mon, Jun 27, 2016 at 04:43:47PM +0200, Marc Hartmayer wrote: > Ensure that the given controller and all controllers with a smaller > index exist; there must not be any missing index in between. > > Reviewed-by: Boris Fiuczynski > Reviewed-by: Bjoern Walk

Re: [libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

On Mon, Jun 27, 2016 at 04:43:46PM +0200, Marc Hartmayer wrote: > The commit "qemu: hot-plug: Assume support for -device in > qemuDomainAttachSCSIDisk" dropped the code for the automatic SCSI > controller creation used in SCSI disk hot-plugging. If we are > hot-plugging a SCSI disk to a domain and

Re: [libvirt] libvirt on up-for-grabs.net?

On Thu, Jun 30, 2016 at 10:17:10AM +0200, Andrea Bolognani wrote: > I just bumped into this website: > >   http://up-for-grabs.net/ > > I wonder if we could try to get our Bite-sized Tasks[1] in > the list... > > Of course we don't use GitHub for pull requests or issue > tracking, but we could

Re: [libvirt] regression on virsh capabilities ?

On Thu, Jun 30, 2016 at 04:13:11PM +0800, Eli Qiao wrote: > hi guys. > > I build libvirt from source(assume the latest is 2.0.0) but I get wrong > virsh capabilities, see detail on. > https://bugzilla.redhat.com/show_bug.cgi?id=1347458 > > This issue is not found if I use 1.3.1(from ubuntu

[libvirt] libvirt on up-for-grabs.net?

I just bumped into this website:   http://up-for-grabs.net/ I wonder if we could try to get our Bite-sized Tasks[1] in the list... Of course we don't use GitHub for pull requests or issue tracking, but we could create a dummy issue called "Look at the Bite-sized Tasks wiki page" that contains a

Re: [libvirt] [PATCH] qemu: Let empty default VNC password work as documented

On Thu, Jun 30, 2016 at 09:28:24AM +0200, Jiri Denemark wrote: > CVE-2016-5008 > > Setting an empty graphics password is documented as a way to disable > VNC/SPICE access, but QEMU does not always behaves like that. VNC would > happily accept the empty password. Let's enforce the behavior by

[libvirt] regression on virsh capabilities ?

hi guys. I build libvirt from source(assume the latest is 2.0.0) but I get wrong virsh capabilities, see detail on. https://bugzilla.redhat.com/show_bug.cgi?id=1347458 This issue is not found if I use 1.3.1(from ubuntu 16.04) Is this an regression or the issue is bring out by my manually

[libvirt] [PATCH] qemu: Avoid needless copies of static strings

Signed-off-by: Jiri Denemark --- src/qemu/qemu_hotplug.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index bf6430d..f88520f 100644 --- a/src/qemu/qemu_hotplug.c +++

Re: [libvirt] Availability of libvirt-2.0.0-rc2

Hi Daniel, qemu scsi disk hotplug is broken. A series with patches for a fix had been sent to the mailing list. https://www.redhat.com/archives/libvir-list/2016-June/msg02053.html I suggest to review and include them into 2.0.0. On 06/29/2016 05:31 PM, Daniel Veillard wrote: So as planned

[libvirt] [PATCH v2] conf: def: Avoid unnecessary allocation of 'perf' events definition

Some code paths already assume that it is allocated since it was always allocated by virDomainPerfDefParseXML. Make it member of virDomainDef directly so that we don't have to allocate it all the time. This fixes crash when attempting to connect to an existing process via virDomainQemuAttach

Re: [libvirt] [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

Are there any further comments, especially on patches 23-25, introducing new QOM interfaces? Also, if anybody is planning to look into this, please speak up :) Otherwise it might make sense to put this onto the next KVM call agenda. David > This is our second attempt to implement CPU models

[libvirt] [PATCH] qemu: Let empty default VNC password work as documented

CVE-2016-5008 Setting an empty graphics password is documented as a way to disable VNC/SPICE access, but QEMU does not always behaves like that. VNC would happily accept the empty password. Let's enforce the behavior by setting password expiration to "now".

Re: [libvirt] [libvirt-test-API][PATCH] Modify makefile to add check option.

- Original Message - > From: "Liping Cheng" > To: "Ruifeng Bian" > Cc: libvir-list@redhat.com > Sent: Wednesday, June 29, 2016 6:16:23 PM > Subject: Re: [libvirt] [libvirt-test-API][PATCH] Modify makefile to add check > option. > > ACK > > >

Re: [libvirt] [PATCH] docs: remove outdated suggestion to make patches with "diff -urp" or "git diff"

On Wed, Jun 29, 2016 at 15:40:42 -0400, Laine Stump wrote: > I can't think of any good reason to do either of those, and having the > examples there will just lead to unusable patch emails from people who > can't be bothered to read the entire page. > --- > > I'm sure there are other problems

Re: [libvirt] [PATCH] vz: fixed null-pointer dereference in applying graphic params

On 29.06.2016 20:04, Olga Krishtal wrote: > Signed-off-by: Olga Krishtal > --- > src/vz/vz_sdk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c > index f4c2b3b..903440b 100644 > --- a/src/vz/vz_sdk.c > +++ b/src/vz/vz_sdk.c

Re: [libvirt] [PATCH] vz: fixed null-pointer dereference in applying graphic params

On 29.06.2016 20:23, Olga Krishtal wrote: > Signed-off-by: Olga Krishtal > --- > src/vz/vz_sdk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c > index f4c2b3b..848bfb9 100644 > --- a/src/vz/vz_sdk.c > +++ b/src/vz/vz_sdk.c