Re: [libvirt] [PATCH] qemu: getAutoDumpPath() return value should be dumpfile not domname.

On 13.07.2016 06:39, Yan Fu wrote: > Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=1354238 > --- > src/qemu/qemu_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index f8d9afe..55a5404 100644 > ---

[libvirt] [PATCH] qemu: getAutoDumpPath() return value should be dumpfile not domname.

Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=1354238 --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f8d9afe..55a5404 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@

Re: [libvirt] [PATCH V2] systemd: fix ready notification on abstract socket

Daniel P. Berrange wrote: > On Tue, Jul 12, 2016 at 11:07:10AM -0600, Jim Fehlig wrote: >> At least with systemd v210, NOTIFY_SOCKET is abstact, e.g. >> @/org/freedesktop/systemd1/notify. sendmsg() fails on such a socket >> with "Connection refused". The unix(7) man page contains the following >>

[libvirt] build failure on 32-bit

I hit an interesting failure on my 32-bit F24 machine: In file included from ../../src/util/virconf.c:32:0: ../../src/util/virconf.c: In function 'virConfGetValueSSizeT': ../../src/util/virconf.c:1269:26: error: format '%zd' expects argument of type 'signed size_t', but argument 9 has type 'long

Re: [libvirt] [PATCH V2] systemd: fix ready notification on abstract socket

On Tue, Jul 12, 2016 at 11:07:10AM -0600, Jim Fehlig wrote: > At least with systemd v210, NOTIFY_SOCKET is abstact, e.g. > @/org/freedesktop/systemd1/notify. sendmsg() fails on such a socket > with "Connection refused". The unix(7) man page contains the following > details wrt abstract socket

Re: [libvirt] [PATCH] Make really sure we don't access non-existing vCPUs

On Tue, Jul 12, 2016 at 06:24:01PM +0200, Peter Krempa wrote: On Tue, Jul 12, 2016 at 17:54:03 +0200, Martin Kletzander wrote: On Tue, Jul 12, 2016 at 03:01:57PM +0200, Peter Krempa wrote: >On Tue, Jul 12, 2016 at 13:44:10 +0200, Martin Kletzander wrote: [...] >> I could've pushed this as a

[libvirt] [PATCH V2] systemd: fix ready notification on abstract socket

At least with systemd v210, NOTIFY_SOCKET is abstact, e.g. @/org/freedesktop/systemd1/notify. sendmsg() fails on such a socket with "Connection refused". The unix(7) man page contains the following details wrt abstract socket addresses abstract: an abstract socket address is distinguished (from a

Re: [libvirt] [PATCH] systemd: fix ready notification on abstract socket

Daniel P. Berrange wrote: > On Mon, Jul 11, 2016 at 05:35:03PM -0600, Jim Fehlig wrote: >> At least with systemd v210, NOTIFY_SOCKET is abstact, e.g. >> @/org/freedesktop/systemd1/notify. sendmsg() fails on such a socket >> with "Connection refused". The unix(7) man page contains the following >>

Re: [libvirt] [PATCH] Make really sure we don't access non-existing vCPUs

On Tue, Jul 12, 2016 at 17:54:03 +0200, Martin Kletzander wrote: > On Tue, Jul 12, 2016 at 03:01:57PM +0200, Peter Krempa wrote: > >On Tue, Jul 12, 2016 at 13:44:10 +0200, Martin Kletzander wrote: [...] > >> I could've pushed this as a build breaker, but I'm not really sure > >> everyone will

Re: [libvirt] [PATCH] esx: Fetch snapshot info directly for filtering

On 12.07.2016 05:20, Tomáš Golembiovský wrote: > When fetching domains with virConnectListAllDomains() and when filtering > by snapshot existence is requested the ESX driver first lists all the > domains and then check one-by-one for snapshot existence. This process > takes unnecessarily long

Re: [libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw

On 07/12/2016 03:27 AM, Martin Kletzander wrote: > On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote: >> We can't mock tests on Mingw, which lacks dlopen() and friends; >> follow the paradigms used in other mock files of conditionally >> compiling nothing when not building for Linux. >>

Re: [libvirt] [PATCH] Make really sure we don't access non-existing vCPUs

On Tue, Jul 12, 2016 at 03:01:57PM +0200, Peter Krempa wrote: On Tue, Jul 12, 2016 at 13:44:10 +0200, Martin Kletzander wrote: MinGW complained that we might be dereferencing a NULL pointer. While ^^ Does anybody use that? Well, if nobody uses that, feel free to send a patch removing all

Re: [libvirt] [PATCH] examples: If parameters count is zero we have nothing to do

On 12.07.2016 13:49, Marc Hartmayer wrote: > On Sat, Jul 09, 2016 at 11:02 AM +0200, Michal Privoznik > wrote: >> On 06.07.2016 15:47, Marc Hartmayer wrote: >>> The virDomainGetCPUStats() API contract permits nparams == >>> 0. print_cpu_usage() assumes nparams > 0 because

Re: [libvirt] [PATCH v2] qemu: add a max_core setting to qemu.conf for core dump size

On Tue, Jul 12, 2016 at 01:36:37PM +0100, Daniel P. Berrange wrote: On Tue, Jul 12, 2016 at 12:53:18PM +0200, Martin Kletzander wrote: On Tue, Jul 12, 2016 at 10:56:53AM +0100, Daniel P. Berrange wrote: > On Tue, Jul 12, 2016 at 11:38:22AM +0200, Martin Kletzander wrote: > > On Tue, Jul 12,

Re: [libvirt] [PATCH 2/2] build: drop hack for old mingw ssize_t

On 07/12/2016 02:05 AM, Daniel P. Berrange wrote: > On Mon, Jul 11, 2016 at 09:55:01PM -0600, Eric Blake wrote: >> The old 32-bit-only mingw project had a mismatch in its >> that omitted ssize_t, but where size_t was a different rank than >> int. But now that mingw64 (both 32- and 64-bit) is the

[libvirt] [PATCH] libvirt.spec.in: require systemd-container on >= f24

The systemd-machined tools libvirt uses were split into a systemd-container RPM. Without depending on this, libvirt may silently fallback to the non-systemd cgroup impl which is not desirable. Signed-off-by: Daniel P. Berrange --- libvirt.spec.in | 6 ++ 1 file changed,

Re: [libvirt] [PATCH 0/4] test: have default URI use file parsing helpers

On 07/01/2016 07:37 AM, Cole Robinson wrote: > This series reworks test:///default open handling to use the same > XML parsing helpers that a non-default test://$PATH open uses. > Saves some code, and makes it easier to extend test:///default, > for example in patch #4 which we want for testing

Re: [libvirt] libvirt on up-for-grabs.net?

On Thu, 2016-06-30 at 11:04 +0200, Andrea Bolognani wrote: > Does something like the following look reasonable? If it > does, I'll take care of submitting it. >  > name: libvirt > desc: The virtualization API > site: https://libvirt.org/ > tags: > - api > - c > - cross-platform > - library > - oss

[libvirt] [PATCH v2] qemuhotplugtest: Add tests for ccw devices

These are a few simple and one complex testcases. The simple ones test attaching and detaching ccw devices with both implicitly and explicitly stated addresses. In the complex one, attaching and detaching a device should make the address free to reuse. I have plan to rework the address handling,

Re: [libvirt] [PATCH] Make really sure we don't access non-existing vCPUs

On Tue, Jul 12, 2016 at 13:44:10 +0200, Martin Kletzander wrote: > MinGW complained that we might be dereferencing a NULL pointer. While ^^ Does anybody use that? > that's most probably not going to be true (now), the logic certainly > allows for that and we might actually do this a lot in the

Re: [libvirt] [PATCH v2] qemu: add a max_core setting to qemu.conf for core dump size

On Tue, Jul 12, 2016 at 12:53:18PM +0200, Martin Kletzander wrote: > On Tue, Jul 12, 2016 at 10:56:53AM +0100, Daniel P. Berrange wrote: > > On Tue, Jul 12, 2016 at 11:38:22AM +0200, Martin Kletzander wrote: > > > On Tue, Jul 12, 2016 at 10:12:36AM +0100, Daniel P. Berrange wrote: > > > >

Re: [libvirt] [PATCH] examples: If parameters count is zero we have nothing to do

On Sat, Jul 09, 2016 at 11:02 AM +0200, Michal Privoznik wrote: > On 06.07.2016 15:47, Marc Hartmayer wrote: >> The virDomainGetCPUStats() API contract permits nparams == >> 0. print_cpu_usage() assumes nparams > 0 because the domtop example >> application isn't very useful

[libvirt] [PATCH] Make really sure we don't access non-existing vCPUs

MinGW complained that we might be dereferencing a NULL pointer. While that's most probably not going to be true (now), the logic certainly allows for that and we might actually do this a lot in the future with sparse vcpu mapping. ../../src/conf/domain_conf.c: In function

Re: [libvirt] [PATCH v2] storage: dir: adapts .wipeVol for ploop volumes

On Mon, Jun 27, 2016 at 06:03:38PM +0300, Olga Krishtal wrote: The modification of .volWipe callback wipes ploop volume using one of given wiping algorithm: dod, nnsa, etc. However, in case of ploop volume we need to reinitialize root.hds and DiskDescriptor.xml. v2: - added check on ploop

Re: [libvirt] [PATCH v2] qemu: add a max_core setting to qemu.conf for core dump size

On Tue, Jul 12, 2016 at 10:56:53AM +0100, Daniel P. Berrange wrote: On Tue, Jul 12, 2016 at 11:38:22AM +0200, Martin Kletzander wrote: On Tue, Jul 12, 2016 at 10:12:36AM +0100, Daniel P. Berrange wrote: > Currently the QEMU processes inherit their core dump rlimit > from libvirtd, which is

Re: [libvirt] [PATCH] tests: add missed directories in EXTRA_DIST

On 07/12/2016 05:41 PM, Martin Kletzander wrote: On Tue, Jul 12, 2016 at 04:28:22PM +0800, Luyao Huang wrote: In commit ec5dcf2a and b0b4a35c, we have moved some xml to new directories, but forget fix the Makefile. Add 2 directories in EXTRA_DIST to fix broken vpath build. Signed-off-by:

Re: [libvirt] [PATCH v2] virCommandExec: Report error if execve fails

On Mon, Jul 11, 2016 at 07:06:04PM +0200, Michal Privoznik wrote: In an unlikely event of execve() failing, the virCommandExec() function does not report any error, even though checks that are at the beginning of the function are verbose when failing. Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH v2] qemu: add a max_core setting to qemu.conf for core dump size

On Tue, Jul 12, 2016 at 11:38:22AM +0200, Martin Kletzander wrote: > On Tue, Jul 12, 2016 at 10:12:36AM +0100, Daniel P. Berrange wrote: > > Currently the QEMU processes inherit their core dump rlimit > > from libvirtd, which is really suboptimal. This change allows > > their limit to be directly

Re: [libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw

On Tue, Jul 12, 2016 at 10:45:12AM +0100, Daniel P. Berrange wrote: On Tue, Jul 12, 2016 at 11:27:43AM +0200, Martin Kletzander wrote: On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote: > We can't mock tests on Mingw, which lacks dlopen() and friends; > follow the paradigms used in

Re: [libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw

On Tue, Jul 12, 2016 at 11:27:43AM +0200, Martin Kletzander wrote: > On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote: > > We can't mock tests on Mingw, which lacks dlopen() and friends; > > follow the paradigms used in other mock files of conditionally > > compiling nothing when not

Re: [libvirt] [PATCH] tests: add missed directories in EXTRA_DIST

On Tue, Jul 12, 2016 at 04:28:22PM +0800, Luyao Huang wrote: In commit ec5dcf2a and b0b4a35c, we have moved some xml to new directories, but forget fix the Makefile. Add 2 directories in EXTRA_DIST to fix broken vpath build. Signed-off-by: Luyao Huang --- tests/Makefile.am |

Re: [libvirt] [PATCH v2] qemu: add a max_core setting to qemu.conf for core dump size

On Tue, Jul 12, 2016 at 10:12:36AM +0100, Daniel P. Berrange wrote: Currently the QEMU processes inherit their core dump rlimit from libvirtd, which is really suboptimal. This change allows their limit to be directly controller from qemu.conf instead. --- Changed in v2: - Allow use of string

Re: [libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw

On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote: We can't mock tests on Mingw, which lacks dlopen() and friends; follow the paradigms used in other mock files of conditionally compiling nothing when not building for Linux. Signed-off-by: Eric Blake ---

Re: [libvirt] [PATCH 1/2] Add qemu hotplug test files

On Mon, Jul 11, 2016 at 10:25:27PM +0200, Tomasz Flendrich wrote: The file tests/qemuhotplugtestdevices/qemuhotplug-ccw-virtio-2-explicit.xml should have an endline at the end to pass the syntax-check. Should I post the patch again with that fixed, or it’s okay? I don’t know how such minor

[libvirt] [PATCH v2] qemu: add a max_core setting to qemu.conf for core dump size

Currently the QEMU processes inherit their core dump rlimit from libvirtd, which is really suboptimal. This change allows their limit to be directly controller from qemu.conf instead. --- Changed in v2: - Allow use of string "unlimited" src/libvirt_private.syms | 2 ++

[libvirt] [PATCH] tests: add missed directories in EXTRA_DIST

In commit ec5dcf2a and b0b4a35c, we have moved some xml to new directories, but forget fix the Makefile. Add 2 directories in EXTRA_DIST to fix broken vpath build. Signed-off-by: Luyao Huang --- tests/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [libvirt] [PATCH 2/2] build: drop hack for old mingw ssize_t

On Mon, Jul 11, 2016 at 09:55:01PM -0600, Eric Blake wrote: > The old 32-bit-only mingw project had a mismatch in its > that omitted ssize_t, but where size_t was a different rank than > int. But now that mingw64 (both 32- and 64-bit) is the more > popular platform (Fedora has dropped mingw in

Re: [libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw

On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote: > We can't mock tests on Mingw, which lacks dlopen() and friends; > follow the paradigms used in other mock files of conditionally > compiling nothing when not building for Linux. > > Signed-off-by: Eric Blake > --- >

Re: [libvirt] [PATCH] systemd: fix ready notification on abstract socket

On Mon, Jul 11, 2016 at 05:35:03PM -0600, Jim Fehlig wrote: > At least with systemd v210, NOTIFY_SOCKET is abstact, e.g. > @/org/freedesktop/systemd1/notify. sendmsg() fails on such a socket > with "Connection refused". The unix(7) man page contains the following > details wrt abstract socket

Re: [libvirt] [PATCH RFC] virhook: adding virHookCheck() inside virHookCall().

On Mon, Jul 11, 2016 at 03:22:44PM -0300, Julio Faracco wrote: > This commit introduces the virHookCheck() before running the command (hook). > The virHookCheck() before virCommandRun() will avoid errors with changes > (removal and other permissions changes) in the hook file, while the libvirt >