Re: [libvirt] [libvirt RFC PATCH 04/10] util: storage: Add support for URI based backing volumes in qemu's JSON pseudo-protocol

On 07/15/2016 07:46 AM, Peter Krempa wrote: > http(s), ftp(s) and tftp use URIs for volume definitions in the JSON > pseudo protocol so it's pretty straightforward to add support for them. > --- > src/util/virstoragefile.c | 34 ++ > tests/virstoragetest.c| 8

Re: [libvirt] [libvirt RFC PATCH 03/10] util: storage: Add support for host device backing specified via JSON

On 07/15/2016 07:46 AM, Peter Krempa wrote: > JSON pseudo protocol for qemu allows to explicitly specify devices. > Add convertor to the internal type. s/convertor/converter/ > --- > src/util/virstoragefile.c | 2 ++ > tests/virstoragetest.c| 6 ++ > 2 files changed, 8 insertions(+) >

Re: [libvirt] [PATCH 2/2] libvirt.spec.in: Adapt to newest wireshark plugindir

Le 27/07/2016 à 17:03, Michal Privoznik a écrit : In the old days, when wireshark plugin was introduced it was installed under /usr/lib64/wireshark/plugins/$VERSION/ while with wireshark-2.1.0 this path has changed just to /usr/lib64/wireshark/plugins. We should teach our spec file about this

Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

On Wed, Jul 27, 2016 at 08:44:53AM +0200, Martin Kletzander wrote: > On Tue, Jul 26, 2016 at 07:12:30PM +0100, Daniel P. Berrange wrote: > > The current LUKS support has a "luks" volume type which has > > a "luks" encryption format. > > > > This partially makes sense if you consider the QEMU

Re: [libvirt] [PATCH libvirt-glib] docs: Document gvir_connection_get_{storage_pools, networks, domains}

On Wed, Jul 27, 2016 at 10:27:17AM +0200, Christophe Fergeau wrote: > > Acked-by: Christophe Fergeau > > (I'm assuming you can push to libvirt-glib, let me know if that's not > the case). Pushed. Thanks! -- Guido > > Christophe > > On Wed, Jul 27, 2016 at 08:59:54AM

Re: [libvirt] [PATCH v1 0/4] libxl: host cpu element in capabilities

On 07/27/2016 02:28 PM, Cedric Bosdonnat wrote: > Hey Joao, > > The series looks good to me, but I'm surely not expert enough to give a > full ACK. > Thank you! Joao > On Wed, 2016-07-20 at 20:08 +0100, Joao Martins wrote: >> Hey, >> >> This small series implements host cpu description in caps,

Re: [libvirt] [PATCH 2/3] libxl: fix segfault in libxlReconnectDomain

On 07/27/2016 02:42 PM, Cédric Bosdonnat wrote: > In case of error, libxlReconnectDomain may call > virDomainObjListRemoveLocked. However it has no local reference on > the domain object, leading to segfault. Get a reference to the domain > object at the start of the function and release it at

Re: [libvirt] [PATCH 3/3] libxl: add hooks support

On 07/27/2016 02:42 PM, Cédric Bosdonnat wrote: > Introduce libxl hook and use it for start, prepare, started, > stop, stopped, migrate events. Looks good to me with one comment and few nits. Looking at lxc and qemu drivers virHook support seems to be similar so I am assuming this is correct. But

[libvirt] [PATCH 0/2] Couple of build fixes

Contradictory to my previous patch set [1], these are not pushed yet and thus require proper review. 1: https://www.redhat.com/archives/libvir-list/2016-July/msg01147.html Michal Privoznik (2): vshCmddefGetOption: Change type of opt_index vshReadlineParse: Drop some unused variables

[libvirt] [PATCH 1/2] vshCmddefGetOption: Change type of opt_index

This function tries to look up desired option for a given parsed command. Upon successful return it also stores option position into passed *opt_index. Now, this variable is type of int, even though it is never ever used to store negative value. Moreover, the variable is set from a local variable

[libvirt] [PATCH 2/2] vshReadlineParse: Drop some unused variables

My compiler identified some variables that were set, but never actually used. For instance, opts_required, and data_acomplete. Signed-off-by: Michal Privoznik --- tools/vsh.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/vsh.c

[libvirt] Entering freeze for libvirt-2.1.0

So as planned I tagged the Release Candidate 1 version in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ Please give it a try, I plan to push the rc2 on Friday and if everything goes fine have the final release on Monday or Tuesday. Please give

Re: [libvirt] [PATCH 5/5] qemu: Advertise OVMF_CODE.secboot.fd

On 07/27/16 10:43, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_conf.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c > index fa9d65e..b51f36f 100644 > ---

Re: [libvirt] [PATCH 4/5] qemu: Enable secure boot

On 07/27/16 10:43, Michal Privoznik wrote: > In qemu, enabling this feature boils down to adding the following > onto the command line: > > -global driver=cfi.pflash01,property=secure,value=on > > However, there are some constraints resulting from the > implementation. For instance, System

[libvirt] [PATCH 2/2] libvirt.spec.in: Adapt to newest wireshark plugindir

In the old days, when wireshark plugin was introduced it was installed under /usr/lib64/wireshark/plugins/$VERSION/ while with wireshark-2.1.0 this path has changed just to /usr/lib64/wireshark/plugins. We should teach our spec file about this change. Signed-off-by: Michal Privoznik

[libvirt] [PATCH 0/2] Two wireshark fixes

While trying to do an RPM, I've ran into two problems. I've already pushed the fixes under 'build breaker rule'. I'm sending them for completeness. Michal Privoznik (2): virt-wireshark: Properly substract wireshark prefix libvirt.spec.in: Adapt to newest wireshark plugindir libvirt.spec.in

[libvirt] [PATCH 1/2] virt-wireshark: Properly substract wireshark prefix

So, when building wireshark plugin, we get the plugindir variable from the wireshark.pc as well as prefix. Then we replace the prefix in the plugindir with our own prefix where libvirt is building to: plugindir="${prefix}${plugindir#ws_prefix}" However, as you can see, there's '$' missing in

Re: [libvirt] [PATCH 2/5] Introduce SMM feature

Hi Michal, thanks a lot for posting this. One question: On 07/27/16 10:43, Michal Privoznik wrote: > Since its release of 2.4.0 qemu is able to enable System > Management Module in the firmware, or disable it. We should > expose this capability in the XML. Unfortunately, there's no good > way to

Re: [libvirt] [PATCH] virconf: Fix config file path construction

On Wed, Jul 27, 2016 at 08:50:42AM +0200, Erik Skultety wrote: Since commit c4bdff19, the path to the configuration file has been constructed in the following manner: - if no config filename was passed to virConfLoadConfigPath, libvirt.conf was used as default - otherwise the filename was

Re: [libvirt] [PATCH] admin: Fix default uri config option name s/admin_uri_default/uri_default

On Wed, Jul 27, 2016 at 02:22:52PM +0200, Erik Skultety wrote: The original name 'admin_uri_default' was introduced to our code by commit dbecb87f. However, at that time we already had a separate config file for admin library but the commit mentioned above didn't properly adjust the config's

[libvirt] [PATCH v2] qemu: fix domain id after domainCreateWithFlags()

Ever since virDomainCreateWithFlags() was introduced by de3aadaa [drivers: add virDomainCreateWithFlags if virDomainCreate exists], the domain ID retrieved with virDomainGetID() was incorrect for several drivers after virDomainCreateWithFlags() was called. The API consumer had to look up the

Re: [libvirt] [PATCH v7 0/7] qemu: expand domain memory statistics

On Wed, Jul 27, 2016 at 03:05:43PM +0300, Dmitry Derbyshev wrote: > 7/27/2016 2:10 PM, Pavel Hrdina пишет: > > On Wed, Jul 13, 2016 at 01:42:11PM +0300, Derbyshev Dmitriy wrote: > >> From: Derbyshev Dmitry > > There are some things that needs to be updated, but if you're

[libvirt] [PATCH 3/3] libxl: add hooks support

Introduce libxl hook and use it for start, prepare, started, stop, stopped, migrate events. --- docs/hooks.html.in | 53 ++-- src/libxl/libxl_domain.c| 75 + src/libxl/libxl_driver.c| 24 +++

[libvirt] [PATCH 0/3] libxl hooks

Hi there! Here is small patchset adding hooks support to the libxl driver. Cédric Bosdonnat (3): libxl: add a flag to mark guests as tainted by a hook libxl: fix segfault in libxlReconnectDomain libxl: add hooks support docs/hooks.html.in | 53 ++--

[libvirt] [PATCH 1/3] libxl: add a flag to mark guests as tainted by a hook

The migrate hook will affect the migrated guest definition. Allow these domains be marked as tainted in the libxl driver. --- src/libxl/libxl_domain.c | 10 ++ src/libxl/libxl_domain.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/src/libxl/libxl_domain.c

[libvirt] [PATCH 2/3] libxl: fix segfault in libxlReconnectDomain

In case of error, libxlReconnectDomain may call virDomainObjListRemoveLocked. However it has no local reference on the domain object, leading to segfault. Get a reference to the domain object at the start of the function and release it at the end to avoid problems. This commit also factorizes

Re: [libvirt] [PATCH] qemu: remove panic device with model s390 when migrating

On Tue, 2016-07-26 at 18:41 +0200, Ján Tomko wrote: > [cc-ing Andrea who auto-added panic for PPC64] >  > Should we do the same for PANIC_MODEL_PSERIES? Thanks for the heads-up. If we care about migrating guests to <= 1.2.16, then we should indeed to the same for pSeries guests. I don't see how

Re: [libvirt] [PATCH v1 0/4] libxl: host cpu element in capabilities

Hey Joao, The series looks good to me, but I'm surely not expert enough to give a full ACK. -- Cedric On Wed, 2016-07-20 at 20:08 +0100, Joao Martins wrote: > Hey, > > This small series implements host cpu description in caps, by getting > topology and xen hwcaps parsing done, followed by

Re: [libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

On Wed, Jul 27, 2016 at 18:08:29 +0530, Shivaprasad G Bhat wrote: > virsh maxvcpus --type kvm output is useless on PPC. Also, in > commit e6806d79 we documented not rely on virConnectGetMaxVcpus > output. Fix the maxvcpus to use virConnectGetDomainCapabilities > now to make it useful. The call is

[libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

The following patch fixes the maxvcpus output on PPC64. Earlier I tried fixing this in kvmGetMaxVcpus() which was later decided to be document not use the virConnectGetMaxVcpus() instead use the virConnectGetDomainCapabilities api. I have not implemented the suggestedcpus as mentioned in my

[libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

virsh maxvcpus --type kvm output is useless on PPC. Also, in commit e6806d79 we documented not rely on virConnectGetMaxVcpus output. Fix the maxvcpus to use virConnectGetDomainCapabilities now to make it useful. The call is made to use the default qemu binary and to check for the host machine and

[libvirt] [PATCH] admin: Fix default uri config option name s/admin_uri_default/uri_default

The original name 'admin_uri_default' was introduced to our code by commit dbecb87f. However, at that time we already had a separate config file for admin library but the commit mentioned above didn't properly adjust the config's option name. The result is that when we're loading the config, we

Re: [libvirt] [PATCH sandbox] image: Rename 'create' and 'delete' to 'prepare' and 'purge'

On Wed, 2016-07-27 at 13:01 +0100, Daniel P. Berrange wrote: > Currently we have three virt-sandbox-image commands > > - 'create' - downloads a template and creates qcow2 > - 'delete' - deletes template qcow2 files > - 'run' - runs an instance of a template > > The 'run' command is generating

Re: [libvirt] [PATCH v7 0/7] qemu: expand domain memory statistics

7/27/2016 2:10 PM, Pavel Hrdina пишет: On Wed, Jul 13, 2016 at 01:42:11PM +0300, Derbyshev Dmitriy wrote: From: Derbyshev Dmitry There are some things that needs to be updated, but if you're OK with me updating those issues I can push the first 5 patches for you with

[libvirt] [PATCH] virt-admin.pod: Remove a statement about remote access to the daemon

There's been a forgotten fragment (copy-paste error probably) in the virt-admin's man page referring the reader to our web page on how to construct URIs in case of remote access, which sort of implies that we support it which we don't at the moment, so better remove that. Signed-off-by: Erik

[libvirt] [PATCH sandbox] image: Rename 'create' and 'delete' to 'prepare' and 'purge'

Currently we have three virt-sandbox-image commands - 'create' - downloads a template and creates qcow2 - 'delete' - deletes template qcow2 files - 'run' - runs an instance of a template The 'run' command is generating a transient guest which disappears when it stops. We want to have the

Re: [libvirt] [PATCH v7 6/7] qemu: add cache for DomainMemoryStats

7/27/2016 2:14 PM, Daniel P. Berrange пишет: On Wed, Jul 27, 2016 at 01:09:38PM +0200, Pavel Hrdina wrote: On Wed, Jul 13, 2016 at 01:42:17PM +0300, Derbyshev Dmitriy wrote: From: Igor Redko Communication with qemu monitor is time-consuming and there is additional

Re: [libvirt] [PATCH 00/25] Add support for multi-host gluster drives

On Tue, Jul 26, 2016 at 17:57:32 +0200, Ján Tomko wrote: > On Mon, Jul 25, 2016 at 08:11:45PM +0200, Peter Krempa wrote: > >This is a updated take based on stuff I had laying around and parts from > >https://www.redhat.com/archives/libvir-list/2016-July/msg00872.html > > > >This addresses the

Re: [libvirt] [PATCHv2 00/10] JSON pseudo-protocol support for backing chains

On Wed, Jul 27, 2016 at 12:50:07PM +0200, Peter Krempa wrote: This part is extracted from the gluster series since Eric's comment on the original RFC triggered a rework of certain parts. This version allows to handle both flattened and hierarchical syntaxes (see patch 1/10) for details. Peter

Re: [libvirt] [PATCH] qemu: Adjust the cur_ballon on coldplug/unplug of dimms

On Thu, Jul 21, 2016 at 15:39:30 +0530, Shivaprasad G Bhat wrote: > The cur_balloon also increases/decreases with dimm hotplug/unplug. > To be consistent, adjust the value for coldplug too. This was inconsistently > taken care when cur_ballon != memory to begin with. The patch fixes it >

Re: [libvirt] [PATCH v7 6/7] qemu: add cache for DomainMemoryStats

On Wed, Jul 27, 2016 at 01:09:38PM +0200, Pavel Hrdina wrote: > On Wed, Jul 13, 2016 at 01:42:17PM +0300, Derbyshev Dmitriy wrote: > > From: Igor Redko > > > > Communication with qemu monitor is time-consuming and there is > > additional overhead for converting

Re: [libvirt] [PATCH v7 0/7] qemu: expand domain memory statistics

On Wed, Jul 13, 2016 at 01:42:11PM +0300, Derbyshev Dmitriy wrote: > From: Derbyshev Dmitry There are some things that needs to be updated, but if you're OK with me updating those issues I can push the first 5 patches for you with the issues fixed. Pavel --

Re: [libvirt] [PATCH v7 6/7] qemu: add cache for DomainMemoryStats

On Wed, Jul 13, 2016 at 01:42:17PM +0300, Derbyshev Dmitriy wrote: > From: Igor Redko > > Communication with qemu monitor is time-consuming and there is > additional overhead for converting qemu_binary->json->libvirt_binary. > > This patch tries to avoid unnecessary qmp

Re: [libvirt] [PATCH v7 5/7] qemu: return balloon statistics when all domain statistics reported

On Wed, Jul 13, 2016 at 01:42:16PM +0300, Derbyshev Dmitriy wrote: > From: Derbyshev Dmitry > > To collect all balloon statistics for all guests it was necessary to make > several libvirt requests. Now it's possible to get all balloon statiscs via > single

Re: [libvirt] [PATCH 1/2] util: Introduce virISCSINodeNew

On 07/27/2016 06:48 AM, Ján Tomko wrote: > On Tue, Jul 26, 2016 at 10:25:41PM -0400, John Ferlan wrote: >> >> >> On 07/26/2016 12:24 PM, Ján Tomko wrote: >>> On Mon, Jul 18, 2016 at 07:37:20AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1356436 According

[libvirt] [PATCHv2 09/10] util: storage: Add 'ssh' network storage protocol

Allow using 'ssh' protocol in backing chains and later for disks themselves. --- src/libxl/libxl_conf.c| 1 + src/qemu/qemu_command.c | 7 +++ src/qemu/qemu_driver.c| 3 +++ src/qemu/qemu_parse_command.c | 1 + src/util/virstoragefile.c | 4 +++-

[libvirt] [PATCHv2 05/10] util: storage: Add json pseudo protocol support for gluster volumes

Along with the legacy URI based syntax add support for the brand-new fully object based syntax. --- src/util/virstoragefile.c | 108 ++ tests/virstoragetest.c| 46 2 files changed, 154 insertions(+) diff --git

[libvirt] [PATCHv2 00/10] JSON pseudo-protocol support for backing chains

This part is extracted from the gluster series since Eric's comment on the original RFC triggered a rework of certain parts. This version allows to handle both flattened and hierarchical syntaxes (see patch 1/10) for details. Peter Krempa (10): util: storage: Add parser for qemu's json backing

[libvirt] [PATCHv2 10/10] util: storage: Add JSON backing volume parser for 'ssh' protocol

--- src/util/virstoragefile.c | 38 ++ tests/virstoragetest.c| 19 +++ 2 files changed, 57 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 3e22b0c..fa12b28 100644 --- a/src/util/virstoragefile.c +++

[libvirt] [PATCHv2 01/10] util: storage: Add parser for qemu's json backing pseudo-protocol

Add a modular parser that will allow to parse 'json' backing definitions that are supported by qemu. The initial implementation adds support for the 'file' driver. Due to the approach qemu took to implement the JSON backing strings it's possible to specify them in two approaches. The object

[libvirt] [PATCHv2 08/10] util: storage: Add JSON backing store parser for 'sheepdog' protocol

--- src/util/virstoragefile.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 53ff710..169d70e 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -2746,6 +2746,30 @@

[libvirt] [PATCHv2 06/10] util: storage: Add json pseudo protocol support for iSCSI volumes

iSCSI is a bit odd in this aspect since it only supports URIs but using the 'filename' property and does not have any alternative syntax. --- src/util/virstoragefile.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c

[libvirt] [PATCHv2 07/10] util: storage: Add JSON backing volume parser for 'nbd' protocol

--- src/util/virstoragefile.c | 45 + tests/virstoragetest.c| 30 ++ 2 files changed, 75 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 66dbbef..53ff710 100644 ---

[libvirt] [PATCHv2 03/10] util: storage: Add support for host device backing specified via JSON

JSON pseudo protocol for qemu allows to explicitly specify devices. Add convertor to the internal type. --- src/util/virstoragefile.c | 2 ++ tests/virstoragetest.c| 6 ++ 2 files changed, 8 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index

[libvirt] [PATCHv2 02/10] util: json: Make first argument of virJSONValueCopy const

It's just read. --- src/util/virjson.c | 2 +- src/util/virjson.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index afc98e3..b6d9a34 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -1241,7 +1241,7 @@

[libvirt] [PATCHv2 04/10] util: storage: Add support for URI based backing volumes in qemu's JSON pseudo-protocol

http(s), ftp(s) and tftp use URIs for volume definitions in the JSON pseudo protocol so it's pretty straightforward to add support for them. --- src/util/virstoragefile.c | 43 +++ tests/virstoragetest.c| 15 +++ 2 files changed, 58

Re: [libvirt] [PATCH 1/2] util: Introduce virISCSINodeNew

On Tue, Jul 26, 2016 at 10:25:41PM -0400, John Ferlan wrote: On 07/26/2016 12:24 PM, Ján Tomko wrote: On Mon, Jul 18, 2016 at 07:37:20AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1356436 According to RFC 3721 (https://www.ietf.org/rfc/rfc3721.txt), there are two

Re: [libvirt] [PATCH v7 4/7] qemu: split qemuDomainMemoryStats into internal and external functions

On Wed, Jul 13, 2016 at 01:42:15PM +0300, Derbyshev Dmitriy wrote: > From: Derbyshev Dmitry > > Is necessary to call it from other contexts, such as > qemuDomainGetStatsBalloon. > > Signed-off-by: Derbyshev Dmitry > --- >

Re: [libvirt] [PATCH] virconf: Fix config file path construction

On 27/07/16 11:21, Andrea Bolognani wrote: > On Wed, 2016-07-27 at 08:50 +0200, Erik Skultety wrote: >> Since commit c4bdff19, the path to the configuration file has been >> constructed >> in the following manner: >> - if no config filename was passed to virConfLoadConfigPath, libvirt.conf >>

Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

On Wed, Jul 27, 2016 at 10:23:18AM +0100, Daniel P. Berrange wrote: On Wed, Jul 27, 2016 at 11:16:57AM +0200, Martin Kletzander wrote: On Wed, Jul 27, 2016 at 09:29:29AM +0100, Daniel P. Berrange wrote: > On Wed, Jul 27, 2016 at 08:44:53AM +0200, Martin Kletzander wrote: > > On Tue, Jul 26,

Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

On Wed, Jul 27, 2016 at 11:16:57AM +0200, Martin Kletzander wrote: > On Wed, Jul 27, 2016 at 09:29:29AM +0100, Daniel P. Berrange wrote: > > On Wed, Jul 27, 2016 at 08:44:53AM +0200, Martin Kletzander wrote: > > > On Tue, Jul 26, 2016 at 07:12:30PM +0100, Daniel P. Berrange wrote: > > > > The

Re: [libvirt] [PATCH] virconf: Fix config file path construction

On Wed, 2016-07-27 at 08:50 +0200, Erik Skultety wrote: > Since commit c4bdff19, the path to the configuration file has been constructed > in the following manner: >  - if no config filename was passed to virConfLoadConfigPath, libvirt.conf was >  used as default >  - otherwise the filename was

Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

On Wed, Jul 27, 2016 at 09:29:29AM +0100, Daniel P. Berrange wrote: On Wed, Jul 27, 2016 at 08:44:53AM +0200, Martin Kletzander wrote: On Tue, Jul 26, 2016 at 07:12:30PM +0100, Daniel P. Berrange wrote: > The current LUKS support has a "luks" volume type which has > a "luks" encryption format.

Re: [libvirt] [PATCH] docs: Add Kimchi as Web Application

On Thu, 2016-07-14 at 15:54 -0300, Ramon Medeiros wrote: > Kimchi is a open-source interface to kvm. It runs with HTML5, simple and > easy to manage kvm guests. >  > Signed-off-by: Ramon Medeiros > --- >  docs/apps.html.in | 8 >  1 file changed, 8 insertions(+)

[libvirt] [PATCH 4/5] qemu: Enable secure boot

In qemu, enabling this feature boils down to adding the following onto the command line: -global driver=cfi.pflash01,property=secure,value=on However, there are some constraints resulting from the implementation. For instance, System Management Mode (SMM) is required to be enabled, the machine

[libvirt] [PATCH 0/5] Enable secure boot

We have UEFI enabled guests for a while now. But only recently qemu introduced secure boot. We should reflect that in our code too. Michal Privoznik (5): qemuBuildMachineCommandLine: Follow our pattern Introduce SMM feature Introduce @secure attribute to os loader element qemu: Enable

[libvirt] [PATCH 3/5] Introduce @secure attribute to os loader element

This element will control secure boot implemented by some firmwares. If the firmware used in does support the feature we must tell it to the underlying hypervisor. However, we can't know whether loader does support it or not just by looking at the file. Therefore we have to have an attribute to

[libvirt] [PATCH 2/5] Introduce SMM feature

Since its release of 2.4.0 qemu is able to enable System Management Module in the firmware, or disable it. We should expose this capability in the XML. Unfortunately, there's no good way to determine whether the binary we are talking to supports it. I mean, if qemu's run with real machine type,

[libvirt] [PATCH 5/5] qemu: Advertise OVMF_CODE.secboot.fd

Signed-off-by: Michal Privoznik --- src/qemu/qemu_conf.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index fa9d65e..b51f36f 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@

[libvirt] [PATCH 1/5] qemuBuildMachineCommandLine: Follow our pattern

We use 'goto cleanup' for a reason. If a function can exit at many places but doesn't follow the pattern, it has to copy the free code in multiple places. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 39 ++- 1 file

Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

On Wed, Jul 27, 2016 at 08:44:53AM +0200, Martin Kletzander wrote: > On Tue, Jul 26, 2016 at 07:12:30PM +0100, Daniel P. Berrange wrote: > > The current LUKS support has a "luks" volume type which has > > a "luks" encryption format. > > > > This partially makes sense if you consider the QEMU

Re: [libvirt] [PATCH libvirt-glib] docs: Document gvir_connection_get_{storage_pools, networks, domains}

Acked-by: Christophe Fergeau (I'm assuming you can push to libvirt-glib, let me know if that's not the case). Christophe On Wed, Jul 27, 2016 at 08:59:54AM +0200, Guido Günther wrote: > In contrast to libvirt itself all get_* methods need to prefetch the > corresponding

Re: [libvirt] [PATCH v7 3/7] qemu: expand domain memory statistics with 'last-update' timestamp

On Wed, Jul 13, 2016 at 01:42:14PM +0300, Derbyshev Dmitriy wrote: > From: Derbyshev Dmitry > > QEMU reports timestamp along with other memory statistics, but this > information is not reported by libvirt statistics API. > It could be useful to determine if the data

Re: [libvirt] [PATCH v7 2/7] qemu: expand domain memory statistics with 'usable'

On Wed, Jul 13, 2016 at 01:42:13PM +0300, Derbyshev Dmitriy wrote: > From: Derbyshev Dmitry > > Currently 'memtotal' in virtio drivers and qemu corresponds > to 'available' in libvirt. Because of that we introduce libvirt 'usable' > parameter, which maps to

Re: [libvirt] [PATCH v7 1/7] virsh: Add balloon stats description to .pod

On Wed, Jul 13, 2016 at 01:42:12PM +0300, Derbyshev Dmitriy wrote: > From: Derbyshev Dmitry > > Description for existing balloon stats was missing for dommemstat. > > Signed-off-by: Derbyshev Dmitry > --- > tools/virsh.pod | 14

Re: [libvirt] [libvirt RFC PATCH 02/10] util: storage: Add parser for qemu's "json" backing pseudo-protocol

On Tue, Jul 26, 2016 at 14:28:23 -0600, Eric Blake wrote: > On 07/15/2016 07:46 AM, Peter Krempa wrote: > > Add a modular parser that will allow to parse 'json' backing definitions > > that are supported by qemu. The initial implementation adds support for > > the 'file' driver. > > Might be nice

Re: [libvirt] [PATCH v3 0/2] qemu: expand domain memory statistics

On Tue, Jul 26, 2016 at 09:32:30PM +0300, Maxim Nestratov wrote: > 26-Jul-16 18:32, Pavel Hrdina пишет: > > > On Sat, Jun 04, 2016 at 06:41:35PM +0300, Maxim Nestratov wrote: > >> 01.06.2016 20:07, Derbyshev Dmitriy пишет: > >> Makes sense, looks good to me. > >> ACK the series. > > Pushed now.

[libvirt] [PATCH libvirt-glib] docs: Document gvir_connection_get_{storage_pools, networks, domains}

In contrast to libvirt itself all get_* methods need to prefetch the corresponding information first so document this. --- libvirt-gobject/libvirt-gobject-connection.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-connection.c

[libvirt] [PATCH] virconf: Fix config file path construction

Since commit c4bdff19, the path to the configuration file has been constructed in the following manner: - if no config filename was passed to virConfLoadConfigPath, libvirt.conf was used as default - otherwise the filename was concatenated with "/libvirt/libvirt%s%s.conf" which in admin case

Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

On Tue, Jul 26, 2016 at 07:12:30PM +0100, Daniel P. Berrange wrote: The current LUKS support has a "luks" volume type which has a "luks" encryption format. This partially makes sense if you consider the QEMU shorthand syntax only requires you to specify a format=luks, and it'll automagically

Re: [libvirt] [PATCH v2 00/10] Remove caching of address sets

On Sat, Jul 23, 2016 at 03:47:05AM +0200, Tomasz Flendrich wrote: From: Tomasz Flendrich These patches delete the caching of pci, virtioSerial and ccw address sets. I am deleting them, because they can be recalculated from the domain definition, and there's no

Re: [libvirt] [PATCH 1/2] virstoragefile: refactor virStorageFileMatchesNNN methods

On Tue, Jul 26, 2016 at 07:12:29PM +0100, Daniel P. Berrange wrote: Refactor the virStorageFileMatchesNNN methods so that they don't take a struct FileFormatInfo parameter, but instead get the actual raw dat items they needs. This will facilitate reuse in other contexts. Signed-off-by: Daniel