[libvirt] [PATCH] storage_backend_rbd: continue searching when failing in rbd_diff_iterate

From: Chen Hanxiao We try to find a snapshot that had no different between the current state of RBD image. If we failed in rbd_diff_iterate, just continue for the next search iteration. Signed-off-by: Chen Hanxiao ---

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

On Mon, 5 Sep 2016 11:36:55 +0200 Paolo Bonzini wrote: > On 05/09/2016 11:23, Markus Armbruster wrote: > >> > > >> > On the other hand, it is clearly documented that the DEVICE_DELETED > >> > event is sent as soon as guest acknowledges completion of device > >> > removal. So

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

On 09/05/2016 05:36 AM, Paolo Bonzini wrote: On 05/09/2016 11:23, Markus Armbruster wrote: On the other hand, it is clearly documented that the DEVICE_DELETED event is sent as soon as guest acknowledges completion of device removal. So libvirt's buggy if we'd follow documentation strictly. But

Re: [libvirt] [libvirt-php] libvirt_connect not reading out credential info on 0.5.2

Hi again Michal, I have more information to share. I think I can confirm that the patches are actually fixing the credentials problem and they are passed along. This is the content of test.log with libvirt-php output: [2016-09-05 22:06:05 libvirt-php/core ]: libvirt_connect: credentials

Re: [libvirt] [libvirt-php] libvirt_connect not reading out credential info on 0.5.2

Thanks for your reply Michal. Actually you don't need a Hyper-V server to reproduce the problem since the connection to the server is never initiated because the process crash before that stage (got wireshark on the network to confirm this). So you should be able to reproduce the problem

Re: [libvirt] virt-admin commands aliases

On Mon, Sep 05, 2016 at 05:37:07PM +0200, Erik Skultety wrote: > Hi there, > > after my presentation at KVM Forum, it was pointed out from the audience > that we might think about doing something about the naming of the > virt-admin's comands, since there is some sort of inconsistency: srv- > vs.

Re: [libvirt] virt-admin commands aliases

On Mon, Sep 05, 2016 at 07:40:30PM +0200, Andrea Bolognani wrote: > On Mon, 2016-09-05 at 17:37 +0200, Erik Skultety wrote: > > Hi there, > >  > > after my presentation at KVM Forum, it was pointed out from the audience > > Disclaimer: I'm the audience in question :) There's always one

Re: [libvirt] virt-admin commands aliases

On Mon, 2016-09-05 at 17:37 +0200, Erik Skultety wrote: > Hi there, >  > after my presentation at KVM Forum, it was pointed out from the audience Disclaimer: I'm the audience in question :) > that we might think about doing something about the naming of the > virt-admin's comands, since there is

[libvirt] [PATCH] util: fix crash in virClassIsDerivedFrom for CloseCallbacks objects

There is a possibility that qemu driver frees by unreferencing its closeCallbacks pointer as it has the only reference to the object, while in fact not all users of CloseCallbacks called thier virCloseCallbacksUnset. Backtrace is the following: Thread #1: 0 in pthread_cond_wait@@GLIBC_2.3.2 ()

[libvirt] [PATCH 0/3] vz: nettype=bridge and other corrections

Maxim Nestratov (3): vz: support type=bridge network interface type correctly vz: remove Bridged network name and rename Routed vz: add MIGRATION_V3 capability src/vz/vz_driver.c | 1 + src/vz/vz_sdk.c| 100 - src/vz/vz_utils.h |

[libvirt] [PATCH 2/3] vz: remove Bridged network name and rename Routed

It's funny, but Routed network name was incorrect. We should use host-routed instead. --- src/vz/vz_utils.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h index 4b407ec..9e02fe0 100644 --- a/src/vz/vz_utils.h +++ b/src/vz/vz_utils.h @@

[libvirt] [PATCH 1/3] vz: support type=bridge network interface type correctly

Recently, libprlsdk got a separate flag PNA_BRIDGE corresponding to type=bridge libvirt network interfaces. Let's use it and get rid of all workarounds previously added to support it. Signed-off-by: Maxim Nestratov --- src/vz/vz_sdk.c | 100

[libvirt] [PATCH] qemu: guest agent: introduce new error code VIR_ERR_AGENT_UNSYNCED

From: Yuri Pudgorodskiy A separate error code will help recognize real failures from necessity to try again Signed-off-by: Maxim Nestratov --- include/libvirt/virterror.h | 2 ++ src/qemu/qemu_agent.c | 6 +++--- src/util/virerror.c

[libvirt] [PATCH 3/3] vz: add MIGRATION_V3 capability

Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 819dad7..b971add 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -3071,6 +3071,7 @@

[libvirt] [PATCH 2/2] util: storage: Add json pseudo protocol support for legacy RBD strings

RBD in qemu still uses only the legacy 'filename' syntax. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1371758 --- src/util/virstoragefile.c | 23 +++ tests/virstoragetest.c| 6 ++ 2 files changed, 29 insertions(+) diff --git a/src/util/virstoragefile.c

[libvirt] [PATCH 0/2] util: storage: Fixes for the JSON pseudo protocol parser

Gluster protocol type was not set properly and the RBD protocol was missing. Peter Krempa (2): util: storage: Properly set protocol type when parsing gluster json string util: storage: Add json pseudo protocol support for legacy RBD strings src/util/virstoragefile.c | 26

[libvirt] [PATCH 1/2] util: storage: Properly set protocol type when parsing gluster json string

Commit 2ed772cd forgot to set proper protocol. This was also present in the test data. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1372251 --- src/util/virstoragefile.c | 3 +++ tests/virstoragetest.c| 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH 1/2] qemu: domain: Clear startup policy for dropped removable media

When a source image is dropped when missing due to startup policy the policy needs to be cleared since it was relevant only for the given storage source. New sources need to update it if needed. --- src/qemu/qemu_domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[libvirt] [PATCH 0/2] qemu: hotplug: Fix two issues with drives made empty by using starup policy

If a cdrom drive is emptied by 'requisite' startup policy the policy setting would not be cleared and due to a bug in qemu the cdrom image could not be changed. The first patch clears the startup policy setting and the second one fixes ejection of cdroms if --force is specified. Also I've

[libvirt] [PATCH 2/2] qemu: hotplug: Don't wait if cdrom tray is opened forcibly

Qemu always opens the tray if forced to. Skip the waiting step in such case. This also helps if qemu does not report the tray change event when opening the cdrom forcibly (the documentation says that the event will not be sent although qemu in fact does trigger it even if @force is selceted).

Re: [libvirt] [libvirt-glib/libvirt-gconfig 06/17] gconfig: Implement gvir_config_domain_graphics_spice_get_tls_port()

On Thu, Apr 21, 2016 at 12:12:19PM +0200, Christophe Fergeau wrote: > For patches up to this one: > > Acked-by: Christophe Fergeau On second thought, the API added by the patches before this one becomes redundant and deprecated once the Remote/Local classes are introduced,

[libvirt] virt-admin commands aliases

Hi there, after my presentation at KVM Forum, it was pointed out from the audience that we might think about doing something about the naming of the virt-admin's comands, since there is some sort of inconsistency: srv- vs. client- vs. dmn- (not merged yet). When I sent patches to upstream I

Re: [libvirt] [PATCH v2 0/3] virsh: Option completers and small improvements/fixes for autocomplete

On 05.09.2016 11:45, Nishith Shah wrote: > This series introduces option completers and adds some minor improvements > and fixes(not bugs per se, just better/sane behavior) in vshReadlineParse. > > The first patch introduces the usage of option completers to auto-complete > arguments for a

Re: [libvirt] [PATCH] Prefix major/minor with gnu_dev_

On Mon, Sep 05, 2016 at 03:33:36PM +0200, Michal Privoznik wrote: > In the latest glibc, major() and minor() functions are marked as > deprecated (glibc commit dbab6577): > > CC util/libvirt_util_la-vircgroup.lo > util/vircgroup.c: In function 'virCgroupGetBlockDevString': >

Re: [libvirt] Call for mentors: Outreachy December - March

On Mon, Sep 5, 2016 at 9:39 AM, Stefan Hajnoczi wrote: > The Outreachy open source internship programme is running a December - > March round. Outreachy promotes participation of underrepresented > groups in open source. > > If you would like to be a mentor please reply.

[libvirt] Call for mentors: Outreachy December - March

The Outreachy open source internship programme is running a December - March round. Outreachy promotes participation of underrepresented groups in open source. If you would like to be a mentor please reply. What is a mentor? Mentors help interns with their project and evaluate their progress.

[libvirt] [PATCH] Prefix major/minor with gnu_dev_

In the latest glibc, major() and minor() functions are marked as deprecated (glibc commit dbab6577): CC util/libvirt_util_la-vircgroup.lo util/vircgroup.c: In function 'virCgroupGetBlockDevString': util/vircgroup.c:768:5: error: '__major_from_sys_types' is deprecated: In the GNU C

Re: [libvirt] [libvirt-perl][PATCH 0/2] Add more PERF_PARAM_* constants

On Sun, Sep 04, 2016 at 10:53:12PM +0200, Michal Privoznik wrote: > Now that libvirt-2.2.0 is out, we should: > a) do the libvirt-perl release too > b) adapt to new constants pushed to 2.3.0 > > Michal Privoznik (2): > Bump version to 2.3.0 > Add more PERF_PARAM_* constants > > Changes

Re: [libvirt] [PATCH 0/2] Report block jobs more wisely

On Mon, Sep 05, 2016 at 01:48:21PM +0200, Michal Privoznik wrote: > There's been a discussion recently (even here on the list [1]) > that Nova is sometimes unable to fetch block job stats properly. > Basically, we may report job.cur == job.end == 0 in some cases > tricking Nova into thinking job

[libvirt] [PATCH 0/2] Report block jobs more wisely

There's been a discussion recently (even here on the list [1]) that Nova is sometimes unable to fetch block job stats properly. Basically, we may report job.cur == job.end == 0 in some cases tricking Nova into thinking job is done when in fact it hasn't even started yet. Michal Privoznik (2):

[libvirt] [PATCH 1/2] qemuDomainGetBlockJobInfo: Move info translation into separate func

Even though we merely just pass to users whatever qemu provided on the monitor, we still do some translation. For instance we turn bytes into mebibytes, or fix job type if needed. However, in the future there is more fixing to be done so this code deserves its own function. Signed-off-by: Michal

[libvirt] [PATCH 2/2] virDomainGetBlockJobInfo: Fix corner case when qemu reports no info

https://bugzilla.redhat.com/show_bug.cgi?id=1372613 Apparently, some management applications use the following code pattern when waiting for a block job to finish: while (1) { virDomainGetBlockJobInfo(dom, disk, info, flags); if (info.cur == info.end) break; sleep(1); }

[libvirt] [PATCH v2 1/3] virsh: Introduce usage of option completers to auto-complete arguments

Call option completers if argument completion is requested using the corresponding option completer, if it is defined. Signed-off-by: Nishith Shah --- v2: Fix a infinite while loop in vshReadlineParse when using option completers tools/vsh.c | 66

[libvirt] [PATCH v2 2/3] virsh: Allow data or argument options to be completed as well

Signed-off-by: Nishith Shah --- tools/vsh.c | 4 1 file changed, 4 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index b101645..45f55d9 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2607,10 +2607,6 @@ vshReadlineOptionsGenerator(const char *text, int

[libvirt] [PATCH v2 3/3] virsh: Complete multiple options when any one option requires data

Before this patch: virsh # start --domain dom1 [TAB][TAB] <- offers filename completion virsh # start --domain [TAB][TAB] <- offers filename completion After this patch: virsh # start --domain dom1 [TAB][TAB] <- offers command completion virsh # start --domain [TAB][TAB] <- calls

[libvirt] [PATCH v2 0/3] virsh: Option completers and small improvements/fixes for autocomplete

This series introduces option completers and adds some minor improvements and fixes(not bugs per se, just better/sane behavior) in vshReadlineParse. The first patch introduces the usage of option completers to auto-complete arguments for a particular option. The second and third patches provide

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

On 05/09/2016 11:23, Markus Armbruster wrote: >> > >> > On the other hand, it is clearly documented that the DEVICE_DELETED >> > event is sent as soon as guest acknowledges completion of device >> > removal. So libvirt's buggy if we'd follow documentation strictly. But >> > then again, I don't

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

Adding Paolo. Michal Privoznik writes: > On 02.09.2016 01:11, Alex Williamson wrote: >> Hey, >> >> I'm out of my QOM depth, so I'll just beg for help in advance. I >> noticed in testing vfio-pci hotunplug that the host seems to be trying >> to reclaim the device before

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

On 03/09/2016 13:57, John Ferlan wrote: After creating the vGPU, if required by the host driver, all the other type ids would disappear from "virsh nodedev-dumpxml pci__86_00_0" too. >>> >>> Not wanting to make assumptions, but this reads as if I create one type >>> 11 vGPU, then I

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

On 03/09/2016 01:57, Laine Stump wrote: >> >> mdevs do not exist on the host (they do not have a driver on the host >> because they are not PCI devices) so they do need any management. At >> least I hope that's good news. :) > > What's your definition of "management"? They don't need the same

Re: [libvirt] [libvirt-php] libvirt_connect not reading out credential info on 0.5.2

On 02.09.2016 11:11, Fernando Casas Schössow wrote: > I'm running libvirt-php 0.5.2 on CentOS 7 with libvirt 2.1.0. > Using virsh I'm able to connect to hyper-v hosts correctly but using > libvirt-php it fails during authentication since it seems that the > credentials are not being passed along.