Re: [libvirt] [PATCH v5 6/9] conf: Add new secret element for tcp chardev

On 08/05/2016 04:25 AM, Daniel P. Berrange wrote: > On Thu, Aug 04, 2016 at 11:21:24AM -0400, John Ferlan wrote: >> Define, parse, and format a key secret element for a chardev tcp backend. >> This secret will be used in conjunction with the chartcp_tls_x509_cert_dir >> in order to provide the

[libvirt] [PATCH] util: Quiet the logging if perf file doesn't exist

Commit id 'b00d7f29' shifted the opening of the /sys/devices/intel_cqm/type file from event enable to perf event initialization. If the file did not exist, then an error would be written to the domain log: 2016-09-06 20:51:21.677+: 7310: error : virFileReadAll:1360 : Failed to open file

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

On Wed, 7 Sep 2016 01:05:11 +0530 Kirti Wankhede wrote: > On 9/6/2016 11:10 PM, Alex Williamson wrote: > > On Sat, 3 Sep 2016 22:04:56 +0530 > > Kirti Wankhede wrote: > > > >> On 9/3/2016 3:18 AM, Paolo Bonzini wrote: > >>> > >>> > >>> On

[libvirt] [PATCH 2/2] storage: Need to properly read the crypt offset value

Commit id 'a48c7141' altered how to determine if a volume was encrypted by adding a peek at an offset into the file at a specific buffer location. Unfortunately, all that was compared was the first "char" of the buffer against the expect "int" value. Restore the virReadBufInt32BE to get the

[libvirt] [PATCH 1/2] storage: Need to refresh secret for luks volume after volume refresh

A LUKS volume uses the volume secret type just like the QCOW2 secret, so adjust the loading of the default secrets to handle any volume that the virStorageFileGetMetadataFromBuf code has deemed to be an encrypted volume to search for the volume's secret. This lookup is done by volume usage where

[libvirt] [PATCH 0/2] A couple of volume encryption patches

I'm assume there will be a couple of bz's on these... Patch 1 fixes a problem where the vol-dumpxml would not list the element from a volume in a pool after the initial creation and a pool refresh (or libvirtd restart). This issue was missed due to rewriting the LUKS support to not use it's own

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

On 9/6/2016 11:10 PM, Alex Williamson wrote: > On Sat, 3 Sep 2016 22:04:56 +0530 > Kirti Wankhede wrote: > >> On 9/3/2016 3:18 AM, Paolo Bonzini wrote: >>> >>> >>> On 02/09/2016 20:33, Kirti Wankhede wrote: We could even do: >> >> echo $UUID1:$GROUPA >

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

On Sat, 3 Sep 2016 22:01:13 +0530 Kirti Wankhede wrote: > On 9/3/2016 1:59 AM, John Ferlan wrote: > > > > > > On 09/02/2016 02:33 PM, Kirti Wankhede wrote: > >> > >> On 9/2/2016 10:55 PM, Paolo Bonzini wrote: > >>> > >>> > >>> On 02/09/2016 19:15, Kirti Wankhede

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

On Sat, 3 Sep 2016 22:04:56 +0530 Kirti Wankhede wrote: > On 9/3/2016 3:18 AM, Paolo Bonzini wrote: > > > > > > On 02/09/2016 20:33, Kirti Wankhede wrote: > >> We could even do: > > echo $UUID1:$GROUPA > create > > where $GROUPA is the group ID of

Re: [libvirt] [libvirt-php] libvirt_connect not reading out credential info on 0.5.2

Thanks for the explanation Michal. I will be looking forward the fix to try it. :) On mar, sep 6, 2016 at 6:59 , Michal Privoznik wrote: On 06.09.2016 13:45, Fernando Casas Schössow wrote: Thanks for the instructions since I'm not familiar with debugging as you

Re: [libvirt] [libvirt-php] libvirt_connect not reading out credential info on 0.5.2

On 06.09.2016 13:45, Fernando Casas Schössow wrote: > Thanks for the instructions since I'm not familiar with debugging as you > probably guessed. :) > > Here you have gdb output: > > GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-80.el7 > Copyright (C) 2013 Free Software Foundation, Inc. >

Re: [libvirt] [PATCH] Make sure sys/types.h is included after sys/sysmacros.h

On 09/06/2016 08:46 AM, Michal Privoznik wrote: > In the latest glibc, major() and minor() functions are marked as > deprecated (glibc commit dbab6577): Not only that, but there's a thread on the autoconf list about how to fix AC_HEADER_MAJOR to work. I may be releasing autoconf 2.70 in the near

Re: [libvirt] [PATCH] tools: Pass opaque data in vshCompleter and introduce autoCompleteOpaque

On 06.09.2016 14:04, Nishith Shah wrote: > This patch changes the signature of vshCompleters, allowing to pass along > some data that we might want to along with the completers; for example, > we might want to pass the autocomplete vshControl along with the > completer, in case the completer

Re: [libvirt] [PATCH] qemu: guest agent: introduce new error code VIR_ERR_AGENT_UNSYNCED

On 9/6/2016 6:03 PM, Michal Privoznik wrote: On 05.09.2016 18:42, Maxim Nestratov wrote: From: Yuri Pudgorodskiy A separate error code will help recognize real failures from necessity to try again Signed-off-by: Maxim Nestratov ---

Re: [libvirt] [PATCH] util: hostcpu: improve CPU freq code for FreeBSD

Michal Privoznik wrote: > On 31.08.2016 07:14, Roman Bogorodskiy wrote: > > Current implementation uses the dev.cpu.0.freq sysctl that is > > provided by the cpufreq(4) framework and returns the actual > > CPU frequency. However, there are environment where it's not available, > > e.g. when

Re: [libvirt] [PATCH] qemu: guest agent: introduce new error code VIR_ERR_AGENT_UNSYNCED

06-Sep-16 18:03, Michal Privoznik пишет: On 05.09.2016 18:42, Maxim Nestratov wrote: From: Yuri Pudgorodskiy A separate error code will help recognize real failures from necessity to try again Signed-off-by: Maxim Nestratov ---

Re: [libvirt] [PATCH] qemu: guest agent: introduce new error code VIR_ERR_AGENT_UNSYNCED

On 05.09.2016 18:42, Maxim Nestratov wrote: > From: Yuri Pudgorodskiy > > A separate error code will help recognize real failures from > necessity to try again > > Signed-off-by: Maxim Nestratov > --- > include/libvirt/virterror.h | 2 ++ >

Re: [libvirt] [PATCH] util: fix crash in virClassIsDerivedFrom for CloseCallbacks objects

On 05.09.2016 18:42, Maxim Nestratov wrote: > There is a possibility that qemu driver frees by unreferencing its > closeCallbacks pointer as it has the only reference to the object, > while in fact not all users of CloseCallbacks called thier > virCloseCallbacksUnset. > > Backtrace is the

Re: [libvirt] [PATCH] virsh: Fix *-event error string

On Tue, Sep 06, 2016 at 03:07:37PM +0200, Erik Skultety wrote: > ACK, although, I have a really small nitpick the decision on fixing of > which I leave to you. After the fix, "--list or --event type...", at > least to me, sounds like "--event" was the mentioned type itself which > is of course

Re: [libvirt] [PATCH 0/4] systemd-related fixes and improvements

On Tue, 2016-09-06 at 14:58 +0100, Daniel P. Berrange wrote: > On Tue, Sep 06, 2016 at 03:55:20PM +0200, Andrea Bolognani wrote: > > > > Make libvirt on systemd nicer for the user, by getting rid of > > some confusing behavior, and overall more solid. > > > > More details in each specific patch.

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

On 06/09/2016 16:02, Laine Stump wrote: >>> >> It seems like this is just pointing out another flaw in the semantics >> of DEVICE_DELETED, a device can linger without a device id, so there's >> no way to reference it via QMP. > > Ah, right. I hadn't caught that. Yeah, since it's the device id

Re: [libvirt] [PATCH] util: hostcpu: improve CPU freq code for FreeBSD

On 31.08.2016 07:14, Roman Bogorodskiy wrote: > Current implementation uses the dev.cpu.0.freq sysctl that is > provided by the cpufreq(4) framework and returns the actual > CPU frequency. However, there are environment where it's not available, > e.g. when running nested in KVM. In this case fall

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

On 06/09/2016 04:18, Alex Williamson wrote: > On Mon, 5 Sep 2016 11:36:55 +0200 > Paolo Bonzini wrote: >> DEVICE_DELETED does have a meaning: management cannot talk to the device >> anymore in QMP once it is raised. > > It seems like this is just pointing out another flaw

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

On 09/05/2016 10:18 PM, Alex Williamson wrote: On Mon, 5 Sep 2016 11:36:55 +0200 Paolo Bonzini wrote: On 05/09/2016 11:23, Markus Armbruster wrote: On the other hand, it is clearly documented that the DEVICE_DELETED event is sent as soon as guest acknowledges completion

[libvirt] [PATCH 4/4] libvirt-guests.service: Add Requires=libvirtd.service

Having After=libvirtd.service merely ensures that, if both services are asked to start, libvirtd.service will start first. What we really want is for libvirtd.service to be started whenever libvirt-guests.service is asked to start. Adding a Requires= relationship guarantees that will happen. ---

Re: [libvirt] [PATCH 0/4] systemd-related fixes and improvements

On Tue, Sep 06, 2016 at 03:55:20PM +0200, Andrea Bolognani wrote: > Make libvirt on systemd nicer for the user, by getting rid of > some confusing behavior, and overall more solid. > > More details in each specific patch. ACK to all Regards, Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH] Make sure sys/types.h is included after sys/sysmacros.h

On Tue, Sep 06, 2016 at 03:46:59PM +0200, Michal Privoznik wrote: > In the latest glibc, major() and minor() functions are marked as > deprecated (glibc commit dbab6577): > > CC util/libvirt_util_la-vircgroup.lo > util/vircgroup.c: In function 'virCgroupGetBlockDevString': >

[libvirt] [PATCH 3/4] libvirt-guests.service: Split After= relationship

We use a separate line for each After= relationship in other unit files: do the same here for consistency's sake, and also to make future changes nicer to diff --- tools/libvirt-guests.service.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH 1/4] virtlogd.socket: Tie lifecycle to libvirtd.service

We already guarantee that virtlogd.socket is enabled/disabled along with libvirtd.service, but if libvirtd.service has just been installed and is started before rebooting, then virtlogd.socket will not be running and guest startup will fail. Add Requires=virtlogd.socket to libvirtd.service to

[libvirt] [PATCH 0/4] systemd-related fixes and improvements

Make libvirt on systemd nicer for the user, by getting rid of some confusing behavior, and overall more solid. More details in each specific patch. Andrea Bolognani (4): virtlogd.socket: Tie lifecycle to libvirtd.service libvirt-guests.service: Improve description libvirt-guests.service:

[libvirt] [PATCH 2/4] libvirt-guests.service: Improve description

libvirt-guests.service does both suspend *and* resume guests, depending on whether it's being started or stopped: the description should reflect this, to avoid confusing messages during startup. Replace "active" with "running" (to match virsh list's output) and don't capitalize libvirt. ---

[libvirt] [PATCH] Make sure sys/types.h is included after sys/sysmacros.h

In the latest glibc, major() and minor() functions are marked as deprecated (glibc commit dbab6577): CC util/libvirt_util_la-vircgroup.lo util/vircgroup.c: In function 'virCgroupGetBlockDevString': util/vircgroup.c:768:5: error: '__major_from_sys_types' is deprecated: In the GNU C

Re: [libvirt] virt-admin commands aliases

On 06/09/16 11:52, Martin Kletzander wrote: > On Tue, Sep 06, 2016 at 09:02:19AM +0200, Erik Skultety wrote: >> On 05/09/16 19:48, Daniel P. Berrange wrote: >>> On Mon, Sep 05, 2016 at 05:37:07PM +0200, Erik Skultety wrote: Hi there, after my presentation at KVM Forum, it was

Re: [libvirt] [PATCH] virsh: Fix *-event error string

On 06/09/16 13:17, Christophe Fergeau wrote: > When using > virsh net-event non-existing-net > the error message says that 'either --list or event type is required' > This is misleading as 'virsh net-event $valid-event-type' is not going > to work either. What is expected is 'virsh net-event

[libvirt] [PATCH v2 4/5] qemu: Allow hotplug of vhost-scsi device

Adjust the device string that is built for vhost-scsi devices so that it can be invoked from hotplug. >From the QEMU command line, the file descriptors are expect to be numeric only. However, for hotplug, the file descriptors are expected to begin with at least one alphabetic character else this

[libvirt] [PATCH RESEND v2 0/5] Implementation of QEMU vhost-scsi

[Resending after the release of 2.2.0; no changes other than a rebase to current master and the associated tweaking to the capabilities patch] This patch series provides a libvirt implementation of the vhost-scsi interface in QEMU. As near as I can see, this was discussed upstream in July

[libvirt] [PATCH v2 1/5] Introduce a "scsi_host" hostdev type

We already have a "scsi" hostdev type, which refers to a single LUN that is passed through to a guest. But what of things where multiple LUNs are passed through via a single SCSI HBA, such as with the vhost-scsi target? Create a new hostdev type that will carry this, and its associated

[libvirt] [PATCH v2 5/5] tests: Introduce basic vhost-scsi test

The qemuxml2argv test was cloned from hostdev-scsi-virtio-scsi Signed-off-by: Eric Farman Reviewed-by: Boris Fiuczynski --- .../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24

[libvirt] [PATCH v2 3/5] qemu: Add vhost-scsi string for -device parameter

Open /dev/vhost-scsi, and record the resulting file descriptor, so that the guest has access to the host device outside of the libvirt daemon. Pass this information, along with data parsed from the XML file, to build a device string for the qemu command line. That device string will be for either

[libvirt] [PATCH v2 2/5] qemu: Introduce vhost-scsi capability

Do all the stuff for the vhost-scsi capability in QEMU, so it's in place for our checks later. Signed-off-by: Eric Farman Reviewed-by: Boris Fiuczynski --- src/qemu/qemu_capabilities.c| 3 +++

Re: [libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

On Tue, Sep 06, 2016 at 16:59:09 +0530, Shivaprasad G Bhat wrote: > virsh maxvcpus --type kvm output is useless on PPC. Also, in > commit e6806d79 we documented not rely on virConnectGetMaxVcpus > output. Fix the maxvcpus to use virConnectGetDomainCapabilities > now to make it useful. The call is

Re: [libvirt] [PATCH] qemu: Don't warn about missing device in DEVICE_DELETED event

On Tue, Sep 06, 2016 at 13:47:52 +0200, Jiri Denemark wrote: > Debug priority is good enough for this. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_monitor_json.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK -- libvir-list mailing list

[libvirt] [PATCH] tools: Pass opaque data in vshCompleter and introduce autoCompleteOpaque

This patch changes the signature of vshCompleters, allowing to pass along some data that we might want to along with the completers; for example, we might want to pass the autocomplete vshControl along with the completer, in case the completer requires a connection to libvirtd. Signed-off-by:

Re: [libvirt] [PATCH 0/2] util: storage: Fixes for the JSON pseudo protocol parser

On Mon, Sep 05, 2016 at 18:42:45 +0200, Peter Krempa wrote: > Gluster protocol type was not set properly and the RBD protocol was missing. > > Peter Krempa (2): > util: storage: Properly set protocol type when parsing gluster json > string > util: storage: Add json pseudo protocol support

[libvirt] [PATCH] qemu: Don't warn about missing device in DEVICE_DELETED event

Debug priority is good enough for this. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3d0a120..8384314 100644 ---

[libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

virsh maxvcpus --type kvm output is useless on PPC. Also, in commit e6806d79 we documented not rely on virConnectGetMaxVcpus output. Fix the maxvcpus to use virConnectGetDomainCapabilities now to make it useful. The call is made to use the default emulator binary and to check for the host machine

Re: [libvirt] [PATCH] docs: Add libvirt-go Go bindings to binding page

On 06.09.2016 12:47, Roman Mohr wrote: > Signed-off-by: Roman Mohr > --- > docs/bindings.html.in | 4 > 1 file changed, 4 insertions(+) > > diff --git a/docs/bindings.html.in b/docs/bindings.html.in > index 95cfe25..7fe26df 100644 > --- a/docs/bindings.html.in > +++

Re: [libvirt] [PATCH 1/2] qemu: add a max_core setting to qemu.conf for core dump size

On Wed, Aug 17, 2016 at 05:04:48PM -0400, John Ferlan wrote: > > > On 08/03/2016 11:31 AM, Daniel P. Berrange wrote: > > Currently the QEMU processes inherit their core dump rlimit > > from libvirtd, which is really suboptimal. This change allows > > their limit to be directly controlled from

[libvirt] [PATCH] virsh: Fix *-event error string

When using virsh net-event non-existing-net the error message says that 'either --list or event type is required' This is misleading as 'virsh net-event $valid-event-type' is not going to work either. What is expected is 'virsh net-event --event $valid-event-type' This commit fixes the string in

Re: [libvirt] [PATCH] Prefix major/minor with gnu_dev_

On Mon, 2016-09-05 at 14:47 +0100, Daniel P. Berrange wrote: > On Mon, Sep 05, 2016 at 03:33:36PM +0200, Michal Privoznik wrote: > >  > > In the latest glibc, major() and minor() functions are marked as > > deprecated (glibc commit dbab6577): > >  > >   CC   util/libvirt_util_la-vircgroup.lo >

Re: [libvirt] [libvirt-php] libvirt_connect not reading out credential info on 0.5.2

On 05.09.2016 23:08, Fernando Casas Schössow wrote: > Hi again Michal, > > I have more information to share. > I think I can confirm that the patches are actually fixing the > credentials problem and they are passed along. > This is the content of test.log with libvirt-php output: > >

Re: [libvirt] Nice golang bindings for libvirt

Hi Martin, On Tue, Sep 6, 2016 at 11:30 AM, Martin Kletzander wrote: > On Mon, Sep 05, 2016 at 05:44:03PM +0200, Roman Mohr wrote: > >> Hi all, >> >> I have been using these pretty nice libvirt-binding library for golang >> [1]. >> It is under active development, pretty

[libvirt] [PATCH] docs: Add libvirt-go Go bindings to binding page

Signed-off-by: Roman Mohr --- docs/bindings.html.in | 4 1 file changed, 4 insertions(+) diff --git a/docs/bindings.html.in b/docs/bindings.html.in index 95cfe25..7fe26df 100644 --- a/docs/bindings.html.in +++ b/docs/bindings.html.in @@ -14,6 +14,10 @@ C#: Arnaud

Re: [libvirt] virt-admin commands aliases

On Tue, Sep 06, 2016 at 09:02:19AM +0200, Erik Skultety wrote: On 05/09/16 19:48, Daniel P. Berrange wrote: On Mon, Sep 05, 2016 at 05:37:07PM +0200, Erik Skultety wrote: Hi there, after my presentation at KVM Forum, it was pointed out from the audience that we might think about doing

Re: [libvirt] Nice golang bindings for libvirt

On Mon, Sep 05, 2016 at 05:44:03PM +0200, Roman Mohr wrote: Hi all, I have been using these pretty nice libvirt-binding library for golang [1]. It is under active development, pretty well maintained and has a very nice travis setup to run tests against libvirt [2]. I was wondering if the

Re: [libvirt] [libvirt-glib/libvirt-gconfig 17/17] gconfig, graphics: Avoid crash when gvir_config_object_new_from_xml() returns NULL

On Thu, Apr 21, 2016 at 01:05:45PM +0200, Christophe Fergeau wrote: > This issues is more widespread than that, it would be better to fix it > everywhere in one go (maybe through a gvir_config_object_check_type() or > something like this?) I believe this patch should do for now (with runtime

[libvirt] virsh blockcopy or virDomainBlockCopy auto converge

Does it possible to add something like auto converge in live migration to blockcopy ? In my case i'm try to do virsh blockcopy --pivot and sometime it fails because domain write more data and it needs to be copied. -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru -- libvir-list mailing list

Re: [libvirt] virt-admin commands aliases

On 05/09/16 19:48, Daniel P. Berrange wrote: > On Mon, Sep 05, 2016 at 05:37:07PM +0200, Erik Skultety wrote: >> Hi there, >> >> after my presentation at KVM Forum, it was pointed out from the audience >> that we might think about doing something about the naming of the >> virt-admin's comands,