Re: [libvirt] [PATCH v5 2/9] conf: Introduce chartcp_tls_x509_cert_dir

On 08/05/2016 04:19 AM, Daniel P. Berrange wrote: > In the subject s/chartcp/chardev/ > > On Thu, Aug 04, 2016 at 11:21:20AM -0400, John Ferlan wrote: >> Add a new TLS X.509 certificate type - "chardev". This will handle the >> creation of a TLS certificate capability (and possibly repository)

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

On Fri, 9 Sep 2016 00:18:10 +0530 Kirti Wankhede wrote: > On 9/8/2016 3:43 AM, Alex Williamson wrote: > > On Wed, 7 Sep 2016 23:36:28 +0530 > > Kirti Wankhede wrote: > > > >> On 9/7/2016 10:14 PM, Alex Williamson wrote: > >>> On Wed, 7 Sep 2016

Re: [libvirt] [PATCH] usb: allow host devices to be specified by port

Thanks for the patch. Sorry this didn't get a timely response. Note there's an upstream bug for this as well but it doesn't add much: https://bugzilla.redhat.com/show_bug.cgi?id=914883 The patch is a bit difficult to review because it's mixing up some refactorings in virhostdev.c with the

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

On 9/8/2016 3:43 AM, Alex Williamson wrote: > On Wed, 7 Sep 2016 23:36:28 +0530 > Kirti Wankhede wrote: > >> On 9/7/2016 10:14 PM, Alex Williamson wrote: >>> On Wed, 7 Sep 2016 21:45:31 +0530 >>> Kirti Wankhede wrote: >>> On 9/7/2016 2:58

[libvirt] xen/libvirt freeze while attching network-device to vm´s - question about provided patches

Hello everybody, a colleague of me described last november a problem that we have with libvirt and xen https://www.redhat.com/archives/libvir-list/2015-November/msg00130.html Jim Fehlig provided for this problem a patch a few days later:

Re: [libvirt] [PATCH 00/16] Hyper-V: Improve 2008, Introduce 2012

Disregard my last email, it seems that while copying the patches from my browser some invisible chars got in. So I extracted the patches from the mailist txt archive. Now they are all applied just fine. Thanks. On jue, sep 8, 2016 at 6:48 , Fernando Casas Schössow

Re: [libvirt] [PATCH 00/16] Hyper-V: Improve 2008, Introduce 2012

Hi Phil, May I ask which libvirt version are you patching against? I'm trying to apply this patches to libvirt 2.2.0 but some of them are failing (for example patch 7). Thanks. Fer On jue, sep 8, 2016 at 12:28 , Philipp Heckel wrote: We have a lot more implemented, but

Re: [libvirt] [PATCH] security: Fixing wrong label in virt-aa-helper.c.

Thanks John, Don't worry. We are here to help you, guys. :-) Julio Cesar Faracco 2016-09-07 19:09 GMT-03:00 John Ferlan : > > > On 09/07/2016 05:43 PM, Julio Faracco wrote: >> There is an issue with a wrong label inside vah_add_path(). >> The compilation fails with the

Re: [libvirt] [PATCH 2/2] qemu: Remove stale transient def when migration fails

On Thu, Sep 08, 2016 at 16:21:04 +0200, Jiri Denemark wrote: > If a migration of a domain which is already defined on the destination > host failed early (before we tried to start QEMU), we would forget to > remove the incoming transient definition. Later on when someone starts > the domain on the

Re: [libvirt] [PATCH 1/2] Add helper for removing transient definition

On Thu, Sep 08, 2016 at 16:21:03 +0200, Jiri Denemark wrote: > The code for replacing domain's transient definition with the persistent > one is repeated in several places and we'll need to add one more. Let's > make a nice helper for it. > > Signed-off-by: Jiri Denemark >

[libvirt] [PATCH 2/2] qemu: Remove stale transient def when migration fails

If a migration of a domain which is already defined on the destination host failed early (before we tried to start QEMU), we would forget to remove the incoming transient definition. Later on when someone starts the domain on the destination host, we will use the stale incoming definition and the

[libvirt] [PATCH 1/2] Add helper for removing transient definition

The code for replacing domain's transient definition with the persistent one is repeated in several places and we'll need to add one more. Let's make a nice helper for it. Signed-off-by: Jiri Denemark --- src/conf/domain_conf.c | 19 +++

[libvirt] [PATCH 0/2] qemu: Remove stale transient def when migration fails

If a migration of a domain which is already defined on the destination host failed early (before we tried to start QEMU), we would forget to remove the incoming transient definition. Later on when someone starts the domain on the destination host, we will use the stale incoming definition and the

Re: [libvirt] [PATCH v2 01/10] Introduce NVDIMM memory model

On Thu, Sep 08, 2016 at 14:59:07 +0100, Daniel Berrange wrote: > On Thu, Sep 08, 2016 at 03:50:40PM +0200, Michal Privoznik wrote: [...] > This is very different to how we deal with addressing for all other > types of device in libvirt, where we always assign addresses > immediately at time the

Re: [libvirt] [PATCH v2 01/10] Introduce NVDIMM memory model

On Thu, Sep 08, 2016 at 03:50:40PM +0200, Michal Privoznik wrote: > > After going through patch 3, I'm beginning to think it wouldn't be such > > a good idea to keep nvdimm's and dimm's in the same nmems list. I think > > they might just be too different. I also recall some algorithm > >

Re: [libvirt] [PATCH v2 01/10] Introduce NVDIMM memory model

On 01.09.2016 00:51, John Ferlan wrote: > > > On 08/11/2016 09:26 AM, Michal Privoznik wrote: >> NVDIMM is new type of memory introduced in qemu. The idea is that > > s/in qemu/into QEMU 2.6/ > >> we have a DIMM module that keeps the data persistent across > > s/DIMM/Non Volatile memory/ >

[libvirt] Opening a read-only connection - with SASL auth.

Looking at the collectd virt plugin, it opens a read only connection with libvirt[1]. We'd like to use it with SASL auth. (which oVirt configures libvirt to use by default, with a simple username/password) - is that possible? TIA, Y. [1]

Re: [libvirt] [PATCH] Allow address lease query with inactive domain

On Thu, Sep 8, 2016 at 2:46 AM, Laine Stump wrote: > On 09/07/2016 05:57 AM, Amador Pahim wrote: >> >> On Wed, Sep 7, 2016 at 11:41 AM, Daniel P. Berrange >> wrote: >>> >>> On Wed, Sep 07, 2016 at 11:18:58AM +0200, Amador Pahim wrote: The

Re: [libvirt] [PATCH] virt-admin: Document srv-list command in virt-admin's man page

On 08/09/16 10:27, Andrea Bolognani wrote: > On Wed, 2016-09-07 at 13:43 +0200, Erik Skultety wrote: >> srv-list command was missing in the man page. >> >> Signed-off-by: Erik Skultety >> --- >> tools/virt-admin.pod | 14 ++ >> 1 file changed, 14

[libvirt] [PATCH] virt-admin: Fix some English grammar in the manpage

Signed-off-by: Erik Skultety --- tools/virt-admin.pod | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Pushed as trivial. diff --git a/tools/virt-admin.pod b/tools/virt-admin.pod index 0195001..020eb51 100644 --- a/tools/virt-admin.pod +++ b/tools/virt-admin.pod

Re: [libvirt] [PATCH] virt-admin: Document srv-list command in virt-admin's man page

On Wed, 2016-09-07 at 13:43 +0200, Erik Skultety wrote: > srv-list command was missing in the man page. >  > Signed-off-by: Erik Skultety > --- >  tools/virt-admin.pod | 14 ++ >  1 file changed, 14 insertions(+) >  > diff --git a/tools/virt-admin.pod

[libvirt] [libvirt-php][PATCH 2/8] libvirt_storagepool_get_autostart: Rework

This function is written just too complicated. Signed-off-by: Michal Privoznik --- src/libvirt-php.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 33b4c5d..54de2e3 100644 ---

[libvirt] [libvirt-php][PATCH 3/8] translate_counter_type: Rework

Firstly, this function returns const char *. Then it is static. Then it's body can be written better. Signed-off-by: Michal Privoznik --- src/libvirt-php.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git

[libvirt] [libvirt-php][PATCH 8/8] libvirt_list_storagepools: Reindent

Signed-off-by: Michal Privoznik --- src/libvirt-php.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 6546ad5..3aed882 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -8785,7 +8785,7 @@

[libvirt] [libvirt-php][PATCH 4/8] libvirt_domain_block_commit: Reindent

Signed-off-by: Michal Privoznik --- src/libvirt-php.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index dfadf15..28183a6 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@

[libvirt] [libvirt-php][PATCH 6/8] libvirt_domain_disk_add: Reindent

Signed-off-by: Michal Privoznik --- src/libvirt-php.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 30ada47..067fb90 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -6170,11 +6170,11 @@

[libvirt] [libvirt-php][PATCH 1/8] libvirt_domain_get_network_info: Don't overwrite retval

In e0d6f457 I've tried to fix a memleak. However, in libvirt_domain_get_network_info instead of plain 'return' I've put 'RETURN_TRUE'. This macro throws away whatever return value we've constructed so far and replace it with integer value of 1. Le sigh. Signed-off-by: Michal Privoznik

[libvirt] [libvirt-php][PATCH 5/8] libvirt_domain_qemu_agent_command: Reindent

Signed-off-by: Michal Privoznik --- src/libvirt-php.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 28183a6..30ada47 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@

[libvirt] [libvirt-php][PATCH 7/8] libvirt_domain_disk_remove: Reindent

Signed-off-by: Michal Privoznik --- src/libvirt-php.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 067fb90..6546ad5 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -6243,9 +6243,9 @@

[libvirt] [libvirt-php][PATCH] Don't leak @mime in libvirt_domain_get_screenshot_api

When getting a screenshot of a domain via virDomainScreenshot() the MIME type of a image is returned as a string which needs to be freed by caller. However, we are not doing that anywhere. ==24748== 48 bytes in 2 blocks are definitely lost in loss record 123 of 171 ==24748==at 0x4C29F80:

[libvirt] [libvirt-php][PATCH 0/8] Couple of php fixes

Pushed under php-autopush rule. Michal Privoznik (8): libvirt_domain_get_network_info: Don't overwrite retval libvirt_storagepool_get_autostart: Rework translate_counter_type: Rework libvirt_domain_block_commit: Reindent libvirt_domain_qemu_agent_command: Reindent