[libvirt] [PATCH 1/2] mountlist: include sysmacros.h for glibc

On Fedora rawhide (glibc 2.25), './gnulib-tool --test mountlist' reports: ../../gllib/mountlist.c: In function 'read_file_system_list': ../../gllib/mountlist.c:534:13: warning: '__makedev_from_sys_types' is deprecated: In the GNU C Library, `makedev' is defined by . For historical

[libvirt] [gnulib PATCH 0/2] Work around glibc 2.25 deprecation warnings

Fedora rawhide builds of libvirt.git at commit d53fa838^ failed due to the new glibc 2.25 deprecation warning for use of major() from just ; I also found that the same warning is provoked by gnulib's mountlist module. Libvirt commit d53fa838 was a temporary hack to work around the problem, and I

[libvirt] [PATCH 2/2] sys_types: avoid glibc 2.25 warnings about major()

Todo: tweak sys_types_h.m4 comment before pushing glibc 2.25 is deprecating the namespace pollution of injecting major(), minor(), and makedev() into the compilation environment, with a warning that insists that users include instead. However, because the expansion of AC_HEADER_MAJOR didn't

Re: [libvirt] [PATCH 05/16] hyperv: implement vcpu functions

?? On 08/09/2016 08:39 AM, Jason Miesionczek wrote: > --- > src/hyperv/hyperv_driver.c | 176 > + > 1 file changed, 176 insertions(+) > > diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c > index b2d1abf..7d956d3 100644 > ---

Re: [libvirt] [PATCH 01/16] hyperv: additional server 2008 wmi classes

On 09/14/2016 05:39 PM, Philipp Heckel wrote: > Thanks for looking at the pulls. > > Small update on the continued progress of the Hyper-V integration. We > started developing against master (as opposed to against 1.3.1), and > will try to keep the code updated in this branch: >

Re: [libvirt] [PATCH 04/16] hyperv: implement connectGetVersion

On 08/09/2016 08:39 AM, Jason Miesionczek wrote: > --- > src/hyperv/hyperv_driver.c | 52 > ++ > 1 file changed, 52 insertions(+) > > diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c > index 4a5e80d..b2d1abf 100644 > ---

Re: [libvirt] [PATCH 01/16] hyperv: additional server 2008 wmi classes

Thanks for looking at the pulls. Small update on the continued progress of the Hyper-V integration. We started developing against master (as opposed to against 1.3.1), and will try to keep the code updated in this branch: https://github.com/datto/libvirt/compare/master...datto-master-hyperv.

Re: [libvirt] [PATCH 02/16] hyperv: add cim types support to code generator

2016-09-14 23:16 GMT+02:00 John Ferlan : > > > On 08/09/2016 08:39 AM, Jason Miesionczek wrote: >> --- >> src/hyperv/hyperv_wmi_generator.py | 57 >> -- >> 1 file changed, 54 insertions(+), 3 deletions(-) >> > > Not that familiar with the

Re: [libvirt] [PATCH 01/16] hyperv: additional server 2008 wmi classes

2016-09-14 23:00 GMT+02:00 John Ferlan : > > > On 08/09/2016 08:39 AM, Jason Miesionczek wrote: >> --- >> src/hyperv/hyperv_wmi_generator.input | 485 >> ++ >> 1 file changed, 485 insertions(+) >> > > I figure I can give at least "some"

Re: [libvirt] [PATCH 03/16] hyperv: add get capabilities

On 08/09/2016 08:39 AM, Jason Miesionczek wrote: > --- > src/hyperv/hyperv_driver.c | 106 > +++- > src/hyperv/hyperv_private.h | 2 + > 2 files changed, 107 insertions(+), 1 deletion(-) > > diff --git a/src/hyperv/hyperv_driver.c

Re: [libvirt] [PATCH 02/16] hyperv: add cim types support to code generator

On 08/09/2016 08:39 AM, Jason Miesionczek wrote: > --- > src/hyperv/hyperv_wmi_generator.py | 57 > -- > 1 file changed, 54 insertions(+), 3 deletions(-) > Not that familiar with the needs here. I assume it's fine, but your commit message should describe

Re: [libvirt] [PATCH 01/16] hyperv: additional server 2008 wmi classes

On 08/09/2016 08:39 AM, Jason Miesionczek wrote: > --- > src/hyperv/hyperv_wmi_generator.input | 485 > ++ > 1 file changed, 485 insertions(+) > I figure I can give at least "some" feedback. There's not a lot of hyperv experience on the team so whether what's

Re: [libvirt] [PATCH v1 3/4] libxl: implement virConnectCompareCPU

On 09/12/2016 11:50 AM, Michal Privoznik wrote: > On 20.07.2016 21:08, Joao Martins wrote: >> Implement support for "virsh cpu-compare" so that we can calculate >> common cpu element between a pool of hosts, which had a requirement >> of providing host cpu description. >> >> Signed-off-by: Joao

Re: [libvirt] [PATCH v1 0/4] libxl: host cpu element in capabilities

On 09/12/2016 11:50 AM, Michal Privoznik wrote: > On 20.07.2016 21:08, Joao Martins wrote: >> Hey, >> >> This small series implements host cpu description in caps, by getting >> topology and xen hwcaps parsing done, followed by having >> cpu-{compare,baseline} APIs implemented. Last thing

Re: [libvirt] [PATCH 28/41] Show host model in domain capabilities

On Tue, Aug 30, 2016 at 10:49:25 -0400, John Ferlan wrote: ... > > - No mode specific details are provided yet. > > + > > +If host-model is supported by the hypervisor, the > > +mode describes the guest CPU which will be used when > > +starting a domain with

Re: [libvirt] [PATCH 26/41] qemu: Store host-model CPU in qemu capabilities

On Tue, Aug 30, 2016 at 10:27:44 -0400, John Ferlan wrote: ... > > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c > > index 8f55fcc..97dc877 100644 > > --- a/src/qemu/qemu_capabilities.c > > +++ b/src/qemu/qemu_capabilities.c > > @@ -374,6 +374,7 @@ struct _virQEMUCaps {

Re: [libvirt] [PATCH] qemu-migration: Disallow migration of read only disk

On Wed, Sep 14, 2016 at 10:37:07AM -0400, Corey S. McQuay wrote: > Currently Libvirt allows attempts to migrate read only disks. Qemu cannot > handle this as read only > disks cannot be written to on the destination system. The end result is a > cryptic error message > and a failed migration. >

[libvirt] [PATCH] qemu-migration: Disallow migration of read only disk

Currently Libvirt allows attempts to migrate read only disks. Qemu cannot handle this as read only disks cannot be written to on the destination system. The end result is a cryptic error message and a failed migration. This patch causes migration to fail earlier and provides a meaningful error

Re: [libvirt] [PATCH 20/41] domcaps: Add CPU usable flag

[...] >>> @@ -399,7 +412,16 @@ virDomainCapsCPUFormat(virBufferPtr buf, >>>virCPUModeTypeToString(VIR_CPU_MODE_CUSTOM)); >>> if (cpu->custom && cpu->custom->count) { >>> virBufferAddLit(buf, "supported='yes'>\n"); >>> -

Re: [libvirt] [PATCH 25/41] conf: Introduce virCPUDefCopyModelFilter

On Tue, Aug 30, 2016 at 10:25:10 -0400, John Ferlan wrote: > > > On 08/12/2016 09:33 AM, Jiri Denemark wrote: > > The function filters all CPU features through a given callback while > > copying CPU model related parts of a CPU definition. > > > > Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH 24/41] conf: Introduce virCPUDefMoveModel

On Tue, Aug 30, 2016 at 10:24:07 -0400, John Ferlan wrote: > > > On 08/12/2016 09:33 AM, Jiri Denemark wrote: > > The function moves CPU model related parts from one CPU definition to > > another. It can be used to avoid unnecessary copies from a temporary CPU > > definitions which will be freed

Re: [libvirt] [PATCH 23/41] conf: Introduce virCPUDefCopyWithoutModel

On Tue, Aug 30, 2016 at 10:23:10 -0400, John Ferlan wrote: > > > On 08/12/2016 09:33 AM, Jiri Denemark wrote: > > Useful for copying a CPU definition without model related parts (i.e., > > without model name, feature list, vendor). > > > > Signed-off-by: Jiri Denemark > >

Re: [libvirt] [PATCH 22/41] qemu: Propagate virCapsPtr to virQEMUCapsNewForBinaryInternal

On Mon, Aug 29, 2016 at 19:31:22 -0400, John Ferlan wrote: > > > On 08/12/2016 09:33 AM, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > src/qemu/qemu_capabilities.c | 25 +++-- > > src/qemu/qemu_capabilities.h | 6 -- > >

Re: [libvirt] [PATCH 20/41] domcaps: Add CPU usable flag

On Mon, Aug 29, 2016 at 19:21:24 -0400, John Ferlan wrote: ... > > @@ -183,6 +183,10 @@ > > > > The mode element contains a list of supported CPU > > models, each described by a dedicated model element. > > +The usable attribute specifies whether the model can > >

Re: [libvirt] [PATCH 2/2] tests: Self test virt-admin

On 14.09.2016 12:58, Erik Skultety wrote: > On 14/09/16 12:50, Michal Privoznik wrote: >> On 14.09.2016 12:39, Erik Skultety wrote: >>> On 14/09/16 10:17, Michal Privoznik wrote: Just like we are running 'virsh self-test' from within our test suite, we should run 'virt-admin self-test'

Re: [libvirt] [PATCH 2/2] tests: Self test virt-admin

On 14/09/16 12:50, Michal Privoznik wrote: > On 14.09.2016 12:39, Erik Skultety wrote: >> On 14/09/16 10:17, Michal Privoznik wrote: >>> Just like we are running 'virsh self-test' from within our test >>> suite, we should run 'virt-admin self-test' too. >>> >>> Signed-off-by: Michal Privoznik

Re: [libvirt] [libvirt-perl PATCH 2/2] Add support for ERR_AGENT_UNSYNCED

On Fri, Sep 09, 2016 at 01:12:01PM -0400, John Ferlan wrote: > Allows libvirt-perl to build with upstream libvirt. > > Signed-off-by: John Ferlan > --- > Changes | 1 + > Virt.xs | 1 + > lib/Sys/Virt/Error.pm | 4 > 3 files changed, 6

Re: [libvirt] [libvirt-perl PATCH 1/2] Add support for VIR_SECRET_USAGE_TYPE_TLS

On Fri, Sep 09, 2016 at 01:12:00PM -0400, John Ferlan wrote: > Allows libvirt-perl to build with upstream libvirt. > > Signed-off-by: John Ferlan > --- > Changes| 1 + > Virt.xs| 1 + > lib/Sys/Virt/Secret.pm | 7 +++ > 3 files changed, 9

Re: [libvirt] [PATCH 2/2] tests: Self test virt-admin

On 14.09.2016 12:39, Erik Skultety wrote: > On 14/09/16 10:17, Michal Privoznik wrote: >> Just like we are running 'virsh self-test' from within our test >> suite, we should run 'virt-admin self-test' too. >> >> Signed-off-by: Michal Privoznik >> --- >> .gitignore

Re: [libvirt] [PATCH 2/2] virDomainGetBlockJobInfo: Fix corner case when qemu reports no info

On 13.09.2016 19:03, Eric Blake wrote: > On 09/13/2016 06:02 AM, Michal Privoznik wrote: > >>> So, just to make it crystal clear, is this what you're saying? >>> >>> ready | initial C/R |fudged C/R >> >> Oh, This should have been C/E instead of C/R. Current/End. 'e' and 'r' >> keys are just too

Re: [libvirt] [PATCH 2/2] tests: Self test virt-admin

On 14/09/16 10:17, Michal Privoznik wrote: > Just like we are running 'virsh self-test' from within our test > suite, we should run 'virt-admin self-test' too. > > Signed-off-by: Michal Privoznik > --- > .gitignore | 1 + > tests/Makefile.am | 1 +

Re: [libvirt] [PATCH] qemu_driver: pass path of compress prog directly

At 2016-09-13 23:47:10, "John Ferlan" wrote: > > >On 08/27/2016 03:13 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> We check compress prog in qemuCompressProgramAvailable, >> then check it again in virExec. >> >> This path will pass compress

Re: [libvirt] [PATCH 19/41] domcaps: Show only CPU models supported by libvirt

On Mon, Aug 29, 2016 at 18:01:21 -0400, John Ferlan wrote: ... > My Coverity environment had a build failure here: > > conf/domain_capabilities.c: In function 'virDomainCapsCPUModelsFilter': > conf/domain_capabilities.c:183:48: error: passing argument 1 of > 'virStringArrayHasString' from

Re: [libvirt] [PATCH 17/41] cpu: Special case models == NULL in cpuGetModels

On Mon, Aug 29, 2016 at 17:59:21 -0400, John Ferlan wrote: ... > > @@ -1127,9 +1127,13 @@ cmdCPUModelNames(vshControl *ctl, const vshCmd *cmd) > > return false; > > } > > > > -for (i = 0; i < nmodels; i++) { > > -vshPrint(ctl, "%s\n", models[i]); > > -

Re: [libvirt] [PATCH 16/41] qemu: Fill in CPU domain capabilities

On Mon, Aug 29, 2016 at 17:59:02 -0400, John Ferlan wrote: > > > On 08/12/2016 09:33 AM, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > src/qemu/qemu_capabilities.c | 24 +- > > src/qemu/qemu_capabilities.h |

Re: [libvirt] [PATCH 15/41] qemu: Introduce virQEMUCapsGuestIsNative

On Mon, Aug 29, 2016 at 17:56:29 -0400, John Ferlan wrote: ... > > @@ -852,7 +863,7 @@ virQEMUCapsInitGuest(virCapsPtr caps, > > * arm is different in that 32-on-64 _only_ works with > > * qemu-system-aarch64. So we have to add it to the kvmbins list > > */ > > -

Re: [libvirt] [PATCH 4/4] qemu: domain: Don't infer vcpu state

On Tue, Sep 13, 2016 at 06:27:46PM +0200, Peter Krempa wrote: > Use the state information (online, hotpluggable) provided by the monitor > code rather than trying to infer it. This fixes a issue where on s/a issue/an issue/ > architectures that require hotplug of multiple threads at once the >

Re: [libvirt] [PATCH 2/4] qemu: monitor: qemuMonitorGetCPUInfoHotplug: Add iterator 'anycpu'

On Tue, Sep 13, 2016 at 06:27:44PM +0200, Peter Krempa wrote: > Add separate iterator for iterating all the entries > --- > src/qemu/qemu_monitor.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > ACK Pavel -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 3/4] qemu: monitor: Add vcpu state information to monitor data

On Tue, Sep 13, 2016 at 06:27:45PM +0200, Peter Krempa wrote: > Return whether a vcpu entry is hotpluggable or online so that upper > layers don't have to infer the information from other data. > > Advantage is that this code can be tested by unit tests. > --- > src/qemu/qemu_monitor.c

Re: [libvirt] [PATCH 1/4] qemu: monitor: Use a more obvious iterator name

On Tue, Sep 13, 2016 at 06:27:43PM +0200, Peter Krempa wrote: > The algorithm that matches data from query-cpus and > query-hotpluggable-cpus is quite complex. Start using descriptive > iterator names to avoid confusion. > --- > src/qemu/qemu_monitor.c | 25 + > 1 file

Re: [libvirt] [PATCH 1/2] virsh: Move cmdSelfTest to vsh

On 14/09/16 10:17, Michal Privoznik wrote: > This command should be exposed to other shells of ours. > They are gonna need it as soon as we want to test them too. > > Signed-off-by: Michal Privoznik > --- > tools/virsh.c | 45 + >

Re: [libvirt] [PATCH 11/41] qemu: Separate guest CPU validation from command line creation

On Mon, Aug 29, 2016 at 15:21:43 -0400, John Ferlan wrote: ... > > -driver.caps->host.cpu->arch = VIR_ARCH_AARCH64; > > +qemuTestSetHostArch(driver.caps, VIR_ARCH_AARCH64); > > DO_TEST("aarch64-kvm-32-on-64", > > QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_DEVICE_VIRTIO_MMIO, > >

[libvirt] [PATCH 1/2] virsh: Move cmdSelfTest to vsh

This command should be exposed to other shells of ours. They are gonna need it as soon as we want to test them too. Signed-off-by: Michal Privoznik --- tools/virsh.c | 45 + tools/vsh.c | 38

[libvirt] [PATCH 2/2] tests: Self test virt-admin

Just like we are running 'virsh self-test' from within our test suite, we should run 'virt-admin self-test' too. Signed-off-by: Michal Privoznik --- .gitignore | 1 + tests/Makefile.am | 1 + tests/virsh-self-test | 21 -

[libvirt] [PATCH 0/2] Introduce basic virt-admin-self-test

I've realized we do no testing of virt-admin yet while reviewing Erik's patches. Michal Privoznik (2): virsh: Move cmdSelfTest to vsh tests: Self test virt-admin .gitignore | 1 + tests/Makefile.am | 1 + tests/virsh-self-test | 21 -

Re: [libvirt] [PATCH v2 0/3] Introduce aliases for virt-admin's srv-* commands

On 13/09/16 17:11, Erik Skultety wrote: > the original version: > https://www.redhat.com/archives/libvir-list/2016-September/msg00312.html > > since v1: > - tweaked the virsh-self-test so that it also checks the aliased commands > instead of skipping them (since there was a good reason

Re: [libvirt] [PATCH 0/2] Fix vcpu hotplug with memoryless NUMA nodes

On Tue, Sep 13, 2016 at 05:08:02PM +0200, Peter Krempa wrote: See patch 2. Peter Krempa (2): util: numa: Remove impossible error handling numa: Rename virNumaGetHostNodeset and make it return only nodes with memory Looks sane, ACK. src/libvirt_private.syms | 2 +-

[libvirt] [PATCH 0/4] qemu: fix vcpupin/emulatorpin with --config on VMs with automatic NUMA pinning

The automatic nodeset would creep into the persistent definition for live VMs with automatic pinning which is incorrect. https://bugzilla.redhat.com/show_bug.cgi?id=1365779 Peter Krempa (4): conf: Introduce virDomainObjGetOneDefState qemu: domain: Add macro to simplify access to vm private

[libvirt] [PATCH 2/4] qemu: domain: Add macro to simplify access to vm private data

Sometimes adding a separate variable to access vm->privateData is not necessary. Add a macro that will do the typecasting rather than having to add a temp variable to force the compiler to typecast it. --- src/qemu/qemu_domain.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[libvirt] [PATCH 4/4] qemu: driver: Don't return automatic NUMA emulator pinning data for persistentDef

Calling virDomainGetEmulatorPinInfo on a live VM with automatic NUMA pinning and VIR_DOMAIN_AFFECT_CONFIG would return the automatic pinning data in some cases which is bogus. Use the autoCpuset property only when called on a live definition. Resolves:

[libvirt] [PATCH 1/4] conf: Introduce virDomainObjGetOneDefState

Return whether the live or persistent definition was returned. Sometimes it's necessary to base the decisions on this. --- src/conf/domain_conf.c | 40 src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + 3 files changed, 40 insertions(+),

[libvirt] [PATCH 3/4] qemu: driver: Don't return automatic NUMA vCPU pinning data for persistentDef

Calling virDomainGetVcpuPinInfo on a live VM with automatic NUMA pinning and VIR_DOMAIN_AFFECT_CONFIG would return the automatic pinning data in some cases which is bogus. Use the autoCpuset property only when called on a live definition. Resolves: