[libvirt] [PATCH 1/1] qemu: host NUMA hugepage policy without guest NUMA

At the moment, guests that are backed by hugepages in the host are only able to use policy to control the placement of those hugepages on a per-(guest-)CPU basis. Policy applied globally is ignored. Such guests would use and a block with but no elements. This patch corrects this by, in this

Re: [libvirt] [PATCH] sheepdog: allow snapshot

On 11.10.2016 19:30, Vasiliy Tolstov wrote: > 2016-09-29 16:00 GMT+03:00 Vasiliy Tolstov : >> partially revert f7c1410b0ee5b878e81f2eddf86c609947a9b27c because >> sheepdog allow to store vm state inside vdi >> > > Sorry, can somebody check this? > >> Signed-off-by: Vasiliy

Re: [libvirt] [PATCH 3/3] qemu: add support for simpler UEFI config

On 10/03/2016 11:49 AM, Daniel P. Berrange wrote: > This wires up the domain XML post-parse callback so that > it can fill in the loader/nvram paths, when seeing the > "firmware" attribute set. > > Signed-off-by: Daniel P. Berrange > --- > src/qemu/qemu_command.c

Re: [libvirt] [PATCH 2/3] conf: add support for choosing firmware type

On 10/03/2016 11:49 AM, Daniel P. Berrange wrote: > Currently if you want to enable UEFI firmware for a guest > you need to know about the hypervisor platform specific > firmware path. This does not even work for all platforms, > as hypervisors like VMWare don't expose UEFI as a path, > they

Re: [libvirt] [PATCH 1/3] firmware: include arch and features in firmware file list

On 10/03/2016 11:49 AM, Daniel P. Berrange wrote: > Currently qemu.conf contains a nvram parameter which > lists firmware code files and the corresponding nvram > file path. We need to know which architecture and > features are associated with each firmware file for > future enhancement. This

[libvirt] [PATCH] util: Alter return value of virReadFCHost and fix mem leak

https://bugzilla.redhat.com/show_bug.cgi?id=1357416 Rather than return a 0 or -1 and the *result string, return just the result string to the caller. Alter all the callers to handle the different return. As a side effect or result of this, it's much clearer that we cannot just assign the

[libvirt] [PATCH] virsh: vol-resize: be explicit that this is an offline operation.

No time to read manpages at home heheh (qemu-img check -r all repaired it very well though). --- tools/virsh-volume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index f302f95..46c36c2 100644 --- a/tools/virsh-volume.c +++

Re: [libvirt] [PATCH 3/4] vbox: change API (un)initialization logic.

On Tue, 2016-10-11 at 10:58 -0400, Dawid Zamirski wrote: > On Tue, 2016-10-11 at 16:22 +0200, Martin Kletzander wrote: > > On Wed, Sep 28, 2016 at 01:41:35PM -0400, Dawid Zamirski wrote: > >  > > > I don't understand how vbox works, but if initializing > > g_pVBoxGlobalData > > does not make any

[libvirt] libvirt API / balloon last-update

Hi, I see that recently the last-update field has been added to the balloon statistics, this is how it looks like from Python: [(, {'balloon.rss': 960048L, 'balloon.swap_in': 0L, 'balloon.usable': 1676424L, 'balloon.unused': 1376188L, 'balloon.major_fault': 816L, 'balloon.swap_out': 0L,

Re: [libvirt] [PATCH v3 09/18] qemu: set/use info->pciConnectFlags during qemuDomainAssignDevicePCISlots

On 10/04/2016 10:11 AM, Andrea Bolognani wrote: On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote: Set pciConnectFlags in each device's DeviceInfo prior to assigning PCI addresses, and then use those flags later when actually assigning the addresses with qemuDomainPCIAddressReserveNextAddr()

[libvirt] [PATCH 5/6] virsh: Extract fallback handling in cmdVcpuinfo

Put it into a separate function so that more fallback handling can be added without making a mess. --- tools/virsh-domain.c | 75 +--- 1 file changed, 54 insertions(+), 21 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

[libvirt] [PATCH 2/6] virsh: domain: Fix broken indentation in virshCPUCountCollect

I managed to space most of the code by 5 spaces instead of 4 when orignally implementing this function. --- tools/virsh-domain.c | 68 ++-- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c

[libvirt] [PATCH 4/6] virsh: Extract cpumap formatting in cmdVcpuinfo

cmdVcpuinfo will be split in upcomming patches thus extract the common code that formats pinning cpumaps for the vcpus. --- tools/virsh-domain.c | 52 +++- 1 file changed, 35 insertions(+), 17 deletions(-) diff --git a/tools/virsh-domain.c

[libvirt] [PATCH 3/6] virsh: Fix xpath queries for retrieving vcpu count

The fallback code used if virDomainGetVcpusFlags is not supported used wrong XPath queries and basically did not work at all. Fix them to point to the element instead of which was not present until lately. --- tools/virsh-domain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[libvirt] [PATCH 0/6] virsh: Fix 'vcpuinfo' on inactive VMs with new hotplug vcpus

See patch 6/6. Peter Krempa (6): util: bitmap: Make bitmaps const in virBitmapNewData and virBitmapDataToString virsh: domain: Fix broken indentation in virshCPUCountCollect virsh: Fix xpath queries for retrieving vcpu count virsh: Extract cpumap formatting in cmdVcpuinfo virsh:

[libvirt] [PATCH 6/6] virsh: vcpuinfo: Report proper vcpu numbers and data for offline VMs

If the VM is offline virsh attempted to at least report the pinning information for the VM. This would not work properly now that the vcpus can be sparse. Fix it by getting the vcpu states from the XML. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1375920 --- tools/virsh-domain.c | 109

[libvirt] [PATCH 1/6] util: bitmap: Make bitmaps const in virBitmapNewData and virBitmapDataToString

The functions just read the passed pointer so it can be marked as const. --- src/util/virbitmap.c | 6 +++--- src/util/virbitmap.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index 3b85c16..0c04f1a 100644 ---

Re: [libvirt] [PATCH 3/4] vbox: change API (un)initialization logic.

On Tue, Oct 11, 2016 at 11:23:13AM -0400, Dawid Zamirski wrote: On Tue, 2016-10-11 at 16:22 +0200, Martin Kletzander wrote: On Wed, Sep 28, 2016 at 01:41:35PM -0400, Dawid Zamirski wrote: > > * _pfnUnitilalize decrements connectionCount in g_pVBoxGlobalData > and >  once it is down to 0, it

Re: [libvirt] [PATCH 3/4] vbox: change API (un)initialization logic.

On Tue, Oct 11, 2016 at 10:58:47AM -0400, Dawid Zamirski wrote: On Tue, 2016-10-11 at 16:22 +0200, Martin Kletzander wrote: On Wed, Sep 28, 2016 at 01:41:35PM -0400, Dawid Zamirski wrote: The allocation is not guarded by any lock, so there's still a race.  I think there should be a global

Re: [libvirt] [PATCH 3/4] vbox: change API (un)initialization logic.

On Tue, 2016-10-11 at 16:22 +0200, Martin Kletzander wrote: > On Wed, Sep 28, 2016 at 01:41:35PM -0400, Dawid Zamirski wrote: > > > > * _pfnUnitilalize decrements connectionCount in g_pVBoxGlobalData > > and > >  once it is down to 0, it calls pfnComUnitialize and > >  g_pVBoxGlobalData if

Re: [libvirt] [PATCH 4/8] conf, qemu: Add newer shmem models

On Fri, Oct 07, 2016 at 11:09:54AM -0400, John Ferlan wrote: On 09/27/2016 08:24 AM, Martin Kletzander wrote: The old ivshmem is deprecated in QEMU, so let's use the better ivshmem-{plain,doorbell} variants instead. Perhaps explained a bit differently (my understanding ;-))... Older

Re: [libvirt] [PATCH 3/4] vbox: change API (un)initialization logic.

On Tue, 2016-10-11 at 16:22 +0200, Martin Kletzander wrote: > On Wed, Sep 28, 2016 at 01:41:35PM -0400, Dawid Zamirski wrote: > > The allocation is not guarded by any lock, so there's still a > race.  I > think there should be a global struct that has only some lock in it > and > whatever global

Re: [libvirt] [PATCH 5/8] qemu: Add capabilities for ivshmem-{plain, doorbell}

On Fri, Oct 07, 2016 at 11:11:53AM -0400, John Ferlan wrote: On 09/27/2016 08:24 AM, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/qemu/qemu_capabilities.c| 4 src/qemu/qemu_capabilities.h|

Re: [libvirt] [PATCH 3/8] conf, qemu: Add support for shmem model

On Fri, Oct 07, 2016 at 03:55:44PM +0100, Daniel P. Berrange wrote: On Fri, Oct 07, 2016 at 10:53:48AM -0400, John Ferlan wrote: On 09/27/2016 08:24 AM, Martin Kletzander wrote: > Just the default one now, new ones will be added in following commits. > > Signed-off-by: Martin Kletzander

[libvirt] [Fwd: Re: [PATCH 2/4] vbox: replace vboxGlobalData with vboxPrivate.]

Sorry, forgot to CC the ML in my last reply. Forwarded Message From: Dawid Zamirski To: Martin Kletzander Subject: Re: [libvirt] [PATCH 2/4] vbox: replace vboxGlobalData with vboxPrivate. Date: Tue, 11 Oct 2016 10:43:23 -0400 On Tue,

Re: [libvirt] [PATCH] libvirt-guests: Weaken dependency on libvirtd

On Tue, Oct 11, 2016 at 03:17:07PM +0200, Andrea Bolognani wrote: On Mon, 2016-10-10 at 15:59 +0200, Martin Kletzander wrote: On Fri, Oct 07, 2016 at 10:19:53AM +0200, Andrea Bolognani wrote: >  > The Requires relationship is very strong, in that it prevents > a unit from running unless all the

Re: [libvirt] [PATCH 3/4] vbox: change API (un)initialization logic.

On Wed, Sep 28, 2016 at 01:41:35PM -0400, Dawid Zamirski wrote: Since VBOX API initialization method (pfnComInitialize) is not thread-safe and must be called from the primary thread, calling it in every vboxConnectOpen (as we used to do) leads to segmentation faults when multiple connections are

Re: [libvirt] [Qemu-devel] [PATCH v6 3/3] target-i386: Return runnability information on query-cpu-definitions

On Fri, 7 Oct 2016 17:29:02 -0300 Eduardo Habkost wrote: > Fill the "unavailable-features" field on the x86 implementation > of query-cpu-definitions. > > Cc: Jiri Denemark > Cc: libvir-list@redhat.com > Signed-off-by: Eduardo Habkost

Re: [libvirt] [PATCH 0/4] systemd-related fixes and improvements

On Tue, 2016-10-11 at 14:59 +0200, Boris Fiuczynski wrote: > > I tried upgrading from 2.2.0 to 2.3.0 a bunch of times, but > > I haven't been able to reproduce the failure you're > > reporting: libvirt-guests is never started automatically. > >  > > Can you provide more information? What

Re: [libvirt] [PATCH v6 3/3] target-i386: Return runnability information on query-cpu-definitions

On Tue, 11 Oct 2016 10:24:38 -0300 Eduardo Habkost wrote: > On Tue, Oct 11, 2016 at 03:21:05PM +0200, Igor Mammedov wrote: > > On Tue, 11 Oct 2016 08:58:02 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, Oct 11, 2016 at 01:45:21PM +0200, Igor

Re: [libvirt] [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser

Julien Grall writes ("Re: [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser"): > live migration is not currently the supported but will be in the future. > FWIW, there is a patch series on xen-devel to support dead migration > (first step for live migration) [1].

Re: [libvirt] [PATCH 2/4] vbox: replace vboxGlobalData with vboxPrivate.

On Wed, Sep 28, 2016 at 01:41:34PM -0400, Dawid Zamirski wrote: Since those stucts are identical at the moment, this patch basically does s/vboxGlobalData \*data/vboxPrivate *data/ with type casts in vboxDriverLock/Unlock calls to keep the code working and take care of unavoidable diff noise to

Re: [libvirt] [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser

Hi Ian, On 06/10/16 11:00, Ian Jackson wrote: Julien Grall writes ("Re: [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser"): On 04/10/2016 10:05, Ian Jackson wrote: Missing _. I didn't test this again before sending it. I'd still like a review from libvirt

Re: [libvirt] [PATCH 1/4] vbox: add vboxPrivate struct.

On Wed, Sep 28, 2016 at 01:41:33PM -0400, Dawid Zamirski wrote: To be passed as per-connection context info instead of using vboxGlobalData that it will eventually replace in most cases. --- src/vbox/vbox_uniformed_api.h | 30 ++ 1 file changed, 30 insertions(+) diff

Re: [libvirt] Recommendations for Libvirt LTS release

On 10/01/2016 05:15 AM, Guido Günther wrote: > Hi, > Debian is about to enter it's freeze for the Stretch release in November > and we will support the libvirt version that is in Stretch for at least > 5 years. > > The upstream version of libvirt at this point will likely be 2.4.0. Are > any

Re: [libvirt] [PATCH v6 3/3] target-i386: Return runnability information on query-cpu-definitions

On Tue, Oct 11, 2016 at 03:21:05PM +0200, Igor Mammedov wrote: > On Tue, 11 Oct 2016 08:58:02 -0300 > Eduardo Habkost wrote: > > > On Tue, Oct 11, 2016 at 01:45:21PM +0200, Igor Mammedov wrote: > > > On Mon, 10 Oct 2016 14:01:10 -0300 > > > Eduardo Habkost

Re: [libvirt] [PATCH 0/3] Make UEFI firmware config simpler

ping On Mon, Oct 03, 2016 at 04:49:46PM +0100, Daniel P. Berrange wrote: > This series lets apps enabled UEFI for a guest by > simply doing > > > > with the other (existing) attributes being auto-filled > with correct QEMU specific defaults. > > Daniel P. Berrange (3): > firmware: include

Re: [libvirt] [PATCH v6 3/3] target-i386: Return runnability information on query-cpu-definitions

On Tue, 11 Oct 2016 08:58:02 -0300 Eduardo Habkost wrote: > On Tue, Oct 11, 2016 at 01:45:21PM +0200, Igor Mammedov wrote: > > On Mon, 10 Oct 2016 14:01:10 -0300 > > Eduardo Habkost wrote: > > > On Mon, Oct 10, 2016 at 02:27:49PM +0200, Igor Mammedov

Re: [libvirt] [PATCH] libvirt-guests: Weaken dependency on libvirtd

On Mon, 2016-10-10 at 15:59 +0200, Martin Kletzander wrote: > On Fri, Oct 07, 2016 at 10:19:53AM +0200, Andrea Bolognani wrote: > >  > > The Requires relationship is very strong, in that it prevents > > a unit from running unless all the units it Requires are > > running as well. > >  > > This

Re: [libvirt] [PATCH 0/4] systemd-related fixes and improvements

On 10/07/2016 05:04 PM, Andrea Bolognani wrote: On Fri, 2016-10-07 at 11:42 +0200, Andrea Bolognani wrote: On Fri, 2016-10-07 at 11:19 +0200, Boris Fiuczynski wrote: Andrea, there is another "side effect" of the Requires directive. libvirt-guests gets automatically started when libvirt is

[libvirt] [PATCH 5/5] Clean timer in virObjectEventStateFlush

If the last event callback is unregistered while the event loop is dispatching, it is only marked as deleted, but not removed. The number of callbacks is more than zero in that case, so the timer is not removed. Because it can be removed in this function now (but also accessed afterwards so that

[libvirt] [PATCH 4/5] Add virObjectEventStateRegisterID to symsfile

To go with the Deregister version as well. Signed-off-by: Martin Kletzander --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index d92d3d865307..fd63f99b568c 100644 ---

[libvirt] [PATCH 2/5] Reference state when using it as opaque

There should be one more reference because it is being kept in the list of callbacks as an opaque. We also unref it properly using virObjectFreeCallback. Signed-off-by: Martin Kletzander --- src/conf/object_event.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[libvirt] [PATCH 1/5] Change virDomainEventState to virObjectLockable

This way we get reference counting and we can get rid of locking function. Signed-off-by: Martin Kletzander --- src/bhyve/bhyve_driver.c | 2 +- src/conf/object_event.c| 99 +++--- src/conf/object_event.h|

[libvirt] [PATCH 3/5] De-duplicate code into virObjectEventStateCleanupTimer()

There is a repeating pattern of code that removes the timer if it's not needed. So let's move it to a new function. We'll also use it later. Signed-off-by: Martin Kletzander --- src/conf/object_event.c | 34 ++ 1 file changed, 22

[libvirt] [PATCH 0/5] Various virObjectEventState fixes

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1363628 Martin Kletzander (5): Change virDomainEventState to virObjectLockable Reference state when using it as opaque De-duplicate code into virObjectEventStateCleanupTimer() Add virObjectEventStateRegisterID to symsfile Clean

Re: [libvirt] [PATCH] audit: add descriptions about audit log

On Tue, Oct 11, 2016 at 19:43:19 +0800, Chen Hanxiao wrote: > From: Chen Hanxiao > > This patch add some descriptions on what libvirt > audit will record in introduction section. > > Signed-off-by: Chen Hanxiao > --- > docs/auditlog.html.in | 4

Re: [libvirt] [PATCH v6 3/3] target-i386: Return runnability information on query-cpu-definitions

On Tue, Oct 11, 2016 at 01:45:21PM +0200, Igor Mammedov wrote: > On Mon, 10 Oct 2016 14:01:10 -0300 > Eduardo Habkost wrote: > > On Mon, Oct 10, 2016 at 02:27:49PM +0200, Igor Mammedov wrote: > > > On Fri, 7 Oct 2016 17:29:02 -0300 > > > Eduardo Habkost

Re: [libvirt] [PATCH v6 3/3] target-i386: Return runnability information on query-cpu-definitions

On Mon, 10 Oct 2016 14:01:10 -0300 Eduardo Habkost wrote: > On Mon, Oct 10, 2016 at 02:27:49PM +0200, Igor Mammedov wrote: > > On Fri, 7 Oct 2016 17:29:02 -0300 > > Eduardo Habkost wrote: > > > > > Fill the "unavailable-features" field on the x86

[libvirt] [PATCH] audit: add descriptions about audit log

From: Chen Hanxiao This patch add some descriptions on what libvirt audit will record in introduction section. Signed-off-by: Chen Hanxiao --- docs/auditlog.html.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [Qemu-devel] [PATCH] fixup! target-i386: x86_cpu_load_features() function

On Mon, 10 Oct 2016 13:58:25 -0300 Eduardo Habkost wrote: > On Mon, Oct 10, 2016 at 02:25:32PM +0200, Igor Mammedov wrote: > > On Fri, 7 Oct 2016 17:29:01 -0300 > > Eduardo Habkost wrote: > > > > > When probing for CPU model information, we need to

Re: [libvirt] [PATCH] sheepdog: allow snapshot

2016-09-29 16:00 GMT+03:00 Vasiliy Tolstov : > partially revert f7c1410b0ee5b878e81f2eddf86c609947a9b27c because > sheepdog allow to store vm state inside vdi > Sorry, can somebody check this? > Signed-off-by: Vasiliy Tolstov > --- >

Re: [libvirt] [PATCH 0/2] Sanitize vcpu topology checking

On 10.10.2016 22:01, Peter Krempa wrote: > See patch 1. > > Peter Krempa (2): > conf: Sanitize cpu topology numbers > qemu: Reuse virDomainDeGetVcpusTopology to calculate total vcpu count > > src/conf/domain_conf.c | 39 +++ > src/conf/domain_conf.h |

Re: [libvirt] [PATCH 2/2] Forbid new-line char in name of networks

On 11.10.2016 04:15, Sławek Kapłoński wrote: > New line character in name of network is now forbidden because it > mess virsh output and can be confusing for users. > > Closes-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=818064 > --- > src/conf/network_conf.c | 5 + > 1 file changed, 1

Re: [libvirt] [PATCH 0/2] Forbid new-line char in name of networks

On 11.10.2016 04:15, Sławek Kapłoński wrote: > *** BLURB HERE *** > > Sławek Kapłoński (2): > util: Add function to check if string contains some chars > Forbid new-line char in name of networks > > src/conf/network_conf.c | 5 + > src/util/virxml.c | 18 ++ >

Re: [libvirt] [PATCH 1/2] util: Add function to check if string contains some chars

On 11.10.2016 04:15, Sławek Kapłoński wrote: > This new function can be used to check if e.g. name of XML node don't > contains forbidden chars like "/" or new-line. > --- > src/util/virxml.c | 18 ++ > src/util/virxml.h | 4 > 2 files changed, 22 insertions(+) > > diff

Re: [libvirt] [PATCH v3 15/18] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

On Mon, 2016-10-10 at 15:43 -0400, Laine Stump wrote: > > > 3) Although it is strongly discouraged, it is legal for a pci-bridge > > >  to be directly plugged into pcie-root, and we don't want to > > >  auto-add a dmi-to-pci-bridge if there is already a pci-bridge > > >  that's been

Re: [libvirt] libvirt-guest.sh bug fixes

On 10.10.2016 20:43, Eric Blake wrote: > On 10/10/2016 11:48 AM, Stefan Bader wrote: > >>> I did not hear about that before. But revisiting things again I think what >>> happened is that the Xen patch which I had done before (but at that time >>> forgot >>> to submit upstream) was adding quotes

Re: [libvirt] [PATCH] libvirt-storage.c:Lines too long, use 80 character columns.

Hello Daniel, Thanks for the feedback . Actually I only line wrapped those lines exceeding 80 column limit. Rest I left unchanged. I particularly sent this patch to get feedback on whether its a rule or not as HACKING file hints at it and patch reviews point at it. Anywaz it does not make any