Re: [libvirt] [PATCH v4 10/25] [ACKED] conf: make virDomainPCIAddressGetNextSlot() a local static function

On 10/18/2016 10:46 AM, Andrea Bolognani wrote: On Fri, 2016-10-14 at 15:54 -0400, Laine Stump wrote: This function is no longer needed outside of domain_addr.c. --- src/conf/domain_addr.c | 2 +- src/conf/domain_addr.h | 5 - src/libvirt_private.syms | 1 - 3 files changed, 1

Re: [libvirt] [PATCH v4 02/25] [ACKED but has additions] qemu: replace a lot of "def->controllers[i]" with equivalent "cont"

On 10/18/2016 07:22 AM, Andrea Bolognani wrote: On Fri, 2016-10-14 at 15:53 -0400, Laine Stump wrote: There's no functional change here. This pointer was just used so many times that the extra long lines became annoying. --- Change: added more instances of the same change.

[libvirt] [PATCH 4/4] conf: Add iterators for RNG and Redirdev

Add the virDomainRNGDefForeach and +virDomainRedirdevDefForeach iterators to traverse all the RNG and Redirdevs just like the Smartcard's and Chr's Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 48

[libvirt] [PATCH 2/4] conf: Use virDomainChrSourceDefPtr for _virDomainRedirdevDef 'source.chr'

Use a pointer and the virDomainChrSourceDefNew() function in order to allocate the structure for _virDomainRedirdevDef. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 36 src/conf/domain_conf.h | 2 +- src/qemu/qemu_command.c

[libvirt] [PATCH 0/4] Complete virDomainChrSourceDefPtr adjustments

Similar to _virDomainChrDef, alter _virDomainSmartcardDef and _virDomainRedirdevDef in order to use a virDomainChrSourceDefPtr. This includes modifying the relevant allocations for the source. Next, modify the virDomainRNGDef allocation to use virDomainChrSourceNew rather than a straight

[libvirt] [PATCH 1/4] conf: Use virDomainChrSourceDefPtr for _virDomainSmartcardDef 'passthru'

Use a pointer and the virDomainChrSourceDefNew() function in order to allocate the structure for _virDomainSmartcardDef. Signed-off-by: John Ferlan --- src/conf/domain_audit.c | 2 +- src/conf/domain_conf.c | 25 -

[libvirt] [PATCH 3/4] conf: Use virDomainChrSourceDefNew for virDomainRNGDef allocation

Rather than VIR_ALLOC() the data, use virDomainChrSourceDefNew in order to get the private data if necessary. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [REPOST] regarding cgroup v2 support in libvirt

Hello, Daniel. On Fri, Oct 21, 2016 at 11:19:02AM +0100, Daniel P. Berrange wrote: > The big question I have around cgroup v2 is state of support for all > controllers that libvirt uses (cpu, cpuacct, cpuset, memory, devices, > freezer, blkio). IIUC, not all of these have been ported to cgroup >

Re: [libvirt] [PATCH 1/3] vmx: Use the allocator virDomainChrDefNew

On Fri, Oct 21, 2016 at 01:58:42PM -0400, John Ferlan wrote: > > > On 10/21/2016 12:01 PM, Pavel Hrdina wrote: > > On Fri, Oct 21, 2016 at 09:01:42AM -0400, John Ferlan wrote: > >> Rather than VIR_ALLOC of the virDomainChrDefPtr > >> > >> Signed-off-by: John Ferlan > >> ---

Re: [libvirt] [PATCH 1/3] vmx: Use the allocator virDomainChrDefNew

On 10/21/2016 12:01 PM, Pavel Hrdina wrote: > On Fri, Oct 21, 2016 at 09:01:42AM -0400, John Ferlan wrote: >> Rather than VIR_ALLOC of the virDomainChrDefPtr >> >> Signed-off-by: John Ferlan >> --- >> src/vmx/vmx.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2

[libvirt] [RFC] qemu: Use virtio-pci by default for mach-virt guests

virtio-pci is the way forward for aarch64 guests: it's faster and less alien to people coming from other architectures. Now that guest support is finally getting there, we'd like to start using it by default instead of virtio-mmio. Users and applications can already opt-in by explicitly using

Re: [libvirt] [PATCH 1/3] vmx: Use the allocator virDomainChrDefNew

On Fri, Oct 21, 2016 at 09:01:42AM -0400, John Ferlan wrote: > Rather than VIR_ALLOC of the virDomainChrDefPtr > > Signed-off-by: John Ferlan > --- > src/vmx/vmx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c >

Re: [libvirt] [PATCH 2/3] Introduce virDomainChrSourceDefNew for virDomainChrDefPtr

On Fri, Oct 21, 2016 at 09:01:43AM -0400, John Ferlan wrote: > Change the virDomainChrDef to use a pointer to 'source' and allocate > that pointer during virDomainChrDefNew. > > This has tremendous "fallout" in the rest of the code which mainly > has to change source.$field to source->$field. >

Re: [libvirt] [PATCH 3/3] conf: Move the privateData from virDomainChrDef to virDomainChrSourceDef

On Fri, Oct 21, 2016 at 09:01:44AM -0400, John Ferlan wrote: > Commit id '5f2a132786' should have placed the data in the host source > def structure since that's also used by smartcard, redirdev, and rng in > order to provide a backend tcp channel. The data in the private structure > will be

Re: [libvirt] [PATCH 11/15] qemu: capabilities: Detect support for gluster debug setting

On 10/21/2016 08:22 AM, Peter Krempa wrote: >>> static struct virQEMUCapsStringFlags virQEMUCapsQMPSchemaQueries[] = { >>> -{ "bogus/path/to/satisfy/compiler", 0 }, >>> +{ "blockdev-add/arg-type/options/+gluster/debug-level", >>> QEMU_CAPS_GLUSTER_DEBUG_LEVEL}, >> >> Okay, I see how you

Re: [libvirt] [PATCH 1/3] vz: support type=bridge network interface type correctly

07-Sep-16 14:00, Nikolay Shirokovskiy пишет: On 05.09.2016 19:39, Maxim Nestratov wrote: Recently, libprlsdk got a separate flag PNA_BRIDGE corresponding to type=bridge libvirt network interfaces. Let's use it and get rid of all workarounds previously added to support it. Signed-off-by:

Re: [libvirt] [PATCH] doc: Describe the VCPU states returned by virsh vcpuinfo

On 10/13/2016 07:08 AM, Viktor Mihajlovski wrote: > Added a brief description of the VCPU states. > > Signed-off-by: Viktor Mihajlovski > --- > tools/virsh.pod | 49 + > 1 file changed, 49 insertions(+) > ACK and

Re: [libvirt] [PATCH] xenFormatXLDisk: Fix commas for arguments

On Thu, Oct 20, 2016 at 11:05:36PM +0800, Michal Privoznik wrote: On 20.10.2016 22:27, Ján Tomko wrote: On Thu, Oct 20, 2016 at 10:16:05PM +0800, Michal Privoznik wrote: instead of: virBufferAdd(buf, "arg1,"); virBufferAdd(buf, "arg2"); lets have: virBufferAdd(buf, "arg1");

[libvirt] [PATCH 1/4] qemu: Introduce qemuDomainGetChardevTLSObjects for hotplug

As it turns out more than one place will need these objects, so rather than cut-copy-paste in each, make a helper Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 41 + 1 file changed, 29 insertions(+), 12 deletions(-) diff

[libvirt] [PATCH 4/4] qemu: Add TLS hotplug for qemuDomainAttachRNGDevice

Commit id '2c322378' missed the nuance that the rng backend could be using a TCP chardev and if TLS is enabled on the host, thus will need to have the TLS object added. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 31 +++ 1 file

[libvirt] [PATCH 3/4] qemu: Add TLS hotplug for qemuDomainAttachRedirdevDevice

Commit id '2c322378' missed the nuance that the redirdev backend could be using a TCP chardev and if TLS is enabled on the host, thus will need to have the TLS object added. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 24 1 file changed,

[libvirt] [PATCH 0/4] Add TLS for TCP chardev redirdev and rng backends

This "would" conflict with other TLS/TCP changes on list depending on order of commit, but it does work against the current top. The conflict would be limited to the new helper qemuDomainGetChardevTLSObjects and changing the 'if (!cfg->chardevTLS)' to the corresponding 'if

[libvirt] [PATCH 2/4] qemu: Clean up error path in qemuDomainAttachRedirdevDevice

It's about to get more complicated - let's alter the logic to handle various failures. Adds saving of the error as well. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git

[libvirt] [PATCH 3/6] Return directly from qemuDomainAttachChrDeviceAssignAddr

This function should never need a cleanup section. --- src/qemu/qemu_hotplug.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index cbdcd81..407ae73 100644 --- a/src/qemu/qemu_hotplug.c +++

[libvirt] [PATCH v2 01/15] util: json: add helper to iterate and steal members of json array

Simplifies cases where JSON array members need to be transferred to a different structure. --- Notes: v2: - iterate from beginning - add option to keep array member in the array without breaking iteration - documented callback return codes src/libvirt_private.syms | 1 +

[libvirt] [PATCH 4/6] Also create the USB address cache for domains with all the USB addresses

When starting a new domain, we allocate the USB addresses and keep an address cache in the domain object's private data. However this data is lost on libvirtd restart. Also generate the address cache if all the addresses have been specified, so that devices hotplugged after libvirtd restart also

[libvirt] [PATCH 5/6] Fix crash on usb-serial hotplug

For domains with no USB address cache, we should not attempt to generate a USB address. https://bugzilla.redhat.com/show_bug.cgi?id=1387665 --- src/qemu/qemu_hotplug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index

[libvirt] [PATCH v2 10/15] qemu: capabilities: Add support for QMP schema introspection

Allow detecting capabilities according to the qemu QMP schema. This is necessary as sometimes the availability of certain options depends on the presence of a field in the schema. This patch adds support for loading the QMP schema when detecting qemu capabilities and adds a very simple query

[libvirt] [PATCH 1/6] Add 'FromCache' to virDomainVirtioSerialAddrAutoAssign

We dropped the cache from QEMU's private domain object. Assume the callers do not have the cache by default and use a longer name for the internal ones that do. This makes the shorter 'virDomainVirtioSerialAddrAutoAssign' name availabe for a function that will not require the cache. ---

[libvirt] [PATCH 6/6] Do not try to release virtio serial addresses

Return 0 instead of 1, so that qemuDomainAttachChrDevice does not assume the address neeeds to be released on error. No functional change, since qemuDomainReleaseDeviceAddress has been a noop for virtio serial addresses since the address cache was removed. --- src/qemu/qemu_hotplug.c | 8

[libvirt] [PATCH 0/6] Address assignment fixes

Fixes a crash on usb-serial hotplug and missing addresses after libvirtd restart, and makes some code more readable. Ján Tomko (6): Add 'FromCache' to virDomainVirtioSerialAddrAutoAssign Introduce virDomainVirtioSerialAddrAutoAssign again Return directly from

[libvirt] [PATCH 2/6] Introduce virDomainVirtioSerialAddrAutoAssign again

This time do not require an address cache as a parameter. Simplify qemuDomainAttachChrDeviceAssignAddr to not generate the virtio serial address cache for devices of other types. --- src/conf/domain_addr.c | 21 + src/conf/domain_addr.h | 6 ++

Re: [libvirt] [PATCH 10/15] qemu: capabilities: Add support for QMP schema introspection

On Thu, Oct 20, 2016 at 15:05:21 -0500, Eric Blake wrote: > On 10/20/2016 10:25 AM, Peter Krempa wrote: [...] > > +continue; > > +} else if (STREQ(metatype, "object")) { > > +if (**query == '+') > > +basename =

Re: [libvirt] [PATCH 0/2] vz: add serial number to disk devices

22-Sep-16 17:55, Nikolay Shirokovskiy пишет: Only the first patch is really on the subject. The second one is bugfix that is included mainly because it touches the same place (and nice to have to test first patch too...) Nikolay Shirokovskiy (2): vz: add serial number to disk devices vz:

Re: [libvirt] [PATCH v2 0/3] qemu: util: vz: support setting disk serial number

21-Oct-16 12:50, Maxim Nestratov пишет: Actually this is a combination of the two previous series https://www.redhat.com/archives/libvir-list/2016-October/msg00890.html and https://www.redhat.com/archives/libvir-list/2016-September/msg01024.html Maxim Nestratov (1): util: qemu: make

Re: [libvirt] [PATCH 11/15] qemu: capabilities: Detect support for gluster debug setting

On Thu, Oct 20, 2016 at 15:17:50 -0500, Eric Blake wrote: > On 10/20/2016 10:25 AM, Peter Krempa wrote: > > From: Prasanna Kumar Kalever > > > > Teach qemu driver to detect whether qemu supports specifying debug level > > for gluster volumes. > > > > Signed-off-by:

[libvirt] [PATCH 3/3] conf: Move the privateData from virDomainChrDef to virDomainChrSourceDef

Commit id '5f2a132786' should have placed the data in the host source def structure since that's also used by smartcard, redirdev, and rng in order to provide a backend tcp channel. The data in the private structure will be necessary in order to provide the secret properly Signed-off-by: John

[libvirt] [PATCH 2/3] Introduce virDomainChrSourceDefNew for virDomainChrDefPtr

Change the virDomainChrDef to use a pointer to 'source' and allocate that pointer during virDomainChrDefNew. This has tremendous "fallout" in the rest of the code which mainly has to change source.$field to source->$field. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 1/3] vmx: Use the allocator virDomainChrDefNew

Rather than VIR_ALLOC of the virDomainChrDefPtr Signed-off-by: John Ferlan --- src/vmx/vmx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index fc4347f..f61c4d6 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -2758,7

[libvirt] [PATCH 0/3] Alter 'source' to be virDomainChrSourceDefPtr in _virDomainChrDef

Yes, it's absolutely terrifying; however, in order to "fix" problems noted during the review of the TLS chardev TCP 'properly' making the 'source' be a pointer and then moving the 'privateData' from _virDomainChrDef to _virDomainChrSourceDef will allow for setting of the 'secinfo' for the

[libvirt] [PATCH] bhyve: Need to add parameter to virDomainChrDefNew

Commit id '5f2a13278' missed this one. Signed-off-by: John Ferlan --- Pushed as build breaker https://ci.centos.org/view/libvirt-project/job/libvirt-master-build/150/systems=libvirt-freebsd/ src/bhyve/bhyve_parse_command.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [libvirt] [PATCH 4/4] qemuBuildHostNetStr: remove dead code

On Fri, Oct 14, 2016 at 04:32:18PM +0200, Ján Tomko wrote: > This function is never called for VIR_DOMAIN_NET_TYPE_HOSTDEV, > and the dead code comment agrees. > > Introduced by commit 1dcbef8a. > --- ACK Pavel signature.asc Description: Digital signature -- libvir-list mailing list

Re: [libvirt] [PATCH 3/4] qemuBuildHostNetStr: move stray VIR_DOMAIN_NET_TYPE_INTERNAL

On Fri, Oct 14, 2016 at 04:32:17PM +0200, Ján Tomko wrote: > This network type is only used by the vbox driver and it does not > make sense to group it with VIR_DOMAIN_NET_TYPE_USER. > > Introduced by commit 1dcbef8. > --- > src/qemu/qemu_command.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [libvirt] [PATCH v10 2/4] domain: Add optional 'tls' attribute for TCP chardev

On 10/21/2016 07:57 AM, Pavel Hrdina wrote: > On Fri, Oct 21, 2016 at 07:15:55AM -0400, John Ferlan wrote: >> >> >> On 10/21/2016 02:29 AM, Pavel Hrdina wrote: >>> On Thu, Oct 20, 2016 at 03:48:30PM -0400, John Ferlan wrote: [...] >> >> Since I assume you have these changes in your

Re: [libvirt] [REPOST] regarding cgroup v2 support in libvirt

On Fri, 21.10.16 11:19, Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Oct 20, 2016 at 02:59:45PM -0400, Tejun Heo wrote: > > (reposting w/ libvir-list cc'd, sorry about the delay in reposting, > > was traveling and then on vacation) > > > > Hello, Daniel. How have you been? > > >

Re: [libvirt] [PATCH 2/4] qemuBuildHostNetStr: do not start options with a comma

On Fri, Oct 14, 2016 at 04:32:16PM +0200, Ján Tomko wrote: > Put the comma at the end and trim it later for consistency. > --- ACK Pavel signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/4] qemuBuildHostNetStr: use type_sep earlier

On Fri, Oct 14, 2016 at 04:32:15PM +0200, Ján Tomko wrote: > When hotplugging networks with ancient QEMUs not supporting > QEMU_CAPS_NETDEV, we use space instead of a comma as the separator > between the network type and other options. > > Except for "user", all the network types pass other

Re: [libvirt] [PATCH v10 2/4] domain: Add optional 'tls' attribute for TCP chardev

On Fri, Oct 21, 2016 at 07:15:55AM -0400, John Ferlan wrote: > > > On 10/21/2016 02:29 AM, Pavel Hrdina wrote: > > On Thu, Oct 20, 2016 at 03:48:30PM -0400, John Ferlan wrote: > >> [...] > >> > > Since I assume you have these changes in your local branch - let's go > with the two patches and

Re: [libvirt] [PATCH v10 2/4] domain: Add optional 'tls' attribute for TCP chardev

On 10/21/2016 02:29 AM, Pavel Hrdina wrote: > On Thu, Oct 20, 2016 at 03:48:30PM -0400, John Ferlan wrote: >> [...] >> Since I assume you have these changes in your local branch - let's go with the two patches and move on. It would be nice while it's still fresh to update the documentation,

Re: [libvirt] [PATCH] libxl: fix leaking of allocated migration ports

On Fri, Oct 14, 2016 at 12:19:19PM -0600, Jim Fehlig wrote: > Although the migration port is immediately released in the > finish phase of migration, it was never set in the domain > private object when allocated in the prepare phase. So > libxlDomainMigrationFinish() always released a

Re: [libvirt] [RFC] Toward a better NEWS file

On Fri, Oct 21, 2016 at 12:33:44PM +0200, Sławek Kapłoński wrote: > Hello, > > I'm quite new in libvirt community so I don't know all requirements > which community have but did You know about reno project from Openstack: > http://docs.openstack.org/developer/reno/ ? It's used for managing >

Re: [libvirt] [RFC] Toward a better NEWS file

Hello, I'm quite new in libvirt community so I don't know all requirements which community have but did You know about reno project from Openstack: http://docs.openstack.org/developer/reno/ ? It's used for managing releae notes which are added in git as separate files. Maybe it can be some

Re: [libvirt] [REPOST] regarding cgroup v2 support in libvirt

On Thu, Oct 20, 2016 at 02:59:45PM -0400, Tejun Heo wrote: > (reposting w/ libvir-list cc'd, sorry about the delay in reposting, > was traveling and then on vacation) > > Hello, Daniel. How have you been? > > We (facebook) are deploying cgroup v2 and internally use libvirt to > manage virtual

[libvirt] [PATCH v2 3/3] vz: add serial number to disk devices

From: Nikolay Shirokovskiy vz sdk supports setting serial number only for disk devices. Getting serial upon cdrom(for example) is error however setting is just ignored. Let's check for disk device explicitly for clarity in both cases. Setting serial number for other

[libvirt] [PATCH v2 1/3] vz: set something in disk driver name

From: Nikolay Shirokovskiy Absent driver name attribute is invalid xml. Which in turn makes unusable 'virsh edit' for example. The value does not make much sense and ignored on input so nobody will hurt. --- src/vz/vz_sdk.c | 3 +++ 1 file changed, 3 insertions(+)

[libvirt] [PATCH v2 0/3] qemu: util: vz: support setting disk serial number

Actually this is a combination of the two previous series https://www.redhat.com/archives/libvir-list/2016-October/msg00890.html and https://www.redhat.com/archives/libvir-list/2016-September/msg01024.html Maxim Nestratov (1): util: qemu: make qemuSafeSerialParamValue function usable by other

[libvirt] [PATCH v2 2/3] util: qemu: make qemuSafeSerialParamValue function usable by other drivers

Rename qemuSafeSerialParamValue to virSafeSerialParamValue and move it to utils Signed-off-by: Maxim Nestratov --- src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 19 +-- src/util/virutil.c | 16 src/util/virutil.h

Re: [libvirt] [RFC] Toward a better NEWS file

On Fri, Oct 21, 2016 at 10:10:50AM +0800, Michal Privoznik wrote: > On 19.10.2016 19:58, Daniel P. Berrange wrote: > > On Wed, Oct 19, 2016 at 01:53:41PM +0200, Andrea Bolognani wrote: > >> Hi, > >> > >> > > > > Why don't we simply have a NEWS file in GIT, and require that > > non-trivial

Re: [libvirt] [PATCH] vz: set localhost as vnc address

19-Oct-16 12:40, Nikolay Shirokovskiy пишет: On 18.10.2016 19:19, Mikhail Feoktistov wrote: We should set localhost as vnc address in case of empty string. Because Virtuozzo sets 0.0.0.0 as default vnc address. --- src/vz/vz_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [libvirt] [RFC] Toward a better NEWS file

On Wed, 2016-10-19 at 18:22 -0400, John Ferlan wrote: > I really think we should do something - especially to be able to > describe what's new, what was added when, etc. beyond what DV culls out > of the existing commits. >  > Whether the mechanism is some news.html.in or features.html.in or >

Re: [libvirt] [PATCH 1/2] vz: add serial number to disk devices

22-Sep-16 17:55, Nikolay Shirokovskiy пишет: vz sdk supports setting serial number only for disk devices. Getting serial upon cdrom(for example) is error however setting is just ignored. Let's check for disk device explicitly for clarity in both cases. Setting serial number for other devices

Re: [libvirt] [PATCH 2/2] vz: set something in disk driver name

22-Sep-16 17:55, Nikolay Shirokovskiy пишет: Absent driver name attribute is invalid xml. Which in turn makes unusable 'virsh edit' for example. The value does not make much sense and ignored on input so nobody will hurt. --- src/vz/vz_sdk.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [libvirt] [PATCH] virt-wireshark.m4: Defer $(prefix) substitution

On Fri, 2016-10-21 at 10:47 +0800, Michal Privoznik wrote: > > If the plugindir for wireshark is eg. > > /usr/lib64/wireshark/plugins, should we still install under > > an arbitrary $(prefix)? Will wireshark pick up the plugin > > then? >  > Well, depends how you installed wireshark. If you

Re: [libvirt] [PATCH v10 2/4] domain: Add optional 'tls' attribute for TCP chardev

On Thu, Oct 20, 2016 at 03:48:30PM -0400, John Ferlan wrote: > [...] > > + > + Since 2.4.0, the optional attribute > + tls can be used to control whether a serial chardev > + TCP communication channel would utilize a hypervisor configured > + TLS