[libvirt] Should Libvirt apply for OSS-Fuzz?

Google announced OSS-Fuzz project [1]. It's aim is to test projects with significant user base and/or critical projects to the global infrastructure. I like to think that libvirt falls in both categories :-) You can find a list of already accepted projects here [2]. Once accepted to the project we

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

On Fri, Nov 25, 2016 at 03:36:25PM +0100, Andrea Bolognani wrote: > On Wed, 2016-11-23 at 16:02 +1100, David Gibson wrote: > > > > The change from OHCI to XHCI only affected the *default* USB > > > > controller, which libvirt tries its best not to use anyway: > > > > instead, it will prefer to use

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

On Fri, Nov 25, 2016 at 02:46:21PM +0100, Andrea Bolognani wrote: > On Wed, 2016-11-23 at 16:00 +1100, David Gibson wrote: > > > Existing libvirt versions assume that pseries guests have > > > a legacy PCI root bus, and will base their PCI address > > > allocation / PCI topology decisions on that

[libvirt] [libivrt] storage: Two iSCSI node records may cause refreshing iscsi pool failed

Hi, John When starting an iscsi storage pool, libvirt will execute “iscsiadm --mode node --portal 192.168.0.42 --targetname iqn.2003-10.com. --op new”, which is called by virISCSINodeNew. This will add an iSCSI node record. The record file is

[libvirt] [PATCH 1/7] qemu: Clean up description for qemuStorageLimitsRefresh

Originally added by commit id '89646e69' prior to commit id '15fa84ac' and '71d2c172' which ensured that qemuStorageLimitsRefresh was only called for inactive domains. Adjust the comment describing the need for FIXME and move all the text to the function description. Signed-off-by: John Ferlan

[libvirt] [PATCH 4/7] util: Introduce virStorageSourceUpdatePhysicalSize

Commit id '8dc27259' introduced virStorageSourceUpdateBlockPhysicalSize in order to retrieve the physical size for a block backed source device since commit id '15fa84ac' changed to use the qemuMonitorGetAllBlockStatsInfo and qemuMonitorBlockStatsUpdateCapacity API's to (essentially) retrieve the

[libvirt] [PATCH 2/7] qemu: Add helpers to handle stat data for qemuStorageLimitsRefresh

Split out the opening of the file and fetch of the stat buffer into a helper qemuDomainStorageOpenStat. This will handle either opening the local or remote storage. Additionally split out the cleanup of that into a separate helper qemuDomainStorageCloseStat which will either close the file or

[libvirt] [PATCH 7/7] qemu: Fix GetBlockInfo setting allocation from wr_highest_offset

The libvirt-domain.h documentation indicates that for a qcow2 file in a filesystem being used for a backing store should report the disk space occupied by a file; however, commit id '15fa84ac' altered the code to trust that the wr_highest_offset should be used whenever wr_highest_offset_valid was

[libvirt] [PATCH 3/7] qemu: Introduce helper qemuDomainStorageUpdatePhysical

Currently just a shim to call virStorageSourceUpdateBlockPhysicalSize Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH 6/7] util: Introduce virStorageSourceUpdateCapacity

Instead of having duplicated code in qemuStorageLimitsRefresh and virStorageBackendUpdateVolTargetInfo to get capacity specific data about the storage backing source or volume -- create a common API to handle the details for both. As a side effect, virStorageFileProbeFormatFromBuf returns to

[libvirt] [PATCH 5/7] util: Introduce virStorageSourceUpdateBackingSizes

Instead of having duplicated code in qemuStorageLimitsRefresh and virStorageBackendUpdateVolTargetInfoFD to fill in the storage backing source or volume allocation, capacity, and physical values - create a common API that will handle the details for both. The common API will fill in "default"

[libvirt] [PATCH 0/7] Adjustments for storage/qemu volume/file backing size settings

A bit of a mix between fixing some bugs and merging some code between the block info/stats fetching of backing store data and storage backend data for volume allocation, capacity, and physical sizes. Patch 1 just adjusts some comments Patches 2-3 are code motion Patch 4 alters how domain/qemu

[libvirt] bug, libvirt, internal error

Hi, I'm having a problem with libvirt. Since a few days, when I try to create a virtual machine I get the following error and I could not solve it " Imposible completar la instalación: 'internal error: Cannot find suitable CPU model for given data' "

Re: [libvirt] [PATCH] network: write both lo and lo0 in dnsmasq configuration

Pino Toscano wrote: > When generating a new configuration for dnsmasq, add except-interface > for both lo and lo0: this should make sure the configuration works, > and is always the same for every supported OS. > > Adjust the data of networkxml2conftest to reflect the new dnsmasq >

Re: [libvirt] Libvirt domain event usage and consistency

On Fri, Nov 25, 2016 at 8:23 PM, Michal Privoznik wrote: > On 25.11.2016 18:33, Roman Mohr wrote: > > On Fri, Nov 25, 2016 at 6:04 PM, Michal Privoznik > > wrote: > > > >> On 25.11.2016 17:54, Roman Mohr wrote: > >>> On Fri, Nov 25, 2016 at 4:34 PM,

[libvirt] [PATCH python] libvirt-override: fix setBlockIoTune failure with flags 3

From: Yingtai Xie virDomainGetBlockIoTune() will be called before setBlockIoTune, as a result, it leads to a failure if set flags with VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG which is an reasonable option. Signed-off-by: Yingtai Xie ---

Re: [libvirt] [PATCH python] libvirt-override: fix setBlockIoTune failure with flags 3

On Thu, Dec 01, 2016 at 09:08:32PM +0800, xieying...@huawei.com wrote: > From: Yingtai Xie > > virDomainGetBlockIoTune() will be called before setBlockIoTune, as a result, > it leads to a failure if set flags with VIR_DOMAIN_AFFECT_LIVE | > VIR_DOMAIN_AFFECT_CONFIG which

Re: [libvirt] [PATCH] qemuDomainAttachNetDevice: pass mq and vectors for vhost-user with multiqueue

On 01.12.2016 07:01, gaohaifeng wrote: > Two reasons: > 1.in none hotplug, we will pass it. We can see from libvirt function > qemuBuildVhostuserCommandLine > 2.qemu will use this vetcor num to init msix table. If we don't pass, qemu > will use default value, this will cause VM can only use

Re: [libvirt] [PATCH] docs: add "more PCIe less legacy PCI" to list of new features

On Wed, Nov 30, 2016 at 06:00:51PM -0500, Laine Stump wrote: --- If this entry looks okay and I'm not around on IRC, feel free to push it so it will be in RC2. I haven't made it before rc2, but I pushed it with some amendments so it matches the rest of the file (mentioned below). Feel free

Re: [libvirt] [PATCH] NEWS: Remove end-of-sentence period

On Thu, Dec 01, 2016 at 12:25:21PM +0100, Andrea Bolognani wrote: None of the other sentences in the file ends with the period, and we want to maintain a consistent style. --- Pushed as trivial. I pushed one more that's few lines above. Hopefully not sending yet another mail just because of

Re: [libvirt] [PATCH] node_device: Check return value for udev_new()

On Wed, Nov 30, 2016 at 04:25 PM +0100, Martin Kletzander wrote: > On Wed, Nov 30, 2016 at 01:45:32PM +0100, Marc Hartmayer wrote: >>The comment was actually wrong as >>https://www.freedesktop.org/software/systemd/man/udev_new.html >>mentions that on failure NULL is

[libvirt] [PATCH] network: write both lo and lo0 in dnsmasq configuration

When generating a new configuration for dnsmasq, add except-interface for both lo and lo0: this should make sure the configuration works, and is always the same for every supported OS. Adjust the data of networkxml2conftest to reflect the new dnsmasq configuration, making networkxml2conftest pass

[libvirt] [PATCH] NEWS: Remove end-of-sentence period

None of the other sentences in the file ends with the period, and we want to maintain a consistent style. --- Pushed as trivial. docs/news.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/news.html.in b/docs/news.html.in index 8a86dd4..27d3387 100644 ---

Re: [libvirt] Plan for next release(s)

On Dec 1, 2016 6:12 AM, "Andrea Bolognani" wrote: > > On Mon, 2016-11-28 at 21:53 -0500, Laine Stump wrote: > > P.S. to Andrea - I will write a NEWS file entry, but I guess that can be > > safely pushed after Daniel freezes :-) > > You better! ;) Posted last night. I'm not

Re: [libvirt] Plan for next release(s)

On Mon, 2016-11-28 at 21:53 -0500, Laine Stump wrote: [...] > it was too late in  > the day to have a discussion with him about his question here: >  > https://www.redhat.com/archives/libvir-list/2016-November/msg01204.html >  > He didn't give a NACK for putting that function in now (rather than 

Re: [libvirt] [PATCH 8/8] nss: Lookup by libvirt domain names too

On Thu, Dec 01, 2016 at 09:42:57AM +0100, Michal Privoznik wrote: > On 30.11.2016 11:41, Michal Privoznik wrote: > > On 30.11.2016 11:16, Daniel P. Berrange wrote: > >> On Wed, Nov 30, 2016 at 10:59:35AM +0100, Michal Privoznik wrote: > >>> So far the NSS module looks up only hostnames as provided

Re: [libvirt] [PATCH 8/8] nss: Lookup by libvirt domain names too

On 30.11.2016 11:41, Michal Privoznik wrote: > On 30.11.2016 11:16, Daniel P. Berrange wrote: >> On Wed, Nov 30, 2016 at 10:59:35AM +0100, Michal Privoznik wrote: >>> So far the NSS module looks up only hostnames as provided by >>> guests themselves. However, there are some cases where this is >>>

Re: [libvirt] [PATCH] xen: Fix build when with xen disabled and libxl enabled

On Wed, Nov 30, 2016 at 19:10:42 -0700, Jim Fehlig wrote: > On 11/30/2016 12:39 PM, Peter Krempa wrote: > > xen_common.c does not get compiled in such case which breaks the build > > due to xenDomainDefAddImplicitInputDevice not being available. > > Odd that I don't see this problem on current