Re: [libvirt] Paradox cpu topology in capabilities outputs

Okay, I got some answer myself. This indicate the topology in one of a numa node. But what if I want to get the node’s physical socket number? Best Regards Eli Qiao(乔立勇）OpenStack Core team OTC Intel. -- From: "Qiao, Liyong" Date: Wednesday, 11 January 2017 at 2:52

[libvirt] Paradox cpu topology in capabilities outputs

Hi, I observe that virsh capabilities give wrong cpu topology on a multiple sockets host taget@jfz1r04h13:~/libvirt$ lscpu Architecture: x86_64 CPU op-mode(s):32-bit, 64-bit Byte Order:Little Endian CPU(s):72 On-line CPU(s) list: 0-71 Thread(s) per

Re: [libvirt] Do different Virgil3D users running have the same CANVAS fingerprint?

ACK :) On 2017-01-09 11:17, Martin Kletzander wrote: On Sun, Jan 08, 2017 at 07:17:07PM +0100, ban...@openmailbox.org wrote: On 2016-12-27 04:05, ban...@openmailbox.org wrote: Background: Canvas fingerprinting is a technique to track users based on their GPUs.

Re: [libvirt] [PATCH] storage_backend_rbd: always call rados_conf_read_file when connect a rbd pool

At 2017-01-11 02:23:54, "John Ferlan" wrote: > > >On 12/30/2016 03:39 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> This patch fix a dead lock when try to read a rbd image >> >> When trying to connect a rbd server >>

Re: [libvirt] [PATCH] Extend l3 cache to nodeinfo

Best Regards Eli Qiao(乔立勇）OpenStack Core team OTC Intel. -- On 10/01/2017, 8:32 PM, "Martin Kletzander" wrote: On Tue, Jan 10, 2017 at 04:11:03PM +0800, Eli Qiao wrote: >This patch extends l3 cache infomation to nodeinfo output. > This doesn't make

Re: [libvirt] [PATCH] Extend l3 cache to nodeinfo

>Also, why only l3 cache. Why not expose full info about > the CPU cache hierarchy. It feels wrong to expose only > L3 cache and ignore other levels of cache. Okay, I’ll think how to expose there into capabilities. This is related to enable cache tune support in [1] The status in

Re: [libvirt] RFC: Use __attribute__ ((cleanup) in libvirt ?

On Tue, Jan 10, 2017 at 10:00:31AM +, Daniel P. Berrange wrote: > If we mandate use of gcc / clang, then we wouldn't need to hide it > behind a macro - we'd be able to use it inline. That said, using a > macro makes it smaller and gives a bit of standardization. eg with > libguestfs style: >

Re: [libvirt] [PATCH] libxl: fix usb inputs loop error

Cédric Bosdonnat wrote: > List indexes where mixed up in the code looping over the USB > input devices. > --- > src/libxl/libxl_conf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c > index ac83b51c7..1053e60a1 100644

Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

On 12/19/2016 10:23 AM, Laine Stump wrote: Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so that they will be assigned to all the functions on a slot. Some qemu test case outputs had to be adjusted due to the pcie-root-ports now being put on multiple functions. --- ARGH! In

Re: [libvirt] [PATCH] virsh: pool-info: introduce option --bytes

On 01/03/2017 08:01 PM, Chen Hanxiao wrote: > From: Chen Hanxiao > > By default, pool-info will convert sizes to human friendly > units. > This patch will introduce option [--bytes]. > If specified, the raw sizes will be in the output. > > Signed-off-by: Chen Hanxiao

Re: [libvirt] [PATCH 00/12] vbox: remove support for vbox 3.x and older.

On Tue, 2017-01-10 at 11:50 -0500, John Ferlan wrote: > > Seems reasonable - it builds for me ;-).  I did take a cursory scan > through the changes - they all seem valid. > > ACK series and can push everything before the release once/if the > news > patches series on list can come to a

Re: [libvirt] [PATCH] NEWS: Add trailing periods to all sentences

ACK. I never liked the idea of multiple sentences where everything except the final sentence ends with a period (but it wasn't worth complaining about). On 01/10/2017 01:57 PM, Andrea Bolognani wrote: Suggested-by: John Ferlan --- docs/news.xml | 30

[libvirt] [PATCH] NEWS: Add trailing periods to all sentences

Suggested-by: John Ferlan --- docs/news.xml | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 909b4ca..672e988 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -24,7 +24,7 @@

Re: [libvirt] [PATCH 2/3] remote: fix logic for known_hosts and keyfile checks

On Tue, Jan 10, 2017 at 19:43:19 +0100, Pino Toscano wrote: > If any of them is specified for the libssh and libssh2 drivers, there is > no need to depend on chec ks based on other paths: in particular, a s/chec ks/checks/ > specified path for known_hosts was ignored if the local config

Re: [libvirt] [PATCH 3/3] remote: do not check for an existing config dir

On Tue, Jan 10, 2017 at 19:43:20 +0100, Pino Toscano wrote: > When composing the path to the default known_hosts file (for the libssh > and libssh2 drivers), do not check whether the configuration directory > (determined by virGetUserConfigDirectory()) exists: both the drivers can > handle

[libvirt] [PATCH] maint: update to latest gnulib

Among other recent changes, this includes a workaround to avoid Clang compiler bug https://llvm.org/bugs/show_bug.cgi?id=16404 having spurious link failures. * .gnulib: Update. * bootstrap: Synchronize to upstream. Signed-off-by: Eric Blake --- I'm debating about re-enabling

Re: [libvirt] [PATCH 1/3] rpc: libssh: allow a NULL known_hosts file

On Tue, Jan 10, 2017 at 19:43:18 +0100, Pino Toscano wrote: > Make sure that virNetLibsshSessionSetHostKeyVerification accepts a NULL > value for the path to the known_hosts file: > - call ssh_options_set(SSH_OPTIONS_KNOWNHOSTS) anyway, using /dev/null, > otherwise libssh will use its default

Re: [libvirt] [PATCH v4] libxl: define a per-domain logger.

Cédric Bosdonnat wrote: > libxl doesn't provide a way to write one log for each domain. Thus > we need to demux the messages. If our logger doesn't know to which > domain to attribute a message, then it will write it to the default > log file. > > Starting with Xen 4.9 (commit f9858025 and

Re: [libvirt] [PATCH v3 0/3] Improve release notes process

On Tue, 2017-01-10 at 13:28 -0500, John Ferlan wrote: > > So, will you ACK this series if I promise to follow up with > > a patch that adds leading periods to all s? >  > Sure, ACK with the caveat that I barely know how to spell xlst. Is the misspelling intentional? If so, good one! If not,

[libvirt] [PATCH 2/4] storage: gluster: Report error if no volumes were found in pool lookup

Similarly to the 'netfs' pool, return an error if the host does not have any volumes. --- src/storage/storage_backend_gluster.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_gluster.c b/src/storage/storage_backend_gluster.c index

[libvirt] [PATCH 4/4] spec: Depend on the gluster command line tool

The gluster command line tool that is used to lookup storage pool sources moved from the gluster-client package to gluster-cli. Unfortunately the location differs between fedora and rhel so depend on the package rather than binary. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1349441

[libvirt] [PATCH 0/4] gluster: cleanup and fix code for pool discovery

Peter Krempa (4): storage: Fix error reporting when looking up storage pool sources storage: gluster: Report error if no volumes were found in pool lookup storage: gluster: Remove build-time dependency on the 'gluster' cli tool spec: Depend on the gluster command line tool

[libvirt] [PATCH 3/4] storage: gluster: Remove build-time dependency on the 'gluster' cli tool

The tool is used for pool discovery. Since we call an external binary we don't really need to compile out the code that uses it. We can check whether it exists at runtime. --- configure.ac | 2 +- src/storage/storage_backend.c | 29 -

[libvirt] [PATCH 1/4] storage: Fix error reporting when looking up storage pool sources

In commit 4090e15399 we went back from reporting no errors if no storage pools were found on a given host to reporting a bad error. And only in cases when gluster was not installed. Report a less bad error in case there are no volumes. Also report the error when gluster is installed but no

[libvirt] [PATCH 2/3] remote: fix logic for known_hosts and keyfile checks

If any of them is specified for the libssh and libssh2 drivers, there is no need to depend on chec ks based on other paths: in particular, a specified path for known_hosts was ignored if the local config directory could not be determined, and the path for keyfile was ignored if the home could not

[libvirt] [PATCH 1/3] rpc: libssh: allow a NULL known_hosts file

Make sure that virNetLibsshSessionSetHostKeyVerification accepts a NULL value for the path to the known_hosts file: - call ssh_options_set(SSH_OPTIONS_KNOWNHOSTS) anyway, using /dev/null, otherwise libssh will use its default path - do not call ssh_write_knownhost when no known hosts file was

[libvirt] [PATCH 3/3] remote: do not check for an existing config dir

When composing the path to the default known_hosts file (for the libssh and libssh2 drivers), do not check whether the configuration directory (determined by virGetUserConfigDirectory()) exists: both the drivers can handle non-existing files, and are able to create them (and their directories) in

Re: [libvirt] [PATCH] storage_backend_rbd: always call rados_conf_read_file when connect a rbd pool

On 12/30/2016 03:39 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This patch fix a dead lock when try to read a rbd image > > When trying to connect a rbd server > (ceph-0.94.7-1.el7.centos.x86_64), > > rbd_list/rbd_open enter a dead lock state. > > Backtrace: >

Re: [libvirt] [PATCH v3 0/3] Improve release notes process

On 01/10/2017 11:55 AM, Andrea Bolognani wrote: > On Tue, 2017-01-10 at 11:23 -0500, John Ferlan wrote: >> I'm "mostly" fine with the changes - would like resolution sooner than >> later since I have a couple of things to add to news, but I didn't want >> to cause you extra merge cycles ;-) > >

Re: [libvirt] [PATCH 0/2] Couple of build fixes

On Tue, 2017-01-10 at 16:33 +0100, Michal Privoznik wrote: > Spotted by our CI. >  > Michal Privoznik (2): >   qemu_domain: Move qemuDomainGetPreservedMounts >   virSecuritySELinuxSetFileconHelper: Fix build with broken selinux.h >  >  src/qemu/qemu_domain.c  | 140

Re: [libvirt] [PATCH] libxl: implement virDomainGetMaxVcpus

Pavel Hrdina wrote: > On Fri, Jan 06, 2017 at 12:35:21PM -0700, Jim Fehlig wrote: >> The libxl driver already supports getting maximum vcpu count via >> libxlDomainGetVcpusFlags, allowing to trivially implement >> virDomainGetMaxVcpus. >> >> Signed-off-by: Jim Fehlig >> --- >>

Re: [libvirt] [PATCH 2/2] qemu: use virDomainPCIAddressSetAllMulti() to set multi when needed

On Tue, 2017-01-10 at 03:23 -0500, Laine Stump wrote: > If there are multiple devices assigned to the different functions of a > single PCI slot, they will not work properly if the device at function > 0 doesn't have its "multi" attribute turned on, so it makes sense for > libvirt to turn it on

Re: [libvirt] [PATCH v2 1/2] conf: new function virDomainPCIAddressSetAllMulti()

On Tue, 2017-01-10 at 11:55 -0500, Laine Stump wrote: > This utility function iterates through all devices looking for any > with a PCI address that has function != 0 (which implies that multiple > functions are in use on that slot), then uses an inner iterator to > find the device that's on

Re: [libvirt] [PATCH v3 0/3] Improve release notes process

On Tue, 2017-01-10 at 11:23 -0500, John Ferlan wrote: > I'm "mostly" fine with the changes - would like resolution sooner than > later since I have a couple of things to add to news, but I didn't want > to cause you extra merge cycles ;-) Yeah, same here :) > The *one* thing I'm really having a

[libvirt] [PATCH v2 1/2] conf: new function virDomainPCIAddressSetAllMulti()

This utility function iterates through all devices looking for any with a PCI address that has function != 0 (which implies that multiple functions are in use on that slot), then uses an inner iterator to find the device that's on function 0 of that same slot and sets the "multi" in its

Re: [libvirt] [PATCH 00/12] vbox: remove support for vbox 3.x and older.

On 12/29/2016 03:34 PM, Dawid Zamirski wrote: > Hello, > > This series removes support for legacy VirtualBox versions (3.x and > older) that did not have upstream support for a while and won't even > work on any relatively recent distro. The idea for doing this was > first mentioned here [1]

Re: [libvirt] TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc)

On 05/01/2017 14:00, Daniel P. Berrange wrote: >> If you do this unconditionally, you have another problem: if >> tsc-frequency is set explicitly, migration is only possible if >> TSC frequency of the destination matches[1], or if TSC scaling is >> supported by the destination. It's a good idea

Re: [libvirt] TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc)

On 05/01/2017 11:48, Marcelo Tosatti wrote: >> Host A has TSC scaling, host B doesn't have TSC scaling. We want >> to be able to start the VM on host A, and migrate to B. In this >> case, the only possible solution is to use B's frequency when >> starting the VM. The QEMU process doesn't have

Re: [libvirt] [PATCH v3 0/3] Improve release notes process

On 01/10/2017 10:25 AM, Andrea Bolognani wrote: > Dan raised some concerns, but it doesn't look like they're > critical enough for him to NACK the series; moreover, it's > all stuff that we can easily address later on, so I'd like > to move forward with this before the freeze. > > Details of

Re: [libvirt] RFC: Use __attribute__ ((cleanup) in libvirt ?

On Tue, Jan 10, 2017 at 05:05:21PM +0100, Michal Privoznik wrote: > On 01/09/2017 05:58 PM, Daniel P. Berrange wrote: > > > > I'm wondering what people think of making use of this in libvirt ? > > Apart from what have been said (I share the same concerns) I like the > idea. All the "limitations"

[libvirt] OpenStack/libvirt CAT interface

There have been queries about the OpenStack interface for CAT: http://bugzilla.redhat.com/show_bug.cgi?id=1299678 Comment 2 says: Sahid Ferdjaoui 2016-01-19 10:58:48 EST A spec will have to be addressed, after a first look this feature needs some work in several components of Nova to

Re: [libvirt] [PATCH] storage: Fix storage_backend probing when PARTED not installed.

On Tue, Jan 10, 2017 at 10:20:11 -0500, John Ferlan wrote: > Commit id 'a48c674f' caused problems for systems without PARTED installed. > > So move the PARTED probing code back to storage_backend_disk.c and create > a shim within storage_backend.c to call it if WITH_STORAGE_DISK is true; >

[libvirt] [PATCH] libxl: fix usb inputs loop error

List indexes where mixed up in the code looping over the USB input devices. --- src/libxl/libxl_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index ac83b51c7..1053e60a1 100644 --- a/src/libxl/libxl_conf.c +++

Re: [libvirt] RFC: Use __attribute__ ((cleanup) in libvirt ?

On 01/09/2017 05:58 PM, Daniel P. Berrange wrote: > > I'm wondering what people think of making use of this in libvirt ? Apart from what have been said (I share the same concerns) I like the idea. All the "limitations" - we already have them. You have to initialize variables even when using

Re: [libvirt] [PATCH] Extend l3 cache to nodeinfo

On Tue, Jan 10, 2017 at 04:11:03PM +0800, Eli Qiao wrote: > This patch extends l3 cache infomation to nodeinfo output. Also, why only l3 cache. Why not expose full info about the CPU cache hierarchy. It feels wrong to expose only L3 cache and ignore other levels of cache. Regards, Daniel -- |:

Re: [libvirt] qemu-kvm blocked for more than 120 seconds when "libvirt-guests" is enabled

On Sat, 2016-12-31 at 17:25 +0100, Oscar Segarra wrote: [...] > [root@vdicnode01 ~]# service libvirt-guests status > Redirecting to /bin/systemctl status  libvirt-guests.service > ● libvirt-guests.service - Suspend Active Libvirt Guests >Loaded: loaded

Re: [libvirt] [PATCH] rpc: libssh: don't crash when known_hosts file path is not provided

On Tue, Jan 10, 2017 at 16:08:03 +0100, Pino Toscano wrote: > On Monday, 9 January 2017 15:16:46 CET Peter Krempa wrote: > > When connecting as root, the "hostsfile" variable would be NULL due to > > the code leading to this point. This would result into a crash when > > attempting to set the

[libvirt] [PATCH 2/2] virSecuritySELinuxSetFileconHelper: Fix build with broken selinux.h

There are still some systems out there that have broken setfilecon*() prototypes. Instead of taking 'const char *tcon' it is taking 'char *tcon'. The function should just set the context, not modify it. We had been bitten with this problem before which resulted in 292d3f2d and subsequently

[libvirt] [PATCH 0/2] Couple of build fixes

Spotted by our CI. Michal Privoznik (2): qemu_domain: Move qemuDomainGetPreservedMounts virSecuritySELinuxSetFileconHelper: Fix build with broken selinux.h src/qemu/qemu_domain.c | 140 src/security/security_selinux.c | 2 +- 2 files

[libvirt] [PATCH 1/2] qemu_domain: Move qemuDomainGetPreservedMounts

This function is used only from code compiled on Linux. Therefore on non-Linux platforms it triggers compilation error: ../../src/qemu/qemu_domain.c:209:1: error: unused function 'qemuDomainGetPreservedMounts' [-Werror,-Wunused-function] Signed-off-by: Michal Privoznik ---

Re: [libvirt] [PATCH 5/6] qemu: snapshot: Properly handle image locking

On Sat, Jan 07, 2017 at 13:37:48 -0500, John Ferlan wrote: > > > On 12/16/2016 11:24 AM, Peter Krempa wrote: > > Images that became the backing chain of the current image due to the > > snapshot need to be unlocked in the lock manager. Also if qemu was > > paused during the snapshot the current

Re: [libvirt] [PATCH 4/6] qemu: snapshot: Refactor snapshot rollback on failure

On Sat, Jan 07, 2017 at 13:37:12 -0500, John Ferlan wrote: > > > On 12/16/2016 11:24 AM, Peter Krempa wrote: > > The code at first changed the definition and then rolled it back in case > > of failure. This was ridiculous. Refactor the code so that the image in > > the definition is changed only

[libvirt] [PATCH v3 1/3] NEWS: Improve building pipeline

Currently, building the NEWS file involves using a XSLT stylesheet to extract information from the same HTML file that's used on the libvirt website. The process works, but it's quite fiddly in that it requires the source HTML to be formatted in a very precise way, and a single missing newline

[libvirt] [PATCH v3 2/3] NEWS: Reformat at generation time

Instead of encoding formatting information inside the corresponding XSLT stylesheet, use a Python script to reformat the text appropriately based on a few simple markers. Splitting the task between the XSLT stylesheet and the Python script allows us to keep both parts very simple. --- Changes

[libvirt] [PATCH v3 3/3] docs: Document the release notes process for contributors

Now that we have built a fairly solid process for dealing with release notes, we should start pushing for contributors to provide the relevant information along with their code: documenting the process is clearly a requirement for this to happen. --- Changes from v2: * Address review comments

[libvirt] [PATCH v3 0/3] Improve release notes process

Dan raised some concerns, but it doesn't look like they're critical enough for him to NACK the series; moreover, it's all stuff that we can easily address later on, so I'd like to move forward with this before the freeze. Details of changes can be found in the single patches. Andrea Bolognani

[libvirt] [PATCH] storage: Fix storage_backend probing when PARTED not installed.

Commit id 'a48c674f' caused problems for systems without PARTED installed. So move the PARTED probing code back to storage_backend_disk.c and create a shim within storage_backend.c to call it if WITH_STORAGE_DISK is true; otherwise, just return -1 with the error. Signed-off-by: John Ferlan

Re: [libvirt] [PATCH] rpc: libssh: don't crash when known_hosts file path is not provided

On Monday, 9 January 2017 15:16:46 CET Peter Krempa wrote: > When connecting as root, the "hostsfile" variable would be NULL due to > the code leading to this point. This would result into a crash when > attempting to set the known hosts file path. Almost: the issue happens generally when

[libvirt] Regarding Migration Statistics

Greetings, I am writing a code using libvirt API to migrate VM between two physical hosts *(QEMU/KVM) , *say some *n *number of times. *1)* I am using right now* virDomainPtr virDomainMigrate (...) *and to calculate the total migration time I am using something like this:

Re: [libvirt] RFC: Use __attribute__ ((cleanup) in libvirt ?

On Tue, Jan 10, 2017 at 02:50:40PM +0100, Erik Skultety wrote: On Tue, Jan 10, 2017 at 02:17:00PM +0100, Martin Kletzander wrote: On Tue, Jan 10, 2017 at 10:00:31AM +, Daniel P. Berrange wrote: > On Tue, Jan 10, 2017 at 10:48:47AM +0100, Martin Kletzander wrote: > > On Tue, Jan 10, 2017 at

Re: [libvirt] [PATCH v4] libxl: define a per-domain logger.

On Tue, 2017-01-10 at 12:21 +, Joao Martins wrote: > Hey Cedric, > > On 01/10/2017 09:03 AM, Cédric Bosdonnat wrote: > > libxl doesn't provide a way to write one log for each domain. Thus > > we need to demux the messages. If our logger doesn't know to which > > domain to attribute a message,

Re: [libvirt] RFC: Use __attribute__ ((cleanup) in libvirt ?

On Tue, Jan 10, 2017 at 01:55:02PM +, Daniel P. Berrange wrote: > On Tue, Jan 10, 2017 at 02:17:00PM +0100, Martin Kletzander wrote: > > On Tue, Jan 10, 2017 at 10:00:31AM +, Daniel P. Berrange wrote: > > > On Tue, Jan 10, 2017 at 10:48:47AM +0100, Martin Kletzander wrote: > > > > On Tue,

Re: [libvirt] RFC: Use __attribute__ ((cleanup) in libvirt ?

On Tue, Jan 10, 2017 at 02:17:00PM +0100, Martin Kletzander wrote: > On Tue, Jan 10, 2017 at 10:00:31AM +, Daniel P. Berrange wrote: > > On Tue, Jan 10, 2017 at 10:48:47AM +0100, Martin Kletzander wrote: > > > On Tue, Jan 10, 2017 at 02:58:21AM -0500, Laine Stump wrote: > > > > On 01/09/2017

Re: [libvirt] RFC: Use __attribute__ ((cleanup) in libvirt ?

On Tue, Jan 10, 2017 at 02:17:00PM +0100, Martin Kletzander wrote: > On Tue, Jan 10, 2017 at 10:00:31AM +, Daniel P. Berrange wrote: > > On Tue, Jan 10, 2017 at 10:48:47AM +0100, Martin Kletzander wrote: > > > On Tue, Jan 10, 2017 at 02:58:21AM -0500, Laine Stump wrote: > > > > On 01/09/2017

Re: [libvirt] [PATCH go-xml] Added Storage Pool and Storage Volume XML schemes.

On Mon, Jan 09, 2017 at 08:15:21AM +0100, Alexey Slaykovsky wrote: > Signed-off-by: Alexey Slaykovsky > --- > storage_encryption.go | 50 ++ > storage_pool.go | 121 + > storage_pool_test.go | 240

Re: [libvirt] qemu-kvm blocked for more than 120 seconds when "libvirt-guests" is enabled

:_ 2016-12-31 17:25 GMT+01:00 Oscar Segarra : > Hi, > > I just have two virtual machines in my environment, I want them to > gracefully stop when host is powered off gracefully. > > Nevertheless, system hangs on shutdown: > > [root@vdicnode01 ~]# virsh list > Id

Re: [libvirt] [PATCH] libxl: implement virDomainGetMaxVcpus

On Fri, Jan 06, 2017 at 12:35:21PM -0700, Jim Fehlig wrote: > The libxl driver already supports getting maximum vcpu count via > libxlDomainGetVcpusFlags, allowing to trivially implement > virDomainGetMaxVcpus. > > Signed-off-by: Jim Fehlig > --- > docs/news.html.in| 2

Re: [libvirt] RFC: Use __attribute__ ((cleanup) in libvirt ?

On Tue, Jan 10, 2017 at 10:00:31AM +, Daniel P. Berrange wrote: On Tue, Jan 10, 2017 at 10:48:47AM +0100, Martin Kletzander wrote: On Tue, Jan 10, 2017 at 02:58:21AM -0500, Laine Stump wrote: > On 01/09/2017 08:09 PM, Richard W.M. Jones wrote: > > On Mon, Jan 09, 2017 at 04:58:49PM +,

Re: [libvirt] [PATCH 0/2] Attempt, and fail, to fix build with Clang 3.9 / Linux

On Fri, 2017-01-06 at 15:48 -0600, Eric Blake wrote: > > The last one I was unable to work around in any sensible > > manner: when linking, clang fails with > >  > >   ../gnulib/lib/.libs/libgnu.a(mgetgroups.o): > >   In function `realloc_groupbuf': > >   .../libvirt/gnulib/lib/mgetgroups.c:45: >

Re: [libvirt] [PATCHv2 02/11] storage: Fix implementation of no-overwrite for file system backend

On 01/10/2017 01:36 PM, John Ferlan wrote: > > [...] > >> >> Yeah, I think if this function was called MatchFS(), CheckFS() or >> something among those lines I'm okay with this patch. But ProbeFS() >> makes me think that the function is just probing for existing FSs on >> given device. Sorry for

Re: [libvirt] [PATCHv2 02/11] storage: Fix implementation of no-overwrite for file system backend

[...] > > Yeah, I think if this function was called MatchFS(), CheckFS() or > something among those lines I'm okay with this patch. But ProbeFS() > makes me think that the function is just probing for existing FSs on > given device. Sorry for the bikeshedding :-). No problem - I'd rather get

Re: [libvirt] [PATCH] Extend l3 cache to nodeinfo

On Tue, Jan 10, 2017 at 04:11:03PM +0800, Eli Qiao wrote: This patch extends l3 cache infomation to nodeinfo output. This doesn't make sense, in case there are multiple sockets with different L3 cache sizes, it can't be represented in nodeinfo. If there can be multiple values, you need to

Re: [libvirt] [PATCHv2 02/11] storage: Fix implementation of no-overwrite for file system backend

On 01/10/2017 01:12 AM, John Ferlan wrote: > > > On 01/09/2017 10:32 AM, Michal Privoznik wrote: >> On 12/15/2016 10:42 PM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1363586 >>> >>> Commit id '27758859' introduced the "NO_OVERWRITE" flag check for >>> file system

Re: [libvirt] [PATCH v4] libxl: define a per-domain logger.

Hey Cedric, On 01/10/2017 09:03 AM, Cédric Bosdonnat wrote: > libxl doesn't provide a way to write one log for each domain. Thus > we need to demux the messages. If our logger doesn't know to which > domain to attribute a message, then it will write it to the default > log file. > > Starting

Re: [libvirt] [PATCH v2 5/5] qemu: Use transactions from security driver

On 01/09/2017 11:18 PM, John Ferlan wrote: > > > On 01/09/2017 07:58 AM, Michal Privoznik wrote: >> So far if qemu is spawned under separate mount namespace in order >> to relabel everything it needs an access to the security driver >> is run in that namespace too. This has a very nasty down

Re: [libvirt] [PATCH] Extend l3 cache to nodeinfo

Hi Daniel, Thanks for your comments. I will not change public ABI nor break RPC. I wonder if you would agree with extend virHostCPUGetInfoPopulateLinux to get l3 cache size ? Such as: virHostCPUGetInfoPopulateLinux(FILE *cpuinfo, virArch arch,

Re: [libvirt] [PATCH] Extend l3 cache to nodeinfo

On Tue, Jan 10, 2017 at 12:05:00PM +, Qiao, Liyong wrote: > Hi Daniel, > > Thanks for your comments. > > I will not change public ABI nor break RPC. > > I wonder if you would agree with extend virHostCPUGetInfoPopulateLinux to get > l3 cache size ? > Such as: >

Re: [libvirt] [PATCH v3 1/3] qemu: Use virtio-pci by default for mach-virt guests

On Tue, 2017-01-10 at 03:38 -0500, Laine Stump wrote: [...] > > -if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_MMIO)) { > > -qemuDomainPrimeVirtioDeviceAddresses( > > -def, VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO); > > +/* We use virtio-mmio by default on

Re: [libvirt] [PATCH v3 2/3] docs: Document virtio-mmio by default for mach-virt guests

On Tue, 2017-01-10 at 03:38 -0500, Laine Stump wrote: > Don't you want the subject to say "Document virtio-pci by default"? Of course I did :) Good catch! -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 0/4] qemu: Don't leave temp mount dirs around

On Fri, Jan 06, 2017 at 11:30:39AM +0100, Michal Privoznik wrote: After yesterday's patches [1] and fixing BZ [2] with them, the comment 4 got me thinking: why leave /var/run/libvirt/$domain.pts and similar temporary directories around? We need them just for a very short time. After that we

[libvirt] [PATCH go] Add support for perf cache_l1d event

Signed-off-by: Daniel P. Berrange --- Pushed as a build fix connect.go | 6 ++ domain.go | 6 ++ domain_compat.h | 4 3 files changed, 16 insertions(+) diff --git a/connect.go b/connect.go index 35eb7fd..41c54b1 100644 --- a/connect.go +++

Re: [libvirt] [PATCH 1/2] conf: new function virDomainPCIAddressSetAllMulti()

On Tue, 2017-01-10 at 03:23 -0500, Laine Stump wrote: > This utility function looks through a virPCIAddressSet for any slot of > any bus that has multiple functions in use, and sets the "multi" flag > in the virDomainDeviceInfo for the device that is assigned to function > 0 of that slot (as long

Re: [libvirt] [libvirt-python][PATCH] examples: Update event-test.py

On Tue, Jan 10, 2017 at 11:25:20AM +0100, Michal Privoznik wrote: > With recent changes there are new events known to libvirt. > Reflect those changes in our event-test.py example script. > > Signed-off-by: Michal Privoznik > --- > examples/event-test.py | 24

Re: [libvirt] [PATCH python 1/2] Add support for secret event APIs

On Tue, Jan 10, 2017 at 11:25:27AM +0100, Michal Privoznik wrote: > On 01/09/2017 07:10 PM, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange > > --- > > generator.py | 2 + > > libvirt-override-virConnect.py | 43 + > >

Re: [libvirt] [PATCH python 1/2] Add support for secret event APIs

On 01/09/2017 07:10 PM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > generator.py | 2 + > libvirt-override-virConnect.py | 43 + > libvirt-override.c | 203 > + >

[libvirt] [libvirt-python][PATCH] examples: Update event-test.py

With recent changes there are new events known to libvirt. Reflect those changes in our event-test.py example script. Signed-off-by: Michal Privoznik --- examples/event-test.py | 24 1 file changed, 24 insertions(+) diff --git

Re: [libvirt] [libvirt-perl PATCH] Add perf cache_l1d event

On Mon, Jan 09, 2017 at 06:47:04PM -0500, John Ferlan wrote: > Signed-off-by: John Ferlan > --- > Daniel - feel free to add to the pile of changes you posted if it's easier. > > Changes| 1 + > Virt.xs| 1 + > lib/Sys/Virt/Domain.pm | 6

Re: [libvirt] RFC: Use __attribute__ ((cleanup) in libvirt ?

On Tue, Jan 10, 2017 at 10:48:47AM +0100, Martin Kletzander wrote: > On Tue, Jan 10, 2017 at 02:58:21AM -0500, Laine Stump wrote: > > On 01/09/2017 08:09 PM, Richard W.M. Jones wrote: > > > On Mon, Jan 09, 2017 at 04:58:49PM +, Daniel P. Berrange wrote: > > > > For those who don't already

Re: [libvirt] RFC: Use __attribute__ ((cleanup) in libvirt ?

On Tue, Jan 10, 2017 at 02:58:21AM -0500, Laine Stump wrote: On 01/09/2017 08:09 PM, Richard W.M. Jones wrote: On Mon, Jan 09, 2017 at 04:58:49PM +, Daniel P. Berrange wrote: For those who don't already know, GCC and CLang both implement a C language extension that enables automatic

Re: [libvirt] [PATCH] Extend l3 cache to nodeinfo

On Tue, Jan 10, 2017 at 04:11:03PM +0800, Eli Qiao wrote: > This patch extends l3 cache infomation to nodeinfo output. > > Signed-off-by: Eli Qiao > --- > include/libvirt/libvirt-host.h | 1 + > src/nodeinfo.c | 3 ++- > src/remote/remote_protocol.x |

Re: [libvirt] [PATCH python 0/2] Add support for new events

On 01/09/2017 07:10 PM, Daniel P. Berrange wrote: > Daniel P. Berrange (2): > Add support for secret event APIs > Add support for domain metadata change event > > generator.py | 2 + > libvirt-override-virConnect.py | 52 + > libvirt-override.c | 260

Re: [libvirt] Issue with libvirtd

On 01/10/2017 07:48 AM, Faysal Ali wrote: > Hi Michal, [It is usually good idea to keep the list CCed - it may help others finding a solution to their problems] > > Well I have created my little python/libivrt app to manage my virtual > machines. I am using python socket to check libivrt port

[libvirt] [PATCH v4] libxl: define a per-domain logger.

libxl doesn't provide a way to write one log for each domain. Thus we need to demux the messages. If our logger doesn't know to which domain to attribute a message, then it will write it to the default log file. Starting with Xen 4.9 (commit f9858025 and following), libxl will write the domain ID

Re: [libvirt] [PATCH v3 2/3] docs: Document virtio-mmio by default for mach-virt guests

Don't you want the subject to say "Document virtio-pci by default"? ACK. On 12/23/2016 01:54 PM, Andrea Bolognani wrote: --- docs/formatdomain.html.in | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index

Re: [libvirt] [PATCH v3 3/3] NEWS: Update for virtio-pci by default for mach-virt guests

On 12/23/2016 01:54 PM, Andrea Bolognani wrote: --- docs/news.html.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/news.html.in b/docs/news.html.in index 36c7d3d..e5b9513 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -53,6 +53,12 @@ Add a display of

Re: [libvirt] [PATCH v3 1/3] qemu: Use virtio-pci by default for mach-virt guests

On 12/23/2016 01:54 PM, Andrea Bolognani wrote: virtio-pci is the way forward for aarch64 guests: it's faster and less alien to people coming from other architectures. Now that guest support is finally getting there (Fedora 24, CentOS 7.3, Ubuntu 16.04 and Debian testing all support virtio-pci

[libvirt] [PATCH 2/2] qemu: use virDomainPCIAddressSetAllMulti() to set multi when needed

If there are multiple devices assigned to the different functions of a single PCI slot, they will not work properly if the device at function 0 doesn't have its "multi" attribute turned on, so it makes sense for libvirt to turn it on during PCI address assignment. Just in case a future change in

[libvirt] [PATCH 0/2] replacement for Patches 5/8 & 6/8 of "aggregate multiple pcie-root-ports onto a single slot"

During review of the aforementioned series, Andrea expressed misgivings about patch 6, which automatically set the multifunction=on option transiently at the time the qemu commandline was generated. Dan agreed. These two patches replace patches 5 and 6 of that series with two patches that will set

[libvirt] [PATCH 1/2] conf: new function virDomainPCIAddressSetAllMulti()

This utility function looks through a virPCIAddressSet for any slot of any bus that has multiple functions in use, and sets the "multi" flag in the virDomainDeviceInfo for the device that is assigned to function 0 of that slot (as long as it hasn't already been set explicitly by someone who

[libvirt] [PATCH] Extend l3 cache to nodeinfo

This patch extends l3 cache infomation to nodeinfo output. Signed-off-by: Eli Qiao --- include/libvirt/libvirt-host.h | 1 + src/nodeinfo.c | 3 ++- src/remote/remote_protocol.x | 1 + src/test/test_driver.c | 1 + src/util/virhostcpu.c

  1   2   >