Re: [libvirt] [PATCH] qemu: document snapshot-related fixes in the release notes

On Fri, 2017-01-13 at 17:34 +0100, Peter Krempa wrote: > ACK, although I don't really think that this explains much. I don't > really find those patches worth documenting. Cool, let's drop it then. Sorry for the noise :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing

Re: [libvirt] [PATCH] qemu-capabilities: Fix query-cpu-model-expansion on s390 with older kernel

On Fri, Jan 13, 2017 at 03:11:54PM +0100, Jiri Denemark wrote: > On Fri, Jan 13, 2017 at 11:04:21 +0100, Jiri Denemark wrote: > > On Thu, Jan 12, 2017 at 11:18:11 -0500, Collin L. Walling wrote: > > > When running on s390 with a kernel that does not support cpu model > > > checking and > > > with

Re: [libvirt] [PATCH] qemu-capabilities: Fix query-cpu-model-expansion on s390 with older kernel

On Fri, Jan 13, 2017 at 09:06:52AM -0500, Jason J. Herne wrote: > On 01/13/2017 05:04 AM, Jiri Denemark wrote: > > On Thu, Jan 12, 2017 at 11:18:11 -0500, Collin L. Walling wrote: > > > When running on s390 with a kernel that does not support cpu model > > > checking and > > > with a Qemu new

Re: [libvirt] [PATCH] qemu: document snapshot-related fixes in the release notes

On Fri, Jan 13, 2017 at 17:22:15 +0100, Andrea Bolognani wrote: > --- > docs/news.xml | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 50c3b3e..043d1fe 100644 > --- a/docs/news.xml > +++ b/docs/news.xml > @@ -225,6 +225,15 @@ >

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

On Fri, 13 Jan 2017 09:57:36 +1100 David Gibson wrote: > On Thu, Jan 12, 2017 at 11:31:35AM +0100, Andrea Bolognani wrote: > > On Mon, 2017-01-09 at 10:46 +1100, David Gibson wrote: > > > > >* To allow for hotplugged devices, libvirt should also add a number >

[libvirt] [PATCH] news: Add support for guest CPU configuration on s390

Signed-off-by: Jiri Denemark --- docs/news.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 50c3b3ea2..a076836ed 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -73,6 +73,11 @@ volumes when building a new logical

[libvirt] [PATCH] qemu: document snapshot-related fixes in the release notes

--- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 50c3b3e..043d1fe 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -225,6 +225,15 @@ for x86_64 HVM domains. + + + qemu:

Re: [libvirt] [PATCH] docs: add entry for aggregation of pcie-root-ports to news.xml

On Fri, 2017-01-13 at 10:29 -0500, Laine Stump wrote: > --- >  docs/news.xml | 13 + >  1 file changed, 13 insertions(+) >  > diff --git a/docs/news.xml b/docs/news.xml > index 50c3b3e..18006e8 100644 > --- a/docs/news.xml > +++ b/docs/news.xml > @@ -140,6 +140,19 @@ >the

Re: [libvirt] [PATCH] qemu-capabilities: Fix query-cpu-model-expansion on s390 with older kernel

On Fri, Jan 13, 2017 at 09:20:40 -0500, Jason J. Herne wrote: > On 01/13/2017 09:11 AM, Jiri Denemark wrote: > > But I suggest to change the comment to something like the following: > > > > /* Even though query-cpu-model-expansion is advertised by > > * query-commands it may just return

[libvirt] [PATCH] docs: add entry for aggregation of pcie-root-ports to news.xml

--- docs/news.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 50c3b3e..18006e8 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -140,6 +140,19 @@ the storage pool XML. + + + qemu:

Re: [libvirt] [PATCH 1/3] storage: Alter logic when both BLKID and PARTED unavailable

On Fri, Jan 13, 2017 at 07:59:08 -0500, John Ferlan wrote: > If neither BLKID or PARTED is available and we're not writing, then > just return 0 which allows the underlying storage pool to generate > a failur. If both are unavailable and we're writing, then generate failure > a more generic

Re: [libvirt] [PATCH 3/3] storage: Alter error message in probe/empty checks

On Fri, Jan 13, 2017 at 07:59:10 -0500, John Ferlan wrote: > For case VIR_STORAGE_BLKID_PROBE_DIFFERENT, clean up the message to > avoid using the virsh like --overwrite syntax. Additionally provide > a different error message when not writing the label to avoid confusion. > > Signed-off-by: John

Re: [libvirt] [PATCH 2/3] storage: Clean up return value checking

On Fri, Jan 13, 2017 at 07:59:09 -0500, John Ferlan wrote: > Rather than special casing the VIR_STORAGE_BLKID_PROBE_UNKNOWN after > calling virStorageBackendBLKIDFindPart, just allow the switch statement > handle setting ret = -2. > > Signed-off-by: John Ferlan > --- >

Re: [libvirt] [PATCH v2 1/2] nodedev: Fabric name must not be required for fc_host capability

On 01/13/2017 06:56 AM, Boris Fiuczynski wrote: > fabric_name is one of many fc_host attributes in Linux that is optional > and left to the low-level driver to decide if it is implemented. > The zfcp device driver does not provide a fabric name for an fcp host. > > This patch removes the

Re: [libvirt] [PATCH] qemu: Copy SELinux labels for namespace too

On 01/13/2017 12:43 PM, Martin Kletzander wrote: > On Fri, Jan 13, 2017 at 11:12:43AM +0100, Michal Privoznik wrote: >> When creating new /dev/* for qemu, we do chown() and copy ACLs to >> create the exact copy from the original /dev. I though that >> copying SELinux labels is not necessary as

Re: [libvirt] [PATCH] qemu-capabilities: Fix query-cpu-model-expansion on s390 with older kernel

On 01/13/2017 09:11 AM, Jiri Denemark wrote: On Fri, Jan 13, 2017 at 11:04:21 +0100, Jiri Denemark wrote: On Thu, Jan 12, 2017 at 11:18:11 -0500, Collin L. Walling wrote: When running on s390 with a kernel that does not support cpu model checking and with a Qemu new enough to support

Re: [libvirt] [PATCH] qemu-capabilities: Fix query-cpu-model-expansion on s390 with older kernel

On Fri, Jan 13, 2017 at 11:04:21 +0100, Jiri Denemark wrote: > On Thu, Jan 12, 2017 at 11:18:11 -0500, Collin L. Walling wrote: > > When running on s390 with a kernel that does not support cpu model checking > > and > > with a Qemu new enough to support query-cpu-model-expansion, the gathering >

Re: [libvirt] [PATCH] qemu-capabilities: Fix query-cpu-model-expansion on s390 with older kernel

On 01/13/2017 05:04 AM, Jiri Denemark wrote: On Thu, Jan 12, 2017 at 11:18:11 -0500, Collin L. Walling wrote: When running on s390 with a kernel that does not support cpu model checking and with a Qemu new enough to support query-cpu-model-expansion, the gathering of qemu capabilities will

Re: [libvirt] [PATCH] qemu: Copy SELinux labels for namespace too

On 01/13/2017 12:26 PM, Andrea Bolognani wrote: > On Fri, 2017-01-13 at 11:12 +0100, Michal Privoznik wrote: > [...] >> @@ -7023,10 +7029,34 @@ qemuDomainCreateDevice(const char *device, >> goto cleanup; >> } >> >> +#ifdef WITH_SELINUX >> +if (getfilecon_raw(canonDevicePath,

[libvirt] [PATCH 1/3] storage: Alter logic when both BLKID and PARTED unavailable

If neither BLKID or PARTED is available and we're not writing, then just return 0 which allows the underlying storage pool to generate a failur. If both are unavailable and we're writing, then generate a more generic error message. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 2/3] storage: Clean up return value checking

Rather than special casing the VIR_STORAGE_BLKID_PROBE_UNKNOWN after calling virStorageBackendBLKIDFindPart, just allow the switch statement handle setting ret = -2. Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 10 +- 1 file changed, 1 insertion(+),

[libvirt] [PATCH 3/3] storage: Alter error message in probe/empty checks

For case VIR_STORAGE_BLKID_PROBE_DIFFERENT, clean up the message to avoid using the virsh like --overwrite syntax. Additionally provide a different error message when not writing the label to avoid confusion. Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 14

[libvirt] [PATCH 0/3] More adjustments for recent storage probe logic

Adjustments based on recent activity... The !writelabel path of patch 3 is probably a moot point since patches to check at FS and Logical startup for a valid data on the device(s) were reverted. John Ferlan (3): storage: Alter logic when both BLKID and PARTED unavailable storage: Clean up

[libvirt] [PATCH v2 2/2] util: Minor correction in documenting comment

Signed-off-by: Boris Fiuczynski --- src/util/virutil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index 5bfbf37..d79775d 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -2011,7 +2011,7 @@

[libvirt] [PATCH v2 1/2] nodedev: Fabric name must not be required for fc_host capability

fabric_name is one of many fc_host attributes in Linux that is optional and left to the low-level driver to decide if it is implemented. The zfcp device driver does not provide a fabric name for an fcp host. This patch removes the requirement for a fabric name by making it optional.

[libvirt] [PATCH v2 0/2] Fabric name must not be required for fc_host capability

fabric_name is one of many fc_host attributes in Linux that is optional and left to the low-level driver to decide if it is implemented. --- Changes since v1: - split of minor correction in documenting comment - added news entry... - added new virReadFCHostOption method - added check for

Re: [libvirt] [PATCH] qemu: Copy SELinux labels for namespace too

On Fri, Jan 13, 2017 at 11:12:43AM +0100, Michal Privoznik wrote: When creating new /dev/* for qemu, we do chown() and copy ACLs to create the exact copy from the original /dev. I though that copying SELinux labels is not necessary as SELinux will chose the sane defaults. Surprisingly, it does

Re: [libvirt] [PATCH] qemu: Copy SELinux labels for namespace too

On Fri, 2017-01-13 at 11:12 +0100, Michal Privoznik wrote: [...] > @@ -7023,10 +7029,34 @@ qemuDomainCreateDevice(const char *device, >  goto cleanup; >  } >   > +#ifdef WITH_SELINUX > +if (getfilecon_raw(canonDevicePath, ) < 0 && > +(errno != ENOTSUP && errno != ENODATA))

[libvirt] [PATCH] docs: Fix libvirt_guest nss module name

In the documentation we are mixing libvirt-guest and libvirt_guest module name. The correct name is the latter. Signed-off-by: Michal Privoznik --- Pushed as trivial. docs/news.xml| 4 ++-- docs/nss.html.in | 12 ++-- 2 files changed, 8 insertions(+), 8

Re: [libvirt] [PATCH v2 10/10] nss: Introduce libvirt-guest module

On 01/13/2017 11:27 AM, Andrea Bolognani wrote: > On Mon, 2016-12-05 at 11:31 +0100, Michal Privoznik wrote: > [...] >> + >> +$ cat /etc/nsswitch.conf >> +# /etc/nsswitch.conf: >> +hosts: files libvirt-guest dns >> +# ... >> + >> +Or users can enable both at the same time: >> + >> +$ cat

Re: [libvirt] [PATCH v2 10/10] nss: Introduce libvirt-guest module

On Mon, 2016-12-05 at 11:31 +0100, Michal Privoznik wrote: [...] > + > +$ cat /etc/nsswitch.conf > +# /etc/nsswitch.conf: > +hosts:   files libvirt-guest dns > +# ... > + > +Or users can enable both at the same time: > + > +$ cat /etc/nsswitch.conf > +# /etc/nsswitch.conf: > +hosts:   

[libvirt] [PATCH] qemu: Copy SELinux labels for namespace too

When creating new /dev/* for qemu, we do chown() and copy ACLs to create the exact copy from the original /dev. I though that copying SELinux labels is not necessary as SELinux will chose the sane defaults. Surprisingly, it does not leaving namespace with the following labels: crw-rw-rw-. root

Re: [libvirt] [PATCH] qemu-capabilities: Fix query-cpu-model-expansion on s390 with older kernel

On Thu, Jan 12, 2017 at 11:18:11 -0500, Collin L. Walling wrote: > When running on s390 with a kernel that does not support cpu model checking > and > with a Qemu new enough to support query-cpu-model-expansion, the gathering of > qemu > capabilities will fail. Qemu responds to the

Re: [libvirt] [V4] RFC for support cache tune(CAT) in libvirt

On Fri, Jan 13, 2017 at 09:38:44AM +0800, 乔立勇(Eli Qiao) wrote: > > virsh capabilities > > > > > > > <- level 3 cache is per socket, so group them by > socket id > > > >cpus="3,4,5,9,10,11"/> > > > > > > > >

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

On Fri, 13 Jan 2017 15:48:31 +1100 David Gibson wrote: > On Thu, Jan 12, 2017 at 10:09:03AM +0100, Greg Kurz wrote: > > On Thu, 12 Jan 2017 17:19:40 +1100 > > Alexey Kardashevskiy wrote: > > > > > On 12/01/17 14:52, David Gibson wrote: > > > >

Re: [libvirt] [PATCH 0/4] Doc update changes for my recent commits

On Wed, Jan 11, 2017 at 07:25:51AM -0500, John Ferlan wrote: These are all trivial and will push in a bit - I was essentially waiting for the news.html.in or news.xml to shake out before adjusting. John Ferlan (4): docs: Document the new vHBA/NPIV params for storage docs: Add NPIV/vHBA change

Re: [libvirt] [PATCH 3/4] docs: Add file system pool overwrite change description to news.xml

On Wed, Jan 11, 2017 at 07:25:54AM -0500, John Ferlan wrote: Add bug fixes description of overwrite changes for a file system storage pool Signed-off-by: John Ferlan --- docs/news.xml | 12 1 file changed, 12 insertions(+) diff --git a/docs/news.xml

Re: [libvirt] [PATCH 1/4] docs: Document the new vHBA/NPIV params for storage

On Wed, Jan 11, 2017 at 07:25:52AM -0500, John Ferlan wrote: Commit id 'bb74a7ffe' forgot to adjust the storage docs to describe the new fields. Signed-off-by: John Ferlan --- docs/formatstorage.html.in | 17 + 1 file changed, 17 insertions(+) diff --git

Re: [libvirt] [PATCH 1/3] Revert "storage: For FS pool check for properly formatted target volume"

On Thu, Jan 12, 2017 at 19:45:52 -0500, John Ferlan wrote: > > > On 01/12/2017 09:41 AM, Peter Krempa wrote: > > On Thu, Jan 12, 2017 at 09:36:01 -0500, John Ferlan wrote: > >> > >> > >> On 01/12/2017 09:24 AM, Peter Krempa wrote: > >>> The check does not work properly (crashes) with netfs