[libvirt] [PATCH] news: Fix xml dump of autogenerated websocket

--- Sorry for delay and thus not getting this news bit into release notes in time. docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 95b021a..3ff8f4e 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -274,6 +274,15 @@ for

[libvirt] [ libvirt-python BUG ?] Memory leak in libvirt_virConnectDomainEventJobCompletedCallback

Hi all, It seems that, there is a memory leak bug in libvirt_virConnectDomainEventJobCompletedCallback() function of libvirt-override.c. We didn't decrease the reference of 'pyobj_dict' in this function or any other places while pyt0bj_ret is not zero.

Re: [libvirt] Release of libvirt-3.0.0

On 01/17/2017 07:40 PM, Daniel Veillard wrote: > So I got mixed reports in the last day about the state of the head > but one of the big issues seems solved, and I'm not sure keeping the > freeze much longer will help, so libvirt-3.0.0 is out. It's tagged in > git, signed tarball and rpms are

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

On 01/17/2017 05:39 PM, Daniel P. Berrange wrote: I'm thinking we've hit the limit of what we should try to force into the 3.0.0 release. My vote at this poiint is to change the code so that namespaces are disabled out of the box, and do a 3.0.0 release. Look at fixing the bugs to turn it back

[libvirt] [PATCH 0/2] *** Expose host's cache information in capabilities ***

This series patches are the first step to support CAT featues, which also called cache tune in libvirt. First to expose cache information which could be tuned in capabilites XML, later will add some more interface to do cache tune. Some discussion about this feature support can be found from:

[libvirt] [PATCH 2/2] Resctrl: expose cache information to capabilities

This patch expose cache information to host's capabilites xml. There are some nits difference from RFC on mailing list. https://www.redhat.com/archives/libvir-list/2017-January/msg00644.html Signed-off-by: Eli Qiao --- src/conf/capabilities.c

[libvirt] [PATCH 1/2] Resctrl: Add some utils functions

This patch adds some utils struct and functions to expose resctrl information. virResCtrlAvailable: If resctrl interface exist on host virResCtrlGet: get specify type resource contral information virResCtrlInit: initialize resctrl struct from the host's sys fs. ResCtrlAll[]: an array to maintain

[libvirt] [PATCH] virsh: Modify description for LIBVIRT_DEBUG=4 in manpage

As LIBVIRT_DEBUG=4 logs only error messages and there are no levels above it, adjusting the description in the man page accordingly. Signed-off-by: Nitesh Konkar --- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod

Re: [libvirt] vms hung

Hi Michal, Well right now all the vms running fine, and this vm hung issue happening occasionally. The following out put is one of my running VM [root@kvm03 ~]# virsh qemu-monitor-command w7-DRAC '{"execute":"query-status"}'

[libvirt] [PATCH resend v2 2/2] virsh: introduce flage --direct for save command

From: Chen Hanxiao Base upon patches from Roy Keene This patch introduces --direct flag for save command. We could use this flag to save vm to a PIPE. We could saving a VM state directly to Ceph RBD images without having an intermediate file.

[libvirt] [PATCH resend v2 0/2] Allow saving QEMU libvirt state to a pipe

This series introduce flag VIR_DOMAIN_SAVE_DIRECT to enable command 'save' to write to PIPE. Base upon patches from Roy Keene with some fixes. Change from original patch: 1) Check whether the specified path is a PIPE. 2) Rebase on upstream. 3) Add doc for virsh command

[libvirt] [PATCH resend v2 1/2] qemu: Allow saving QEMU libvirt state to a pipe

From: Chen Hanxiao Base upon patches from Roy Keene Currently qemuDomainSaveMemory can save vm's config and memory to fd. It write a magic QEMU_SAVE_PARTIAL firstly, then re-open it to change QEMU_SAVE_PARTIAL as QEMU_SAVE_MAGIC. For pipes this

Re: [libvirt] [PATCH v2] Add support for Veritas HyperScale (VxHS) block device protocol

On Mon, Jan 16, 2017 at 1:10 AM, Daniel P. Berrange wrote: > On Sat, Jan 14, 2017 at 10:31:05AM -0500, John Ferlan wrote: >> [...] >> >> >> diff --git >> >> a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args >> >>

Re: [libvirt] [PATCH v2] Add support for Veritas HyperScale (VxHS) block device protocol

On Mon, Jan 16, 2017 at 5:48 AM, John Ferlan wrote: > > > On 01/16/2017 04:07 AM, Peter Krempa wrote: >> On Sat, Jan 14, 2017 at 10:31:05 -0500, John Ferlan wrote: >>> [...] >>> > diff --git > a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args >

Re: [libvirt] [PATCH] util: disallow resetting a pci-bridge device

On 01/17/2017 09:51 AM, Shivaprasad G Bhat wrote: It is distructive to attempt a reset on pci-bridge, the host can crash. The bridges won't contain any guest data and neither they can be passed through using vfio/stub. So, no point in allowing a reset for them. Signed-off-by: Shivaprasad G Bhat

[libvirt] Release of libvirt-3.0.0

So I got mixed reports in the last day about the state of the head but one of the big issues seems solved, and I'm not sure keeping the freeze much longer will help, so libvirt-3.0.0 is out. It's tagged in git, signed tarball and rpms are available at thet usual place:

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

On 01/17/2017 05:39 PM, Daniel P. Berrange wrote: > I'm thinking we've hit the limit of what we should try to force into the > 3.0.0 release. > > My vote at this poiint is to change the code so that namespaces are > disabled out of the box, and do a 3.0.0 release. Look at fixing the Ack. >

Re: [libvirt] [PATCH] tests: fix compilation of shunloadtest

On 01/17/2017 01:49 AM, Pavel Hrdina wrote: On Mon, Jan 16, 2017 at 11:06:17AM -0700, Jim Fehlig wrote: While local builds succeed fine, a build worker building in a chroot environment is encountering the following error with libvirt 3.0.0 release candidates [ 162s] shunloadtest.o: In

[libvirt] [PATCH V2] tests: fix compilation of shunloadtest

While local builds succeed fine, a build worker building in a chroot environment is encountering the following error with libvirt 3.0.0 release candidates [ 162s] shunloadtest.o: In function `main': [ 162s] /home/abuild/rpmbuild/BUILD/libvirt-3.0.0/tests/shunloadtest.c:110: undefined reference

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

On 17.01.2017 14:21, Michal Privoznik wrote: > On 01/17/2017 02:13 PM, Marc Hartmayer wrote: >> Update: >> It's a SELinux labeling problem and seems to be introduced by the >> QEMU namespace patches. >> > > I wouldn't guess from the error message that qemu is getting EPERM. > > Anyway, the

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

On Tue, Jan 17, 2017 at 04:41:57PM +0100, Michal Privoznik wrote: > On 01/17/2017 04:28 PM, Marc Hartmayer wrote: > > On Tue, Jan 17, 2017 at 03:28 PM +0100, Michal Privoznik > > wrote: > >> [Dropping libvirt-announce] > >> > >> On 01/17/2017 02:51 PM, Boris Fiuczynski

Re: [libvirt] [PATCH] qemu: catch failure of drive_add

On Tue, Jan 17, 2017 at 05:15 PM +0100, "Daniel P. Berrange" wrote: > Previously when QEMU failed "drive_add" due to an error opening > a file it would report > > "could not open disk image" > > These days though, QEMU reports > > "Could not open

[libvirt] [PATCH] qemu: catch failure of drive_add

Previously when QEMU failed "drive_add" due to an error opening a file it would report "could not open disk image" These days though, QEMU reports "Could not open '/tmp/virtd-test_e3hnhh5/disk1.qcow2': Permission denied" which we were not detecting as an error condition. Signed-off-by:

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

On Tue, Jan 17, 2017 at 04:41:57PM +0100, Michal Privoznik wrote: > On 01/17/2017 04:28 PM, Marc Hartmayer wrote: > > On Tue, Jan 17, 2017 at 03:28 PM +0100, Michal Privoznik > > wrote: > >> [Dropping libvirt-announce] > >> > >> On 01/17/2017 02:51 PM, Boris Fiuczynski

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

On Tue, Jan 17, 2017 at 04:41 PM +0100, Michal Privoznik wrote: > On 01/17/2017 04:28 PM, Marc Hartmayer wrote: >> On Tue, Jan 17, 2017 at 03:28 PM +0100, Michal Privoznik >> wrote: >>> [Dropping libvirt-announce] >>> >>> On 01/17/2017 02:51 PM, Boris

Re: [libvirt] [PATCH] tests: fix QED disk test in xlconfigtest

On 01/17/2017 04:39 AM, Joao Martins wrote: On 01/16/2017 06:45 PM, Jim Fehlig wrote: When LIBXL_HAVE_QED is defined, xlconfigtest fails 9) Xen XL-2-XML Format disk-qed ... command line: config parsing error in disk specification: no vdev specified in

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

On 01/17/2017 04:28 PM, Marc Hartmayer wrote: > On Tue, Jan 17, 2017 at 03:28 PM +0100, Michal Privoznik > wrote: >> [Dropping libvirt-announce] >> >> On 01/17/2017 02:51 PM, Boris Fiuczynski wrote: >>> On 01/17/2017 02:21 PM, Michal Privoznik wrote: >> >>

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

On Tue, Jan 17, 2017 at 03:28 PM +0100, Michal Privoznik wrote: > [Dropping libvirt-announce] > > On 01/17/2017 02:51 PM, Boris Fiuczynski wrote: >> On 01/17/2017 02:21 PM, Michal Privoznik wrote: > > > > > With v2.5.0 everything has worked. I'll

Re: [libvirt] [PATCH v3 0/2] Fabric name must not be required for fc_host capability

On 01/17/2017 04:22 PM, John Ferlan wrote: On 01/16/2017 08:27 AM, Boris Fiuczynski wrote: fabric_name is one of many fc_host attributes in Linux that is optional and left to the low-level driver to decide if it is implemented. --- Changes sinve v2: - removed virReadFCHostOption method -

Re: [libvirt] [Qemu-devel] [PATCH 0/9] i386: query-cpu-model-expansion test script

On 01/16/2017 08:01 PM, Eduardo Habkost wrote: This is a follow-up to the series that implements query-cpu-model-expansion. Before including the test script, the series has some fixes to allow the results of query-cpu-model-expansion to be used in the QEMU command-line. The script probably will

Re: [libvirt] [PATCH v3 0/2] Fabric name must not be required for fc_host capability

On 01/16/2017 08:27 AM, Boris Fiuczynski wrote: > fabric_name is one of many fc_host attributes in Linux that is optional > and left to the low-level driver to decide if it is implemented. > > --- > Changes sinve v2: > - removed virReadFCHostOption method > - changed additional file check to

Re: [libvirt] vms hung

On 01/16/2017 04:13 PM, Umar Draz wrote: > Hello, > > I am running libvirt-2.0.0-10.el7_3.2.x86_64 on CentOS 7.3, I have few vms > of CentOS and Windows 2012 servers. > > Randomly they are hung, but the status of virtual machine keep running, vnc > and network not responding. > > I have checked

Re: [libvirt] [PATCH 1/2] security: DAC: fix the transaction model's list append

> > -if (VIR_APPEND_ELEMENT(list->items, list->nItems, item) < 0) { > > -VIR_FREE(item); > > -return -1; > > -} > > +if (VIR_APPEND_ELEMENT(list->items, list->nItems, item) < 0) > > +goto cleanup; > > > > -return 0; > > +tmp = NULL; > > +item =

Re: [libvirt] [PATCH 2/2] security: SELinux: fix the transaction model's list append

> > @@ -111,21 +111,31 @@ > > virSecuritySELinuxContextListAppend(virSecuritySELinuxContextListPtr list, > > const char *tcon, > > bool optional) > > { > > -virSecuritySELinuxContextItemPtr item; > > +int ret = -1;

[libvirt] [PATCH v2 4/5] storage: added vstorage pool backend volume functions

Vstorage operates with volumes the same way as directory pool and netfs pool. We use the same functions. Signed-off-by: Olga Krishtal --- src/storage/storage_backend_vstorage.c | 342 + 1 file changed, 342 insertions(+) diff --git

[libvirt] [PATCH v2 3/5] storage: vstorage pool operations

Added create/define/etc pool operations for vstorage backend. The vstorage storage pool looks like netfs ones. Due to this some of pool/volume functions were taken with no changes: refresh pool function. Signed-off-by: Olga Krishtal ---

[libvirt] [PATCH v2 2/5] storage: vstorage empty backend

Added general defenitions for vstorage pool backend Signed-off-by: Olga Krishtal --- include/libvirt/libvirt-storage.h | 1 + po/POTFILES.in | 1 + src/Makefile.am| 9 + src/conf/storage_conf.c

[libvirt] [PATCH v2 1/5] storage: adds with_storage_vstorage buils option

This patch only adds --with-storage-vstorage build option. In order to use vstorage as a backend for storage pool vstorage tools should be installed. Signed-off-by: Olga Krishtal --- configure.ac| 4 +++ m4/virt-storage-vstorage.m4 | 73

[libvirt] [PATCH v2 0/5] storage: Virtuozzo storage backend for storage pool

This series of patches support pool and volume management within Virtuozzo Storage. Virtuozzo Storage is a highly-available distributed software defined storage with built-in replication and disaster recovery. More information about vzstorage can be found here:

[libvirt] [PATCH v2 5/5] storage: vstorage pool documentation and simple test

Signed-off-by: Olga Krishtal --- docs/formatstorage.html.in| 7 --- docs/schemas/storagepool.rng | 21 docs/storage.html.in | 28 ++-

[libvirt] [PATCH] util: disallow resetting a pci-bridge device

It is distructive to attempt a reset on pci-bridge, the host can crash. The bridges won't contain any guest data and neither they can be passed through using vfio/stub. So, no point in allowing a reset for them. Signed-off-by: Shivaprasad G Bhat --- src/util/virpci.c |

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

[Dropping libvirt-announce] On 01/17/2017 02:51 PM, Boris Fiuczynski wrote: > On 01/17/2017 02:21 PM, Michal Privoznik wrote: With v2.5.0 everything has worked. I'll take a closer look to it today. >> You can try and see if this is a namespace caused issue. Just

Re: [libvirt] [PATCH 2/2] security: SELinux: fix the transaction model's list append

On 01/17/2017 02:56 PM, Erik Skultety wrote: > The problem is in the way how the list item is created prior to > appending it to the transaction list - the @path argument is just a > shallow copy instead of deep copy of the hostdev device's path. > Unfortunately, the hostdev devices from which the

Re: [libvirt] [PATCH 1/2] security: DAC: fix the transaction model's list append

On 01/17/2017 02:56 PM, Erik Skultety wrote: > The problem is in the way how the list item is created prior to > appending it to the transaction list - the @path attribute is just a > shallow copy instead of deep copy of the hostdev device's path. > Unfortunately, the hostdev devices from which

Re: [libvirt] [PATCH] qemu: Don't leak hostCPUModelInfo in virQEMUCaps

On Tue, Jan 17, 2017 at 14:57:09 +0100, Peter Krempa wrote: > On Tue, Jan 17, 2017 at 14:40:21 +0100, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > src/qemu/qemu_capabilities.c | 1 + > > 1 file changed, 1 insertion(+) > > ACK, safe. Safely pushed.

[libvirt] [PATCH 2/2] security: SELinux: fix the transaction model's list append

The problem is in the way how the list item is created prior to appending it to the transaction list - the @path argument is just a shallow copy instead of deep copy of the hostdev device's path. Unfortunately, the hostdev devices from which the @path is extracted, in order to add them into the

Re: [libvirt] [PATCH] qemu: Don't leak hostCPUModelInfo in virQEMUCaps

On Tue, Jan 17, 2017 at 14:40:21 +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_capabilities.c | 1 + > 1 file changed, 1 insertion(+) ACK, safe. signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 1/2] security: DAC: fix the transaction model's list append

The problem is in the way how the list item is created prior to appending it to the transaction list - the @path attribute is just a shallow copy instead of deep copy of the hostdev device's path. Unfortunately, the hostdev devices from which the @path is extracted, in order to add them into the

[libvirt] [PATCH 0/2] security: Fix the transaction model's list appending

The problem lies in how elements are appended into the transaction list - instead of making a deep copy of a string we were doing a shallow copy only. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1413773 Erik Skultety (2): security: DAC: fix the transaction model's list append

Re: [libvirt] [PATCH 4/4] spec: Depend on the gluster command line tool

On Tue, Jan 10, 2017 at 07:44:59PM +0100, Peter Krempa wrote: The gluster command line tool that is used to lookup storage pool sources moved from the gluster-client package to gluster-cli. Unfortunately the location differs between fedora and rhel so depend on the package rather than binary.

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

On 01/17/2017 02:21 PM, Michal Privoznik wrote: With v2.5.0 everything has worked. I'll take a closer look to it today. You can try and see if this is a namespace caused issue. Just disable the namespaces and retry. If it succeeds with namespaces disabled, the bug indeed is in my

[libvirt] [PATCH] qemu: Don't leak hostCPUModelInfo in virQEMUCaps

Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 2512e4838..89e9dd471 100644 --- a/src/qemu/qemu_capabilities.c +++

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

On 01/17/2017 02:13 PM, Marc Hartmayer wrote: > Update: > It's a SELinux labeling problem and seems to be introduced by the > QEMU namespace patches. > I wouldn't guess from the error message that qemu is getting EPERM. Anyway, the SELinux issue is fixed in -rc2: commit

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

Update: It's a SELinux labeling problem and seems to be introduced by the QEMU namespace patches. On Tue, Jan 17, 2017 at 11:18 AM +0100, Marc Hartmayer wrote: > Hey, > > I have tried to live hot plug a disk backed on a qcow2 disk (see XML > snippet below) on a s390

Re: [libvirt] [PATCH 2/4] storage: gluster: Report error if no volumes were found in pool lookup

On Tue, Jan 10, 2017 at 07:44:57PM +0100, Peter Krempa wrote: Similarly to the 'netfs' pool, return an error if the host does not have any volumes. --- src/storage/storage_backend_gluster.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) ACK Jan signature.asc

Re: [libvirt] [PATCH 3/4] storage: gluster: Remove build-time dependency on the 'gluster' cli tool

On Tue, Jan 10, 2017 at 07:44:58PM +0100, Peter Krempa wrote: The tool is used for pool discovery. Since we call an external binary we don't really need to compile out the code that uses it. We can check whether it exists at runtime. --- configure.ac | 2 +-

Re: [libvirt] [PATCH 1/4] storage: Fix error reporting when looking up storage pool sources

On Tue, Jan 10, 2017 at 07:44:56PM +0100, Peter Krempa wrote: In commit 4090e15399 we went back from reporting no errors if no storage pools were found on a given host to reporting a bad error. And only in cases when gluster was not installed. Report a less bad error in case there are no

Re: [libvirt] [PATCH] qemu: Actually unshare() iff running as root

On Tue, Jan 17, 2017 at 12:32:16PM +0100, Michal Privoznik wrote: > While all the code that deals with qemu namespaces correctly > detects whether we are running as root (and turn into NO-OP for > qemu:///session) the actual unshare() call is not guarded with > such check. Therefore any attempt to

Re: [libvirt] How to generate better API documentation?

On Mon, Jan 16, 2017 at 09:17:03AM +, Daniel P. Berrange wrote: > > To me the key factor is what the end result looks like, how easy it is to > navigate & find stuff. From that POV doxygen is ruled out as the HTML it > generates is just awful - I despair every time i find a project which has

Re: [libvirt] [PATCH] tests: fix QED disk test in xlconfigtest

On 01/16/2017 06:45 PM, Jim Fehlig wrote: > When LIBXL_HAVE_QED is defined, xlconfigtest fails > > 9) Xen XL-2-XML Format disk-qed ... command line: config parsing error > in disk specification: no vdev specified in > >

[libvirt] [PATCH] qemu: Actually unshare() iff running as root

While all the code that deals with qemu namespaces correctly detects whether we are running as root (and turn into NO-OP for qemu:///session) the actual unshare() call is not guarded with such check. Therefore any attempt to start a domain under qemu:///session shall fail as unshare() is reserved

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

Hey, I have tried to live hot plug a disk backed on a qcow2 disk (see XML snippet below) on a s390 system and I've got the following error message: internal error: unable to execute QEMU command 'device_add': Property 'scsi-hd.drive' can't find value 'drive-scsi0-0-0-0'

Re: [libvirt] [PATCH] tests: fix compilation of shunloadtest

On Mon, Jan 16, 2017 at 11:06:17AM -0700, Jim Fehlig wrote: > While local builds succeed fine, a build worker building in a > chroot environment is encountering the following error with > libvirt 3.0.0 release candidates > > [ 162s] shunloadtest.o: In function `main': > [ 162s]

Re: [libvirt] [PATCH v2 0/4] Virtio-crypto device support

Hi, Ping... :) Regards, Longpeng(Mike) On 2017/1/11 16:28, Longpeng(Mike) wrote: > As virtio-crypto has been supported in QEMU 2.8 and the frontend > driver has been merged in linux 4.10, so it's necessary to support > virtio-crypto in libvirt. > > --- > Changes since v1: > - split patch