Re: [libvirt] [PATCH resend v2 0/2] Allow saving QEMU libvirt state to a pipe

2017-01-21 Thread Chen Hanxiao
At 2017-01-18 09:05:12, "Chen Hanxiao" wrote: >This series introduce flag VIR_DOMAIN_SAVE_DIRECT >to enable command 'save' to write to PIPE. > >Base upon patches from Roy Keene >with some fixes. > >Change from original patch: >1) Check whether the

Re: [libvirt] [PATCH v2] qemu_domain: add timestamp in tainting of guests log

2017-01-21 Thread John Ferlan
On 01/20/2017 03:46 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > We lacked of timestamp in tainting of guests log, > which bring troubles for finding guest issues: > such as whether a guest powerdown caused by qemu-monitor-command > or others issues inside guests. >

Re: [libvirt] [PATCH v2 3/5] storage: vstorage pool operations

2017-01-21 Thread John Ferlan
[...] >> >> If you want to support [NO_]OVERWRITE, then prior to calling the common >> function we can play with flags, thus you end up with just: >> >> if (flags & VIR_STORAGE_POOL_BUILD_OVERWRITE) >> dir_create_flags |= VIR_DIR_CREATE_ALLOW_EXIST; >> >> return

[libvirt] [PATCH 0/3] Move FS Storage Backend API's to storage_util

2017-01-21 Thread John Ferlan
While reviewing the Virtuozzo backend changes it became apparent that my initial review comments weren't fully understood. Rather than going back and forth more on this, I figured I'd take the plunge and make the "preparations". Also since the storage_util is the new dumping ground, I went there.

[libvirt] [PATCH 1/3] storage: Move the virStorageBackendFileSystem{Start|Stop} API's

2017-01-21 Thread John Ferlan
Just moving code around with minor adjustment to have the Stop code combine with the Unmount code since all the Stop code did was call the Unmount code. Signed-off-by: John Ferlan --- src/storage/storage_backend.c| 1 + src/storage/storage_backend_fs.c | 74

[libvirt] [PATCH 2/3] storage: Create common file/dir pool backend helpers

2017-01-21 Thread John Ferlan
Move some pool functions to storage_util to create local/common helpers using the same naming syntax as the existing upload, download, and wipe virStorageBackend*Local API's. In the process of doing so, found a few API's that can now become local to storage_util. In order to distinguish between

[libvirt] [PATCH 3/3] storage: Create common file/dir volume backend helpers

2017-01-21 Thread John Ferlan
Move all the volume functions to storage_util to create local/common helpers using the same naming syntax as the existing upload, download, and wipe virStorageBackend*Local API's. In the process of doing so, found more API's that can now become local to storage_util. In order to distinguish

[libvirt] [PATCH] docs: Reword virsh manpage for --uuid --name --details options

2017-01-21 Thread Nitesh Konkar
This commit is similar to commit 0977ada8.The virsh manpage lists options --uuid and --name as mutually exclusive if option --details is specified when actually the option --details is mutually exclusive and can't go with options --uuid and/or --name. This patch rewords the virsh manpage to state