[libvirt] [PATCH] THREADS.txt: fix typos

2017-01-24 Thread Chen Hanxiao
From: Chen Hanxiao s/wakup/wakeup Signed-off-by: Chen Hanxiao --- daemon/THREADS.txt | 2 +- src/util/vireventpoll.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/THREADS.txt b/daemon/THREADS.txt index

Re: [libvirt] [PATCH v2] network: make openvswitch call timeout compile time configurable

2017-01-24 Thread Laine Stump
On 01/24/2017 10:53 AM, Boris Fiuczynski wrote: Since a successful completion of the calls to openvswitch is expected a long timeout should be chosen to account for heavily loaded systems. Therefore this patch increases the timeout value from 5 to 120 seconds as default value and also allows to

Re: [libvirt] [PATCH 3/4] xenconfig: add support for more timers

2017-01-24 Thread Jim Fehlig
On 01/20/2017 04:16 PM, Joao Martins wrote: On 01/20/2017 10:17 PM, Jim Fehlig wrote: On 01/20/2017 05:00 AM, Joao Martins wrote: On 01/20/2017 01:59 AM, Jim Fehlig wrote: Currently xenconfig only supports the hpet timer for HVM domains. Include support for tsc timer for both PV and HVM

Re: [libvirt] OSX Homebrew support note ;)

2017-01-24 Thread Justin Clift
On 24 Jan 2017, at 10:33, Daniel P. Berrange wrote: > So lets enable QEMU in libvirt and for OS-X and just let people file > bugs if they find bits that don't work. Just compiled Libvirt (3.0.0 release) on OSX, using "--with-qemu" on the configure line. QEMU 2.8.0 is

Re: [libvirt] [PATCH v1 1/4] bhyve: detect 32 SATA devices per controller support

2017-01-24 Thread Fabian Freyer
On 24 Jan 2017, at 16:31, Laine Stump wrote: +cmd = virCommandNew(binary); +virCommandAddArgList(cmd, "-s", "0,ahci", NULL); +virCommandSetErrorBuffer(cmd, ); Too bad there isn't some way you could learn both of these with a single run of the binary. +if (virCommandRun(cmd,

Re: [libvirt] [PATCH 2/4] virDomainNetDefParseXML: s/ret/rv/

2017-01-24 Thread Laine Stump
On 01/24/2017 10:40 AM, Michal Privoznik wrote: We use @ret to hold the actual return value of the function we are currently in. To hold a return value of a function called we use different variables: @rv, @rc, etc. Honour this naming scheme in virDomainNetDefParseXML too. Signed-off-by: Michal

Re: [libvirt] [PATCH 1/4] formatnetwork.html.in: Fix #elementsNICS anchor

2017-01-24 Thread Laine Stump
On 01/24/2017 10:40 AM, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- docs/formatnetwork.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 291dcea12..8638df96e

Re: [libvirt] [PATCH v2] network: make openvswitch call timeout compile time configurable

2017-01-24 Thread Michal Privoznik
On 01/24/2017 04:53 PM, Boris Fiuczynski wrote: > Since a successful completion of the calls to openvswitch is expected > a long timeout should be chosen to account for heavily loaded systems. > Therefore this patch increases the timeout value from 5 to 120 seconds > as default value and also

Re: [libvirt] [PATCH 3/3] storage: Create common file/dir volume backend helpers

2017-01-24 Thread Olga Krishtal
On 21/01/17 20:23, John Ferlan wrote: Move all the volume functions to storage_util to create local/common helpers using the same naming syntax as the existing upload, download, and wipe virStorageBackend*Local API's. In the process of doing so, found more API's that can now become local to

Re: [libvirt] [PATCH 1/3] storage: Move the virStorageBackendFileSystem{Start|Stop} API's

2017-01-24 Thread Olga Krishtal
On 21/01/17 20:23, John Ferlan wrote: Just moving code around with minor adjustment to have the Stop code combine with the Unmount code since all the Stop code did was call the Unmount code. Signed-off-by: John Ferlan --- src/storage/storage_backend.c| 1 +

Re: [libvirt] [PATCH 2/3] storage: Create common file/dir pool backend helpers

2017-01-24 Thread Olga Krishtal
On 21/01/17 20:23, John Ferlan wrote: Move some pool functions to storage_util to create local/common helpers using the same naming syntax as the existing upload, download, and wipe virStorageBackend*Local API's. In the process of doing so, found a few API's that can now become local to

[libvirt] [PATCH] configure: fix indentation in TLS priority result

2017-01-24 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- m4/virt-tls-priority.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-tls-priority.m4 b/m4/virt-tls-priority.m4 index f7a6c56..44d9f68 100644 --- a/m4/virt-tls-priority.m4 +++ b/m4/virt-tls-priority.m4

[libvirt] [PATCH v2] network: make openvswitch call timeout compile time configurable

2017-01-24 Thread Boris Fiuczynski
Since a successful completion of the calls to openvswitch is expected a long timeout should be chosen to account for heavily loaded systems. Therefore this patch increases the timeout value from 5 to 120 seconds as default value and also allows to set the openvswitch timeout value by specifying

Re: [libvirt] [PATCH 2/3] conf: support mtu attribute in a network's element

2017-01-24 Thread Michal Privoznik
On 01/24/2017 04:24 PM, Laine Stump wrote: > On 01/24/2017 05:34 AM, Michal Privoznik wrote: >> On 01/23/2017 04:35 PM, Laine Stump wrote: >>> Example: >>> >>> >>> ... >>> >>> ... >>> >> BTW: what if we want to set MTU over some different network types? For >> instance, if

Re: [libvirt] [PATCH v1 2/4] bhyve: add virBhyveDriverCreateXMLConf

2017-01-24 Thread Laine Stump
On 01/05/2017 09:46 AM, Roman Bogorodskiy wrote: Add virBhyveDriverCreateXMLConf, a simple wrapper around virDomainXMLOptionNew that makes it easier to pass bhyveConnPtr as a private data for parser. It will be used later for device address allocation at parsing time. Update consumers to use it

[libvirt] [PATCH 3/4] domain_conf: Introduce to

2017-01-24 Thread Michal Privoznik
So far we allow to set MTU for libvirt networks. However, not all domain interfaces have to be plugged into a libvirt network and even if they are, they might want to have a different MTU (e.g. for testing purposes). Signed-off-by: Michal Privoznik ---

[libvirt] [PATCH 4/4] qemu: Implement mtu on interface

2017-01-24 Thread Michal Privoznik
Not only we should set the MTU on the host end of the device but also let qemu know what MTU did we set. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 +

[libvirt] [PATCH 2/4] virDomainNetDefParseXML: s/ret/rv/

2017-01-24 Thread Michal Privoznik
We use @ret to hold the actual return value of the function we are currently in. To hold a return value of a function called we use different variables: @rv, @rc, etc. Honour this naming scheme in virDomainNetDefParseXML too. Signed-off-by: Michal Privoznik ---

[libvirt] [PATCH 1/4] formatnetwork.html.in: Fix #elementsNICS anchor

2017-01-24 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- docs/formatnetwork.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 291dcea12..8638df96e 100644 --- a/docs/formatnetwork.html.in +++

[libvirt] [PATCH 0/4] Support setting MTU on domain interfaces

2017-01-24 Thread Michal Privoznik
After Laine merges his patches [1] the only missing piece is setting MTU on a domain . Well, up until now :-) 1: https://www.redhat.com/archives/libvir-list/2017-January/msg00946.html Michal Privoznik (4): formatnetwork.html.in: Fix #elementsNICS anchor virDomainNetDefParseXML: s/ret/rv/

Re: [libvirt] [PATCH v1 1/4] bhyve: detect 32 SATA devices per controller support

2017-01-24 Thread Laine Stump
On 01/05/2017 09:46 AM, Roman Bogorodskiy wrote: From: Fabian Freyer Introduce a BHYVE_CAP_AHCI32SLOT capability that shows if 32 devices per SATA controller are supported, and a bhyveProbeCapsAHCI32Slot function that probes it. ---

Re: [libvirt] [PATCH 2/3] conf: support mtu attribute in a network's element

2017-01-24 Thread Laine Stump
On 01/24/2017 05:34 AM, Michal Privoznik wrote: On 01/23/2017 04:35 PM, Laine Stump wrote: Example: ... ... BTW: what if we want to set MTU over some different network types? For instance, if we have a network with a pool of phys NICs. Is it worth to set MTU there too?

Re: [libvirt] [PATCH 2/3] conf: support mtu attribute in a network's element

2017-01-24 Thread Michal Privoznik
On 01/23/2017 04:35 PM, Laine Stump wrote: > Example: > > > ... > > ... > BTW: what if we want to set MTU over some different network types? For instance, if we have a network with a pool of phys NICs. Is it worth to set MTU there too? If so, then we might need to move the

Re: [libvirt] OSX Homebrew support note ;)

2017-01-24 Thread Daniel P. Berrange
On Mon, Jan 23, 2017 at 03:29:01PM +, Justin Clift wrote: > On 23 Jan 2017, at 11:38, Daniel P. Berrange wrote: > > On Wed, Dec 21, 2016 at 09:55:53AM +, Justin Clift wrote: > > > > > I'm looking at (what I hope is the correct) configuration file for the > > build:

Re: [libvirt] [PATCH v2 00/12] qemu: migration: show disks stats for nbd migration

2017-01-24 Thread Nikolay Shirokovskiy
ping On 28.12.2016 17:39, Nikolay Shirokovskiy wrote: > diff from v1: > > 1. patch "qemu: clean out unused migrate to unix" is dropped > as it is already pushed. > 2. a lot of refactoring patches added, namely all except > the last patch. > 3. fetching mirroring stats is done

[libvirt] [PATCH] perf: Prevent enabling of already enabled perf event

2017-01-24 Thread Nitesh Konkar
Currently, on every --enable perf_event command, a new event->fd is created and counting of perf event counter starts from zero and previous event->fd is lost. This patch prevents this behaviour. Signed-off-by: Nitesh Konkar --- src/util/virperf.c | 3 +++ 1 file