Re: [libvirt] [PATCH 3/5] util: Introduce virFileMoveMount

On 01/30/2017 10:14 PM, Olaf Hering wrote: > On Wed, Jan 11, Michal Privoznik wrote: > >> This is a simple wrapper over mount(). However, not every system >> out there is capable of moving a mount point. Therefore, instead >> of having to deal with this fact in all the places of our code we >>

[libvirt] [PATCH 0/2] vz: support more API calls

Nikolay Shirokovskiy (2): vz: support virDomainAbortJob vz: support virDomainReset src/vz/vz_driver.c | 53 + src/vz/vz_sdk.c| 48 src/vz/vz_sdk.h| 2 ++ src/vz/vz_utils.c | 1 +

[libvirt] [PATCH 1/2] vz: support virDomainAbortJob

--- src/vz/vz_driver.c | 21 + src/vz/vz_sdk.c| 33 + src/vz/vz_sdk.h| 1 + src/vz/vz_utils.c | 1 + src/vz/vz_utils.h | 2 ++ 5 files changed, 58 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index

[libvirt] [PATCH 2/2] vz: support virDomainReset

--- src/vz/vz_driver.c | 32 src/vz/vz_sdk.c| 15 +++ src/vz/vz_sdk.h| 1 + 3 files changed, 48 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 0547de5..6aade90 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c

Re: [libvirt] char: Logging serial pty output when disconnected

On Fri, Jan 27, 2017 at 1:40 AM, Daniel P. Berrange wrote: > On Thu, Jan 26, 2017 at 05:07:16PM -0800, Ed Swierk wrote: >> Currently qemu_chr_fe_write() calls qemu_chr_fe_write_log() only for >> data consumed by the backend chr_write function. With the pty backend, >>

Re: [libvirt] [PATCH 3/5] util: Introduce virFileMoveMount

On Wed, Jan 11, Michal Privoznik wrote: > This is a simple wrapper over mount(). However, not every system > out there is capable of moving a mount point. Therefore, instead > of having to deal with this fact in all the places of our code we > can have a simple wrapper and deal with this fact at

Re: [libvirt] [PATCH] remote generator: handle remoteDomainCreateWithFlags()

On Thu, Jan 19, 2017 at 09:17 PM +0100, Marc Hartmayer wrote: > This commit removes the handcrafted code for > remoteDomainCreateWithFlags() and lets it auto generate. > > A little bit of history repeating... > Commit 03d813bbcd7b4a183601055006 removed the auto

Re: [libvirt] [PATCH v1 0/4] bhyve: rework SATA address allocation

Andrea Bolognani wrote: > On Thu, 2017-01-05 at 18:46 +0400, Roman Bogorodskiy wrote: > > This series reworks SATA address allocation in the bhyve driver. > > > > While commit messages provide enough details (I hope), there > > are some general important notes: > > > > - currently, sata

Re: [libvirt] [PATCH v1 3/4] bhyve: fix SATA address allocation

Laine Stump wrote: > On 01/05/2017 09:46 AM, Roman Bogorodskiy wrote: > > As bhyve for a long time didn't have a notion of the explicit SATA > > controller and created a controller for each drive, the bhyve driver > > in libvirt acted in a similar way and didn't care about the SATA > >

Re: [libvirt] [PATCH] vz: don't show bootorder for containers

30-Jan-17 18:35, Maxim Nestratov пишет: 29-Dec-16 12:58, Nikolay Shirokovskiy пишет: Because this is invalid xml for containers. This patch almost reverts 7eda8369, but still skips converting vz sdk bootorder for containers to libvirt bootorder because we use boot order in containers for

Re: [libvirt] [PATCH 0/5] implement .connectGetAllDomainStats

12-Dec-16 10:56, Nikolay Shirokovskiy пишет: Nikolay Shirokovskiy (5): vz: provide block stats for all domain stats vz: add net group to all domain stats vz: add vcpu group to all domain stats vz: add balloon group to all domain stats vz: add state group to all domain stats

Re: [libvirt] [PATCH 00/10] Another set of qemu namespace fixes

On Mon, Jan 30, 2017 at 11:15 AM +0100, Michal Privoznik wrote: > On 01/20/2017 10:42 AM, Michal Privoznik wrote: >> The major problem was with symlinks. Imagine the following chain of symlinks: >> >> /dev/my_awesome_disk -> /home/user/blaah -> /dev/disk/by-uuid/$uuid -> >>

Re: [libvirt] [PATCH 5/5] vz: add state group to all domain stats

12-Dec-16 10:56, Nikolay Shirokovskiy пишет: --- src/vz/vz_driver.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 01c1a96..d9bd2cd 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -3729,6 +3729,28 @@

Re: [libvirt] [PATCH 1/5] vz: provide block stats for all domain stats

12-Dec-16 10:56, Nikolay Shirokovskiy пишет: --- src/vz/vz_driver.c | 189 + src/vz/vz_sdk.c| 8 +++ 2 files changed, 197 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 08f7961..6d173ef 100644 ---

[libvirt] [PATCH] conf: check port range even for USB hubs

Move the range check introduced by commit 2650d5e into virDomainUSBAddressFindPort. That way both virDomainUSBAddressRelease and virDomainUSBAddressSetAddHub can benefit from it. Reported-by: Michal Privoznik --- src/conf/domain_addr.c | 19 ++- 1 file

Re: [libvirt] [PATCH] vz: don't show bootorder for containers

29-Dec-16 12:58, Nikolay Shirokovskiy пишет: Because this is invalid xml for containers. This patch almost reverts 7eda8369, but still skips converting vz sdk bootorder for containers to libvirt bootorder because we use boot order in containers for quite different purpurse. --- I know I

[libvirt] [PATCH] util: fix off-by-one when expanding a bitmap

To make sure bit 'b' fits into the bitmap, we need to allocate b+1 bits, since we number from 0. Adjust the bitmap test to use a multiple of 8 to catch this invalid write. --- src/util/virbitmap.c | 2 +- tests/virbitmaptest.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[libvirt] [PATCH] Validate required CPU features even for host-passthrough

Commit adff345 allowed enabling features with -cpu host without ajdusting the validity checks on domain startup and migration. --- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_process.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_migration.c

Re: [libvirt] [PATCHv4 0/3] Add support for file memorybacking

On Mon, Jan 30, 2017 at 12:16:38PM +, Safka, JaroslavX wrote: > > > > -Original Message- > > From: Pavel Hrdina [mailto:phrd...@redhat.com] > > Sent: Monday, January 30, 2017 1:13 PM > > To: Safka, JaroslavX > > Cc: Daniel P. Berrange

Re: [libvirt] [PATCHv4 0/3] Add support for file memorybacking

> -Original Message- > From: Pavel Hrdina [mailto:phrd...@redhat.com] > Sent: Monday, January 30, 2017 1:13 PM > To: Safka, JaroslavX > Cc: Daniel P. Berrange ; Michal Privoznik > ; libvir-list@redhat.com; Mooney, Sean

Re: [libvirt] [PATCHv4 0/3] Add support for file memorybacking

On Mon, Jan 30, 2017 at 12:06:19PM +, Safka, JaroslavX wrote: > > > > -Original Message- > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > Sent: Monday, January 30, 2017 12:35 PM > > To: Michal Privoznik > > Cc: Safka, JaroslavX

Re: [libvirt] [PATCHv4 3/3] qemu: Add args generation for file memory backing

On Mon, Jan 30, 2017 at 11:38:08AM +, Daniel P. Berrange wrote: > On Sat, Jan 28, 2017 at 03:03:16PM +0100, Michal Privoznik wrote: > > On 13.12.2016 13:12, Jaroslav Safka wrote: > > > This patch add support for file memory backing on numa topology. > > > > > > The specified access mode in

Re: [libvirt] [PATCHv4 0/3] Add support for file memorybacking

> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Monday, January 30, 2017 12:35 PM > To: Michal Privoznik > Cc: Safka, JaroslavX ; libvir-list@redhat.com; > Mooney, Sean K ;

Re: [libvirt] [PATCHv4 3/3] qemu: Add args generation for file memory backing

> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Monday, January 30, 2017 12:38 PM > To: Michal Privoznik > Cc: Safka, JaroslavX ; libvir-list@redhat.com; > Mooney, Sean K ;

Re: [libvirt] [PATCHv4 3/3] qemu: Add args generation for file memory backing

On Sat, Jan 28, 2017 at 03:03:16PM +0100, Michal Privoznik wrote: > On 13.12.2016 13:12, Jaroslav Safka wrote: > > This patch add support for file memory backing on numa topology. > > > > The specified access mode in memoryBacking can be overriden > > by specifying token memAccess in numa cell. >

Re: [libvirt] [PATCHv4 0/3] Add support for file memorybacking

On Sat, Jan 28, 2017 at 03:03:02PM +0100, Michal Privoznik wrote: > On 13.12.2016 13:12, Jaroslav Safka wrote: > > Hi, > > we would like to introduce 3 new elements source,access and allocation in > > memoryBacking element. > > For now it was made for numa topology. > > > > > > > >

Re: [libvirt] [PATCH 00/10] Another set of qemu namespace fixes

On 01/20/2017 10:42 AM, Michal Privoznik wrote: > The major problem was with symlinks. Imagine the following chain of symlinks: > > /dev/my_awesome_disk -> /home/user/blaah -> /dev/disk/by-uuid/$uuid -> > /dev/sda > > We really need to create all those /dev/* symlinks and /dev/sda device. Also,

Re: [libvirt] [PATCH] Add libvirt-go-xml and libvirt-console-proxy to downloads

On Thu, 2017-01-26 at 15:44 +, Daniel P. Berrange wrote: > Add recently created modules to the download page list. > > Signed-off-by: Daniel P. Berrange > --- > docs/downloads.html.in | 34 ++ > 1 file changed, 34 insertions(+) ACK --

Re: [libvirt] [PATCHv4 0/3] Add support for file memorybacking

On 01/30/2017 09:07 AM, Safka, JaroslavX wrote: > Hi, > first , thanks much for review. > Comments inside > >> -Original Message- >> From: Michal Privoznik [mailto:mpriv...@redhat.com] >> Sent: Saturday, January 28, 2017 3:03 PM >> To: Safka, JaroslavX ;

Re: [libvirt] [PATCH] qemuBuildChrChardevStr: Don't leak @charAlias

On Mon, Jan 30, 2017 at 10:28:53AM +0100, Michal Privoznik wrote: > ==12618== 110 bytes in 10 blocks are definitely lost in loss record 269 of 295 > ==12618==at 0x4C2AE5F: malloc (vg_replace_malloc.c:297) > ==12618==by 0x1CFC6DD7: vasprintf (vasprintf.c:73) > ==12618==by 0x1912B2FC:

[libvirt] [PATCH] qemuBuildChrChardevStr: Don't leak @charAlias

==12618== 110 bytes in 10 blocks are definitely lost in loss record 269 of 295 ==12618==at 0x4C2AE5F: malloc (vg_replace_malloc.c:297) ==12618==by 0x1CFC6DD7: vasprintf (vasprintf.c:73) ==12618==by 0x1912B2FC: virVasprintfInternal (virstring.c:551) ==12618==by 0x1912B411:

Re: [libvirt] [PATCH] spec: Enable qemu driver for RHEL-7 on aarch64

On Fri, 2017-01-27 at 18:48 +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > libvirt.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 7d8858d3f..e8c272bd7 100644 > ---

Re: [libvirt] [PATCHv4 0/3] Add support for file memorybacking

Hi, first , thanks much for review. Comments inside > -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Saturday, January 28, 2017 3:03 PM > To: Safka, JaroslavX ; libvir-list@redhat.com > Cc: Mooney, Sean K

Re: [libvirt] [PATCHv4 2/3] conf: Add new xml elements for file memorybacking support

Comments inside. > -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Saturday, January 28, 2017 3:03 PM > To: Safka, JaroslavX ; libvir-list@redhat.com > Cc: Mooney, Sean K ; Ptacek, MichalX >

Re: [libvirt] [PATCHv4 3/3] qemu: Add args generation for file memory backing

Comments inside > -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Saturday, January 28, 2017 3:03 PM > To: Safka, JaroslavX ; libvir-list@redhat.com > Cc: Mooney, Sean K ; Ptacek, MichalX >