[libvirt] [PATCH RESEND] vz: make more accurate closing connection to sdk

2017-02-02 Thread Nikolay Shirokovskiy
Current code for example can call unsubscribe if connection succeeds but subscribing fails. This will probabaly lead only to spurious error messages without any actual inconsistencies but nevertheless. --- src/vz/vz_driver.c | 9 ++-- src/vz/vz_sdk.c| 65

[libvirt] [V2 3/5] Resctrl: Add new xml element to support cache tune

2017-02-02 Thread Eli Qiao
This patch adds new xml element to support cache tune as: ... ... id: any non-minus number host_id: reference of the host's cache banks id, it's from capabilities type: cache bank type size: should be multiples of the min_size of the bank on host. --- docs/schemas/domaincommon.rng |

[libvirt] [V2 5/5] Qemu: Set cache banks

2017-02-02 Thread Eli Qiao
Set cache banks while booting a new domain. Signed-off-by: Eli Qiao --- src/qemu/qemu_process.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 184440d..ec3d3c2 100644 --- a/src/qemu/qemu_process.c

[libvirt] [V2 4/5] Resctrl: Add private interface to set cachebanks

2017-02-02 Thread Eli Qiao
virResCtrlSetCacheBanks: Set cache banks of a libvirt domain. It will create new resource domain under `/sys/fs/resctrl` and fill the schemata according the cache banks configration. virResCtrlUpdate: Update the schemata after libvirt domain destroy. Signed-off-by: Eli Qiao

[libvirt] [V2 1/5] Resctrl: Add some utils functions

2017-02-02 Thread Eli Qiao
This patch adds some utils struct and functions to expose resctrl information. virResCtrlAvailable: If resctrl interface exist on host virResCtrlGet: get specify type resource contral information virResCtrlInit: initialize resctrl struct from the host's sys fs. ResCtrlAll[]: an array to maintain

[libvirt] [V2 2/5] Resctrl: expose cache information to capabilities

2017-02-02 Thread Eli Qiao
This patch expose cache information to host's capabilites xml. For l3 cache allocation For l3 cache allocation supported cdp(seperate data/code): RFC on mailing list. https://www.redhat.com/archives/libvir-list/2017-January/msg00644.html

[libvirt] [V2 0/5] Support cache tune in libvirt

2017-02-02 Thread Eli Qiao
This series patches are for supportting CAT featues, which also called cache tune in libvirt. First to expose cache information which could be tuned in capabilites XML. Then add new domain xml element support to add cacahe bank which will apply on this libvirt domain. This series patches add a

[libvirt] [PATCH 1/2] libxl: honor autoballoon setting in libxl.conf

2017-02-02 Thread Jim Fehlig
libxlGetAutoballoonConf is supposed to honor user-specified autoballoon setting in libxl.conf. As written, the user-specified setting could be overwritten by the subsequent logic to check dom0_mem parameter. If user-specified setting is present and correct, accept it. Only fallback to checking Xen

[libvirt] [PATCH 0/2] libxl: some small fixes

2017-02-02 Thread Jim Fehlig
I noticed a few small bugs while fixing the domain maximum memory bugs :-). See patches for details. Jim Fehlig (2): libxl: honor autoballoon setting in libxl.conf libxl: use init and dispose functions with libxl_physinfo src/libxl/libxl_capabilities.c | 16 +++-

[libvirt] [PATCH 2/2] libxl: use init and dispose functions with libxl_physinfo

2017-02-02 Thread Jim Fehlig
The typical pattern when calling libxl functions that populate a structure is libxl_foo foo; libxl_foo_init(); libxl_get_foo(ctx, ); ... libxl_foo_dispose(); Fix several instances of libxl_physinfo missing the init and dispose calls. Signed-off-by: Jim Fehlig ---

[libvirt] [PATCH 0/2] libxl: a few domain maximum memory fixes

2017-02-02 Thread Jim Fehlig
Patch 1 fixes reporting of domain maximum memory for running domains. When creating a virDomainDef object to represent dom0, max memory was not set correctly, which is fixed by patch2. Jim Fehlig (2): libxl: fix reporting of maximum memory libxl: fix dom0 maximum memory setting

[libvirt] [PATCH 2/2] libxl: fix dom0 maximum memory setting

2017-02-02 Thread Jim Fehlig
When the libxl driver is initialized, it creates a virDomainDef object for dom0 and adds it to the list of domains. Total memory for dom0 was being set from the max_memkb field of libxl_dominfo struct retrieved from libxl, but this field can be set to LIBXL_MEMKB_DEFAULT (~0ULL) if dom0 maximum

[libvirt] [PATCH 1/2] libxl: fix reporting of maximum memory

2017-02-02 Thread Jim Fehlig
The libxl driver reports different values of maximum memory depending on state of a domain. If inactive, maximum memory value is reported correctly. When active, maximum memory is derived from max_pages value returned by the XEN_SYSCTL_getdomaininfolist sysctl operation. But max_pages can be

Re: [libvirt] [PATCH] qemu: Allow empty script path to

2017-02-02 Thread Kashyap Chamarthy
On Thu, Feb 02, 2017 at 05:12:54PM +, Daniel P. Berrange wrote: > On Thu, Feb 02, 2017 at 04:55:29PM +0100, Kashyap Chamarthy wrote: [...] > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1412834 > > > > IIUC, this bug was filed to handle the case of _existing_ VMs that were > > not

Re: [libvirt] [PATCH 02/10] util: Introduce virFileReadLink

2017-02-02 Thread Martin Kletzander
On Thu, Feb 02, 2017 at 03:09:15PM +, Daniel P. Berrange wrote: On Thu, Feb 02, 2017 at 03:11:56PM +0100, Martin Kletzander wrote: On Fri, Jan 20, 2017 at 10:42:42AM +0100, Michal Privoznik wrote: > We will need to traverse the symlinks one step at the time. > Therefore we need to see where

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2017 at 06:21:55PM +, Daniel P. Berrange wrote: > On Thu, Feb 02, 2017 at 07:31:49PM +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 02, 2017 at 05:29:08PM +, Daniel P. Berrange wrote: > > > On Thu, Feb 02, 2017 at 07:20:35PM +0200, Michael S. Tsirkin wrote: > > > > On

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 07:31:49PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2017 at 05:29:08PM +, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 07:20:35PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Feb 02, 2017 at 05:10:28PM +, Daniel P. Berrange wrote: > > > > On

Re: [libvirt] [Xen-devel] [PATCH] libxl: fix dom0 autoballooning with Xen 4.8

2017-02-02 Thread Jim Fehlig
On 02/02/2017 04:42 AM, Wei Liu wrote: I saw this mail but didn't realise it required my input, sorry. I suppose it didn't and I was shamelessly fishing for a review - so you have my apologies :-). But the patch does fix an annoying, easily encountered bug which I'm eager to see resolved in

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2017 at 05:29:08PM +, Daniel P. Berrange wrote: > On Thu, Feb 02, 2017 at 07:20:35PM +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 02, 2017 at 05:10:28PM +, Daniel P. Berrange wrote: > > > On Thu, Feb 02, 2017 at 06:21:55PM +0200, Michael S. Tsirkin wrote: > > > > On

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 07:20:35PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2017 at 05:10:28PM +, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 06:21:55PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Feb 02, 2017 at 03:06:21PM +, Daniel P. Berrange wrote: > > > > On

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2017 at 05:10:28PM +, Daniel P. Berrange wrote: > On Thu, Feb 02, 2017 at 06:21:55PM +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 02, 2017 at 03:06:21PM +, Daniel P. Berrange wrote: > > > On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: > > > > > > > >

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Maxime Coquelin
On 02/02/2017 06:09 PM, Michael S. Tsirkin wrote: On Thu, Feb 02, 2017 at 11:47:57AM -0500, Laine Stump wrote: On 02/02/2017 10:06 AM, Daniel P. Berrange wrote: On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: It depends

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 07:09:24PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2017 at 11:47:57AM -0500, Laine Stump wrote: > > On 02/02/2017 10:06 AM, Daniel P. Berrange wrote: > > > On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: > > > > > > > > On 02/01/2017 12:41 PM,

Re: [libvirt] [PATCH] qemu: Allow empty script path to

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 04:55:29PM +0100, Kashyap Chamarthy wrote: > On Thu, Feb 02, 2017 at 03:29:15PM +, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 04:21:39PM +0100, Michal Privoznik wrote: > > > On 02/02/2017 02:56 PM, Daniel P. Berrange wrote: > > > > On Thu, Feb 02, 2017 at

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 06:21:55PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2017 at 03:06:21PM +, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: > > > > > > > > > On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: > > > > > > > > It

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2017 at 11:47:57AM -0500, Laine Stump wrote: > On 02/02/2017 10:06 AM, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: > > > > > > On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: > > > > It depends where / how in OVS it needs to be

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Laine Stump
On 02/02/2017 10:06 AM, Daniel P. Berrange wrote: On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: It depends where / how in OVS it needs to be set. The only stuff libvirt does with OVS is to run 'add-port' and 'del-port'

Re: [libvirt] [PATCH 2/2] tests: qemuhotplug: Don't free the monitor object as part of @vm

2017-02-02 Thread Peter Krempa
On Thu, Feb 02, 2017 at 17:12:28 +0100, Marc Hartmayer wrote: > On Thu, Feb 02, 2017 at 04:46 PM +0100, Peter Krempa > wrote: > > The test monitor should be freed separately so we need to remove the > > pointer from the @vm object. This fixes a race condition crash in the > >

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2017 at 03:06:21PM +, Daniel P. Berrange wrote: > On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: > > > > > > On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: > > > > > > It depends where / how in OVS it needs to be set. The only stuff libvirt > > > does

Re: [libvirt] [PATCH 2/2] tests: qemuhotplug: Don't free the monitor object as part of @vm

2017-02-02 Thread Marc Hartmayer
On Thu, Feb 02, 2017 at 04:46 PM +0100, Peter Krempa wrote: > The test monitor should be freed separately so we need to remove the > pointer from the @vm object. This fixes a race condition crash in the > test introduced in commit a245abce43. > --- > tests/qemuhotplugtest.c |

Re: [libvirt] [PATCH] qemu: Allow empty script path to

2017-02-02 Thread Kashyap Chamarthy
On Thu, Feb 02, 2017 at 03:29:15PM +, Daniel P. Berrange wrote: > On Thu, Feb 02, 2017 at 04:21:39PM +0100, Michal Privoznik wrote: > > On 02/02/2017 02:56 PM, Daniel P. Berrange wrote: > > > On Thu, Feb 02, 2017 at 02:49:48PM +0100, Michal Privoznik wrote: > > >> Before 9c17d665fdc5f (v1.3.2

[libvirt] [PATCH 1/2] DON'T APPLY: Reproducer to serialize threads "correctly"

2017-02-02 Thread Peter Krempa
--- tests/qemumonitortestutils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index cfd0a38cb..98ea1266c 100644 --- a/tests/qemumonitortestutils.c +++ b/tests/qemumonitortestutils.c @@ -435,6 +435,8 @@

[libvirt] [PATCH 2/2] tests: qemuhotplug: Don't free the monitor object as part of @vm

2017-02-02 Thread Peter Krempa
The test monitor should be freed separately so we need to remove the pointer from the @vm object. This fixes a race condition crash in the test introduced in commit a245abce43. --- tests/qemuhotplugtest.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH 0/2] Fix random crash in qemuhotplugtest

2017-02-02 Thread Peter Krempa
First patch makes the bug 100%[1] reproducible. *[1]: Race conditions may apply. Peter Krempa (2): DON'T APPLY: Reproducer to serialize threads "correctly" tests: qemuhotplug: Don't free the monitor object as part of @vm tests/qemuhotplugtest.c | 10 +-

Re: [libvirt] [PATCH] qemu: Allow empty script path to

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 04:21:39PM +0100, Michal Privoznik wrote: > On 02/02/2017 02:56 PM, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 02:49:48PM +0100, Michal Privoznik wrote: > >> Before 9c17d665fdc5f (v1.3.2 - I know, right?) it was possible to > >> have the following interface

Re: [libvirt] [PATCH] qemu: Allow empty script path to

2017-02-02 Thread Michal Privoznik
On 02/02/2017 02:56 PM, Daniel P. Berrange wrote: > On Thu, Feb 02, 2017 at 02:49:48PM +0100, Michal Privoznik wrote: >> Before 9c17d665fdc5f (v1.3.2 - I know, right?) it was possible to >> have the following interface configuration: >> >> >> >> >> >> This resulted in -netdev

Re: [libvirt] [PATCH 02/10] util: Introduce virFileReadLink

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 03:11:56PM +0100, Martin Kletzander wrote: > On Fri, Jan 20, 2017 at 10:42:42AM +0100, Michal Privoznik wrote: > > We will need to traverse the symlinks one step at the time. > > Therefore we need to see where a symlink is pointing to. > > > > Signed-off-by: Michal

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: > > > On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: > > > > It depends where / how in OVS it needs to be set. The only stuff libvirt > > does with OVS is to run 'add-port' and 'del-port' commands via the ovs > > cli tool. We

[libvirt] [PATCH] tests: qemuhotplug: Fix memory leaks after cpu hotplug testing patches

2017-02-02 Thread Peter Krempa
testQemuHotplugCpuDataFree leaked @data always and testQemuHotplugCpuPrepare leaked @prefix on success --- Pushed as trivial. tests/qemuhotplugtest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 9a203bd44..8cceb883e 100644 ---

Re: [libvirt] [PATCH 05/10] qemu_security: Use more transactions

2017-02-02 Thread Martin Kletzander
On Fri, Jan 20, 2017 at 10:42:45AM +0100, Michal Privoznik wrote: The idea is to move all the seclabel setting to security driver. Having the relabel code spread all over the place looks very messy. Signed-off-by: Michal Privoznik --- src/qemu/qemu_security.c | 112

Re: [libvirt] [PATCH 04/10] qemuSecurityRestoreAllLabel: Don't use transactions

2017-02-02 Thread Martin Kletzander
On Fri, Jan 20, 2017 at 10:42:44AM +0100, Michal Privoznik wrote: Because of the nature of security driver transactions, it is impossible to use them properly. The thing is, transactions enter the domain namespace and commit all the seclabel changes. However, in RestoreAllLabel() this is

Re: [libvirt] [PATCH 03/10] qemuDomainPrepareDisk: Fix ordering

2017-02-02 Thread Martin Kletzander
On Fri, Jan 20, 2017 at 10:42:43AM +0100, Michal Privoznik wrote: The current ordering is as follows: 1) set label 2) create the device in namespace 3) allow device in the cgroup While this might work for now, it will definitely not work if the security driver would use transactions as in that

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Maxime Coquelin
On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: On Wed, Feb 01, 2017 at 12:33:22PM +0100, Maxime Coquelin wrote: On 02/01/2017 10:43 AM, Daniel P. Berrange wrote: On Wed, Feb 01, 2017 at 10:14:54AM +0100, Michal Privoznik wrote: On 02/01/2017 09:35 AM, Maxime Coquelin wrote: Solution

Re: [libvirt] [PATCH 02/10] util: Introduce virFileReadLink

2017-02-02 Thread Martin Kletzander
On Fri, Jan 20, 2017 at 10:42:42AM +0100, Michal Privoznik wrote: We will need to traverse the symlinks one step at the time. Therefore we need to see where a symlink is pointing to. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virfile.c

Re: [libvirt] [PATCH v2 1/3] cgroup: extract interface part from virCgroupGetPercpuStats

2017-02-02 Thread Nikolay Shirokovskiy
After refactorings of this patch virCgroupGetPercpuStats has little to do with cgroups. As already mentioned in commit message it mostly adapts raw cpu data to storage used in API. So I want to move this function elsewhere together with virCgroupCpuStatsPtr structure. I just can find proper

Re: [libvirt] [PATCH 01/10] virProcessRunInMountNamespace: Report errors from child

2017-02-02 Thread Martin Kletzander
On Fri, Jan 20, 2017 at 10:42:41AM +0100, Michal Privoznik wrote: The comment to the function states that the errors from the child process are reported. Well, the error buffer is filled with possible error messages. But then it is thrown away. Among with important error message from the child

Re: [libvirt] [PATCH] qemu: Allow empty script path to

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 02:49:48PM +0100, Michal Privoznik wrote: > Before 9c17d665fdc5f (v1.3.2 - I know, right?) it was possible to > have the following interface configuration: > > > > > > This resulted in -netdev tap,script=,.. Fortunately, qemu helped > us to get away with this

[libvirt] [PATCH] qemu: Allow empty script path to

2017-02-02 Thread Michal Privoznik
Before 9c17d665fdc5f (v1.3.2 - I know, right?) it was possible to have the following interface configuration: This resulted in -netdev tap,script=,.. Fortunately, qemu helped us to get away with this as it just ignored the empty script path. However, after the commit mentioned above

[libvirt] [PATCHv5 0/4] Add support for memory backing with file source

2017-02-02 Thread Jaroslav Safka
Hi, we would like to introduce 3 new elements source,access and allocation in memoryBacking element. For now it was made for numa topology. If allocation is immediate then -mem-prealloc should be added to the qemu commanline. If source is file then -object

[libvirt] [PATCHv5 3/4] conf: Add new xml elements for file memorybacking support

2017-02-02 Thread Jaroslav Safka
This part introduces new xml elements for file based memorybacking support and their parsing. (It allows vhost-user to be used without hugepages.) New xml elements: --- docs/formatdomain.html.in | 9 ++ docs/schemas/domaincommon.rng |

[libvirt] [PATCHv5 2/4] qemu_conf: Add param memory_backing_dir

2017-02-02 Thread Jaroslav Safka
Add new parameter memory_backing_dir where files will be stored when memoryBacking source is selected as file. Value is stored inside char* memoryBackingDir --- src/qemu/libvirtd_qemu.aug | 3 +++ src/qemu/qemu.conf | 4 src/qemu/qemu_conf.c | 9

[libvirt] [PATCHv5 4/4] qemu: Add args generation for file memory backing

2017-02-02 Thread Jaroslav Safka
This patch add support for file memory backing on numa topology. The specified access mode in memoryBacking can be overriden by specifying token memAccess in numa cell. --- src/qemu/qemu_command.c| 45 --

[libvirt] [PATCHv5 1/4] qemu, conf: Rename virNumaMemAccess to virDomainMemoryAccess

2017-02-02 Thread Jaroslav Safka
Rename to avoid duplicate code. Because virDomainMemoryAccess will be used in memorybacking for setting default behaviour. NOTE: The enum cannot be moved to qemu/domain_conf because of headers dependency --- src/conf/numa_conf.c| 15 --- src/conf/numa_conf.h| 14

[libvirt] [PATCH] qemu: Forbid slashes in shmem name

2017-02-02 Thread Martin Kletzander
With that users could access files outside /dev/shm. That itself isn't a security problem, but might cause some errors we want to avoid. So let's forbid slashes as we do with domain and volume names and also mention that in the schema. Resolves:

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 12:47:30PM +, Richard W.M. Jones wrote: > On Wed, Feb 01, 2017 at 04:54:01PM +, Daniel P. Berrange wrote: > > The virtlockd daemon has existed for years now, but we have never > > turned it on by default, requiring explicit user opt-in. This leaves > > users

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-02 Thread Richard W.M. Jones
On Wed, Feb 01, 2017 at 04:54:01PM +, Daniel P. Berrange wrote: > The virtlockd daemon has existed for years now, but we have never > turned it on by default, requiring explicit user opt-in. This leaves > users unprotected against accidents out of the box. > > By turning it on by default,

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-02 Thread Peter Krempa
On Thu, Feb 02, 2017 at 12:09:07 +, Daniel Berrange wrote: > On Thu, Feb 02, 2017 at 01:05:17PM +0100, Peter Krempa wrote: > > On Thu, Feb 02, 2017 at 10:02:54 +, Daniel Berrange wrote: > > > On Thu, Feb 02, 2017 at 10:58:50AM +0100, Peter Krempa wrote: > > > > On Wed, Feb 01, 2017 at

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 01:05:17PM +0100, Peter Krempa wrote: > On Thu, Feb 02, 2017 at 10:02:54 +, Daniel Berrange wrote: > > On Thu, Feb 02, 2017 at 10:58:50AM +0100, Peter Krempa wrote: > > > On Wed, Feb 01, 2017 at 18:11:28 +, Daniel Berrange wrote: > > > > On Wed, Feb 01, 2017 at

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-02 Thread Peter Krempa
On Thu, Feb 02, 2017 at 10:02:54 +, Daniel Berrange wrote: > On Thu, Feb 02, 2017 at 10:58:50AM +0100, Peter Krempa wrote: > > On Wed, Feb 01, 2017 at 18:11:28 +, Daniel Berrange wrote: > > > On Wed, Feb 01, 2017 at 07:04:54PM +0100, Peter Krempa wrote: > > > > On Wed, Feb 01, 2017 at

Re: [libvirt] [PATCH] qemu: enforce maximum ports value for nec-xhci

2017-02-02 Thread John Ferlan
On 01/31/2017 09:08 AM, Ján Tomko wrote: > This controller only allows up to 15 ports. > > https://bugzilla.redhat.com/show_bug.cgi?id=1375417 > --- > src/qemu/qemu_domain.c | 8 > .../qemuxml2argv-usb-controller-xhci-limit.xml | 16 >

Re: [libvirt] [Xen-devel] [PATCH] libxl: fix dom0 autoballooning with Xen 4.8

2017-02-02 Thread Wei Liu
I saw this mail but didn't realise it required my input, sorry. On Wed, Feb 01, 2017 at 04:00:54PM -0700, Jim Fehlig wrote: > Jim Fehlig wrote: > > xen.git commit 57f8b13c changed several of the libxl memory > > get/set functions to take 64 bit parameters. The libvirt > > libxl driver still uses

[libvirt] [PATCH v2 2/3] cgroup: reuse virCgroupGetPercpuTime in virCgroupGetPercpuVcpuSum

2017-02-02 Thread Nikolay Shirokovskiy
--- src/util/vircgroup.c | 44 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index e4eaf32..06dd589 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -89,6 +89,10 @@ typedef

[libvirt] [PATCH v2 1/3] cgroup: extract interface part from virCgroupGetPercpuStats

2017-02-02 Thread Nikolay Shirokovskiy
virCgroupGetPercpuStats do 2 things. First it extracts per cpu stats from cgroups, second it puts stats values into virTypedParameterPtr in accordance with virDomainGetCPUStats interface. As we need first function in order to prodive per cpus stats in virConnectGetAllDomainStats lets split these

[libvirt] [PATCH v2 0/3] add per cpu stats to all domain stats

2017-02-02 Thread Nikolay Shirokovskiy
Info provided in virDomainGetCPUStats is currently missed in all domain stats. This patch removes this discrepancy. You may need not yet merged patch 'qemu: fix crash on getting block stats for empty cdrom' to test this series. diff from v1: 1. reuse code (patches 1, 2) 2.

[libvirt] [PATCH v2 3/3] add per cpu stats to all domain stats

2017-02-02 Thread Nikolay Shirokovskiy
Add per host cpu info provided in virDomainGetCPUStats to the stats provided in virConnectGetAllDomainStats. Namely: "cpu.count" - number of host cpus "cpu..time" - total cpu time spent for this domain in nanoseconds "cpu..vtime" - time spent in virtual cpu threads for this domain

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 10:58:50AM +0100, Peter Krempa wrote: > On Wed, Feb 01, 2017 at 18:11:28 +, Daniel Berrange wrote: > > On Wed, Feb 01, 2017 at 07:04:54PM +0100, Peter Krempa wrote: > > > On Wed, Feb 01, 2017 at 16:54:01 +, Daniel Berrange wrote: > > > > The virtlockd daemon has

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-02 Thread Peter Krempa
On Wed, Feb 01, 2017 at 18:11:28 +, Daniel Berrange wrote: > On Wed, Feb 01, 2017 at 07:04:54PM +0100, Peter Krempa wrote: > > On Wed, Feb 01, 2017 at 16:54:01 +, Daniel Berrange wrote: > > > The virtlockd daemon has existed for years now, but we have never > > > turned it on by default,

[libvirt] [PATCH] Fix indentation in datatypes.h

2017-02-02 Thread Nitesh Konkar
Signed-off-by: Nitesh Konkar --- src/datatypes.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/datatypes.h b/src/datatypes.h index 5830482..d525835 100644 --- a/src/datatypes.h +++ b/src/datatypes.h @@ -696,11 +696,11 @@