Re: [libvirt] [RFC PATCH v2 14.5/18] qemu: Bump the memory locking limit for mdevs as well

2017-02-16 Thread Erik Skultety
> > Nice! For series: > > > > Tested-by: Alex Williamson > > > > (with KVMGT vGPU mdev) > Thank you very much for the effort Alex. Given its current state, I'm glad KVMGT was testable with my patches :). > Nit, if I configure a VM for an invalid mdev uuid, I get

Re: [libvirt] [PATCH resend v2 0/2] Allow saving QEMU libvirt state to a pipe

2017-02-16 Thread Chen Hanxiao
At 2017-02-03 16:23:52, "Chen Hanxiao" wrote: >This series introduce flag VIR_DOMAIN_SAVE_DIRECT >to enable command 'save' to write to PIPE. > >Base upon patches from Roy Keene >with some fixes. > >Change from original patch: >1) Check whether the

Re: [libvirt] [PATCH] qemu_capabilities: introduce QEMU_CAPS_SD_CARD to probe sd-card drivers

2017-02-16 Thread Chen Hanxiao
At 2017-02-13 09:53:44, "Chen Hanxiao" wrote: >At 2017-02-07 16:31:20, "Chen Hanxiao" wrote: >>From: Chen Hanxiao >> >>This patch introduces QEMU_CAPS_SD_CARD for probing >>whether qemu support SD card by: >> >>{"execute":

Re: [libvirt] [RFC PATCH v2 14.5/18] qemu: Bump the memory locking limit for mdevs as well

2017-02-16 Thread Alex Williamson
On Thu, 16 Feb 2017 11:04:39 -0700 Alex Williamson wrote: > On Thu, 16 Feb 2017 17:49:45 +0100 > Erik Skultety wrote: > > > Since mdevs are just another type of VFIO devices, we should increase > > the memory locking limit the same way we do for

Re: [libvirt] [RFC PATCH v2 14.5/18] qemu: Bump the memory locking limit for mdevs as well

2017-02-16 Thread Alex Williamson
On Thu, 16 Feb 2017 17:49:45 +0100 Erik Skultety wrote: > Since mdevs are just another type of VFIO devices, we should increase > the memory locking limit the same way we do for VFIO PCI devices. > > Signed-off-by: Erik Skultety > --- >

Re: [libvirt] [PATCH] libxl: fix coverity issues introduced by 6a95edf

2017-02-16 Thread John Ferlan
On 02/16/2017 11:43 AM, Joao Martins wrote: > As discussed here [0][1] Coverity reported two issues: > > - On libxlDomainMigrationPrepareTunnel3 @@mig will be leaked on failures > after sucessfull call libxlDomainMigrationPrepareAny hence we free it. > > Setting mig = NULL after @mig is

Re: [libvirt] [v7 01/10] Resctrl: Add some utils functions

2017-02-16 Thread Martin Kletzander
On Thu, Feb 16, 2017 at 05:35:12PM +0800, Eli Qiao wrote: This patch adds some utils struct and functions to expose resctrl information. One tiny nitpick, but it might actually help you as well. You can use -v7 parameter to git send-email or git format-patch to automatically add 'v7' to the

[libvirt] [RFC PATCH v2 14.5/18] qemu: Bump the memory locking limit for mdevs as well

2017-02-16 Thread Erik Skultety
Since mdevs are just another type of VFIO devices, we should increase the memory locking limit the same way we do for VFIO PCI devices. Signed-off-by: Erik Skultety --- src/qemu/qemu_domain.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH] libxl: fix coverity issues introduced by 6a95edf

2017-02-16 Thread Joao Martins
As discussed here [0][1] Coverity reported two issues: - On libxlDomainMigrationPrepareTunnel3 @@mig will be leaked on failures after sucessfull call libxlDomainMigrationPrepareAny hence we free it. Setting mig = NULL after @mig is assigned plus adding libxlMigrationCookieFree on error paths

Re: [libvirt] [PATCH] nodedev: Return the parent for a virNodeDevicePtr struct

2017-02-16 Thread Ján Tomko
On Thu, Feb 09, 2017 at 02:23:47PM -0500, John Ferlan wrote: On 02/09/2017 07:39 AM, Bjoern Walk wrote: [...] } diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6820298..8dd738b 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -5450,7

Re: [libvirt] ARMv7 guest PCI support broken in 3.0.0 onwards

2017-02-16 Thread Daniel P. Berrange
On Thu, Feb 16, 2017 at 04:58:52PM +0100, Andrea Bolognani wrote: > On Wed, 2017-02-15 at 09:24 +, Daniel P. Berrange wrote: > [...] > > $ virsh start f22-arm32 > > error: Failed to start domain f22-arm32 > > error: internal error: qemu unexpectedly closed the monitor: > >

Re: [libvirt] [PATCH v3 2/2] libxl: add tunnelled migration support

2017-02-16 Thread Joao Martins
On 02/16/2017 02:57 PM, John Ferlan wrote: > On 02/16/2017 09:26 AM, Joao Martins wrote: >> On 02/16/2017 11:47 AM, John Ferlan wrote: >>> FYI: Couple of Coverity issues resulted from these patches. >>> int +libxlDomainMigrationPrepareTunnel3(virConnectPtr dconn, +

Re: [libvirt] ARMv7 guest PCI support broken in 3.0.0 onwards

2017-02-16 Thread Andrea Bolognani
On Wed, 2017-02-15 at 09:24 +, Daniel P. Berrange wrote: [...] > $ virsh start f22-arm32 > error: Failed to start domain f22-arm32 > error: internal error: qemu unexpectedly closed the monitor: > 2017-02-15T09:24:03.967648Z qemu-system-arm: -device

Re: [libvirt] [PATCH v2 09/12] qemu: drop fetch flag in qemuDomainGetJobStatsInternal

2017-02-16 Thread Jiri Denemark
On Wed, Dec 28, 2016 at 17:39:18 +0300, Nikolay Shirokovskiy wrote: > Basically this optimization skips acquiring jobs condition > in case no job is running. But as we are going to add > mirroring statistics it is simplier to drop this optimization. This was actually an optimization for old QEMU

Re: [libvirt] [PATCH 05/15] test: Fix fchosttest resource leak

2017-02-16 Thread Pavel Hrdina
On Wed, Jan 25, 2017 at 03:27:31PM -0500, John Ferlan wrote: > Commit id '666bee3' made fabric_name optional; however, if fabric name > was present, then a leak would occur. > > Signed-off-by: John Ferlan > --- > tests/fchosttest.c | 7 +-- > 1 file changed, 5

Re: [libvirt] [PATCH] Revert "news: fix spelling of tunneled"

2017-02-16 Thread Jim Fehlig
On 02/16/2017 01:46 AM, Erik Skultety wrote: On Wed, Feb 15, 2017 at 07:53:40PM -0700, Jim Fehlig wrote: Use of 'tunnelled' is over 100x that of 'tunneled' throughout the code. Also, the commit providing this news item used 'tunnelled'. I don't think it matters at all, both should be

Re: [libvirt] [PATCH v2 10/12] qemu: split getting stats for migration and others

2017-02-16 Thread Jiri Denemark
On Wed, Dec 28, 2016 at 17:39:19 +0300, Nikolay Shirokovskiy wrote: > All domain jobs other than source migration have only one > state - active. Only elapsed time is available for such > jobs so let's make it more explicit. Also if in future there will > be more stats for such jobs we don't want

Re: [libvirt] [PATCH 04/15] tests: Create a more realistic vHBA

2017-02-16 Thread Pavel Hrdina
On Wed, Jan 25, 2017 at 03:27:30PM -0500, John Ferlan wrote: > Modify the code to react more like a real HBA -> vHBA creation. > > Currently the code would just modify the input XML definition to > set the name to a wwpn and then modify the scsi_host capability > entry for the defintion to change

Re: [libvirt] [PATCH v2 08/12] qemu: drop unused code in qemuDomainGetJobStatsInternal

2017-02-16 Thread Jiri Denemark
On Wed, Dec 28, 2016 at 17:39:17 +0300, Nikolay Shirokovskiy wrote: > Destination migration never fetch migration stats thus due This becomes true only after patch 10/12. > to the check above fetch flag can not be set. > --- > src/qemu/qemu_driver.c | 6 -- > 1 file changed, 6 deletions(-)

Re: [libvirt] [PATCH v2 07/12] qemu: simplify getting completed job stats

2017-02-16 Thread Jiri Denemark
On Wed, Dec 28, 2016 at 17:39:16 +0300, Nikolay Shirokovskiy wrote: > --- > src/qemu/qemu_driver.c | 26 -- > 1 file changed, 12 insertions(+), 14 deletions(-) ACK Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v2 06/12] qemu: drop fetch and update status functions

2017-02-16 Thread Jiri Denemark
On Wed, Dec 28, 2016 at 17:39:15 +0300, Nikolay Shirokovskiy wrote: > qemuMigrationFetchJobStatus is rather inconvinient. If we poll > stats for status only then we don't need to update elapsed time. > Next on some paths we use this function to get stats only we don't > what to unexpectedly update

Re: [libvirt] [PATCH v3 2/2] libxl: add tunnelled migration support

2017-02-16 Thread John Ferlan
On 02/16/2017 09:26 AM, Joao Martins wrote: > On 02/16/2017 11:47 AM, John Ferlan wrote: >> FYI: Couple of Coverity issues resulted from these patches. >> >>> int >>> +libxlDomainMigrationPrepareTunnel3(virConnectPtr dconn, >>> + virStreamPtr st, >>> +

[libvirt] [PATCH] libvirt-override: fix flags mutually exclusize

2017-02-16 Thread Jie Wang
Because of virDomainGetBlkioParameters is called in libvirt_virDomainSetBlkioParameters, it will result in the two flags 'VIR_DOMAIN_AFFECT_LIVE' and 'VIR_DOMAIN_AFFECT_CONFIG' are mutually exclusive in libvirt_virDomainSetBlkioParameters, it's unreasonable, So ues this patch to fix it.

Re: [libvirt] [PATCH v2 05/12] qemu: drop excessive zero-out in qemuMigrationFetchJobStatus

2017-02-16 Thread Jiri Denemark
On Wed, Dec 28, 2016 at 17:39:14 +0300, Nikolay Shirokovskiy wrote: > qemuMonitorGetMigrationStats will do it for us anyway. > --- > src/qemu/qemu_migration.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > index 05ff2a0..6ddc4bd

Re: [libvirt] [PATCH v2 04/12] qemu: drop QEMU_MIGRATION_COMPLETED_UPDATE_STATS

2017-02-16 Thread Jiri Denemark
On Wed, Dec 28, 2016 at 17:39:13 +0300, Nikolay Shirokovskiy wrote: > This way we get stats only in one place. The former code waits for > complete/postcopy status basically and don't need to mess with stats. > > The patch drops raising an error on stats updates failure. This > does not make much

Re: [libvirt] [PATCH 03/15] test: Add helper to create vHBA for testNodeDeviceCreateXML

2017-02-16 Thread Pavel Hrdina
On Wed, Jan 25, 2017 at 03:27:29PM -0500, John Ferlan wrote: > Rather than inline the dummy creation of a vHBA to add to the node > devices - create a helper to do that work. > > Also just tidy up a couple of things while at it... This is better to do in two patches, first one just moves things

Re: [libvirt] [PATCH] news: document libxl tunnelled migration support

2017-02-16 Thread Joao Martins
On 02/16/2017 01:24 AM, Jim Fehlig wrote: > On 02/15/2017 05:06 PM, Joao Martins wrote: >> On 02/15/2017 11:41 PM, Jim Fehlig wrote: >>> Joao Martins wrote: Signed-off-by: Joao Martins --- docs/news.xml | 10 ++ 1 file changed, 10

Re: [libvirt] [PATCH 5/5] qemu: add rendernode argument

2017-02-16 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 01:04:13AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a new attribute 'rendernode' to spice element. > > Give it to QEMU if qemu supports it (queued for 2.9). > > Signed-off-by: Marc-André Lureau

Re: [libvirt] [PATCH 4/5] nodedev: add drm capability

2017-02-16 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 01:04:12AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a new 'drm' capability for Direct Rendering Manager (DRM) devices, > providing device type information. > > Teach the udev backend to populate those

Re: [libvirt] [PATCH 3/5] nodedev: parse

2017-02-16 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 01:04:11AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This should have been added with c4a4603de (or 0bdefd9b04). Technically the node dev parser only needs to parse enough to deal with NPIV device creation -

Re: [libvirt] [PATCH 2/5] nodedev: add paths

2017-02-16 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 01:04:10AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add new top-level element, that list the associated > /dev files. Distinguish the main /dev name from symlinks with a 'type' > attribute of value 'dev' or

Re: [libvirt] [PATCH v2 03/12] qemu: introduce QEMU_DOMAIN_JOB_STATUS_POSTCOPY

2017-02-16 Thread Jiri Denemark
On Wed, Dec 28, 2016 at 17:39:12 +0300, Nikolay Shirokovskiy wrote: > Current code consults job.current->stats.status to check for postcopy > state. First it is more correct to check for both job.current->status > and job.current->stats.status.code because on some paths on failures > we change

Re: [libvirt] [PATCH v3 2/2] libxl: add tunnelled migration support

2017-02-16 Thread Joao Martins
On 02/16/2017 11:47 AM, John Ferlan wrote: > FYI: Couple of Coverity issues resulted from these patches. > >> int >> +libxlDomainMigrationPrepareTunnel3(virConnectPtr dconn, >> + virStreamPtr st, >> + virDomainDefPtr *def, >> +

Re: [libvirt] [PATCH 1/5] nodedev: fix extra space in dump

2017-02-16 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 01:04:09AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is a cosmetic change, shouldn't change XML parsing, and doesn't > break any test. > > Signed-off-by: Marc-André Lureau > ---

Re: [libvirt] [PATCH v2 02/12] qemu: introduce qemu domain job status

2017-02-16 Thread Jiri Denemark
On Wed, Dec 28, 2016 at 17:39:11 +0300, Nikolay Shirokovskiy wrote: > This patch simply switches code from using VIR_DOMAIN_JOB_* to > introduced QEMU_DOMAIN_JOB_STATUS_*. Later this gives us freedom > to introduce states for postcopy and mirroring phases. > --- > src/qemu/qemu_domain.c| 24

[libvirt] [PATCH 2/2] cputest: Add CPUID data for Haswell with TSX

2017-02-16 Thread Jiri Denemark
All existing Haswell CPUID data were gathered from CPUs with broken TSX. Let's add new data for Haswell with correct TSX implementation. Signed-off-by: Jiri Denemark --- tests/cputest.c| 1 + .../x86_64-cpuid-Xeon-E7-8890-guest.xml

[libvirt] [PATCH 1/2] cpu_x86: Disable TSX on broken models

2017-02-16 Thread Jiri Denemark
All Intel Haswell processors (except Xeon E7 v3 with stepping >= 4) have TSX disabled by microcode update. As not all CPUs are guaranteed to be patched with microcode updates we need to explicitly disable TSX on affected CPUs to avoid its accidental usage.

[libvirt] [PATCH 0/2] cpu_x86: Disable TSX on broken models

2017-02-16 Thread Jiri Denemark
This series applies on top of "qemu: Detect host CPU model by asking QEMU on x86_64". https://bugzilla.redhat.com/show_bug.cgi?id=1406791 Jiri Denemark (2): cpu_x86: Disable TSX on broken models cputest: Add CPUID data for Haswell with TSX src/cpu/cpu_x86.c

Re: [libvirt] [PATCH 02/15] test: Add new NPIV capable HBA and a vHBA

2017-02-16 Thread Pavel Hrdina
On Wed, Jan 25, 2017 at 03:27:28PM -0500, John Ferlan wrote: > Predefine a second NPIV capable HBA as well as a vHBA using the first > NPIV capable HBA. This will allow for a mechanism to perform more > realistic create vHBA testing. > > Signed-off-by: John Ferlan > --- >

Re: [libvirt] [PATCH 01/15] tests: Alter test_driver HBA name/data to be closer to reality

2017-02-16 Thread Pavel Hrdina
On Wed, Jan 25, 2017 at 03:27:27PM -0500, John Ferlan wrote: > Alter "test-scsi-host-vport" to be "scsi_host1" to match the real > environment. This is the vport capable HBA - IOW the NPIV device. > Add more fields to scsi_host1 as well. > > Alter the XML being used by the objecttest to create a

[libvirt] [PATCH] cputest: Fix name of the file removed by cpu-parse.sh

2017-02-16 Thread Jiri Denemark
We want to remove the file created by json <<<"$data" >$fname.json in case it was empty. Signed-off-by: Jiri Denemark --- tests/cputestdata/cpu-parse.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cputestdata/cpu-parse.sh

Re: [libvirt] [PATCH v2 01/12] qemu: qemuDomainJobInfoToParams drop unused code

2017-02-16 Thread Jiri Denemark
On Wed, Dec 28, 2016 at 17:39:10 +0300, Nikolay Shirokovskiy wrote: > qemu driver does not have VIR_DOMAIN_JOB_BOUNDED jobs. > --- > src/qemu/qemu_domain.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index acfa695..acc27d0

Re: [libvirt] [PATCH 7/9] perf: add page_faults_maj software perf event support

2017-02-16 Thread John Ferlan
On 02/16/2017 07:57 AM, Nitesh Konkar wrote: > > > On Mon, Feb 13, 2017 at 8:14 PM, John Ferlan > wrote: > > > > On 02/13/2017 01:49 AM, Nitesh Konkar wrote: > > > > > > > > On Fri, Feb 10, 2017 at 3:22 AM, John Ferlan

Re: [libvirt] [PATCH 7/9] perf: add page_faults_maj software perf event support

2017-02-16 Thread Nitesh Konkar
On Mon, Feb 13, 2017 at 8:14 PM, John Ferlan wrote: > > > On 02/13/2017 01:49 AM, Nitesh Konkar wrote: > > > > > > > > On Fri, Feb 10, 2017 at 3:22 AM, John Ferlan > > wrote: > > > > > > > > On 01/27/2017 06:01 AM, Nitesh

Re: [libvirt] [PATCH 7/7] qemu: Allow /dev/dri/render* for virgl domains

2017-02-16 Thread Marc-André Lureau
Hi On Fri, Feb 10, 2017 at 6:57 PM Michal Privoznik wrote: > When enabling virgl, qemu opens /dev/dri/render*. So far, we are > not allowing that in devices cgroup nor creating the file in > domain's namespace and thus requiring users to set the paths in > qemu.conf. This,

Re: [libvirt] [PATCH 6/7] qemuDomainGetHostdevPath: Report /dev/vfio/vfio less frequently

2017-02-16 Thread Marc-André Lureau
On Fri, Feb 10, 2017 at 6:57 PM Michal Privoznik wrote: > So far, qemuDomainGetHostdevPath has no knowledge of the reasong > reasong/reason > it is called and thus reports /dev/vfio/vfio for every VFIO > backed device. This is suboptimal, as we want it to: > > a) report

Re: [libvirt] [PATCH 5/7] qemuDomainGetHostdevPath: Create /dev/vfio/vfio iff needed

2017-02-16 Thread Marc-André Lureau
Hi On Fri, Feb 10, 2017 at 6:57 PM Michal Privoznik wrote: > So far, we are allowing /dev/vfio/vfio in the devices cgroup > unconditionally (and creating it in the namespace too). Even if > domain has no hostdev assignment configured. This is potential > security hole.

Re: [libvirt] [PATCH 4/7] qemuSetupHostdevCgroup: Use qemuDomainGetHostdevPath

2017-02-16 Thread Marc-André Lureau
Hi On Fri, Feb 10, 2017 at 6:57 PM Michal Privoznik wrote: > Since these two functions are nearly identical (with > qemuSetupHostdevCgroup actually calling virCgroupAllowDevicePath) > we can have one function call the other and thus de-duplicate > some code. > >

Re: [libvirt] [PATCH 3/7] qemu_cgroup: Kill qemuSetupHostSCSIVHostDeviceCgroup

2017-02-16 Thread Marc-André Lureau
Hi On Fri, Feb 10, 2017 at 6:57 PM Michal Privoznik wrote: > There's no need for this function. Currently it is passed as a > callback to virSCSIVHostDeviceFileIterate(). However, SCSI host > devices have just one file path. Therefore we can mimic approach > used in

Re: [libvirt] [PATCH 2/7] qemu_cgroup: Kill qemuSetupHostSCSIDeviceCgroup

2017-02-16 Thread Marc-André Lureau
On Fri, Feb 10, 2017 at 6:57 PM Michal Privoznik wrote: > There's no need for this function. Currently it is passed as a > callback to virSCSIDeviceFileIterate(). However, SCSI devices > have just one file path. Therefore we can mimic approach used in >

Re: [libvirt] [PATCH 1/7] qemu_cgroup: Kill qemuSetupHostUSBDeviceCgroup

2017-02-16 Thread Marc-André Lureau
Hi On Fri, Feb 10, 2017 at 6:57 PM Michal Privoznik wrote: > There's no need for this function. Currently it is passed as a > callback to virUSBDeviceFileIterate(). However, USB devices have > just one file path. Therefore we can mimic approach used in >

Re: [libvirt] [PATCH] nodedev: Return the parent for a virNodeDevicePtr struct

2017-02-16 Thread John Ferlan
ping - no ACK on the only comment... Tks - John On 02/08/2017 05:03 PM, John Ferlan wrote: > When the 'parent' was added to the virNodeDevicePtr structure > by commit id 'e8a4ea75a' the 'parent' field was not properly filled > in when a virGetNodeDevice call was made within driver/config code.

Re: [libvirt] [PATCH 00/15] Add more vHBA related tests and module-arize the code

2017-02-16 Thread John Ferlan
ping*2? These really aren't that difficult - there's test adjustments, code motion, function renames, and new tests. Tks - John On 02/07/2017 07:49 AM, John Ferlan wrote: > > ping? > > tks - > > John > > On 01/25/2017 03:27 PM, John Ferlan wrote: >> Don't be scared off by the quantity of

Re: [libvirt] [PATCH v3 2/2] libxl: add tunnelled migration support

2017-02-16 Thread John Ferlan
FYI: Couple of Coverity issues resulted from these patches. > int > +libxlDomainMigrationPrepareTunnel3(virConnectPtr dconn, > + virStreamPtr st, > + virDomainDefPtr *def, > + const char

Re: [libvirt] [PATCH v2] Ensure disk names follow the disk name regex

2017-02-16 Thread Nitesh Konkar
As we know that Libvirt translates a device name of the form (regex) /^[fhv]d[a-z]+[0-9]*$/ into the corresponding index (e.g. sda => 0, hdz => 25, vdaa => 26) such that any trailing string of digits is simply ignored. Thus disk names like vda2 after attaching vda1 will error out like this:

Re: [libvirt] [PATCH] Validate required CPU features even for host-passthrough

2017-02-16 Thread Jiri Denemark
On Mon, Jan 30, 2017 at 16:19:24 +0100, Ján Tomko wrote: > Commit adff345 allowed enabling features with -cpu host > without ajdusting the validity checks on domain startup > and migration. > --- > src/qemu/qemu_migration.c | 2 +- > src/qemu/qemu_process.c | 2 +- > 2 files changed, 2

Re: [libvirt] libvirt-php --with-php-config=/path/to/php is broken.

2017-02-16 Thread Michal Privoznik
On 02/10/2017 07:46 PM, Shaun Reitan wrote: > When running the following command I ended up getting errors that phpize > was missing. Trying to dig into this further i found that configure.ac > was just trying to run php-config without providing a path. The > following patch corrects the issue by

Re: [libvirt] [PATCH] qemu: Allow empty script path to

2017-02-16 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 02:49:48PM +0100, Michal Privoznik wrote: > Before 9c17d665fdc5f (v1.3.2 - I know, right?) it was possible to > have the following interface configuration: > > > > > > This resulted in -netdev tap,script=,.. Fortunately, qemu helped > us to get away with this

[libvirt] [v7 02/10] Resctrl: expose cache information to capabilities

2017-02-16 Thread Eli Qiao
This patch expose cache information to host's capabilites xml. For l3 cache allocation For l3 cache allocation supported cdp(seperate data/code): RFC on mailing list. https://www.redhat.com/archives/libvir-list/2017-January/msg00644.html

[libvirt] [v7 06/10] Resctrl: enable l3code/l3data

2017-02-16 Thread Eli Qiao
Enable l3code/l3data while doing cache tune. l3code/l3data should use a continus cbm in their seperated schemata and the cache size are shared between them, so we need to deal them differently with l3 cache. This should enable cdp feature while mounting /sys/fs/resctrl, eg: mount -t resctrl

[libvirt] [v7 09/10] Resctrl: concurrence support

2017-02-16 Thread Eli Qiao
The internal struct list domainall is a list which are resctral domain status shared by all VMs, especiall the default domain, each VM should access it concomitantly. Ues a mutex to control it. Each bank's cache_left field is also a global shared resource we need to be care, add a mutex for each

[libvirt] [v7 04/10] Resctrl: Add private interface to set cachebanks

2017-02-16 Thread Eli Qiao
virResCtrlSetCacheBanks: Set cache banks of a libvirt domain. It will create new resource domain under `/sys/fs/resctrl` and fill the schemata according the cache banks configration. virResCtrlUpdate: Update the schemata after libvirt domain destroy. Signed-off-by: Eli Qiao

[libvirt] [v7 03/10] Resctrl: Add new xml element to support cache tune

2017-02-16 Thread Eli Qiao
This patch adds new xml element to support cache tune as: ... ... id: any non-minus number host_id: reference of the host's cache banks id, it's from capabilities type: cache bank type size: should be multiples of the min_size of the bank on host. vcpus: cache allocation on vcpu set, if

[libvirt] [v7 05/10] Qemu: Set cache banks

2017-02-16 Thread Eli Qiao
Set cache banks while booting a new domain. Signed-off-by: Eli Qiao --- src/qemu/qemu_driver.c | 6 -- src/qemu/qemu_process.c | 53 + 2 files changed, 57 insertions(+), 2 deletions(-) diff --git

[libvirt] [v7 00/10] Support cache tune in libvirt

2017-02-16 Thread Eli Qiao
Addressed comment from v7 -> v6 Marcelo: * Fix flock usage while VM initialization. Addressed comment from v6 -> v5 Marcelo: * Support other APPs to operate /sys/fs/resctrl at same time Libvirt will scan /sys/fs/resctrl again before doing cache allocation. patch

[libvirt] [v7 07/10] Resctrl: Make sure l3data/l3code are pairs

2017-02-16 Thread Eli Qiao
l3data and l3code type of cache banks should be configured pairs. Signed-off-by: Eli Qiao --- src/conf/domain_conf.c | 19 +++ src/util/virresctrl.c | 1 - src/util/virresctrl.h | 2 ++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git

[libvirt] [v7 10/10] Resctrl: Scan resctrl before doing cache allocation

2017-02-16 Thread Eli Qiao
Other application may touch resctrl while libvirt's running, scan resctrl again before allocating cache information to the newly created VM. Signed-off-by: Eli Qiao --- src/util/virresctrl.c | 44 1 file changed, 44

[libvirt] [v7 01/10] Resctrl: Add some utils functions

2017-02-16 Thread Eli Qiao
This patch adds some utils struct and functions to expose resctrl information. virResCtrlAvailable: If resctrl interface exist on host virResCtrlGet: get specify type resource contral information virResCtrlInit: initialize resctrl struct from the host's sys fs. resctrlall[]: an array to maintain

[libvirt] [v7 08/10] Resctrl: Compatible mode for cdp enabled

2017-02-16 Thread Eli Qiao
This patch support l3 cache allocation compatible mode if cdp enabled on host. In this case l3code/l3data has same schemata. Signed-off-by: Eli Qiao --- src/conf/domain_conf.c | 15 +-- src/util/virresctrl.c | 10 ++ 2 files changed, 23

Re: [libvirt] [PATCH] news: add entries for libxl driver improvements and bug fixes

2017-02-16 Thread Erik Skultety
On Wed, Feb 15, 2017 at 09:31:57PM -0700, Jim Fehlig wrote: > Signed-off-by: Jim Fehlig > --- > > Since news changes are not candidates for backport I assume it is fine > to include recent libxl improvements and bug fixes in a single commit. > I can break this up if that

Re: [libvirt] [PATCH v2] Ensure disk names follow the disk name regex

2017-02-16 Thread Michal Privoznik
On 02/15/2017 12:14 PM, Nitesh Konkar wrote: > Currently disk names do not follow the > (regex) /^[fhv]d[a-z]+[0-9]*$/ completely > and hence one can assign disk names like > vd2 etc. This patch ensures that the > disk names follow the regex mentioned. > This patch also adds a testcase. > >

Re: [libvirt] [PATCH] Revert "news: fix spelling of tunneled"

2017-02-16 Thread Erik Skultety
On Wed, Feb 15, 2017 at 07:53:40PM -0700, Jim Fehlig wrote: > Use of 'tunnelled' is over 100x that of 'tunneled' throughout the > code. Also, the commit providing this news item used 'tunnelled'. > I don't think it matters at all, both should be grammatically correct, it's just a matter of