[libvirt] [PATCH 07/13] qemu: Move qemuDomainSecretChardevPrepare call

Move the call to inside the qemuDomainAddChardevTLSObjects in order to further converge the code. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git

[libvirt] [PATCH 01/13] qemu: Create #define for TLS configuration setup.

Create GET_CONFIG_TLS_CERT to set up the TLS for 'chardev' TLS setting. Soon to be reused. Signed-off-by: John Ferlan --- src/qemu/qemu_conf.c | 41 + 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_conf.c

[libvirt] [PATCH 12/13] qemu: Set up the migrate TLS objects for target

Support TLS for a migration is a multistep process. The target guest must be started using the "-object tls-creds-x509,endpoint=server,...". If that TLS object requires a passphrase an addition "-object security..." would also be created. The alias/id used for the TLS object is "objmigrate_tls0",

[libvirt] [PATCH 13/13] qemu: Set up the migration TLS objects for source

https://bugzilla.redhat.com/show_bug.cgi?id=1300769 Modify the Begin phase to add the checks to determine whether a migration wishes to use TLS and whether it's configured including adding the secret into the priv->migSecinfo for the source domain. Modify the Perform phase in qemuMigrationRun in

[libvirt] [PATCH 11/13] Add new migration flag VIR_MIGRATE_TLS

Signed-off-by: John Ferlan --- include/libvirt/libvirt-domain.h | 8 src/qemu/qemu_migration.h| 1 + tools/virsh-domain.c | 7 +++ 3 files changed, 16 insertions(+) diff --git a/include/libvirt/libvirt-domain.h

[libvirt] [PATCH 03/13] qemu: Rename qemuAliasTLSObjFromChardevAlias

It's not really 'Chardev' specific - we can reuse this for other objects. Signed-off-by: John Ferlan --- src/qemu/qemu_alias.c| 8 src/qemu/qemu_alias.h| 2 +- src/qemu/qemu_command.c | 4 ++-- src/qemu/qemu_hotplug.c | 6 +++---

[libvirt] [PATCH 05/13] qemu: Refactor hotplug to introduce qemuDomain{Add|Del}TLSObjects

Refactor the TLS object adding code to make two separate API's that will handle the add/remove of the "secret" and "tls-creds-x509" objects including the Enter/Exit monitor commands. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 169

[libvirt] [PATCH 09/13] qemu: Introduce qemuDomainGetTLSObjects

Split apart and rename qemuDomainGetChardevTLSObjects in order to make a more generic API that can create the TLS JSON prop objects (secret and tls-creds-x509) to be used to create the objects Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 55

[libvirt] [PATCH 00/13] Add TLS support for migration

Patches 1, 3 -> 9 are primarily quite a bit of code motion in order to allow reuse of the "core" of the chardev TLS code. Theoretically speaking of course, these patches should work - I don't have a TLS and migration environment to test with, so between following the qemu command model on

[libvirt] [PATCH 10/13] qemu: Add TLS params to _qemuMonitorMigrationParams

Add the fields to support setting tls-creds and tls-hostname during a migration (either source or target) Signed-off-by: John Ferlan --- src/qemu/qemu_monitor.c | 12 +--- src/qemu/qemu_monitor.h | 7 +++ src/qemu/qemu_monitor_json.c | 11 +++

[libvirt] [PATCH 04/13] qemu: Introduce qemuDomainSecretMigrate{Prepare|Destroy}

Introduce API's to Prepare/Destroy a qemuDomainSecretInfoPtr to be used with a migrate or nbd TLS object Signed-off-by: John Ferlan --- src/qemu/qemu_domain.c | 73 + src/qemu/qemu_domain.h | 88

[libvirt] [PATCH 02/13] conf: Introduce migrate_tls_x509_cert_dir

Add a new TLS X.509 certificate type - "migrate". This will handle the creation of a TLS certificate capability (and possibly repository) to be used for migrations. Similar to chardev's, credentials will be handled via a libvirt secrets. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 08/13] qemu: Move qemuDomainPrepareChardevSourceTLS call

Move the call to inside the qemuDomainAddChardevTLSObjects in order to further converge the code. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git

[libvirt] [PATCH 06/13] qemu: Refactor qemuDomainGetChardevTLSObjects to converge code

Create a qemuDomainAddChardevTLSObjects which will encapsulate the qemuDomainGetChardevTLSObjects and qemuDomainAddTLSObjects so that the callers don't need to worry about the props. Move the dev->type and haveTLS checks in to the Add function to avoid an unnecessary call to

Re: [libvirt] [PATCH v2 10/12] qemu: split getting stats for migration and others

On Fri, Feb 17, 2017 at 17:16:54 +0300, Nikolay Shirokovskiy wrote: > > > On 16.02.2017 18:47, Jiri Denemark wrote: > > On Wed, Dec 28, 2016 at 17:39:19 +0300, Nikolay Shirokovskiy wrote: > >> All domain jobs other than source migration have only one > >> state - active. Only elapsed time is

Re: [libvirt] [PATCH 09/15] util: Move scsi_host specific functions from virutil

On Wed, Jan 25, 2017 at 03:27:35PM -0500, John Ferlan wrote: > Create a virscsihost.c and place the functions there. That removes the > last #ifdef __linux__ from virutil.c. > > Take the opporunity to also change the function names and in one case > the parameters slightly > > Signed-off-by:

Re: [libvirt] [PATCH 07/15] util: Move/rename virStoragePoolGetVhbaSCSIHostParent to virvhba

On Fri, Feb 17, 2017 at 12:14:51PM -0500, John Ferlan wrote: > > > On 02/17/2017 11:41 AM, Pavel Hrdina wrote: > > On Wed, Jan 25, 2017 at 03:27:33PM -0500, John Ferlan wrote: > >> Move the function and rename to simply virVHBAGetParent > >> > >> Since I'm changing related code, rather than have

Re: [libvirt] [PATCH v2 08/12] qemu: drop unused code in qemuDomainGetJobStatsInternal

On Fri, Feb 17, 2017 at 17:06:17 +0300, Nikolay Shirokovskiy wrote: > > > On 16.02.2017 18:45, Jiri Denemark wrote: > > On Wed, Dec 28, 2016 at 17:39:17 +0300, Nikolay Shirokovskiy wrote: > >> Destination migration never fetch migration stats thus due > > > > This becomes true only after patch

Re: [libvirt] [PATCH 07/15] util: Move/rename virStoragePoolGetVhbaSCSIHostParent to virvhba

On 02/17/2017 11:41 AM, Pavel Hrdina wrote: > On Wed, Jan 25, 2017 at 03:27:33PM -0500, John Ferlan wrote: >> Move the function and rename to simply virVHBAGetParent >> >> Since I'm changing related code, rather than have a Vhba named function >> in storage_backend_scsi rename it to simply

Re: [libvirt] [PATCH 06/15] util: Create a new virvhba module and move/rename API's

On Fri, Feb 17, 2017 at 11:42:54AM -0500, John Ferlan wrote: > > > On 02/17/2017 11:00 AM, Pavel Hrdina wrote: > > On Wed, Jan 25, 2017 at 03:27:32PM -0500, John Ferlan wrote: > >> Rather than have them mixed in with the virutil apis, create a separate > >> virvhba.c module and move the vHBA

Re: [libvirt] [PATCH 08/15] util: Reduce complexity of virVHBAGetParent

On Wed, Jan 25, 2017 at 03:27:34PM -0500, John Ferlan wrote: > Rather that getting the XML, parsing it, and grabbing the parent name > field, just call the virNodeDeviceGetParent which is far more efficient. ACK, this is unrelated to this series so you can push it as a fix for the code in

Re: [libvirt] [PATCH 06/15] util: Create a new virvhba module and move/rename API's

On 02/17/2017 11:00 AM, Pavel Hrdina wrote: > On Wed, Jan 25, 2017 at 03:27:32PM -0500, John Ferlan wrote: >> Rather than have them mixed in with the virutil apis, create a separate >> virvhba.c module and move the vHBA related calls into there. Soon there >> will be more added. >> >> Also

Re: [libvirt] [PATCH 07/15] util: Move/rename virStoragePoolGetVhbaSCSIHostParent to virvhba

On Wed, Jan 25, 2017 at 03:27:33PM -0500, John Ferlan wrote: > Move the function and rename to simply virVHBAGetParent > > Since I'm changing related code, rather than have a Vhba named function > in storage_backend_scsi rename it to simply checkParent as it's already > within the scope of

Re: [libvirt] [PATCH v2 12/12] qemu: show disks stats for nbd migration

On Fri, Feb 17, 2017 at 17:30:27 +0300, Nikolay Shirokovskiy wrote: > On 17.02.2017 13:17, Jiri Denemark wrote: > > On Wed, Dec 28, 2016 at 17:39:21 +0300, Nikolay Shirokovskiy wrote: > >> There is no disks stats when migrating with VIR_MIGRATE_NON_SHARED_* > >> for qemu that supports nbd. The

Re: [libvirt] [PATCH] libvirt-override: fix flags mutually exclusize

On Fri, Feb 17, 2017 at 10:20:34AM -0600, Eric Blake wrote: > On 02/17/2017 08:26 AM, Daniel P. Berrange wrote: > > > It isn't that simple - this isn't a mere matter of checking data. The use > > of the getters during the setter method is a fundamental requirement. At > > the C layer we have many

Re: [libvirt] [PATCH] libvirt-override: fix flags mutually exclusize

On 02/17/2017 08:26 AM, Daniel P. Berrange wrote: > It isn't that simple - this isn't a mere matter of checking data. The use > of the getters during the setter method is a fundamental requirement. At > the C layer we have many distinct data types - eg int, unsigned int, > long long, unsigned

Re: [libvirt] [PATCH 06/15] util: Create a new virvhba module and move/rename API's

On Wed, Jan 25, 2017 at 03:27:32PM -0500, John Ferlan wrote: > Rather than have them mixed in with the virutil apis, create a separate > virvhba.c module and move the vHBA related calls into there. Soon there > will be more added. > > Also modify the names of the functions and some arguments to

Re: [libvirt] [PATCH 0/2] Add support for 'raw' block driver to Qemu JSON backend parsing code

Hi, gentle reminder. Thanks, Tomas On Mon, 13 Feb 2017 23:53:41 +0100 Tomáš Golembiovský wrote: > The raw driver is not very interesting on its own but it can be layered on top > of other block drivers. New parameters that allow using only part of the > underlying

[libvirt] [PATCH] news: add entries for recent nodedev driver improvements

Signed-off-by: Michal Privoznik --- docs/news.xml | 17 + 1 file changed, 17 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 54337f782..8d53e0797 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -63,6 +63,23 @@ other than what's

Re: [libvirt] [PATCH] nodedev: Introduce new drm cap

Hi - Original Message - > After 7f1bdec5fa0a0cd25 our nodedev driver is capable of > determining DRM devices (DRM stands for Direct Render Manager not > Digital rights management). There is still one bit missing > though: virConnectListAllNodeDevices() is capable of listing > either all

[libvirt] [PATCH] nodedev: Introduce new drm cap

After 7f1bdec5fa0a0cd25 our nodedev driver is capable of determining DRM devices (DRM stands for Direct Render Manager not Digital rights management). There is still one bit missing though: virConnectListAllNodeDevices() is capable of listing either all devices or just those with specified

Re: [libvirt] [PATCH] nodedev: Introduce new drm cap

On Fri, Feb 17, 2017 at 04:19:38PM +0100, Michal Privoznik wrote: > After 7f1bdec5fa0a0cd25 our nodedev driver is capable of > determining DRM devices (DRM stands for Direct Render Manager not > Digital rights management). There is still one bit missing > though: virConnectListAllNodeDevices() is

Re: [libvirt] [PATCH] libvirt-override: fix flags mutually exclusize

On Fri, Feb 17, 2017 at 02:26:21PM +, Daniel P. Berrange wrote: > On Fri, Feb 17, 2017 at 03:22:12PM +0100, Erik Skultety wrote: > > On Fri, Feb 17, 2017 at 07:19:25PM +0800, Jie Wang wrote: > > > > Just a nit that we tend to prefix the patch with [libvirt-python] instead of > > just

Re: [libvirt] ARMv7 guest PCI support broken in 3.0.0 onwards

On Thu, 2017-02-16 at 16:13 +, Daniel P. Berrange wrote: > > I'm asking because I've just spent some time trying to run > > ARM guests[1] on my laptop[2] and I can't reproduce the > > failure you're describing, so I need more information to > > try and narrow it down. >  > my favourite type of

Re: [libvirt] [PATCH 5/5] qemu: add rendernode argument

On 02/14/2017 10:04 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a new attribute 'rendernode' to spice element. > > Give it to QEMU if qemu supports it (queued for 2.9). > > Signed-off-by: Marc-André Lureau

[libvirt] [PATCH 04/13] conf: store iothreads in order by iothread_id

Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 46 -- .../qemuxml2argv-iothreads-ids-partial.args| 4 +- 2 files changed, 44 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH 08/13] qemu_process: remove unnecessary iothread check

The situation covered by the removed code will not ever happen. This code is called only while starting a new QEMU process where the capabilities where already checked and while attaching to existing QEMU process where we don't even detect the iothreads. Signed-off-by: Pavel Hrdina

[libvirt] [PATCH 05/13] conf: always display iothread ids in the XML

There was at first only iothreads element in the XML. Because iothreads are used by theirs ids we should always print them in the XML even if they are auto-generated. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 32

[libvirt] [PATCH 13/13] qemu_driver: move iothread duplicate check into one place

Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 7 --- src/qemu/qemu_driver.c | 29 ++--- 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a70084658a..8b4e54d574 100644

[libvirt] [PATCH 10/13] qemu_driver: always check whether iothread is used by disk or not

If virDomainDelIOThread API was called with VIR_DOMAIN_AFFECT_LIVE and VIR_DOMAIN_AFFECT_CONFIG and both XML were already a different it could result in removing iothread from config XML even if there was a disk using that iothread. Signed-off-by: Pavel Hrdina ---

[libvirt] [PATCH 06/13] qemu_driver: check invalid iothread_id before we do anything else

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_driver.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3f0237da48..189c10ead5 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH 11/13] qemu_driver: move iothread existence check into one place

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_driver.c | 32 +++- 1 file changed, 7 insertions(+), 25 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1a7cc12874..03fea2713d 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH 02/13] conf: remove redundant iothreads variable

Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 32 +--- src/conf/domain_conf.h | 1 - src/qemu/qemu_driver.c | 6 -- src/qemu/qemu_process.c | 1 - 4 files changed, 17 insertions(+), 23 deletions(-) diff --git

[libvirt] [PATCH 09/13] conf: move iothread XML validation from qemu_command

This will ensure that IOThreads are properly validated while a domain is defined. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 62 ++-- src/qemu/qemu_command.c | 96 - 2 files changed,

[libvirt] [PATCH 12/13] qemu_driver: check whether iothread is used by controller

This follows the same check for disk, because we cannot remove iothread if it's used by disk or by controller. It could lead to crashing QEMU. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_driver.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[libvirt] [PATCH 07/13] qemu_process: move capabilities check for iothreads

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c | 31 +-- src/qemu/qemu_process.c | 34 ++ 2 files changed, 39 insertions(+), 26 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c

[libvirt] [PATCH 03/13] conf: move iothread parse code into its own function

Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 93 ++ 1 file changed, 56 insertions(+), 37 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 71cd572a30..b303c3f46c 100644 ---

[libvirt] [PATCH 01/13] conf: fix indentation

Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1bc72a4e90..a179c1e278 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15538,7

[libvirt] [PATCH 00/13] iothread code cleanup

This is a preparation for implementation of recently added iothread polling feature into QEMU. Pavel Hrdina (13): conf: fix indentation conf: remove redundant iothreads variable conf: move iothread parse code into its own function conf: store iothreads in order by iothread_id conf:

Re: [libvirt] [RFC PATCH 00/10] introduce push backups

On 08.02.2017 17:52, Martin Kletzander wrote: > On Wed, Jan 18, 2017 at 01:21:48PM +0300, Nikolay Shirokovskiy wrote: >> By the way we came to agreement to create distinct API to support backup >> operations in [1] >> and there is a discussion of pull backup series in [2]. The latter is blocked

Re: [libvirt] [PATCH v2 12/12] qemu: show disks stats for nbd migration

On 17.02.2017 13:17, Jiri Denemark wrote: > On Wed, Dec 28, 2016 at 17:39:21 +0300, Nikolay Shirokovskiy wrote: >> There is no disks stats when migrating with VIR_MIGRATE_NON_SHARED_* >> for qemu that supports nbd. The reason is that disks are copied via disk >> mirroring >> and not in the

Re: [libvirt] [PATCH] libvirt-override: fix flags mutually exclusize

On Fri, Feb 17, 2017 at 03:22:12PM +0100, Erik Skultety wrote: > On Fri, Feb 17, 2017 at 07:19:25PM +0800, Jie Wang wrote: > > Just a nit that we tend to prefix the patch with [libvirt-python] instead of > just [libvirt] so it's absolutely clear which repository you're sending the > patch against

Re: [libvirt] [PATCH] libvirt-override: fix flags mutually exclusize

On Fri, Feb 17, 2017 at 07:19:25PM +0800, Jie Wang wrote: Just a nit that we tend to prefix the patch with [libvirt-python] instead of just [libvirt] so it's absolutely clear which repository you're sending the patch against and in this case it's a python bindings fix. > As

Re: [libvirt] [PATCH v2 10/12] qemu: split getting stats for migration and others

On 16.02.2017 18:47, Jiri Denemark wrote: > On Wed, Dec 28, 2016 at 17:39:19 +0300, Nikolay Shirokovskiy wrote: >> All domain jobs other than source migration have only one >> state - active. Only elapsed time is available for such >> jobs so let's make it more explicit. Also if in future there

[libvirt] [PATCH] nwfilter_gentech_driver: Fix indentation and typo

Signed-off-by: Nitesh Konkar --- src/nwfilter/nwfilter_gentech_driver.c | 4 ++-- src/nwfilter/nwfilter_gentech_driver.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c

Re: [libvirt] [PATCH v2 08/12] qemu: drop unused code in qemuDomainGetJobStatsInternal

On 16.02.2017 18:45, Jiri Denemark wrote: > On Wed, Dec 28, 2016 at 17:39:17 +0300, Nikolay Shirokovskiy wrote: >> Destination migration never fetch migration stats thus due > > This becomes true only after patch 10/12. > >> to the check above fetch flag can not be set. >> --- >>

Re: [libvirt] [v7 01/10] Resctrl: Add some utils functions

On Thu, Feb 16, 2017 at 06:03:50PM +0100, Martin Kletzander wrote: On Thu, Feb 16, 2017 at 05:35:12PM +0800, Eli Qiao wrote: This patch adds some utils struct and functions to expose resctrl information. One tiny nitpick, but it might actually help you as well. You can use -v7 parameter to

Re: [libvirt] [PATCH v2 06/12] qemu: drop fetch and update status functions

On 17.02.2017 11:23, Jiri Denemark wrote: > On Thu, Feb 16, 2017 at 16:15:02 +0100, Jiri Denemark wrote: >> On Wed, Dec 28, 2016 at 17:39:15 +0300, Nikolay Shirokovskiy wrote: >>> qemuMigrationFetchJobStatus is rather inconvinient. If we poll >>> stats for status only then we don't need to

Re: [libvirt] [PATCH v2 01/12] qemu: qemuDomainJobInfoToParams drop unused code

On 16.02.2017 16:07, Jiri Denemark wrote: > On Wed, Dec 28, 2016 at 17:39:10 +0300, Nikolay Shirokovskiy wrote: >> qemu driver does not have VIR_DOMAIN_JOB_BOUNDED jobs. >> --- >> src/qemu/qemu_domain.c | 6 -- >> 1 file changed, 6 deletions(-) >> >> diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH] libvirt-override: fix flags mutually exclusize

As virDomainGetBlkioParameters is called in libvirt_virDomainSetBlkioParameters, it will result in the two flags 'VIR_DOMAIN_AFFECT_LIVE' and 'VIR_DOMAIN_AFFECT_CONFIG' are mutually exclusive in libvirt_virDomainSetBlkioParameters, it's unreasonable, So ues this patch to fix it. Signed-off-by:

Re: [libvirt] [PATCH v2 12/12] qemu: show disks stats for nbd migration

On 17.02.2017 13:17, Jiri Denemark wrote: > On Wed, Dec 28, 2016 at 17:39:21 +0300, Nikolay Shirokovskiy wrote: >> There is no disks stats when migrating with VIR_MIGRATE_NON_SHARED_* >> for qemu that supports nbd. The reason is that disks are copied via disk >> mirroring >> and not in the

Re: [libvirt] [PATCH] cputest: Fix name of the file removed by cpu-parse.sh

On Fri, Feb 17, 2017 at 11:06:46 +0100, Erik Skultety wrote: > On Thu, Feb 16, 2017 at 02:46:04PM +0100, Jiri Denemark wrote: > > We want to remove the file created by > > > > json <<<"$data" >$fname.json > > > > in case it was empty. > > > > Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH v2 12/12] qemu: show disks stats for nbd migration

On Wed, Dec 28, 2016 at 17:39:21 +0300, Nikolay Shirokovskiy wrote: > There is no disks stats when migrating with VIR_MIGRATE_NON_SHARED_* > for qemu that supports nbd. The reason is that disks are copied via disk > mirroring > and not in the scope of migration job itself. Below > a couble of

Re: [libvirt] [PATCH] cputest: Fix name of the file removed by cpu-parse.sh

On Thu, Feb 16, 2017 at 02:46:04PM +0100, Jiri Denemark wrote: > We want to remove the file created by > > json <<<"$data" >$fname.json > > in case it was empty. > > Signed-off-by: Jiri Denemark > --- > tests/cputestdata/cpu-parse.sh | 2 +- > 1 file changed, 1

Re: [libvirt] [PATCH v2 06/12] qemu: drop fetch and update status functions

On Thu, Feb 16, 2017 at 16:15:02 +0100, Jiri Denemark wrote: > On Wed, Dec 28, 2016 at 17:39:15 +0300, Nikolay Shirokovskiy wrote: > > qemuMigrationFetchJobStatus is rather inconvinient. If we poll > > stats for status only then we don't need to update elapsed time. > > Next on some paths we use

Re: [libvirt] [PATCH v2 11/12] qemu: introduce QEMU_DOMAIN_JOB_STATUS_PREPARE

On Wed, Dec 28, 2016 at 17:39:20 +0300, Nikolay Shirokovskiy wrote: > This patch removes the last place where we consult > priv->job.current->stats.status for migration state, namely > in qemuDomainGetMigrationJobStats. > --- > src/qemu/qemu_domain.c| 1 + > src/qemu/qemu_domain.h| 1 + >