Re: [libvirt] [Qemu-ppc] Proposal PCI/PCIe device placement on PAPR guests

On Thu, 23 Feb 2017 13:11:52 +1100 David Gibson wrote: > On Wed, Feb 22, 2017 at 12:08:25PM +0100, Greg Kurz wrote: > > David, > > > > I don't see the "spapr_pci: Allow PCI-Express devices" patch in your > > ppc-for-2.9 tree. Do you still consider merging it ? >

Re: [libvirt] [PATCH RESEND] qdev: Make "hotplugged" property read-only

On Wed, Feb 22, 2017 at 04:43:37PM -0600, Eric Blake wrote: > On 02/22/2017 01:26 PM, Eduardo Habkost wrote: > > The "hotplugged" property is user visible, but it was never meant > > to be set by the user. There are probably multiple ways to break > > or crash device code by overriding the

Re: [libvirt] [Qemu-ppc] Proposal PCI/PCIe device placement on PAPR guests

On Wed, Feb 22, 2017 at 12:08:25PM +0100, Greg Kurz wrote: > David, > > I don't see the "spapr_pci: Allow PCI-Express devices" patch in your > ppc-for-2.9 tree. Do you still consider merging it ? No. After discussions with Marcel Apfelbaum and others I'm looking at a different approach for PCIe

Re: [libvirt] [PATCH RESEND] qdev: Make "hotplugged" property read-only

On 02/22/2017 01:26 PM, Eduardo Habkost wrote: > The "hotplugged" property is user visible, but it was never meant > to be set by the user. There are probably multiple ways to break > or crash device code by overriding the property. For example, we > recently fixed a crash in rtc_set_memory()

[libvirt] [PATCH v2 2/3] i386/kvm: Blacklist TSX on known broken hosts

Some Intel CPUs are known to have a broken TSX implementation. A microcode update from Intel disabled TSX on those CPUs, but GET_SUPPORTED_CPUID might be reporting it as supported if the hosts were not updated yet. Manually fixup the GET_SUPPORTED_CPUID data to ensure we will never enable TSX

[libvirt] [PATCH v2 3/3] i386: Change stepping of Haswell to non-blacklisted value

glibc blacklists TSX on Haswell CPUs with model==60 and stepping < 4. To make the Haswell CPU model more useful, make those guests actually use TSX by changing CPU stepping to 4. References: * glibc commit 2702856bf45c82cf8e69f2064f5aa15c0ceb6359

[libvirt] [PATCH v2 0/3] Use non-blacklisted family/model/stepping for Haswell CPU model

Changes v1 -> v2: * Coding style fixes * Make series simpler: * Don't use trick: char vendor[static (CPUID_VENDOR_SZ + 1)] because it confuses checkpatch.pl * Removed patch "Add explicit array size to x86_cpu_vendor_words2str()" * Rebased on top of my x86-next branch:

[libvirt] [PATCH v2 1/3] i386: host_vendor_fms() helper function

Helper function for code that needs to check the host CPU vendor/family/model/stepping values. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Coding style fix (split long lines) --- target/i386/cpu.h | 1 + target/i386/cpu.c | 29 + 2

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

On 02/22/2017 01:44 PM, Laine Stump wrote: > On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: >> One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags >> was missing a break that could result it in falling through to >> an incorrect codepath. > > Actually that's not true. Every

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

On 02/22/2017 11:52 AM, Daniel P. Berrange wrote: > One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags > was missing a break that could result it in falling through to > an incorrect codepath. > > Signed-off-by: Daniel P. Berrange > --- >

Re: [libvirt] [PATCH 4/4] Add ATTRIBUTE_FALLTHROUGH for switch cases without break

On 02/22/2017 11:52 AM, Daniel P. Berrange wrote: > In GCC 7 there is a new warning triggered when a switch > case has a conditional statement (eg if ... else...) and > some of the code paths fallthrough to the next switch > statement. e.g. > > conf/domain_conf.c: In function

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

On Wed, Feb 22, 2017 at 02:44:01PM -0500, Laine Stump wrote: On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags was missing a break that could result it in falling through to an incorrect codepath. Actually that's not true.

Re: [libvirt] [PATCH 1/4] Use explicit boolean comparison in OOM check

On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: GCC 7 gets upset by if (!tmp && (size * count)) warning util/viralloc.c: In function 'virReallocN': util/viralloc.c:246:23: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context] if (!tmp && (size *

Re: [libvirt] [PATCH 4/4] Add ATTRIBUTE_FALLTHROUGH for switch cases without break

On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: In GCC 7 there is a new warning triggered when a switch case has a conditional statement (eg if ... else...) and some of the code paths fallthrough to the next switch statement. e.g. conf/domain_conf.c: In function 'virDomainChrEquals':

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags was missing a break that could result it in falling through to an incorrect codepath. Actually that's not true. Every codepath of the preceding case ends with a "return blah".

[libvirt] [PATCH RESEND] qdev: Make "hotplugged" property read-only

The "hotplugged" property is user visible, but it was never meant to be set by the user. There are probably multiple ways to break or crash device code by overriding the property. For example, we recently fixed a crash in rtc_set_memory() related to the property (commit

Re: [libvirt] [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

On Tue, Jan 03, 2017 at 03:06:02PM -0200, Eduardo Habkost wrote: > (CCing libvir-list and Laine) > > On Tue, Jan 03, 2017 at 05:53:27PM +0100, Igor Mammedov wrote: > > On Tue, 3 Jan 2017 17:10:15 +0100 > > Paolo Bonzini wrote: > > > > > > > > > > > On 03/01/2017 15:22,

[libvirt] [PATCH v3 2/3] target-i386: Implement query-cpu-model-expansion QMP command

Implement query-cpu-model-expansion for target-i386. This should meet all the requirements while being simple. In the case of static expansion, it will use the new "base" CPU model, and in the case of full expansion, it will keep the original CPU model name+props, and append extra properties. A

[libvirt] [PATCH v3 0/3] target-i386: Implement query-cpu-model-expansion

This series implements query-cpu-model-expansion on target-i386. Changes v2 -> v3: - * Rebased on top of my x86-next branch: https://github.com/ehabkost/qemu x86-next * Added new patch that will extend type=full expansion to return every (writeable) QOM property from the CPU

Re: [libvirt] [PATCH 2/4] libxl: fix empty string check for channel path

On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: The libxl code was checking that a 'char *' was != '\0', instead of checking the first element in the string Signed-off-by: Daniel P. Berrange --- src/libxl/libxl_domain.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [libvirt] [PATCH 6/6] tests: Reduce QEMU_CAPS_DEVICE_{DMI_TO_, }PCI_BRIDGE usage

On 02/22/2017 12:53 PM, Andrea Bolognani wrote: On Wed, 2017-02-22 at 09:58 -0500, Laine Stump wrote: On 02/21/2017 02:57 PM, Andrea Bolognani wrote: Now that QEMU_CAPS_DEVICE_PCI_BRIDGE is no longer checked unless a pci-bridge is really part of the configuration, and most uses of the

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

On Wed, 2017-02-22 at 17:52 +, Daniel P. Berrange wrote: > @@ -553,6 +553,7 @@ > qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDefPtr dev, >  return pciFlags; >  } >  } > +break; >   >  case VIR_DOMAIN_DEVICE_FS: >  /* the only type of

Re: [libvirt] [PATCH 4/4] Add ATTRIBUTE_FALLTHROUGH for switch cases without break

On Wed, Feb 22, 2017 at 05:52:05PM +, Daniel P. Berrange wrote: > In GCC 7 there is a new warning triggered when a switch > case has a conditional statement (eg if ... else...) and > some of the code paths fallthrough to the next switch > statement. e.g. > > conf/domain_conf.c: In function

Re: [libvirt] [PATCH 6/6] tests: Reduce QEMU_CAPS_DEVICE_{DMI_TO_, }PCI_BRIDGE usage

On Wed, 2017-02-22 at 09:58 -0500, Laine Stump wrote: > On 02/21/2017 02:57 PM, Andrea Bolognani wrote: > >  > > Now that QEMU_CAPS_DEVICE_PCI_BRIDGE is no longer checked > > unless a pci-bridge is really part of the configuration, > > and most uses of the legacy PCI controller combo have been > >

[libvirt] [PATCH 2/4] libxl: fix empty string check for channel path

The libxl code was checking that a 'char *' was != '\0', instead of checking the first element in the string Signed-off-by: Daniel P. Berrange --- src/libxl/libxl_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_domain.c

[libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags was missing a break that could result it in falling through to an incorrect codepath. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_domain_address.c | 1 + 1 file changed, 1 insertion(+) diff --git

[libvirt] [PATCH 1/4] Use explicit boolean comparison in OOM check

GCC 7 gets upset by if (!tmp && (size * count)) warning util/viralloc.c: In function 'virReallocN': util/viralloc.c:246:23: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context] if (!tmp && (size * count)) { ~~^~~~ Keep it happy

[libvirt] [PATCH 0/4] Fix build with GCC 7

As always with new GCC major releases, we've tickled some new warnings. What's nice is that two of them identified genuine bugs in our code. I would push this as a build-breaker fix, but I wanted some visibility on the fourth patch before doing that, as it was not the usual type of quick fix.

[libvirt] [PATCH 4/4] Add ATTRIBUTE_FALLTHROUGH for switch cases without break

In GCC 7 there is a new warning triggered when a switch case has a conditional statement (eg if ... else...) and some of the code paths fallthrough to the next switch statement. e.g. conf/domain_conf.c: In function 'virDomainChrEquals': conf/domain_conf.c:14926:12: error: this statement may fall

[libvirt] [PATCH] test: fix pcie-root-port-too-many test

While reviewing a patch from Andrea that modified this test case, I realized that although it was "properly failing" (it's a negative test), that it was failing for the wrong reason (the MULTIFUNCTION cap wasn't set in the test case, so it was saying that multifunction=on wasn't supported by the

Re: [libvirt] [PATCH 4/6] tests: Reduce usage of legacy PCI controllers on PCIe machines

On 02/21/2017 02:57 PM, Andrea Bolognani wrote: Up until a while ago, libvirt would automatically add a legacy PCI controllers combo (dmi-to-pci-bridge + pci-bridge) to any PCIe machine type (x86_64/q35 and aarch64/virt). As a result, a number of input and output files in the test suite ended

Re: [libvirt] [PATCH v2 11/33] qemu: Store more types in qemuMonitorCPUModelInfo

On Tue, Feb 21, 2017 at 09:27:45 -0500, John Ferlan wrote: > > > On 02/15/2017 11:44 AM, Jiri Denemark wrote: > > While query-cpu-model-expansion returns only boolean features on s390, > > but x86_64 reports some integer and string properties which we are > > interested in. > > > >

[libvirt] [PATCH] qemu_cgroup: Only try to allow devices if devices CGroup's available

When a domain needs an access to some device (be it a disk, RNG, chardev, whatever), we have to allow it in the devices CGroup (if it is available), because by default we disallow all the devices. But some of the functions that are responsible for setting up devices CGroup are lacking check

Re: [libvirt] [PATCH] virsh: Alter formatting a bit for output of domstats fields

On 02/09/2017 05:02 PM, John Ferlan wrote: Alter the formatting of each line to not give the appearance of one long run-on sentance and to be consistent between the various elements of collected/displayed data. The formatting should fit within the 80 character display. This removes the need for

Re: [libvirt] [PATCH 3/6] conf: Make switch statements more strict

On Wed, 2017-02-22 at 09:40 -0500, Laine Stump wrote: [...] > >   virReportError(VIR_ERR_INTERNAL_ERROR, > > -   _("Invalid PCI controller model %d"), model); > > +   _("PCI controller model was not set correctly")); >  > You're going to need to

Re: [libvirt] [RFC PATCH v2 REBASE 17/18] docs: Document the new hostdev and address type 'mdev'

On Wed, Feb 22, 2017 at 08:20:06PM +0530, Kirti Wankhede wrote: > > > On 2/20/2017 7:58 PM, Erik Skultety wrote: > > Signed-off-by: Erik Skultety > > --- > > docs/formatdomain.html.in | 48 > > +++ > > 1 file changed, 44

Re: [libvirt] [PATCH 6/6] tests: Reduce QEMU_CAPS_DEVICE_{DMI_TO_, }PCI_BRIDGE usage

On 02/21/2017 02:57 PM, Andrea Bolognani wrote: Now that QEMU_CAPS_DEVICE_PCI_BRIDGE is no longer checked unless a pci-bridge is really part of the configuration, and most uses of the legacy PCI controller combo have been dropped from tests that use PCIe machine types, we can drop the

Re: [libvirt] [PATCH v2 10/33] qemu: Rename hostCPU/feature element in capabilities cache

On Tue, Feb 21, 2017 at 09:27:17 -0500, John Ferlan wrote: > > > On 02/15/2017 11:44 AM, Jiri Denemark wrote: > > The element will be generalized in the following commit. > > > > Signed-off-by: Jiri Denemark > > --- > > > > Notes: > > Version 2: > > - no change >

Re: [libvirt] [PATCH 5/6] qemu: Allow multiple bridges when pci-bridges is not available

On 02/21/2017 02:57 PM, Andrea Bolognani wrote: qemuDomainAssignPCIAddresses() hardcoded the assumption that the only way to support devices on a non-zero bus is to add one or more pci-bridges; however, since we now support a large selection of PCI controllers that can be used instead, the

Re: [libvirt] [RFC PATCH v2 REBASE 17/18] docs: Document the new hostdev and address type 'mdev'

On 2/20/2017 7:58 PM, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > docs/formatdomain.html.in | 48 > +++ > 1 file changed, 44 insertions(+), 4 deletions(-) > > diff --git a/docs/formatdomain.html.in

Re: [libvirt] [PATCH 3/6] conf: Make switch statements more strict

On 02/21/2017 02:57 PM, Andrea Bolognani wrote: When switching over the values in the virDomainControllerModelPCI enumeration, make sure the proper cast is in place so that the compiler can warn us when the coverage is not exaustive. For the same reason, remove the 'default' case from one of

Re: [libvirt] [RFC v2 0/2] vireventpoll implimentation using epoll

Ping. Also, noticed that I renamed patch series, old name was "Substitute poll by epoll in virEventPollRunOnce". My bad. /14/2017 9:04 PM, Derbyshev Dmitriy пишет: From: Derbyshev Dmitry Provides about 20% boost on local machine with 35 vms.

Re: [libvirt] [RFC] Substitute poll by epoll in virEventPollRunOnce

Hello, Daniel Could you check new version of this patch series? My bad, I renamed it to "vireventpoll implimentation using epoll". Sorry for that. Regards, Dmitry 2/10/2017 9:05 PM, Daniel P. Berrange пишет: On Fri, Feb 10, 2017 at 04:29:27PM +0300, Derbyshev Dmitriy wrote: From: Derbyshev

Re: [libvirt] [PATCH v2 1/4] docs: schema: Add basic documentation for the virtual crypto device support

On 01/11/2017 09:28 AM, Longpeng(Mike) wrote: This patch documents XML elements used for support of virtual crypto devices. In the devices section in the domain XML users may specify: to enable the crypto device for guests. Signed-off-by: Longpeng(Mike) ---

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On Wed, Feb 22, 2017 at 03:13:05PM +0100, Paolo Bonzini wrote: > > > On 22/02/2017 15:11, Daniel P. Berrange wrote: > > On Wed, Feb 22, 2017 at 03:10:00PM +0100, Paolo Bonzini wrote: > >> > >> > >> On 22/02/2017 14:46, Daniel P. Berrange wrote: > >>> On Wed, Feb 22, 2017 at 02:38:32PM +0100,

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On 22/02/2017 15:11, Daniel P. Berrange wrote: > On Wed, Feb 22, 2017 at 03:10:00PM +0100, Paolo Bonzini wrote: >> >> >> On 22/02/2017 14:46, Daniel P. Berrange wrote: >>> On Wed, Feb 22, 2017 at 02:38:32PM +0100, Paolo Bonzini wrote: On 22/02/2017 11:05, Daniel P. Berrange wrote:

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On Wed, Feb 22, 2017 at 03:10:00PM +0100, Paolo Bonzini wrote: > > > On 22/02/2017 14:46, Daniel P. Berrange wrote: > > On Wed, Feb 22, 2017 at 02:38:32PM +0100, Paolo Bonzini wrote: > >> > >> > >> On 22/02/2017 11:05, Daniel P. Berrange wrote: > >>> I'd also suggest just assigning the whole

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On 22/02/2017 14:46, Daniel P. Berrange wrote: > On Wed, Feb 22, 2017 at 02:38:32PM +0100, Paolo Bonzini wrote: >> >> >> On 22/02/2017 11:05, Daniel P. Berrange wrote: >>> I'd also suggest just assigning the whole vHBA >> >> What do you mean by "assigning the whole vHBA"? There is no concept of

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On Wed, Feb 22, 2017 at 02:38:32PM +0100, Paolo Bonzini wrote: > > > On 22/02/2017 11:05, Daniel P. Berrange wrote: > > I'd also suggest just assigning the whole vHBA > > What do you mean by "assigning the whole vHBA"? There is no concept of > a vHBA as e.g. a PCI virtual function. I thought

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On 22/02/2017 11:05, Daniel P. Berrange wrote: > I'd also suggest just assigning the whole vHBA What do you mean by "assigning the whole vHBA"? There is no concept of a vHBA as e.g. a PCI virtual function. > , but We can still make > it possible for a mgmt app to dynamically add/remove LUNS

Re: [libvirt] [PATCH v2 08/33] docs: Update description of the host-model CPU mode

On Tue, Feb 21, 2017 at 09:25:28 -0500, John Ferlan wrote: > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in > > index 294d3c467..9e7f7804e 100644 > > --- a/docs/formatdomain.html.in > > +++ b/docs/formatdomain.html.in > > @@ -1272,16 +1272,15 @@ > >model even if

Re: [libvirt] [PATCH 1/5] lib: Add API for specific vCPU hot(un)plug

On Wed, Feb 22, 2017 at 12:55:21 +, Daniel Berrange wrote: > On Wed, Feb 22, 2017 at 01:34:54PM +0100, Peter Krempa wrote: > > On Wed, Feb 22, 2017 at 12:16:51 +, Daniel Berrange wrote: > > > On Fri, Feb 10, 2017 at 06:10:18PM +0100, Peter Krempa wrote: > > > > Similarly to

Re: [libvirt] [PATCH v2 00/33] qemu: Detect host CPU model by asking QEMU on x86_64

On Wed, Feb 15, 2017 at 05:44:34PM +0100, Jiri Denemark wrote: > Until now host-model CPU mode tried to enable all CPU features supported > by the host CPU even if QEMU/KVM did not support them. This caused a > number of issues and made host-model quite unreliable. Asking QEMU for > the CPU it can

Re: [libvirt] [PATCH 1/5] lib: Add API for specific vCPU hot(un)plug

On Wed, Feb 22, 2017 at 01:34:54PM +0100, Peter Krempa wrote: > On Wed, Feb 22, 2017 at 12:16:51 +, Daniel Berrange wrote: > > On Fri, Feb 10, 2017 at 06:10:18PM +0100, Peter Krempa wrote: > > > Similarly to domainSetGuestVcpus this commit adds API which allows to > > > modify state of

Re: [libvirt] [PATCH v2 07/33] qemu: Fix CPU model fallback in domain capabilities

On Tue, Feb 21, 2017 at 09:25:20 -0500, John Ferlan wrote: > > > On 02/15/2017 11:44 AM, Jiri Denemark wrote: > > Our documentation of the domain capabilities XML says that the fallback > > attribute of a CPU model is used to indicate whether the CPU model was > > detected by libvirt itself

Re: [libvirt] [PATCH v2 05/33] qemu: Refactor virQEMUCapsInitHostCPUModel

On Tue, Feb 21, 2017 at 09:24:13 -0500, John Ferlan wrote: > > > On 02/15/2017 11:44 AM, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > > > Notes: > > Version 2: > > - no change > > > > src/qemu/qemu_capabilities.c | 109 > >

Re: [libvirt] [PATCH 1/5] lib: Add API for specific vCPU hot(un)plug

On Wed, Feb 22, 2017 at 12:16:51 +, Daniel Berrange wrote: > On Fri, Feb 10, 2017 at 06:10:18PM +0100, Peter Krempa wrote: > > Similarly to domainSetGuestVcpus this commit adds API which allows to > > modify state of individual vcpus rather than just setting the count. > > > > This allows to

Re: [libvirt] [PATCH 1/5] lib: Add API for specific vCPU hot(un)plug

On Fri, Feb 10, 2017 at 06:10:18PM +0100, Peter Krempa wrote: > Similarly to domainSetGuestVcpus this commit adds API which allows to > modify state of individual vcpus rather than just setting the count. > > This allows to enable CPUs in specific guest NUMA nodes to achieve any > necessary

Re: [libvirt] [PATCH v2 04/33] domaincapstest: Add test data for QEMU 2.9.0

On 02/22/2017 04:06 AM, Jiri Denemark wrote: > On Tue, Feb 21, 2017 at 09:23:34 -0500, John Ferlan wrote: >> >> >> On 02/15/2017 11:44 AM, Jiri Denemark wrote: >>> Signed-off-by: Jiri Denemark >>> --- >>> >>> Notes: >>> Version 2: >>> - no change >>> >>>

Re: [libvirt] [libvirt-users] Determining domain job kind from job stats?

On Tue, Feb 21, 2017 at 15:38:22 +0100, Milan Zamazal wrote: > [Starting to move to the development list.] > > Milan Zamazal writes: > > > Jiri Denemark writes: > > > >> On Fri, Feb 17, 2017 at 12:38:24 +0100, Milan Zamazal wrote: > >>> > >>> There

Re: [libvirt] [PATCH v2 21/33] cpu: Use virCPUData.arch in cpuDecode

On Tue, Feb 21, 2017 at 22:24:34 -0500, John Ferlan wrote: > > > On 02/15/2017 11:44 AM, Jiri Denemark wrote: > > virCPUDef.arch is not required to be filled in for guest CPU > > definitions. It doesn't make sense to artificially mandate it to be set > > when cpuDecode is called especially when

Re: [libvirt] [PATCH v2 13/33] cpu: Introduce virCPUDataNew

On Tue, Feb 21, 2017 at 14:32:09 -0500, John Ferlan wrote: > > > On 02/15/2017 11:44 AM, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > > > Notes: > > Version 2: > > - no change > > > > src/cpu/cpu.c| 19 +++ > >

Re: [libvirt] [PATCH v2 09/33] qemu: Introduce virQEMUCapsFormatHostCPUModelInfo

On Tue, Feb 21, 2017 at 09:25:38 -0500, John Ferlan wrote: > > > On 02/15/2017 11:44 AM, Jiri Denemark wrote: > > The CPU model info formating code in virQEMUCapsFormatCache will get > > more complicated soon. Separating the code in > > virQEMUCapsFormatHostCPUModelInfo will make the result

Re: [libvirt] [PATCH v2 02/33] docs: Fix since statement in host-model documentation

On Tue, Feb 21, 2017 at 09:20:02 -0500, John Ferlan wrote: > > > On 02/15/2017 11:44 AM, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > > > Notes: > > Version 2: > > - no change > > > > docs/formatdomain.html.in | 2 +- > > 1 file changed, 1

Re: [libvirt] [PATCH v2 06/33] qemu: Skip virQEMUCapsCPUFilterFeatures on non-x86 CPUs

On Tue, Feb 21, 2017 at 09:24:33 -0500, John Ferlan wrote: > > > On 02/15/2017 11:44 AM, Jiri Denemark wrote: > > All features the function is currently supposed to filter out are > > specific to x86_64. We should avoid removing them on other > > architectures. It seems to be quite unlikely

Re: [libvirt] [PATCH v2 01/33] docs: Drop obsolete statement about CPU modes and migration

On Tue, Feb 21, 2017 at 09:19:54 -0500, John Ferlan wrote: > > > On 02/15/2017 11:44 AM, Jiri Denemark wrote: > > The guest CPU definition has always been updated automatically during > > migration. And currently we just transform any host-model CPU into a > > custom one when a domain starts. >

Re: [libvirt] [Qemu-ppc] Proposal PCI/PCIe device placement on PAPR guests

David, I don't see the "spapr_pci: Allow PCI-Express devices" patch in your ppc-for-2.9 tree. Do you still consider merging it ? Cheers. -- Greg On Fri, 13 Jan 2017 09:58:28 +0100 Greg Kurz wrote: > On Fri, 13 Jan 2017 15:48:31 +1100 > David Gibson

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On Tue, Feb 21, 2017 at 10:45:05PM -0500, John Ferlan wrote: > > > On 02/21/2017 12:03 PM, Daniel P. Berrange wrote: > > On Tue, Feb 21, 2017 at 11:33:25AM -0500, John Ferlan wrote: > >> Repost: > >> http://www.redhat.com/archives/libvir-list/2017-February/msg00501.html > >> > >> to update to

Re: [libvirt] [PATCH] conf: Allow omitting of numa node memory size

On Wed, Feb 22, 2017 at 10:04:08AM +0100, Peter Krempa wrote: > On Tue, Feb 21, 2017 at 15:36:23 +, Daniel Berrange wrote: > > On Tue, Feb 21, 2017 at 04:22:05PM +0100, Peter Krempa wrote: > > > Memory-less numa nodes could be specified by setting the memory size to > > > 0. Allow ommiting of

Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

On Wed, Feb 22, 2017 at 10:34:12 +0100, Peter Krempa wrote: > On Mon, Feb 13, 2017 at 23:53:43 +0100, Tomáš Golembiovský wrote: > > The 'raw' block driver in Qemu is not directly interesting from > > libvirt's perspective, but it can be layered above some other block > > drivers and this may be

Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

On Mon, Feb 13, 2017 at 23:53:43 +0100, Tomáš Golembiovský wrote: > The 'raw' block driver in Qemu is not directly interesting from > libvirt's perspective, but it can be layered above some other block > drivers and this may be interesting for the user. > > The patch adds support for the 'raw'

Re: [libvirt] [PATCH 2/6] qemu: Make switch statements more strict

On Tue, 2017-02-21 at 15:26 -0500, Laine Stump wrote: > > @@ -2664,19 +2664,13 @@ qemuBuildControllerDevStr(const virDomainDef > > *domainDef, > >   break; > >    > >   case VIR_DOMAIN_CONTROLLER_TYPE_PCI: > > -if (def->model == VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT || > > -

Re: [libvirt] [PATCH 1/2] util: storage: split function for JSON backing volume parsing in two

On Mon, Feb 13, 2017 at 23:53:42 +0100, Tomáš Golembiovský wrote: > Split virStorageSourceParseBackingJSON into two functions so that the > core can be reused by other functions. The new function called > virStorageSourceParseBackingJSONInternal accepts virJSONValuePtr. > > Signed-off-by: Tomáš

Re: [libvirt] [PATCH v2 04/33] domaincapstest: Add test data for QEMU 2.9.0

On Tue, Feb 21, 2017 at 09:23:34 -0500, John Ferlan wrote: > > > On 02/15/2017 11:44 AM, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > > > Notes: > > Version 2: > > - no change > > > > .../domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml | 116

Re: [libvirt] [PATCH] conf: Allow omitting of numa node memory size

On Tue, Feb 21, 2017 at 15:36:23 +, Daniel Berrange wrote: > On Tue, Feb 21, 2017 at 04:22:05PM +0100, Peter Krempa wrote: > > Memory-less numa nodes could be specified by setting the memory size to > > 0. Allow ommiting of the parameter completely to specify the same. > > > > Partially

Re: [libvirt] [PATCH 13/13] qemu: Set up the migration TLS objects for source

On Tue, Feb 21, 2017 at 22:47:38 +0100, Jiri Denemark wrote: > On Fri, Feb 17, 2017 at 14:39:30 -0500, John Ferlan wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1300769 > > > > Modify the Begin phase to add the checks to determine whether a migration > > wishes to use TLS and whether