[libvirt] A question for external snapshots with flag“VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE”

Hello, I got a question here. When we create consistent active external snapshots with flag “VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE” , the qemuDomainSnapshotFSFreeze will be called firstly to freeze all filesystems in vm, and then create snapshots. For windows vm, freezing filesystems used by vss

Re: [libvirt] [PATCH v2 1/2] tests: Sync tests between qemuxml2argv and qemuxml2xml

+42 for doing this :-) ACK to the patch, because I don't have the intestinal fortitude to connect reconcile single change, but I'm assuming you had some methodology to the way that you added/removed things (and I'd like to subscribe to your newsletter on the topic). (Seriously, I tried

[libvirt] [PATCH] Add aarch64 to virArch

Signed-off-by: Matwey V. Kornilov --- src/lxc/lxc_container.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 99bd7e9..95c0cfc 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -2285,6

[libvirt] [PATCH] Add aarch64 to virArch

Hello, This patch is for allowing 32-bit ARMs for aarch64 hosts. Exact 32-bit personality for aarch64 is aarch32, but there is no such arch in libvirt, so we use arvm7l instead. Matwey V. Kornilov (1): Add aarch64 to virArch src/lxc/lxc_container.c | 2 ++ 1 file changed, 2 insertions(+) --

Re: [libvirt] [PATCH v2 02/14] qemu: Introduce qemuDomainSecretMigratePrepare

On 02/24/2017 12:08 PM, Jiri Denemark wrote: > On Thu, Feb 23, 2017 at 13:42:04 -0500, John Ferlan wrote: >> Introduce API to Prepare a qemuDomainSecretInfoPtr to be >> used with a migrate or nbd TLS object >> >> Also alter the error message in ChardevPrepare when UUIDParse fails >> to be

Re: [libvirt] [PATCH v2 01/14] qemu: Introduce qemuDomainSecretInfoNew

On 02/24/2017 09:00 AM, Jiri Denemark wrote: > On Thu, Feb 23, 2017 at 13:42:03 -0500, John Ferlan wrote: >> Create a helper which will create the secinfo used for disks, hostdevs, >> and chardevs. >> >> Signed-off-by: John Ferlan >> --- >> src/qemu/qemu_domain.c | 140 >>

Re: [libvirt] [RFC PATCH v2 REBASE 00/18] Introduce vGPU mdev framework to libvirt

On Mon, 20 Feb 2017 15:28:13 +0100 Erik Skultety wrote: > since the original v2 [1]: > - resolved a few merge conflicts caused by @9d92f533 which refactored out some > duplicate code which eventually lead to dropping patch 14/18 from the original > series due to being

Re: [libvirt] [PATCH v2 02/14] qemu: Introduce qemuDomainSecretMigratePrepare

On Thu, Feb 23, 2017 at 13:42:04 -0500, John Ferlan wrote: > Introduce API to Prepare a qemuDomainSecretInfoPtr to be > used with a migrate or nbd TLS object > > Also alter the error message in ChardevPrepare when UUIDParse fails > to be consistent with the message for MigratePrepare > >

[libvirt] RFC: Making storage vol upload/download more useful

The virStorageVolUpload/Download APIs currently require that you upload the physical disk image content, rather than the virtual disk image content. ie the entire qcow2 file, not just its payload. While this is certainly useful in some scenarios, it is rather unhelpful, if not dangerous, in

[libvirt] Entering freeze for libvirt 3.1.0

Hi everybody, as planned I just tagged the RC1 in git and uploded the signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ Seems to work fine in my limited testing, but more testing especially on different platforms and system is needed.

Re: [libvirt] [PATCH 1/4] Unify checking for machine1 systemd service

On Thu, Feb 23, 2017 at 12:53:06PM +0100, Ján Tomko wrote: > Both virSystemdTerminateMachine and virSystemdCreateMachine > propagate the error to tell between a non-systemd system > and a hard error. > > In virSystemdGetMachineNameByPID both are treated the same, > but an error is ignored by the

Re: [libvirt] [PATCH v2 01/14] qemu: Introduce qemuDomainSecretInfoNew

On Thu, Feb 23, 2017 at 13:42:03 -0500, John Ferlan wrote: > Create a helper which will create the secinfo used for disks, hostdevs, > and chardevs. > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_domain.c | 140 > ++--- > 1

[libvirt] [PATCH] virfile: Fix virFileExists commentary

Arguably though, function returning only on success is a very interesting, although quite impractical concept. Also, the errno isn't and shouldn't be preserved in this case, since the errno can be directly fed to the virReportSystemError. Signed-off-by: Erik Skultety ---

Re: [libvirt] [PATCH 0/2] cpu_x86: Disable TSX on broken models

On Thu, Feb 16, 2017 at 03:02:17PM +0100, Jiri Denemark wrote: > This series applies on top of "qemu: Detect host CPU model by asking > QEMU on x86_64". > > https://bugzilla.redhat.com/show_bug.cgi?id=1406791 > > Jiri Denemark (2): > cpu_x86: Disable TSX on broken models > cputest: Add CPUID

Re: [libvirt] [PATCH v3 00/28] qemu: Detect host CPU model by asking QEMU on x86_64

Thanks for the reviews. I pushed all patches which didn't rely on the new QEMU feature. They are mostly refactoring the code or adding new internal APIs used in the rest of the series. I'll wait with pushing the other patches until the QEMU feature is accepted upstream. Pushed patches: - qemu:

Re: [libvirt] [PATCH v2 12/14] conf: Introduce migrate_tls_x509_cert_dir

On 02/23/2017 01:42 PM, John Ferlan wrote: > Add a new TLS X.509 certificate type - "migrate". This will handle the > creation of a TLS certificate capability (and possibly repository) to > be used for migrations. Similar to chardev's, credentials will be handled > via a libvirt secrets. > >

Re: [libvirt] [PATCH v2 00/14] Add TLS support for migration

On 02/24/2017 04:01 AM, Andrea Bolognani wrote: > On Thu, 2017-02-23 at 13:42 -0500, John Ferlan wrote: >> v1: http://www.redhat.com/archives/libvir-list/2017-February/msg00897.html >> v1 cover letter reiterated: >> >> Patches 1, 3 -> 9 are primarily quite a bit of code motion in order to

[libvirt] [PATCH go v3] Add support for perf events

Signed-off-by: Nitesh Konkar --- connect.go | 54 ++ domain.go | 54 ++ domain_compat.h | 36 3 files changed, 144

Re: [libvirt] [PATCH v3 09/28] qemu: Probe "max" CPU model in TCG

On Fri, Feb 24, 2017 at 01:04:35PM +0100, Jiri Denemark wrote: > On Thu, Feb 23, 2017 at 20:07:00 +0100, Pavel Hrdina wrote: > > On Thu, Feb 23, 2017 at 03:15:07PM +0100, Jiri Denemark wrote: > > > Querying "host" CPU model expansion only makes sense for KVM. QEMU 2.9.0 > > > introduces a new

Re: [libvirt] [PATCH v3 09/28] qemu: Probe "max" CPU model in TCG

On Thu, Feb 23, 2017 at 20:07:00 +0100, Pavel Hrdina wrote: > On Thu, Feb 23, 2017 at 03:15:07PM +0100, Jiri Denemark wrote: > > Querying "host" CPU model expansion only makes sense for KVM. QEMU 2.9.0 > > introduces a new "max" CPU model which can be used to ask QEMU what the > > best CPU it can

Re: [libvirt] [PATCH v2 0/3] introduce virBufferEscapeN and fix escape bug

On Fri, Feb 24, 2017 at 11:53:29AM +0100, Ján Tomko wrote: > On Thu, Feb 23, 2017 at 09:36:15PM +0100, Pavel Hrdina wrote: > >I've dropped the STRCAT patches in v2. The whole purpose of the STRCAT was > >to avoid calling *strcspn* several times but it was probably a bad call. > >Now we call that

Re: [libvirt] A question for external snapshots with flag“VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE”

[Adding the correct mailing list, removing libvirt-list-owner] On Fri, Feb 24, 2017 at 05:35:31PM +0800, WangJie (Captain) wrote: > Hello, I got a question here. When we create consistent active external > snapshots with flag “VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE” , the >

Re: [libvirt] [PATCH] qemuProcessInit: Jump onto correct label in case of error

On Thu, Feb 23, 2017 at 05:46 PM +0100, Michal Privoznik wrote: > On 02/23/2017 05:40 PM, Marc Hartmayer wrote: >> On Thu, Feb 23, 2017 at 05:15 PM +0100, Michal Privoznik >> wrote: >>> After eca76884ea in case of error in qemuDomainSetPrivatePaths()

Re: [libvirt] [PATCH v3 28/28] news: Detect host CPU model by asking QEMU on x86_64

On Thu, Feb 23, 2017 at 03:15:26PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 3: > - no change > > Version 2: > - no change > > docs/news.xml | 11 +++ > 1 file changed, 11 insertions(+) > > diff

Re: [libvirt] [PATCH v3 27/28] cputest: Drop .new suffix from CPU test data files

On Thu, Feb 23, 2017 at 03:15:25PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 3: > - no change > > Version 2: > - no change ACK Pavel signature.asc Description: Digital signature -- libvir-list mailing list

Re: [libvirt] [PATCH v3 26/28] cputest: Drop obsolete CPU test data files

On Thu, Feb 23, 2017 at 03:15:24PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 3: > - no change > > Version 2: > - no change ACK Pavel signature.asc Description: Digital signature -- libvir-list mailing list

Re: [libvirt] [PATCH v3 25/28] cputest: Test virQEMUCapsInitCPUModel

On Thu, Feb 23, 2017 at 03:15:23PM +0100, Jiri Denemark wrote: > The original test didn't use family/model numbers to make better > decisions about the CPU model and thus mis-detected the model in the two > cases which are modified in this commit. The detected CPU models now > match those obtained

Re: [libvirt] [PATCH v3 24/28] cputest: Convert all json data files to query-cpu-model-expansion

On Thu, Feb 23, 2017 at 03:15:22PM +0100, Jiri Denemark wrote: > Converted by running the following command, renaming the files as > *.new, and committing only the *.new files. > > (cd tests/cputestdata; ./cpu-convert.py *.json) > > Signed-off-by: Jiri Denemark > --- >

Re: [libvirt] [PATCH v3 23/28] cputest: Switch host CPU data scripts to model expansion

On Thu, Feb 23, 2017 at 03:15:21PM +0100, Jiri Denemark wrote: > Instantiating "host" CPU and querying it using qom-get has been the only > way of probing host CPU via QEMU until 2.9.0 implemented > query-cpu-model-expansion for x86_64. Even though libvirt never really > used the old way its

Re: [libvirt] [PATCH go v2] Add support for perf events

On Fri, Feb 24, 2017 at 3:32 PM, Peter Krempa wrote: > On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote: > > Signed-off-by: Nitesh Konkar > > --- > > connect.go | 54 ++ > > >

Re: [libvirt] [PATCH go v2] Add support for perf events

On Fri, Feb 24, 2017 at 04:39:01PM +0530, Nitesh Konkar wrote: > On Fri, Feb 24, 2017 at 4:06 PM, Daniel P. Berrange > wrote: > > > On Fri, Feb 24, 2017 at 11:02:33AM +0100, Peter Krempa wrote: > > > On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote: > > > >

Re: [libvirt] [PATCH go v2] Add support for perf events

On Fri, Feb 24, 2017 at 4:06 PM, Daniel P. Berrange wrote: > On Fri, Feb 24, 2017 at 11:02:33AM +0100, Peter Krempa wrote: > > On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote: > > > Signed-off-by: Nitesh Konkar > > > --- > > >

Re: [libvirt] [PATCH] qemuProcessInit: Jump onto correct label in case of error

On Thu, Feb 23, 2017 at 05:15:47PM +0100, Michal Privoznik wrote: After eca76884ea in case of error in qemuDomainSetPrivatePaths() in pretended start we jump to stop. I've changed this during review from 'cleanup' which turned out to be correct. Well, sort of. We can't call qemuProcessStop() as

Re: [libvirt] [PATCH v2 0/3] introduce virBufferEscapeN and fix escape bug

On Thu, Feb 23, 2017 at 09:36:15PM +0100, Pavel Hrdina wrote: I've dropped the STRCAT patches in v2. The whole purpose of the STRCAT was to avoid calling *strcspn* several times but it was probably a bad call. Now we call that function for each pair but if no escaping is required we at least

Re: [libvirt] [PATCH v2 1/3] util: virbuffer: introduce virBufferEscapeN

On Thu, Feb 23, 2017 at 09:36:16PM +0100, Pavel Hrdina wrote: +/** + * virBufferEscapeN: + * @buf: the buffer to append to + * @format: a printf like format string but with only one %s parameter + * @str: the string argument which needs to be escaped + * @...: the variable list of arguments

Re: [libvirt] [PATCH go v2] Add support for perf events

On Fri, Feb 24, 2017 at 11:02:33AM +0100, Peter Krempa wrote: > On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote: > > Signed-off-by: Nitesh Konkar > > --- > > connect.go | 54 ++ > > domain.go

Re: [libvirt] [PATCH v3 22/28] cputest: Use virArch enum rather then strings

On Thu, 2017-02-23 at 15:15 +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark s/then/than/ in the subject ;) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH go v2] Add support for perf events

On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > connect.go | 54 ++ > domain.go | 54 ++ >

Re: [libvirt] [PATCH v3 22/28] cputest: Use virArch enum rather then strings

On Thu, Feb 23, 2017 at 03:15:20PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 3: > - no change > > Version 2: > - no change > > tests/cputest.c | 294 >

[libvirt] [PATCH go v2] Add support for perf events

Signed-off-by: Nitesh Konkar --- connect.go | 54 ++ domain.go | 54 ++ domain_compat.h | 36 3 files changed, 144

Re: [libvirt] [PATCH v2 0/2] tests: Reduce QEMU_CAPS_DEVICE_{DMI_TO_, }PCI_BRIDGE usage

On 02/23/2017 07:39 PM, Andrea Bolognani wrote: > Changes from v1: > > * don't drop capabilities for a bunch of test cases, > so that potential regressions will be still caught. > > Andrea Bolognani (2): > tests: Sync tests between qemuxml2argv and qemuxml2xml > tests: Reduce

Re: [libvirt] [PATCH 02/13] conf: Introduce migrate_tls_x509_cert_dir

On Thu, Feb 23, 2017 at 12:19:46 -0500, John Ferlan wrote: > >>> The problem is chardevs and migration are quite different. While you can > >>> easily have a default configuration for chardevs and use tls="yes|no" to > >>> override it (no tls attribute will just tell libvirt to use the > >>>

Re: [libvirt] [RFC PATCH 00/12] Add block write threshold event

On Thu, Feb 23, 2017 at 13:50:03 -0600, Eric Blake wrote: > On 02/23/2017 01:21 PM, Peter Krempa wrote: > > Since I'm a procrastinator and I wanted to do this after full node-name > > support > > is added I'm kind of late for this release here. Since oVirt is asking for > > this > > feature for

Re: [libvirt] [RFC PATCH 03/12] lib: Introduce event for tracking disk backing file write threshold

On Thu, Feb 23, 2017 at 16:32:45 -0600, Eric Blake wrote: > On 02/23/2017 01:21 PM, Peter Krempa wrote: > > When using thin provisioning, management tools need to resize the disk > > in certain cases. To avoid having them to poll disk fillng introduce an > > Typo, but a different word sounds

Re: [libvirt] [PATCH v3 21/28] cputest: Rename x86 data files

On Thu, Feb 23, 2017 at 03:15:19PM +0100, Jiri Denemark wrote: > While "x86" is a CPU sub driver name, it is not a recognized name of any > architecture known to libvirt. Let's use "x86_64" prefix which can be > used with virArch APIs. > > Signed-off-by: Jiri Denemark > ---

Re: [libvirt] [PATCH v3 20/28] qemu: Make virQEMUCapsInitCPUModel testable

On Thu, Feb 23, 2017 at 03:15:18PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 3: > - s/type/virtType/ in virQEMUCapsLoadHostCPUModelInfo > > Version 2: > - no change > > src/qemu/qemu_capabilities.c | 19

Re: [libvirt] [PATCH v3 19/28] qemu: Use full CPU model expansion on x86

On Thu, Feb 23, 2017 at 03:15:17PM +0100, Jiri Denemark wrote: > The static CPU model expansion is designed to return only canonical > names of all CPU properties. To maintain backwards compatibility libvirt > is stuck with different spelling of some of the features, but we need to > use the full

Re: [libvirt] [PATCH v3 18/28] qemu: Use enum for CPU model expansion type

On Thu, Feb 23, 2017 at 03:15:16PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 3: > - no change > > Version 2: > - no change > > src/qemu/qemu_capabilities.c | 4 +++- > src/qemu/qemu_monitor.c | 4 ++--

Re: [libvirt] [PATCH] qemu_process: spice: don't release used port

On Fri, Feb 24, 2017 at 09:58:31AM +0100, Pavel Hrdina wrote: The port is stored in graphics configuration and it will also get released in qemuProcessStop in case of error. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1397440 Signed-off-by: Pavel Hrdina ---

Re: [libvirt] [PATCH v2 00/14] Add TLS support for migration

On Thu, 2017-02-23 at 13:42 -0500, John Ferlan wrote: > v1: http://www.redhat.com/archives/libvir-list/2017-February/msg00897.html > v1 cover letter reiterated: >  > Patches 1, 3 -> 9 are primarily quite a bit of code motion in order to allow > reuse of the "core" of the chardev TLS code. >  >

[libvirt] [PATCH] qemu_process: spice: don't release used port

The port is stored in graphics configuration and it will also get released in qemuProcessStop in case of error. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1397440 Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 1 - 1 file changed, 1 deletion(-) diff

[libvirt] [PATCH 3/3] libxl: Change virDomainObjIsActive to virDomainObjCheckIsActive

Replace virDomainObjIsActive with virDomainObjCheckIsActive which raises error if domain is not active Signed-off-by: Sagar Ghuge --- ...libxl-Implement-virDomainObjCheckIsActive.patch | 55 ...omainObjIsActive-with-virDomainObjCheckIs.patch | 109

[libvirt] [PATCH 2/3] change virDomainObjIsActive with virDomainObjCheckIsActive

Signed-off-by: Sagar Ghuge --- src/test/test_driver.c | 35 +++ 1 file changed, 7 insertions(+), 28 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5fef3f1..bbcaa44 100644 --- a/src/test/test_driver.c +++

[libvirt] [PATCH 1/3] libxl: Implement virDomainObjCheckIsActive

Add function which raises error if domain is not active Signed-off-by: Sagar Ghuge --- src/conf/domain_conf.c | 15 +++ src/conf/domain_conf.h | 1 + 2 files changed, 16 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH 0/3] libxl: implement virDomainObjCheckIsActive

Add function which raises error if domain is not active. This is BiteSizedTask. http://wiki.libvirt.org/page/BiteSizedTasks#Add_function_that_raises_error_if_domain_is_not_active Sagar Ghuge (3): libxl: Implement virDomainObjCheckIsActive change virDomainObjIsActive with

Re: [libvirt] [PATCH] qemu: Don't update physical storage size of empty drives

On Thu, Feb 23, 2017 at 10:22:05 +0100, Peter Krempa wrote: > Previously the code called virStorageSourceUpdateBlockPhysicalSize which > did not do anything on empty drives since it worked only on block > devices. After the refactor in c5f6151390 it's called for all devices > and thus attempts to