Re: [libvirt] [PATCH v2 00/38] Implement sparse streams for libvirt

On 04/20/2017 12:01 PM, Michal Privoznik wrote: > v2 of: > > https://www.redhat.com/archives/libvir-list/2017-April/msg00671.html > > All the patches can be found on my github: > > https://github.com/zippy2/libvirt/tree/sparse_iohelper5 > ping? Patches 01-07 are fairly trivial and are more

[libvirt] Errors related to Per-node memory binding and huge pages per NUMA node.

Hi Daniel et.al, Running into the following errors when attempting to start up a multi-vNUMA node VM backed by 1G huge page per physical NUMA node. (details below) error: unsupported configuration: Per-node memory binding is not supported with this QEMU (or in another case) error: unsupported

[libvirt] [PATCH] util: Remove unused variate @errbuf in virPCIGetDeviceAddressFromSysfsLink

From: w00185384 Since refactoring by commit id 'a7035662', @errbuf is no longer used. --- src/util/virpci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index c89b94b..83c7e74 100644 --- a/src/util/virpci.c +++

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

On Wed, 26 Apr 2017 18:20:24 +0200 Andrea Bolognani wrote: > [*actually* added David and Drew to CC smh] > > On Wed, 2017-04-26 at 18:13 +0200, Andrea Bolognani wrote: > > The rest looks good, but I'd like to make sure changing the > > default is something that's okay with

Re: [libvirt] [PATCH 2/2] network: better log message when network is inactive during reconnect

On 04/26/2017 02:39 PM, John Ferlan wrote: > > > On 04/25/2017 12:34 PM, Laine Stump wrote: >> If the network isn't active during networkNotifyActualDevice(), we >> would log an error message stating that the bridge device didn't >> exist. This patch adds a check to see if the network is active,

Re: [libvirt] [PATCH 1/2] qemu: don't kill qemu process on restart if networkNotify fails

On 04/26/2017 02:39 PM, John Ferlan wrote: > > > On 04/25/2017 12:33 PM, Laine Stump wrote: >> Nothing that could happen during networkNotifyActualDevice() could >> justify unceremoniously killing the qemu process, but that's what we >> were doing. > > So that galaxy in far far away land circa

[libvirt] [PATCH] qemu: Ignore missing query-migrate-parameters

Trivially no migration parameters are supported when query-migrate-parameters QMP command is missing. There's no need to report an error in such case especially when doing so breaks compatibility with old QEMU. https://bugzilla.redhat.com/show_bug.cgi?id=1441934 Signed-off-by: Jiri Denemark

[libvirt] [PATCH v2 3/3] qemu: Remove extra messages for vhost-scsi hotplug

As with virtio-scsi, the "internal error" messages after preparing a vhost-scsi hostdev overwrites more meaningful error messages deeper in the callchain. Remove it too. Signed-off-by: Eric Farman --- src/qemu/qemu_hotplug.c | 7 +-- 1 file changed, 1

[libvirt] [PATCH v2 0/3] Cleanup messages after hotplug of scsi hostdev

v1 was here: https://www.redhat.com/archives/libvir-list/2017-April/msg01066.html Per review, removed the "internal error" messages and split the resulting patch into patches 2 (virtio-scsi) and 3 (vhost-scsi). Patch 1 fixes a return code check that is a little off. Eric Farman (3): qemu:

[libvirt] [PATCH v2 1/3] qemu: Check return code from qemuHostdevPrepareSCSIDevices

Signed-off-by: Eric Farman --- src/qemu/qemu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index eec99af..6d568d6 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@

[libvirt] [PATCH v2 2/3] qemu: Remove extra messages from virtio-scsi hotplug

I tried to attach a SCSI LUN to two different guests, and forgot to specify "shareable" in the hostdev XML. Attaching the device to the second guest failed, but the message was not helpful in telling me what I was doing wrong: $ cat scsi_scratch_disk.xml

[libvirt] [PATCH] qemu: Properly reset non-p2p migration

While peer-to-peer migration enters the Confirm phase even if the Perform phase fails, the client which initiated a non-p2p migration will never call virDomainMigrateConfirm* API if the Perform phase failed. Thus we need to explicitly reset migration before reporting a failure from the Perform

Re: [libvirt] [PATCH] qemu: Do not overwrite existing messages in hotplug

On 04/26/2017 01:55 PM, John Ferlan wrote: On 04/24/2017 02:02 PM, Eric Farman wrote: I tried to attach a SCSI LUN to two different guests, and forgot to specify "shareable" in the hostdev XML. Attaching the device to the second guest failed, but the message was not helpful in telling me

Re: [libvirt] [PATCH 2/2] network: better log message when network is inactive during reconnect

On 04/25/2017 12:34 PM, Laine Stump wrote: > If the network isn't active during networkNotifyActualDevice(), we > would log an error message stating that the bridge device didn't > exist. This patch adds a check to see if the network is active, making > the logs more useful in the case that it

Re: [libvirt] [PATCH 1/2] qemu: don't kill qemu process on restart if networkNotify fails

On 04/25/2017 12:33 PM, Laine Stump wrote: > Nothing that could happen during networkNotifyActualDevice() could > justify unceremoniously killing the qemu process, but that's what we > were doing. So that galaxy in far far away land circa commit id '04711a0f' when all this was added - > > In

Re: [libvirt] [PATCH] qemu: Do not overwrite existing messages in hotplug

On 04/24/2017 02:02 PM, Eric Farman wrote: > I tried to attach a SCSI LUN to two different guests, and forgot > to specify "shareable" in the hostdev XML. Attaching the device > to the second guest failed, but the message was not helpful in > telling me what I was doing wrong: > > $ cat

[libvirt] [PATCH 14/14] qemu: command: Add support for HTTP cookies

Format the string into the "curl" format so that it's accepted by qemu. Partially resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140164 --- src/qemu/qemu_command.c| 27 +++- .../qemuxml2argv-disk-drive-network-http.args | 32 +++

[libvirt] [PATCH 13/14] qemu: capabilities: Add capability for the new curl driver options

Add a capability that will cover 'sslverify', 'timeout' and 'cookie' which was recently added after qemu 2.9 finally fixed the introspection for the curl driver. --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 +

[libvirt] [PATCH 07/14] docs: schemas: Split up definitions for NBD and gluster

NBD does not mandate a "filename". Gluster can have more servers. Split them so that we can tighten the schema. --- docs/schemas/domaincommon.rng | 43 +++ 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/docs/schemas/domaincommon.rng

[libvirt] [PATCH 12/14] qemu: command: Use switch to formatting additional network disk params

To allow formatting params for other protocols too add convert it to a switch statement. --- src/qemu/qemu_command.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 1116d2cd5..e9c3ea952 100644

[libvirt] [PATCH 10/14] util: string: Introduce virStringHasChars

The helper returns true if a string contains any of the given chars. virStringHasControlChars can be reimplemented using that helper. --- src/util/virstring.c | 23 +++ src/util/virstring.h | 2 ++ 2 files changed, 21 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH 11/14] conf: Add support for cookies for HTTP based disks

Add possibility to specify one or more cookies for http based disks. This patch adds the config parser, storage and validation of the cookies. --- docs/formatdomain.html.in | 9 ++ docs/schemas/domaincommon.rng | 39 +-- src/conf/domain_conf.c

[libvirt] [PATCH 09/14] tests: genericxml2xml: Add test case for HTTP based disk

--- .../generic-disk-network-http.xml | 44 ++ tests/genericxml2xmltest.c | 1 + 2 files changed, 45 insertions(+) create mode 100644 tests/genericxml2xmlindata/generic-disk-network-http.xml diff --git

[libvirt] [PATCH 08/14] conf: Extract formatting of network disk source into separate function

--- src/conf/domain_conf.c | 99 ++ 1 file changed, 52 insertions(+), 47 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 61006dea7..5a736c853 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt] [PATCH 02/14] docs: schemas: Extract disk source host specification

'diskSourceNetwork' schema define was rather big and it would be hard to simplify it. Split out the host portion subelement into a separate define. --- docs/schemas/domaincommon.rng | 70 +++ 1 file changed, 37 insertions(+), 33 deletions(-) diff --git

[libvirt] [PATCH 04/14] docs: schemas: Extract RBD-specific data

RBD driver supports specifying a snapshot image name or config file. Create a define for RBD and move the specifics there. --- docs/schemas/domaincommon.rng | 50 --- 1 file changed, 37 insertions(+), 13 deletions(-) diff --git

[libvirt] [PATCH 06/14] docs: schemas: Split out simple network protocols

ftp/tftp/sheepdog have a mandatory filename and support only one host. There are no additional options for them. --- docs/schemas/domaincommon.rng | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/docs/schemas/domaincommon.rng

[libvirt] [PATCH 05/14] docs: schemas: Extract HTTP disk source specification

Make the schema more strict for HTTP disks requiring a name and mandating exactly one source host. ftp/tftp entries were not moved here, since http transport also will support cookies and other options, which will be added later. --- docs/schemas/domaincommon.rng | 16 ++-- 1 file

[libvirt] [PATCH 01/14] docs: schemas: Remove from file/block/dir/volume disks

They don't contain any elements to interleave. --- docs/schemas/domaincommon.rng | 136 -- 1 file changed, 64 insertions(+), 72 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index eb4b0f743..79ea56960 100644 ---

[libvirt] [PATCH 03/14] docs: schemas: Move the interleave definition into network disk source

Move it to the place where actually interleaving elements can be placed. --- docs/schemas/domaincommon.rng | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 5d17809b3..eca479594 100644 ---

[libvirt] [PATCH 00/14] network schema refactor and addition of cookies for http disks

Peter Krempa (14): docs: schemas: Remove from file/block/dir/volume disks docs: schemas: Extract disk source host specification docs: schemas: Move the interleave definition into network disk source docs: schemas: Extract RBD-specific data docs: schemas: Extract HTTP disk source

Re: [libvirt] [PATCH] tests: update QEMU 2.9.0 caps data to final version

On Wed, Apr 26, 2017 at 19:34:41 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 4329 > ++-- > tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml |5 +- > 2 files changed, 2248

Re: [libvirt] [PATCH v2 00/11]

On 04/26/2017 04:46 AM, Pavel Hrdina wrote: > On Tue, Apr 25, 2017 at 05:15:24PM -0400, John Ferlan wrote: >> v1: https://www.redhat.com/archives/libvir-list/2017-April/msg01051.html >> >> Changes since v1: >> >> - Patches 1, 2, 4, and 14 were pushed since they were ACK and "separable" >> >> -

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

On Wed, Apr 26, 2017 at 06:13:44PM +0200, Andrea Bolognani wrote: > [David and Drew added to CC, feel free to skip to the bottom] > > On Thu, 2017-04-20 at 15:44 +0200, Pavel Hrdina wrote: > [...] > > +} else if (def->os.arch == VIR_ARCH_AARCH64 && > > +   

Re: [libvirt] [PATCH] IPv6 route check: list devices only once

On 04/26/2017 06:38 AM, Cédric Bosdonnat wrote: > If several RA routes are found for the same device, only list that > device once in the error message. > --- > src/util/virnetdevip.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/src/util/virnetdevip.c

[libvirt] Plans for next release

I didn't realized that end of month was getting that close. So I suggest to enter freeze for 3.3.0 on Friday. I can then push an RC2 on Monday evening or Tuesday and push the release Wed or Thursday, I hope that works for everybody, there is roughtly 2 days to push patches you want in (except

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

[*actually* added David and Drew to CC smh] On Wed, 2017-04-26 at 18:13 +0200, Andrea Bolognani wrote: > The rest looks good, but I'd like to make sure changing the > default is something that's okay with everyone. > > David, Drew, do you have anything against changing the > default USB

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

[David and Drew added to CC, feel free to skip to the bottom] On Thu, 2017-04-20 at 15:44 +0200, Pavel Hrdina wrote: [...] > +} else if (def->os.arch == VIR_ARCH_AARCH64 && > +   virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_QEMU_XHCI)) > { > +/* If

Re: [libvirt] [PATCH] qemu: Don't fail if physical size can't be updated in qemuDomainGetBlockInfo

On Thu, Apr 20, 2017 at 15:50:00 +0200, Peter Krempa wrote: > Since commit c5f6151390 qemuDomainBlockInfo tries to update the > "physical" storage size for all network storage and not only block > devices. > > Since the storage driver APIs to do this are not implemented for certain > storage

[libvirt] [PATCH 2/2] qemu: Report VIR_DOMAIN_JOB_OPERATION

https://bugzilla.redhat.com/show_bug.cgi?id=1441563 Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c| 16 +--- src/qemu/qemu_domain.h| 4 +++- src/qemu/qemu_driver.c| 32 ++-- src/qemu/qemu_migration.c | 19

[libvirt] [PATCH 1/2] Add VIR_DOMAIN_JOB_OPERATION typed parameter

The parameter is reported by virDomainGetJobStats API and VIR_DOMAIN_EVENT_ID_JOB_COMPLETED event and it can be used to identify the operation (migration, snapshot, ...) to which the reported statistics belong. https://bugzilla.redhat.com/show_bug.cgi?id=1441563 Signed-off-by: Jiri Denemark

[libvirt] [PATCH 0/2] Report VIR_DOMAIN_JOB_OPERATION in job stats

As agreed in [1] we should enhance job statistics returned by virDomainGetJobStats API and VIR_DOMAIN_EVENT_ID_JOB_COMPLETED event with a new typed parameter which would indicate what operation (migration, snapshot, ...) the reported statistics belong to.

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On Wed, Apr 26, 2017 at 01:40:33PM +0100, Daniel P. Berrange wrote: > On Wed, Apr 26, 2017 at 08:14:31AM -0400, John Ferlan wrote: [...] # Snip some useful discussion > > What happens if one forgets or one consistently doesn't provide the > > tags? Is their push privilege taken away? IOW, what's

[libvirt] [PATCH v3 2/6] nodedev: conf: Split PCI sub-capability parsing to separate methods

Since there's at least SRIOV and MDEV sub-capabilities to be parsed, let's make the code more readable by splitting it to several logical blocks. Signed-off-by: Erik Skultety --- src/conf/node_device_conf.c | 130 ++-- 1 file changed,

[libvirt] [PATCH v3 1/6] mdev: Pass a uuidstr rather than an mdev object to some util functions

Namely, this patch is about virMediatedDeviceGetIOMMUGroup{Dev,Num} functions. There's no compelling reason why these functions should take an object, on the contrary, having to create an object every time one needs to query the IOMMU group number, discarding the object afterwards, seems odd.

[libvirt] [PATCH v3 6/6] docs: Document the mediated devices within the nodedev driver

Signed-off-by: Erik Skultety --- docs/drvnodedev.html.in | 164 +++- 1 file changed, 163 insertions(+), 1 deletion(-) diff --git a/docs/drvnodedev.html.in b/docs/drvnodedev.html.in index 0a3870343..8f820cca1 100644 ---

[libvirt] [PATCH v3 3/6] nodedev: Introduce new mdev_types and mdev nodedev capabilities

The reason for introducing two capabilities, one for the device itself (cap 'mdev') and one for the parent device listing the available types ('mdev_types'), is that we should be able to do 'virsh nodedev-list --cap' not only for existing mdev devices but also for devices that support creation of

[libvirt] [PATCH v3 5/6] nodedev: Introduce mdev capability for mediated devices

Start discovering the mediated devices on the host system and format the attributes for the mediated device into the XML. Compared to the parent device which reports generic information about the abstract mediated devices types, a child device only reports the type name it has been instantiated

[libvirt] [PATCH v3 0/6] Add mdev reporting capability to the nodedev driver

since v1: - dropped the element from the parent device nested capability - added missing RNG schema and tests - updated the documentation to describe the MDEV elements in both the parent and the child since v2: - I further split our PCI sub-capability parser into more blocks as suggested -

[libvirt] [PATCH v3 4/6] nodedev: Introduce the mdev capability to a PCI parent device

The parent device needs to report the generic stuff about the supported mediated devices types, like device API, available instances, type name, etc. Therefore this patch introduces a new nested capability element of type 'mdev_types' with the resulting XML of the following format: ... ...

Re: [libvirt] [PATCHv3 1/6] conf: add to

On 26/04/2017 11:36, Peter Xu wrote: >> Possible values are off, split or on. > Hi, Ján, > > Thanks you for cced me. One tiny comment on irqchip mode... > > Here could user specify irqchip=off from libvirt side? IIUC that might > be dangerous since userspace APIC should only be for debugging

Re: [libvirt] [PATCH 2/3] qemu: add support for qemu-xhci USB controller

On Thu, 2017-04-20 at 15:44 +0200, Pavel Hrdina wrote: [...] > @@ -3464,7 +3464,7 @@ >  "ehci", "ich9-ehci1", "ich9-uhci1", "ich9-uhci2", "ich9-uhci3", >  "vt82c686b-uhci", "pci-ohci", "nec-xhci", "qusb1" (xen pvusb >  with qemu backend, version 1.1) or "qusb2" (xen pvusb

Re: [libvirt] [PATCH v2 09/10] docs: Provide a nodedev driver stub documentation

> > I'm not a native speaker but the text makes sense and having something is > > definitely better than having no documentation at all. > > > > ACK > > > > Pavel > > If you remove all MDEV references you can push it right away. I did so and pushed the documentation stub. Thanks, Erik --

Re: [libvirt] [PATCH 1/3] qemu: introduce QEMU_CAPS_DEVICE_QEMU_XHCI

On Thu, 2017-04-20 at 15:44 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h | 1 + > tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + > 3 files

Re: [libvirt] How to get VM memory usage

[moderator note: I'm forwarding a stripped down version of the original mail which was rejected in the moderator queue. I stripped the .jpg attachments, which are inappropriate for a technical list. Either paste the text contents (rather than a screenshot) of the window you are describing, or host

[libvirt] [PATCH] qemu: numa: Don't return automatic nodeset for inactive domain

qemuDomainGetNumaParameters would return the automatic nodeset even for the persistent config if the domain was running. This is incorrect since the automatic nodeset will be re-queried upon starting the vm. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1445325 --- src/qemu/qemu_driver.c

[libvirt] [PATCH 4/4] qemu: Move freeing of PCI address list to qemuProcessStop

Rather than freeing the list before starting a new VM clear it after stopping the old instance when the data becomes invalid. --- src/qemu/qemu_domain_address.c | 1 - src/qemu/qemu_process.c| 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH 3/4] qemu: process: Clean up priv->migTLSAlias

The alias would be leaked, since it's not freed on the vm stop path. --- src/qemu/qemu_process.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 6787c47cf..d3266e778 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c

[libvirt] [PATCH 1/4] qemu: process: Clean automatic NUMA/cpu pinning information on shutdown

Clean the stale data after shutting down the VM. Otherwise the data would be leaked on next VM start. This happens due to the fact that the private data object is not freed on destroy of the VM. --- src/qemu/qemu_process.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[libvirt] [PATCH 0/4] qemu: process: Fix memleaks on VM restart

Few leaks with automatic pinning, USB addresses and TLS migration, since the private data structure needs to be cleared manually in qemuProcessStop. Peter Krempa (4): qemu: process: Clean automatic NUMA/cpu pinning information on shutdown qemu: process: Don't leak priv->usbaddrs after VM

[libvirt] [PATCH 2/4] qemu: process: Don't leak priv->usbaddrs after VM restart

Since the private data structure is not freed upon stopping a VM, the usbaddrs pointer would be leaked: ==15388== 136 (16 direct, 120 indirect) bytes in 1 blocks are definitely lost in loss record 893 of 1,019 ==15388==at 0x4C2CF55: calloc (vg_replace_malloc.c:711) ==15388==by 0x54BF64A:

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On Wed, Apr 26, 2017 at 08:14:31AM -0400, John Ferlan wrote: > Still for the most part, I would "hope" that an S-o-B could come with > the implicit expectation that they've run "make check syntax-check". > Similarly a reviewer would I think for a majority of what they review, > apply the patches

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On 04/26/2017 05:10 AM, Daniel P. Berrange wrote: > On Wed, Apr 26, 2017 at 11:06:54AM +0200, Kashyap Chamarthy wrote: >> On Wed, Apr 26, 2017 at 09:35:47AM +0100, Daniel P. Berrange wrote: >>> On Wed, Apr 26, 2017 at 09:55:50AM +0200, Kashyap Chamarthy wrote: >> >> [...] >> I realize that

[libvirt] [ROC] migration: set cpu throttle value by workload

Hi all, When migrating a guest which consumes too much CPU & memory, dirty pages amount will increase significantly, so does the migration time, migration can not even complete, at worst. So I made an RFC patch in QEMU to set cpu throttle value by workload when migration. The test result and the

Re: [libvirt] [PATCH v3 1/5] storage: Modify storageBackendWipeLocal to allow zero from end of device

On 04/25/2017 03:06 AM, Michal Privoznik wrote: > On 04/07/2017 06:30 PM, John Ferlan wrote: >> Add bool 'zero_end' and logic that would allow a caller to wipe specific >> portions of a target device either from the beginning (the default) or >> from the end when zero_end is true. >> >> This

[libvirt] [PATCH] Update keycodemapdb submodule for python2 compat fixes

There were a few bugs in keycodemap tool that broke it when run on python circa 2.7.5 or older, which affected RHEL builds. Signed-off-by: Daniel P. Berrange --- Pushed as a CI build fix for rhel6/7 src/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH] conf: format only relevant attributes for graphics based on listen type

This patch changes following output: ... ... into this output: ... ... Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH] IPv6 route check: list devices only once

If several RA routes are found for the same device, only list that device once in the error message. --- src/util/virnetdevip.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index 09925e1d7..bf98ed8a5 100644 ---

Re: [libvirt] [PATCHv3 5/6] conf: add caching attribute to iommu device

On Wed, Apr 26, 2017 at 10:29:06AM +0200, Ján Tomko wrote: > Add a new attribute to control the caching mode. I don't know the detailed changes below, but... I feel like using the full term "caching-mode" might be slightly better, since "caching" is a too general name used everywhere, and that

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On Wed, Apr 26, 2017 at 10:10:08AM +0100, Daniel P. Berrange wrote: > On Wed, Apr 26, 2017 at 11:06:54AM +0200, Kashyap Chamarthy wrote: [...] > > > I'd like to see us formally adopt the signed-off-by approach for all > > > patches as a mandatory thing, along with the associated contributor > >

Re: [libvirt] [PATCHv3 1/6] conf: add to

On Wed, Apr 26, 2017 at 10:29:02AM +0200, Ján Tomko wrote: > Add a new element with a mode attribute. > > Possible values are off, split or on. Hi, Ján, Thanks you for cced me. One tiny comment on irqchip mode... Here could user specify irqchip=off from libvirt side? IIUC that might be

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On Wed, Apr 26, 2017 at 11:06:54AM +0200, Kashyap Chamarthy wrote: > On Wed, Apr 26, 2017 at 09:35:47AM +0100, Daniel P. Berrange wrote: > > On Wed, Apr 26, 2017 at 09:55:50AM +0200, Kashyap Chamarthy wrote: > > [...] > > > > I realize that if it's not automated (via Git hooks or similar), it

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On Wed, Apr 26, 2017 at 09:35:47AM +0100, Daniel P. Berrange wrote: > On Wed, Apr 26, 2017 at 09:55:50AM +0200, Kashyap Chamarthy wrote: [...] > > I realize that if it's not automated (via Git hooks or similar), it can > > become "lossy", i.e. if Joe posts v1 of a patch, you give a 'Tested-by',

Re: [libvirt] [PATCH v2 10/11] secret: Alter FindByUUID to expect the formatted uuidstr

On Tue, Apr 25, 2017 at 05:15:34PM -0400, John Ferlan wrote: > Since we're storing a virUUIDFormat'd string in our Hash Table, let's > modify the Lookup API to receive a formatted string as well. > > Signed-off-by: John Ferlan > --- > src/conf/virsecretobj.c| 18

Re: [libvirt] [PATCH v2 00/11]

On Tue, Apr 25, 2017 at 05:15:24PM -0400, John Ferlan wrote: > v1: https://www.redhat.com/archives/libvir-list/2017-April/msg01051.html > > Changes since v1: > > - Patches 1, 2, 4, and 14 were pushed since they were ACK and "separable" > > - Former patch 3 is now patch 1 >-> Restore the

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On Wed, Apr 26, 2017 at 09:55:50AM +0200, Kashyap Chamarthy wrote: > Hi folks, > > I was wondering if the upstream would be receptive to adding a > 'Tested-by' tag for patches that had someone give tested feedback on the > list. > > Personally, what I consider a bar for giving a 'Tested-by' is,

[libvirt] [PATCHv3 5/6] conf: add caching attribute to iommu device

Add a new attribute to control the caching mode. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- docs/formatdomain.html.in | 9 docs/schemas/domaincommon.rng | 5 +++ src/conf/domain_conf.c | 24 +--

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On Wed, Apr 26, 2017 at 10:27:00 +0200, Michal Privoznik wrote: > On 04/26/2017 09:55 AM, Kashyap Chamarthy wrote: > > Hi folks, > > > > I was wondering if the upstream would be receptive to adding a > > 'Tested-by' tag for patches that had someone give tested feedback on the > > list. > > If we

Re: [libvirt] [PATCH v2 04/11] secret: Use virSecretDefPtr rather than deref from virSecretObjPtr

On Tue, Apr 25, 2017 at 05:15:28PM -0400, John Ferlan wrote: > Rather than dereferencing obj->def->X, create a local 'def' variable > variable that will dereference the def and use directly. s/variable// > Signed-off-by: John Ferlan > --- > src/conf/virsecretobj.c | 63 >

[libvirt] [PATCHv3 3/6] conf: add to

Add a new attribute to control interrupt remapping. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- docs/formatdomain.html.in | 22 - docs/schemas/domaincommon.rng | 9 + src/conf/domain_conf.c |

[libvirt] [PATCHv3 1/6] conf: add to

Add a new element with a mode attribute. Possible values are off, split or on. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- docs/formatdomain.html.in | 10 +++ docs/schemas/domaincommon.rng | 16 ++ src/conf/domain_conf.c

[libvirt] [PATCHv3 0/6] Support more options for intel-iommu

[Adding Peter Xu to cc to see if he has any opinion on the docs] https://bugzilla.redhat.com/show_bug.cgi?id=1427005 v1: https://www.redhat.com/archives/libvir-list/2017-March/msg01072.html v2: https://www.redhat.com/archives/libvir-list/2017-April/msg00932.html new in v3: * add more devices

Re: [libvirt] [PATCH v2 03/11] secret: Use consistent naming for variables

On Tue, Apr 25, 2017 at 05:15:27PM -0400, John Ferlan wrote: > When processing a virSecretPtr use 'secret' as a variable name. > > When processing a virSecretObjPtr use 'obj' as a variable name. > > When processing a virSecretDefPtr use 'def' as a variable name, > unless a distinction needs to

[libvirt] [PATCHv3 6/6] qemu: format caching-mode on iommu command line

Format the caching-mode option for the intel-iommu device, based on its attribute value. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 3 +++ src/qemu/qemu_command.c

[libvirt] [PATCHv3 2/6] qemu: format kernel_irqchip on the command line

Add kernel_irqchip=off/split/on to the QEMU command line and a capability that looks for it in query-command-line-options output. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c

[libvirt] [PATCHv3 4/6] qemu: format intremap= on intel-iommu command line

Add the intremap= option to QEMU command line, corresponding to the attribute of the iommu device. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- src/qemu/qemu_capabilities.c | 8 src/qemu/qemu_capabilities.h | 1 +

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On 04/26/2017 09:55 AM, Kashyap Chamarthy wrote: > Hi folks, > > I was wondering if the upstream would be receptive to adding a > 'Tested-by' tag for patches that had someone give tested feedback on the > list. If we are doing this, I suggest having 'Reviewed-by' too. It's merely the same effort

Re: [libvirt] [PATCH v2 00/13] Multiple cleanups within nwfilterobj and nwfilter drivers

On Tue, Apr 25, 2017 at 03:30:20PM -0400, John Ferlan wrote: > v1: https://www.redhat.com/archives/libvir-list/2017-April/msg01074.html > > Changes since v1: > > * Patch 2 -> Do not add the local @def when just dereference obj->def > > * Patch 13 & 15 dropped > > Most patches were ACK'd, but

Re: [libvirt] Unbounded client streams

On Wed, Apr 26, 2017 at 09:48:12AM +0200, Michal Privoznik wrote: > On 04/25/2017 04:06 PM, Daniel P. Berrange wrote: > > On Tue, Apr 25, 2017 at 09:22:51AM +0200, Michal Privoznik wrote: > >> Dear list, > >> > > > > I see three possible options (besides ignoring it) > > > > - Turn off the

[libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

Hi folks, I was wondering if the upstream would be receptive to adding a 'Tested-by' tag for patches that had someone give tested feedback on the list. Personally, what I consider a bar for giving a 'Tested-by' is, when someone: - Applies a patch or a series (following the iterations as

Re: [libvirt] Unbounded client streams

On Wed, Apr 26, 2017 at 09:48:12 +0200, Michal Privoznik wrote: > On 04/25/2017 04:06 PM, Daniel P. Berrange wrote: > > On Tue, Apr 25, 2017 at 09:22:51AM +0200, Michal Privoznik wrote: > >> Dear list, > >> > > > > I see three possible options (besides ignoring it) > > > > - Turn off the

Re: [libvirt] [PATCHv2 3/6] conf: add to

On Mon, Apr 24, 2017 at 05:42:07PM -0400, John Ferlan wrote: On 04/20/2017 08:19 AM, Ján Tomko wrote: Add a new attribute to control interrupt remapping. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- docs/formatdomain.html.in | 22 -

Re: [libvirt] [PATCHv2 1/6] conf: add to

On Mon, Apr 24, 2017 at 05:40:07PM -0400, John Ferlan wrote: On 04/20/2017 08:19 AM, Ján Tomko wrote: Add a new element with a mode attribute. Possible values are off, split or on. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- docs/formatdomain.html.in |

Re: [libvirt] Unbounded client streams

On 04/25/2017 04:06 PM, Daniel P. Berrange wrote: > On Tue, Apr 25, 2017 at 09:22:51AM +0200, Michal Privoznik wrote: >> Dear list, >> > I see three possible options (besides ignoring it) > > - Turn off the keepalive somehow when we want to pause reading from >the stream > > - Somehow

Re: [libvirt] [PATCH] locking: Add support for sanlock_strerror

On Wed, Apr 19, 2017 at 10:32:49 +0200, Jiri Denemark wrote: > The recently added sanlock_strerror function can be used to translate > sanlock's numeric errors into human readable strings. > > https://bugzilla.redhat.com/show_bug.cgi?id=1409511 > > Signed-off-by: Jiri Denemark