Re: [libvirt] [PATCH v2 4/4] security: don't relabel chardev source if virtlogd is used as stdio handler

On 06/15/2017 10:40 AM, Pavel Hrdina wrote: > On Thu, Jun 15, 2017 at 07:57:18AM -0400, John Ferlan wrote: >> >> >> On 06/15/2017 03:11 AM, Pavel Hrdina wrote: >>> On Tue, Jun 13, 2017 at 08:00:41PM -0400, John Ferlan wrote: On 05/29/2017 10:31 AM, Pavel Hrdina wrote: > In the

Re: [libvirt] [PATCH v2 7/8] util: Introduce virObjectPoolableDef

On 06/05/2017 08:29 AM, Peter Krempa wrote: > On Fri, Jun 02, 2017 at 06:17:21 -0400, John Ferlan wrote: >> Add a new virObjectPoolableHashElement child which will be used to provide >> the basis for driver def/newDef elements. >> >> Each virObjectPoolableDef has: >> >> 1. A required

Re: [libvirt] [PATCH 1/2] util: implement virStrToDoubleSafe().

Thanks to share the commit SHA, Martin. My only doubt is: I speak Brazilian portuguese (so pt_BR-Latin America and we use comma as separator). Should libvirt consider it as a separator? Or only dot? Because this approach fails to parse 12,34 (12.34 US) for example. 2017-06-15 5:27 GMT-03:00

[libvirt] [PATCH] util: Force reading of meta data to get encryption capacity value

https://bugzilla.redhat.com/show_bug.cgi?id=1371892 As it turns out the volume create, build, and refresh path was not peeking at the meta data, so immediately after a create operation the value displayed for capacity was still incorrect. However, if a pool refresh was done the correct value was

Re: [libvirt] RFC: Creating mediated devices with libvirt

On Thu, 15 Jun 2017 09:33:01 +0100 "Daniel P. Berrange" wrote: > On Thu, Jun 15, 2017 at 12:06:43AM +0200, Erik Skultety wrote: > > Hi all, > > > > so there's been an off-list discussion about finally implementing creation > > of > > mediated devices with libvirt and it's

Re: [libvirt] [PATCH] maint: update to latest gnulib

On Thu, Jun 15, 2017 at 05:39:00PM +0200, Martin Kletzander wrote: > On Wed, Jun 14, 2017 at 03:35:39PM +0100, Daniel P. Berrange wrote: > > On Wed, Jun 14, 2017 at 04:30:49PM +0200, Martin Kletzander wrote: > > > On Wed, Jun 14, 2017 at 02:32:41PM +0100, Daniel P. Berrange wrote: > > > > On Wed,

Re: [libvirt] [PATCH] Temporarily disable format truncation warnings

On Thu, Jun 15, 2017 at 02:33:34PM +0100, Daniel P. Berrange wrote: GCC 7.1 introduces a new -Wformat-truncation warning flag that reports if it thinks the maximum possible size of the formatted output will exceed the provided fixed buffer. This is enabled automatically by the -Wformat warning

Re: [libvirt] [PATCH] maint: update to latest gnulib

On Wed, Jun 14, 2017 at 03:35:39PM +0100, Daniel P. Berrange wrote: On Wed, Jun 14, 2017 at 04:30:49PM +0200, Martin Kletzander wrote: On Wed, Jun 14, 2017 at 02:32:41PM +0100, Daniel P. Berrange wrote: > On Wed, Jun 14, 2017 at 03:27:25PM +0200, Martin Kletzander wrote: > > On Wed, Jun 14,

Re: [libvirt] [PATCH v2 4/4] security: don't relabel chardev source if virtlogd is used as stdio handler

On Thu, Jun 15, 2017 at 04:40:49PM +0200, Pavel Hrdina wrote: > On Thu, Jun 15, 2017 at 07:57:18AM -0400, John Ferlan wrote: > > > > > > On 06/15/2017 03:11 AM, Pavel Hrdina wrote: > > > On Tue, Jun 13, 2017 at 08:00:41PM -0400, John Ferlan wrote: > > >> > > >> > > >> On 05/29/2017 10:31 AM,

Re: [libvirt] [PATCH v2 4/4] security: don't relabel chardev source if virtlogd is used as stdio handler

On Thu, Jun 15, 2017 at 07:57:18AM -0400, John Ferlan wrote: > > > On 06/15/2017 03:11 AM, Pavel Hrdina wrote: > > On Tue, Jun 13, 2017 at 08:00:41PM -0400, John Ferlan wrote: > >> > >> > >> On 05/29/2017 10:31 AM, Pavel Hrdina wrote: > >>> In the case that virtlogd is used as stdio handler we

[libvirt] [PATCH] qemu: Remove inactive vm when failed to start it

Libvirt forgets to remove inactive vm when failed to start a defined vm. That may result in residual domain in driver->domains on such condition: during the process of starting a vm, undefine it, and qemu exit because of some exception. As we undefined the vm successfully, the vm->persistent was

[libvirt] [PATCH 3/3] qemu: add busy polling support

From: Sahid Orentino Ferdjaoui This patch finalizes support of 'poll_us' attribute as an option of the NIC driver-specific element, the commit also takes care of hotplug. That option is supported for all networks which are using a tap device.

[libvirt] [PATCH 1/3] qemu: add capability for vhost-net busy polling

From: Sahid Orentino Ferdjaoui QEMU 2.7.0 adds support of busy polling on vhost-net. 69e87b32680a41d9761191443587c595b6f5fc3f Signed-off-by: Sahid Orentino Ferdjaoui --- src/qemu/qemu_capabilities.c | 6 ++

[libvirt] [PATCH 2/3] conf: introduce 'poll_us' attribute for domain interface

From: Sahid Orentino Ferdjaoui In this commit we introduce 'poll_us' attribute which will be passed then to the QEMU command line to enable support of busy polling. This commit also take into account that attribute to generate the XML. Signed-off-by: Sahid Orentino

[libvirt] [PATCH 0/3] exposing busy polling support for vhost-net

From: Sahid Orentino Ferdjaoui In version 2.7.0, QEMU introduced support of busy polling for vhost-net [0]. To avoid paraphrasing original authors of that feature and the purpose it I prefer to share a pointer [1]. This patch serie exposes throught the NIC

Re: [libvirt] [PATCH 1/3] qemuDomainBuildNamespace: Clean up temp files

On 06/15/2017 09:44 AM, Michal Privoznik wrote: > On 06/15/2017 02:03 PM, John Ferlan wrote: >> >> >> On 06/15/2017 04:53 AM, Michal Privoznik wrote: >>> On 06/14/2017 09:50 PM, John Ferlan wrote: On 06/12/2017 11:57 AM, Michal Privoznik wrote: >

Re: [libvirt] [PATCH 1/3] qemuDomainBuildNamespace: Clean up temp files

On 06/15/2017 02:03 PM, John Ferlan wrote: > > > On 06/15/2017 04:53 AM, Michal Privoznik wrote: >> On 06/14/2017 09:50 PM, John Ferlan wrote: >>> >>> >>> On 06/12/2017 11:57 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1431112 After 290a00e41d we know

[libvirt] [PATCH] Temporarily disable format truncation warnings

GCC 7.1 introduces a new -Wformat-truncation warning flag that reports if it thinks the maximum possible size of the formatted output will exceed the provided fixed buffer. This is enabled automatically by the -Wformat warning flag. There are quite a few places hit by this in libvirt which need

Re: [libvirt] [PATCH v2 1/4] conf: move seclabel for chardev source to the correct sturcture

On Thu, Jun 15, 2017 at 06:50:34AM -0400, John Ferlan wrote: > > > On 06/15/2017 02:39 AM, Pavel Hrdina wrote: > > On Tue, Jun 13, 2017 at 12:35:10PM -0400, John Ferlan wrote: > >> > >> > >> On 05/29/2017 10:31 AM, Pavel Hrdina wrote: > >>> Signed-off-by: Pavel Hrdina > >>>

[libvirt] [PATCH] qemu: Allow live-updates of coalesce settings

Change the settings from qemuDomainUpdateDeviceLive() as otherwise the call would succeed even though nothing has changed. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1460862 Signed-off-by: Martin Kletzander --- src/qemu/qemu_hotplug.c | 13 ++

Re: [libvirt] [PATCH] hacking: Improve 'git send-email' documentation

On 06/14/2017 11:31 PM, Andrea Bolognani wrote: > For the benefit of first time contributors, we point out that 'git > send-email' might have to be installed separately; however, we omit > the fact that some configuration will likely be needed before it > can successfully deliver patches to the

Re: [libvirt] [PATCH 2/2] qemu: fixing internationalization problem with sched kernel entry.

On 06/14/2017 12:25 PM, Julio Faracco wrote: > In qemuGetSchedInfo(), libvirt is trying to parse some field of /proc/*/sched. > Some fields are floating point numbers and their separator is always a dot. > When you change the locale of the system, you can change the mantissa > separator (to a

Re: [libvirt] [PATCH v5 1/4] conf : Add loadparm boot option for a boot device

On 06/14/2017 01:12 PM, John Ferlan wrote: On 06/01/2017 12:36 PM, Farhan Ali wrote: Update the per device boot schema to add an optional loadparm parameter. eg: Extend the virDomainDeviceInfo to support loadparm option. Modify the appropriate functions to parse loadparm from boot device

Re: [libvirt] [PATCH] Disable the -Wduplicated-branches warning

On Wed, Jun 14, 2017 at 03:11:35PM +0100, Daniel P. Berrange wrote: Depending on the platform/architecture, a number of conditionals in libvirt code expand the same on both branches. This is expected behaviour and harmless, so disable the warning to avoid creating unexpected build failures Two

Re: [libvirt] [PATCH 3/3] qemuDomainGetPreservedMounts: Fix suffixes for corner cases

On 06/15/2017 04:53 AM, Michal Privoznik wrote: > On 06/14/2017 09:58 PM, John Ferlan wrote: >> >> >> On 06/12/2017 11:57 AM, Michal Privoznik wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1431112 >>> >>> Imagine a FS mounted on /dev/blah/blah2. Our process of creating >>> suffix for

Re: [libvirt] [PATCH 1/3] qemuDomainBuildNamespace: Clean up temp files

On 06/15/2017 04:53 AM, Michal Privoznik wrote: > On 06/14/2017 09:50 PM, John Ferlan wrote: >> >> >> On 06/12/2017 11:57 AM, Michal Privoznik wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1431112 >>> >>> After 290a00e41d we know how to deal with file mount points. >>> However, when

Re: [libvirt] [PATCH v2 4/4] security: don't relabel chardev source if virtlogd is used as stdio handler

On 06/15/2017 03:11 AM, Pavel Hrdina wrote: > On Tue, Jun 13, 2017 at 08:00:41PM -0400, John Ferlan wrote: >> >> >> On 05/29/2017 10:31 AM, Pavel Hrdina wrote: >>> In the case that virtlogd is used as stdio handler we pass to QEMU >>> only FD to a PIPE connected to virtlogd instead of the file

[libvirt] [PATCH v2] qemu: Pass the number of heads even with -vga qxl

When added in multiple previous commits, it was used only with -device qxl(-vga), but for some QEMUs (< 1.6) we need to add this functionality when using -vga qxl as well. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283207 Signed-off-by: Martin Kletzander --- v2:

Re: [libvirt] [PATCH v2 1/4] conf: move seclabel for chardev source to the correct sturcture

On 06/15/2017 02:39 AM, Pavel Hrdina wrote: > On Tue, Jun 13, 2017 at 12:35:10PM -0400, John Ferlan wrote: >> >> >> On 05/29/2017 10:31 AM, Pavel Hrdina wrote: >>> Signed-off-by: Pavel Hrdina >>> --- >>> >>> Notes: >>> new in v2 >>> >>> src/conf/domain_conf.c |

Re: [libvirt] [PATCH] hacking: Improve 'git send-email' documentation

On Thu, Jun 15, 2017 at 11:31:43AM +0800, Andrea Bolognani wrote: > For the benefit of first time contributors, we point out that 'git > send-email' might have to be installed separately; however, we omit > the fact that some configuration will likely be needed before it > can successfully deliver

Re: [libvirt] [PATCH] qemu: Pass the number of heads even with -vga qxl

On Wed, Jun 14, 2017 at 04:48:10PM +0200, Ján Tomko wrote: On Wed, Jun 14, 2017 at 03:56:15PM +0200, Martin Kletzander wrote: When added in multiple previous commits, it was used only with -device qxl(-vga), but for some QEMUs (< 1.6) we need to add this functionality when using -vga qxl as

Re: [libvirt] [PATCH 2/3] qemuDomainGetPreservedMounts: Prune nested mount points

On 06/14/2017 09:52 PM, John Ferlan wrote: > > > On 06/12/2017 11:57 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1431112 >> >> There can be nested mount points. For instance /dev/shm/blah can >> be a mount point and /dev/shm too. It doesn't make much sense to >>

Re: [libvirt] [PATCH 1/3] qemuDomainBuildNamespace: Clean up temp files

On 06/14/2017 09:50 PM, John Ferlan wrote: > > > On 06/12/2017 11:57 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1431112 >> >> After 290a00e41d we know how to deal with file mount points. >> However, when cleaning up the temporary location for preserved >> mount

Re: [libvirt] [PATCH 3/3] qemuDomainGetPreservedMounts: Fix suffixes for corner cases

On 06/14/2017 09:58 PM, John Ferlan wrote: > > > On 06/12/2017 11:57 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1431112 >> >> Imagine a FS mounted on /dev/blah/blah2. Our process of creating >> suffix for temporary location where all the mounted filesystems >> are

Re: [libvirt] RFC: Creating mediated devices with libvirt

On Thu, Jun 15, 2017 at 12:06:43AM +0200, Erik Skultety wrote: > Hi all, > > so there's been an off-list discussion about finally implementing creation of > mediated devices with libvirt and it's more than desired to get as many > opinions > on that as possible, so please do share your ideas.

Re: [libvirt] [PATCH 1/2] util: implement virStrToDoubleSafe().

On Wed, Jun 14, 2017 at 01:24:42PM -0300, Julio Faracco wrote: Following the GNU Documentation, functions to convert double/float to string and vice versa, use the locale to set the mantissa separator. Some languages use comma and other use dot as a separator. For example: 1,212.67 (en_US) =

Re: [libvirt] [PATCH] hacking: Improve 'git send-email' documentation

On Thu, Jun 15, 2017 at 11:31:43AM +0800, Andrea Bolognani wrote: For the benefit of first time contributors, we point out that 'git send-email' might have to be installed separately; however, we omit the fact that some configuration will likely be needed before it can successfully deliver

Re: [libvirt] [PATCH v2 4/4] security: don't relabel chardev source if virtlogd is used as stdio handler

On Tue, Jun 13, 2017 at 08:00:41PM -0400, John Ferlan wrote: > > > On 05/29/2017 10:31 AM, Pavel Hrdina wrote: > > In the case that virtlogd is used as stdio handler we pass to QEMU > > only FD to a PIPE connected to virtlogd instead of the file itself. > > > > Resolves:

Re: [libvirt] [PATCH v2 3/4] qemu: propagate chardevStdioLogd to qemuBuildChrChardevStr

On Tue, Jun 13, 2017 at 03:12:59PM -0400, John Ferlan wrote: > > Would be nice to say something about what the commit does and why here. > The title is partially self explanatory, but the devil is in the details. I'll add some commit message. Thanks, Pavel signature.asc Description: Digital

Re: [libvirt] [PATCH v2 1/4] conf: move seclabel for chardev source to the correct sturcture

On Tue, Jun 13, 2017 at 12:35:10PM -0400, John Ferlan wrote: > > > On 05/29/2017 10:31 AM, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > > > Notes: > > new in v2 > > > > src/conf/domain_conf.c | 46 > >