Re: [libvirt] [PATCH v3 13/26] conf: Parse and format

On 06/23/2017 11:03 AM, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > docs/formatdomain.html.in | 5 + > docs/schemas/domaincommon.rng | 5 + > src/conf/domain_conf.c| 24 > src/conf/domain_conf.h| 1

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

On Thu, Jun 22, 2017 at 8:30 AM, Andrea Bolognani wrote: > On Wed, 2017-06-07 at 23:13 +0200, Christoffer Dall wrote: >> The function to check if -chardev is supported by QEMU was written a >> long time ago, where adding chardevs did not make sense on the fixed ARM >>

Re: [libvirt] [PATCH v3 03/26] conf: Make virDomainPCIAddressFlagsCompatible() private

On 06/23/2017 11:03 AM, Andrea Bolognani wrote: > There are no external users. > > Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump > --- > src/conf/domain_addr.c | 2 +- > src/conf/domain_addr.h | 8 > src/libvirt_private.syms | 1 -

Re: [libvirt] [PATCH v3 05/26] qemu: Clean up qemuDomainAttachHostPCIDevice()

On 06/23/2017 11:03 AM, Andrea Bolognani wrote: > We use hostdev->info frequently enough that having > a shorter name for it makes the code more readable. > We will also be adding even more uses later on. > > Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump

Re: [libvirt] [PATCH] Fix conditional check for DBus

On Fri, Jun 23, 2017 at 04:22:52PM +0100, Daniel P. Berrange wrote: > The DBus conditional was renamed way back: > > commit da77f04ed5fa0731d50b947be8c739bdbf8121ad > Author: Daniel P. Berrange > Date: Thu Sep 20 15:05:39 2012 +0100 > > Convert HAVE_DBUS to

[libvirt] [PATCH] Improve logging of shutdown inhibitor

The log category for virnetdaemon.c was mistakenly set to rpc.netserver. Some useful info about the inhibitor file descriptor was also never logged. Signed-off-by: Daniel P. Berrange --- src/rpc/virnetdaemon.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

[libvirt] [PATCH] Fix conditional check for DBus

The DBus conditional was renamed way back: commit da77f04ed5fa0731d50b947be8c739bdbf8121ad Author: Daniel P. Berrange Date: Thu Sep 20 15:05:39 2012 +0100 Convert HAVE_DBUS to WITH_DBUS but the shutdown inhibit code was not updated. Thus libvirt was never

[libvirt] [PATCH v3 16/26] qemu: Introduce QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE

This new capability can be used to detect whether a QEMU binary supports the spapr-pci-host-bridge controller. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_capabilities.c | 2 ++

[libvirt] [PATCH v3 13/26] conf: Parse and format

Signed-off-by: Andrea Bolognani --- docs/formatdomain.html.in | 5 + docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c| 24 src/conf/domain_conf.h| 1 + 4 files changed, 35 insertions(+) diff --git

[libvirt] [PATCH v3 02/26] conf: Make virDomainPCIAddressSetGrow() private

There are no external users. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/conf/domain_addr.c | 2 +- src/conf/domain_addr.h | 5 - src/libvirt_private.syms | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git

[libvirt] [PATCH v3 14/26] conf: Add 'spapr-pci-host-bridge' controller model

Adding it to the virDomainControllerPCIModelName enumeration is enough for existing code to handle it, so parsing and formatting will work without further tweaking. Signed-off-by: Andrea Bolognani --- docs/schemas/domaincommon.rng | 2 ++ src/conf/domain_conf.c| 1 +

[libvirt] [PATCH v3 12/26] qemu: Relax pci-root index requirement for pSeries guests

pSeries guests will soon be allowed to have multiple PHBs (pci-root controllers), meaning the current check on the controller index no longer applies to them. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_domain.c | 11

[libvirt] [PATCH v3 18/26] qemu: Use multiple PHBs for pSeries guests

Additional PHBs (pci-root controllers) will be created for the guest using the spapr-pci-host-bridge QEMU device, if available; the implicit default PHB, while present in the guest configuration, will be skipped. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1431193 Signed-off-by: Andrea

[libvirt] [PATCH v3 11/26] conf: Move index number checking to drivers

pSeries guests will soon be allowed to have multiple PHBs (pci-root controllers), which of course means that all but one of them will have a non-zero index; hence, we'll need to relax the current check. However, right now the check is performed in the conf module, which is generic rather than

[libvirt] [PATCH v3 07/26] tests: Mock IOMMU groups

Later on we're going to need access to information about IOMMU groups for host devices. Implement the support in virpcimock, and start using that mock library in a few QEMU test cases. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump ---

[libvirt] [PATCH v3 24/26] conf: Implement isolation rules

These rules will make it possible for libvirt to automatically assign PCI addresses in a way that respects any isolation constraints devices might have. Signed-off-by: Andrea Bolognani --- src/conf/domain_addr.c | 104 ++--- 1

[libvirt] [PATCH v3 25/26] qemu: Isolate hostdevs on pSeries guests

All the pieces are now in place, so we can finally start using isolation groups to achieve our initial goal, which is separating hostdevs from emulated PCI devices while keeping hostdevs that belong to the same host IOMMU group together. Resolves:

[libvirt] [PATCH v3 26/26] news: Update for multiple PHBs and hostdev isolation

Signed-off-by: Andrea Bolognani --- docs/news.xml | 21 + 1 file changed, 21 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 27562e1..d70ba08 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -46,6 +46,27 @@ select a boot entry.

[libvirt] [PATCH v3 23/26] conf: Introduce isolation groups

Isolation groups will eventually allow us to make sure certain devices, eg. PCI hostdevs, are assigned to guest PCI buses in a way that guarantees improved isolation, error detection and recovery for machine types and hypervisors that support it, eg. pSeries guest on QEMU. Signed-off-by: Andrea

[libvirt] [PATCH v3 22/26] qemu: Use PHBs when extending the guest PCI topology

When looking for slots suitable for a PCI device, libvirt might need to add an extra PCI controller: for pSeries guests, we want that extra controller to be a PHB (pci-root) rather than a PCI bridge. Signed-off-by: Andrea Bolognani --- src/conf/domain_addr.c

[libvirt] [PATCH v3 20/26] tests: Add baseline tests for automatic PHB usage

These tests demonstrate that, while it's now possible for the user to create PHB explicitly and manually assign devices to them, libvirt still defaults to extending the guest PCI topology using PCI bridges and making suboptimal device placement choices. The next few commits will improve on these

[libvirt] [PATCH v3 21/26] qemu: Use PHBs to fill holes in PCI bus numbering

PCI bus has to be numbered sequentially, and no index can be missing, so libvirt will fill in the blanks automatically for the user. Up until now, it has done so using either pci-bridge, for machine types based on legacy PCI, or pcie-root-port, for machine types based on PCI Express. Neither

[libvirt] [PATCH v3 19/26] tests: Add tests for pSeries guests with multiple PHBs

Signed-off-by: Andrea Bolognani --- .../qemuxml2argv-pseries-phb-default-missing.args | 22 +++ .../qemuxml2argv-pseries-phb-default-missing.xml | 16 +++ .../qemuxml2argv-pseries-phb-simple.args | 22 +++

[libvirt] [PATCH v3 17/26] qemu: Deal with PHB naming conventions

Usually, a controller with alias 'x' will create a bus with the same name; however, the bus created by a PHBs with alias 'x' will be named 'x.0' instead, so we need to account for that. As an exception to the exception, the implicit PHB that's added automatically to every pSeries guest creates

[libvirt] [PATCH v3 15/26] qemu: Automatically pick target index and model for pci-root controllers

pSeries guests will soon need the new information; luckily, we can figure it out automatically most of the time, so users won't have to worry about it. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain_address.c | 88 +-

[libvirt] [PATCH v3 09/26] qemu: Allow qemuBuildControllerDevStr() to return NULL

We will soon need to be able to return a NULL pointer without the caller considering that an error: to make it possible, change the return type to int and use an out parameter for the string instead. Add some documentation for the function as well. Signed-off-by: Andrea Bolognani

[libvirt] [PATCH v3 10/26] qemu: Tweak index number checking

Moving the check and rewriting it this way doesn't alter the current behavior, but will allow us to special-case pci-root down the line. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_command.c | 26 -- 1

[libvirt] [PATCH v3 04/26] conf: Tweak virDomainPCIAddressGetNextAddr() signature

Move @function after @flags to match other functions in the same module like virDomainPCIAddressReserveNextAddr(). Also move virDomainPCIAddressReserveNextAddr() closer to virDomainPCIAddressReserveAddr() in the header file. Signed-off-by: Andrea Bolognani Reviewed-by:

[libvirt] [PATCH v3 05/26] qemu: Clean up qemuDomainAttachHostPCIDevice()

We use hostdev->info frequently enough that having a shorter name for it makes the code more readable. We will also be adding even more uses later on. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_hotplug.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[libvirt] [PATCH v3 06/26] tests: Update qemumemlock data

Use 0001:01:00.0 instead of :04:02.0 as the source address for the host device. This doesn't change anything at the moment, but it will make a difference later on. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump ---

[libvirt] [PATCH v3 01/26] conf: Remove obsolete comment

The virDomainDeviceInfoIsSet() function no longer exists. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/conf/device_conf.h | 4 1 file changed, 4 deletions(-) diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h index

[libvirt] [PATCH v3 08/26] conf: Simplify slot allocation

The current algorithm for slot allocation tries to be clever and avoid looking at buses / slots more than once unless it's necessary. Unfortunately that makes the code more complex, and it will cause problem later on in some situations unless even more complex code is added. Since the performance

[libvirt] [PATCH v3 03/26] conf: Make virDomainPCIAddressFlagsCompatible() private

There are no external users. Signed-off-by: Andrea Bolognani --- src/conf/domain_addr.c | 2 +- src/conf/domain_addr.h | 8 src/libvirt_private.syms | 1 - 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/conf/domain_addr.c

[libvirt] [PATCH v3 00/26] Multiple PHBs and hostdev isolation for pSeries guests

Changes from [v2]: * support hot(un)plug properly; * add documentation. Changes from [v1]: * address review comments; * implement a much better isolation algorithm that doesn't require parsing and formatting the isolation group and can handle more dynamic scenarios, such as

[libvirt] [PATCH 1/6] lib: Remove misplaced and redundant comments

It's obvious that unsigned long long is 64 bit and also our web page generator would misplace the comment after the return value due to the way it's parsing them. --- src/libvirt-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libvirt-domain.c

[libvirt] [PATCH 4/6] storage: Make virStorageFileReadHeader more universal

Allow specifying offset to read an arbitrary position in the file. This warrants a rename to virStorageFileRead. --- src/qemu/qemu_driver.c| 3 +-- src/storage/storage_backend.h | 9 + src/storage/storage_backend_fs.c | 20 +--

[libvirt] [PATCH 6/6] qemu: Support only raw volumes in qemuDomainBlockPeek

The API documents that it peeks into the VM disk. We can't do that currently for non raw images so report an error. --- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 115368d1d..53655749b 100644 ---

[libvirt] [PATCH 5/6] qemu: Use storage driver APIs in qemuDomainBlockPeek

Refactor the access to storage driver usage along with qemuDomainStorageFileInit which ensures that we access the file with correct DAC uid/gid. --- src/qemu/qemu_driver.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 2/6] tests: storage: Fully register storage driver

Use the full storage driver registration method that also fails if one of the storage backends is not present. This makes the test fail if a submodule fails registration, which is useful for testing. Additionally return EXIT_FAILURE as usual in tests rather than -1. --- tests/virstoragetest.c |

[libvirt] [PATCH 0/6] qemu: Clean up storage file access

A collection of few cleanups and bugfixes. Peter Krempa (6): lib: Remove misplaced and redundant comments tests: storage: Fully register storage driver storage: Split out virStorageSource accessors to separate file storage: Make virStorageFileReadHeader more universal qemu: Use storage

[libvirt] [PATCH 3/6] storage: Split out virStorageSource accessors to separate file

The helper methods for actually accessing the storage objects don't really belong to the main storage driver implementation file. Split them out. --- po/POTFILES.in| 1 + src/Makefile.am | 1 + src/qemu/qemu_domain.c| 1 + src/qemu/qemu_driver.c

Re: [libvirt] [RFC PATCH v1 4/4] xlconfigtest: add tests for numa cell sibling distances

On Thu, 22 Jun 2017 16:16:16 +0100 Joao Martins wrote: > On 06/12/2017 07:54 PM, Wim Ten Have wrote: > > From: Wim ten Have > > > > Test a bidirectional xen-xl domxml to and from native for numa > > support administration as brought under

Re: [libvirt] [PATCH v2] util: Extract locale-related fixes into separate functions

On Fri, Jun 23, 2017 at 02:32:39PM +0200, Peter Krempa wrote: From: Martin Kletzander Signed-off-by: Martin Kletzander --- src/util/virstring.c | 114 +-- 1 file changed, 75 insertions(+), 39 deletions(-)

Re: [libvirt] [PATCH v2 0/2] qemu: allow hotplugging disks with duplicate WWNs

On Fri, Jun 23, 2017 at 02:16:44PM +0200, Peter Krempa wrote: v2 contains a test as requested. Peter Krempa (2): Revert "qemu: Check duplicate WWNs also for hotplugged disks" tests: hotplug: Test disks with duplicate WWNs src/conf/domain_conf.c | 37 ---

[libvirt] [PATCH v2] util: Extract locale-related fixes into separate functions

From: Martin Kletzander Signed-off-by: Martin Kletzander --- src/util/virstring.c | 114 +-- 1 file changed, 75 insertions(+), 39 deletions(-) v2: - fixed Martin's laziness ... oh wait. diff --git

[libvirt] [PATCH v2 0/2] qemu: allow hotplugging disks with duplicate WWNs

v2 contains a test as requested. Peter Krempa (2): Revert "qemu: Check duplicate WWNs also for hotplugged disks" tests: hotplug: Test disks with duplicate WWNs src/conf/domain_conf.c | 37 --- tests/qemuhotplugtest.c| 5 ++

[libvirt] [PATCH v2 2/2] tests: hotplug: Test disks with duplicate WWNs

--- tests/qemuhotplugtest.c| 5 ++ .../qemuhotplug-disk-scsi-duplicate-wwn.xml| 8 +++ ...-live+disk-scsi-wwn+disk-scsi-duplicate-wwn.xml | 74 ++ .../qemuhotplug-base-live+disk-scsi-wwn.xml| 63 ++ 4 files changed,

[libvirt] [PATCH v2 1/2] Revert "qemu: Check duplicate WWNs also for hotplugged disks"

Similarly to commit 5da28cc3069b573f54f0bcaf8eb75476bcfdc6e9 this check actually does not make sense since duplicate WWNs are used e.g. when multipathing disks. This reverts commit 780fe4e4baf7e2f10f65ba1a34f9274fc547cad2. --- src/conf/domain_conf.c | 37 - 1

Re: [libvirt] [PATCH] util: Extract locale-related fixes into separate functions

On Fri, Jun 23, 2017 at 12:56:10PM +0100, Daniel P. Berrange wrote: On Fri, Jun 23, 2017 at 01:51:41PM +0200, Martin Kletzander wrote: On Fri, Jun 23, 2017 at 10:45:30AM +0100, Daniel P. Berrange wrote: > On Fri, Jun 23, 2017 at 11:42:01AM +0200, Martin Kletzander wrote: > > On Fri, Jun 23,

Re: [libvirt] [PATCH] util: Extract locale-related fixes into separate functions

On Fri, Jun 23, 2017 at 01:51:41PM +0200, Martin Kletzander wrote: > On Fri, Jun 23, 2017 at 10:45:30AM +0100, Daniel P. Berrange wrote: > > On Fri, Jun 23, 2017 at 11:42:01AM +0200, Martin Kletzander wrote: > > > On Fri, Jun 23, 2017 at 09:32:07AM +0100, Daniel P. Berrange wrote: > > > > On Fri,

Re: [libvirt] [PATCH] util: Extract locale-related fixes into separate functions

On Fri, Jun 23, 2017 at 10:45:30AM +0100, Daniel P. Berrange wrote: On Fri, Jun 23, 2017 at 11:42:01AM +0200, Martin Kletzander wrote: On Fri, Jun 23, 2017 at 09:32:07AM +0100, Daniel P. Berrange wrote: > On Fri, Jun 23, 2017 at 10:21:32AM +0200, Martin Kletzander wrote: > > On Thu, Jun 22,

Re: [libvirt] [PATCH] virNetDevOpenvswitchInterfaceStats: Be more forgiving when fetching stats

On 06/23/2017 11:32 AM, Martin Kletzander wrote: > On Thu, Jun 22, 2017 at 03:44:46PM +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1461270 >> >> When fetching stats for a vhost-user type of interface, we run >> couple of ovs-vsctl commands and parse their output.

Re: [libvirt] [PATCH] util: Extract locale-related fixes into separate functions

On Fri, Jun 23, 2017 at 11:42:01AM +0200, Martin Kletzander wrote: > On Fri, Jun 23, 2017 at 09:32:07AM +0100, Daniel P. Berrange wrote: > > On Fri, Jun 23, 2017 at 10:21:32AM +0200, Martin Kletzander wrote: > > > On Thu, Jun 22, 2017 at 03:49:03PM +0200, Peter Krempa wrote: > > > > On Thu, Jun

Re: [libvirt] [PATCH] util: Extract locale-related fixes into separate functions

On Fri, Jun 23, 2017 at 09:32:07AM +0100, Daniel P. Berrange wrote: On Fri, Jun 23, 2017 at 10:21:32AM +0200, Martin Kletzander wrote: On Thu, Jun 22, 2017 at 03:49:03PM +0200, Peter Krempa wrote: > On Thu, Jun 22, 2017 at 14:36:53 +0200, Martin Kletzander wrote: > > Signed-off-by: Martin

Re: [libvirt] [PATCH] events: Avoid double free possibility on remote call failure

On 06/23/2017 12:10 AM, John Ferlan wrote: > If a remote call fails during event registration (more than likely from > a network failure or remote libvirtd restart timed just right), then when > calling the virObjectEventStateDeregisterID we don't want to call the > registered @freecb function

Re: [libvirt] [PATCH v4] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

On Thu, Jun 22, 2017 at 06:21:49PM -0400, John Ferlan wrote: [...] There was no change, it is an additional variable, the original one is below. The number of differences would be the same, I believe. If edit the file and change "xml" to "xmlFile" and change the 3 changed xml variable

Re: [libvirt] [PATCH] virNetDevOpenvswitchInterfaceStats: Be more forgiving when fetching stats

On Thu, Jun 22, 2017 at 03:44:46PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1461270 When fetching stats for a vhost-user type of interface, we run couple of ovs-vsctl commands and parse their output. However, not all stats exist at all times, for instance

Re: [libvirt] RFC: Creating mediated devices with libvirt

On Thu, Jun 22, 2017 at 05:57:34PM -0400, John Ferlan wrote: > > > On 06/14/2017 06:06 PM, Erik Skultety wrote: > > Hi all, > > > > so there's been an off-list discussion about finally implementing creation > > of > > mediated devices with libvirt and it's more than desired to get as many > >

Re: [libvirt] [PATCH] util: Force reading of meta data to get encryption capacity value

On 06/15/2017 09:31 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1371892 > > As it turns out the volume create, build, and refresh path was not peeking > at the meta data, so immediately after a create operation the value displayed > for capacity was still incorrect.

Re: [libvirt] RFC: Creating mediated devices with libvirt

[...] > >> So, just for clarification of the concept, the device with ^this UUID will > >> have > >> had to be defined by the nodedev API by the time we start to edit the > >> domain > >> XML in this manner in which case the only thing the autocreate=yes would > >> do is > >> to actually create

Re: [libvirt] [libvirt-php PATCH 0/7] add bindings for NWFilter APIs

On 06/22/2017 09:14 PM, Dawid Zamirski wrote: > Hello, > > This series adds support for libvirt's virNWFilter* APIs. Since it > introduces new resource type, I took the opportunity to cleanup the > driver code a little: > > * in patches 1-3: added macros to take care of the differences in how >

Re: [libvirt] [libvirt-php PATCH 6/7] add nwfilter resource type

On 06/22/2017 09:14 PM, Dawid Zamirski wrote: > --- > src/libvirt-php.c | 61 > +-- > src/libvirt-php.h | 7 +++ > 2 files changed, 66 insertions(+), 2 deletions(-) > > diff --git a/src/libvirt-php.c b/src/libvirt-php.c > index

Re: [libvirt] [PATCH] util: Extract locale-related fixes into separate functions

On Fri, Jun 23, 2017 at 10:21:32AM +0200, Martin Kletzander wrote: > On Thu, Jun 22, 2017 at 03:49:03PM +0200, Peter Krempa wrote: > > On Thu, Jun 22, 2017 at 14:36:53 +0200, Martin Kletzander wrote: > > > Signed-off-by: Martin Kletzander > > > --- > > > src/util/virstring.c

Re: [libvirt] [PATCH v3 0/2] Adding locale support for virStrToDouble().

On Thu, Jun 22, 2017 at 05:55:12PM -0300, Julio Faracco wrote: Twos question related to this topic: 1. Is virstringtest missing some important tests from virstring.c? I'm not seeing vir{StrToDouble|DoubleToStr}... 2. Should locale be considered during the test phase too? Yep, it would be nice

Re: [libvirt] [PATCH] util: Extract locale-related fixes into separate functions

On Thu, Jun 22, 2017 at 03:49:03PM +0200, Peter Krempa wrote: On Thu, Jun 22, 2017 at 14:36:53 +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/util/virstring.c | 96 1 file changed, 60

Re: [libvirt] libvirt-2.0.0 build error (hidden symbol libvirt_event_poll_update_handle_semaphore)

On 06/23/2017 04:33 AM, longguang.yue wrote: > Hi, all: > i back port a patch which make qemu depends on util directory. > so i correct its dependency by applying a patch. but another error occur. > the patch is : > --- libvirt-2.0.0/src/Makefile.am 2016-06-27 22:12:20.523191076 +0800