Re: [libvirt] [PATCH] qemu: Take all PHBs into account while calculating memlock limits

On 07/03/2017 09:51 AM, Andrea Bolognani wrote: > On Fri, 2017-06-30 at 13:56 +0530, Shivaprasad G Bhat wrote: >> -/* TODO: Detect at runtime once we start using more than just >> - * the default PCI Host Bridge */ >> -nPCIHostBridges = 1; >> +for (i = 0; i <

Re: [libvirt] [PATCH v3 19/26] tests: Add tests for pSeries guests with multiple PHBs

On 07/04/2017 09:19 AM, Andrea Bolognani wrote: > On Fri, 2017-06-23 at 23:03 +0800, Andrea Bolognani wrote: >> Signed-off-by: Andrea Bolognani >> --- >> .../qemuxml2argv-pseries-phb-default-missing.args | 22 +++ >>

Re: [libvirt] [PATCH v3 13/26] conf: Parse and format

On 07/04/2017 07:32 AM, Andrea Bolognani wrote: > On Fri, 2017-06-30 at 17:10 +0530, Shivaprasad bhat wrote: >>> @@ -9348,6 +9351,23 @@ virDomainControllerDefParseXML(xmlNodePtr node, >>> goto error; >>> } >>> } >>> +if (idx) { >>> +if

Re: [libvirt] Release of libvirt-3.5.0

On Wed, Jul 05, 2017 at 01:29:08PM -0600, Jim Fehlig wrote: > On 07/04/2017 03:04 PM, Daniel Veillard wrote: > > I also made a release 3.5.0 of the python bindings with minimal changes > > compared to 3.4.0, it can be found at: > > > > ftp://libvirt.org/libvirt/python/ > > FYI, I don't see

Re: [libvirt] libvirt binding for DBUS

2017-07-05 15:51 GMT+03:00 Vasiliy Tolstov : > Very good ! Do you have time roadmap for this code generator? I'm > happy to replace own generated go binding to dbus based. Also can you provide minimal example to list domains or create? -- Vasiliy Tolstov, e-mail:

Re: [libvirt] Release of libvirt-3.5.0

On 07/04/2017 03:04 PM, Daniel Veillard wrote: I also made a release 3.5.0 of the python bindings with minimal changes compared to 3.4.0, it can be found at: ftp://libvirt.org/libvirt/python/ FYI, I don't see the 3.5.0 tarball there. Regards, Jim -- libvir-list mailing list

Re: [libvirt] [PATCH] autogen.sh: tell user the correct make command

On 07/05/2017 11:32 AM, Andrea Bolognani wrote: > On Tue, 2017-07-04 at 16:22 +0100, Daniel P. Berrange wrote: >> When autogen.sh finishes it helpfully prints >> >>"Now type 'make' to compile libvirt." >> >> which is fine if on a host with GNU make, but on *BSD running >> 'make' will end

Re: [libvirt] [PATCH] autogen.sh: tell user the correct make command

On Tue, 2017-07-04 at 16:22 +0100, Daniel P. Berrange wrote: > When autogen.sh finishes it helpfully prints >  >   "Now type 'make' to compile libvirt." >  > which is fine if on a host with GNU make, but on *BSD running > 'make' will end in tears. We should tell users to run 'gmake' > on these

Re: [libvirt] libvirt binding for DBUS

2017-07-04 17:55 GMT+03:00 Daniel P. Berrange : >> Currently the binding is written manually and only few APIs are >> supported, however the ultimate goal is to write a code generator >> and ensure that all APIs are covered by this binding (similarly to the >> python binding).

Re: [libvirt] [PATCH v3 1/4] block: Pass bdrv_* methods to bs->file by default

[adding libvirt for block size discussion] On 07/04/2017 04:44 AM, Kevin Wolf wrote: > Am 04.07.2017 um 10:40 hat Manos Pitsidianakis geschrieben: >> The following functions fail if bs->drv does not implement them: >> >> bdrv_probe_blocksizes >> bdrv_probe_geometry >> bdrv_truncate >>

Re: [libvirt] [PATCH go-xml] Add support for device RNG

On Tue, Jul 04, 2017 at 10:16:07AM +0200, Thomas Hipp wrote: > Add support for device RNG (random number generator), and add test code. > > Signed-off-by: Thomas Hipp > --- > domain.go | 34 +++ > domain_test.go | 85 >

[libvirt] [PATCH v2 5/5] Prevent more compiler optimization of mockable functions

Currently all mockable functions are annotated with the 'noinline' attribute. This is insufficient to guarantee that a function can be reliably mocked with an LD_PRELOAD. The C language spec allows the compiler to assume there is only a single implementation of each function. It can thus do things

[libvirt] [PATCH v2 4/5] Remove incorrectly used TODO macro

The TODO macro expands to an fprintf() call and is used in several places in the Xen driver. Anything that wishes to print such debug messages should use the logging macros. In this case though, all the places in the Xen driver should have been raising a formal libvirt error instead. Add proper

[libvirt] [PATCH v2 3/5] Remove network constants out of internal.h

The HOST_NAME_MAX, INET_ADDRSTRLEN and VIR_LOOPBACK_IPV4_ADDR constants are only used by a handful of files, so are better kept in virsocketaddr.h Signed-off-by: Daniel P. Berrange --- src/internal.h | 16 src/libxl/libxl_conf.c

[libvirt] [PATCH v2 1/5] Remove duplicate define of __GNUC_PREREQ

Back in this commit: commit b436a8ae5ccb04f8cf893d882d52ab5efc713307 Author: Fabian Freyer Date: Thu Jun 9 00:50:35 2016 + gnulib: add getopt module config-post.h was modified to define __GNUC_PREREQ, but the original definition was never

[libvirt] [PATCH v2 2/5] Require use of GCC 4.4 or CLang compilers

We only ever test libvirt with GCC or CLang which provides a GCC compatible compilation environment. Between them, these compilers cover every important operating system platform, even Windows. Mandate their use to make it explicit that we don't care about compilers like Microsoft VCC or other

[libvirt] [PATCH v2 0/5] Misc cleanups for internal.h & fix tests with CLang

When writing the fix for test suite mocking under CLang I found a bunch of cruft in internal.h The first four patches thus cleanup up internal.h. We then add the extra annotations requird to prevent CLang optimizer breaking mock overrides. Changed in v2: - Fixed version check to find clang -

[libvirt] [PATCH v3 2/4] conf: Parse virtio-crypto in the domain XML

This patch parse the domain XML with virtio-crypto support, the virtio-crypto XML looks like this: Signed-off-by: Longpeng(Mike) --- src/conf/domain_conf.c | 213 - src/conf/domain_conf.h | 32 +++

[libvirt] [PATCH v3 1/4] docs: schema: Add basic documentation for the virtual

This patch documents XML elements used for support of virtual crypto devices. In the devices section in the domain XML users may specify: to enable the crypto device for guests. Signed-off-by: Longpeng(Mike) --- docs/formatdomain.html.in | 61

Re: [libvirt] [PATCH 2/4] Require use of GCC 4.4 or CLang compilers

On Wed, Jul 05, 2017 at 11:34:10AM +0100, Daniel P. Berrange wrote: > We only ever test libvirt with GCC or CLang which provides a > GCC compatible compilation environment. Between them, these > compilers cover every important operating system platform, > even Windows. > > Mandate their use to

[libvirt] [PATCH v3 4/4] tests: Add testcase for virtio-crypto XML parsing

Adds XML parsing and qemu commandline tests for the virtio-crypto device support. Signed-off-by: Longpeng(Mike) --- tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml| 2 ++ tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 2 ++

[libvirt] [PATCH v3 3/4] qemu: Implement support for 'builtin' backend for virtio-crypto

This patch implements support for the virtio-crypto-pci device and the builtin backend in qemu. Two capabilities bits are added to track support for those: QEMU_CAPS_DEVICE_VIRTIO_CRYPTO - for the device support and QEMU_CAPS_OBJECT_CRYPTO_BUILTIN - for the backend support. qemu is invoked with

[libvirt] [PATCH v3 0/4] Virtio-crypto device support

As virtio-crypto has been supported in QEMU 2.8 and the frontend driver has been merged in linux 4.10, so it's necessary to support virtio-crypto in libvirt. --- Hi guys, Sorry for the long delay... Changes since v2: - PATCH 1: modify docs as Martin & Boris's suggestion. [Martin & Boris] -

[libvirt] [PATCH 3/4] Remove network constants out of internal.h

The HOST_NAME_MAX, INET_ADDRSTRLEN and VIR_LOOPBACK_IPV4_ADDR constants are only used by a handful of files, so are better kept in virsocketaddr.h Signed-off-by: Daniel P. Berrange --- src/internal.h | 16 src/libxl/libxl_conf.c

[libvirt] [PATCH 4/4] Remove incorrectly used TODO macro

The TODO macro expands to an fprintf() call and is used in several places in the Xen driver. Anything that wishes to print such debug messages should use the logging macros. In this case though, all the places in the Xen driver should have been raising a formal libvirt error instead. Add proper

[libvirt] [PATCH 0/4] Misc cleanups for internal.h

Looking at internal.h there was some cruft we could usefully clean out. Daniel P. Berrange (4): Remove duplicate define of __GNUC_PREREQ Require use of GCC 4.4 or CLang compilers Remove network constants out of internal.h Remove incorrectly used TODO macro config-post.h

[libvirt] [PATCH 1/4] Remove duplicate define of __GNUC_PREREQ

Back in this commit: commit b436a8ae5ccb04f8cf893d882d52ab5efc713307 Author: Fabian Freyer Date: Thu Jun 9 00:50:35 2016 + gnulib: add getopt module config-post.h was modified to define __GNUC_PREREQ, but the original definition was never

[libvirt] [PATCH 2/4] Require use of GCC 4.4 or CLang compilers

We only ever test libvirt with GCC or CLang which provides a GCC compatible compilation environment. Between them, these compilers cover every important operating system platform, even Windows. Mandate their use to make it explicit that we don't care about compilers like Microsoft VCC or other

[libvirt] [PATCH v3 0/7] Add new APIs to edit xml configuration of managed save state of a domain

managedsave command offloads the user from managing the save state file. It does not need the user to specify saved state file location, all it takes is domain name to identify. This makes it much more comfortable to use in emergency where immediate shutdowm is needed. But it doesn't provide a way

[libvirt] [PATCH v3 4/7] qemu: Implement qemuDomainManagedSaveDefineXML

This commit adds qemu driver implementation to edit xml configuration of managed save state file of a domain. Signed-off-by: Kothapally Madhu Pavan --- src/qemu/qemu_driver.c | 41 + 1 file changed, 41 insertions(+) diff --git

[libvirt] [PATCH v3 7/7] virsh: Implement managedsave-edit command

Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan --- tools/virsh-domain.c | 72 tools/virsh.pod | 21 +++ 2 files changed, 93 insertions(+)

[libvirt] [PATCH v3 2/7] lib: Add API to edit domain's managed save state xml configuration

Similar to domainSaveImageDefineXML this commit adds domainManagedSaveDefineXML API which allows to edit domain's managed save state xml configuration. Signed-off-by: Kothapally Madhu Pavan --- include/libvirt/libvirt-domain.h | 4 +++ src/driver-hypervisor.h

[libvirt] [PATCH v3 6/7] virsh: Implement managedsave-dumpxml command

Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan --- tools/virsh-domain.c | 56 tools/virsh.pod | 6 ++ 2 files changed, 62 insertions(+) diff --git

[libvirt] [PATCH v3 5/7] virsh: Implement managedsave-define command

Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan --- tools/virsh-domain.c | 79 tools/virsh.pod | 14 ++ 2 files changed, 93 insertions(+) diff

[libvirt] [PATCH v3 1/7] lib: Add API to dump xml configuration of managed save state domain

Similar to domainSaveImageGetXMLDesc this commit adds domainManagedSaveGetXMLDesc API which allows to get the xml of managed save state domain. Signed-off-by: Kothapally Madhu Pavan --- include/libvirt/libvirt-domain.h | 2 ++ src/driver-hypervisor.h | 5

[libvirt] [PATCH v3 3/7] qemu: Implement qemuDomainManagedSaveGetXMLDesc

This commit adds qemu driver implementation to get xml description for managed save state domain. Signed-off-by: Kothapally Madhu Pavan --- src/qemu/qemu_driver.c | 46 ++ 1 file changed, 46 insertions(+) diff --git