Re: [libvirt] [PATCH v2 07/20] network: Alter virNetworkObj @class_id to be @classIdMap

On 08/15/2017 11:32 AM, Michal Privoznik wrote: > On 07/26/2017 05:05 PM, John Ferlan wrote: >> Change the variable name to be a bit more descriptive and less confusing >> when used with the data.network.actual->class_id. >> >> Signed-off-by: John Ferlan >> --- >>

Re: [libvirt] [PATCH] qemu: undefine is not allowed during domain starting up

On 07/22/2017 04:55 AM, Yi Wang wrote: > Start a domain whilst undefine it, if starting failed duing ProcessLaunch, > on which period qemu exited unexpectedly, the operation will lead to failure > of undefine the domain until libvirtd restarted. The reason is that libvirtd > will unlock vm

[libvirt] question about locking in qemuDomainObjBeginJobInternal()

Hi, I'm hitting a scenario (on libvirt 1.2.12, so yeah it's a bit old) where I'm attempting to create two domains at the same time, and they both end up erroring out with "cannot acquire state change lock": 2017-08-14T12:57:00.000 79674: warning : qemuDomainObjBeginJobInternal:1380 :

Re: [libvirt] [PATCH v2 18/20] network: Rename @filter to @aclfilter

On 08/15/2017 11:32 AM, Michal Privoznik wrote: > On 07/26/2017 05:05 PM, John Ferlan wrote: >> Rename the virNetworkObjListFilter to be virNetworkObjListACLFilter >> since that's more representative of what it is. Also modify the >> variable @filter to be @aclfilter. In the future adding the

Re: [libvirt] [PATCH v2 17/20] network: Use @maxnames instead of @nnames

On 08/15/2017 11:32 AM, Michal Privoznik wrote: > On 07/26/2017 05:05 PM, John Ferlan wrote: >> To be consistent with the API definition, use the @maxnames instead >> of @nnames when describing/comparing against the maximum names to >> be provided for the *ConnectList[Defined]Networks APIs. >>

Re: [libvirt] [PATCH v2 11/20] network: Introduce virNetworkObj{Get|Set}Autostart

On 08/15/2017 11:32 AM, Michal Privoznik wrote: > On 07/26/2017 05:05 PM, John Ferlan wrote: >> In preparation for privatizing the virNetworkObj structure, create >> accessors for the obj->autostart. >> >> Signed-off-by: John Ferlan >> --- >> src/conf/virnetworkobj.c|

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On 08/15/2017 11:47 AM, Peter Krempa wrote: > On Tue, Aug 15, 2017 at 10:02:38 -0400, John Ferlan wrote: >> On 08/15/2017 08:01 AM, Peter Krempa wrote: >>> On Mon, Aug 14, 2017 at 20:46:10 -0400, John Ferlan wrote: On 08/03/2017 04:50 AM, Peter Krempa wrote: >>> >>> [ trimmed off-topic part

Re: [libvirt] [RFC v4 00/13] qmp: query-device-slots command

On Tue, Aug 15, 2017 at 01:57:50PM -0500, Eric Blake wrote: > On 08/14/2017 04:57 PM, Eduardo Habkost wrote: > > Changelog > > - > > > > Changes v3 -> v4: > > * New compact representation of slot sets. > > * New generic code to automatically merge similar slots > > into a single entry

Re: [libvirt] [RFC v4 00/13] qmp: query-device-slots command

On 08/14/2017 04:57 PM, Eduardo Habkost wrote: > Changelog > - > > Changes v3 -> v4: > * New compact representation of slot sets. > * New generic code to automatically merge similar slots > into a single entry in the command output while keeping > implementations of the method

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On Tue, Aug 15, 2017 at 10:02:38 -0400, John Ferlan wrote: > On 08/15/2017 08:01 AM, Peter Krempa wrote: > > On Mon, Aug 14, 2017 at 20:46:10 -0400, John Ferlan wrote: > >> On 08/03/2017 04:50 AM, Peter Krempa wrote: > > > > [ trimmed off-topic part ] > > > >> NB: I didn't dig into the

Re: [libvirt] [PATCH v2 11/20] network: Introduce virNetworkObj{Get|Set}Autostart

On 07/26/2017 05:05 PM, John Ferlan wrote: > In preparation for privatizing the virNetworkObj structure, create > accessors for the obj->autostart. > > Signed-off-by: John Ferlan > --- > src/conf/virnetworkobj.c| 15 +++ > src/conf/virnetworkobj.h| 9

Re: [libvirt] [PATCH v2 07/20] network: Alter virNetworkObj @class_id to be @classIdMap

On 07/26/2017 05:05 PM, John Ferlan wrote: > Change the variable name to be a bit more descriptive and less confusing > when used with the data.network.actual->class_id. > > Signed-off-by: John Ferlan > --- > src/conf/virnetworkobj.c| 39

Re: [libvirt] [PATCH v2 18/20] network: Rename @filter to @aclfilter

On 07/26/2017 05:05 PM, John Ferlan wrote: > Rename the virNetworkObjListFilter to be virNetworkObjListACLFilter > since that's more representative of what it is. Also modify the > variable @filter to be @aclfilter. In the future adding the ability > to describe a generic @filter routine for the

Re: [libvirt] [PATCH v2 00/20] Make the virNetworkObjPtr private

On 07/26/2017 05:05 PM, John Ferlan wrote: > v1: https://www.redhat.com/archives/libvir-list/2017-May/msg00701.html > (but reviewed much more recently) > > NOTE from v1: > Patches 1-3 already pushed > > Former patch 4: > * Patch 1 (NEW) - splits out the formatting change in bridge_driver.h > *

Re: [libvirt] [PATCH v2 17/20] network: Use @maxnames instead of @nnames

On 07/26/2017 05:05 PM, John Ferlan wrote: > To be consistent with the API definition, use the @maxnames instead > of @nnames when describing/comparing against the maximum names to > be provided for the *ConnectList[Defined]Networks APIs. > > Signed-off-by: John Ferlan > ---

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On Tue, Aug 15, 2017 at 10:02:38AM -0400, John Ferlan wrote: > > > On 08/15/2017 08:01 AM, Peter Krempa wrote: > > On Mon, Aug 14, 2017 at 20:46:10 -0400, John Ferlan wrote: > >> On 08/03/2017 04:50 AM, Peter Krempa wrote: > > > > [ trimmed off-topic part ] > > > >> NB: I didn't dig into the

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On 08/15/2017 08:01 AM, Peter Krempa wrote: > On Mon, Aug 14, 2017 at 20:46:10 -0400, John Ferlan wrote: >> On 08/03/2017 04:50 AM, Peter Krempa wrote: > > [ trimmed off-topic part ] > >> NB: I didn't dig into the qemumonitorjsontest algorithm, but... >> >> While going through the common

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On Tue, Aug 15, 2017 at 03:03:07PM +0200, Michal Privoznik wrote: > On 08/15/2017 02:01 PM, Peter Krempa wrote: > > On Mon, Aug 14, 2017 at 20:46:10 -0400, John Ferlan wrote: > >> On 08/03/2017 04:50 AM, Peter Krempa wrote: > > > > [ trimmed off-topic part ] > > > >> NB: I didn't dig into the

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On Tue, Aug 15, 2017 at 15:03:07 +0200, Michal Privoznik wrote: > On 08/15/2017 02:01 PM, Peter Krempa wrote: > > On Mon, Aug 14, 2017 at 20:46:10 -0400, John Ferlan wrote: > >> On 08/03/2017 04:50 AM, Peter Krempa wrote: [...] > >> The next thing I considered was using a prime number as the

Re: [libvirt] [PATCH] qemu: Fix bug assuming usage of default UUID for certificate passphrase

On 07/21/2017 11:47 PM, John Ferlan wrote: > If an environment specific _tls_x509_cert_dir is provided, then > do not VIR_STRDUP the defaultTLSx509secretUUID as that would be > for the "default" environment and not the vnc, spice, chardev, or > migrate environments. If the environment needs a

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On 08/15/2017 02:01 PM, Peter Krempa wrote: > On Mon, Aug 14, 2017 at 20:46:10 -0400, John Ferlan wrote: >> On 08/03/2017 04:50 AM, Peter Krempa wrote: > > [ trimmed off-topic part ] > >> NB: I didn't dig into the qemumonitorjsontest algorithm, but... >> >> While going through the common object

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On Mon, Aug 14, 2017 at 20:46:10 -0400, John Ferlan wrote: > On 08/03/2017 04:50 AM, Peter Krempa wrote: [ trimmed off-topic part ] > NB: I didn't dig into the qemumonitorjsontest algorithm, but... > > While going through the common object changes, I ended up looking at and > thinking about the

Re: [libvirt] [PATCHv2 0/3] exposing busy polling support for vhost-net

On Mon, Jul 17, 2017 at 01:39:13PM +0200, Peter Krempa wrote: > On Mon, Jul 17, 2017 at 07:27:24 -0400, sferd...@redhat.com wrote: > > From: Sahid Orentino Ferdjaoui > > > > In version 2.7.0, QEMU introduced support of busy polling for > > vhost-net [0]. To avoid

[libvirt] [PATCH] libvirtd.conf: Drop max_requests

Since its introduction in f61341173bdaa2e0 it was never implemented nor there are plans to implement it. Drop it. Signed-off-by: Michal Privoznik --- daemon/libvirtd-config.c| 3 --- daemon/libvirtd-config.h| 1 - daemon/libvirtd.aug | 1 -

Re: [libvirt] [dbus PATCH 0/7] additional cleanups and improvements

On Mon, Aug 14, 2017 at 09:40:14PM -0400, John Ferlan wrote: > > > On 08/08/2017 11:25 AM, Pavel Hrdina wrote: > > Pavel Hrdina (7): > > maint: cleanup gitignore > > maint: ignore dist tarball > > build: fix distcheck > > build: move test related bits to test/Makefile.am > > maint:

Re: [libvirt] [libvirt-php][PATCH] Generate AUTHORS file

On 08/15/2017 10:39 AM, Ján Tomko wrote: > On Tue, Aug 15, 2017 at 07:43:36AM +0200, Michal Privoznik wrote: >> On 08/14/2017 05:42 PM, Ján Tomko wrote: >>> On Sat, Aug 05, 2017 at 02:29:58PM +0200, Michal Privoznik wrote: +gen-AUTHORS: +$(AM_V_GEN)if test -d $(srcdir)/.git; then \

Re: [libvirt] [libvirt-php][PATCH] Generate AUTHORS file

On Tue, Aug 15, 2017 at 07:43:36AM +0200, Michal Privoznik wrote: On 08/14/2017 05:42 PM, Ján Tomko wrote: On Sat, Aug 05, 2017 at 02:29:58PM +0200, Michal Privoznik wrote: +gen-AUTHORS: +$(AM_V_GEN)if test -d $(srcdir)/.git; then \ +out="`cd $(srcdir) && git log

[libvirt] [PATCH v2 0/2] Have qemuDomainUndefineFlags grab a job

This is v2 to: https://www.redhat.com/archives/libvir-list/2017-August/msg00222.html diff to v1: - Split qemuDomainRemoveInactive into two functions so that its safe to call it from places where we already have a job. Michal Privoznik (2): qemu: Introduce and use qemuDomainRemoveInactiveJob

[libvirt] [PATCH v2 1/2] qemu: Introduce and use qemuDomainRemoveInactiveJob

At some places we either already have synchronous job or we just released it. Also, some APIs might want to use this code without having to release their job. Anyway, the job acquire code is moved out to qemuDomainRemoveInactiveJob so that qemuDomainRemoveInactive does just what it promises.

[libvirt] [PATCH v2 2/2] qemuDomainUndefineFlags: Grab QEMU_JOB_MODIFY

This API is definitely modifying state of @vm. Therefore it should grab a job. Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH 1/2] qemuDomainUndefineFlags: Grab QEMU_JOB_MODIFY

On 08/15/2017 03:00 AM, John Ferlan wrote: > > > On 08/07/2017 08:20 AM, Michal Privoznik wrote: >> This API is definitely modifying state of @vm. Therefore it >> should grab a job. >> >> Signed-off-by: Michal Privoznik >> --- >> src/qemu/qemu_driver.c | 23