Hi Michael,
Thanks for looking at the submission. I've made the proposed changes and can
verify that the fix works. :)
There error has gone away with the container starting. Below is a snippet of
the device node from the intermediate mount namespace that eventually ends up
target container's
On 12/08/2017 09:01 AM, John Ferlan wrote:
> Commit id '46a811db07' added code to check if the filter by Name
> already existed with a different UUID, to go along with the existing
> found filter by UUID and compare the Names match thus making it
> impossible to reach this find by Name condition wi
We've been building up to this. This adds support for cputune/cachetune
settings for domains in the QEMU driver. The addition into
qemuProcessSetupVcpu() automatically adds support for hotplug. For hot-unplug
we need to remove the allocation only if all the vCPUs were unplugged. But
since the t
This test initializes capabilities from vircaps2xmldata (since it exists there
already) and then requests list of free bitmaps (all unallocated space) from
virresctrl.c
Desirable outputs are saved in virresctrldata.
Signed-off-by: Martin Kletzander
---
tests/Makefile.am
More info in the documentation, this is basically the XML parsing/formatting
support, schemas, tests and documentation for the new cputune/cachetune element
that will get used by following patches.
Signed-off-by: Martin Kletzander
---
docs/formatdomain.html.in | 54
Basically the `cpus` and `tasks` files are not needed, and I've witnessed on a
real system that the schemata file may have spaces prepended to a line, so let's
adjust at least one test so that it reflects what can happen. Also `000`
allocation is invalid and a full mask means it's all free. So ad
Signed-off-by: Martin Kletzander
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index b4d980624956..4ffa736c04c8 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,6 +35,15 @@
+
+
+ Added support f
With this commit we finally have a way to read and manipulate basic resctrl
settings. Locking is done only on exposed functions that read/write from/to
resctrlfs. Not in functions that are exposed in virresctrlpriv.h as those are
only supposed to be used from tests.
More information about how re
Signed-off-by: Martin Kletzander
---
src/libvirt_private.syms | 2 -
src/util/virresctrl.c| 132 ---
src/util/virresctrl.h| 11
3 files changed, 145 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index e95
Just to ease the review of following patches.
Signed-off-by: Martin Kletzander
---
src/conf/capabilities.c | 2 +-
src/conf/capabilities.h | 2 +-
src/util/virresctrl.c | 4 ++--
src/util/virresctrl.h | 8
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/conf/capab
So again all the reviews are incorporated. I managed to get my hands on
a machine with CAT support, so I also found out some things that needed
tweaking.
@Eli: I would still appreciate you helping with some testing as I wasn't
able to find a machine with multiple caches (sockets) and I
Signed-off-by: Martin Kletzander
---
src/conf/capabilities.c | 53 -
src/conf/capabilities.h | 2 ++
2 files changed, 28 insertions(+), 27 deletions(-)
diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c
index e93eaed2f0e0..edf9f54f7710
This will make the current functions obsolete and it will provide more
information to the virresctrl module so that it can be used later.
Signed-off-by: Martin Kletzander
---
po/POTFILES.in | 1 +
src/libvirt_private.syms | 3 +
src/util/virresctrl.c| 305 ++
On Tue, Jan 23, 2018 at 03:40:02PM +0800, Chen Hanxiao wrote:
From: Chen Hanxiao
Introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the output of `arp -an` command.
I'm not sure about the implications of this as sometimes we can't use that, but
I guess that's fine.
On Tue, Jan 23, 2018 at 05:41 PM +0100, Marc Hartmayer
wrote:
> On Tue, Jan 23, 2018 at 04:01 PM +0100, John Ferlan
> wrote:
>> On 01/23/2018 04:21 AM, Marc Hartmayer wrote:
>>> On Fri, Jan 19, 2018 at 06:23 PM +0100, John Ferlan
>>> wrote:
RFC:
https://www.redhat.com/archives/libvi
On Tue, Jan 23, 2018 at 04:01 PM +0100, John Ferlan wrote:
> On 01/23/2018 04:21 AM, Marc Hartmayer wrote:
>> On Fri, Jan 19, 2018 at 06:23 PM +0100, John Ferlan
>> wrote:
>>> RFC:
>>> https://www.redhat.com/archives/libvir-list/2018-January/msg00318.html
>>>
>>> Adjustments since RFC...
>>>
>>>
On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote:
> This extends the update hook so that it enforces a requirement to have a
> Signed-off-by line in every commit message. This can be optionally
> turned off in individual repos by setting the "hooks.allowmissingsob"
> git config va
Introduce a way to enable and disable the availability of
HTM (Hardware Transactional Memory) for pSeries guests.
Signed-off-by: Andrea Bolognani
---
The availability of the corresponding QEMU toggle is currently
crudely inferred from the version number, but there's ongoing
discussion on how to i
Now that the feature has been implemented, we
can get rid of the original feature and thus ensure all
pSeries features are grouped together in the same sub-element.
Compatibility code is provided so that existing guests can be
parsed and migrated successfully despite the change.
Signed-off-by:
We're going to introduce a number of optional, pSeries-specific
features, so we want to have a dedicated sub-element to avoid
cluttering the element.
Along with the generic framework, we also introduce the first
actual feature: HPT (Hash Page Table) tuning. This will replace
the existing feature
I consider the first 4 patches ready for inclusion, but the last
one - which is basically what justifies going through all this
trouble - is sub-optimal until more development has happened in
QEMU, so it's marked as RFC. Still, I thought I'd get the ball
rolling sooner rather than later.
Andrea Bo
Give them better names and remove some redundancy.
Signed-off-by: Andrea Bolognani
---
I would probably just squash this into the previous patch, but
I figured others would prefer it as a separate one.
...es-hpt-resizing.args => pseries-features-hpt.args} | 1 -
.../pseries-features-hpt.xml}
We're going to use the same attribute for two elements, so it
makes sense to give it its own stand-alone definition.
Signed-off-by: Andrea Bolognani
---
docs/schemas/domaincommon.rng | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/docs/schemas/domaincommon
On 01/23/2018 05:07 AM, Martin Kletzander wrote:
> On Wed, Jan 03, 2018 at 06:50:22PM -0500, John Ferlan wrote:
>>
>>
>> On 12/13/2017 10:39 AM, Martin Kletzander wrote:
>>> More info in the documentation, this is basically the XML
>>> parsing/formatting
>>> support, schemas, tests and documentat
On 01/23/2018 04:21 AM, Marc Hartmayer wrote:
> On Fri, Jan 19, 2018 at 06:23 PM +0100, John Ferlan
> wrote:
>> RFC:
>> https://www.redhat.com/archives/libvir-list/2018-January/msg00318.html
>>
>> Adjustments since RFC...
>>
>> Patches 1&2: No change, were already R-B'd
>> Patch 3: Removed code
Add a virtlogd-admin-sock can serves the admin protocol for the virtlogd
daemon and define a virtlogd:///{system,session} URI scheme for
connecting to it.
Signed-off-by: Daniel P. Berrange
---
src/Makefile.am | 1 +
src/libvirt-admin.c | 20 +++--
src/lo
With the current code it is neccessary to call
virNetDaemonNewPostExecRestart()
and then for each server that needs restarting you are supposed
to call
virNetDaemonAddSeverPostExecRestart()
This is fine if there's only ever one server, but as soon as you
have two servers it is impossible to
We don't have any per-client private data we need to persist, but the
RPC infrastructure requires that we provide the callbacks and serialize
an empty JSON object. This makes us future proof going forwards.
Signed-off-by: Daniel P. Berrange
---
src/admin/admin_server_dispatch.c | 21
When receiving multiple socket FDs from systemd, it is critical to know
what socket address each corresponds to so we can setup the right
protocols on each.
Signed-off-by: Daniel P. Berrange
---
src/libvirt_private.syms | 1 +
src/util/virutil.c | 45 ++
Signed-off-by: Daniel P. Berrange
---
daemon/libvirtd.c | 8
daemon/remote.c | 6 +++---
daemon/remote.h | 6 +++---
src/admin/admin_server_dispatch.c | 6 +++---
src/admin/admin_server_dispatch.h | 4 ++--
5 files changed, 15 insertion
The admin server functionality is a generic concept that should be wired
up into all libvirt daemons, but is currently integrated with the
libvirtd code. Move it all into the src/admin directory to prepare for
broader reuse.
Signed-off-by: Daniel P. Berrange
---
.gitignore
The initial admin protocol support was only integrated into libvirtd.
This series extracts that code so that it is reusable with all the
daemons we have (and more than we'll get).
In v2:
- Fixed completely broken post-exec restart support for admin servers
- Misc fixes from v1 review
Daniel P.
Add a virtlockd-admin-sock can serves the admin protocol for the virtlockd
daemon and define a virtlockd:///{system,session} URI scheme for
connecting to it.
Signed-off-by: Daniel P. Berrange
---
cfg.mk| 1 -
src/Makefile.am | 1 +
src/l
The virNetServer class is passing a pointer to itself to the
virNetServerClient as a 'void *' pointer. This is presumably due to fact
that the virnetserverclient.h file doesn't see the virNetServerPtr
typedef. The typedef is easily movable though, which lets us get
typesafe parameter passing, remov
The server name and client data callbacks need to be non-NULL or the
system will crash at various times. This is particularly bad when some
of the crashes only occur post-exec restart.
Signed-off-by: Daniel P. Berrange
---
src/rpc/virnetserver.h | 7 +--
src/rpc/virnetserverclient.h |
It is not possible to blindly call virNetDaemonGetServer()
because in a post-exec restart scenario, some servers may
not exist and this method will pollute the error logs.
Signed-off-by: Daniel P. Berrange
---
src/libvirt_remote.syms | 1 +
src/rpc/virnetdaemon.c | 13 +
src/rpc/vi
Signed-off-by: Daniel P. Berrange
---
src/rpc/virnetserverclient.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/rpc/virnetserverclient.h b/src/rpc/virnetserverclient.h
index 0fa8745191..14ace9e522 100644
--- a/src/rpc/virnetserverclient.h
+++ b/src/rpc/virnetserverclient.h
@@
On Tue, Jan 23, 2018 at 02:11:50PM +0100, Pavel Hrdina wrote:
> Some of the drivers are remote only, such as ESX, GSX, VPX, PHyp and
> HyperV. Currently we support only local drivers.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/main.c | 21 +
> test/libvirttest.py |
Some of the drivers are remote only, such as ESX, GSX, VPX, PHyp and
HyperV. Currently we support only local drivers.
Signed-off-by: Pavel Hrdina
---
src/main.c | 21 +
test/libvirttest.py | 2 +-
2 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/src/
On Tue, Jan 23, 2018 at 10:13:07AM +, Daniel P. Berrange wrote:
> On Mon, Jan 22, 2018 at 06:15:58PM +0100, Pavel Hrdina wrote:
> > This patch series is a proposal to how to implement libvirt connections
> > in the libvirt D-Bus binding. The design is based on a discussion with
> > Daniel and
On Tue, Jan 23, 2018 at 12:37:53PM +0100, Pavel Hrdina wrote:
> On Tue, Jan 23, 2018 at 10:12:26AM +, Daniel P. Berrange wrote:
> > On Mon, Jan 22, 2018 at 06:16:09PM +0100, Pavel Hrdina wrote:
> > > Signed-off-by: Pavel Hrdina
> > > ---
> > > src/main.c | 26 ++
> > >
On Wed, Jan 03, 2018 at 07:19:00PM -0500, John Ferlan wrote:
Need to beef up this commit message.
On 12/13/2017 10:39 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_process.c | 61 +
1 file changed, 56 insertion
On Tue, Jan 23, 2018 at 10:12:26AM +, Daniel P. Berrange wrote:
> On Mon, Jan 22, 2018 at 06:16:09PM +0100, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/main.c | 26 ++
> > 1 file changed, 22 insertions(+), 4 deletions(-)
> >
> > diff --git a/sr
From: Chen Hanxiao
Introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the output of `arp -an` command.
We can use:
domifaddr f26-cloud --source arp
to get the address.
Signed-off-by: Chen Hanxiao
---
include/libvirt/libvirt-domain.h | 1 +
src/qemu/qemu_driver.c
On Mon, Jan 22, 2018 at 04:43:35PM -0200, Eduardo Habkost wrote:
> On Wed, Jan 17, 2018 at 09:04:26AM +0100, Kashyap Chamarthy wrote:
[...]
> > > > The list of known CPU feature
> > > > +names (e.g. 'vmx', 'cmt', et cetera) can be found in the same
>
On Tue, Jan 23, 2018 at 10:02:24AM +, Daniel P. Berrange wrote:
> On Mon, Jan 22, 2018 at 06:16:04PM +0100, Pavel Hrdina wrote:
> > If the connection dies for some reason between D-Bus calls we need
> > to properly reconnect because the current connection is not usable
> > anymore. Without thi
On Tue, Jan 23, 2018 at 09:48:51AM +, Daniel P. Berrange wrote:
> On Mon, Jan 22, 2018 at 06:15:59PM +0100, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/util.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/src/util.h b/src/util.h
> > index 0c9f3d7..6
On Mon, Jan 22, 2018 at 06:15:58PM +0100, Pavel Hrdina wrote:
> This patch series is a proposal to how to implement libvirt connections
> in the libvirt D-Bus binding. The design is based on a discussion with
> Daniel and it should follow D-Bus convention.
>
> Each connection is represented as ex
On Mon, Jan 22, 2018 at 06:16:09PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/main.c | 26 ++
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/src/main.c b/src/main.c
> index 14c7c18..6421919 100644
> --- a/src/main.c
> +++ b/s
On Wed, Jan 03, 2018 at 06:50:22PM -0500, John Ferlan wrote:
On 12/13/2017 10:39 AM, Martin Kletzander wrote:
More info in the documentation, this is basically the XML parsing/formatting
support, schemas, tests and documentation for the new cputune/cachetune element
that will get used by follo
On Mon, Jan 22, 2018 at 06:16:08PM +0100, Pavel Hrdina wrote:
> This effectively removes --connect parameter from daemon, for now we
> will support only local connection. Instead of specifying URI for
> different drivers we will use connect object which allows using
> multiple drivers from one dae
On Mon, Jan 22, 2018 at 06:16:07PM +0100, Pavel Hrdina wrote:
> Each connection have its own domains so we must make the domain path
> as a sub-path of the specific connection.
Might be nice to illustrate the new scheme which, IIUC, will be
/org/libvirt/Connect/domain/{uuid} ?
> Signed-off-by
On Mon, Jan 22, 2018 at 06:16:05PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/connect.c | 7 ++-
> src/connect.h | 2 ++
> src/domain.c | 7 +++
> 3 files changed, 11 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: https
On Mon, Jan 22, 2018 at 06:16:06PM +0100, Pavel Hrdina wrote:
> This prepares for multiple connection objects since each object will
> have different path based on the driver name.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/connect.c | 3 ++-
> src/connect.h | 1 +
> src/events.c | 2 +-
> 3 f
On Mon, Jan 22, 2018 at 06:16:03PM +0100, Pavel Hrdina wrote:
> We need to implement our own authentication callback because the
> default one ask for credentials using STDIO. This is not suitable
> behavior for daemon.
>
> For now we will require usage of client configuration file for libvirt
>
On Mon, Jan 22, 2018 at 06:16:04PM +0100, Pavel Hrdina wrote:
> If the connection dies for some reason between D-Bus calls we need
> to properly reconnect because the current connection is not usable
> anymore. Without this the only solution would be to restart the
> libvirt-dbus daemon.
>
> Sign
On Mon, Jan 22, 2018 at 06:16:02PM +0100, Pavel Hrdina wrote:
> Open a connection to libvirt only when it is required.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/connect.c | 41 +++--
> src/connect.h | 1 +
> 2 files changed, 36 insertions(+), 6 deletions(-)
On Mon, Jan 22, 2018 at 06:16:01PM +0100, Pavel Hrdina wrote:
> Manager was a good name for the original design. However, the design
> will be changed that for now libvirt-dbus will be using only local
> connection and will support multiple drivers.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/M
On Mon, Jan 22, 2018 at 06:15:59PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/util.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/util.h b/src/util.h
> index 0c9f3d7..6d99841 100644
> --- a/src/util.h
> +++ b/src/util.h
> @@ -8,6 +8,8 @@
> #define _cl
On Mon, Jan 22, 2018 at 06:16:00PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/util.c | 7 +++
> src/util.h | 4
> 2 files changed, 11 insertions(+)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/
On Mon, Jan 22, 2018 at 08:58:52AM -0500, John Ferlan wrote:
> It's also easier than the :
>
> Reviewed-by: John Ferlan
>
> line that I keep in a "cheats" file that I always have open so that I
> don't have to add it for patches I review. Of course, I could also just
> say ACK, but the R-b seem
On Fri, Jan 19, 2018 at 06:23 PM +0100, John Ferlan wrote:
> RFC:
> https://www.redhat.com/archives/libvir-list/2018-January/msg00318.html
>
> Adjustments since RFC...
>
> Patches 1&2: No change, were already R-B'd
> Patch 3: Removed code as noted in code review, update commit message
> Patch 4: F
On Fri, Jan 19, 2018 at 06:23 PM +0100, John Ferlan wrote:
> Once virNetDaemonAddServer returns, the @srv or @srvAdm have
> either been added to the @dmn list increasing the refcnt or
> there was an error. In either case, we can lower the refcnt
> from virNetServerNew, but not set to NULL. Thus "u
On Fri, Jan 19, 2018 at 06:23 PM +0100, John Ferlan wrote:
> Once virNetServerProgramNew returns, the program objects have
> either been added to the @srv or @srvAdm list increasing the
> refcnt or there was an error. In either case, we can lower the
> refcnt from virNetServerProgramNew and set th
64 matches
Mail list logo
