Re: [libvirt] [PATCH] qemu: Alter condition to avoid possible NULL deref

On 02/09/2018 04:33 PM, John Ferlan wrote: > Commit 'f0f2a5ec2' neglected to adjust the if condition to split > out the possibility that the @watchdog is NULL when altering the > message to add detail about the model. > > Just split out the condition and use previous/original message, but > with

Re: [libvirt] [PATCH] qemu: don't leak in qemuGetDHCPInterfaces when failing to alloc

On 02/11/2018 04:07 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > We forgot to free alloced mem when failed to > dup ifname or macaddr. > > Also use VIR_STEAL_PTR to simplify codes. > > Signed-off-by: Chen Hanxiao > --- > src/qemu/qemu_agent.c

Re: [libvirt] [PATCH REBASE 2/2] qemu: Clean up PCI controller options

On 02/05/2018 11:08 AM, Andrea Bolognani wrote: > Most of the options are only applicable to one or two controller > types, so they should be filtered out everywhere else. > > This will reduce user confusion and, in at least one corner case, > prevent guests from disappearing on daemon restart.

Re: [libvirt] [PATCH REBASE 1/2] tests: Add some tests for PCI controller options

On 02/05/2018 11:08 AM, Andrea Bolognani wrote: > The input configurations set all existing options for all PCI > controllers, to see what ends up showing up in the output. > > Signed-off-by: Andrea Bolognani > --- > .../i440fx-controllers-pciopts.args| 24