[libvirt] 答复: [PATCH 0/3] virSysinfo: Introduce SMBIOS type 3 support

> -邮件原件- > 发件人: John Ferlan [mailto:jfer...@redhat.com] > 发送时间: 2018年2月14日 22:02 > 收件人: Zhuangyanying ; > libvir-list@redhat.com; berra...@redhat.com > 抄送: Zhangbo (Oscar) ; Gonglei (Arei) > ; Jiangyifei

Re: [libvirt] [PATCH 0/9] Resolve libvirtd hang on termination with connected long running client

On 01/26/2018 03:47 AM, Nikolay Shirokovskiy wrote: > > > On 19.01.2018 20:23, John Ferlan wrote: >> RFC: >> https://www.redhat.com/archives/libvir-list/2018-January/msg00318.html >> >> Adjustments since RFC... >> >> Patches 1&2: No change, were already R-B'd >> Patch 3: Removed code as noted

[libvirt] [PATCH v2 1/2] conf, qemu: Check for NULL addrs in virDomainUSBAddressRelease

Rather than having the caller check, if the input @addrs is NULL (e.g. priv->usbaddrs), then just return 0. This also removes the need for ATTRIBUTE_NONNULL which only really helped if someone passed a NULL as a parameter not if the passed parameter is NULL. Signed-off-by: John Ferlan

[libvirt] [PATCH v2 2/2] conf, qemu: Check for NULL addrs in virDomainUSBAddressEnsure

Rather than having the caller check, if the input @addrs is NULL (e.g. priv->usbaddrs), then just return 0. This also removes the need for ATTRIBUTE_NONNULL which only really helped if someone passed a NULL as a parameter not if the passed parameter is NULL. Signed-off-by: John Ferlan

[libvirt] [PATCH v2 0/2] Couple of hotplug cleanups

Necromancing some old branches... v1: https://www.redhat.com/archives/libvir-list/2017-October/msg00930.html Changes since v1 - beef up commit messages and drop patches 3 & 4 as that's a bit more involved and Jan seemed to imply he eventually may send patches dealing with the same thing - so

Re: [libvirt] [jenkins-ci PATCH] jobs: Set $PYTHONPATH for python-distutils jobs

On Wed, Feb 14, 2018 at 05:53:57PM +0100, Andrea Bolognani wrote: > Since we install Python modules under $VIRT_PREFIX, we need to set > $PYTHONPATH or the interpreter won't be able to locate them. This is > currently being done per-worker in the Jenkins Web interface. > > However, now that we've

[libvirt] [jenkins-ci PATCH] jobs: Set $PYTHONPATH for python-distutils jobs

Since we install Python modules under $VIRT_PREFIX, we need to set $PYTHONPATH or the interpreter won't be able to locate them. This is currently being done per-worker in the Jenkins Web interface. However, now that we've introduced Python 3 builds, depending on the project and the OS, we might

Re: [libvirt] Should we switch to a different JSON library?

On Monday, 12 February 2018 19:47:00 CET Ján Tomko wrote: > On Mon, Feb 12, 2018 at 02:38:02PM +0100, Pino Toscano wrote: > >On Tuesday, 7 November 2017 14:05:25 CET Martin Kletzander wrote: > >> - Jansson [3] - I really like this one. The API seems very intuitive, > >> it has

[libvirt] [PATCH 1/3] virsh: detach-disk: Add --print-xml switch

Similarly to other commands add an argument which allows to check the XML which would be used to execute the operation instead. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 10 ++ tools/virsh.pod | 4 2 files changed, 14 insertions(+) diff --git

[libvirt] [PATCH 2/3] util: storage: Remove detected authentication data for backing chains

We can't really detect all the authentication data in a sane manner for disk backing chains. Since the old RBD parser parses it in some cases as the argv->XML convertor requires it, we can't just drop it. Instead clear any detected authentication data in the code paths related to disk backing

[libvirt] [PATCH 3/3] virsh: Remove sub-element in virshFindDisk

Previously we've removed the data only in virshUpdateDiskXML when changing the disk source for the CDROM since the backing store would be invalid. Move the code into a separate function and callit from virshFindDisk which is also used when detaching disk. The detaching code does not necessarily

[libvirt] [PATCH 0/3] Fix trouble with in virsh detach-disk

We've created malformed element for RBD images in backing store of a disk which failed parsing and broke detaching disks via virsh. Fix it by not parsing auth data at all from the disk backing images and remove the element when constructing the XML for disk detach. Peter Krempa (3): virsh:

Re: [libvirt] [PATCH 3/6] spec: Drop checks for old Fedora releases

On Wed, Feb 14, 2018 at 03:11:38PM +0100, Jiri Denemark wrote: > The oldest Fedora release supported by the spec file is 26. Checking for > anything older makes no sense. > > Signed-off-by: Jiri Denemark > --- > libvirt.spec.in | 24 +--- > 1 file

Re: [libvirt] [PATCH 4/6] spec: Prepare for future RHEL

On Wed, Feb 14, 2018 at 03:11:39PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > libvirt.spec.in | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index daf7098216..c5cb0439a0 100644

Re: [libvirt] [PATCH 6/6] spec: Drop overlapping triggers

On Wed, Feb 14, 2018 at 03:11:41PM +0100, Jiri Denemark wrote: > The postun trigger for libvirt-daemon was defined twice for overlapping > ranges of package verions if systemd support was switched off (which > happens when building on something ancient, such as RHEL-6). > > Let's combine the two

Re: [libvirt] [PATCH 5/6] spec: Fix indentation in daemon's triggerpostun

On Wed, Feb 14, 2018 at 03:11:40PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > libvirt.spec.in | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index c5cb0439a0..f73fcab494

Re: [libvirt] [PATCH 2/6] spec: Build virt-login-shell iff LXC driver is enabled

On Wed, Feb 14, 2018 at 03:11:37PM +0100, Jiri Denemark wrote: > Building virt-login-shell doesn't really make any sense without LXC and > doing so even breaks "make rpm" since the associated files are installed > but unpackaged (the login-shell sub package already depends on LXC). > >

Re: [libvirt] [PATCH 1/6] spec: Enable fuse only if LXC is enabled

On Wed, Feb 14, 2018 at 03:11:36PM +0100, Jiri Denemark wrote: > Enabling fuse without LXC does not make a lot of sense because fuse is > used only by LXC. > > Signed-off-by: Jiri Denemark > --- > libvirt.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[libvirt] [PATCH 5/6] spec: Fix indentation in daemon's triggerpostun

Signed-off-by: Jiri Denemark --- libvirt.spec.in | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c5cb0439a0..f73fcab494 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1615,15 +1615,15 @@ fi

[libvirt] [PATCH 1/6] spec: Enable fuse only if LXC is enabled

Enabling fuse without LXC does not make a lot of sense because fuse is used only by LXC. Signed-off-by: Jiri Denemark --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 44f846a169..4821da826e

[libvirt] [PATCH 2/6] spec: Build virt-login-shell iff LXC driver is enabled

Building virt-login-shell doesn't really make any sense without LXC and doing so even breaks "make rpm" since the associated files are installed but unpackaged (the login-shell sub package already depends on LXC). Signed-off-by: Jiri Denemark --- libvirt.spec.in | 5 -

[libvirt] [PATCH 6/6] spec: Drop overlapping triggers

The postun trigger for libvirt-daemon was defined twice for overlapping ranges of package verions if systemd support was switched off (which happens when building on something ancient, such as RHEL-6). Let's combine the two triggers into the one which is called when libvirt-daemon < 1.3.0 is

[libvirt] [PATCH 3/6] spec: Drop checks for old Fedora releases

The oldest Fedora release supported by the spec file is 26. Checking for anything older makes no sense. Signed-off-by: Jiri Denemark --- libvirt.spec.in | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/libvirt.spec.in

[libvirt] [PATCH 0/6] spec: Misc cleanups and improvements

Jiri Denemark (6): spec: Enable fuse only if LXC is enabled spec: Build virt-login-shell iff LXC driver is enabled spec: Drop checks for old Fedora releases spec: Prepare for future RHEL spec: Fix indentation in daemon's triggerpostun spec: Drop overlapping triggers libvirt.spec.in |

[libvirt] [PATCH 4/6] spec: Prepare for future RHEL

Signed-off-by: Jiri Denemark --- libvirt.spec.in | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index daf7098216..c5cb0439a0 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -143,6 +143,10 @@ %define

Re: [libvirt] [PATCH 0/3] virSysinfo: Introduce SMBIOS type 3 support

On 02/14/2018 04:22 AM, Zhuangyanying wrote: > From: Zhuang Yanying > > Some applications inside VM need to access SMBIOS Chassis Asset Tag, > which should be emulated. > > access inside VM (for example) > Linux: /sys/class/dmi/id/chassis_asset_tag. > Windows:

Re: [libvirt] [PATCH v2 0/2] Fix parsing and formatting of 'UnixSocketAddress' qapi type

On Wed, Feb 14, 2018 at 01:33:09PM +0100, Peter Krempa wrote: v2: Don't 'fix' it for gluster disks which use old syntax not conforming to the schema in qemu. Peter Krempa (2): storage: Fix formatting and parsing of qemu type 'UnixSocketAddress' virstoragetest: Add test case for NBD over unix

[libvirt] [PATCH 0/3] virSysinfo: Introduce SMBIOS type 3 support

From: Zhuang Yanying Some applications inside VM need to access SMBIOS Chassis Asset Tag, which should be emulated. access inside VM (for example) Linux: /sys/class/dmi/id/chassis_asset_tag. Windows: (Get-WmiObject Win32_SystemEnclosure).SMBIOSAssetTag

[libvirt] [PATCH 2/3] qemu: add support for generating SMBIOS Chassis strings command line

From: Zhuang Yanying This wires up the previously added Chassis strings XML schema to be able to generate comamnd line args for QEMU. This requires QEMU >= 2.1 release containing this patch: SMBIOS: Build aggregate smbios tables and entry point

[libvirt] [PATCH v2 1/2] storage: Fix formatting and parsing of qemu type 'UnixSocketAddress'

The documentation for the JSON/qapi type 'UnixSocketAddress' states that the unix socket path field is named 'path'. Unfortunately qemu uses 'socket' in case of the gluster driver (despite documented otherwise). Add logic which will format the correct fields while keeping support of the old

[libvirt] [PATCH v2 0/2] Fix parsing and formatting of 'UnixSocketAddress' qapi type

v2: Don't 'fix' it for gluster disks which use old syntax not conforming to the schema in qemu. Peter Krempa (2): storage: Fix formatting and parsing of qemu type 'UnixSocketAddress' virstoragetest: Add test case for NBD over unix socket with new syntax src/qemu/qemu_block.c | 13

[libvirt] [PATCH v2 2/2] virstoragetest: Add test case for NBD over unix socket with new syntax

Use the new syntax which uses the 'UnixSocket' type in qemu. Signed-off-by: Peter Krempa --- tests/virstoragetest.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index 6eed7134ed..16c271c781 100644 ---

Re: [libvirt] [jenkins-ci PATCH] jobs: Shorten name for python-distutils jobs

On Wed, Feb 14, 2018 at 12:47:04PM +0100, Andrea Bolognani wrote: > Instead of passing the full name of the Python binary as 'python', > only pass the major version as 'pyver' and build everything else > based on that. > > Doing so allows us to make a few things, most notably job names, >

[libvirt] [jenkins-ci PATCH] jobs: Shorten name for python-distutils jobs

Instead of passing the full name of the Python binary as 'python', only pass the major version as 'pyver' and build everything else based on that. Doing so allows us to make a few things, most notably job names, slightly shorter and nicer. Signed-off-by: Andrea Bolognani

Re: [libvirt] [RFC] cgroup settings and systemd daemon-reload conflict

On Tue, Jan 30, 2018 at 10:34:14AM +0300, Nikolay Shirokovskiy wrote: > Hi, all. > > It turns out that systemd daemon-reload reset settings that are managable > thru 'systemctl set-property' interface. > > > virsh schedinfo tst3 | grep global_quota > global_quota : -1 > > virsh schedinfo tst3

[libvirt] [PATCH 1/3] conf: add support for setting Chassis SMBIOS data fields

From: Zhuang Yanying This type of information defines attributes of a system chassis, such as SMBIOS Chassis Asset Tag. access inside VM (for example) Linux: /sys/class/dmi/id/chassis_asset_tag. Windows: (Get-WmiObject Win32_SystemEnclosure).SMBIOSAssetTag

[libvirt] [PATCH 3/3] news: add support for setting Chassis SMBIOS data fields

From: Zhuang Yanying Signed-off-by: Zhuang Yanying --- docs/news.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 5a2943a..b60cb2d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -72,6

Re: [libvirt] [PATCH 1/3] storage: Fix formatting and parsing of qemu type 'UnixSocketAddress'

On Tue, Feb 13, 2018 at 17:33:00 +0100, Ján Tomko wrote: > On Mon, Feb 12, 2018 at 04:20:58PM +0100, Peter Krempa wrote: > > The documentation for the JSON/qapi type 'UnixSocketAddress' states that > > the unix socket path field is named 'path'. We used 'socket' by > > mistake. Fix both the

Re: [libvirt] [PATCHv2 1/1] include: function parameter names same in declaration

On Tue, Feb 13, 2018 at 01:56:59PM -0500, Christopher Venteicher wrote: > > > - Original Message - > > From: "Bjoern Walk" > > To: "Daniel P. Berrangé" > > Cc: "Chris Venteicher" , libvir-list@redhat.com > > Sent:

Re: [libvirt] [PATCHv2 1/1] include: function parameter names same in declaration

On Tue, Feb 13, 2018 at 12:03:40PM +0100, Bjoern Walk wrote: > Daniel P. Berrangé [2018-02-13, 09:47AM +]: > > On Mon, Feb 12, 2018 at 03:24:03PM -0600, Chris Venteicher wrote: > > > Headers use same function parameter names as definition code. > > > > > > In some cases