[libvirt] [PATCH] virsh: add missing help info of --source to domifaddr

From: Chen Hanxiao commit b4b5c82ce forgot to add this. Signed-off-by: Chen Hanxiao --- tools/virsh-domain-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c

Re: [libvirt] [GSoC] git send-email help

On 03/15/2018 07:59 PM, Sukrit Bhatnagar wrote: > Hi, > I am trying to mail a patch I made to this list, but git send-email is > not working. I have followed the steps in Contributing Guidelines > page. What can I do? In general, I would recommend giving a more detailed description of your

[libvirt] [GSoC] git send-email help

Hi, I am trying to mail a patch I made to this list, but git send-email is not working. I have followed the steps in Contributing Guidelines page. What can I do? Thanks, Sukrit -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [RFC PATCH 00/28] Enable multifunction pci hotplug

On Thu, 15 Mar 2018 17:53:02 -0400 Laine Stump wrote: > On 03/15/2018 11:35 AM, Daniel P. Berrangé wrote: > > On Thu, Mar 15, 2018 at 08:47:32PM +0530, Shivaprasad G Bhat wrote: > >> > >> On 03/15/2018 08:03 PM, Daniel P. Berrangé wrote: > >>> On Thu, Mar 15, 2018 at

Re: [libvirt] [RFC PATCH 00/28] Enable multifunction pci hotplug

On 03/15/2018 11:35 AM, Daniel P. Berrangé wrote: > On Thu, Mar 15, 2018 at 08:47:32PM +0530, Shivaprasad G Bhat wrote: >> >> On 03/15/2018 08:03 PM, Daniel P. Berrangé wrote: >>> On Thu, Mar 15, 2018 at 07:54:47PM +0530, Shivaprasad G Bhat wrote: On 03/15/2018 03:31 PM, Daniel P. Berrangé

Re: [libvirt] [PATCH] docs: link to security.libvirt.org website

On 03/15/2018 12:05 PM, Daniel P. Berrangé wrote: > We forgot to tell anyone that we were publishing security notices > online at https://security.libvirt.org > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump -- libvir-list mailing list

[libvirt] [PATCH] docs: Fix apibuild.py syntax

Commit id '477502de3' altered the entry to add one too many closing parenthesis ')' and that propagated into commit id '9176b42bd'. Signed-off-by: John Ferlan --- Pushed as a build breaker: GEN news.html File "./apibuild.py", line 481 line.split(

Re: [libvirt] [PATCH 00/20] Fix virConnect(Un)RegisterCloseCallback and get rid of global variables

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > The first part of this patch series fixes the behavior of > virConnectSupportsFeatures, virConnect(Un)RegisterCloseCallback, and > implements these features in the test driver. This results in a better > code coverage of our test suite. > > The

Re: [libvirt] [PATCH 20/20] remote/rpc: Use virNetServerGetProgram() to determine the program

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Use virNetServerGetProgram() to determine the virNetServerProgram > instead of using hard coded global variables. This allows us to remove > the global variables @remoteProgram and @qemuProgram as they're now no > longer necessary. > >

Re: [libvirt] [PATCH 20/20] remote/rpc: Use virNetServerGetProgram() to determine the program

On Thu, Mar 08, 2018 at 01:20 PM +0100, Marc Hartmayer wrote: > Use virNetServerGetProgram() to determine the virNetServerProgram > instead of using hard coded global variables. This allows us to remove > the global variables @remoteProgram and @qemuProgram as

Re: [libvirt] [PATCH 18/20] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

On Thu, Mar 15, 2018 at 07:56 PM +0100, John Ferlan wrote: > On 03/08/2018 07:20 AM, Marc Hartmayer wrote: >> This allows us to get rid of another usage of the global variable >> remoteProgram. >> >> Signed-off-by: Marc Hartmayer >> Reviewed-by:

Re: [libvirt] [PATCH 18/20] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

On Thu, Mar 15, 2018 at 07:56 PM +0100, John Ferlan wrote: > On 03/08/2018 07:20 AM, Marc Hartmayer wrote: >> This allows us to get rid of another usage of the global variable >> remoteProgram. >> >> Signed-off-by: Marc Hartmayer >> Reviewed-by:

Re: [libvirt] [PATCH 19/20] rpc: Introduce virNetServerGetProgramLocked helper function

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > This patch introduces virNetServerGetProgramLocked. It's a function to > determine which program has to be used for a given @msg. This function > will be reused in the next patch. > > Signed-off-by: Marc Hartmayer >

Re: [libvirt] [PATCH 18/20] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > This allows us to get rid of another usage of the global variable > remoteProgram. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- >

Re: [libvirt] [PATCH 02/20] remote: Don't hard code the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK as available

On Thu, Mar 15, 2018 at 12:02 AM +0100, John Ferlan wrote: > On 03/14/2018 05:30 PM, John Ferlan wrote: >> >> >> On 03/08/2018 07:20 AM, Marc Hartmayer wrote: >>> Don't assume that the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK is >>> available for every driver used for the

Re: [libvirt] [PATCH 17/20] remote: Add the information which program has to be used to daemonClientEventCallback

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > As a result, you can later determine at the callback which program has > to be used. This makes it easier to refactor the code in the future > and is less prone to error. > > Signed-off-by: Marc Hartmayer >

Re: [libvirt] [PATCH 1/2] docs: Import print_function in reformat-news.py

On Thu, Mar 15, 2018 at 06:00:37PM +0100, Andrea Bolognani wrote: > The script already works perfectly fine with Python 2, but that's > more by chance than by design: we have a single occurrence of > print(), and it just so happens that its only argument is an > expression. Importing

Re: [libvirt] [PATCH 2/2] python: Drop explicit version where possible

On Thu, Mar 15, 2018 at 06:00:38PM +0100, Andrea Bolognani wrote: > Some of our scripts are known to work both with Python 2 and > Python 3, so for them we shouldn't be forcing any specific > version of the interpreter when they're called directly. > > Signed-off-by: Andrea Bolognani

[libvirt] [PATCH 2/2] python: Drop explicit version where possible

Some of our scripts are known to work both with Python 2 and Python 3, so for them we shouldn't be forcing any specific version of the interpreter when they're called directly. Signed-off-by: Andrea Bolognani --- docs/reformat-news.py | 2 +-

[libvirt] [PATCH 1/2] docs: Import print_function in reformat-news.py

The script already works perfectly fine with Python 2, but that's more by chance than by design: we have a single occurrence of print(), and it just so happens that its only argument is an expression. Importing print_function makes the script more future, err, past proof. Signed-off-by: Andrea

[libvirt] [PATCH 0/2] python3: Further minor tweaks

Andrea Bolognani (2): docs: Import print_function in reformat-news.py python: Drop explicit version where possible docs/reformat-news.py | 4 +++- src/esx/esx_vi_generator.py | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.14.3 -- libvir-list mailing list

Re: [libvirt] [PATCH v2 4/8] python3: Remove uses of string.*() functions

On Thu, 2018-03-15 at 16:36 +, Daniel P. Berrangé wrote: > > @@ -478,8 +478,8 @@ class CLexer: > > return None > > > > if line[0] == '#': > > -self.tokens = map((lambda x: ('preproc', x)), > > -

Re: [libvirt] [PATCH v2 6/8] python3: Replace keys() + sort() with sorted()

On Thu, Mar 15, 2018 at 05:11:08PM +0100, Andrea Bolognani wrote: > The keys() method no longer returns a list, so converting the > return value would be necessary before calling sort() on it; > alternatively, we can just call sorted(), which returns a > sorted list. > > Signed-off-by: Andrea

Re: [libvirt] [PATCH v2 5/8] python3: Call list() explicitly as needed

On Thu, Mar 15, 2018 at 05:11:07PM +0100, Andrea Bolognani wrote: > For list concatenation to work, the value returned by the > keys() method must be converted to a list first. > > Signed-off-by: Andrea Bolognani > --- > docs/apibuild.py | 17 ++--- > 1 file

Re: [libvirt] [PATCH v2 4/8] python3: Remove uses of string.*() functions

On Thu, Mar 15, 2018 at 05:11:06PM +0100, Andrea Bolognani wrote: > All of these have been replaced with methods. > > Signed-off-by: Andrea Bolognani > --- > docs/apibuild.py | 142 > +++ > 1 file changed, 71

Re: [libvirt] [RFC PATCH v2 8/8] python3: Fix sort function

On Thu, Mar 15, 2018 at 05:11:10PM +0100, Andrea Bolognani wrote: > This deals with cls.version possibly being None. > > Signed-off-by: Andrea Bolognani > --- > Really not sure about this one. The script runs all the way to > the end after applying it, so there's that I

Re: [libvirt] [PATCH 16/20] remote: Set eventID explicitly to an invalid value

On Thu, Mar 15, 2018 at 04:39 PM +0100, John Ferlan wrote: > On 03/08/2018 07:20 AM, Marc Hartmayer wrote: >> Set the eventID for remoteRelayDomainQemuMonitorEvent explicitly to an >> invalid value. Although the value is not used by >> remoteRelayDomainQemuMonitorEvent, but it

Re: [libvirt] [PATCH v2 1/8] python3: Use the print() function

On Thu, Mar 15, 2018 at 05:11:03PM +0100, Andrea Bolognani wrote: > It has replaced the 'print' statement. > > Signed-off-by: Andrea Bolognani > --- > docs/apibuild.py | 85 > -- > src/esx/esx_vi_generator.py|

Re: [libvirt] [PATCH v2 2/8] python3: Use the repr() function

On Thu, Mar 15, 2018 at 05:11:04PM +0100, Andrea Bolognani wrote: > This replaces the `` built-in. > > Signed-off-by: Andrea Bolognani > --- > docs/apibuild.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé

Re: [libvirt] [RFC PATCH v2 7/8] python3: Open files in text instead of binary mode

On Thu, Mar 15, 2018 at 04:28:56PM +, Daniel P. Berrangé wrote: > On Thu, Mar 15, 2018 at 05:11:09PM +0100, Andrea Bolognani wrote: > > We use text operations on the contents after reading them. > > > > Signed-off-by: Andrea Bolognani > > --- > > This seems reasonable

Re: [libvirt] [PATCH 15/20] stream: Access stream->prog instead of a hard-coded global variable

On Thu, Mar 15, 2018 at 04:22 PM +0100, John Ferlan wrote: > On 03/08/2018 07:20 AM, Marc Hartmayer wrote: >> Use stream->prog instead of a hard-coded >> virNetServerProgram. Especially since these functions are intended as >> generic helpers for streams. > > Looks like you

Re: [libvirt] [PATCH v2 3/8] python3: Use the 'in' keyword

On Thu, Mar 15, 2018 at 05:11:05PM +0100, Andrea Bolognani wrote: > This replaces uses of the has_key() method. > > Signed-off-by: Andrea Bolognani > --- > docs/apibuild.py | 60 > > 1 file changed, 30 insertions(+),

Re: [libvirt] [RFC PATCH v2 7/8] python3: Open files in text instead of binary mode

On Thu, Mar 15, 2018 at 05:11:09PM +0100, Andrea Bolognani wrote: > We use text operations on the contents after reading them. > > Signed-off-by: Andrea Bolognani > --- > This seems reasonable and works correctly AFAICT, but I'm > not 100% confident it's the right way to

Re: [libvirt] [PATCH 13/20] test: Convert testDriver to virObjectLockable

On Thu, Mar 15, 2018 at 04:05 PM +0100, John Ferlan wrote: > On 03/08/2018 07:20 AM, Marc Hartmayer wrote: >> The test driver state (@testDriver) uses it's own reference counting >> and locking implementation. Instead of doing that, convert @testDriver >> into a

Re: [libvirt] [PATCH 10/20] test: rename defaultConn to defaultPrivconn

On Thu, Mar 15, 2018 at 03:38 PM +0100, John Ferlan wrote: > On 03/08/2018 07:20 AM, Marc Hartmayer wrote: >> Rename the variable @defaultConn to @defaultPrivconn as it doesn't >> point to a default connection but to the private data used for the >> shared default connection

[libvirt] [RFC PATCH v2 8/8] python3: Fix sort function

This deals with cls.version possibly being None. Signed-off-by: Andrea Bolognani --- Really not sure about this one. The script runs all the way to the end after applying it, so there's that I guess. src/hyperv/hyperv_wmi_generator.py | 2 +- 1 file changed, 1

Re: [libvirt] [RFC PATCH 00/28] Enable multifunction pci hotplug

On Thu, Mar 15, 2018 at 09:54:46AM -0600, Alex Williamson wrote: > On Thu, 15 Mar 2018 15:06:38 + > Daniel P. Berrangé wrote: > > On Thu, Mar 15, 2018 at 08:59:41AM -0600, Alex Williamson wrote: > > > > > > Neither really bothers me, but I'm confused by the claimed

[libvirt] [RFC PATCH v2 7/8] python3: Open files in text instead of binary mode

We use text operations on the contents after reading them. Signed-off-by: Andrea Bolognani --- This seems reasonable and works correctly AFAICT, but I'm not 100% confident it's the right way to address the issue. src/esx/esx_vi_generator.py| 4 ++--

[libvirt] [PATCH v2 3/8] python3: Use the 'in' keyword

This replaces uses of the has_key() method. Signed-off-by: Andrea Bolognani --- docs/apibuild.py | 60 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index

[libvirt] [PATCH v2 6/8] python3: Replace keys() + sort() with sorted()

The keys() method no longer returns a list, so converting the return value would be necessary before calling sort() on it; alternatively, we can just call sorted(), which returns a sorted list. Signed-off-by: Andrea Bolognani --- docs/apibuild.py | 60

[libvirt] [PATCH v2 5/8] python3: Call list() explicitly as needed

For list concatenation to work, the value returned by the keys() method must be converted to a list first. Signed-off-by: Andrea Bolognani --- docs/apibuild.py | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/docs/apibuild.py

[libvirt] [PATCH v2 4/8] python3: Remove uses of string.*() functions

All of these have been replaced with methods. Signed-off-by: Andrea Bolognani --- docs/apibuild.py | 142 +++ 1 file changed, 71 insertions(+), 71 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index

[libvirt] [PATCH v2 0/8] Introduce partial Python 3 support

This series takes care of all the trivial stuff, paving the way for someone with good Python knowledge to jump in and finish porting. Changes since [v1]: * the build system no longer needs tweaks; * patches are organized by type of change for easier review. [v1]

[libvirt] [PATCH v2 1/8] python3: Use the print() function

It has replaced the 'print' statement. Signed-off-by: Andrea Bolognani --- docs/apibuild.py | 85 -- src/esx/esx_vi_generator.py| 8 ++-- src/hyperv/hyperv_wmi_generator.py | 8 ++-- 3 files changed, 54

[libvirt] [PATCH v2 2/8] python3: Use the repr() function

This replaces the `` built-in. Signed-off-by: Andrea Bolognani --- docs/apibuild.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index 9ac6442337..2e8932bb5e 100755 --- a/docs/apibuild.py +++

[libvirt] [PATCH] docs: link to security.libvirt.org website

We forgot to tell anyone that we were publishing security notices online at https://security.libvirt.org Signed-off-by: Daniel P. Berrangé --- docs/securityprocess.html.in | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] [RFC PATCH 00/28] Enable multifunction pci hotplug

On Thu, 15 Mar 2018 15:06:38 + Daniel P. Berrangé wrote: > On Thu, Mar 15, 2018 at 08:59:41AM -0600, Alex Williamson wrote: > > > > Neither really bothers me, but I'm confused by the claimed existing > > handling of SR-IOV. Either you're assigning a PF and SR-IOV is > >

Re: [libvirt] [PATCH] rpm: depend on python2, not bare python

On Thu, 2018-03-15 at 13:45 +, Daniel P. Berrangé wrote: > Fedora requires packages to depend on "python2" RPM, not the unversioned > "python" name. Fortunately even though RHEL-6 ships a "python" RPM, it > has a virtual Provides for the "python2" name, so we don't need to > conditionalize

Re: [libvirt] [PATCH] travis: Don't install xz on macOS

On Thu, Mar 15, 2018 at 04:43:37PM +0100, Andrea Bolognani wrote: > It's already being dragged in by Python. > > Signed-off-by: Andrea Bolognani > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Fun, it was not being dragged in a couple of weeks

[libvirt] [PATCH] travis: Don't install xz on macOS

It's already being dragged in by Python. Signed-off-by: Andrea Bolognani --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index d1f09f9cad..d071c98634 100644 --- a/.travis.yml +++ b/.travis.yml @@ -18,7 +18,7 @@

Re: [libvirt] [PATCH 16/20] remote: Set eventID explicitly to an invalid value

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Set the eventID for remoteRelayDomainQemuMonitorEvent explicitly to an > invalid value. Although the value is not used by > remoteRelayDomainQemuMonitorEvent, but it might be less prone to > errors for further refactorings. > > Signed-off-by: Marc

Re: [libvirt] [RFC PATCH 00/28] Enable multifunction pci hotplug

On Thu, Mar 15, 2018 at 08:47:32PM +0530, Shivaprasad G Bhat wrote: > > > On 03/15/2018 08:03 PM, Daniel P. Berrangé wrote: > > On Thu, Mar 15, 2018 at 07:54:47PM +0530, Shivaprasad G Bhat wrote: > > > > > > On 03/15/2018 03:31 PM, Daniel P. Berrangé wrote: > > > > On Wed, Mar 14, 2018 at

Re: [libvirt] [PATCH 15/20] stream: Access stream->prog instead of a hard-coded global variable

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Use stream->prog instead of a hard-coded > virNetServerProgram. Especially since these functions are intended as > generic helpers for streams. Looks like you were editing your commit message and didn't reformat. In essence though it seems you're

Re: [libvirt] [RFC PATCH 00/28] Enable multifunction pci hotplug

On 03/15/2018 08:03 PM, Daniel P. Berrangé wrote: On Thu, Mar 15, 2018 at 07:54:47PM +0530, Shivaprasad G Bhat wrote: On 03/15/2018 03:31 PM, Daniel P. Berrangé wrote: On Wed, Mar 14, 2018 at 10:44:30PM +0530, Shivaprasad G Bhat wrote: Hi All, I have revisited/rewritten my previously

Re: [libvirt] [PATCH 13/20] test: Convert testDriver to virObjectLockable

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > The test driver state (@testDriver) uses it's own reference counting > and locking implementation. Instead of doing that, convert @testDriver > into a virObjectLockable and use the provided functionalities. > > Signed-off-by: Marc Hartmayer

Re: [libvirt] [RFC PATCH 00/28] Enable multifunction pci hotplug

On Thu, Mar 15, 2018 at 08:59:41AM -0600, Alex Williamson wrote: > On Thu, 15 Mar 2018 14:33:55 + > Daniel P. Berrangé wrote: > > > On Thu, Mar 15, 2018 at 07:54:47PM +0530, Shivaprasad G Bhat wrote: > > > > > > > > > On 03/15/2018 03:31 PM, Daniel P. Berrangé wrote:

Re: [libvirt] [PATCH 14/20] remote: remove unneeded global variables

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Remove unneeded global variables and convert them into local variables > where they're needed. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Bjoern Walk > Reviewed-by: Boris Fiuczynski

Re: [libvirt] [RFC PATCH 00/28] Enable multifunction pci hotplug

On Thu, 15 Mar 2018 14:33:55 + Daniel P. Berrangé wrote: > On Thu, Mar 15, 2018 at 07:54:47PM +0530, Shivaprasad G Bhat wrote: > > > > > > On 03/15/2018 03:31 PM, Daniel P. Berrangé wrote: > > > On Wed, Mar 14, 2018 at 10:44:30PM +0530, Shivaprasad G Bhat wrote: >

Re: [libvirt] [PATCH 12/20] test: fix error path in testConnectOpen

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > In case of an error do the cleanup of the private data of the > connection. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- > src/test/test_driver.c | 5 - > 1

Re: [libvirt] [PATCH 11/20] test: introduce testDriverCloseInternal

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Refactor testConnectClose as it's then obvious that conn->privateData > is set to NULL in all cases. In addition, 'testConnectCloseInternal' > can be better reused. > > Signed-off-by: Marc Hartmayer > Reviewed-by:

Re: [libvirt] [PATCH 10/20] test: rename defaultConn to defaultPrivconn

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Rename the variable @defaultConn to @defaultPrivconn as it doesn't > point to a default connection but to the private data used for the > shared default connection of the test driver. > > Signed-off-by: Marc Hartmayer

Re: [libvirt] [RFC PATCH 00/28] Enable multifunction pci hotplug

On Thu, Mar 15, 2018 at 07:54:47PM +0530, Shivaprasad G Bhat wrote: > > > On 03/15/2018 03:31 PM, Daniel P. Berrangé wrote: > > On Wed, Mar 14, 2018 at 10:44:30PM +0530, Shivaprasad G Bhat wrote: > > > Hi All, > > > > > > I have revisited/rewritten my previously posted patches. Here is > > >

Re: [libvirt] [PATCH 09/20] test: testConnectClose: Set privateData to NULL in all cases

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Set privateData to NULL also for a connection that uses @defaultConn > as privateData regardless of whether @defaultConn was freed or > not. @defaultConn is shared between multiple connections and it's > ensured that there will be no memory leak by

Re: [libvirt] [RFC PATCH 00/28] Enable multifunction pci hotplug

On 03/15/2018 03:31 PM, Daniel P. Berrangé wrote: On Wed, Mar 14, 2018 at 10:44:30PM +0530, Shivaprasad G Bhat wrote: Hi All, I have revisited/rewritten my previously posted patches. Here is the RFC. Since this patchset is a complete rewrite, I am starting with v1 here. The semantics is as

Re: [libvirt] [PATCH 08/20] test: testConnectAuthenticate: Take the lock when accessing mutable values

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- > src/test/test_driver.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: John Ferlan

Re: [libvirt] [PATCH 07/20] test: testOpenFromFile: return VIR_DRV_OPEN_SUCCESS in case of success

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- > src/test/test_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: John Ferlan

Re: [libvirt] [PATCH 2/2] travis: unlink python package before upgrading brew packages

On Thu, Mar 15, 2018 at 02:58:56PM +0100, Andrea Bolognani wrote: > On Thu, 2018-03-15 at 13:33 +, Daniel P. Berrangé wrote: > > The 'brew upgrade' command is pulling in the python2 package which > > promptly fails due to clashing symlinks installed by the new python > > package (which is

Re: [libvirt] [PATCH 2/2] travis: unlink python package before upgrading brew packages

On Thu, 2018-03-15 at 13:33 +, Daniel P. Berrangé wrote: > The 'brew upgrade' command is pulling in the python2 package which > promptly fails due to clashing symlinks installed by the new python > package (which is python3 based): > > ==> Pouring python@2-2.7.14_3.sierra.bottle.tar.gz >

Re: [libvirt] [PATCH 1/2] travis: move macOS before_install tasks into osx matrix entry

On Thu, 2018-03-15 at 13:33 +, Daniel P. Berrangé wrote: > The list of commands we're running for the before_install task > is rather large. We have it all on one line because we're > wrapping it all in a test against TRAVIS_OS_NAME env variable. > > By moving it into the osx matrix entry we

[libvirt] [PATCH] rpm: depend on python2, not bare python

Fedora requires packages to depend on "python2" RPM, not the unversioned "python" name. Fortunately even though RHEL-6 ships a "python" RPM, it has a virtual Provides for the "python2" name, so we don't need to conditionalize this. Signed-off-by: Daniel P. Berrangé ---

[libvirt] [PATCH 2/2] travis: unlink python package before upgrading brew packages

The 'brew upgrade' command is pulling in the python2 package which promptly fails due to clashing symlinks installed by the new python package (which is python3 based): ==> Pouring python@2-2.7.14_3.sierra.bottle.tar.gz Error: The `brew link` step did not complete successfully The formula built,

[libvirt] [PATCH 0/2] travis: fix macOS build

You can see the "working" build here: https://travis-ci.org/berrange/libvirt/builds/353816421 Yeah it still failed, but it got past the brew bit that was failing before, and now fails for genuine code problems :-) Daniel P. Berrangé (2): travis: move macOS before_install tasks into osx

[libvirt] [PATCH 1/2] travis: move macOS before_install tasks into osx matrix entry

The list of commands we're running for the before_install task is rather large. We have it all on one line because we're wrapping it all in a test against TRAVIS_OS_NAME env variable. By moving it into the osx matrix entry we can remove the need for the conditional shell test. This lets us put

Re: [libvirt] [PATCH 2/2] virarptable: Include rtnetlink.h only on Linux

At 2018-03-15 20:49:30, "Michal Privoznik" wrote: >And at the same time, do that from .c rather than .h file. > >Signed-off-by: Michal Privoznik >--- > src/util/virarptable.c | 3 +++ > src/util/virarptable.h | 1 - > 2 files changed, 3 insertions(+), 1

Re: [libvirt] [PATCH v1 0/7] Add support for video and input devices on S390

A polite ping :) Would appreciate some feedback on these patches. Thanks Farhan On 03/08/2018 11:06 AM, Farhan Ali wrote: Hi, This patch series adds Libvirt support for video and input devices for QEMU guests on S390. QEMU v2.11.0 added support for the virtio-gpu-ccw device [1] and

Re: [libvirt] [PATCH] conf: nodedev: Update capabilities from within virNodeDeviceObjHasCap

On 03/15/2018 04:35 AM, Erik Skultety wrote: > On Wed, Mar 14, 2018 at 03:28:36PM -0400, John Ferlan wrote: >> >> >> On 03/06/2018 10:32 AM, Erik Skultety wrote: >>> Commit d18feadc0c put this into virNodeDeviceMatch, but this should have >>> rather been part of virNodeDeviceObjHasCap from the

Re: [libvirt] Emacs tip for easily adding Reviewed-by tags & friends

On Thu, Mar 15, 2018 at 12:38:26PM +, Daniel P. Berrangé wrote: > On Thu, Mar 15, 2018 at 01:34:31PM +0100, Erik Skultety wrote: > > On Thu, Mar 15, 2018 at 11:36:28AM +, Daniel P. Berrangé wrote: > > > It is nice that git has the short-hand for adding Signed-off-by, but > > > adding other

Re: [libvirt] [PATCH v3 10/12] qemu_hotplug: Hotplug of reservations

On Wed, Mar 14, 2018 at 17:05:39 +0100, Michal Privoznik wrote: > Surprisingly, nothing special is happening here. If we are the > first to use the managed helper then spawn it. If not, we're > almost done. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_hotplug.c

Re: [libvirt] Emacs tip for easily adding Reviewed-by tags & friends

On Thu, 2018-03-15 at 12:38 +, Daniel P. Berrangé wrote: > On Thu, Mar 15, 2018 at 01:34:31PM +0100, Erik Skultety wrote: > > On Thu, Mar 15, 2018 at 11:36:28AM +, Daniel P. Berrangé wrote: > > > It is nice that git has the short-hand for adding Signed-off-by, but > > > adding other tags

Re: [libvirt] [PATCH 2/2] virarptable: Include rtnetlink.h only on Linux

On Thu, Mar 15, 2018 at 01:49:30PM +0100, Michal Privoznik wrote: > And at the same time, do that from .c rather than .h file. > > Signed-off-by: Michal Privoznik > --- > src/util/virarptable.c | 3 +++ > src/util/virarptable.h | 1 - > 2 files changed, 3 insertions(+), 1

Re: [libvirt] [PATCH 1/2] src: Don't add virarptable.c to setuid library

On Thu, Mar 15, 2018 at 01:49:29PM +0100, Michal Privoznik wrote: > The setuid-rpc-client.la is intended to be small and contain only > bare minimum of source files. virarptable.c is not one of them. > > Signed-off-by: Michal Privoznik > --- > src/Makefile.am | 1 - > 1

Re: [libvirt] [PATCH] travis: Temporarily disable 'brew upgrade'

On Thu, Mar 15, 2018 at 01:40:29PM +0100, Andrea Bolognani wrote: > There are a lot of changes happening in the homebrew ecosystem > around Python, and as a consequence 'brew upgrade' hasn't been > able to complete successfully for several days. > > Temporarily disable upgrading the system before

[libvirt] [PATCH 0/2] Two small fixes

*** BLURB HERE *** Michal Privoznik (2): src: Don't add virarptable.c to setuid library virarptable: Include rtnetlink.h only on Linux src/Makefile.am| 1 - src/util/virarptable.c | 3 +++ src/util/virarptable.h | 1 - 3 files changed, 3 insertions(+), 2 deletions(-) -- 2.16.1 --

[libvirt] [PATCH 2/2] virarptable: Include rtnetlink.h only on Linux

And at the same time, do that from .c rather than .h file. Signed-off-by: Michal Privoznik --- src/util/virarptable.c | 3 +++ src/util/virarptable.h | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virarptable.c b/src/util/virarptable.c index

[libvirt] [PATCH 1/2] src: Don't add virarptable.c to setuid library

The setuid-rpc-client.la is intended to be small and contain only bare minimum of source files. virarptable.c is not one of them. Signed-off-by: Michal Privoznik --- src/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index

[libvirt] [PATCH] travis: Temporarily disable 'brew upgrade'

There are a lot of changes happening in the homebrew ecosystem around Python, and as a consequence 'brew upgrade' hasn't been able to complete successfully for several days. Temporarily disable upgrading the system before building: this will need to be reverted once the upgrade issues have been

Re: [libvirt] Emacs tip for easily adding Reviewed-by tags & friends

On Thu, Mar 15, 2018 at 01:34:31PM +0100, Erik Skultety wrote: > On Thu, Mar 15, 2018 at 11:36:28AM +, Daniel P. Berrangé wrote: > > It is nice that git has the short-hand for adding Signed-off-by, but > > adding other tags during reviews is kind of tedious and long winded. > > eg "ACK" is

Re: [libvirt] libvirt build failure with --disable-shared

Hello Rahul, On Thu, 2018-03-15 at 00:24 -0400, Rahul Sharma wrote: > Hi, > > I am facing an error with libvirt build where it fails if I try to disable > shared libraries. Though I opened up the > issue on gitlab, not sure if that was the right place to open one. Kindly do > let me know if

Re: [libvirt] [jenkins-ci PATCH] guests: Stop installing polkit-devel

On Thu, Mar 15, 2018 at 12:46:49PM +0100, Andrea Bolognani wrote: > As of libvirt commit 9cd42e725f42 only the runtime package is > needed, even during build. > > Signed-off-by: Andrea Bolognani > --- > guests/vars/mappings.yml | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [libvirt] Emacs tip for easily adding Reviewed-by tags & friends

On Thu, Mar 15, 2018 at 11:36:28AM +, Daniel P. Berrangé wrote: > It is nice that git has the short-hand for adding Signed-off-by, but > adding other tags during reviews is kind of tedious and long winded. > eg "ACK" is much shorter than typing "Reviewed-by: ...blah blah blah.." > > Good

Re: [libvirt] [PATCH v3 09/12] qemu: Start PR daemon on domain startup

On Wed, Mar 14, 2018 at 17:05:38 +0100, Michal Privoznik wrote: > Before we exec() qemu we have to spawn pr-helper processes for > all managed reservations (well, technically there can only one). > The only caveat there is that we should place the process into > the same namespace and cgroup as

Re: [libvirt] libvirt build failure with --disable-shared

On Thu, Mar 15, 2018 at 12:24:41AM -0400, Rahul Sharma wrote: > Hi, > > I am facing an error with libvirt build where it fails if I try to disable > shared libraries. Though I opened up the issue on gitlab, not sure if that > was the right place to open one. Kindly do let me know if this should

Re: [libvirt] [PATCH v3 06/12] qemu: Generate cmd line at startup

On Wed, Mar 14, 2018 at 17:05:35 +0100, Michal Privoznik wrote: > This is the easier part. All we need to do here is put -object > pr-manager-helper,id=$alias,path=$socketPath and then just > reference the object in -drive file.pr-manager=$alias. > > Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH v3 05/12] qemu: Store pr runtime data in status XML

On Wed, Mar 14, 2018 at 17:05:34 +0100, Michal Privoznik wrote: > Now that we generate pr-manager alias and socket path store them > in status XML so that they are preserved across daemon restarts. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 108 >

[libvirt] libvirt build failure with --disable-shared

Hi, I am facing an error with libvirt build where it fails if I try to disable shared libraries. Though I opened up the issue on gitlab, not sure if that was the right place to open one. Kindly do let me know if this should be opened up at some other place. Build failure with libvirt-4.1.0 using

Re: [libvirt] [PATCH v3 01/12] virstoragefile: Introduce virStoragePRDef

On Wed, Mar 14, 2018 at 17:05:30 +0100, Michal Privoznik wrote: > This is a definition that holds information on SCSI persistent > reservation settings. The XML part looks like this: > > > > > > If @managed is set to 'yes' then the is not parsed. > This design was agreed on here: >

[libvirt] [jenkins-ci PATCH] guests: Stop installing polkit-devel

As of libvirt commit 9cd42e725f42 only the runtime package is needed, even during build. Signed-off-by: Andrea Bolognani --- guests/vars/mappings.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml

Re: [libvirt] [PATCH v3 05/12] qemu: Store pr runtime data in status XML

On Wed, Mar 14, 2018 at 17:05:34 +0100, Michal Privoznik wrote: > Now that we generate pr-manager alias and socket path store them > in status XML so that they are preserved across daemon restarts. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 108 >

[libvirt] Emacs tip for easily adding Reviewed-by tags & friends

It is nice that git has the short-hand for adding Signed-off-by, but adding other tags during reviews is kind of tedious and long winded. eg "ACK" is much shorter than typing "Reviewed-by: ...blah blah blah.." Good editors have a way to setup macros though, and so I thought I'd share the emacs

Re: [libvirt] [PATCH v2] spec: Drop polkit-devel from BuildRequires

On Thu, Mar 15, 2018 at 12:26:17PM +0100, Andrea Bolognani wrote: > As of 2499d1a09508 we don't link against libpolkit anymore, so > we only need the polkit package to be available during build. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 4 +--- > 1 file

  1   2   3   >