[libvirt] [PATCHv1 7/7] qemu_driver: Baseline CPU model using QEMU

2018-05-05 Thread Chris Venteicher
virsh cpu-baseline determines baseline from QEMU for some architectures and libvirt for others. Skip the QEMU attempt to save time on architectures QEMU baseline does not support. --- src/qemu/qemu_driver.c | 29 + 1 file changed, 29 insertions(+) diff --git

[libvirt] [PATCHv1 6/7] qemu_capabilities: qmperr pointer tracked in QMPCommand

2018-05-05 Thread Chris Venteicher
Allow QEMU process to be started without requirement for caller to maintain handle to qmperr pointer. The handle to qmperr pointer can be stored in QMPCommand structure (new way) stored in calling function's stack (original way). --- src/qemu/qemu_capabilities.c | 7 ++- 1 file changed, 6

[libvirt] [PATCHv1 2/7] qemu_capabilities: CPUModelInfo: XML/QMP format conversion

2018-05-05 Thread Chris Venteicher
Functions converting directly between virsh XML and QMEU QMP forms of CPUModelInfo. --- src/qemu/qemu_capabilities.c | 159 +++ 1 file changed, 159 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index

[libvirt] [PATCHv1 5/7] qemu_capabilities: Find QEMU binary for S390 arch

2018-05-05 Thread Chris Venteicher
S390 uses qemu-kvm in /usr/libexec. --- src/qemu/qemu_capabilities.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 9ffbf91a90..ac7569679c 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@

[libvirt] [PATCHv1 1/7] qemu_monitor_json: Properties optional in QMP JSON for CPUModelInfo

2018-05-05 Thread Chris Venteicher
Allow case where props not present in JSON for CPUModelInfo. Check for NULL input. Update comments to show JSON examples for more typical S390x usecase. --- src/qemu/qemu_monitor_json.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git

[libvirt] [PATCHv1 0/7] Baseline CPU model using QEMU QMP exchanges

2018-05-05 Thread Chris Venteicher
Some architectures (S390) depend on QEMU to compute baseline CPU model. Interacting with QEMU requires starting the QEMU process and completing one or more query-cpu-model-baseline QMP exchanges with QEMU. This patch set depends on qemuMonitorGetCPUModelBaseline function exposed by

[libvirt] [PATCHv1 4/7] qemu_capabilities: Baseline CPUModel via QEMU

2018-05-05 Thread Chris Venteicher
Spinup QEMU instance and complete QMP query-cpu-model-baseline exchanges to determine CPUModel Baseline. query-cpu-model-baseline only compares two CPUModels so multiple exchanges are needed to evaluate more than two CPUModels. --- src/qemu/qemu_capabilities.c | 132

[libvirt] [PATCHv1 3/7] qemu_capabilities: Start and connect to QEMU

2018-05-05 Thread Chris Venteicher
Start and connect to QEMU so QMP commands can be performed. Isolates code for starting QEMU and establishing Monitor connections from code for obtaining capabilities so that arbitrary QMP commands can be exchanged with QEMU. --- src/qemu/qemu_capabilities.c | 59

[libvirt] [PATCH 3/3] all: replacing virGetLastError with virGetLastErrorCode where we can

2018-05-05 Thread ramyelkest
Replaced instances where we called virGetLastError just to either get the code or to check if an error exists with virGetLastErrorCode to avoid a validity pre-check. Signed-off-by: Ramy Elkest --- src/locking/lock_driver_lockd.c | 3 +-- src/lxc/lxc_controller.c|

[libvirt] [PATCH 2/3] util: added virGetLastErrorCode/Domain

2018-05-05 Thread ramyelkest
Many places in the code call virGetLastError() just to check the raised error code, or domain. However virGetLastError() can return NULL, so the code has to check for that first. This patch therefore introduces virGetLasErrorCode/Domain function which always returns a valid error code/domain

[libvirt] [PATCH 1/3] util: cleanup: using virGetLastErrorMessage instead of err->message

2018-05-05 Thread ramyelkest
Signed-off-by: Ramy Elkest --- src/util/virfilecache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virfilecache.c b/src/util/virfilecache.c index dab7216..96ae96d 100644 --- a/src/util/virfilecache.c +++ b/src/util/virfilecache.c @@ -157,9

[libvirt] [PATCH v2 0/3] adding virGetLastErrorCode/Domain to paritally replace virGetLastError

2018-05-05 Thread ramyelkest
Changes from v1[1]: * removed virHasLastError() and s/virHasLastError/virGetLastErrorCode/g * replaced in missed files: virmodule.c and virnetlibsshsession.c * better split of patches [1] https://www.redhat.com/archives/libvir-list/2018-May/msg00259.html ramyelkest (3): util: cleanup: using

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-05 Thread David Kiarie
On Sat, May 5, 2018 at 12:15 PM, David Kiarie wrote: > Replace references to my name and email with a pseudonym > Sorry, I just want my real name and email off these files and I keep making silly mistakes. > > Signed-off-by: David Kiarie > ---

[libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-05 Thread David Kiarie
Replace references to my name and email with a pseudonym Signed-off-by: David Kiarie --- src/xenconfig/xen_xl.c | 2 +- src/xenconfig/xen_xl.h | 2 +- tests/xlconfigtest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/xenconfig/xen_xl.c

[libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-05 Thread David Kiarie
Replace references to my name and email with a pseudonym Signed-off-by: David Kiarie --- src/xenconfig/xen_xl.c | 2 +- src/xenconfig/xen_xl.h | 2 +- tests/xlconfigtest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/xenconfig/xen_xl.c