On Fri, Jun 08, 2018 at 12:13:39PM +0200, Andrea Bolognani wrote:
> We were only keeping it around so that we could generate
> package lists to use on Travis CI, so now that (with commit
> 01c0179fbec0) libvirt has switched to building on newer
> Ubuntu releases through Docker, we can finally drop
On Mon, Jun 11, 2018 at 03:38:16PM -0400, Anya Harter wrote:
> Currently, all virObjectEventStateQueue callers and
> virObjectEventStateQueueRemote callers need to do NULL checking.
>
> In this patch series, all NULL checking has been moved to
> virObjectEventStateQueueRemote and all callers of
In virConnectCredCallbackWrapper() we ignore the error case of
libvirt_charPtrUnwrap() function so we should also reset the exception.
Signed-off-by: Pavel Hrdina
---
libvirt-override.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libvirt-override.c
Pavel Hrdina (4):
libvirt-utils: remove unused py_str function
typewrappers: Fix libvirt_charPtrUnwrap to set an exception if it
fails
libvirt-override: Reset exception if the error is ignored
libvirt_charPtrUnwrap: remove unnecessary check of returned string
libvirt-override.c | 16
Function libvirt_charPtrUnwrap() either fails or always sets the
unwrapped string so there is no need to check it explicitly.
Signed-off-by: Pavel Hrdina
---
libvirt-override.c | 12
libvirt-utils.c| 10 +++---
2 files changed, 7 insertions(+), 15 deletions(-)
diff --git
If the function fails it should always set an exception.
Signed-off-by: Pavel Hrdina
---
typewrappers.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/typewrappers.c b/typewrappers.c
index 01ee310..99a8fb8 100644
--- a/typewrappers.c
+++ b/typewrappers.c
@@ -384,8
Commit <57a160b5248ba47d4e1c9d22d95847dad8e0524f> removed last usage
but did not remove the function itself.
Signed-off-by: Pavel Hrdina
---
libvirt-utils.c | 14 --
libvirt-utils.h | 1 -
2 files changed, 15 deletions(-)
diff --git a/libvirt-utils.c b/libvirt-utils.c
index
CCing libvir-list.
On Mon, Jun 11, 2018 at 11:29:24PM +0200, Igor Mammedov wrote:
> On Mon, 11 Jun 2018 16:06:07 -0300
> Eduardo Habkost wrote:
>
> > On Mon, Jun 11, 2018 at 03:16:25PM +0200, Igor Mammedov wrote:
> > > On Fri, 8 Jun 2018 10:21:05 -0300
> > > Eduardo Habkost wrote:
> > >
> > >
Since virConfGetValueBool() can return earlier, the parameter 'value'
might be not initialised properly inside this method. Another proof:
Valgrind is returning this error during the libvirtd daemon startup:
==16199== Conditional jump or move depends on uninitialised value(s)
==16199==at
And remove NULL checking from all callers
Signed-off-by: Anya Harter
---
src/bhyve/bhyve_driver.c | 15 +--
src/conf/object_event.c| 3 +++
src/lxc/lxc_driver.c | 24
src/lxc/lxc_process.c | 9 +++--
Currently, all virObjectEventStateQueue callers and
virObjectEventStateQueueRemote callers need to do NULL checking.
In this patch series, all NULL checking has been moved to
virObjectEventStateQueueRemote and all callers of the Remote or
not Remote function have their NULL checking removed.
>From remote_driver.c
And replace all calls with virObjectEventStateQueue such that:
remoteEventQueue(priv, event, callbackID);
becomes:
virObjectEventStateQueue(priv->eventState, event, callbackID);
Signed-off-by: Anya Harter
---
src/remote/remote_driver.c | 74
Remove NULL check from virObjectEventStateQueue and add NULL check to
virObjectEventStateQueueRemote
Remove NULL check around call to virObjectEventStateQueueRemote in
remote_driver.c
Signed-off-by: Anya Harter
---
src/conf/object_event.c| 6 +++---
src/remote/remote_driver.c | 3 +--
2
On Mon, 11 Jun 2018 at 16:35, Pavel Hrdina wrote:
>
> On Mon, Jun 11, 2018 at 12:59:11PM +0200, Martin Kletzander wrote:
> > On Mon, Jun 11, 2018 at 12:53:47PM +0200, Erik Skultety wrote:
> > > On Mon, Jun 11, 2018 at 12:43:59PM +0200, Martin Kletzander wrote:
> > > > On Mon, Jun 11, 2018 at
It has been 9 years since the first release of Libvirt TCK, so I'm
happy to annonunce a second ever release, with countless accumulated
bug fixes and features, is now available from
https://libvirt.org/sources/tck/Sys-Virt-TCK-v1.0.0.tar.gz
The GPG signature:
Hi Erik,
On 06/11/2018 09:10 AM, Erik Skultety wrote:
On Fri, Jun 08, 2018 at 10:14:35AM -0500, Brijesh Singh wrote:
Re: Jano's below comment
(Also, some of the patches have double "<< >>" around your e-mail,
how did that happen?)
I am not sure what I am doing that is causing the double
On Mon, Jun 11, 2018 at 04:59:54PM +0200, Peter Krempa wrote:
Move the code to a separate function.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 84 ++
1 file changed, 50 insertions(+), 34 deletions(-)
Reviewed-by: Ján Tomko
Jano
On Mon, Jun 11, 2018 at 04:59:52PM +0200, Peter Krempa wrote:
Extract and refactor the code to use the new approach which allows to
delete a monster condition to check if the element needs to be
formatted.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 116
On Mon, Jun 11, 2018 at 04:59:53PM +0200, Peter Krempa wrote:
Formatting of 'driver' already used a separate buffer but was part of
the main function. Separate it and remove bunch of unnecessary temporary
variables.
Note that some checks are removed but they are not really necessary
anyways.
On Wed, Jun 06, 2018 at 08:21:25PM -0400, John Ferlan wrote:
Fix the error message to indicate what exactly is failing - that
the controller index provided matches an existing controller.
Signed-off-by: John Ferlan
---
src/qemu/qemu_driver.c | 5 +++--
1 file changed, 3 insertions(+), 2
On Wed, Jun 06, 2018 at 08:21:26PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1583623
When attaching a virtio-scsi with IOThreads for the config of a
live domain, allow the to not be defined thus allowing
post parse processing to fill in the address.
Make the error
Move the code to a separate function.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 84 ++
1 file changed, 50 insertions(+), 34 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6461dfb936..30078bb14b
Split out various bits from the overly-long functions.
Peter Krempa (3):
conf: Use virXMLFormatElement to format disk IO tuning
conf: Use virXMLFormatElement to format disk 'driver' element
conf: Extract formatting of 'mirror' disk sub-element
src/conf/domain_conf.c | 321
Extract and refactor the code to use the new approach which allows to
delete a monster condition to check if the element needs to be
formatted.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 116 +++--
1 file changed, 54 insertions(+), 62
Formatting of 'driver' already used a separate buffer but was part of
the main function. Separate it and remove bunch of unnecessary temporary
variables.
Note that some checks are removed but they are not really necessary
anyways.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 121
On Wed, Jun 06, 2018 at 10:44:10AM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1559867
Add a check if the incoming with specified
already exists and if so fail the attach.
Looking at the reproducer steps, the bug talks about libvirt
auto-generating a duplicate
On 06/11/2018 01:50 PM, intrigeri wrote:
>
> 0001-AppArmor-allow-virt-aa-helper-read-access-to-Nova-s-.patch
>
>
>>From f4ea2da3ddeb275b3bd08b33ebe858dd6f7f274f Mon Sep 17 00:00:00 2001
> From: intrigeri
> Date: Sat, 9 Jun 2018 19:26:26 +
> Subject: [PATCH] AppArmor: allow virt-aa-helper
D-Bus object path element can contain only [a-zA-Z0-9_] characters so
we need to encode existing unique IDs. In case of UUID it's simple, we
just change '-' into '_' but in case of storage volumes we need to use
'key' which is arbitrary string.
This helpers encode the string using this
On Fri, Jun 08, 2018 at 10:14:35AM -0500, Brijesh Singh wrote:
>
> Re: Jano's below comment
>
> (Also, some of the patches have double "<< >>" around your e-mail,
> how did that happen?)
>
> I am not sure what I am doing that is causing the double "<< >>" around my
> email address in some patches.
On Tue, Jun 05, 2018 at 05:23:18PM +0200, Fabiano Fidêncio wrote:
On Tue, Jun 5, 2018 at 4:16 PM, Michal Privoznik wrote:
On 06/03/2018 08:09 PM, Fabiano Fidêncio wrote:
virCgroupSetupBlkiotune() has been introduced in order to remove the
code duplication present between
On Fri, Jun 08, 2018 at 09:40:55AM -0500, Brijesh Singh wrote:
> Signed-off-by: Brijesh Singh <>
> ---
> src/qemu/qemu_capabilities.c | 7
> src/qemu/qemu_capabilities.h | 4 +++
> src/qemu/qemu_driver.c | 82
>
> 3 files changed, 93
On Mon, Jun 11, 2018 at 06:46:21PM +0800, Chen Hanxiao wrote:
From: Chen Hanxiao
s/glibc's_asprintf/glibc's asprintf
Signed-off-by: Chen Hanxiao
---
src/util/virstring.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
It might have been intentional to avoid syntax-check
On Fri, Jun 08, 2018 at 04:43:36PM +0200, Andrea Bolognani wrote:
> They're both pretty much guaranteed to be dragged in by
> other packages already, but since we're being explicit in
> the spec file might as well be explicit here too.
>
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Erik
On Mon, Jun 11, 2018 at 3:34 PM, Ján Tomko wrote:
> On Mon, May 28, 2018 at 12:28:19AM +0200, Fabiano Fidêncio wrote:
>>
>> This patchset finishes the conversion to virConfGetValue* functions,
>> started by Daniel Berrange a few months ago.
>>
>> Please, mind that although we could make
On Mon, May 28, 2018 at 12:28:19AM +0200, Fabiano Fidêncio wrote:
This patchset finishes the conversion to virConfGetValue* functions,
started by Daniel Berrange a few months ago.
Please, mind that although we could make virConfGetValue* functions more
generic in order to support numbers and
On Mon, May 28, 2018 at 12:28:24AM +0200, Fabiano Fidêncio wrote:
xenParseVfi() does a lot of stuff and, in order to make things cleaner,
let's split it in two new functions:
- xenParseVfi(): it's a new function that keeps the old name. It's
responsible for the whole per-Vfi logic from the old
On Mon, May 28, 2018 at 12:28:26AM +0200, Fabiano Fidêncio wrote:
While converting the functions of xen_common to use typesafe virConf
acessors, I've spotted a few memory leaks, which are fixed in this
patch.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 22
On Mon, Jun 11, 2018 at 2:48 PM, Erik Skultety wrote:
> On Mon, Jun 11, 2018 at 01:52:54PM +0200, Christian Ehrhardt wrote:
> > The base vfio has not much functionality but to provide a custom
> > container by opening this path.
> > See https://www.kernel.org/doc/Documentation/vfio.txt for more.
On Mon, May 28, 2018 at 12:28:23AM +0200, Fabiano Fidêncio wrote:
xenParsePCI() does a lot of stuff and, in order to make things cleaner,
let's split it in two new functions:
- xenParsePCI(): it's a new function that keeps the old name. It's
responsible for the whole per-PCI logic from the old
On Mon, Jun 11, 2018 at 02:48:16PM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
All other NWFilter APIs are merged but I forgot this one as Jano
noticed.
data/org.libvirt.NWFilter.xml | 4
src/nwfilter.c| 21 +
2 files changed, 25
On Mon, Jun 11, 2018 at 01:52:54PM +0200, Christian Ehrhardt wrote:
> The base vfio has not much functionality but to provide a custom
> container by opening this path.
> See https://www.kernel.org/doc/Documentation/vfio.txt for more.
>
> Systems with static hostdevs will get /dev/vfio/vfio by
Signed-off-by: Katerina Koukiou
---
All other NWFilter APIs are merged but I forgot this one as Jano
noticed.
data/org.libvirt.NWFilter.xml | 4
src/nwfilter.c| 21 +
2 files changed, 25 insertions(+)
diff --git a/data/org.libvirt.NWFilter.xml
Hi,
Michal Prívozník:
> On 06/11/2018 08:43 AM, Christian Ehrhardt wrote:
>> On Mon, Jun 11, 2018 at 8:12 AM, Michal Prívozník
>> wrote:
>>> Also, it would be nice if you can use your real name.
>>
>> We had the real name discussion before, but at least the S-O-B as agreed
>> last time should
The base vfio has not much functionality but to provide a custom
container by opening this path.
See https://www.kernel.org/doc/Documentation/vfio.txt for more.
Systems with static hostdevs will get /dev/vfio/vfio by virt-aa-hotplug
right from the beginning. But if the guest initially had no
Christian Ehrhardt:
> On Mon, Jun 11, 2018 at 8:12 AM, Michal Prívozník
> wrote:
>> Thank you for your exhaustive explanation. You've convinced me that it's
>> safe to merge this patch. However, what I still don't quite understand
>> is: Nova uses that path for ages, doesn't it? How come we've
On Wed, Dec 20, 2017 at 12:58 PM, Christian Ehrhardt <
christian.ehrha...@canonical.com> wrote:
> On Tue, Dec 19, 2017 at 5:26 PM, Jamie Strandboge
> wrote:
> > On Tue, 2017-12-19 at 16:03 +0100, Christian Ehrhardt wrote:
> >> vfio devices are generated on the fly, but the generic base is
> >>
On Fri, Jun 08, 2018 at 01:10:13PM -0400, John Ferlan wrote:
> Resolve a few things that have built up previous and a couple
> that are more recent.
>
> John Ferlan (6):
> vbox: Fix resource leak
> vbox: Fix resource leak
> qemu: Fix Coverity build for qemu_monitor
> test: Fix resource
On Mon, Jun 11, 2018 at 12:59:11PM +0200, Martin Kletzander wrote:
> On Mon, Jun 11, 2018 at 12:53:47PM +0200, Erik Skultety wrote:
> > On Mon, Jun 11, 2018 at 12:43:59PM +0200, Martin Kletzander wrote:
> > > On Mon, Jun 11, 2018 at 12:12:16PM +0200, Pavel Hrdina wrote:
> > > > On Sat, Jun 09,
On Mon, Jun 11, 2018 at 12:53:47PM +0200, Erik Skultety wrote:
On Mon, Jun 11, 2018 at 12:43:59PM +0200, Martin Kletzander wrote:
On Mon, Jun 11, 2018 at 12:12:16PM +0200, Pavel Hrdina wrote:
> On Sat, Jun 09, 2018 at 11:12:29PM +0200, Martin Kletzander wrote:
> > On Sat, Jun 09, 2018 at
From: Chen Hanxiao
This patch introduces --all to show all block devices info
of guests like:
virsh # domblkinfo --all
Target CapacityAllocation Physical
---
hda42949672960 9878110208 9878110208
vda
On Mon, Jun 11, 2018 at 12:43:59PM +0200, Martin Kletzander wrote:
> On Mon, Jun 11, 2018 at 12:12:16PM +0200, Pavel Hrdina wrote:
> > On Sat, Jun 09, 2018 at 11:12:29PM +0200, Martin Kletzander wrote:
> > > On Sat, Jun 09, 2018 at 10:06:55PM +0530, Sukrit Bhatnagar wrote:
> > > > Hi,
> > > >
> >
From: Chen Hanxiao
Introduce helper cmdDomblkinfoPrint for printing.
Signed-off-by: Chen Hanxiao
---
tools/virsh-domain-monitor.c | 39 ++--
1 file changed, 24 insertions(+), 15 deletions(-)
diff --git a/tools/virsh-domain-monitor.c
This series introduce --all to cmdDomblkinfo to show
all block devices info in one cmd.
Likes a combination of domblklist and domblkinfo.
v2:
add support --human for --all
v1.1
fix a self test
Chen Hanxiao (3):
cmdDomblkinfo: introduce helper cmdDomblkinfoPrint
cmdDomblkinfo: add --all
From: Chen Hanxiao
Update news for cmdDomblkinfo --all option.
Signed-off-by: Chen Hanxiao
---
docs/news.xml | 8
1 file changed, 8 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index e0cf381f33..c07db04809 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -193,6 +193,14
From: Chen Hanxiao
s/glibc's_asprintf/glibc's asprintf
Signed-off-by: Chen Hanxiao
---
src/util/virstring.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/virstring.h b/src/util/virstring.h
index fa2ec1df4d..607ae66e99 100644
--- a/src/util/virstring.h
+++
On Mon, Jun 11, 2018 at 12:12:16PM +0200, Pavel Hrdina wrote:
On Sat, Jun 09, 2018 at 11:12:29PM +0200, Martin Kletzander wrote:
On Sat, Jun 09, 2018 at 10:06:55PM +0530, Sukrit Bhatnagar wrote:
> Hi,
>
> I am starting this discussion thread as a continuation of my GSoC
> weekly meeting with
On Wed, Jun 06, 2018 at 08:21:26PM -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1583623
>
> When attaching a virtio-scsi with IOThreads for the config of a
> live domain, allow the to not be defined thus allowing
> post parse processing to fill in the address.
>
>
At 2018-06-09 04:49:08, "John Ferlan" wrote:
>
>
>On 06/07/2018 12:19 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> This patch introduces --all to show all block devices info
>> of guests like:
>>
>> virsh # domblkinfo w08 --all
>> Target CapacityAllocation Physical
On Fri, Jun 08, 2018 at 12:23:05PM +0200, Andrea Bolognani wrote:
> We're not supposed to use Jinja2 templates in this
> context, as recent versions of Ansible very helpfully
> point out.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/tasks/base.yml | 4 ++--
> 1 file changed, 2
On Sat, Jun 09, 2018 at 11:12:29PM +0200, Martin Kletzander wrote:
> On Sat, Jun 09, 2018 at 10:06:55PM +0530, Sukrit Bhatnagar wrote:
> > Hi,
> >
> > I am starting this discussion thread as a continuation of my GSoC
> > weekly meeting with Erik and Pavel on 8th June.
> >
> > I was going through
On Fri, Jun 08, 2018 at 04:35:18PM +0200, Andrea Bolognani wrote:
> Recent versions of Ansible point out this mistake too.
>
> Signed-off-by: Andrea Bolognani
> ---
> To be applied on top of
>
> https://www.redhat.com/archives/libvir-list/2018-June/msg00685.html
>
> Should have posted both
On Fri, 2018-06-08 at 22:05 +0400, Roman Bogorodskiy wrote:
> Add missing data files for bhyve cpu topology tests that should have been
> added in b66fda0a74.
>
> Signed-off-by: Roman Bogorodskiy
> ---
> Pushed under the build breaker rule.
Yup, that fixed it. Thanks :)
--
Andrea Bolognani /
On Fri, Jun 08, 2018 at 05:02:18PM +0800, Wang Huaqiang wrote:
---
The subject says 'virsh', but the code does:
include/libvirt/libvirt-domain.h| 9 +++
src/conf/domain_conf.c | 28 +++
src/conf/domain_conf.h | 3 +
something with XML parsing and/or
On Fri, Jun 08, 2018 at 05:02:17PM +0800, Wang Huaqiang wrote:
Add RDT/CMT feature (Intel x86) by interacting with kernel resctrl file system.
Integrate code into util/resctrl.
---
src/libvirt_private.syms | 9 ++
src/util/virresctrl.c| 316 ++-
[It would be nice if you wrapped the long lines]
On Fri, Jun 08, 2018 at 05:02:16PM +0800, Wang Huaqiang wrote:
This is an RFC request for supporting CPU Cache Monitoring Technology (CMT)
feature in libvirt. Since MBM is also another feature which is very close to
CMT, for simplicity we only
On Sat, Jun 09, 2018 at 10:06:55PM +0530, Sukrit Bhatnagar wrote:
> Hi,
>
> I am starting this discussion thread as a continuation of my GSoC
> weekly meeting with Erik and Pavel on 8th June.
>
> I was going through src/util/virstring.c for adding cleanup macros and
> saw that virStringListFree
On Mon, Jun 11, 2018 at 9:41 AM, Michal Prívozník
wrote:
> On 06/11/2018 08:43 AM, Christian Ehrhardt wrote:
> > On Mon, Jun 11, 2018 at 8:12 AM, Michal Prívozník
> > wrote:
> >
> >> On 06/11/2018 07:34 AM, Christian Ehrhardt wrote:
> >>>
> >>>
> >> Thank you for your exhaustive explanation.
On Fri, Jun 08, 2018 at 12:00:50PM -0400, John Ferlan wrote:
>
>
> On 06/08/2018 07:09 AM, Erik Skultety wrote:
> > On Mon, Jun 04, 2018 at 07:40:42PM -0400, John Ferlan wrote:
> >>
> >>
> >> On 05/30/2018 09:43 AM, Erik Skultety wrote:
> >>> Signed-off-by: Erik Skultety
> >>> ---
> >>>
On 06/11/2018 08:43 AM, Christian Ehrhardt wrote:
> On Mon, Jun 11, 2018 at 8:12 AM, Michal Prívozník
> wrote:
>
>> On 06/11/2018 07:34 AM, Christian Ehrhardt wrote:
>>>
>>>
>> Thank you for your exhaustive explanation. You've convinced me that it's
>> safe to merge this patch. However, what I
On Mon, Jun 11, 2018 at 8:12 AM, Michal Prívozník
wrote:
> On 06/11/2018 07:34 AM, Christian Ehrhardt wrote:
> > Hi Intrigeri and Michal,
> > IMHO this is the right path as it is stage one of the two stage process
> to
> > allow images for guests with apparmor.
> >
> > Stage 1:
> >
On Fri, Jun 08, 2018 at 17:11:55 -0300, Julio Faracco wrote:
> Since virConfGetValueBool() can return earlier, the parameter 'value'
> might be not initialised properly inside this method. Another proof:
Yeah, the problem is that if the value is not found, virConfGetValueBool
returns 0 which I
On 06/11/2018 07:34 AM, Christian Ehrhardt wrote:
> Hi Intrigeri and Michal,
> IMHO this is the right path as it is stage one of the two stage process to
> allow images for guests with apparmor.
>
> Stage 1:
> Virt-aa-helper has to be allowed to access the paths to evaluate images for
> some
72 matches
Mail list logo
