Re: [libvirt] [PATCH] vmx: allow an odd number of vCPUs

On Thursday, 14 June 2018 15:34:25 CEST Pino Toscano wrote: > Most probably this was a limitation in older ESX versions, and it seems > it does not exist anymore in more recent versions; see the following > thread: > https://www.redhat.com/archives/libvir-list/2018-May/msg02159.html >

[libvirt] [PATCH] docs: schema: Add missing to devices

For input,hub,redirdev devices, their sub-elements should be interleaved. input device: interleave for , , hub device: interleave for , redirdev device: interleave for , , , Signed-off-by: Han Han --- docs/schemas/domaincommon.rng | 60 +++ 1 file changed, 33

[libvirt] [PATCHv1 08/12] qemu_capabilities: QMPCommandPtr without shadow qmperr

Previously QMPCommandPtr (handle for issuing QMP commands) required an external char * qmperr to persist over the lifespan of QMPCommand to expose a QMP error string outside of QMPCommand. Specifically the external char *qmperr was required between calls to virQEMUCapsInitQMPCommandNew and

[libvirt] [PATCHv1 11/12] qemu_capabilities: Introduce virQEMUCapsQMPBaselineCPUModel (baseline using QEMU)

Baseline cpu model using QEMU/QMP query-cpu-model-baseline query-cpu-model-baseline only compares two CPUModels so multiple exchanges are needed to evaluate more than two CPUModels. --- src/qemu/qemu_capabilities.c | 89 src/qemu/qemu_capabilities.h | 4 ++

[libvirt] [PATCHv1 12/12] qemu_driver: BaselineHypervisorCPU supports S390 using QEMU/QMP

Transient S390 configurations require using QEMU to compute CPU Model Baseline and to do CPU Feature Expansion. Start and use a single QEMU instance to do both the baseline and expansion transactions required by BaselineHypervisorCPU. --- src/qemu/qemu_driver.c | 66

[libvirt] [PATCHv1 07/12] qemu_capabilities: virCPUDef / qemuMonitorCPUModelInfo conversions

Bi-directional conversion functions. Converts model / name and features / properties. --- src/qemu/qemu_capabilities.c | 137 +-- src/qemu/qemu_capabilities.h | 3 + 2 files changed, 118 insertions(+), 22 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCHv1 10/12] qemu_capabilities: Introduce virQEMUCapsNewQMPCommandConnection

Start and connect to QEMU so QMP commands can be performed. Isolates code for starting QEMU and establishing Monitor connections from code for obtaining capabilities so that arbitrary QMP commands can be exchanged with QEMU. --- src/qemu/qemu_capabilities.c | 40

[libvirt] [PATCHv1 05/12] qemu_monitor: CPUModelExpansion on CPUModel with both name and properties

Send both model name and a set of features/properties to QEMU for expansion rather than just the model name. --- src/qemu/qemu_capabilities.c | 33 +-- src/qemu/qemu_monitor.c | 38 ++ src/qemu/qemu_monitor.h | 5 ++- src/qemu/qemu_monitor_json.c |

[libvirt] [PATCHv1 01/12] qemu_monitor_json: qemuMonitorCPUModelInfo / JSON conversion

Bidirectional conversion functions between data structure and JSON. JSON of form: {"model": {"name": "IvyBridge", "props": {}}} --- src/qemu/qemu_monitor_json.c | 126 ++- 1 file changed, 96 insertions(+), 30 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c

[libvirt] [PATCHv1 00/12] BaselineHypervisorCPU using QEMU QMP exchanges

Some architectures (S390) depend on QEMU to compute baseline CPU model and expand a models feature set. Interacting with QEMU requires starting the QEMU process and completing one or more query-cpu-model-baseline QMP exchanges with QEMU in addition to a query-cpu-model-expansion QMP exchange to

[libvirt] [PATCHv1 06/12] cpu_conf: Calculate virCPUDef List Length function

Function returns number of virCPUDefPtrs in list --- src/conf/cpu_conf.c | 15 +++ src/conf/cpu_conf.h | 3 +++ src/libvirt_private.syms | 1 + 3 files changed, 19 insertions(+) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 43a3ab5dcd..ff978ec083 100644 ---

[libvirt] [PATCHv1 09/12] qemu_capabilities: Persist QEMU instance over multiple QMP Cmds

Makes possible to start a single QEMU instance and use that one instance for multiple independent QMP commands without starting and stopping QEMU for each QMP command type. This allows functions outside qemu_capabilities (ex. qemuConnectBaselineHypervisorCPU in qemu_driver) requiring multiple

[libvirt] [PATCHv1 04/12] qemu_monitor: Indicate when CPUModelInfo props report migratablity

Renamed variable in CPUModelInfo such that props_migratable_valid is true when properties in CPUModelInfo indicate if property is / isn't migratable. Property migratability is not part of QMP messages but rather is sometimes calculated within Libvirt and stored in CPUModelInfo properties. ---

[libvirt] [PATCHv1 02/12] qemu_monitor: Introduce qemuMonitorCPUModelInfoInit and qemuMonitorCPUModelInfoFreeContents

Init - Initial with model name and empty properties FreeContents - Free model name and properties without freeing pointer --- src/qemu/qemu_monitor.c | 37 - src/qemu/qemu_monitor.h | 4 2 files changed, 40 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCHv1 03/12] qemu_monitor: Introduce qemuMonitorGetCPUModelBaseline (query-cpu-model-baseline)

Wrap QMP query-cpu-model-baseline command transaction with QEMU. --- src/qemu/qemu_monitor.c | 13 src/qemu/qemu_monitor.h | 5 +++ src/qemu/qemu_monitor_json.c | 65 src/qemu/qemu_monitor_json.h | 7 4 files changed, 90 insertions(+)

Re: [libvirt] [GSoC] Code design for scalar and external types

On Mon, 18 Jun 2018 at 17:20, Andrea Bolognani wrote: > > On Mon, 2018-06-18 at 11:52 +0100, Daniel P. Berrangé wrote: > > On Mon, Jun 18, 2018 at 12:24:39PM +0200, Pavel Hrdina wrote: > > > # define VIR_DEFINE_AUTOCLEAR_FUNC(type, func) \ > > > static inline void

Re: [libvirt] [PATCH 2/2] qemu: Escape commas for qemuBuildSCSIiSCSIHostdevDrvStr

On 06/20/2018 09:17 AM, Anya Harter wrote: > Add comma escaping for netsource > > Signed-off-by: Anya Harter > --- > src/qemu/qemu_command.c | 4 +++- > tests/qemuxml2argvdata/name-escape.args | 6 +- > tests/qemuxml2argvdata/name-escape.xml | 7 +++ >

Re: [libvirt] [PATCH] qemu: Escape commas for qemuBuildDiskThrottling

On 06/19/2018 12:20 PM, Anya Harter wrote: > Add comma escaping for disk->blkdeviotune.group_name. > > Signed-off-by: Anya Harter > --- > src/qemu/qemu_command.c | 4 ++-- > tests/qemuxml2argvdata/name-escape.args | 5 + > tests/qemuxml2argvdata/name-escape.xml | 13

Re: [libvirt] [PATCH v3 4/4] news: add cmdDomblkinfo --all option

On 06/19/2018 06:01 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Update news for cmdDomblkinfo --all option. > > Signed-off-by: Chen Hanxiao > --- > v3: > update descriptions > > docs/news.xml | 10 ++ > 1 file changed, 10 insertions(+) > This needed to be in the 4.5.0

Re: [libvirt] [PATCH v3 3/4] cmdDomblkinfoPrint: support printing "-" for invalid virDomainBlockInfo

On 06/19/2018 06:01 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > For inactive domain, we'll set virDomainBlockInfo to 0 > if specific error code got. > Print "-" to show the value should be ignored in this scenario. > > Signed-off-by: Chen Hanxiao > --- > tools/virsh-domain-monitor.c |

Re: [libvirt] [PATCH v3 2/4] cmdDomblkinfo: add --all to show all block devices info

On 06/19/2018 06:01 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This patch introduces --all to show all block devices info > of guests like: > > virsh # domblkinfo w08 --all > Target CapacityAllocation Physical > --- > hda

Re: [libvirt] [RFC PATCH 0/2] Add new mdev type for aggregated resources

On Thu, 21 Jun 2018 19:57:38 +0530 Kirti Wankhede wrote: > On 6/20/2018 1:10 PM, Zhenyu Wang wrote: > > Current mdev device create interface depends on fixed mdev type, which get > > uuid > > from user to create instance of mdev device. If user wants to use customized > > number of resource for

[libvirt] ANNOUNCE: libvirt-dbus 1.1.0 released

I'm happy to announce the release of libvirt-dbus 1.1.0. libvirt-dbus wraps libvirt API to provide high-level object-oriented API better suited for dbus-based applications. You can download it here: https://libvirt.org/sources/dbus/libvirt-dbus-1.1.0.tar.gz * New features - Support

Re: [libvirt] [RFC PATCH 0/2] Add new mdev type for aggregated resources

On 6/20/2018 1:10 PM, Zhenyu Wang wrote: > Current mdev device create interface depends on fixed mdev type, which get > uuid > from user to create instance of mdev device. If user wants to use customized > number of resource for mdev device, then only can create new mdev type for > that >

[libvirt] [PATCH] spec: Move SASL configuration file from -libs to -daemon

SASL authentication is configured server-side, so the sample configuration file should be shipped along with the daemon rather than with the libraries. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libvirt.spec.in

Re: [libvirt] [jenkins-ci PATCH 2/2] jobs: Switch to github webhook instead of polling

On Thu, Jun 21, 2018 at 02:50:49PM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 21, 2018 at 03:37:49PM +0200, Andrea Bolognani wrote: > > On Thu, 2018-06-21 at 14:21 +0200, Pavel Hrdina wrote: > > [...] > > > @@ -31,8 +31,7 @@ > > > triggers: > > >- reverse: > > >jobs:

Re: [libvirt] [PATCH 1/2] virTypedParamsSerialize: minor fixes

On Thu, Jun 21, 2018 at 03:47 PM +0200, Marc Hartmayer wrote: > On Wed, Jun 13, 2018 at 03:11 PM +0200, John Ferlan > wrote: >> On 06/07/2018 08:17 AM, Marc Hartmayer wrote: >>> On Wed, May 09, 2018 at 09:51 PM +0200, John Ferlan >>> wrote: On 05/07/2018 11:24 AM, Marc Hartmayer wrote:

Re: [libvirt] [jenkins-ci PATCH 2/2] jobs: Switch to github webhook instead of polling

On Thu, Jun 21, 2018 at 03:37:49PM +0200, Andrea Bolognani wrote: > On Thu, 2018-06-21 at 14:21 +0200, Pavel Hrdina wrote: > [...] > > @@ -31,8 +31,7 @@ > > triggers: > >- reverse: > >jobs: '{obj:parent_jobs}' > > - - pollscm: > > - cron: "H/20 * * * *" > > +

Re: [libvirt] [PATCH 1/2] virTypedParamsSerialize: minor fixes

On Wed, Jun 13, 2018 at 03:11 PM +0200, John Ferlan wrote: > On 06/07/2018 08:17 AM, Marc Hartmayer wrote: >> On Wed, May 09, 2018 at 09:51 PM +0200, John Ferlan >> wrote: >>> On 05/07/2018 11:24 AM, Marc Hartmayer wrote: On Mon, Apr 30, 2018 at 03:20 PM +0200, John Ferlan wrote:

[libvirt] [PATCH] news: Document recent agent job change

Signed-off-by: Michal Privoznik --- docs/news.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 08e5dcbda3..a3eea4eff6 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -71,6 +71,19 @@ Capabilities XML now provide information

Re: [libvirt] [jenkins-ci PATCH 2/2] jobs: Switch to github webhook instead of polling

On Thu, 2018-06-21 at 14:21 +0200, Pavel Hrdina wrote: [...] > @@ -31,8 +31,7 @@ > triggers: >- reverse: >jobs: '{obj:parent_jobs}' > - - pollscm: > - cron: "H/20 * * * *" > + - github As noted in the review for the previous patch libosinfo:

Re: [libvirt] [jenkins-ci PATCH 1/2] jobs: Change git URL to github

On Thu, 2018-06-21 at 14:21 +0200, Pavel Hrdina wrote: > We had our own local copy of all projects synchronized by cron on > the host where we have the CI VMs. This was to safe the traffic from > libvirt.org repositories and to make the cloning for our Jenkins jobs > faster. > > We might move

[libvirt] [PATCH] virDomainSnapshotDefParse: Prefer VIR_STEAL_PTR

Signed-off-by: Michal Privoznik --- src/conf/snapshot_conf.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index 787c3d0feb..9c537ac7d1 100644 --- a/src/conf/snapshot_conf.c +++ b/src/conf/snapshot_conf.c @@ -331,8

[libvirt] [jenkins-ci PATCH 0/2] git changes to reflect new CI configuration

Pavel Hrdina (2): jobs: Change git URL to github jobs: Switch to github webhook instead of polling jobs/autotools.yaml| 5 ++--- jobs/generic.yaml | 5 ++--- jobs/go.yaml | 5 ++--- jobs/perl-modulebuild.yaml | 5 ++--- jobs/python-distutils.yaml | 5 ++--- 5

[libvirt] [jenkins-ci PATCH 1/2] jobs: Change git URL to github

We had our own local copy of all projects synchronized by cron on the host where we have the CI VMs. This was to safe the traffic from libvirt.org repositories and to make the cloning for our Jenkins jobs faster. We might move our VMs into a cloud in future we would not be able to have any local

[libvirt] [jenkins-ci PATCH 2/2] jobs: Switch to github webhook instead of polling

If we use github as the remote repository we can take advantage of github webhooks in order to trigger our Jobs instead of blind polling. CentOS CI provides that option [1]. [1] Signed-off-by: Pavel Hrdina --- jobs/autotools.yaml| 3 +--

Re: [libvirt] [PATCH 1/2] qemuDomainObjBeginJobInternal: Log agent job too

On Wed, Jun 20, 2018 at 14:32:03 +0200, Michal Privoznik wrote: > If a thread is unable to start a job (e.g. because of timeout) > an warning is printed into the logs. So far, the message does not s/an/a/ > contain agent job info. Add it as it might help future debugging. > > Signed-off-by:

[libvirt] [PATCH] set-lifecycle-action: add description of type and action

From: Chen Hanxiao In [1], are described as "on_poweroff", "on_reboot", "on_crash". but we accept "poweroff", "reboot" and "crash". This patch adds docs about them. [1]: https://libvirt.org/formatdomain.html#elementsEvents Signed-off-by: Chen Hanxiao --- tools/virsh.pod | 8 ++--

Re: [libvirt] [dbus PATCH v2 0/5] tests: Some fixes and cleanups

On Thu, Jun 21, 2018 at 01:04:54PM +0200, Andrea Bolognani wrote: > Changes from [v1]: > > * use the correct paths; > * fix running libvirt-dbus from VPATH builds; > * fix distcheck. > > [v1] https://www.redhat.com/archives/libvir-list/2018-June/msg01453.html > > Andrea Bolognani (5): >

[libvirt] [dbus PATCH v2 2/5] run: Fix VIRT_DBUS_INTERFACES_DIR

The D-Bus interface files are in the source directory, not in the build directory. Signed-off-by: Andrea Bolognani --- run.in | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/run.in b/run.in index e98edaf..03e7c64 100644 --- a/run.in +++ b/run.in @@ -14,9 +14,6 @@ #

[libvirt] [dbus PATCH v2 4/5] tests: Drop fallback path for abs_top_builddir

We have made sure all callers set up the environment correctly, so it's pointless to have a fallback path now. Signed-off-by: Andrea Bolognani --- tests/libvirttest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libvirttest.py b/tests/libvirttest.py index

[libvirt] [dbus PATCH v2 1/5] tests: Include xmldata.py in EXTRA_DIST

This fixes distcheck. Signed-off-by: Andrea Bolognani --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index e841627..3872d7b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,4 +1,5 @@ test_helpers = \ +

[libvirt] [dbus PATCH v2 5/5] tests: Use AM_TESTS_ENVIRONMENT

According to the documentation[1], TESTS_ENVIRONMENT is reserved for the user, which means we shouldn't be using it. AM_TESTS_ENVIRONMENT needs to be terminated with a semicolon, which in turn requires exporting the variables instead of merely declaring them, so do both of those things; since

[libvirt] [dbus PATCH v2 3/5] run: Export abs_top_builddir

The test suite uses this environment variable, if it's present, to locate the libvirt-dbus binary. Signed-off-by: Andrea Bolognani --- run.in | 1 + 1 file changed, 1 insertion(+) diff --git a/run.in b/run.in index 03e7c64..0744a80 100644 --- a/run.in +++ b/run.in @@ -14,6 +14,7 @@ # ./run

[libvirt] [dbus PATCH v2 0/5] tests: Some fixes and cleanups

Changes from [v1]: * use the correct paths; * fix running libvirt-dbus from VPATH builds; * fix distcheck. [v1] https://www.redhat.com/archives/libvir-list/2018-June/msg01453.html Andrea Bolognani (5): tests: Include xmldata.py in EXTRA_DIST run: Fix VIRT_DBUS_INTERFACES_DIR run: Export

Re: [libvirt] [PATCH] cpu: add 'amd-ssbd' and 'amd-no-ssb' CPU features (CVE-2018-3639)

On Thu, Jun 21, 2018 at 12:24:13PM +0200, Kashyap Chamarthy wrote: > On Thu, Jun 14, 2018 at 11:48:41AM +0100, Daniel P. Berrangé wrote: > > [...] > > > Note that neither amd-ssbd or amd-no-ssb will be reported by the kernel > > in /proc/cpuinfo. It knows about these CPUID bits and does the

Re: [libvirt] [PATCH] cpu: add 'amd-ssbd' and 'amd-no-ssb' CPU features (CVE-2018-3639)

On Thu, Jun 14, 2018 at 11:48:41AM +0100, Daniel P. Berrangé wrote: [...] > Note that neither amd-ssbd or amd-no-ssb will be reported by the kernel > in /proc/cpuinfo. It knows about these CPUID bits and does the right thing, > but doesn't report their existance as distinct flags in

[libvirt] [PATCH 0/1] *** SUBJECT HERE ***

*** BLURB HERE *** Han Han (1): docs: schema: Add missing to devices docs/schemas/domaincommon.rng | 60 +++ 1 file changed, 33 insertions(+), 27 deletions(-) -- 2.17.1 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 1/1] docs: schema: Add missing to devices

input device: , , should be interleaved. hub device: , should be interleaved. redirdev device: , , , should be interleaved. Signed-off-by: Han Han --- docs/schemas/domaincommon.rng | 60 +++ 1 file changed, 33 insertions(+), 27 deletions(-) diff --git

Re: [libvirt] [PATCH] schema: allow a element with no subelements in a nwfilter

On 06/21/2018 08:12 AM, Laine Stump wrote: > This is a regression in behavior caused by commit 37359814. It was > intended to limit the schema to allow only a single subelement of > , but it is also acceptable for to have no subelement at > all. > > To prevent the same error from reoccurring in

Re: [libvirt] [PATCH 0/2] Two small problems with hyperv Makefile

On 06/21/2018 09:54 AM, Laine Stump wrote: > I found these when make failed after running "make maintainer-clean". > > Laine Stump (2): > hyperv: fix typo in Makefile.am.inc > hyperv: erase "generated files" sentinel during make maintainer-clean > > src/hyperv/Makefile.inc.am | 6 +++--- >

Re: [libvirt] [dbus PATCH 3/3] tests: Use AM_TESTS_ENVIRONMENT

On Wed, Jun 20, 2018 at 02:20:29PM +0200, Andrea Bolognani wrote: > According to the documentation[1], TESTS_ENVIRONMENT > is reserved for the user, which means we shouldn't be > using it. > > AM_TESTS_ENVIRONMENT needs to be terminated with a > semicolon, so do that; that requires exporting the

[libvirt] [PATCH 0/2] Two small problems with hyperv Makefile

I found these when make failed after running "make maintainer-clean". Laine Stump (2): hyperv: fix typo in Makefile.am.inc hyperv: erase "generated files" sentinel during make maintainer-clean src/hyperv/Makefile.inc.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.14.4

[libvirt] [PATCH 2/2] hyperv: erase "generated files" sentinel during make maintainer-clean

Re-generating of generated source files in the hyperv directory depends on src/.hyperv_wmi_generator.stamp not existing, or having a timestamp older than src/hyperv/hyperv_wmi_generator.py. "make maintainer-clean" erases the generated files, but not this sentinel file, so the erased files aren't

[libvirt] [PATCH 1/2] hyperv: fix typo in Makefile.am.inc

The problem has been around for quite awhile - the misspelling was faithfully copied from src/Makefile.am to src/hyperv/Makefile.am.inc in commit 253b528c. Signed-off-by: Laine Stump --- src/hyperv/Makefile.inc.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [dbus PATCH 2/3] tests: Don't loop up abs_top_builddir in the environment

On Wed, Jun 20, 2018 at 02:20:28PM +0200, Andrea Bolognani wrote: > This only works if the caller has prepared the environment > accordingly; however, there is already a fallback path in > place and it works just fine, so much so that when test > cases are executed manually through the 'run'

Re: [libvirt] [dbus PATCH 1/3] tests: Fix VIRT_DBUS_INTERFACES_DIR

On Wed, Jun 20, 2018 at 02:20:27PM +0200, Andrea Bolognani wrote: > D-Bus interface files are generated, so we need to look > for them inside builddir instead of srcdir for the test > suite to pass before installation. > > Signed-off-by: Andrea Bolognani > --- > tests/Makefile.am | 2 +- > 1

Re: [libvirt] [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

On Wed, Jun 20, 2018 at 02:28:24PM -0300, Eduardo Habkost wrote: > On Mon, Jun 18, 2018 at 08:18:16PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jun 18, 2018 at 02:14:31PM -0300, Eduardo Habkost wrote: > > > > Sure if someone does that, we'll have no choice, but as long as 'pc' is > > > >

Re: [libvirt] [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

On Wed, Jun 20, 2018 at 06:33:51PM +0100, Peter Maydell wrote: > On 18 June 2018 at 18:18, Michael S. Tsirkin wrote: > > On Mon, Jun 18, 2018 at 02:14:31PM -0300, Eduardo Habkost wrote: > >> > Sure if someone does that, we'll have no choice, but as long as 'pc' is > >> > shipped we shouldn't

[libvirt] [PATCH] schema: allow a element with no subelements in a nwfilter

This is a regression in behavior caused by commit 37359814. It was intended to limit the schema to allow only a single subelement of , but it is also acceptable for to have no subelement at all. To prevent the same error from reoccurring in the future, the examples/xml/nwfilter directory was