Re: [libvirt] [PATCH 1/8] snapshots: Avoid term 'checkpoint' for full system snapshot

2018-06-22 Thread John Ferlan
On 06/13/2018 12:42 PM, Eric Blake wrote: > Upcoming patches plan to introduce virDomainCheckpointPtr as a new > object for use in incremental backups, along with documentation > how incremental backups differ from snapshots. But first, we need > to rename any existing mention of a 'system

Re: [libvirt] [qemu-s390x] request a revert for "block: Remove deprecated -drive option serial" (was block: Remove deprecated -drive option serial)

2018-06-22 Thread Thomas Huth
On 22.06.2018 14:51, Christian Borntraeger wrote: > adding more CC. > > On 06/22/2018 01:38 PM, Christian Borntraeger wrote: >> >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: >>> The -drive option serial was deprecated in QEMU 2.10. It's time to >>> remove it. >>> >>> Tests need to be updated to

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 17:40 hat Daniel P. Berrangé geschrieben: > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > This was in fact one release longer than our deprecation policy says. > > Are we serious about the deprecation policy or aren't we? > > > > I might consider reverting a

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 05:01 PM, Kevin Wolf wrote: > Am 22.06.2018 um 16:38 hat Christian Borntraeger geschrieben: >> >> >> On 06/22/2018 04:25 PM, Kevin Wolf wrote: >>> Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: On 06/22/2018 02:55 PM, Kevin Wolf wrote: > Am

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > >> > > >> On 06/15/2018 04:21 PM, Kevin Wolf

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 16:38 hat Christian Borntraeger geschrieben: > > > On 06/22/2018 04:25 PM, Kevin Wolf wrote: > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > >> > >> > >> On 06/22/2018 02:55 PM, Kevin Wolf wrote: > >>> Am 22.06.2018 um 13:38 hat Christian Borntraeger

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Eric Blake
On 06/22/2018 09:30 AM, Daniel P. Berrangé wrote: Perhaps we could use a more structured notification, to make detecting use of deprecated features programmatically trivial. A QMP event might do. Libvirt currently has CI that is largely focused on unit testing. We recently did some work,

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Peter Maydell
On 22 June 2018 at 15:38, Christian Borntraeger wrote: > So if everyone has adopted we can certainly follow our deprecation policy. > Now if deprecation breaks some real world cases it makes no sense to > "insist" on that deprecation policy. Really: If latest greatest libvirt > does not work 2

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 04:25 PM, Kevin Wolf wrote: > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: >> >> >> On 06/22/2018 02:55 PM, Kevin Wolf wrote: >>> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: On 06/15/2018 04:21 PM, Kevin Wolf wrote: > The -drive

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > >> > > >> On 06/15/2018 04:21 PM, Kevin Wolf

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 03:25:19PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 22, 2018 at 04:19:29PM +0200, Markus Armbruster wrote: > > Kevin Wolf writes: > > > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > >> > > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > > >>

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 04:19:29PM +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > >> > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > >> > The -drive option serial was deprecated in QEMU 2.10. It's time to > >> > remove

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > >> > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > >>> The -drive option serial was deprecated in QEMU 2.10. It's

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Markus Armbruster
Kevin Wolf writes: > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >> >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: >> > The -drive option serial was deprecated in QEMU 2.10. It's time to >> > remove it. >> > >> > Tests need to be updated to set the serial number with -global

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 03:36:50PM +0200, Christian Borntraeger wrote: > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > >> > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > >>> The -drive option serial was deprecated in QEMU 2.10.

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 03:36 PM, Christian Borntraeger wrote: > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: >> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >>> >>> On 06/15/2018 04:21 PM, Kevin Wolf wrote: The -drive option serial was deprecated in QEMU 2.10. It's time to

Re: [libvirt] [RFC PATCH 0/2] Add new mdev type for aggregated resources

2018-06-22 Thread Kirti Wankhede
On 6/22/2018 1:12 PM, Zhenyu Wang wrote: > On 2018.06.21 09:00:28 -0600, Alex Williamson wrote: >> On Thu, 21 Jun 2018 19:57:38 +0530 >> Kirti Wankhede wrote: >> >>> On 6/20/2018 1:10 PM, Zhenyu Wang wrote: Current mdev device create interface depends on fixed mdev type, which get

Re: [libvirt] [PATCH] docs: formatdomain: Note the caveats for CPU policy option "force"

2018-06-22 Thread Kashyap Chamarthy
On Fri, Jun 22, 2018 at 02:19:52PM +0200, Jiri Denemark wrote: > On Tue, Jun 12, 2018 at 10:58:46 +0200, Kashyap Chamarthy wrote: [...] > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in > > index 6912762f28..4d6c3892ee 100644 > > --- a/docs/formatdomain.html.in > > +++

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 02:55 PM, Kevin Wolf wrote: > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >> >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: >>> The -drive option serial was deprecated in QEMU 2.10. It's time to >>> remove it. >>> >>> Tests need to be updated to set the serial

Re: [libvirt] [PATCH 2/2] qemu: Escape commas for qemuBuildSCSIiSCSIHostdevDrvStr

2018-06-22 Thread Anya Harter
On 06/21/2018 06:55 PM, John Ferlan wrote: > > > On 06/20/2018 09:17 AM, Anya Harter wrote: >> Add comma escaping for netsource >> >> Signed-off-by: Anya Harter >> --- >> src/qemu/qemu_command.c | 4 +++- >> tests/qemuxml2argvdata/name-escape.args | 6 +- >>

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > On 06/15/2018 04:21 PM, Kevin Wolf wrote: > > The -drive option serial was deprecated in QEMU 2.10. It's time to > > remove it. > > > > Tests need to be updated to set the serial number with -global instead > > of using the -drive

[libvirt] request a revert for "block: Remove deprecated -drive option serial" (was block: Remove deprecated -drive option serial)

2018-06-22 Thread Christian Borntraeger
adding more CC. On 06/22/2018 01:38 PM, Christian Borntraeger wrote: > > On 06/15/2018 04:21 PM, Kevin Wolf wrote: >> The -drive option serial was deprecated in QEMU 2.10. It's time to >> remove it. >> >> Tests need to be updated to set the serial number with -global instead >> of using the

Re: [libvirt] [PATCH] docs: formatdomain: Note the caveats for CPU policy option "force"

2018-06-22 Thread Jiri Denemark
On Tue, Jun 12, 2018 at 10:58:46 +0200, Kashyap Chamarthy wrote: > Eduardo Habkost has pointed out that the current documentation of > libvirt's CPU feature policy "require" vs. "force" does not match > QEMU's behaviour. > > Update the documentation by spelling out the QEMU version dependency and

Re: [libvirt] [PATCH v3 19/20] nwfilter: wire up new APIs for creating and deleting nwfilter bindings

2018-06-22 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 04:59:50PM -0400, John Ferlan wrote: > > > On 06/14/2018 08:33 AM, Daniel P. Berrangé wrote: > > This allows the virsh commands nwfilter-binding-create and > > nwfilter-binding-delete to be used. > > > > Note using these commands lets you delete filters that were > >

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/15/2018 04:21 PM, Kevin Wolf wrote: > The -drive option serial was deprecated in QEMU 2.10. It's time to > remove it. > > Tests need to be updated to set the serial number with -global instead > of using the -drive option. libvirt 4.5 still creates those (at least on s390x)

Re: [libvirt] [PATCH v3 17/20] nwfilter: remove virt driver callback layer for rebuilding filters

2018-06-22 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 04:59:37PM -0400, John Ferlan wrote: > > > On 06/14/2018 08:33 AM, Daniel P. Berrangé wrote: > > Now that the nwfilter driver keeps a list of bindings that it has > > created, there is no need for the complex virt driver callbacks. It is > > possible to simply iterate of

Re: [libvirt] [PATCH v3 16/20] nwfilter: keep track of active filter bindings

2018-06-22 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 04:59:12PM -0400, John Ferlan wrote: > > > On 06/14/2018 08:33 AM, Daniel P. Berrangé wrote: > > Currently the nwfilter driver does not keep any record of what filter > > bindings it has active. This means that when it needs to recreate > > filters, it has to rely on

Re: [libvirt] [PATCH v3 14/20] conf: introduce a virNWFilterBindingObjPtr struct

2018-06-22 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 10:08:00AM -0400, John Ferlan wrote: > > > On 06/14/2018 08:33 AM, Daniel P. Berrangé wrote: > > Introduce a new struct to act as the stateful owner of the > > virNWFilterBindingDefPtr objects. > > > > Signed-off-by: Daniel P. Berrangé > > --- > >

Re: [libvirt] [PATCH v3 11/20] nwfilter: convert IP address learning code to virNWFilterBindingDefPtr

2018-06-22 Thread Daniel P . Berrangé
On Sun, Jun 17, 2018 at 08:28:11AM -0400, John Ferlan wrote: > > > On 06/14/2018 08:33 AM, Daniel P. Berrangé wrote: > > Use the virNWFilterBindingDefPTr struct in the IP address learning code > > directly. > > > > Reviewed-by: John Ferlan > > Signed-off-by: Daniel P. Berrangé > > --- > >

Re: [libvirt] [PATCH v3 09/20] virsh: add nwfilter binding commands

2018-06-22 Thread Daniel P . Berrangé
On Sun, Jun 17, 2018 at 08:27:27AM -0400, John Ferlan wrote: > > > On 06/14/2018 08:32 AM, Daniel P. Berrangé wrote: > > $ virsh nwfilter-binding-list > > Port Dev Filter > > -- > > vnet0

[libvirt] [PATCH] formatdomain.html.in: Amend the 'random' RNG backend section

2018-06-22 Thread Kashyap Chamarthy
Since libvirt 1.3.4, any RNG source is accepted for the 'random' backend. However, '/dev/urandom' is the _recommended_ source of entropy. Mention it so in the docs. Suggested-by: Daniel P. Berrangé Signed-off-by: Kashyap Chamarthy --- docs/formatdomain.html.in | 16 ++-- 1 file

[libvirt] [PATCH] qemu: ensure FDs passed to QEMU for chardevs have correct SELinux labels

2018-06-22 Thread Daniel P . Berrangé
The UNIX socket FDs were we passing to QEMU inherited a label based on libvirtd's context. QEMU is thus denied ability to access the UNIX socket. We need to use the security manager to change our current context temporarily when creating the UNIX socket FD. Signed-off-by: Daniel P. Berrangé ---

Re: [libvirt] [PATCH] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()

2018-06-22 Thread Jiri Denemark
On Wed, Jun 20, 2018 at 16:45:27 +0800, Weilun Zhu wrote: > As qemuMonitorJSONIOProcess will call qemuMonitorJSONIOProcessEvent > which unlocks the monitor mutex, there is some extreme situation, > eg qemu send message to monitor twice in a short time, where the > local viriable 'msg' of

Re: [libvirt] [PATCH] news: Document recent agent job change

2018-06-22 Thread Erik Skultety
On Thu, Jun 21, 2018 at 03:38:12PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] vmx: allow an odd number of vCPUs

2018-06-22 Thread Jiri Denemark
On Thu, Jun 14, 2018 at 15:34:25 +0200, Pino Toscano wrote: > Most probably this was a limitation in older ESX versions, and it seems > it does not exist anymore in more recent versions; see the following > thread: > https://www.redhat.com/archives/libvir-list/2018-May/msg02159.html >

Re: [libvirt] [PATCH 2/2] qemuDomainObjBeginJobInternal: Report agent job in error message

2018-06-22 Thread Jiri Denemark
On Wed, Jun 20, 2018 at 14:32:04 +0200, Michal Privoznik wrote: > If a thread is unable to acquire a job (e.g. because of timeout) > an error is reported and the error message contains reference to > the other thread holding the job. Well, the error message should > report agent job too as it is

Re: [libvirt] [RFC PATCH 0/2] Add new mdev type for aggregated resources

2018-06-22 Thread Zhenyu Wang
On 2018.06.21 09:00:28 -0600, Alex Williamson wrote: > On Thu, 21 Jun 2018 19:57:38 +0530 > Kirti Wankhede wrote: > > > On 6/20/2018 1:10 PM, Zhenyu Wang wrote: > > > Current mdev device create interface depends on fixed mdev type, which > > > get uuid > > > from user to create instance of mdev

Re: [libvirt] [PATCH] virDomainSnapshotDefParse: Prefer VIR_STEAL_PTR

2018-06-22 Thread Erik Skultety
On Thu, Jun 21, 2018 at 02:45:43PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- Trivial.. Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list