On 06/15/2018 05:29 AM, bing@intel.com wrote:
> From: Bing Niu
>
> resctrl not only supports cache tuning, but also memory bandwidth
> tuning. Rename cachetune to restune(resource tuning) to reflect
> that.
>
> Signed-off-by: Bing Niu
> ---
> src/conf/domain_conf.c | 44
On 06/15/2018 05:29 AM, bing@intel.com wrote:
> From: Bing Niu
>
> Introduce a new section memorytune to support memory bandwidth allocation.
> This is consistent with existing cachetune . As the example
> below:
>
>
>
>
The formatting above needed to
On 06/15/2018 05:29 AM, bing@intel.com wrote:
> From: Bing Niu
>
> Add memory bandwidth allocation support basing on existing
s/basing/based
> virresctrl implementation. Two new structures virResctrlInfoMB
^^
"cache" (IOW: fit it in between)
> and virResctrlAllocMB are
On 06/15/2018 05:29 AM, bing@intel.com wrote:
> From: Bing Niu
>
> Renaming some functions and packing some CAT logic into functions
Try to do one "thing" per patch - the "and" gives it away...
Thus one patch could rename various functions and other one(s) do the
"refactor" (not
I'm a bit late for RC2 but it's now tagged in git and signed tarball
and rpms have been pushed to the usual place:
ftp://libvirt.org/libvirt/
This seems to works fine in my limited testing but please continue
testing it. I will probably not push the final GA version before Monday
On Fri, Jun 29, 2018 at 06:01:16PM +0200, Andrea Bolognani wrote:
> We're going to start using libtool convenience libraries
> in a second.
>
> Signed-off-by: Andrea Bolognani
> ---
> .gitignore | 9 +
> configure.ac | 1 +
> 2 files changed, 10 insertions(+)
We should also update
On Fri, Jun 29, 2018 at 11:14:17AM +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 28, 2018 at 04:52:27PM -0300, Eduardo Habkost wrote:
[...]
> > I'm not sure what would be the best way to encode two types of
> > information, though:
> >
> > * Fallback/alternatives info, e.g.: "It makes sense to
On Fri, 2018-06-29 at 19:02 +0200, Pavel Hrdina wrote:
> On Fri, Jun 29, 2018 at 06:01:15PM +0200, Andrea Bolognani wrote:
> > +AM_LDFLAGS = \
> > + $(GIO2_LDFLAGS) \
> > + $(GLIB2_LDFLAGS) \
> > + $(LIBVIRT_LDFLAGS) \
> > + $(LIBVIRT_GLIB_LDFLAGS) \
> > + $(RELRO_LDFLAGS) \
> > +
On Fri, 2018-06-29 at 18:01 +0200, Andrea Bolognani wrote:
> Ignore patterns are shell globs, so '.' doesn't need
> escaping.
>
> Signed-off-by: Andrea Bolognani
> ---
> .gitignore | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitignore b/.gitignore
> index
On Fri, Jun 29, 2018 at 11:19:17AM +0100, Daniel P. Berrangé wrote:
> On Fri, Jun 29, 2018 at 09:53:53AM +0100, Dr. David Alan Gilbert wrote:
[...]
> > We're going to have to say something like:
> > 'For the new XYZ vulnerability make sure you're using
> > Haswell-3.2 or later, SkyLake-2.6 or
On Fri, Jun 29, 2018 at 06:01:15PM +0200, Andrea Bolognani wrote:
> There's nothing target-specific about either. This is
> going to be useful later on.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/Makefile.am | 35 ---
> 1 file changed, 16 insertions(+), 19
All files listed in a *_SOURCE directive are automatically
distributed, so listing them explicitly is pointless.
This makes DAEMON_SOURCES unnecessary, so we can drop it
and list source files in libvirt_dbus_SOURCES directly
instead.
Signed-off-by: Andrea Bolognani
---
src/Makefile.am | 11
libvirt already uses xz compression, so we can safely
follow suit.
Signed-off-by: Andrea Bolognani
---
.gitignore | 2 +-
configure.ac | 2 +-
libvirt-dbus.spec.in | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/.gitignore b/.gitignore
index
Some of the variables that contain lists of files that
will undergo pre-processing follow the *_in_files naming
convention to highlight the fact; let's be consistent
about it.
Signed-off-by: Andrea Bolognani
---
data/Makefile.am | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
This is the recommended mode of operation.
Signed-off-by: Andrea Bolognani
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index eef0834..b6261a0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5,7 +5,7 @@
Signed-off-by: Andrea Bolognani
---
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 3ef3472..de30df1 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -40,7 +40,7 @@ libvirt_dbus_LDFLAGS = \
test_programs is included in EXTRA_DIST, so we need to
make sure compiled binaries don't end in there or they
will be included in release archives.
Signed-off-by: Andrea Bolognani
---
tests/Makefile.am | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/Makefile.am
It all started when I got
tests/Makefile.am:17: warning: source file '$(top_srcdir)/src/util.c' is in a
subdirectory,
tests/Makefile.am:17: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory,
Sticking to one item per line will ensure future diffs
are minimal and easily understandable. More in general,
being consistent is good :)
Signed-off-by: Andrea Bolognani
---
Makefile.am | 12 +---
data/Makefile.am | 32 +++-
docs/Makefile.am | 16
libvirt already use both options and libvirt-dbus only
targets a subset of the platforms, so we can safely
enable them.
Signed-off-by: Andrea Bolognani
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index b6261a0..fff237a 100644
We're going to start using libtool convenience libraries
in a second.
Signed-off-by: Andrea Bolognani
---
.gitignore | 9 +
configure.ac | 1 +
2 files changed, 10 insertions(+)
diff --git a/.gitignore b/.gitignore
index b792bac..48e0411 100644
--- a/.gitignore
+++ b/.gitignore
@@
Ignore patterns are shell globs, so '.' doesn't need
escaping.
Signed-off-by: Andrea Bolognani
---
.gitignore | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 28a7c57..b792bac 100644
--- a/.gitignore
+++ b/.gitignore
@@ -21,7 +21,7 @@ vgcore.*
Includes should be part of *_CPPFLAGS, not *_CFLAGS; since
we have to move the include around anyway, might as well
make it global instead of limiting it to the single test
binary we're building at the moment.
Signed-off-by: Andrea Bolognani
---
tests/Makefile.am | 5 -
1 file changed, 4
No point in declaring it if we're not going to use it.
Signed-off-by: Andrea Bolognani
---
src/Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index de30df1..4662348 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -19,7 +19,6 @@
There's nothing target-specific about either. This is
going to be useful later on.
Signed-off-by: Andrea Bolognani
---
src/Makefile.am | 35 ---
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index
We use these utility functions both in the daemon and
for test programs, so create a new convenience library
that we can compile once and include in both places.
Signed-off-by: Andrea Bolognani
---
src/Makefile.am | 11 ++-
tests/Makefile.am | 4 +++-
2 files changed, 13
The man page for libvirt-dbus is in section 8, not 1.
Signed-off-by: Andrea Bolognani
---
.gitignore | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index c5e16a9..28a7c57 100644
--- a/.gitignore
+++ b/.gitignore
@@ -30,7 +30,7 @@ vgcore.*
[...]
>>> +/* Next we need to figure out how to properly configure the
>>> OpenGL
>>> + * if that is enabled and the 'native' attribute is missing.
>>> + * The cases are:
>>> + * 1) Listen type is either 'socket' or 'none' - SPICE
>>> native
After new iSCSI interface is successfully set up, we issue
sendtargets command. However, after 56057900dc53df490d we don't
update the host config which in turn makes login fail because
iscsiadm is unable to find any matching record for the interface.
Signed-off-by: Michal Privoznik
---
each commit references the commit where the last use was removed
Anya Harter (2):
domain_addr: delete virDomainCCWAddressReleaseAddr
domain_addr: delete virDomainVirtioSerialAddrRelease
src/conf/domain_addr.c | 68
src/conf/domain_addr.h | 8
Firstly, we can utilize virCommandSetOutputBuffer() API which
will collect the command output for us. Secondly, sscanf()-ing
through each line is easier to understand (and more robust) than
jumping over a string with strchr().
Signed-off-by: Michal Privoznik
---
src/util/viriscsi.c | 85
I've noticed that I'm unable to start my iscsi pool if I put my
own IQN into the pool XML. This is very surprising because
iscsiadm would read it from initiatorname.conf file, right? Well,
no. If IQN is provided in pool XML the code calls slightly
different iscsiadm commands (e.g. to set up iSCSI
the last use of this function was deleted in commit
19a148b7c8353d5c214bed699f8fe983317baf93
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 44
src/conf/domain_addr.h | 5 -
src/libvirt_private.syms | 1 -
3 files changed, 50
This is in fact 'cleanup' label and it should be named as such.
Signed-off-by: Michal Privoznik
---
src/util/viriscsi.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/util/viriscsi.c b/src/util/viriscsi.c
index a308ee4bac..2e55b3c10b 100644
---
the last use of this function was deleted in commit
1aa5e66cf3a0dd5e8ada8483f79cb745f786a131
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 24
src/conf/domain_addr.h | 3 ---
src/libvirt_private.syms | 1 -
3 files changed, 28 deletions(-)
diff
When scanning for targets, iSCSI might give different results
depending on the interface used. This is basically just name of
config file under /etc/iscsi/ifaces to use. The file contains
initiator IQN thus different results claim.
Signed-off-by: Michal Privoznik
---
The return value of this function is overwritten more times than
I am comfortable with.
Signed-off-by: Michal Privoznik
---
src/util/viriscsi.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/src/util/viriscsi.c b/src/util/viriscsi.c
index
The @prefix attribute to element for interface type user is
optional. Therefore, if left out it has value of zero in which
case we should not check whether it falls into <4, 27> range.
Otherwise we fail parsing domain XML for no good reason.
Signed-off-by: Michal Privoznik
---
On Thu, Jun 28, 2018 at 06:34:56PM -0400, John Ferlan wrote:
>
>
> On 06/27/2018 09:34 AM, Erik Skultety wrote:
> > Since QEMU 2.10, there's a new cmdline option '-display egl-headless'
> > which enables OpenGL support for cases where we can't render on a local
> > display (i.e. is set to either
On Fri, Jun 29, 2018 at 02:12:51PM +0200, Jiri Denemark wrote:
> On Fri, Jun 29, 2018 at 11:14:17 +0100, Daniel P. Berrangé wrote:
> > On Thu, Jun 28, 2018 at 04:52:27PM -0300, Eduardo Habkost wrote:
> > > On Thu, Jun 28, 2018 at 04:45:02PM +0100, Daniel P. Berrangé wrote:
> > > [...]
> > > > What
On Fri, Jun 29, 2018 at 08:06:04AM +0200, Jiri Denemark wrote:
> On Thu, Jun 28, 2018 at 16:23:53 -0300, Eduardo Habkost wrote:
> > On Thu, Jun 28, 2018 at 07:59:38PM +0100, Dr. David Alan Gilbert wrote:
[...]
> > > Would you restrict the combinations to cut down the test matrix - e.g.
> > > not
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 1a0a457..d7820dd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,4 +1,4 @@
-AC_INIT([libvirt-dbus], [1.1.0],
On Thu, Jun 28, 2018 at 05:18:46PM -0400, John Ferlan wrote:
>
>
> On 06/27/2018 09:34 AM, Erik Skultety wrote:
> > VNC doesn't support OpenGL natively, but can run with non-native
> > egl-headless support, so enable that.
> >
> > Signed-off-by: Erik Skultety
> > ---
> >
On Thu, Jun 28, 2018 at 05:18:46PM -0400, John Ferlan wrote:
>
>
> On 06/27/2018 09:34 AM, Erik Skultety wrote:
> > VNC doesn't support OpenGL natively, but can run with non-native
> > egl-headless support, so enable that.
> >
> > Signed-off-by: Erik Skultety
> > ---
> >
On Fri, Jun 29, 2018 at 02:12:51PM +0200, Jiri Denemark wrote:
> On Fri, Jun 29, 2018 at 11:14:17 +0100, Daniel P. Berrangé wrote:
> > On Thu, Jun 28, 2018 at 04:52:27PM -0300, Eduardo Habkost wrote:
> > > On Thu, Jun 28, 2018 at 04:45:02PM +0100, Daniel P. Berrangé wrote:
> > > [...]
> > > > What
On Fri, Jun 29, 2018 at 11:14:17 +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 28, 2018 at 04:52:27PM -0300, Eduardo Habkost wrote:
> > On Thu, Jun 28, 2018 at 04:45:02PM +0100, Daniel P. Berrangé wrote:
> > [...]
> > > What if we can borrow the concept of versioning from machine types and
> > >
[...]
>> Well, from my example, what units are "128" and "8" in? Also, in libvirt
>> we give users possibility to specify other units than KiB (even though
>> we report back size in KiB), for instance look at numa
>> . Also, your proposal is not that future proof. My suggestion is:
>>
>>
On Fri, Jun 29, 2018 at 09:53:53AM +0100, Dr. David Alan Gilbert wrote:
> * Eduardo Habkost (ehabk...@redhat.com) wrote:
> > On Thu, Jun 28, 2018 at 04:45:02PM +0100, Daniel P. Berrangé wrote:
> > [...]
> > > What if we can borrow the concept of versioning from machine types and
> > > apply
> > >
On Thu, Jun 28, 2018 at 04:52:27PM -0300, Eduardo Habkost wrote:
> On Thu, Jun 28, 2018 at 04:45:02PM +0100, Daniel P. Berrangé wrote:
> [...]
> > What if we can borrow the concept of versioning from machine types and apply
> > it to CPU models directly. For example, considering the history of
On Thu, Jun 28, 2018 at 07:59:38PM +0100, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > This post is to raise question about helping use of named CPU models with
> > KVM ie any case not using -cpu host.
> >
> > In the old days (ie before 2018), the world
On Fri, Jun 29, 2018 at 11:07:02AM +0200, Andrea Bolognani wrote:
> See patch 2/2 for the details.
>
> Andrea Bolognani (2):
> configure: Make polkit rules directory configurable
> configure: Fix default polkit rules directory
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP
On Fri, Jun 29, 2018 at 11:13:29AM +0200, Andrea Bolognani wrote:
> This is consistent with libvirt's own polkit configuration,
> which grants users in the libvirt group full administrative
> access to the system daemon.
>
> Signed-off-by: Andrea Bolognani
> ---
>
This is consistent with libvirt's own polkit configuration,
which grants users in the libvirt group full administrative
access to the system daemon.
Signed-off-by: Andrea Bolognani
---
data/system/org.libvirt.conf.in | 4
1 file changed, 4 insertions(+)
diff --git
The polkit hierarchy under $(sysconfdir) is intended as
a way for the local administrator to agument or override
the vendor configuration, so we should install our rules
under $(datadir) instead.
Signed-off-by: Andrea Bolognani
---
configure.ac | 2 +-
libvirt-dbus.spec.in | 2 +-
2
See patch 2/2 for the details.
Andrea Bolognani (2):
configure: Make polkit rules directory configurable
configure: Fix default polkit rules directory
configure.ac | 5 +
data/Makefile.am | 2 +-
libvirt-dbus.spec.in | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
This is consistent with how we treat other directories where
we install data files.
Signed-off-by: Andrea Bolognani
---
configure.ac | 5 +
data/Makefile.am | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index a52a108..af96b97 100644
* Eduardo Habkost (ehabk...@redhat.com) wrote:
> On Thu, Jun 28, 2018 at 04:45:02PM +0100, Daniel P. Berrangé wrote:
> [...]
> > What if we can borrow the concept of versioning from machine types and apply
> > it to CPU models directly. For example, considering the history of "Haswell"
> > in
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
data/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/data/Makefile.am b/data/Makefile.am
index b3fa614..b0e6b31 100644
--- a/data/Makefile.am
+++ b/data/Makefile.am
@@ -23,7 +23,7 @@ interfaces_files = \
On Fri, Jun 29, 2018 at 09:02:17 +0200, Michal Privoznik wrote:
> On 06/29/2018 05:46 AM, dujiancheng wrote:
> > The patch add support L2 table cache for qcow2 disk.
> > L2 table cache can improve IO read and write performance for qcow2 img.
> > Example: random 4K read requests on a fully
On 06/29/2018 05:46 AM, dujiancheng wrote:
> The patch add support L2 table cache for qcow2 disk.
> L2 table cache can improve IO read and write performance for qcow2 img.
> Example: random 4K read requests on a fully populated 100GB image (SSD
> backend and vm with directsync cacha mode),
On Thu, Jun 28, 2018 at 16:23:53 -0300, Eduardo Habkost wrote:
> On Thu, Jun 28, 2018 at 07:59:38PM +0100, Dr. David Alan Gilbert wrote:
> [...]
> > > An application like virt-manager which wants a simple UI can forever be
> > > happy simply giving users a list of bare CPU model names, and
61 matches
Mail list logo
