> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Tuesday, July 17, 2018 5:11 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
> ; Ding, Jian-feng ; Zang, Rui
>
> Subject: Re: [libvirt] [RFC PATCHv2 00/10] x86 RDT Cache
On 07/04/2018 10:05 PM, Jie Wang wrote:
>>From 29482622218f525f0133be0b7db74835174035d9 Mon Sep 17 00:00:00 2001
> From: Jie Wang
> Date: Thu, 5 Jul 2018 09:52:03 +0800
> Subject: [PATCH] qemu: stop qemu progress when restore failed
Strange stuff in the comment message...
>
> if
On 07/17/2018 05:01 PM, David Hildenbrand wrote:
> On 13.07.2018 18:00, Jiri Denemark wrote:
>> On Mon, Jul 09, 2018 at 22:56:55 -0500, Chris Venteicher wrote:
>>> Transient S390 configurations require using QEMU to compute CPU Model
>>> Baseline and to do CPU Feature Expansion.
>>>
>>> Start and
On 07/05/2018 11:36 PM, Shi Lei wrote:
> Signed-off-by: Shi Lei
> ---
> src/conf/network_conf.c | 12 ---
> src/conf/network_conf.h | 1 +
> src/network/bridge_driver.c | 80
> +
> 3 files changed, 82 insertions(+), 11 deletions(-)
>
On 07/05/2018 11:36 PM, Shi Lei wrote:
> Signed-off-by: Shi Lei
> ---
> src/conf/domain_conf.c | 1 +
> src/conf/virnetworkobj.c | 1 +
> src/qemu/qemu_process.c | 1 +
> 3 files changed, 3 insertions(+)
>
This should have been merged into the previous patch; however, this
doing point
On 07/05/2018 11:36 PM, Shi Lei wrote:
> Signed-off-by: Shi Lei
> ---
> configure.ac | 5 +-
> src/libvirt_private.syms | 4 +
> src/util/virnetdev.c | 195
> +++
> src/util/virnetdev.h | 14
> 4 files changed, 216
On 13.07.2018 18:00, Jiri Denemark wrote:
> On Mon, Jul 09, 2018 at 22:56:55 -0500, Chris Venteicher wrote:
>> Transient S390 configurations require using QEMU to compute CPU Model
>> Baseline and to do CPU Feature Expansion.
>>
>> Start and use a single QEMU instance to do both the baseline and
On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> v2 of:
>
> https://www.redhat.com/archives/libvir-list/2018-June/msg01861.html
>
> diff to v1:
> - fixed misleading while() loop in 03/10
> - Introduced some tests
> - patch 06/10 is new, while writing the tests I've noticed that
> errors
On 07/04/2018 07:03 AM, Nikolay Shirokovskiy wrote:
> Otherwise after libvirtd restart we come back to issues fixed by
> introducing this flag in [1].
>
> [1] 61a0026a : qemu: Fix xml dump of autogenerated websocket
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/conf/domain_conf.c | 9
On 07/04/2018 07:03 AM, Nikolay Shirokovskiy wrote:
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/qemu/qemu_process.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
So your contention is that commit id 84067696 missed a condition?
I agree, but would like you to reference
On 07/04/2018 07:03 AM, Nikolay Shirokovskiy wrote:
> Originally port allocator have 2 functions to release ports: one
> for for manually reserved ports and one for autoallocated ports. Thus
> a bit complicated code of port releasing. Now we have only one releasing
> function.
But there's a
On 07/04/2018 07:03 AM, Nikolay Shirokovskiy wrote:
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/qemu/qemu_process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Copy-Pasta from commit id 1a065caa7 it seems (it's only 4 years old,
just a young bug).
Reviewed-by: John
>>> +} else {
>>> +to->code = VIR_ERR_NO_MEMORY;
>>> +to->domain = VIR_FROM_NONE;
>>> +to->level = VIR_ERR_ERROR;
>>
>> Should we do a VIR_FREE(to->message); so that nothing that was there
>> before somehow remains... I don't think either agent or monitor>
On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> Extend this existing test so that a case when IQN is provided is
> tested too. Since a special iSCSI interface is created and its
> name is randomly generated at runtime we need to link with
> virrandommock to have predictable names.
>
>
On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> Introduce one basic test that tests the simplest case:
> logging into portal without any IQN.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/viriscsitest.c | 46 ++
> 1 file changed, 46
On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> Some tests will want to pass their own callback data into the
> testIscsiadmCbData callback. Introduce testIscsiadmCbData struct
> to give this some form and order.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/viriscsitest.c | 15
On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> This struct has nothing to do with testIscsiadmCb() rather than
> testISCSIGetSession(). Move it closer to the latter.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/viriscsitest.c | 12 ++--
> 1 file changed, 6 insertions(+), 6
On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> Introduce one basic test that tests the simplest case:
> logging into portal without any IQN.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/viriscsitest.c | 46 ++
> 1 file changed, 46
On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> The documentation to virCommandWait() function states that if
> @exitstatus is NULL and command finished with error -1 is
> returned. In other words, if @dryRunCallback is set and returns
> an error (by setting its @status argument to a nonzero
On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> Firstly, we can utilize virCommandSetOutputBuffer() API which
> will collect the command output for us. Secondly, sscanf()-ing
> through each line is easier to understand (and more robust) than
> jumping over a string with strchr().
>
>
On Tue, Jul 17, 2018 at 04:44:24PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-07-17 at 15:04 +0200, Katerina Koukiou wrote:
> > On Thu, Jul 12, 2018 at 05:19:27PM +0200, Andrea Bolognani wrote:
> > > +class Projects:
> > > +
> > > +def __init__(self):
> > > +try:
> > > +
On Tue, Jul 17, 2018 at 04:45:39PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-07-17 at 14:57 +0200, Katerina Koukiou wrote:
> > On Thu, Jul 12, 2018 at 05:19:24PM +0200, Andrea Bolognani wrote:
> > > +cmd = [ "ansible-playbook" ]
> >
> > IMO this requirement should be as well in python
On Tue, Jul 17, 2018 at 02:51:47PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-07-17 at 11:57 +0200, Katerina Koukiou wrote:
> > On Thu, Jul 12, 2018 at 05:19:21PM +0200, Andrea Bolognani wrote:
> > > +import yaml
> >
> > Since you have to install yaml to actually use it, I suggest at this
> >
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-centos-7/docker.yml | 2 ++
guests/host_vars/libvirt-debian-8/docker.yml | 2 ++
guests/host_vars/libvirt-debian-9/docker.yml | 2 ++
guests/host_vars/libvirt-debian-sid/docker.yml | 2 ++
The original tool's limited scope meant loading this
information was not needed, but we're going to start
making use of it pretty soon.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 47 +++
1 file changed, 47 insertions(+)
diff --git
This is basically the exact same algorithm used by the
Ansible playbooks to process package mappings, implemented
in pure Python.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 86 ++
1 file changed, 80 insertions(+), 6 deletions(-)
diff
The 'prepare' alias was kinda redundant and offered
dubious value, so it has been dropped.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 30 ++
1 file changed, 30 insertions(+)
diff --git a/guests/lcitool b/guests/lcitool
index 5156869..ba5ed5d 100755
---
We use an actual YAML parser this time around, and bring
the behavior more in line with what Ansible is doing, so
interoperability should be more solid overall.
New in this implementation is more flexibility in defining
host lists, including support for explicit lists as well
as glob patterns.
Signed-off-by: Andrea Bolognani
---
guests/README.markdown | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/guests/README.markdown b/guests/README.markdown
index bc780f3..4a40619 100644
--- a/guests/README.markdown
+++ b/guests/README.markdown
@@ -6,16 +6,16 @@ of the
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 75 --
1 file changed, 73 insertions(+), 2 deletions(-)
diff --git a/guests/lcitool b/guests/lcitool
index 2df231a..5156869 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -22,6 +22,7 @@
Doesn't do much right now, but it's a start :)
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 46 ++
1 file changed, 46 insertions(+)
create mode 100755 guests/lcitool
diff --git a/guests/lcitool b/guests/lcitool
new file mode 100755
index
The on-disk configuration format and its behavior
are fully backwards compatible with the previous
implementation.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 115 +
1 file changed, 115 insertions(+)
diff --git a/guests/lcitool
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/guests/lcitool b/guests/lcitool
index 95d16b3..cfea077 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -303,7 +303,8 @@ class Application:
update
This replaces the 'list' action from the original
implementation. We're going to list more than just hosts
over time, so a more specific name is warranted.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff
We're going to rewrite the script completely, and getting
the current implementation out of the way firts will make
the diffs more reasonable.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 227 -
1 file changed, 227 deletions(-)
delete
pylint is reasonably happy with the script now:
$ pylint lcitool
No config file found, using default configuration
* Module lcitool
C: 1, 0: Missing module docstring (missing-docstring)
C: 37, 0: Missing class docstring (missing-docstring)
C: 47, 4: Missing method
On Tue, Jul 17, 2018 at 5:47 PM, Katerina Koukiou wrote:
> Although the name of the element is not self-explanatory,
> it's affecting only the vcpu threads.
>
> Signed-off-by: Katerina Koukiou
> ---
> docs/formatdomain.html.in | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Patch series
https://www.redhat.com/archives/libvir-list/2016-January/msg00482.html
introduced the parameters but didn't update the docs.
Signed-off-by: Katerina Koukiou
---
docs/formatdomain.html.in | 21 +
1 file changed, 21 insertions(+)
diff --git
Katerina Koukiou (2):
docs: formatdomain: add info about global_period and global_quota for
cputune
docs: formatdomain: clarify period cputune subelement
docs/formatdomain.html.in | 31 ++-
1 file changed, 26 insertions(+), 5 deletions(-)
--
2.17.1
--
Although the name of the element is not self-explanatory,
it's affecting only the vcpu threads.
Signed-off-by: Katerina Koukiou
---
docs/formatdomain.html.in | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
For easier review of how these tests are different from the one with
capabilities listed.
This commit will be absorbed by the next one.
---
.../graphics-vnc-tls.x86_64-2.4.0.args | 26 ++
.../graphics-vnc-tls.x86_64-latest.args| 26
Add a test with QEMU 2.4.0 capabilites, as well as the latest caps.
The code paths for formatting TLS options will be altered and
2.4.0 is the newest version where QEMU_CAPS_OBJECT_TLS_CREDS_X509
is not supported.
Signed-off-by: Ján Tomko
---
Ján Tomko (4):
tests: qemu: Remove disk from graphics-vnc-tls
FIXDOWN: copy graphics-vnc-tls args to versioned paths
tests: qemu: test more versions for graphics-vnc-tls
qemu: vnc: switch to tls-creds-x509
src/qemu/qemu_command.c| 26 +
The tls, x509 and x509verify options were deprecated in QEMU v2.5.0:
commit 3e305e4a4752f70c0b5c3cf5b43ec957881714f7
Author: Daniel P. Berrange
ui: convert VNC server to use QCryptoTLSSession
Use the tls-creds-x509 object when available.
The disk command line is tested elsewhere.
Signed-off-by: Ján Tomko
---
tests/qemuxml2argvdata/graphics-vnc-tls.args | 2 --
tests/qemuxml2argvdata/graphics-vnc-tls.xml | 6 --
tests/qemuxml2xmloutdata/graphics-vnc-tls.xml | 6 --
3 files changed, 14 deletions(-)
diff --git
On 06/28/2018 09:22 AM, Jai Singh Rana wrote:
> Signed-off-by: Jai Singh Rana
> ---
> docs/news.xml | 9 +
> 1 file changed, 9 insertions(+)
>
This will need to be adjusted for top of tree.
> diff --git a/docs/news.xml b/docs/news.xml
> index 468d34093a..c6394a8f0f 100644
> ---
On 06/28/2018 09:22 AM, Jai Singh Rana wrote:
> In case of pci SR-IOV device with interface_type as 'hostdev', return
> network stats if it has a VF Representor interface enabled on host for
> pci SR-IOV device according to switchdev model.
>
> Signed-off-by: Jai Singh Rana
> ---
>
$SUBJ:
"conf: Introduce virDomainNetFindByHostdev"
Is fine.
then the commit message can be more descriptive.
On 06/28/2018 09:22 AM, Jai Singh Rana wrote:
> Introduce API virDomainNetFindByHostdev which retrieves net def in
> given domain for the given hostdev def. This API will now be used
On 06/28/2018 09:22 AM, Jai Singh Rana wrote:
> Introduce new APIs virNetdevHostdevGetVFRIfName and
> virNetdevHostdevCheckVFRIfName to fetch/verify VF Representor name
> according to switch model for network devices in linux.
>
> Switchdev VF representor interface name on host is queried
$subj:
util: Introduce virNetDevGetProcNetdevStats
On 06/28/2018 09:22 AM, Jai Singh Rana wrote:
> This patch introduces virNetDevGetProcNetdevStats API for linux
> which returns stats for the given interface from /proc/net/dev by
> properly mapping stats entries in probed column to column
On 06/28/2018 09:22 AM, Jai Singh Rana wrote:
> This patch adds string manupulation helper function which takes
manipulation
> string as input and returns string with all but one space removed
> between letters, numbers or words.
>
> Signed-off-by: Jai Singh Rana
> ---
>
On Tue, 2018-07-17 at 14:57 +0200, Katerina Koukiou wrote:
> On Thu, Jul 12, 2018 at 05:19:24PM +0200, Andrea Bolognani wrote:
> > +cmd = [ "ansible-playbook" ]
>
> IMO this requirement should be as well in python requirements file.
> In this way you can also specify which ansible version
On Tue, 2018-07-17 at 15:04 +0200, Katerina Koukiou wrote:
> On Thu, Jul 12, 2018 at 05:19:27PM +0200, Andrea Bolognani wrote:
> > +class Projects:
> > +
> > +def __init__(self):
> > +try:
> > +with open("./vars/mappings.yml", "r") as f:
>
> There is clear information
On Tue, 2018-07-17 at 14:52 +0200, Katerina Koukiou wrote:
> On Thu, Jul 12, 2018 at 05:19:23PM +0200, Andrea Bolognani wrote:
> > -def _action_list(self):
> > +def _action_list(self, hosts):
>
> 'hosts' argument is not used here.
Sure, but...
> > +def _action_install(self, hosts):
Despite the warning that virStorageSourceCopy needs to be populated on
additions to the structure commit 687730540e4 neglected to implement the
copy function.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 27 +++
1 file changed, 27 insertions(+)
diff --git
On Tue, Jul 17, 2018 at 14:14:24 +0200, Peter Krempa wrote:
> Similarly to how we've intergrated data belonging to a single
> virStorageSource for purposes of attaching it to a qemu instance we will
> need to agregate data relevant for the whole disk. With blockdev there
> will be some disk-wide
On Thu, Jul 12, 2018 at 05:19:29PM +0200, Andrea Bolognani wrote:
> This is basically the exact same algorithm used by the
> Ansible playbooks to process package mappings, implemented
> in pure Python.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 86
On Thu, Jul 12, 2018 at 05:19:27PM +0200, Andrea Bolognani wrote:
> The original tool's limited scope meant loadins this
> information was not needed, but we're going to start
> making use of it pretty soon.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 47
On Thu, Jul 12, 2018 at 05:19:24PM +0200, Andrea Bolognani wrote:
> The 'prepare' alias was kinda redundant and offered
> dubious value, so it has been dropped.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 30 ++
> 1 file changed, 30 insertions(+)
>
On Tue, 2018-07-17 at 11:57 +0200, Katerina Koukiou wrote:
> On Thu, Jul 12, 2018 at 05:19:21PM +0200, Andrea Bolognani wrote:
> > +import yaml
>
> Since you have to install yaml to actually use it, I suggest at this
> point to create a requirements.txt file for this script, so that users
> don't
On Thu, Jul 12, 2018 at 05:19:23PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 74 --
> 1 file changed, 72 insertions(+), 2 deletions(-)
>
> diff --git a/guests/lcitool b/guests/lcitool
> index
On Tue, 2018-07-17 at 11:40 +0200, Katerina Koukiou wrote:
> On Thu, Jul 12, 2018 at 05:19:20PM +0200, Andrea Bolognani wrote:
> > +try:
> > +with open(flavor_file, "r") as f:
> > +flavor = f.readline().strip()
> > +except:
>
> And it's generally
On Tue, 10 Jul 2018 16:02:14 +0800
Yi Min Zhao wrote:
> Abstract
>
> The PCI representation in QEMU has recently been extended for S390
> allowing configuration of zPCI attributes like uid (user-defined
> identifier) and fid (PCI function identifier).
> The details can be found here:
>
On Tue, 2018-07-17 at 12:23 +0100, Daniel P. Berrangé wrote:
> On Tue, Jul 17, 2018 at 01:09:57PM +0200, Andrea Bolognani wrote:
> > With the recent update in Fedora Rawhide, MinGW has
> > started freaking out about our use of strncpy():
> >
> > In function 'virStrncpy',
> > inlined
Remove the issue of the monitor command to the caller so that the
function can be used with the modern approach.
Additionally improve the error message.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
Similarly to qemuDomainDiskRemoveManagedPR make it enter monitor on
it's own so that it can be reused. Future users will be in the snapshot
code and in removable media change code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 55 ++---
1
qemuHotplugPrepareDiskAccess can be used to tear down disk access so we
can replace the open-coded version collecting the same function calls.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git
Add code which will convert a disk definition into
qemuHotplugDiskSourceData and then reuse qemuHotplugDiskSourceRemove to
remove all the backend related objects.
This unifies the detach code as much as possible with the already
existing helpers and will allow reuse this infrastructure when
qemuDomainRemoveDiskDevice would leak the disk to be removed if the VM
crashed since it was removed from the definition but not freed.
Broken in commit 105bcdde76b which moved the removal from the definition
earlier.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 8 ++--
1 file
Now that there's only one use of it, replace it directly by the code
filling it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index ee26fb4f52..20efb01dbf 100644
Similarly to how we've intergrated data belonging to a single
virStorageSource for purposes of attaching it to a qemu instance we will
need to agregate data relevant for the whole disk. With blockdev there
will be some disk-wide backing chain members such as the copy-on-read
handler.
Introduce
A bunch of refactors which could be separated from my blockdev add
branch.
The patches modify the disk hotplug/unplug and media change code so that
we can easily add support for -blockdev later on.
Peter Krempa (10):
qemu: hotplug: Reuse qemuHotplugPrepareDiskAccess in
Prepare for the -blockdev implementation of ejectable media changing by
splitting up the old bits.
Additionally since both callers make sure that the device is a cdrom or
floppy the check is no longer necessary.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 99
Extract the (possible) removal of the PR backend and daemon into a
separate helper which enters monitor on it's own. This simplifies the
code and allows reuse of this function in the future e.g. for blockjobs
where removing a image with PR may result into PR not being necessary.
Since the PR is
The warning messages which include the disk source could potentially
format NULL using %s as virDomainDiskGetSource may return NULL for e.g.
NBD disks. As most of the APIs are NOOP for remote disks the usage of
the source string only should be fine for now.
Signed-off-by: Peter Krempa
---
Changelog:
+ v1->v2:
- Removed the the allocation change in virTypedParams(De)Serialize
(John's comment)
Marc Hartmayer (2):
virTypedParamsSerialize: set remote_params_len at the end
virTypedParamsDeserialize: set nparams to 0 in case of an error
src/util/virtypedparam.c | 6 --
From: Marc Hartmayer
Update the length @remote_params_len only if the related
@remote_params_val has also been set.
Signed-off-by: Marc Hartmayer
---
src/util/virtypedparam.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/util/virtypedparam.c
From: Marc Hartmayer
Signed-off-by: Marc Hartmayer
---
src/util/virtypedparam.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c
index c5fc68418c35..ef84642ee989 100644
--- a/src/util/virtypedparam.c
+++ b/src/util/virtypedparam.c
@@
On Wed, Jul 11, 2018 at 12:10 PM wrote:
> On Mon, Jul 09, 2018 at 05:00:49PM -0400, Jason Baron wrote:
> >
> >
> >On 07/08/2018 02:01 AM, Martin Kletzander wrote:
> >> On Thu, Jul 05, 2018 at 06:24:20PM +0200, Roman Mohr wrote:
> >>> On Thu, Jul 5, 2018 at 4:20 PM Jason Baron wrote:
> >>>
>
[Not sure who got this message, but it probably didn't get anywhere due to one
mailserver, so resending to make sure]
On Mon, Jul 09, 2018 at 05:00:49PM -0400, Jason Baron wrote:
On 07/08/2018 02:01 AM, Martin Kletzander wrote:
On Thu, Jul 05, 2018 at 06:24:20PM +0200, Roman Mohr wrote:
On
On Fri, Jul 13, 2018 at 05:31:48PM +0200, Katerina Koukiou wrote:
Since commit f14c37, virDomainConfVMNWFilterTeardown is reporting errors
thus any previously reported error gets overwritten.
We need to save the errors in qemuDomainAttachNetDevice before calling
this function when we are in
On Tue, Jul 17, 2018 at 01:09:57PM +0200, Andrea Bolognani wrote:
> With the recent update in Fedora Rawhide, MinGW has
> started freaking out about our use of strncpy():
>
> In function 'virStrncpy',
> inlined from 'virStrcpy' at ../../src/util/virstring.c:811:12:
>
The way virStrncpy() is called here will never result in
buffer overflow, but it won't prevent or detect truncation
either, despite what the error message might suggest. Use
virStrcpyStatic(), which does all of the above, instead.
Signed-off-by: Andrea Bolognani
---
src/esx/esx_driver.c |
With the recent update in Fedora Rawhide, MinGW has
started freaking out about our use of strncpy():
In function 'virStrncpy',
inlined from 'virStrcpy' at ../../src/util/virstring.c:811:12:
../../src/util/virstring.c:789:11: error: 'strncpy' output truncated before
terminating nul
1/3 contains bug fixes, 2/3 a bunch of cleanups and 3/3 makes
libvirt build again on MinGW.
Andrea Bolognani (3):
src: Use virStrcpyStatic() to avoid truncation
src: Use virStrcpyStatic() wherever possible
m4: Work around MinGW detection of strncpy() usage
cfg.mk | 2
This convenience macro was created for the simple cases
where the length of the source string and the size of the
destination buffer can be figued out with strlen() and
sizeof() respectively, so we should use it wherever
possible instead of open-coding parts of it.
Signed-off-by: Andrea Bolognani
On Tue, 2018-07-17 at 11:16 +0200, Katerina Koukiou wrote:
> On Thu, Jul 12, 2018 at 05:19:19PM +0200, Andrea Bolognani wrote:
> > +# This is necessary to maintain Python 2.7 compatibility
> > +try:
> > +import configparser
> > +except ImportError:
> > +import ConfigParser as configparser
On Mon, Jul 16, 2018 at 03:51:40PM +0200, Erik Skultety wrote:
On Fri, Jul 13, 2018 at 03:06:05PM +0200, Ján Tomko wrote:
On Wed, Jul 11, 2018 at 03:58:27PM +0200, Erik Skultety wrote:
> Since QEMU 2.12, QEMU understands a new vfio-pci device option 'display'
> which can be used to turn on
whops, I didn't notice the other email... please ignore :)
Tomas
On Tue, 17 Jul 2018 12:02:35 +0200
Tomáš Golembiovský wrote:
> ping
--
Tomáš Golembiovský
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Thanks
Tomas
On Mon, 16 Jul 2018 17:45:35 -0400
John Ferlan wrote:
> On 07/02/2018 07:19 AM, Tomáš Golembiovský wrote:
> > QEMU commit bf1e7140e adds reporting of new balloon statistic to QEMU
> > 2.12. Value represents the amount of memory that can be quickly
> > reclaimed without
On Tue, Jul 17, 2018 at 12:52:40AM -0300, Julio Faracco wrote:
> If a domain is configured to start on boot, it has a symlink to the
> domain definition inside the autostart directory. If you rename this
> domain, the definition is renamed too. The symlink need to be pointed to
> this renamed
ping
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Jul 12, 2018 at 05:19:21PM +0200, Andrea Bolognani wrote:
> We use an actual YAML parser this time around, and bring
> the behavior more in line with what Ansible is doing, so
> interoperability should be more solid overall.
>
> New in this implementation is more flexibility in defining
>
On Tue, Jul 17, 2018 at 09:44:07AM +0200, Peter Krempa wrote:
> On Mon, Jul 16, 2018 at 16:57:13 +0200, Erik Skultety wrote:
> > The original capabilities didn't include a patched kernel for spectre
> > and meltdown, SPICE gl support and had xen support enabled which we
> > already have dropped.
>
On Tue, 2018-07-17 at 10:29 +0100, Daniel P. Berrangé wrote:
> On Tue, Jul 17, 2018 at 10:14:18AM +0200, Andrea Bolognani wrote:
> > It looks like gnulib commit 2afc250c6fae changed the ffs()
> > detection code, and now when compiling with MinGW I get HAVE_FFS=1
> > instead of HAVE_FFS=0 and the
On Thu, Jul 12, 2018 at 05:19:20PM +0200, Andrea Bolognani wrote:
> The on-disk configuration format and its behavior
> are fully backwards compatible with the previous
> implementation.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 112
On Tue, Jul 17, 2018 at 10:14:18AM +0200, Andrea Bolognani wrote:
> On Sat, 2018-07-14 at 09:20 +0200, Michal Privoznik wrote:
> > The changelog is quite long because we haven't updated gnulib in
> > a while. Anyway, among the new changes you'll find GCC 8 support,
> > faster build time, mingw
ffs() was not correctly detected on mingw with previous gnulib rebase:
https://lists.gnu.org/archive/html/bug-gnulib/2018-07/msg00061.html.
Signed-off-by: Daniel P. Berrangé
---
.gnulib | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Pushed as a mingw build fix
diff --git a/.gnulib
On Thu, Jul 12, 2018 at 05:19:19PM +0200, Andrea Bolognani wrote:
> Doesn't do much right now, but it's a start :)
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 69 ++
> 1 file changed, 69 insertions(+)
> create mode 100755
On Tue, Jul 17, 2018 at 07:19:41AM +, Wang, Huaqiang wrote:
Hi Martin,
Thanks for your comments. Please see my reply inline.
-Original Message-
From: Martin Kletzander [mailto:mklet...@redhat.com]
Sent: Tuesday, July 17, 2018 2:27 PM
To: Wang, Huaqiang
Cc: libvir-list@redhat.com;
1 - 100 of 107 matches
Mail list logo
