This commit fixes a segmentation fault caused by missing conditional to
check if libxl configuration was properly created by the test. If the
configuration was not properly created, libxlDriverConfigNew() function
will return NULL and cause a segfault at cfg->caps = NULL during the
cleanup.
On 08/01/2018 04:44 PM, Laine Stump wrote:
> (Let's see now which people were the ones who believe it's a huge
> insult to Cc them in list replies, and which are the ones who appreciate
> the Cc and use it as a flag to raise the visibility of the message in
> their mail client . ?.
(Let's see now which people were the ones who believe it's a huge
insult to Cc them in list replies, and which are the ones who appreciate
the Cc and use it as a flag to raise the visibility of the message in
their mail client . ?. Ah, I give up, just leaving in the Cc's
and let the
On Wed, 1 Aug 2018 10:22:39 +
"Wang, Zhi A" wrote:
> Hi:
>
> Let me summarize the understanding so far I got from the discussions since I
> am new to this discussion.
>
> The mdev_type would be a generic stuff since we don't want userspace
> application to be confused. The example of
Signed-off-by: Daniel P. Berrangé
---
src/cpu/cpu_map.xml | 41 +
src/cpu/cpu_map_ppc64_POWER6.xml| 6
src/cpu/cpu_map_ppc64_POWER7.xml| 7 +
src/cpu/cpu_map_ppc64_POWER8.xml| 8 +
Currently we have a cpu_map.xml file that contains all the features and
CPU models for all architectures in one place. I frequently find myself
wondering about the differences between CPU models, but it is hard to
compare them as the list of features is huge.
With this patch series we end up with
Allow for syntax
to reference other files in the CPU database directory
Signed-off-by: Daniel P. Berrangé
---
libvirt.spec.in | 2 +-
mingw-libvirt.spec.in | 4 +--
src/Makefile.am | 2 +-
src/cpu/cpu_map.c | 84 +--
4 files
This is a new version from the last patchset sent yesterday, but now using
VIR_STRNDUP, instead of allocating memory manually.
First version:
https://www.redhat.com/archives/libvir-list/2018-August/msg0.html
Marcos Paulo de Souza (2):
esx: Do not crash SetAutoStart by double free
esx:
esxVI_AutoStartPowerInfo_Free, which is called from
esxVI_HostAutoStartManagerConfig_Free, will always call VIR_FREE to free
memory from {start,stop}Action, leading to a invalid pointer.
With this patch applied, ESX can set autostart successfully to all it's
domains.
Signed-off-by: Marcos Paulo
On 08/01/2018 12:47 PM, Peter Krempa wrote:
> On Wed, Aug 01, 2018 at 12:40:14 +0200, Michal Privoznik wrote:
>> On 07/31/2018 07:19 PM, Ján Tomko wrote:
>>> And I'm still unsure about leaving in
>>> commit 55ce65646348884656fd7bf3f109ebf8f7603494
>>> qemu: Use the correct vm def on cold attach
On 08/01/2018 07:57 AM, Bjoern Walk wrote:
And here's the fix for the viriscsitest on big-endian machine like
Daniel suggested.
From d59b254294a90c5a9ca0fb6ad29465cd0950bb61 Mon Sep 17 00:00:00 2001
From: Bjoern Walk
Date: Wed, 1 Aug 2018 14:48:47 +0200
Subject: [PATCH] util: virrandom: make
On Wed, 2018-08-01 at 14:46 +0200, Erik Skultety wrote:
> On Thu, Jul 19, 2018 at 06:32:05PM +0200, Andrea Bolognani wrote:
> > # preseed files must use a well-known name to be picked up by
> > # d-i; for kickstart files, we can use whatever name we please
> >
Pino Toscano [2018-08-01, 03:08PM +0200]:
> viriscsitest tries to ensure the interface IQN used is a specific one,
> checking later on that it is the same all during the whole test. Since
> the IQN generation involves random bytes, viriscsitest got a fake
> virRandomBytes from the virrandommock
On Wednesday, 1 August 2018 15:24:05 CEST Daniel P. Berrangé wrote:
> On Wed, Aug 01, 2018 at 03:08:07PM +0200, Pino Toscano wrote:
> > viriscsitest tries to ensure the interface IQN used is a specific one,
> > checking later on that it is the same all during the whole test. Since
> > the IQN
On Wed, Aug 01, 2018 at 03:08:07PM +0200, Pino Toscano wrote:
> viriscsitest tries to ensure the interface IQN used is a specific one,
> checking later on that it is the same all during the whole test. Since
> the IQN generation involves random bytes, viriscsitest got a fake
> virRandomBytes from
On Thu, Jul 19, 2018 at 06:32:08PM +0200, Andrea Bolognani wrote:
> The usage has once again changed slightly; additionally,
> a few concrete examples are now provided.
>
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Thu, Jul 19, 2018 at 06:32:07PM +0200, Andrea Bolognani wrote:
> For CentOS CI, we need build dependencies for all known
> projects to be installed; however, when using lcitool
> for development purposes, it is very convenient to install
> just the subset relevant to the project that's being
>
On Thu, Jul 19, 2018 at 06:32:06PM +0200, Andrea Bolognani wrote:
> The rationale is the same as for moving playbooks.
>
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Jul 19, 2018 at 06:32:03PM +0200, Andrea Bolognani wrote:
> We want to get rid of relative paths in playbooks and
> tasks, and in order to do that we have to provide Ansible
> with some more information.
>
> base is the directory where lcitool lives, and
> playbook_base is the directory
viriscsitest tries to ensure the interface IQN used is a specific one,
checking later on that it is the same all during the whole test. Since
the IQN generation involves random bytes, viriscsitest got a fake
virRandomBytes from the virrandommock helper library, setting static
values.
And here's the fix for the viriscsitest on big-endian machine like
Daniel suggested.
Bjoern
--
IBM Systems
Linux on Z & Virtualization Development
IBM Deutschland Research & Development GmbH
Schönaicher Str. 220, 71032
On 08/01/2018 06:24 AM, skob...@redhat.com wrote:
> On Fri, 2018-07-27 at 13:19 -0400, John Ferlan wrote:
>> You shouldn't drop libvir-list when you reply...
> Sorry, I dropped it by mistake.
>>
>> On 07/27/2018 06:35 AM, skob...@redhat.com wrote:
>>> On Mon, 2018-07-23 at 17:32 -0400, John
On Thu, Jul 19, 2018 at 06:32:05PM +0200, Andrea Bolognani wrote:
> The information is mostly duplicated and can be easily
> inferred in a programmatic manner, so storing it in the
> inventory is far from the cleanest solution.
>
> As a side-effect, we reintroduce the error message that
> was
On Wed, Aug 01, 2018 at 01:44:33PM +0200, Michal Privoznik wrote:
> In virStorageBackendCreateIfaceIQN() the virRandomBits() is
> called in order to use random bits to generate random name for
> new interface. However, virAsprintf() is expecting 32 bits and we
> are requesting only 30.
>
>
On Wed, Aug 01, 2018 at 01:44:32PM +0200, Michal Privoznik wrote:
> The function is supposed to return up to 64bit long integer. In
> order to do that it calls virRandomBytes() to fill the integer
> with random bytes and then masks out everything but requested
> bits. However, when doing that it
On 07/30/2018 04:59 PM, Peter Krempa wrote:
> Jansson does not put a newline at the end of formatted JSON strings.
> This breaks the qemucapsprobe utility as we need to keep the spacing so
> that tests work. Add an explicit newline.
>
> Signed-off-by: Peter Krempa
> ---
>
In virStorageBackendCreateIfaceIQN() the virRandomBits() is
called in order to use random bits to generate random name for
new interface. However, virAsprintf() is expecting 32 bits and we
are requesting only 30.
Signed-off-by: Michal Privoznik
---
src/util/viriscsi.c | 2 +-
1 file changed, 1
The function is supposed to return up to 64bit long integer. In
order to do that it calls virRandomBytes() to fill the integer
with random bytes and then masks out everything but requested
bits. However, when doing that it shifts 1U and not 1ULL. So
effectively, requesting 32 random bis or more
Bad pun. But while debugging the issue Bjoern raised [1] I've noticed
these problems.
https://www.redhat.com/archives/libvir-list/2018-July/msg02101.html
Michal Prívozník (2):
util: Don't overflow in virRandomBits
viriscsi: Request more random bits for interface name
src/util/viriscsi.c |
On Mon, Jul 30, 2018 at 16:59:34 +0200, Peter Krempa wrote:
> Jansson does not put a newline at the end of formatted JSON strings.
> This breaks the qemucapsprobe utility as we need to keep the spacing so
> that tests work. Add an explicit newline.
>
> Signed-off-by: Peter Krempa
> ---
>
On Tue, Jul 31, 2018 at 03:54:43PM +0200, Bjoern Walk wrote:
> Bjoern Walk [2018-07-31, 03:16PM +0200]:
> > I have not yet had the time to figure out what goes wrong, any ideas are
> > welcome.
>
> Ah, classic. The mocked virRandomBytes function is not endian-agnostic,
> generating a different
On Wed, Aug 01, 2018 at 12:40:14 +0200, Michal Privoznik wrote:
> On 07/31/2018 07:19 PM, Ján Tomko wrote:
> > And I'm still unsure about leaving in
> > commit 55ce65646348884656fd7bf3f109ebf8f7603494
> > qemu: Use the correct vm def on cold attach
> >
We need to first perform the checks for changed/missing elements
and then we can overwrite the missing ones. Otherwise we might
falsely report successfull update, because some elements got
overwritten before the validity checks.
https://bugzilla.redhat.com/show_bug.cgi?id=1599513
Signed-off-by:
The corresponding libvirt-jenkins-ci commit is dcbad35f45fe.
Signed-off-by: Andrea Bolognani
---
Pushed under the Dockerfile refresh rule.
buildenv-centos-7.Dockerfile | 3 ++-
buildenv-debian-8.Dockerfile | 1 +
buildenv-debian-9.Dockerfile | 1 +
On Fri, 2018-07-27 at 13:19 -0400, John Ferlan wrote:
> You shouldn't drop libvir-list when you reply...
Sorry, I dropped it by mistake.
>
> On 07/27/2018 06:35 AM, skob...@redhat.com wrote:
> > On Mon, 2018-07-23 at 17:32 -0400, John Ferlan wrote:
> > >
> > > On 07/12/2018 09:10 AM, Simon
Hi:
Let me summarize the understanding so far I got from the discussions since I am
new to this discussion.
The mdev_type would be a generic stuff since we don't want userspace
application to be confused. The example of mdev_type is:
There are several pre-defined mdev_types with different
On Tue, 07/24 11:24, Cornelia Huck wrote:
> diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c
> index a02d708239..1bd6c8b458 100644
> --- a/hw/s390x/css-bridge.c
> +++ b/hw/s390x/css-bridge.c
> @@ -106,7 +106,6 @@ VirtualCssBus *virtual_css_bus_init(void)
> /* Create bus on bridge
On Tue, Jul 31, 2018 at 07:24:00PM +0200, Ján Tomko wrote:
> On Tue, Jul 31, 2018 at 05:32:51PM +0200, Katerina Koukiou wrote:
> > On Tue, Jul 31, 2018 at 05:15:51PM +0200, Ján Tomko wrote:
> > > On Tue, Jul 31, 2018 at 04:34:39PM +0200, Katerina Koukiou wrote:
> > > > When trying to update an
On Wed, Aug 01, 2018 at 09:31:49AM +0200, Peter Krempa wrote:
> On Tue, Jul 31, 2018 at 15:55:28 +0100, Daniel Berrange wrote:
> > The jansson and json-glib libraries both export symbols with a json_
> > name prefix and json_object_iter_next() clashes between them.
> >
> > Unfortunately json_glib
On Wed, Aug 01, 2018 at 09:24:29AM +0200, Peter Krempa wrote:
commit 8d9ca6cdb3a5 refactored qemuMonitorJSONBlockStatsCollectData so
that the number of stats is passed back via a pointer. The commit failed
to fix the macro which increments the number of stats to increment the
actual pointee.
commit 8d9ca6cdb3a5 refactored qemuMonitorJSONBlockStatsCollectData so
that the number of stats is passed back via a pointer. The commit failed
to fix the macro which increments the number of stats to increment the
actual pointee.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 2
On Tue, Jul 31, 2018 at 19:19:33 +0200, Ján Tomko wrote:
> On Tue, Jul 31, 2018 at 12:19:28PM +0800, Daniel Veillard wrote:
> > It is out, tagged in git and with signed tarball and rpms at the
> > usual place:
> >
> > ftp://libvirt.org/libvirt/
> >
> > in my limited testing it works but we
42 matches
Mail list logo
