There are few places where dlopen() is called. This call means we
have to link with DLOPEN_LIBS. However, instead of having each
final, installable library linking with it, move the directive to
the source that introduced the dependency.
Signed-off-by: Michal Privoznik
---
src/Makefile.am
On 08/09/2018 07:15 PM, Jim Fehlig wrote:
>
> I tested the patch, works fine. What is the best course of action since
> I pushed the other one? Revert it and push your patch?
No need to revert. I'll send a patch that moves DLOPEN_* where I suggested.
Michal
--
libvir-list mailing list
Before this change, esxDomainGetMaxVcpus returned -1, which in turn
fails in libvirt. This commit reimplements esxDomainGetMaxVcpus instead
of calling esxDomainGetVcpusFlags. The implementation checks for
capability.maxSupportedVcpus, but as this one can be ommited in ESXi, we
also check for
Before this patch, esxDomainGetVcpusFlags was returning -1 since
"maxSupportedVcpus" can be NULL in ESXi[1]. In order to make it work,
replicate the same behavior than esxDomainGetInfo that used
config.hardware.numCPU to return the correct number of vcpus of a VM.
This patch, together with the
Hi guys,
while checking my ESXi 6.5, and trying to query and change vcpus values, I
discovered this was not working. So, these two patches aim to fix the problem. I
checked some docs[1].
Let me know if there are points where it can be improved.
Thanks,
[1]
On 08/05/2018 05:01 PM, Marek Marczykowski-Górecki wrote:
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_driver.c | 126 -
1 file changed, 126 insertions(+)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index
On 08/05/2018 05:01 PM, Marek Marczykowski-Górecki wrote:
When libvirtd is started, initialize domain objects state with its real
state, not only RUNNING/SHUTOFF.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_driver.c | 11 +++
1 file changed, 11 insertions(+)
diff
On 08/05/2018 05:01 PM, Marek Marczykowski-Górecki wrote:
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_domain.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index
On 08/05/2018 03:50 PM, Marek Marczykowski-Górecki wrote:
Fix saving CFLAGS in LIBVIRT_DRIVER_CHECK_LIBXL - LIBVIRT_CHECK_LIB will
override old_CFLAGS, so use a different name.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
and pushed.
Regards,
Jim
---
On 08/09/2018 07:42 AM, Michal Privoznik wrote:
On 08/08/2018 07:00 PM, Jim Fehlig wrote:
While local builds succeed fine, a build worker building in a chroot
environment is encountering errors when linking some items in tools/nss
and tests, e.g.
[ 469s] libtool: link: gcc -shared -fPIC
On Thu, 2018-08-09 at 18:17 +0200, Ján Tomko wrote:
> After commit caccbba this variable is always NULL.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 16 +++-
> 1 file changed, 3 insertions(+), 13 deletions(-)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani /
After commit caccbba this variable is always NULL.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 65bd88a652..12ff09d46d 100644
---
On Thu, Aug 09, 2018 at 11:54:42AM -0400, Laine Stump wrote:
> On 08/09/2018 03:58 AM, Daniel P. Berrangé wrote:
> > On Wed, Aug 08, 2018 at 11:41:23PM -0400, Laine Stump wrote:
> >> On 08/08/2018 11:46 AM, Daniel P. Berrangé wrote:
> >>> The port allocation APIs are currently called
On 08/09/2018 03:58 AM, Daniel P. Berrangé wrote:
> On Wed, Aug 08, 2018 at 11:41:23PM -0400, Laine Stump wrote:
>> On 08/08/2018 11:46 AM, Daniel P. Berrangé wrote:
>>> The port allocation APIs are currently called unconditionally for all
>>> types of NIC, but (mostly) only do anything for NICs
On Thu, Aug 09, 2018 at 11:21:52AM +0200, Katerina Koukiou wrote:
This patch ensures that changes in attributes of interfaces will be emit
errors accept if they are missing from the XML.
Previously we were falsely reporting successfull updates, because some
*successful
changed attributes got
On Thu, Aug 09, 2018 at 16:34:56 +0200, Ján Tomko wrote:
> On Thu, Aug 09, 2018 at 02:48:54PM +0200, Peter Krempa wrote:
> > The field was added in qemu v0.13.0-rc0-731-g1ca4d09ae0 so all supported
> > qemu versions now use it.
> >
> > There's a LOT of test fallout as we did not use capabilities
On Thu, Aug 09, 2018 at 04:50:58PM +0200, Michal Privoznik wrote:
There are couple of files that are the same in both
qemuxml2argvdata and qemuxml2xmloutdata directories. Link them
instead of having full copy.
Signed-off-by: Michal Privoznik
---
tests/qemuxml2xmloutdata/boot-floppy-q35.xml
On 08/07/2018 01:46 PM, Bobo Du wrote:
> the vm xml will be existed when the vm is undefined after started.
> blockcommit interface also has the bug with above.
> Step1:prepare a vm，eg:test1,start it and undefined
> Step2: virsh snapshot-create-as test1 --disk-only --no-metadata
> Step3:ls
On 08/03/2018 04:28 PM, Daniel P. Berrangé wrote:
> The virCapabilitiesDomainDataLookupInternal() is given a list of
> parameters representing the desired domain characteristics. It then has
> to look throught the capabilities to identify an acceptable match.
>
> The virCapsDomainDataCompare()
There are couple of files that are the same in both
qemuxml2argvdata and qemuxml2xmloutdata directories. Link them
instead of having full copy.
Signed-off-by: Michal Privoznik
---
tests/qemuxml2xmloutdata/boot-floppy-q35.xml | 33 +---
On Thu, Aug 09, 2018 at 02:48:54PM +0200, Peter Krempa wrote:
The field was added in qemu v0.13.0-rc0-731-g1ca4d09ae0 so all supported
qemu versions now use it.
There's a LOT of test fallout as we did not use capabilities close
enough to upstream for many of our tests.
Signed-off-by: Peter
On Thu, Aug 09, 2018 at 02:48:59PM +0200, Peter Krempa wrote:
Starting from pc-q35-2.4 the floppy controller is not enabled by
default. Fix the version check so that it does not match 2.11 as being
2.1.
O:-)
Thanks.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c
On Thu, Aug 09, 2018 at 02:48:58PM +0200, Peter Krempa wrote:
Fix regression introduced in 42fd5a58adb. With q35 machine type which
Please wrap the commit id in <> or rephrase the sentence to have the
commit id separated by spaces.
requires the explicitly specified FDC we'd format two
On Thu, Aug 09, 2018 at 03:57:00PM +0200, Andrea Bolognani wrote:
> Commit 15a19dbc0b73 made sure all explicit calls use
> the current directory instead of ~/rpmbuild as workspace,
> but osinfo-db wasn't affected by the change since its
> build recipe calls the custom 'make rpm' target and
>
On Thu, Aug 09, 2018 at 02:48:56PM +0200, Peter Krempa wrote:
Now that the argument is unused we can remove it transitively from all
the call graphs.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 20 +++-
src/qemu/qemu_command.h | 3 +--
src/qemu/qemu_hotplug.c | 2
Commit 15a19dbc0b73 made sure all explicit calls use
the current directory instead of ~/rpmbuild as workspace,
but osinfo-db wasn't affected by the change since its
build recipe calls the custom 'make rpm' target and
continued storing build artifacts in ~/rpmbuild.
Signed-off-by: Andrea Bolognani
On Thu, Aug 09, 2018 at 02:48:57PM +0200, Peter Krempa wrote:
The floppy drive command line is different on the q35 machine. Make sure
to test that both drives are supported and also multiple machine
versions as we generate the commandline differently.
Note that both output files show wrong
On Thu, Aug 09, 2018 at 02:48:55PM +0200, Peter Krempa wrote:
The capability was never set except for (stale) tests. Remove it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_command.c | 19 +--
tests/qemuxml2argvtest.c | 26
On Thu, Aug 09, 2018 at 02:48:54PM +0200, Peter Krempa wrote:
The field was added in qemu v0.13.0-rc0-731-g1ca4d09ae0 so all supported
qemu versions now use it.
There's a LOT of test fallout as we did not use capabilities close
enough to upstream for many of our tests.
Signed-off-by: Peter
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c | 103 ---
1 file changed, 58 insertions(+), 45 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 45fe2595d1..99cbdaa59b 100644
--- a/src/util/vircgroup.c
+++
There is no need for this function, both of the checks are done
later by virCgroupGetControllerPath.
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c | 31 +--
1 file changed, 1 insertion(+), 30 deletions(-)
diff --git a/src/util/vircgroup.c
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.h | 13 -
src/util/vircgrouppriv.h | 13 +
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/src/util/vircgroup.h b/src/util/vircgroup.h
index 138bb3c076..48be077aba 100644
--- a/src/util/vircgroup.h
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c | 43 ++-
1 file changed, 14 insertions(+), 29 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 52be5e5fb8..45fe2595d1 100644
--- a/src/util/vircgroup.c
+++
Commit moved machineName
generation before virCgroupNewDetectMachine() is called.
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index
Commit changed the way how cgroup directory names are
constructed but the documentation was not updated.
Signed-off-by: Pavel Hrdina
---
docs/cgroups.html.in | 34 ++
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/docs/cgroups.html.in
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c | 85 +---
1 file changed, 48 insertions(+), 37 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 5144b33d43..fd58ba154f 100644
--- a/src/util/vircgroup.c
+++
On 08/08/2018 07:00 PM, Jim Fehlig wrote:
> While local builds succeed fine, a build worker building in a chroot
> environment is encountering errors when linking some items in tools/nss
> and tests, e.g.
>
> [ 469s] libtool: link: gcc -shared -fPIC -DPIC -Wl,--whole-archive
>
Signed-off-by: Pavel Hrdina
---
src/lxc/lxc_cgroup.c | 65 +---
1 file changed, 7 insertions(+), 58 deletions(-)
diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c
index 8e937ec389..d93a19d684 100644
--- a/src/lxc/lxc_cgroup.c
+++
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 1 -
src/util/vircgroup.c | 11 +--
src/util/vircgroup.h | 1 -
3 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 95d7c9f834..59d9bc380e 100644
---
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 1 -
src/util/vircgroup.c | 37 -
src/util/vircgroup.h | 1 -
3 files changed, 39 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 32ed5a09f9..8f80ee2250
The cpuacct controller is used to get cpu stats.
Signed-off-by: Pavel Hrdina
---
docs/cgroups.html.in | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/docs/cgroups.html.in b/docs/cgroups.html.in
index e33d07a82b..a498590c45 100644
--- a/docs/cgroups.html.in
+++
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c | 2 +-
src/util/vircgroup.h | 4 ++--
src/util/vircgrouppriv.h | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 6bf4e88da1..7602641713 100644
---
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 280d781f41..6ffa1e9c58 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -251,7 +251,6 @@ static
Preparation for cgroupv2 support.
Pavel Hrdina (17):
docs: List cpuacct in controllers used by QEMU driver
docs: Update how we create cgroup directory names
vircgroup: Rename structs to start with underscore
vircgroup: Introduce standard set of typedefs and use them
vircgroup: Extract
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 1 +
src/util/vircgroup.c | 88
src/util/vircgroup.h | 7
3 files changed, 96 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c | 80 ++--
1 file changed, 47 insertions(+), 33 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 6ffa1e9c58..52be5e5fb8 100644
--- a/src/util/vircgroup.c
+++
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c | 2 +-
src/util/vircgroup.h | 3 ++-
src/util/vircgrouppriv.h | 4 +++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 7602641713..5144b33d43 100644
---
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 1 -
src/util/vircgroup.c | 69 +---
src/util/vircgroup.h | 4 ---
3 files changed, 29 insertions(+), 45 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index
This flag is going to be used to alter default behaviour of the
lock. Firstly, it means we will lock different offset in the file
(offset 1 instead of 0). Secondly, it means the lock acquiring
will actually wait for the lock to be set (compared to default
behaviour which is set or error out).
Signed-off-by: Michal Privoznik
---
src/locking/lock_daemon_dispatch.c | 5 -
src/locking/lock_driver_lockd.c| 31 +--
src/locking/lock_driver_lockd.h| 1 +
3 files changed, 26 insertions(+), 11 deletions(-)
diff --git
In order for our drivers to lock resources for metadata change we
need set of new APIs. Fortunately, we don't have to care about
every possible device a domain can have. We care only about those
which can live on a network filesystem and hence can be accessed
by multiple daemons at the same time.
Fortunately, we have qemu wrappers so it's sufficient to put
lock/unlock call only there.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_security.c | 107 +++
1 file changed, 107 insertions(+)
diff --git a/src/qemu/qemu_security.c
No real support implemented here. But hey, at least we will not
fail.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver_sanlock.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/src/locking/lock_driver_sanlock.c
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/locking/lock_driver.h b/src/locking/lock_driver.h
index 8b7521..7c8f79520a 100644
--- a/src/locking/lock_driver.h
+++ b/src/locking/lock_driver.h
@@ -56,6 +56,8 @@ typedef
All patches are for:
https://bugzilla.redhat.com/show_bug.cgi?id=1524792
You can find them on my Github too:
https://github.com/zippy2/libvirt/tree/disk_metadata_lock_alt
The locking by itself make very little sense. I have a patches waiting
that implement restoring original seclabels
Signed-off-by: Andrea Bolognani
---
projects/libvirt-sandbox.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/projects/libvirt-sandbox.yaml b/projects/libvirt-sandbox.yaml
index 518080a..da9bf77 100644
--- a/projects/libvirt-sandbox.yaml
+++ b/projects/libvirt-sandbox.yaml
@@ -2,6 +2,7
virt-manager can't be built successfully on the
platform, so we shouldn't install the corresponding
build dependencies.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-ubuntu-16/main.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/guests/host_vars/libvirt-ubuntu-16/main.yml
libvirt-dbus can be built successfully on the
platform, so we should install the corresponding
build dependencies.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-debian-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-debian-8/main.yml
As with CentOS 7, we can't run 'make check' on the
platform because we don't have a recent enough Python
interpreter, but the daemon itself will build and run
just fine.
Signed-off-by: Andrea Bolognani
---
projects/libvirt-dbus.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git
libvirt-sandbox can be built successfully on the
platform, so we should install the corresponding
build dependencies.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-debian-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-debian-8/main.yml
We were installing some unnecessary packages and not building
projects on as many platforms as possible. Let's fix that :)
Andrea Bolognani (6):
guests: Don't prepare Ubuntu 16.04 for virt-manager
guests: Don't prepare CentOS 7 for libvirt-sandbox
guests: Prepare Debian 8 for
libvirt-sandbox can't be built successfully on the
platform, so we shouldn't install the corresponding
build dependencies.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-centos-7/main.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/guests/host_vars/libvirt-centos-7/main.yml
Qemu-2.12 gained 'hv-frequencies' cpu flag to enable Hyper-V frequency
MSRs. These MSRs are required (but not sufficient) to make Hyper-V on
KVM pass stable TSC page clocksource to L2 guests.
Signed-off-by: Vitaly Kuznetsov
---
docs/formatdomain.html.in | 7 +++
Qemu-3.0 supports so-called 'Reenlightenment' notifications and this (in
conjunction with 'hv-frequencies') can be used make Hyper-V on KVM pass
stable TSC page clocksource to L2 guests.
Signed-off-by: Vitaly Kuznetsov
---
docs/formatdomain.html.in | 7 +++
Qemu-3.0 supports Hyper-V-style PV TLB flush, Windows guests can benefit
from this feature as KVM knows which vCPUs are not currently scheduled (and
thus don't require any immediate action).
Signed-off-by: Vitaly Kuznetsov
---
docs/formatdomain.html.in | 7 +++
Several new Hyper-V enlightenments were recently added to Qemu:
- hv-frequencies
- hv-reenlightenment
- hv-tlbflush
Support these in libvirt.
Vitaly Kuznetsov (3):
conf: qemu: add support for Hyper-V frequency MSRs
conf: qemu: add support for Hyper-V reenlightenment notifications
conf:
My bad. You can ignore this patch.
On Thu, 9 Aug 2018 at 18:18, Erik Skultety wrote:
>
> On Thu, Aug 09, 2018 at 09:42:19AM +0530, Sukrit Bhatnagar wrote:
> > By making use of GNU C's cleanup attribute handled by the
> > VIR_AUTOPTR macro for declaring aggregate pointer variables,
> > majority of
Now that the argument is unused we can remove it transitively from all
the call graphs.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 20 +++-
src/qemu/qemu_command.h | 3 +--
src/qemu/qemu_hotplug.c | 2 +-
3 files changed, 9 insertions(+), 16 deletions(-)
diff
Fix regression introduced in 42fd5a58adb. With q35 machine type which
requires the explicitly specified FDC we'd format two isa-fdc
controllers to the command line as the code was moved to a place where
it's called per-disk.
Move the call back after formatting all disks and reiterate the disks
The floppy drive command line is different on the q35 machine. Make sure
to test that both drives are supported and also multiple machine
versions as we generate the commandline differently.
Note that both output files show wrong command line which will be fixed
subsequently.
Signed-off-by:
Starting from pc-q35-2.4 the floppy controller is not enabled by
default. Fix the version check so that it does not match 2.11 as being
2.1.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 12
The capability was never set except for (stale) tests. Remove it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_command.c | 19 +--
tests/qemuxml2argvtest.c | 26 +-
3 files changed, 11 insertions(+), 36
Cleanup always present capability QEMU_CAPS_BOOTINDEX and unused
capability QEMU_CAPS_DRIVE_BOOT as a preparation/cleanup step and
fix two bugs in setup of the floppy controller for the q35 machine type.
Peter Krempa (6):
qemu: capabilities: Always assume QEMU_CAPS_BOOTINDEX
qemu:
On Thu, Aug 09, 2018 at 09:42:19AM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_command.c| 4 +++-
.../pages-discard-hugepages.args | 11 +++
tests/qemuxml2argvdata/pages-discard.args | 18 ++
3 files changed, 24 insertions(+), 9 deletions(-)
diff --git
Remove unnecessary XML elements as well.
Signed-off-by: Pavel Hrdina
---
xml => hugepages-numa-nodeset-nonexist.xml} | 17 +
tests/qemuxml2argvtest.c| 5 +++--
.../hugepages-numa-nodeset-nonexist.xml | 1 +
Similar thing happens as for pages-discard, it is not passed to QEMU.
Signed-off-by: Pavel Hrdina
---
tests/qemuxml2argvdata/hugepages-pages3.args | 3 +-
tests/qemuxml2argvdata/hugepages-pages3.xml | 4 +--
.../pages-discard-hugepages.args | 28 +++
Previously we were ignoring "nodeset" attribute for hugepage pages
if there was no guest NUMA topology configured in the domain XML.
Commit partially fixed
that issue but it introduced a somehow valid regression.
In case that there is no guest NUMA topology configured and the
"nodeset" attribute
This use-case was broken by commit
.
We allowed this configuration and it was working as expected therefore
we can consider it as regression. We should have never allowed such
configuration so now the best solution is in case of non-numa guest
silently ignore the 'nodeset' attribute if it's set
Remove unnecessary XML elements as well.
Signed-off-by: Pavel Hrdina
---
...s-pages2.args => hugepages-numa-default-2M.args} | 5 +
...ges-pages2.xml => hugepages-numa-default-2M.xml} | 8 +---
tests/qemuxml2argvtest.c| 5 +++--
...ges-pages2.xml =>
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 75 ++
1 file changed, 40 insertions(+), 35 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index be9c08626a..f88576b5cc 100644
--- a/src/conf/domain_conf.c
+++
We can safely validate the hugepage nodeset attribute at a define time.
This validation is not done for already existing domains when the daemon
is restarted.
All the changes to the tests are necessary because we move the error
from domain start into XML parse.
Signed-off-by: Pavel Hrdina
---
Remove unnecessary XML elements as well.
for numa guest is tested by numatune-memnode test.
Signed-off-by: Pavel Hrdina
---
...s-pages.args => hugepages-numa-nodeset.args} | 17 +
...ges-pages.xml => hugepages-numa-nodeset.xml} | 12 +---
tests/qemuxml2argvtest.c
Remove unnecessary XML elements as well.
Signed-off-by: Pavel Hrdina
---
...ges6.args => hugepages-default-system-size.args} | 5 +
...pages6.xml => hugepages-default-system-size.xml} | 13 +
tests/qemuxml2argvtest.c| 2 +-
This test case is currently working but it uncovers existing issue
in our code that the generated QEMU commandline uses the default 1G
hugepage instead of the 2M hugepage specified for exact node.
The issue in our code is that for non-numa guests we take into account
only the first hugepage.
>From the args output you can see that the 'discard' feature is not
honored if you don't use hugepages, that is a bug, following patche
will fix it.
Signed-off-by: Pavel Hrdina
---
tests/qemuxml2argvdata/hugepages-pages.args | 12 +++
tests/qemuxml2argvdata/hugepages-pages.xml | 3 +-
Remove unnecessary XML elements as well.
Signed-off-by: Pavel Hrdina
---
...ges-pages7.args => pages-dimm-discard.args} | 16 +---
...pages-pages7.xml => pages-dimm-discard.xml} | 18 +-
tests/qemuxml2argvtest.c | 7 ---
Remove unnecessary XML elements as well.
Signed-off-by: Pavel Hrdina
---
...es-pages8.xml => hugepages-nodeset-nonexist.xml} | 13 +
tests/qemuxml2argvtest.c| 7 ---
2 files changed, 5 insertions(+), 15 deletions(-)
rename
Signed-off-by: Pavel Hrdina
---
.../hugepages-numa-default.args | 42 ++-
.../hugepages-numa-default.xml| 74 +--
tests/qemuxml2argvtest.c | 6 --
3 files changed, 7 insertions(+), 115 deletions(-)
diff --git
Remove unnecessary XML elements as well.
Signed-off-by: Pavel Hrdina
---
...pages3.args => hugepages-numa-nodeset-part.args} | 5 +
...s-pages3.xml => hugepages-numa-nodeset-part.xml} | 8 +---
tests/qemuxml2argvtest.c| 3 ++-
...s-pages3.xml =>
Signed-off-by: Pavel Hrdina
---
.../{hugepages-numa.args => hugepages-numa-default.args}| 0
.../{hugepages-numa.xml => hugepages-numa-default.xml} | 0
tests/qemuxml2argvtest.c| 2 +-
3 files changed, 1 insertion(+), 1 deletion(-)
rename
Signed-off-by: Pavel Hrdina
---
.../hugepages-numa-default-dimm.args | 31 +
.../hugepages-numa-default-dimm.xml | 45 +++
tests/qemuxml2argvdata/hugepages-numa.args| 6 +--
tests/qemuxml2argvdata/hugepages-numa.xml | 11 -
Remove unnecessary XML elements as well.
Signed-off-by: Pavel Hrdina
---
...epages-pages5.args => hugepages-default-2M.args} | 5 +
...ugepages-pages5.xml => hugepages-default-2M.xml} | 13 +
tests/qemuxml2argvtest.c| 2 +-
changes in v2:
- renamed existing test cases to sensible names
- split of some existing test cases
- fixed uncovered issue with memory discard
v1: https://www.redhat.com/archives/libvir-list/2018-July/msg00667.html
Pavel Hrdina (20):
tests: rename hugepages to hugepages-default
Remove unnecessary XML elements as well.
Signed-off-by: Pavel Hrdina
---
.../{hugepages.args => hugepages-default.args} | 2 --
.../{hugepages.xml => hugepages-default.xml}| 5 -
tests/qemuxml2argvtest.c| 2 +-
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
---
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
---
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
---
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
---
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
---
src/util/virnetdev.c | 343
1 - 100 of 115 matches
Mail list logo
