ping
On Fri, Jul 13, 2018 at 3:28 PM wrote:
>
> From: Marc-André Lureau
>
> Hi,
>
> This series of patches add support for running a virtio GPU in a
> seperate process, using vhost-user.
>
> The QEMU series "[PATCH v4 00/29] vhost-user for input & GPU" is still
> under review, and will hopefully
On Mon, Aug 13, 2018 at 11:21:05PM +0200, Matthias Bolte wrote:
> 2018-08-10 5:56 GMT+02:00 Marcos Paulo de Souza :
> > Before this change, esxDomainGetMaxVcpus returned -1, which in turn
> > fails in libvirt. This commit reimplements esxDomainGetMaxVcpus instead
> > of calling
On Tue, Aug 14, 2018 at 01:07:45PM -0400, John Ferlan wrote:
> In a case of review collision, Michal pushed Marcos Paulo de Souza's
> series after I had reviewed, but before seeing my review (oh well):
>
> https://www.redhat.com/archives/libvir-list/2018-August/msg00874.html
>
> Rather than
On Tue, Aug 14, 2018 at 10:53:50AM -0400, John Ferlan wrote:
>
>
> On 08/02/2018 08:27 PM, Marcos Paulo de Souza wrote:
> > Instead of adding the same check for every drivers, execute the checks
> > in virAuthGetUsername and virAuthGetPassword. These funtions are called
> > when user is not set
On 08/14/2018 01:05 AM, bing@intel.com wrote:
> From: Bing Niu
>
> Signed-off-by: Bing Niu
> ---
> docs/news.xml | 9 +
> 1 file changed, 9 insertions(+)
>
Reviewed-by: John Ferlan
(and pushed)
Tks, -
John
--
libvir-list mailing list
libvir-list@redhat.com
On 07/27/2018 11:24 AM, Michal Privoznik wrote:
> The check-file-access.pl script is used to match access list
> generated by virtestmock against whitelisted rules stored in
> file_access_whitelist.txt. So far the rules are in form:
>
> $path: $progname: $testname
>
> This is not sufficient
On 07/27/2018 11:24 AM, Michal Privoznik wrote:
> As advertised in the previous commit, we need the list of
> accessed files to also contain action that caused the $path to
> appear on the list. Not only this enables us to fine tune our
> white list rules it also helps us to see why $path is
On 07/27/2018 12:06 PM, Michal Privoznik wrote:
> On 07/27/2018 05:29 PM, Daniel P. Berrangé wrote:
>> On Fri, Jul 27, 2018 at 05:24:45PM +0200, Michal Privoznik wrote:
>>> So far we are setting only fake secret and storage drivers.
>>> Therefore if the code wants to call a public NWFilter API
Now that the virAuthGet*Path API's generate all the error messages
we can remove them from the callers.
Signed-off-by: John Ferlan
---
src/rpc/virnetlibsshsession.c | 2 --
src/rpc/virnetsshsession.c| 5 +
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git
Now that the virAuthGet*Path API's generate all the error messages
we can remove them from the callers.
Signed-off-by: John Ferlan
---
src/test/test_driver.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
Now that the virAuthGet*Path API's generate all the error messages
we can remove them from the callers. This means that we will no
longer overwrite the error from the API.
Signed-off-by: John Ferlan
---
src/xenapi/xenapi_driver.c | 16
1 file changed, 4 insertions(+), 12
Now that the virAuthGet*Path API's generate all the error messages
we can remove them from the callers. This means that we will no
longer overwrite the error from the API.
Signed-off-by: John Ferlan
---
src/hyperv/hyperv_driver.c | 16 +---
1 file changed, 5 insertions(+), 11
Before trying to dereference @auth, let's ensure it's valid.
Signed-off-by: John Ferlan
---
src/util/virauth.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/util/virauth.c b/src/util/virauth.c
index 759b8f0cd3..1b9e4b6704 100644
--- a/src/util/virauth.c
+++
In a case of review collision, Michal pushed Marcos Paulo de Souza's
series after I had reviewed, but before seeing my review (oh well):
https://www.redhat.com/archives/libvir-list/2018-August/msg00874.html
Rather than worry about it, here's a series of changes that I
described in my review:
Now that the virAuthGet*Path API's generate all the error messages
we can remove them from the callers. This means that we will no
longer overwrite the error from the API.
Signed-off-by: John Ferlan
---
src/phyp/phyp_driver.c | 16
1 file changed, 4 insertions(+), 12
Rather than forcing the caller to generate an error, let's
generate the Username or Password error message failure if
the auth->cb fails. This is the last error path that needs
a specific message for various callers.
Signed-off-by: John Ferlan
---
src/util/virauth.c | 10 --
1 file
Now that the virAuthGet*Path API's generate all the error messages
we can remove them from the callers. This means that we will no
longer overwrite the error from the API.
Signed-off-by: John Ferlan
---
src/esx/esx_driver.c | 27 +++
1 file changed, 7 insertions(+), 20
If we never find the valid credtype in the list, then we'd return
NULL without an error signaled forcing the caller to generate one
that will probably be incorrect. Let's be specific.
Signed-off-by: John Ferlan
---
src/util/virauth.c | 13 +
1 file changed, 9 insertions(+), 4
Before trying to call @auth->cb, let's ensure it exists.
Signed-off-by: John Ferlan
---
src/util/virauth.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/util/virauth.c b/src/util/virauth.c
index 1b9e4b6704..7e7098317d 100644
--- a/src/util/virauth.c
+++
Now that the virAuthGet*Path helpers make the checks, we can remove
them from here.
Reviewed-by: John Ferlan
Signed-off-by: John Ferlan
---
src/util/virauth.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/src/util/virauth.c b/src/util/virauth.c
index
On 08/07/2018 07:38 AM, Marc Hartmayer wrote:
> Semantically, there is no difference between an uninitialized worker
> pool and an initialized worker pool with zero workers. Let's allow the
> worker pool to be initialized for max_workers=0 as well then which
> makes the API more symmetric and
On 08/03/2018 02:27 AM, Marcos Paulo de Souza wrote:
> Hi guys,
>
> in some drivers, auth and auth->cb are checked in connectOpen function, while
> in xenapi,
> only auth is checked, which that could lead to a problem if cb if invalid. In
> phyp, auth and auth->cb are checked twice, in getUser
On Tue, Aug 14, 2018 at 05:35:32PM +0200, Andrea Bolognani wrote:
This requires
https://www.redhat.com/archives/libvir-list/2018-August/msg00863.html
to be merged first.
Andrea Bolognani (2):
guests: Install flake8 for libvirt-dbus
projects: Run 'make syntax-check' for libvirt-dbus
On Tue, Aug 14, 2018 at 05:30:44PM +0200, Andrea Bolognani wrote:
Recent versions of the tool will look for Python scripts
on their own, but when performing a VPATH build it's very
likely the resulting list will be empty and nothing will
actually be checked. Point flake8 to the files explicitly
On Tue, Aug 14, 2018 at 05:30:43PM +0200, Andrea Bolognani wrote:
Andrea Bolognani (3):
tests: Point flake8 to the files it needs to check
configure: Detect flake8 automatically
configure: Find flake8 on FreeBSD
Makefile.am | 2 +-
configure.ac | 1 +
2 files changed, 2 insertions(+), 1
On Tuesday, 14 August 2018 17:30:45 CEST Andrea Bolognani wrote:
> This also allows the user to run a custom flake8
> by setting FLAKE8 in the environment.
>
> Signed-off-by: Andrea Bolognani
> ---
> Makefile.am | 2 +-
> configure.ac | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
It is required to run 'make syntax-check'.
Signed-off-by: Andrea Bolognani
---
guests/vars/mappings.yml | 7 +++
guests/vars/projects/libvirt-dbus.yml | 1 +
2 files changed, 8 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index
This requires
https://www.redhat.com/archives/libvir-list/2018-August/msg00863.html
to be merged first.
Andrea Bolognani (2):
guests: Install flake8 for libvirt-dbus
projects: Run 'make syntax-check' for libvirt-dbus
guests/vars/mappings.yml | 7 +++
Now that we have the necessary tools installed, we
can run the extra checks for every build.
Signed-off-by: Andrea Bolognani
---
projects/libvirt-dbus.yaml | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/projects/libvirt-dbus.yaml b/projects/libvirt-dbus.yaml
The newest version available from ports at the moment
is built against Python 3.6 and is thus installed as
flake8-3.6 on the platform. This makes syntax-check
work out of the box on FreeBSD.
Signed-off-by: Andrea Bolognani
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This also allows the user to run a custom flake8
by setting FLAKE8 in the environment.
Signed-off-by: Andrea Bolognani
---
Makefile.am | 2 +-
configure.ac | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index a0696bf..c6d09e6 100644
---
Recent versions of the tool will look for Python scripts
on their own, but when performing a VPATH build it's very
likely the resulting list will be empty and nothing will
actually be checked. Point flake8 to the files explicitly
to avoid the issue.
Signed-off-by: Andrea Bolognani
---
Andrea Bolognani (3):
tests: Point flake8 to the files it needs to check
configure: Detect flake8 automatically
configure: Find flake8 on FreeBSD
Makefile.am | 2 +-
configure.ac | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
2.17.1
--
libvir-list mailing list
On Mon, Aug 13, 2018 at 05:59:43PM +0200, Peter Krempa wrote:
Move the preparation steps from qemuDomainAttachDiskGeneric up into
qemuDomainAttachDeviceDiskLive so that also media changing can use the
prepared file.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 11 ++-
1
On Mon, Aug 13, 2018 at 05:59:42PM +0200, Peter Krempa wrote:
Use qemuDomainAttachDeviceDiskLive to change the media in
qemuDomainChangeDiskLive as the former function already does all the
necessary steps to prepare the new medium.
This also allows us to turn qemuDomainChangeEjectableMedia
On 08/02/2018 08:27 PM, Marcos Paulo de Souza wrote:
> Instead of adding the same check for every drivers, execute the checks
> in virAuthGetUsername and virAuthGetPassword. These funtions are called
> when user is not set in the URI.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
>
On Mon, Aug 13, 2018 at 01:55:25PM +0200, Andrea Bolognani wrote:
Andrea Bolognani (2):
configure: Fix quoting
configure: Call PKG_CHECK_MODULES() correctly
configure.ac | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
Reviewed-by: Ján Tomko
Jano
Hi,
This series was run against 'syntax-check' test by patchew.org, which failed,
please find the details below:
Type: series
Message-id: cover.1534173734.git.pkre...@redhat.com
Subject: [libvirt] [PATCHv2 00/62] qemu: Add support for -blockdev
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing
On Tue, Aug 14, 2018 at 08:21:40 -0400, John Ferlan wrote:
>
>
> On 08/14/2018 05:00 AM, Jiri Denemark wrote:
> > On Wed, Aug 01, 2018 at 18:02:28 +0100, Daniel P. Berrangé wrote:
> >> Currently we have a cpu_map.xml file that contains all the features and
> >> CPU models for all architectures
On Mon, Aug 13, 2018 at 05:59:41PM +0200, Peter Krempa wrote:
Turns out that 'query-nodes' is not what we want and the
'query-blockstats' command was in fact buggy. Revert the new field since
it's not needed.
This reverts commit 50edca1331298bfcb2622e8fe588d493aff9ab68.
Signed-off-by: Peter
On Wed, Aug 01, 2018 at 18:02:30 +0100, Daniel P. Berrangé wrote:
> The x86 and ppc impls both duplicate some logic when parsing CPU
> features. Change the callback signature so that this duplication can be
> pushed up a level to common code.
>
> Signed-off-by: Daniel P. Berrangé
> ---
>
On Tue, Aug 14, 2018 at 04:16:04PM +0200, Andrea Bolognani wrote:
This fixes 'make syntax-check'.
The issue was introduced by commit 7da2b425a8cc.
Reported-by: Ján Tomko
Signed-off-by: Andrea Bolognani
---
tests/test_nodedev.py | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko
On Mon, 2018-08-13 at 14:11 +0200, Ján Tomko wrote:
> On Fri, Jul 27, 2018 at 02:37:38PM +0200, Andrea Bolognani wrote:
> > -@pytest.mark.usefixtures("node_device_create")
> > class TestNodeDevice(libvirttest.BaseTestClass):
> > """ Tests for methods and properties of the NodeDevice interface
This fixes 'make syntax-check'.
The issue was introduced by commit 7da2b425a8cc.
Reported-by: Ján Tomko
Signed-off-by: Andrea Bolognani
---
tests/test_nodedev.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/test_nodedev.py b/tests/test_nodedev.py
index 082cf0b..5c8206e 100755
---
On Mon, Aug 13, 2018 at 05:59:40PM +0200, Peter Krempa wrote:
The diff contains changes from the change of the JSON library
reformatting as well as dropping of the preconfig state and adding of
the 'qdev' field to output of 'query-blockstats'.
After commit
On Tue, Aug 14, 2018 at 04:03:49PM +0200, Andrea Bolognani wrote:
> Since libvirt commit 34a6962c41b4 it's required to
> successfully build the RPM packages.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/vars/mappings.yml | 4
> guests/vars/projects/libvirt.yml | 1 +
> 2
s/useless/unused/ maybe?
On Mon, Aug 13, 2018 at 05:59:39PM +0200, Peter Krempa wrote:
We don't use it for anything useful so it does not make much sense to
extract it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.h | 1 -
src/qemu/qemu_monitor_json.c | 7 ---
On Mon, Aug 13, 2018 at 05:59:38PM +0200, Peter Krempa wrote:
QEMU supports 'block_resize' since 0.14 so we don't need to do explicit
checking. Additionally the caller did not use the different value at
all.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 7 ---
1 file
Since libvirt commit 34a6962c41b4 it's required to
successfully build the RPM packages.
Signed-off-by: Andrea Bolognani
---
guests/vars/mappings.yml | 4
guests/vars/projects/libvirt.yml | 1 +
2 files changed, 5 insertions(+)
diff --git a/guests/vars/mappings.yml
On Mon, Aug 13, 2018 at 05:59:37PM +0200, Peter Krempa wrote:
Remove the pointless "empty path" check and use a better error message
if the disk was not found.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Ján
On 07/23/2018 02:22 PM, xinhua.Cao wrote:
> Currently iohelper's error log is recorded in virFileWrapperFdClose.
> In qemuDomainSaveMemory, it usually fails at qemuMigrationSrcToFile,
> and then goto cleanup, so the iohelper error log is not recorded,
> and so is the another placement. We now
On Mon, Aug 13, 2018 at 05:59:36PM +0200, Peter Krempa wrote:
Print the differences in case when the expected data does not match.
Signed-off-by: Peter Krempa
---
tests/qemumonitorjsontest.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko
On Mon, Aug 13, 2018 at 05:59:35PM +0200, Peter Krempa wrote:
Currently we'd report the alias of the drive which is backing the cdrom
rather than the device itself:
$ virsh event ds tray-change --loop
event 'tray-change' for domain ds disk drive-ide0-0-1: opened
event 'tray-change' for domain
On 08/14/2018 11:07 AM, Andrea Bolognani wrote:
> See patch 6 for the explanation; the previous 5 patches
> are cleanups.
>
> I had to snip out some patches to comply with the message
> size limit for the list - ironic, I know. The full commits
> can be fetched from
>
>
On Tue, Aug 14, 2018 at 03:21:06PM +0200, Peter Krempa wrote:
> This function does not modify the host. It merely puts the file
> descriptor into a list in virCommandPtr.
Yes & no.
It doesn't directly modify the host, but my adding the FD to 'passfd' set,
when virCommandFree is run later, it
Allow mocking of the file descriptor numbers used for the TPM
passthrough mode by extracting the relevant code into an exported
function.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 41 +++--
src/qemu/qemu_command.h | 7 +++
2 files
The capability was usable since qemu 1.3 so we can remove all the
detection code.
Signed-off-by: Peter Krempa
---
Note that the *replies files need to be renumbered. I've split that to a
separate patch for ease of review. Notably because it was done
automatically by tests/qemucapsfixreplies.
All supported qemus support FD passing so modify the tests to test the
proper code path.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/tpm-passthrough-crb.args | 5 +++--
tests/qemuxml2argvdata/tpm-passthrough.args | 5 +++--
tests/qemuxml2argvmock.c| 16
The fallout was slightly larger than expected.
Peter Krempa (5):
tests: qemuxml2argvmock: Don't mock virCommandPassFD
qemu: command: Extract opening of TPM backend FDs for mocking purposes
tests: qemuxml2argv: modernize TPM passthrough tests
qemu: capabilities: Always assume
This function does not modify the host. It merely puts the file
descriptor into a list in virCommandPtr.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvmock.c | 8
1 file changed, 8 deletions(-)
diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c
index
We dropped Fedora 26 support in commit 9dbfddc3e7d9,
but somehow overlooked this bit at the time.
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
guests/vars/mappings.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index
On Tue, Aug 14, 2018 at 02:37:44PM +0200, Andrea Bolognani wrote:
> Most distributions we build RPMs on don't ship a
> recent enough version of libiscsi, so we can't enable
> the driver unconditionally. Add an explicit dependency
> on the runtime package while at it.
>
> Signed-off-by: Andrea
On Tue, 2018-08-14 at 14:18 +0200, Pavel Hrdina wrote:
> This change is correct but it's not good enough to fix all the issues in
> specfile related to iscsi-direct, I'll post a patch in a minute that
> fixes remaining issues including this one.
Most distributions we build RPMs on don't ship a
recent enough version of libiscsi, so we can't enable
the driver unconditionally. Add an explicit dependency
on the runtime package while at it.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 26 --
1 file changed,
On 08/14/2018 05:00 AM, Jiri Denemark wrote:
> On Wed, Aug 01, 2018 at 18:02:28 +0100, Daniel P. Berrangé wrote:
>> Currently we have a cpu_map.xml file that contains all the features and
>> CPU models for all architectures in one place. I frequently find myself
>> wondering about the
On Tue, Aug 14, 2018 at 01:44:40PM +0200, Andrea Bolognani wrote:
> Commit 34a6962c41b4 added a BuildRequires for the
> iscsi-direct backend, but we need the headers rather
> than the runtime package to be available in order to
> link against the library.
>
> Signed-off-by: Andrea Bolognani
>
On Mon, Aug 13, 2018 at 10:23:02PM +0530, Sukrit Bhatnagar wrote:
> On Mon, 13 Aug 2018 at 18:10, Erik Skultety wrote:
> >
> > On Thu, Aug 09, 2018 at 09:42:12AM +0530, Sukrit Bhatnagar wrote:
> > > By making use of GNU C's cleanup attribute handled by the
> > > VIR_AUTOPTR macro for declaring
On 08/05/2018 05:54 PM, Roman Bogorodskiy wrote:
> To reconnect to the bhyve process after deamon restart, a process
> VM's pid points to is checked to have proctitle equal to 'bhyve: $vmname'.
> However, there could be a bug in bhyve(8) which prevents it from
> setting proctitle, so process
On Tue, Aug 14, 2018 at 01:44:40PM +0200, Andrea Bolognani wrote:
> Commit 34a6962c41b4 added a BuildRequires for the
> iscsi-direct backend, but we need the headers rather
> than the runtime package to be available in order to
> link against the library.
>
> Signed-off-by: Andrea Bolognani
> ---
Hi,
This series was run against 'syntax-check' test by patchew.org, which failed,
please find the details below:
Type: series
Message-id: cover.1534245398.git.mpriv...@redhat.com
Subject: [libvirt] [PATCH v2 0/7] Introduce metadata locking
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script
On Mon, Aug 13, 2018 at 18:27:06 -0400, John Ferlan wrote:
>
>
> On 08/01/2018 01:02 PM, Daniel P. Berrangé wrote:
> > The x86 and ppc impls both duplicate some logic when parsing CPU
> > features. Change the callback signature so that this duplication can be
> > pushed up a level to common
Commit 34a6962c41b4 added a BuildRequires for the
iscsi-direct backend, but we need the headers rather
than the runtime package to be available in order to
link against the library.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The corresponding libvirt-jenkins-ci commit is f188ff6a7ceb.
Signed-off-by: Andrea Bolognani
---
Pushed under the Dockerfile refresh rule.
buildenv-centos-7.Dockerfile | 4 ++--
buildenv-debian-8.Dockerfile | 2 +-
buildenv-debian-9.Dockerfile | 2 +-
In order for our drivers to lock resources for metadata change we
need set of new APIs. Fortunately, we don't have to care about
every possible device a domain can have. We care only about those
which can live on a network filesystem and hence can be accessed
by multiple daemons at the same time.
Signed-off-by: Michal Privoznik
---
src/locking/lock_daemon_dispatch.c | 12 ++--
src/locking/lock_driver_lockd.c| 31 +--
src/locking/lock_driver_lockd.h| 1 +
3 files changed, 32 insertions(+), 12 deletions(-)
diff --git
Fortunately, we have qemu wrappers so it's sufficient to put
lock/unlock call only there.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_security.c | 107 +++
1 file changed, 107 insertions(+)
diff --git a/src/qemu/qemu_security.c
No real support implemented here. But hey, at least we will not
fail.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver_sanlock.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/src/locking/lock_driver_sanlock.c
This flag modifies the way the lock is acquired. It waits for the
lock to be set instead of usual set-or-fail logic that happens
without this flag.
Signed-off-by: Michal Privoznik
---
src/util/virlockspace.c | 14 ++
src/util/virlockspace.h | 1 +
2 files changed, 11 insertions(+),
So far the virLockSpaceAcquireResource() locks the first byte in
the underlying file. But caller might want to lock other range.
Signed-off-by: Michal Privoznik
---
src/locking/lock_daemon_dispatch.c | 3 +++
src/util/virlockspace.c| 15 ++-
src/util/virlockspace.h
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/locking/lock_driver.h b/src/locking/lock_driver.h
index 8b7521..7c8f79520a 100644
--- a/src/locking/lock_driver.h
+++ b/src/locking/lock_driver.h
@@ -56,6 +56,8 @@ typedef
v2 of:
https://www.redhat.com/archives/libvir-list/2018-August/msg00482.html
diff to v1:
- 1/6 from original patch set is replaced with different approach.
As Dan suggested, virLockSpace accepts range to lock through its API
and has new flag that tells it to wait for the lock to be acquired.
On Tue, Aug 14, 2018 at 01:07:54PM +0200, Andrea Bolognani wrote:
> A straighforward revert of e1575b08511f..d2bbe1eee61a.
>
> Andrea Bolognani (4):
> guests: Re-introduce yajl kludge
> guests: Add yajl mapping
> guests: Install yajl for libvirt
> guests: Don't install jansson for libvirt
It's once again a build dependency.
This reverts commit 34e7fe227418db1d06ce2cd50b042ee3d1a03f29.
Signed-off-by: Andrea Bolognani
---
guests/vars/projects/libvirt.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml
index
A straighforward revert of e1575b08511f..d2bbe1eee61a.
Andrea Bolognani (4):
guests: Re-introduce yajl kludge
guests: Add yajl mapping
guests: Install yajl for libvirt
guests: Don't install jansson for libvirt
guests/playbooks/update/tasks/kludges.yml | 2 ++
guests/vars/mappings.yml
It's no longer needed, and neither is the mapping.
This reverts commit e1575b08511f09e9c7759f02fadd14752fb2f4f1.
Signed-off-by: Andrea Bolognani
---
guests/vars/mappings.yml | 5 -
guests/vars/projects/libvirt.yml | 1 -
2 files changed, 6 deletions(-)
diff --git
We're going to use it for libvirt.
This reverts commit 0399edd04259f8c49dfd0dbd76740217c90baa1c.
Signed-off-by: Andrea Bolognani
---
guests/vars/mappings.yml | 5 +
1 file changed, 5 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index be356aa..f6b762d
libvirt switched back from jansson to yajl, so we're
going to need this in a second.
This reverts commit d2bbe1eee61aea55beed7eea5d9ed60f3a08cbb9.
Signed-off-by: Andrea Bolognani
---
guests/playbooks/update/tasks/kludges.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git
Caused by commit f7d0663d49. The problem is missing libnl library on
these platforms, so the VIR_DEFINE_AUTOPTR_FUNC has to be compiled in
conditionally.
Signed-off-by: Erik Skultety
---
Checked with Travis CI, local fedora with MinGW and FreeBSD, thus pushed under
the build breaker rule.
On Wed, Aug 01, 2018 at 18:02:29 +0100, Daniel P. Berrangé wrote:
> Allow for syntax
>
>
It seems the code should just work with
but Makefile.am and libvirt.spec would need some adjustment.
> to reference other files in the CPU database directory
>
> Signed-off-by: Daniel P.
On Mon, 2018-08-13 at 11:55 -0400, Anya Harter wrote:
> on vir*ObjListExport call stack
>
> Anya Harter (3):
> conf: rename structs used by Export function
> conf: rename Export Callback functions
> conf: rename Match functions
>
> src/conf/virinterfaceobj.c | 16 +---
>
Christian Ehrhardt [2018-08-14, 11:27AM
+0200]:
> diff --git a/src/util/virprocess.c b/src/util/virprocess.c
> index ecea27a2d4..46360cc051 100644
> --- a/src/util/virprocess.c
> +++ b/src/util/virprocess.c
> @@ -341,15 +341,19 @@ int virProcessKill(pid_t pid, int sig)
> * Returns 0 if it was
Hi,
after a good discussion a few days ago in
https://www.redhat.com/archives/libvir-list/2018-August/msg00122.html
and a short lived but back then untested v2 in
https://www.redhat.com/archives/libvir-list/2018-August/msg00199.html
I finally get access to the right HW again and completed the
It was found that in cases with host devices virProcessKillPainfully
might be able to send signal zero to the target PID for quite a while
with the process already being gone from /proc/.
That is due to cleanup and reset of devices which might include a
secondary bus reset that on top of the
In cases where virProcessKillPainfully already reailizes that
SIGTERM wasn't enough we are partially on a bad path already.
Maybe the system is overloaded or having serious trouble to free and
reap resources in time.
In those case give the SIGKILL that was sent after 10 seconds some more
time to
On Tue, Aug 14, 2018 at 11:07:49AM +0200, Andrea Bolognani wrote:
> See patch 6 for the explanation; the previous 5 patches
> are cleanups.
>
> I had to snip out some patches to comply with the message
> size limit for the list - ironic, I know. The full commits
> can be fetched from
Although
We already have a function which parses
thread_siblings_list for a CPU and returns the
corresponding bitmap, and a bunch of utility functions
that perform operations on bitmaps such as counting
the number of set bits: use those to implement the
function instead of having an additional ad-hoc
Unused since commit c67e04e25fa5.
Signed-off-by: Andrea Bolognani
---
src/util/virhostcpu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
index 060d382781..c260d603a9 100644
--- a/src/util/virhostcpu.c
+++ b/src/util/virhostcpu.c
@@ -197,7
The latter are no longer used by libvirt, and the former
never were; moreover, both have a corresponding *_list
file which we can manipulate very conveniently using our
bitmap APIs, so dropping them makes sure in the future
developers will look into that rather than trying to
parse the kernel
See patch 6 for the explanation; the previous 5 patches
are cleanups.
I had to snip out some patches to comply with the message
size limit for the list - ironic, I know. The full commits
can be fetched from
https://github.com/andreabolognani/libvirt/tree/high-ids
Andrea Bolognani (7):
util:
This proves libvirt can now handle high socket_id and
core_id values correctly and ensures we won't introduce
regressions in this area.
Signed-off-by: Andrea Bolognani
---
.../linux-aarch64-high-ids.cpuinfo| 143 ++
.../linux-aarch64-high-ids.expected | 1
1 - 100 of 117 matches
Mail list logo
