On 2018-09-07 at 19:35, Erik Skultety wrote:
>On Fri, Sep 07, 2018 at 04:27:39PM +0800, Shi Lei wrote:
>> This patch fixes memleak for *resp* in virNetDevIPRouteAdd.
>>
>> Signed-off-by: Shi Lei
>> ---
>> src/util/virnetdevip.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff
On 2018-09-07 at 20:42, Erik Skultety wrote:
>On Fri, Sep 07, 2018 at 04:14:46PM +0800, Shi Lei wrote:
>> This patch removes virNetDevPutExtraHeader and replaces
>> it with nlmsg_append directly.
>
>Reworded the commit message a bit and since it passed the build on all
>platforms, I pushed the
On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
If available, use b_info->nested_hvm instead of
b_info->u.hvm.nested_hvm. This will make nested HVM config available
also for PVH domains.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c
On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
Otherwise starting PVH guest will result in "arch_setup_bootlate:
mapping shared_info failed (pfn=..., rc=-1, errno: 12): Internal error".
After this change the behavior is the same as in `xl`.
Signed-off-by: Marek Marczykowski-Górecki
On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
I added a short sentence to the commit message:
Replace the long dead 'xenner' with 'xenfv'.
Signed-off-by: Marek Marczykowski-Górecki
---
docs/schemas/domaincommon.rng | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Followup to review comments I made for recent agent series.
John Ferlan (2):
qemu: Remove duplicated qemuAgentCheckError
qemu: Remove duplicated qemuAgentCheckError
src/qemu/qemu_agent.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
--
2.17.1
--
libvir-list mailing list
Commit 5b3492fadb moved qemuAgentCheckError calls into
qemuAgentCommand for various reasons; however, subsequent
commit b1aa91e14 restored the call. So let's just remove
the duplicitous call from qemuAgentSetVCPUsCommand.
Signed-off-by: John Ferlan
---
src/qemu/qemu_agent.c | 3 ---
1 file
Commit 5b3492fadb moved qemuAgentCheckError calls into
qemuAgentCommand for various reasons; however, subsequent
commit 0977b8aa0 adding a new command made call again
So let's just remove the duplicitous call from
qemuAgentGetInterfaces.
Signed-off-by: John Ferlan
---
src/qemu/qemu_agent.c | 5
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- use virDomainObjEndAPI
- drop duplicated error reporting on virDomainObjIsActive
- bump version comment to 4.8.0
Changes in v3:
- fix virDomainObjIsActive -> virDomainObjCheckActive
- reuse duration not supported message from
When libvirtd is started, initialize domain objects state with its real
state, not only RUNNING/SHUTOFF.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_driver.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/libxl/libxl_driver.c
Needed libxl_domain_suspend_only is supported in Xen >= 4.11. But wakeup should
work with older versions.
Marek Marczykowski-Górecki (3):
libxl: send lifecycle event on suspend
libxl: implement virDomainPM* functions
libxl: initialize domain state with real data
src/libxl/libxl_domain.c |
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 2ab78ac..b800bc9 100644
---
On 09/07/2018 06:52 AM, Wang, Huaqiang wrote:
>
>
[...]
>>> +static int
>>> +virResctrlCreateGroup(virResctrlInfoPtr resctrl,
>>> + char *path)
>>
>> s/char/const char/
>>
>
> Will be fixed.
>
>> should be:
>>
>> virResctrlCreateGroupPath
>>
>
> I prefer the
On Fri, Sep 07, 2018 at 11:10:14AM -0600, Jim Fehlig wrote:
> On 09/06/2018 03:06 PM, Marek Marczykowski-Górecki wrote:
>
> A few additional comments came to mind while looking at this patch again...
Perfect timing, I was just going to hit "send" on v3...
> > > > +/* Unlock virDomainObjPtr
On 09/07/2018 05:12 AM, Wang, Huaqiang wrote:
>
>
>> -Original Message-
>> From: John Ferlan [mailto:jfer...@redhat.com]
>> Sent: Wednesday, September 5, 2018 7:59 PM
>> To: Wang, Huaqiang ; libvir-list@redhat.com
>> Cc: Feng, Shaohe ; Niu, Bing ;
>> Ding, Jian-feng ; Zang, Rui
>>
On 09/07/2018 04:37 AM, Wang, Huaqiang wrote:
>
>
>> -Original Message-
>> From: John Ferlan [mailto:jfer...@redhat.com]
>> Sent: Wednesday, September 5, 2018 7:59 PM
>> To: Wang, Huaqiang ; libvir-list@redhat.com
>> Cc: Feng, Shaohe ; Niu, Bing ;
>> Ding, Jian-feng ; Zang, Rui
>>
On 09/06/2018 03:06 PM, Marek Marczykowski-Górecki wrote:
A few additional comments came to mind while looking at this patch again...
On Thu, Sep 06, 2018 at 02:58:30PM -0600, Jim Fehlig wrote:
On 09/03/2018 04:09 PM, Marek Marczykowski-Górecki wrote:
Signed-off-by: Marek
On 09/07/2018 03:56 AM, Wang, Huaqiang wrote:
>
>
>> -Original Message-
>> From: John Ferlan [mailto:jfer...@redhat.com]
>> Sent: Wednesday, September 5, 2018 7:58 PM
>> To: Wang, Huaqiang ; libvir-list@redhat.com
>> Cc: Feng, Shaohe ; Niu, Bing ;
>> Ding, Jian-feng ; Zang, Rui
>>
On Tue, 2018-09-04 at 16:39 +0800, Yi Min Zhao wrote:
> Add zPCI definitions in preparation of extending the PCI address
> with parameters uid (user-defined identifier) and fid (PCI function
> identifier).
>
> Signed-off-by: Yi Min Zhao
> Reviewed-by: Boris Fiuczynski
> Reviewed-by: Stefan
On Fri, Sep 07, 2018 at 02:09:14PM +0200, Michal Privoznik wrote:
The qemuSecurityDomainSetPathLabel() function reports perfect
error itself. Do not overwrite it to something less meaningful.
On first glance, I thought AppArmorSetPathLabel does not set a libvirt
error, but it turns out that
On Fri, 2018-09-07 at 17:03 +0200, Ján Tomko wrote:
> On Fri, Sep 07, 2018 at 01:06:39PM +0200, Andrea Bolognani wrote:
> > if (!def->data.nix.path &&
> > (!chr_def ||
> > + chr_def->deviceType != VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL ||
> > +
On Fri, Sep 07, 2018 at 01:06:39PM +0200, Andrea Bolognani wrote:
Attempting to use a chardev definition like
correctly results in an error being reported, since the source
path - a required piece of information - is missing; however,
the very similar
was happily accepted by
On Fri, 2018-09-07 at 16:08 +0200, Ján Tomko wrote:
> Previous commits removed all capabilities from per-device property
> probing for:
Add a newline here.
> pci-assign
> kvm-pci-assign
> usb-host
> scsi-generic
[...]
> -{ "scsi-generic", virQEMUCapsDevicePropsSCSIGeneric,
> -
On Fri, 2018-09-07 at 16:08 +0200, Ján Tomko wrote:
> Introduced by QEMU commit 28b77657 in 2011.
The QEMU version number (v1.0-rc4~21^2~8 in this case) would be
more useful than the year. With that fixed,
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
On Fri, 2018-09-07 at 16:08 +0200, Ján Tomko wrote:
> Introduced by QEMU commit c29029d which was released in 1.5.0
s/released/included/
> -if (subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) {
> -if (subsys->u.pci.backend ==
> -
Since its introduction in commit 2e37bf42 the naming of the arguments
between the prototype and the definition does not match.
Signed-off-by: Ján Tomko
---
Pushed as trivial.
src/conf/domain_conf.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.h
On Fri, 2018-09-07 at 16:08 +0200, Ján Tomko wrote:
> Added by QEMU commit 65bb3a5 contained in v1.1.
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, 2018-09-07 at 16:08 +0200, Ján Tomko wrote:
> Added by QEMU commit 65bb3a5 contained in v1.1.
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, 2018-09-07 at 16:08 +0200, Ján Tomko wrote:
> Added by commit fc66c1603c and not used since.
Most importantly, usb-net was already present in QEMU 1.5.0,
which means we can drop the capability instead of implementing
the missing check. With that mentioned in the commit message,
On Fri, 2018-09-07 at 16:08 +0200, Ján Tomko wrote:
> At the time of its addition in QEMU commit v1.3.0-rc0~572^2
> the bootindex argument was already supported.
Please mention pci-assign here as well.
Reviewed-by: Andrea Bolognani
It's really nice that you're mentioning QEMU commits right
On Thu, Sep 06, 2018 at 10:04:35AM -0400, Cole Robinson wrote:
On 09/06/2018 09:04 AM, Martin Kletzander wrote:
On Wed, Sep 05, 2018 at 03:37:22PM +0100, Daniel P. Berrangé wrote:
On Wed, Sep 05, 2018 at 02:01:42PM +0200, Martin Kletzander wrote:
On Wed, Sep 05, 2018 at 09:28:52AM +0100,
On Fri, 2018-09-07 at 16:08 +0200, Ján Tomko wrote:
> At the time of its addition in QEMU commit v1.3.0-rc0~572^2
> the configfd argument was already supported.
By "its addition" I guess you mean pci-assign's, but that's not
immediately clear from the context. If you mention it explicitly
in the
Introduced by QEMU commit 28b77657 in 2011.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 1 -
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_command.c| 9 -
Introduced by QEMU commit c29029d which was released in 1.5.0
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 1 -
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_command.c| 12
Previous commits removed all capabilities from per-device property
probing for:
pci-assign
kvm-pci-assign
usb-host
scsi-generic
Remove them from the virQEMUCapsDeviceProps list and get rid of the
redundant device-list-properties QMP calls.
Note that 'pci-assign' was already useless,
Added by QEMU commit 65bb3a5 contained in v1.1.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 1 -
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_command.c| 7 ---
At the time of its addition in QEMU commit v1.3.0-rc0~572^2
the bootindex argument was already supported.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 1 -
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_command.c
At the time of its addition in QEMU commit v1.3.0-rc0~572^2
the configfd argument was already supported.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 1 -
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_command.c
Added by commit fc66c1603c and not used since.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 1 -
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 -
While reviewing a bootindex-related patch, I found out that we can
also drop all the per-device BOOTINDEX capabilities and more.
Ján Tomko (9):
qemu: always assume QEMU_CAPS_PCI_CONFIGFD
qemu: always assume QEMU_CAPS_PCI_BOOTINDEX
qemu: drop unused QEMU_CAPS_DEVICE_USB_NET
qemu: always
Added by QEMU commit 65bb3a5 contained in v1.1.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 1 -
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_command.c | 9 +
On 09/07/2018 06:41 AM, Ján Tomko wrote:
> conf: fix boot order with
>
> You don't need the whole reproducer in the commit summary
But what you've given isn't a correct description :-) The boot order
isn't being fixed; the false error is being eliminated.
>
> On Thu, Sep 06, 2018 at 09:14:26PM
On Friday, 7 September 2018 13:57:03 CEST Andrea Bolognani wrote:
> On Thu, 2018-09-06 at 17:13 +0200, Pino Toscano wrote:
> > What do you think? Is it an acceptable path forward?
>
> Rewriting history is frowned upon for very good reasons, but
> considering that the last commit performing
On Fri, Sep 07, 2018 at 04:14:46PM +0800, Shi Lei wrote:
> This patch removes virNetDevPutExtraHeader and replaces
> it with nlmsg_append directly.
Reworded the commit message a bit and since it passed the build on all
platforms, I pushed the patch.
Reviewed-by: Erik Skultety
--
libvir-list
Commit 39015a6f3 modified the test to be more reliable/realistic,
but without checking the return status of virEventRunDefaultImpl
it's possible that the test could run infinitely.
Found by Coverity
Signed-off-by: John Ferlan
---
tests/virnetsockettest.c | 9 +++--
1 file changed, 7
The qemuSecurityDomainSetPathLabel() function reports perfect
error itself. Do not overwrite it to something less meaningful.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_process.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/qemu/qemu_process.c
In some cases we are checking if the mount namespace is enabled
at two places: one is at the beginning of exported function (e.g.
qemuDomainNamespaceSetupDisk()) and the other is at the beginning
of qemuDomainNamespaceMknodPaths() which is called from the
former function anyway. Then we have some
On Thu, 2018-09-06 at 17:13 +0200, Pino Toscano wrote:
> What do you think? Is it an acceptable path forward?
Rewriting history is frowned upon for very good reasons, but
considering that the last commit performing anything but trivial
maintainance tasks is from 2009 I think it's pretty fair to
On Fri, Sep 07, 2018 at 04:27:39PM +0800, Shi Lei wrote:
> This patch fixes memleak for *resp* in virNetDevIPRouteAdd.
>
> Signed-off-by: Shi Lei
> ---
> src/util/virnetdevip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/util/virnetdevip.c
From: Marc-André Lureau
Check anonymous memory is backed by memfd if qemu is capable.
Signed-off-by: Marc-André Lureau
---
tests/qemuxml2argvdata/memfd-memory-numa.args | 28 +++
tests/qemuxml2argvdata/memfd-memory-numa.xml | 36 +++
tests/qemuxml2argvtest.c
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 61 +
1 file changed, 43 insertions(+), 18 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index c9e3a91e32..97cfc8a18d 100644
---
From: Marc-André Lureau
Hi,
This is an alternative to "[RFC v2 02/16] qemu: add memfd memory
backing", which added a new source type. Instead, Daniel suggested to
automatically use memfd for anonymous memory when available.
Marc-André Lureau (5):
qemu: add memory-backend-memfd capability
From: Marc-André Lureau
memfd is able to allocate hugepage anonymous memory.
Signed-off-by: Marc-André Lureau
---
src/conf/domain_conf.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 86199623cc..696cf6ef18 100644
---
From: Marc-André Lureau
Check availability of "-object memory-backend-memfd".
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 +
From: Marc-André Lureau
QEMU 3.1 should only expose the property if the host is actually
capable of creating hugetable-backed memfd. However, it may fail
at runtime depending on requested "hugetlbsize".
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 8
Attempting to use a chardev definition like
correctly results in an error being reported, since the source
path - a required piece of information - is missing; however,
the very similar
was happily accepted by libvirt, only to result in libvirtd
crashing as soon as the
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 10:49 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 05/10] util: resctrl:
commit b00c9c39 removed the label end_of_netlink_messages and 'return
table' statement, It causes the function virArpTableGet doesn't return
a proper virArpTable pointer.
How to reproduce:
# virsh domiflist sles12sp3
Interface Type Source Model MAC
When we call qemuARPGetInterfaces to get IP from host's arp table, The
iface's type has nothing to do with it, We should allow all of type.
Signed-off-by: Lin Ma
---
src/qemu/qemu_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
Lin Ma (2):
qemu: Remove network type limitation for qemuARPGetInterfaces
virarptable: Return a virArpTablePtr when the nlmsghdr for loop is
over
src/qemu/qemu_driver.c | 3 ---
src/util/virarptable.c | 2 ++
2 files changed, 2 insertions(+), 3 deletions(-)
--
2.16.2
--
libvir-list
conf: fix boot order with
You don't need the whole reproducer in the commit summary
On Thu, Sep 06, 2018 at 09:14:26PM -0400, Laine Stump wrote:
virDomainDefCollectBootOrder() is called for every item on the list
for each type of device. Since an is on
both the list of hostdev devices and
On 09/07/2018 10:35 AM, Ján Tomko wrote:
> On Fri, Sep 07, 2018 at 07:21:18AM +0200, Michal Prívozník wrote:
>> On 09/07/2018 12:52 AM, John Ferlan wrote:
>>>
>>>
>>> On 09/06/2018 12:16 PM, Michal Privoznik wrote:
There is no need to check if @npaths is not zero. Let's
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 7:59 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 04/10] test: add test case for
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 7:59 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 03/10] conf: Add CMT capability
On Fri, Sep 07, 2018 at 07:21:18AM +0200, Michal Prívozník wrote:
On 09/07/2018 12:52 AM, John Ferlan wrote:
On 09/06/2018 12:16 PM, Michal Privoznik wrote:
There is no need to check if @npaths is not zero. Let's
qemuDomainNamespaceUnlinkPaths() handle that.
Signed-off-by: Michal Privoznik
This patch fixes memleak for *resp* in virNetDevIPRouteAdd.
Signed-off-by: Shi Lei
---
src/util/virnetdevip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c
index 0f080a5..16570a5 100644
--- a/src/util/virnetdevip.c
+++
This patch removes virNetDevPutExtraHeader and replaces
it with nlmsg_append directly.
Signed-off-by: Shi Lei
---
src/util/virnetdev.c | 44
1 file changed, 12 insertions(+), 32 deletions(-)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 7:58 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 02/10] util: add interface
This patch adds wrapper macros around nla_nest_[start|end] and nla_put
which can make virNetlinkNewLink more readable.
Signed-off-by: Shi Lei
---
src/util/virnetlink.c | 43 +++
src/util/virnetlink.h | 30 ++
2 files changed,
This patch simplifies virNetDevBridgeCreate and virNetDevMacVLanCreate
by using virNetlinkNewLink.
Signed-off-by: Shi Lei
---
src/util/virnetdevbridge.c | 73 +++-
src/util/virnetdevmacvlan.c | 110 +---
2 files changed, 24 insertions(+),
v2 here:
https://www.redhat.com/archives/libvir-list/2018-September/msg00131.html
Diff from V2:
This series remove all unrelated changes. Those changes would be
standalone patches.
Shi Lei (3):
util: netlink: Introduce virNetlinkNewLink helper
util: netlink: Add wrapper macros to make
This patch introduces virNetlinkNewLink helper which wraps the common
libnl/netlink code to create a new link.
Signed-off-by: Shi Lei
---
src/libvirt_private.syms | 1 +
src/util/virnetlink.c| 117 +++
src/util/virnetlink.h| 13 +
3 files
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 7:58 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 01/10] conf: Renamed
73 matches
Mail list logo
