At 2018-09-25 17:37:24, "Lin Ma" wrote:
>Let's ignore the checking of interface type when we call the function
>qemuARPGetInterfaces to get IP from host's arp table.
>
>Based on suggestion from Laine.
>https://www.redhat.com/archives/libvir-list/2018-September/msg00684.html
>
>Signed-off-by:
On 9/21/18 9:02 AM, Marc Hartmayer wrote:
> Marc Hartmayer (4):
> virdbus: Grab a ref as long as the while loop is executed
> virdbus: Unref the D-Bus connection when closing
> virdbus: Report a debug message that dbus_watch_handle() has failed
> virdbus: Use the mnemonic macros for
On 9/25/18 9:38 AM, Daniel Veillard wrote:
> On Tue, Sep 25, 2018 at 09:42:20AM +0200, Michal Privoznik wrote:
>> On 09/24/2018 03:42 PM, Daniel Veillard wrote:
>>> that's next week ! If we want to release around Oct 1st, I would
>>> suggest to enter freeze this Wed, probably in the morning
On 9/25/18 3:34 AM, Michal Privoznik wrote:
> It may happen that in the list of paths/disk sources to relabel
> there is a disk source. If that is the case, the path is NULL. In
> that case, we shouldn't try to lock the path. It's likely a
> network disk anyway and therefore there is nothing to
On 9/21/18 5:29 AM, Michal Privoznik wrote:
> There is this latent bug which can result in virtlockd killing
> libvirtd. The problem is when the following steps occur:
>
>Parent | Child
>
On 9/21/18 5:29 AM, Michal Privoznik wrote:
> There is one caller (virSecurityManagerMetadataLock) which
> duplicates the connection FD and wants to have the flag set.
> However, trying to set the flag after dup() is not safe as
> another thread might fork() meanwhile. Therefore, switch to
>
On 9/21/18 5:29 AM, Michal Privoznik wrote:
> If there was a caller which would dup the client FD without
> CLOEXEC flag and later decided to change the flag it wouldn't be
> safe to do because fork() might have had occurred meantime.
blank line
> Switch to the other pattern - always dup FD
On 9/21/18 5:29 AM, Michal Privoznik wrote:
> This shouldn't be needed per-se. Security manager shouldn't
> disappear during transactions - it's immutable. However, it
> doesn't hurt to grab a reference either - transaction code uses
> it after all.
>
> Signed-off-by: Michal Privoznik
> ---
>
Introduced by:
commit 542039fab09bd46f419702667cd342ae8f88b498
Fully support mingw builds
Made redundant by:
commit ec8a2d0327ee214111bca04c39ab61a9fc247f28
regex: gnulib guarantees that we have regex support
Signed-off-by: Ján Tomko
---
configure.ac | 1 -
1 file changed, 1
Signed-off-by: Ján Tomko
---
configure.ac | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/configure.ac b/configure.ac
index f23faf8b8f..00e2de7b1f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -353,23 +353,23 @@ AC_CHECK_FUNCS_ONCE([\
dnl
Commit 7c08fcc4 added this one.
Signed-off-by: Ján Tomko
---
configure.ac | 1 -
1 file changed, 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 00e2de7b1f..2d2c783dc2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -369,7 +369,6 @@ AC_CHECK_HEADERS([\
sys/sysctl.h \
Introduced by:
commit 635ae38979bbb2659a21dfaa57e7c762ae8d4e88
commit 1b745219c7507595d4a09c89aa6a331eaa039e31
But their HAVE_ counterparts were never used.
Signed-off-by: Ján Tomko
---
configure.ac | 2 --
1 file changed, 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index
Introduced by:
commit 3c37a171a2dea8048dfee90e1be2875f30f7eb15
Add check for kill() to fix build of cgroups on win32
Made redundant by:
commit 02f1fd41f60c90b636ba0e18b37d4624fe47135d
cgroup macros refactoring, part 1
Signed-off-by: Ján Tomko
---
configure.ac | 1 -
1 file changed, 1
Introduced by:
commit b38d045dea41ea1fb41e546e61388116eddb6b3c
Remove use of sys/poll.h on mingw
Made redundant by:
commit 0c97e70b74434b4baca9bbfc19c14bf7ff2ef304
Update event loop example programs to demonstrate best practice
Signed-off-by: Ján Tomko
---
configure.ac | 1 -
1 file
Use one line per entry, to work better with line-based git history.
Signed-off-by: Ján Tomko
---
configure.ac | 56 +++-
1 file changed, 47 insertions(+), 9 deletions(-)
diff --git a/configure.ac b/configure.ac
index 1b5c56b1a9..f23faf8b8f
Ján Tomko (7):
configure: split common header and function checks
configure: sort AC_CHECK_HEADERS argument list
configure: remove duplicit check for sys/un.h
configure: remove check for regex.h
configure: remove check for poll.h
configure: do not check for kill
configure: remove
On 09/25/2018 04:31 PM, Mark Asselstine wrote:
> On Tuesday, September 25, 2018 5:20:26 AM EDT Michal Privoznik wrote:
>> On 09/24/2018 05:11 PM, Mark Asselstine wrote:
>
> Here is my read, again I have to caveat that this code is rather new to me.
>
> The object poisoning in virObjectUnref()
On 9/25/18 9:19 AM, Jiri Denemark wrote:
> The only place where VIR_DOMAIN_EVENT_RESUMED should be generated is the
> RESUME event handler to make sure we don't generate duplicate events or
> state changes. In the worse case the duplicity can revert or cover
> changes done by other event
On Tuesday, September 25, 2018 5:20:26 AM EDT Michal Privoznik wrote:
> On 09/24/2018 05:11 PM, Mark Asselstine wrote:
> > A deadlock situation can occur when autostarting a LXC domain 'guest'
> > due to two threads attempting to take opposing locks while holding
> > opposing locks (AB BA
On Tue, Sep 25, 2018 at 03:35:11PM +0200, Pavel Hrdina wrote:
Cgroups are supported only on linux.
Signed-off-by: Pavel Hrdina
---
src/util/vircgroupv1.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c
index
On Tue, Sep 25, 2018 at 03:35:11PM +0200, Pavel Hrdina wrote:
> Cgroups are supported only on linux.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/util/vircgroupv1.c | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c
> index
On Tue, Sep 25, 2018 at 09:42:20AM +0200, Michal Privoznik wrote:
> On 09/24/2018 03:42 PM, Daniel Veillard wrote:
> > that's next week ! If we want to release around Oct 1st, I would
> > suggest to enter freeze this Wed, probably in the morning europe time,
> > then plan for an RC2 friday
Cgroups are supported only on linux.
Signed-off-by: Pavel Hrdina
---
src/util/vircgroupv1.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c
index 62a6e5c448..3d05fbd745 100644
--- a/src/util/vircgroupv1.c
+++
Thanks to the previous commit the RESUME event handler knows what reason
should be used when changing the domain state to VIR_DOMAIN_RUNNING, but
the emitted VIR_DOMAIN_EVENT_RESUMED event still uses a generic
VIR_DOMAIN_EVENT_RESUMED_UNPAUSED detail. Luckily, the event detail can
be easily
On Tue, Sep 25, 2018 at 01:01:59PM +0200, Michal Privoznik wrote:
> On 09/25/2018 12:47 PM, Erik Skultety wrote:
> > On Tue, Sep 25, 2018 at 09:34:50AM +0200, Michal Privoznik wrote:
> >> It may happen that in the list of paths/disk sources to relabel
> >> there is a disk source. If that is the
This patch replaces some rather generic VIR_DOMAIN_RUNNING_UNPAUSED
reasons when changing domain state to running with more specific ones.
All of them are done when libvirtd reconnects to an existing domain
after being restarted and sees an unfinished migration or save.
Signed-off-by: Jiri
The only place where VIR_DOMAIN_EVENT_RESUMED should be generated is the
RESUME event handler to make sure we don't generate duplicate events or
state changes. In the worse case the duplicity can revert or cover
changes done by other event handlers.
For example, after QEMU sent RESUME,
VIR_DOMAIN_EVENT_RESUMED_FROM_SNAPSHOT was defined but not used anywhere
in our event generation code. This fixes qemuDomainRevertToSnapshot to
properly report why the domain was resumed.
Signed-off-by: Jiri Denemark
Reviewed-by: John Ferlan
---
Notes:
Version 2:
- no change
https://bugzilla.redhat.com/show_bug.cgi?id=1612943
Version 2:
- keep VIR_DOMAIN_EVENT_RESUMED_MIGRATED event at the end of post-copy
migration
Jiri Denemark (5):
qemu: Properly report VIR_DOMAIN_EVENT_RESUMED_FROM_SNAPSHOT
qemu: Report more appropriate running reasons
qemu: Pass running
Whenever we get the RESUME event from QEMU, we change the state of the
affected domain to VIR_DOMAIN_RUNNING with VIR_DOMAIN_RUNNING_UNPAUSED
reason. This is fine if the domain is resumed unexpectedly, but when we
sent "cont" to QEMU we usually have a better reason for the state
change. The better
Commit 95d19cd unconditionally adjusted the tests to account for
the conditional move of the nested_hvm setting location.
Run the affected tests only for the new setup (witnessed by
LIBXL_HAVE_BUILDINFO_NESTED_HVM).
Signed-off-by: Ján Tomko
---
Technically a build breaker fix, but I'd love to
On Tue, Sep 25, 2018 at 12:02:40 +0200, Wim Ten Have wrote:
> From: Wim ten Have
>
> This patch extends the guest domain administration adding support
> to automatically advertise the host NUMA node capabilities obtained
> architecture under a guest by creating a vNUMA copy.
I'm pretty sure
On Tue, Sep 25, 2018 at 12:49:46PM +0200, Ján Tomko wrote:
> On Tue, Sep 18, 2018 at 05:46:08PM +0200, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/util/vircgroup.c | 6 +-
> > src/util/vircgrouppriv.h | 2 +-
> > src/util/vircgroupv1.c | 140
On 09/25/2018 02:03 PM, Ján Tomko wrote:
> On Mon, Sep 24, 2018 at 03:30:02PM +0200, Michal Privoznik wrote:
>> On 09/24/2018 03:14 PM, Ján Tomko wrote:
>>> Please no.
>>>
>>> Despite my comments on the first spacing rule [0], this series slows
>>> down the spacing check by 100 % (from 1.6s to
On Mon, Sep 24, 2018 at 03:30:02PM +0200, Michal Privoznik wrote:
On 09/24/2018 03:14 PM, Ján Tomko wrote:
Please no.
Despite my comments on the first spacing rule [0], this series slows
down the spacing check by 100 % (from 1.6s to 3.1s in my case).
I don't think that syntax-check run time
On 09/25/2018 12:47 PM, Erik Skultety wrote:
> On Tue, Sep 25, 2018 at 09:34:50AM +0200, Michal Privoznik wrote:
>> It may happen that in the list of paths/disk sources to relabel
>> there is a disk source. If that is the case, the path is NULL. In
>
> Is there a way to prevent to such a source
On Tue, Sep 18, 2018 at 05:46:08PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c | 6 +-
src/util/vircgrouppriv.h | 2 +-
src/util/vircgroupv1.c | 140 +++
tests/vircgrouptest.c| 14 ++--
4 files changed, 81
On Tue, Sep 18, 2018 at 05:46:07PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgrouppriv.h | 8
src/util/vircgroupv1.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
On Tue, Sep 18, 2018 at 05:46:06PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 10 ++
src/util/vircgroupbackend.h | 10 ++
src/util/vircgroupv1.c | 24
3 files changed, 36 insertions(+), 8 deletions(-)
On Tue, Sep 25, 2018 at 09:34:50AM +0200, Michal Privoznik wrote:
> It may happen that in the list of paths/disk sources to relabel
> there is a disk source. If that is the case, the path is NULL. In
Is there a way to prevent to such a source would not make it into the list in
the first place?
>
On Tue, Sep 18, 2018 at 05:46:05PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 13 ++---
src/util/vircgroupbackend.h | 10 ++
src/util/vircgroupv1.c | 27 +++
3 files changed, 39 insertions(+), 11
On Tue, Sep 18, 2018 at 05:46:04PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 10 ++
src/util/vircgroupbackend.h | 11 +++
src/util/vircgroupv1.c | 25 +
3 files changed, 38 insertions(+), 8 deletions(-)
On Tue, Sep 18, 2018 at 05:46:03PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 8 ++--
src/util/vircgroupbackend.h | 11 +++
src/util/vircgroupv1.c | 23 +++
3 files changed, 36 insertions(+), 6 deletions(-)
On Tue, Sep 18, 2018 at 05:46:02PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 39 +-
src/util/vircgroupbackend.h | 6 +
src/util/vircgroupv1.c | 47 +
3 files changed, 54
On Tue, Sep 18, 2018 at 05:46:01PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 7 ++-
src/util/vircgroupbackend.h | 11 +++
src/util/vircgroupv1.c | 22 ++
3 files changed, 35 insertions(+), 5 deletions(-)
On Tue, Sep 18, 2018 at 05:46:00PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 13 +
src/util/vircgroupbackend.h | 4
src/util/vircgroupv1.c | 19 +++
3 files changed, 24 insertions(+), 12 deletions(-)
On Tue, Sep 18, 2018 at 05:45:58PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 18 ++
src/util/vircgroupbackend.h | 10 ++
src/util/vircgroupv1.c | 32
3 files changed, 44 insertions(+), 16
On Tue, Sep 18, 2018 at 05:45:59PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 20 +++-
src/util/vircgroupbackend.h | 10 ++
src/util/vircgrouppriv.h| 5 +
src/util/vircgroupv1.c | 32
On Tue, Sep 18, 2018 at 05:45:57PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 8 ++--
src/util/vircgroupbackend.h | 11 +++
src/util/vircgroupv1.c | 23 +++
3 files changed, 36 insertions(+), 6 deletions(-)
On Tue, Sep 18, 2018 at 05:45:56PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 18 ++
src/util/vircgroupbackend.h | 9 +
src/util/vircgroupv1.c | 31 +++
3 files changed, 42 insertions(+), 16
On Thu, Sep 20, 2018 at 09:41:28PM +0200, Fabiano Fidêncio wrote:
> On Thu, Sep 20, 2018 at 10:54 AM, Pavel Hrdina wrote:
Thanks for the review, pushed now.
Pavel
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
On Tue, Sep 18, 2018 at 05:45:55PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 68 +++-
src/util/vircgroupbackend.h | 17 +
src/util/vircgroupv1.c | 69 +
3 files changed,
On Tue, Sep 18, 2018 at 05:45:54PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 9 +
src/util/vircgroupbackend.h | 5 +
src/util/vircgroupv1.c | 16
3 files changed, 22 insertions(+), 8 deletions(-)
Reviewed-by: Ján
On Tue, Sep 18, 2018 at 05:45:53PM +0200, Pavel Hrdina wrote:
They all need virCgroupV1GetMemoryUnlimitedKB() so it's easier to
move them in one commit.
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 128 ++-
src/util/vircgroupbackend.h | 30 +++
From: Wim ten Have
Add tests to ensure that the virDomainNumaAutoconfig() routine to auto-
partition vNUMA topology generates correct KVM/QEMU cmdline arguments
under applicable setup.
Signed-off-by: Wim ten Have
---
.../cpu-host-passthrough-nonuma.args | 25
From: Wim ten Have
Add a mechanism to auto partition the host NUMA topology under the
guest domain.
This patch adds a framework to automatically partition the host into a
small vNUMA subset defined by the guest XML given and
description when are in
effect and the hypervisor indicates per the
From: Wim ten Have
This patch extends the guest domain administration adding support
to automatically advertise the host NUMA node capabilities obtained
architecture under a guest by creating a vNUMA copy.
The mechanism is enabled by setting the check='numa' attribute under
the CPU
On Tue, Sep 18, 2018 at 05:45:52PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 9 +
src/util/vircgroupbackend.h | 5 +
src/util/vircgroupv1.c | 16
3 files changed, 22 insertions(+), 8 deletions(-)
Reviewed-by: Ján
On Tue, Sep 18, 2018 at 05:45:51PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 67 +++---
src/util/vircgroupbackend.h | 10 ++
src/util/vircgroupv1.c | 71 +
3 files changed, 85
Let's ignore the checking of interface type when we call the function
qemuARPGetInterfaces to get IP from host's arp table.
Based on suggestion from Laine.
https://www.redhat.com/archives/libvir-list/2018-September/msg00684.html
Signed-off-by: Lin Ma
---
src/qemu/qemu_driver.c | 3 ---
1 file
On Tue, 2018-09-25 at 17:16 +0800, Yi Min Zhao wrote:
> > > So do you mean we use this kind of API in next version for review?
> >
> > Yes, please :)
>
> I'm not sure how big the change is. So I might take more time
> to prepare the new version. So that we can't catch up with
> the new release.
On 09/24/2018 05:11 PM, Mark Asselstine wrote:
> A deadlock situation can occur when autostarting a LXC domain 'guest'
> due to two threads attempting to take opposing locks while holding
> opposing locks (AB BA problem). Thread A takes and holds the 'vm' lock
> while attempting to take the
在 2018/9/25 下午4:02, Andrea Bolognani 写道:
On Tue, 2018-09-25 at 13:15 +0800, Yi Min Zhao wrote:
From the high level point of view, code outside of conf/ should,
for the most part, not need to concern itself with zPCI at all: it
would eg. ask for a PCI address to be allocated, and if the
On Tue, Sep 18, 2018 at 05:45:50PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 20 +---
src/util/vircgroupbackend.h | 6 ++
src/util/vircgroupv1.c | 28
3 files changed, 35 insertions(+), 19
On Tue, Sep 18, 2018 at 05:45:49PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 34 ++---
src/util/vircgroupbackend.h | 12 +
src/util/vircgroupv1.c | 50 +
3 files changed, 64
On Tue, Sep 18, 2018 at 05:45:48PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 34 ++---
src/util/vircgroupbackend.h | 12 +
src/util/vircgroupv1.c | 50 +
3 files changed, 64
On Tue, Sep 18, 2018 at 05:45:47PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 34 ++---
src/util/vircgroupbackend.h | 12 +
src/util/vircgroupv1.c | 50 +
3 files changed, 64
On Tue, Sep 18, 2018 at 05:45:46PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 34 ++---
src/util/vircgroupbackend.h | 12 +
src/util/vircgroupv1.c | 50 +
3 files changed, 64
On Tue, Sep 18, 2018 at 05:45:45PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 36 +++---
src/util/vircgroupbackend.h | 12 +
src/util/vircgrouppriv.h| 6 +
src/util/vircgroupv1.c | 50
On Tue, Sep 18, 2018 at 05:45:44PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 83 ++
src/util/vircgroupbackend.h | 9
src/util/vircgrouppriv.h| 2 +
src/util/vircgroupv1.c | 89
On Tue, Sep 18, 2018 at 05:45:43PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 87 ++
src/util/vircgroupbackend.h | 8
src/util/vircgroupv1.c | 94 +
3 files changed, 105
On Tue, 2018-09-25 at 13:15 +0800, Yi Min Zhao wrote:
> > > > From the high level point of view, code outside of conf/ should,
> > > > for the most part, not need to concern itself with zPCI at all: it
> > > > would eg. ask for a PCI address to be allocated, and if the device
> > > > in question
On Tue, Sep 18, 2018 at 05:45:42PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c| 14 ++
src/util/vircgroupbackend.h | 20
src/util/vircgroupv1.c | 29 +
3 files changed, 51 insertions(+),
On 09/24/2018 03:42 PM, Daniel Veillard wrote:
> that's next week ! If we want to release around Oct 1st, I would
> suggest to enter freeze this Wed, probably in the morning europe time,
> then plan for an RC2 friday morning and if everything goes well, have
> the final release next monday.
>
>
It may happen that in the list of paths/disk sources to relabel
there is a disk source. If that is the case, the path is NULL. In
that case, we shouldn't try to lock the path. It's likely a
network disk anyway and therefore there is nothing to lock.
Signed-off-by: Michal Privoznik
---
75 matches
Mail list logo
