Re: [libvirt] [PATCH v6 07/13] conf: Introduce parser, formatter for uid and fid

2018-10-16 Thread Yi Min Zhao
在 2018/10/16 下午11:38, Andrea Bolognani 写道: On Tue, 2018-10-16 at 11:12 +0800, Yi Min Zhao wrote: 在 2018/10/11 下午7:45, Andrea Bolognani 写道: You can move virZPCIDeviceAddressIsValid() to util/virpci and export it too, to be consistent with virPCIDeviceAddress*(). It has been moved to

[libvirt] [RFC 1/3] xml: introduce more config elements for NVDIMM memory

2018-10-16 Thread Luyao Zhong
In order to align with QEMU ,four more parameters about NVDIMM will be introduced into Libvirt xml. 1.alignsize The 'alignsize' option allows users to specify the proper alignment. When mmap(2) the backend files, QEMU uses the host page size by default as the alignment of mapping address.

[libvirt] [RFC 3/3] qemu: update qemu command-line generating for NVDIMM memory

2018-10-16 Thread Luyao Zhong
According to the result parsing from xml, add corresponding properties into QEMU command line, including 'align', 'pmem', 'persistence' and 'nvdimm-persistence'. And add testcases related to these properties. Signed-off-by: Zhong,Luyao --- src/qemu/qemu_command.c| 25

[libvirt] [RFC 2/3] xml: update xml parsing and formating about NVDIMM memory

2018-10-16 Thread Luyao Zhong
Four new parameters were introduced into libvirt xml, including 'align', 'pmem', 'persistence' and 'unarmed', which are related to NVDIMM memory device. So we need parse and format the xml to save these configurations.Besides, more testcases related to these parameters were added to verify the

Re: [libvirt] [PATCH] libvirtd: fix potential deadlock when starting vm

2018-10-16 Thread owen...@ucloud.cn
Yes, this is CentOS 6 only, The monitor socket is by default set to NONBLOCK with CentOS 7. I compare the udev code on centos6 and centos7, in udev-147 on centos6: udev_monitor->sock = socket(PF_NETLINK, SOCK_DGRAM|SOCK_CLOEXEC, NETLINK_KOBJECT_UEVENT); in systemd-219 on centos7:

[libvirt] [RFC 0/3] update NVDIMM support

2018-10-16 Thread Luyao Zhong
Hi libvirt experts, This is the RFC for updating NVDIMM support in libvirt. QEMU has supported four more properties which libvirt has not introduced yet, including 'align', 'pmem', 'nvdimm-persistences' and 'unarmed'. The 'align' property allows users to specify the proper alignment. The

[libvirt] [PATCH] conf: Fix typos in pcie controllers' name

2018-10-16 Thread Han Han
Signed-off-by: Han Han --- src/conf/domain_addr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 442e6aab94..e4ed143b76 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -158,9 +158,9 @@

Re: [libvirt] [PATCH v4 2/5] libxl: add support for PVH

2018-10-16 Thread Marek Marczykowski-Górecki
On Sat, Oct 13, 2018 at 08:46:19AM -0600, Jim Fehlig wrote: > I had some couch time at the start of the weekend and was finally able to > try using this series with virt-install. As it turns out, reporting > duplicate blocks for 'xen' is not quite right. Instead we > will want to report the

Re: [libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

2018-10-16 Thread John Ferlan
On 10/14/18 10:26 AM, Han Han wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1535930 > > Report more clear err msg instead of unknown error when coalesce > settings is incomplete. > > Signed-off-by: Han Han > --- > src/conf/domain_conf.c | 6 +- > 1 file changed, 5 insertions(+),

Re: [libvirt] [PATCH] nwfilter: fix learning address thread shutdown

2018-10-16 Thread John Ferlan
On 10/12/18 3:23 AM, Nikolay Shirokovskiy wrote: > If learning thread is configured to learn on all ethernet frames (which is > hardcoded) then chances are big that there is packet on every iteration of > inspecting frames loop. As result we will hang on shutdown because we don't > check

Re: [libvirt] [PATCH] libvirtd: fix potential deadlock when starting vm

2018-10-16 Thread John Ferlan
On 10/11/18 4:13 AM, Bingsong Si wrote: > On CentOS 6, udev_monitor_receive_device will block until the socket becomes Is this really CentOS6 only or just where you've seen it? > readable, udevEventHandleThread will hold the lock all the time and > udevEventHandleCallback hard to get the

Re: [libvirt] [PATCH] network: honor the ipv6 network option

2018-10-16 Thread John Ferlan
On 10/11/18 12:06 AM, Ryan Goodfellow wrote: > According the the documentation for the ipv6 network attribute > > https://libvirt.org/formatnetwork.html > > "When set to yes, the optional parameter ipv6 enables a network > definition with no IPv6 gateway addresses specified to have >

Re: [libvirt] [PATCH 3/3] qemu: don't duplicate suspended events and state changes

2018-10-16 Thread John Ferlan
$SUBJ: s/don't/Don't On 10/10/18 4:04 AM, Nikolay Shirokovskiy wrote: > Now when STOP event handler has correct both suspended event reason > and paused state reason let's wipe out duplicated event sending and > state changed in/after qemuProcessStopCPUs. Since the STOP event handler can use

Re: [libvirt] [PATCH 1/3] qemu: pass stop reason from qemuProcessStopCPUs to stop handler

2018-10-16 Thread John Ferlan
$SUBJ: s/pass/Pass On 10/10/18 4:04 AM, Nikolay Shirokovskiy wrote: > We send duplicate suspended lifecycle events on qemu process stop in several > places. The reason is stop event handler always send suspended event and > we addidionally send same event but with more presise reason after

Re: [libvirt] [PATCH 2/3] qemu: map suspended state reason to suspended event detail

2018-10-16 Thread John Ferlan
$SUBJ: s/map/Map On 10/10/18 4:04 AM, Nikolay Shirokovskiy wrote: > Map is based on existing cases in code where we send suspended > event after changing domain state to paused. > > Signed-off-by: Nikolay Shirokovskiy > --- > src/qemu/qemu_domain.c | 34 ++ >

Re: [libvirt] [PATCH] qemu: Put format=raw onto cmd line for SCSI passthrough

2018-10-16 Thread Daniel P . Berrangé
On Fri, Oct 12, 2018 at 01:17:42PM +0100, Daniel P. Berrangé wrote: > On Fri, Oct 12, 2018 at 01:14:51PM +0200, Michal Privoznik wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1632833 > > > > When doing a SCSI passthrough we don't put format= onto the > > command line. This causes qemu to

Re: [libvirt] [PATCH v6 07/13] conf: Introduce parser, formatter for uid and fid

2018-10-16 Thread Andrea Bolognani
On Tue, 2018-10-16 at 11:12 +0800, Yi Min Zhao wrote: > 在 2018/10/11 下午7:45, Andrea Bolognani 写道: > > You can move virZPCIDeviceAddressIsValid() to util/virpci and > > export it too, to be consistent with virPCIDeviceAddress*(). > > It has been moved to util/virpci. Isn't it? No, it's in

Re: [libvirt] [PATCH] libvirt: add daemon itself as shutdown reason

2018-10-16 Thread John Ferlan
On 10/8/18 7:21 AM, Nikolay Shirokovskiy wrote: > Let's introduce shutdown reason "daemon" which means we have to > kill running domain ourselves as the best action we can take at > that moment. Failure to pick up domain on daemon restart is > one example of such case. Using reason "crashed" is

Re: [libvirt] [PATCH v2] vhost-user: define conventions for vhost-user backends

2018-10-16 Thread Daniel P . Berrangé
On Tue, Oct 16, 2018 at 02:47:12PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Oct 12, 2018 at 1:56 PM Daniel P. Berrangé > wrote: > > > > On Fri, Oct 12, 2018 at 01:43:39PM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On Thu, Oct 11, 2018 at 7:49 PM Daniel P. Berrangé > > >

Re: [libvirt] [PATCH v2] vhost-user: define conventions for vhost-user backends

2018-10-16 Thread Marc-André Lureau
Hi On Fri, Oct 12, 2018 at 1:56 PM Daniel P. Berrangé wrote: > > On Fri, Oct 12, 2018 at 01:43:39PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Thu, Oct 11, 2018 at 7:49 PM Daniel P. Berrangé > > wrote: > > > > > > Adding Markus since we're talking about new CLI argument and capability >

Re: [libvirt] [PATCH v2 01/11] security: Always spawn process for transactions

2018-10-16 Thread Michal Privoznik
On 10/12/2018 04:20 PM, John Ferlan wrote: > > > On 10/12/18 4:45 AM, Michal Privoznik wrote: >> On 10/11/2018 11:06 PM, John Ferlan wrote: >>> >>> >>> On 10/11/18 8:03 AM, Michal Privoznik wrote: In the next commit the virSecurityManagerMetadataLock() is going to be turned thread

Re: [libvirt] [PATCH RFC v2] qemu: fix deadlock when waiting in non async jobs

2018-10-16 Thread Nikolay Shirokovskiy
On 16.10.2018 03:00, John Ferlan wrote: > > > On 10/8/18 4:10 AM, Nikolay Shirokovskiy wrote: >> Block job abort operation can not handle properly qemu crashes when waiting >> for >> abort/pivot completion. Deadlock scenario is next: >> >> - qemuDomainBlockJobAbort waits for pivot/abort