[libvirt] [PATCH] docs: Only one secret is in vol instead of zero or more

2018-12-11 Thread Han Han
Referring to commit fab2e49d, it should be one and only secret for encryption. Signed-off-by: Han Han --- docs/schemas/storagecommon.rng | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/schemas/storagecommon.rng b/docs/schemas/storagecommon.rng index

Re: [libvirt] [PATCH for-4.0 v4 0/2] virtio: Provide version-specific variants of virtio PCI devices

2018-12-11 Thread Michael S. Tsirkin
Nothing, I'm packing up the 1st pull request. On Tue, Dec 11, 2018 at 11:18:51PM -0200, Eduardo Habkost wrote: > Friendly ping. 3.1.0 is tagged now, so there's anything else > blocking this series? > > > On Wed, Dec 05, 2018 at 05:57:02PM -0200, Eduardo Habkost wrote: > > Existing modern-only

Re: [libvirt] [PATCH for-4.0 v4 0/2] virtio: Provide version-specific variants of virtio PCI devices

2018-12-11 Thread Eduardo Habkost
Friendly ping. 3.1.0 is tagged now, so there's anything else blocking this series? On Wed, Dec 05, 2018 at 05:57:02PM -0200, Eduardo Habkost wrote: > Existing modern-only device types are not being touched by v3, as > they don't need separate variants. However, I plan to implement > separate

Re: [libvirt] [PATCH 4/4] conf: domain: gfx: Iterate over graphics devices when doing validation

2018-12-11 Thread John Ferlan
On 12/7/18 9:47 AM, Erik Skultety wrote: > The validation code for graphics has been in place for a while, but > because it is only executed from the device iterator, that validation > code was never truly run. The unfortunate side effect of this whole mess dang confusing postparse and

Re: [libvirt] [PATCH 3/4] tests: Introduce negative versions of DO_TEST_CAPS_LATEST

2018-12-11 Thread John Ferlan
On 12/7/18 9:47 AM, Erik Skultety wrote: > As commit d8266ebe161 demonstrated, it's so easy to forget to add a > single capability which in turn can easily fool the test suite so that > tests expecting a failure can fail with a different error than we > expected, but still making those pass.

Re: [libvirt] [PATCH 2/4] conf: domain: Introduce virDomainDeviceInfoIterate flags

2018-12-11 Thread John Ferlan
On 12/7/18 9:47 AM, Erik Skultety wrote: > One of the usages of the device iterator is to run config validation. > That's a problem for graphics devices, because they don't have any @info > data (graphics shouldn't have been considered as devices in the first > place), and simply passing NULL

Re: [libvirt] [PATCH 1/4] qemu: domain: gfx: Fix shadowing the ptr argument to graphics validation

2018-12-11 Thread John Ferlan
On 12/7/18 9:47 AM, Erik Skultety wrote: > Since the code was never run, this stupid mistake could have only been > spotted by an accident. > > Signed-off-by: Erik Skultety > --- > src/qemu/qemu_domain.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Gah - that wasn't

Re: [libvirt] [PATCH v3 0/2] lxc: Fix a bug related to IPv{4, 6} gateway persistent setting.

2018-12-11 Thread John Ferlan
On 11/30/18 7:43 AM, Julio Faracco wrote: > This serie fixes a bug related to IPv{4,6} gateway settings when it is > defined and used with multiple network definitions. Basically, this data > is being carried on to the next network settings because the pointer is > not being cleaned

Re: [libvirt] [PATCH] qemu: Don't use -mem-prealloc among with .prealloc=yes

2018-12-11 Thread John Ferlan
On 11/29/18 9:58 AM, Michal Privoznik wrote: > On 11/5/18 3:49 PM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1624223 >> >> There are two ways to request memory preallocation on cmd line: >> -mem-prealloc and .prealloc attribute to memory-backend-file. >> However, as

Re: [libvirt] [PATCH v2 3/4] qemu: support metadata-cache-size for blockdev

2018-12-11 Thread John Ferlan
On 12/11/18 6:24 AM, Nikolay Shirokovskiy wrote: > > > On 10.12.2018 20:00, John Ferlan wrote: >> >> >> On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote: >>> Just set l2-cache-size to INT64_MAX for all format nodes of >>> qcow2 type in block node graph. >>> >>> -drive configuration is not

Re: [libvirt] [PATCH v2 2/4] qemu: caps: add QEMU_CAPS_QCOW2_L2_CACHE_SIZE

2018-12-11 Thread John Ferlan
On 12/11/18 6:04 AM, Nikolay Shirokovskiy wrote: > > > On 10.12.2018 19:58, John Ferlan wrote: >> >> >> On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote: >>> For qemu capable of setting l2-cache-size for qcow2 images >>> to INT64_MAX and semantics of upper limit on l2 cache >>> size. We can

Re: [libvirt] [PATCH v2 1/4] xml: add disk driver metadata_cache_size option

2018-12-11 Thread John Ferlan
On 12/11/18 5:22 AM, Nikolay Shirokovskiy wrote: > > > On 10.12.2018 19:56, John Ferlan wrote: >> >> On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote: >>> Signed-off-by: Nikolay Shirokovskiy >>> --- >>> docs/formatdomain.html.in | 8 >>>

[libvirt] [PATCH] network: set mtu as a DHCP option when specified

2018-12-11 Thread Casey Callendrello
This adds an additional directive to the dnsmasq configuration file that notifies clients via dhcp about the link's MTU. Guests can then choose adjust their link accordingly. Signed-off-by: Casey Callendrello --- src/network/bridge_driver.c | 7 ++

[libvirt] [PATCH] remote: check & report OOM in make_nonnull_XXX methods

2018-12-11 Thread Daniel P . Berrangé
The make_nonnull_XXX methods can all fail due to OOM but this was being silently ignored and thus also not checked by callers. Make the methods propagate errors and use ATTRIBUTE_RETURN_CHECK to force callers to deal with it. Signed-off-by: Daniel P. Berrangé ---

Re: [libvirt] [PATCH] tools: relax x509 Subject regexes to allow numbers and more

2018-12-11 Thread Daniel P . Berrangé
On Tue, Dec 11, 2018 at 10:04:34AM +0100, Kashyap Chamarthy wrote: > On Mon, Dec 10, 2018 at 04:53:27PM +, Daniel P. Berrangé wrote: > > The virt-pki-validate tool is extracting components in the x509 > > certificate Subject field. Unfortunately the regex it is is using is far > > too strict,

[libvirt] [PATCH 0/2] AMD SEV: Relabel session data under /var/lib/libvirt

2018-12-11 Thread Erik Skultety
If a user tries to pass the optional "dhCert" or "session" data to the SEV firmware, these are in form of a base64-encoded strings which libvirt then takes and creates files with those strings as content under /var/lib/libvirt/qemu/. Libvirt then puts paths to these files on to QEMU cmdline. QEMU

[libvirt] [PATCH 2/2] qemu: process: SEV: Relabel guest owner's SEV files created before start

2018-12-11 Thread Erik Skultety
Before launching a SEV guest we take the base64-encoded guest owner's data specified in launchSecurity and create files with the same content under /var/lib/libvirt/qemu/. The reason for this is that we need to pass these files on to QEMU which then uses them to communicate with the SEV firmware,

[libvirt] [PATCH 1/2] qemu: process: SEV: Assume libDir to be the directory to create files in

2018-12-11 Thread Erik Skultety
Since SEV operates on a per domain basis, it's very likely that all SEV launch-related data will be created under /var/lib/libvirt/qemu/. Therefore, when calling into qemuProcessSEVCreateFile we can assume @libDir as the directory prefix rather than passing it explicitly. Signed-off-by: Erik

Re: [libvirt] [PATCH 2/2] qemu: don't log error for missing optional sources on start

2018-12-11 Thread Daniel P . Berrangé
On Tue, Dec 11, 2018 at 09:33:50AM -0500, John Ferlan wrote: > > > On 12/11/18 2:39 AM, Nikolay Shirokovskiy wrote: > > > > > > On 11.12.2018 01:05, John Ferlan wrote: > >> $SUBJ > >> > >> "storage sources" > >> > >> On 11/12/18 7:58 AM, Nikolay Shirokovskiy wrote: > >>> Because missing

Re: [libvirt] [PATCH 2/2] qemu: don't log error for missing optional sources on start

2018-12-11 Thread John Ferlan
On 12/11/18 2:39 AM, Nikolay Shirokovskiy wrote: > > > On 11.12.2018 01:05, John Ferlan wrote: >> $SUBJ >> >> "storage sources" >> >> On 11/12/18 7:58 AM, Nikolay Shirokovskiy wrote: >>> Because missing optional source is not error. The patch >>> address only local files. Fixing other cases

Re: [libvirt] [PATCH 1/2] qemu: don't log error for missing optional sources on stats

2018-12-11 Thread John Ferlan
On 12/11/18 2:34 AM, Nikolay Shirokovskiy wrote: > > > On 11.12.2018 01:05, John Ferlan wrote: >> >> $SUBJ: >> >> 'storage sources' >> >> On 11/12/18 7:58 AM, Nikolay Shirokovskiy wrote: >>> Every time we call all domain stats for inactive domain with >>> unavailable source we get error

Re: [libvirt] Adding MTU DHCP option when specified

2018-12-11 Thread Casey Callendrello
On Mon, Dec 10, 2018 at 2:31 PM Daniel P. Berrangé wrote: > On Fri, Dec 07, 2018 at 04:29:18PM +0100, Casey Callendrello wrote: > > dhcp-option-force=option:mtu,9000 > > IIUC, this DHCP option is intended to tell the guest OS to configure its > NIC with the different MTU size, completing the

[libvirt] [PATCH v4 RESEND] openvswitch: Add new port VLAN mode "dot1q-tunnel"(802.1ad double-tagged)

2018-12-11 Thread luzhipeng
From: ZhiPeng Lu This patch adds functionality to allow libvirt to configure the 'dot1q-tunnel' modes(802.1ad double-tagged) on openvswitch networks. For example: Signed-off-by: ZhiPeng Lu --- v1->v2:

Re: [libvirt] [PATCH v2 3/4] qemu: support metadata-cache-size for blockdev

2018-12-11 Thread Nikolay Shirokovskiy
On 10.12.2018 20:00, John Ferlan wrote: > > > On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote: >> Just set l2-cache-size to INT64_MAX for all format nodes of >> qcow2 type in block node graph. >> >> -drive configuration is not supported because we can not >> set l2 cache size down the backing

Re: [libvirt] [PATCH v2 2/4] qemu: caps: add QEMU_CAPS_QCOW2_L2_CACHE_SIZE

2018-12-11 Thread Nikolay Shirokovskiy
On 10.12.2018 19:58, John Ferlan wrote: > > > On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote: >> For qemu capable of setting l2-cache-size for qcow2 images >> to INT64_MAX and semantics of upper limit on l2 cache >> size. We can only check this by qemu version (3.1.0) now. >> >>

Re: [libvirt] [PATCH v2 1/4] xml: add disk driver metadata_cache_size option

2018-12-11 Thread Nikolay Shirokovskiy
On 10.12.2018 19:56, John Ferlan wrote: > > On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote: >> Signed-off-by: Nikolay Shirokovskiy >> --- >> docs/formatdomain.html.in | 8 >> docs/schemas/domaincommon.rng | 11 + >>

Re: [libvirt] [PATCH] tools: relax x509 Subject regexes to allow numbers and more

2018-12-11 Thread Kashyap Chamarthy
On Mon, Dec 10, 2018 at 04:53:27PM +, Daniel P. Berrangé wrote: > The virt-pki-validate tool is extracting components in the x509 > certificate Subject field. Unfortunately the regex it is is using is far > too strict, and so truncating valid data. It needs to consider ',' as a > field

Re: [libvirt] [PATCH] tools: relax x509 Subject regexes to allow numbers and more

2018-12-11 Thread Kashyap Chamarthy
On Mon, Dec 10, 2018 at 04:53:27PM +, Daniel P. Berrangé wrote: > The virt-pki-validate tool is extracting components in the x509 > certificate Subject field. Unfortunately the regex it is is using is far > too strict, and so truncating valid data. It needs to consider ',' as a > field

Re: [libvirt] [PATCH v2] qemu: disable external snapshot of readonly disk

2018-12-11 Thread Nikolay Shirokovskiy
On 10.12.2018 20:23, John Ferlan wrote: > > > On 11/9/18 3:00 AM, Nikolay Shirokovskiy wrote: >> Disable external snapshot of readonly disk for inactive domains >> as this operation is not very useful. As to active domains >> such snapshot was not possible before already but error message was