[libvirt] [PATCH] docs: Improve description of

2018-12-14 Thread Jim Fehlig
/domain/memtune/hard_limit provides a way to cap the memory a VM process can use, including the amount of memory the process can lock. When memory locking of a VM is requested, can be used to prevent the potential host DoS issue mentioned in /domain/memoryBacking/locked description. This patch

[libvirt] [PATCH v2] Drop UML driver

2018-12-14 Thread Michal Privoznik
The driver is unmaintained, untested and severely broken for quite some time now. Since nobody even reported any issue with it let us drop it. Signed-off-by: Michal Privoznik --- diff to v2: - don't drop UML from RNG schema nor config parser as suggested by Dan configure.ac

Re: [libvirt] [PATCH] qemu: use line breaks in command line args written to log

2018-12-14 Thread Michal Prívozník
On 12/14/18 4:55 PM, Daniel P. Berrangé wrote: > On Fri, Dec 14, 2018 at 04:42:12PM +0100, Michal Privoznik wrote: >> On 12/14/18 2:07 PM, Daniel P. Berrangé wrote: >>> The QEMU command line arguments are very long and currently all written >>> on a single line to /var/log/libvirt/qemu/$GUEST.log.

Re: [libvirt] [PATCH] Drop UML driver

2018-12-14 Thread Daniel P . Berrangé
On Fri, Dec 14, 2018 at 03:59:29PM +0100, Michal Privoznik wrote: > On 12/14/18 3:53 PM, Daniel P. Berrangé wrote: > > On Fri, Dec 14, 2018 at 03:46:16PM +0100, Michal Privoznik wrote: > >> On 12/14/18 3:35 PM, Daniel P. Berrangé wrote: > >>> On Fri, Dec 14, 2018 at 03:30:17PM +0100, Michal

Re: [libvirt] [PATCH] Drop UML driver

2018-12-14 Thread Michal Privoznik
On 12/14/18 3:53 PM, Daniel P. Berrangé wrote: > On Fri, Dec 14, 2018 at 03:46:16PM +0100, Michal Privoznik wrote: >> On 12/14/18 3:35 PM, Daniel P. Berrangé wrote: >>> On Fri, Dec 14, 2018 at 03:30:17PM +0100, Michal Privoznik wrote: The driver is unmaintained, untested and severely broken

Re: [libvirt] [PATCH] Drop UML driver

2018-12-14 Thread Daniel P . Berrangé
On Fri, Dec 14, 2018 at 03:46:16PM +0100, Michal Privoznik wrote: > On 12/14/18 3:35 PM, Daniel P. Berrangé wrote: > > On Fri, Dec 14, 2018 at 03:30:17PM +0100, Michal Privoznik wrote: > >> The driver is unmaintained, untested and severely broken for > >> quite some time now. Since nobody even

Re: [libvirt] [PATCH] Drop UML driver

2018-12-14 Thread Michal Privoznik
On 12/14/18 3:35 PM, Daniel P. Berrangé wrote: > On Fri, Dec 14, 2018 at 03:30:17PM +0100, Michal Privoznik wrote: >> The driver is unmaintained, untested and severely broken for >> quite some time now. Since nobody even reported any issue with it >> let us drop it. >> >> Signed-off-by: Michal

Re: [libvirt] [PATCH] Drop UML driver

2018-12-14 Thread Daniel P . Berrangé
On Fri, Dec 14, 2018 at 03:30:17PM +0100, Michal Privoznik wrote: > The driver is unmaintained, untested and severely broken for > quite some time now. Since nobody even reported any issue with it > let us drop it. > > Signed-off-by: Michal Privoznik > --- > docs/schemas/capability.rng

[libvirt] [PATCH] Drop UML driver

2018-12-14 Thread Michal Privoznik
The driver is unmaintained, untested and severely broken for quite some time now. Since nobody even reported any issue with it let us drop it. Signed-off-by: Michal Privoznik --- configure.ac |4 - docs/aclpolkit.html.in |4 - docs/drivers.html.in

[libvirt] [PATCH] cfg.mk: silence the group-qemu-caps command

2018-12-14 Thread Daniel P . Berrangé
A missing $(AM_V_GEN) meant the raw command was printed by mistake. Signed-off-by: Daniel P. Berrangé --- Pushed as a trivial change cfg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cfg.mk b/cfg.mk index c739edf604..4da6dc8f6e 100644 --- a/cfg.mk +++ b/cfg.mk @@

[libvirt] [PATCH] Fix header ifdef check for config-post.h in VPATH build

2018-12-14 Thread Daniel P . Berrangé
We must do a substring match, not an exact match since there can be an arbitrary virtual path prepended. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix build-aux/header-ifdef.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/header-ifdef.pl

[libvirt] [PATCH] logging: ensure pending I/O is drained before reading position

2018-12-14 Thread Daniel P . Berrangé
The virtualization driver has two connections to the virtlogd daemon, one pipe fd for writing to the log file, and one socket fd for making RPC calls. The typical sequence is to write some data to the pipe fd and then make an RPC call to determine the current log file offset. Unfortunately these

Re: [libvirt] [PATCH] remote: Fix the build by explicitly casting the obj pointer for xdr_free

2018-12-14 Thread Daniel P . Berrangé
On Fri, Dec 14, 2018 at 12:08:55PM +0100, Erik Skultety wrote: > On Fri, Dec 14, 2018 at 10:11:55AM +, Daniel P. Berrangé wrote: > > On Fri, Dec 14, 2018 at 10:18:39AM +0100, Erik Skultety wrote: > > > For some reason, xdr_free uses char * instead of void * for its 2nd > > > argument which is

Re: [libvirt] [PATCH] remote: Fix the build by explicitly casting the obj pointer for xdr_free

2018-12-14 Thread Erik Skultety
On Fri, Dec 14, 2018 at 10:11:55AM +, Daniel P. Berrangé wrote: > On Fri, Dec 14, 2018 at 10:18:39AM +0100, Erik Skultety wrote: > > For some reason, xdr_free uses char * instead of void * for its 2nd > > argument which is passed to a custom free routine. Commit > > dc54b3ec missed this detail

Re: [libvirt] [PATCH] remote: Fix the build by explicitly casting the obj pointer for xdr_free

2018-12-14 Thread Daniel P . Berrangé
On Fri, Dec 14, 2018 at 10:18:39AM +0100, Erik Skultety wrote: > For some reason, xdr_free uses char * instead of void * for its 2nd > argument which is passed to a custom free routine. Commit > dc54b3ec missed this detail which made the build fail on a number of > platforms. Fix it by explicitly

Re: [libvirt] [PATCH] qemu: Add default address type for vhost-user interface on aarch64

2018-12-14 Thread Michal Privoznik
On 12/14/18 10:19 AM, Wang Yechao wrote: > on aarch64, hotadd vhost-user interface with the follow xml file: > > > > > > > > will get error like that: > error: internal error: Nicdev support unavailable > > Because there is no device address type specified in xml file, so >

Re: [libvirt] [PATCH v2 9/9] util: error: Put error code messages into an array

2018-12-14 Thread Erik Skultety
On Fri, Dec 14, 2018 at 10:35:50AM +0100, Peter Krempa wrote: > On Thu, Dec 13, 2018 at 17:02:55 +0100, Erik Skultety wrote: > > On Thu, Dec 13, 2018 at 03:48:56PM +0100, Peter Krempa wrote: > > > Simplify adding of new errors by just adding them to the array of > > > messages rather than having

Re: [libvirt] [PATCH v2 9/9] util: error: Put error code messages into an array

2018-12-14 Thread Peter Krempa
On Thu, Dec 13, 2018 at 17:02:55 +0100, Erik Skultety wrote: > On Thu, Dec 13, 2018 at 03:48:56PM +0100, Peter Krempa wrote: > > Simplify adding of new errors by just adding them to the array of > > messages rather than having to add conversion code. > > > > Additionally most of the messages add

[libvirt] [PATCH] remote: Fix the build by explicitly casting the obj pointer for xdr_free

2018-12-14 Thread Erik Skultety
For some reason, xdr_free uses char * instead of void * for its 2nd argument which is passed to a custom free routine. Commit dc54b3ec missed this detail which made the build fail on a number of platforms. Fix it by explicitly casting the object pointer to char * just like we do in other places

[libvirt] [PATCH] qemu: Add default address type for vhost-user interface on aarch64

2018-12-14 Thread Wang Yechao
on aarch64, hotadd vhost-user interface with the follow xml file: will get error like that: error: internal error: Nicdev support unavailable Because there is no device address type specified in xml file, so qemuDomainSupportsNicdev returns 'false' when invoked in

Re: [libvirt] [PATCH v2 4/9] util: error: Reword some unused error messages

2018-12-14 Thread Erik Skultety
On Thu, Dec 13, 2018 at 03:48:51PM +0100, Peter Krempa wrote: > Simplify wording of the error string for VIR_ERR_OPEN_FAILED and > VIR_ERR_CALL_FAILED. The error codes itself are currently unused so it > will not impact any client. > > This will simplify upcomming patch which refactors how we

Re: [libvirt] [RFC v3 4/4] nvdimm: update news.xml

2018-12-14 Thread Luyao Zhong
On 2018/12/14 上午10:17, John Ferlan wrote: On 12/12/18 7:53 AM, Luyao Zhong wrote: add more configure options for NVDIMM Signed-off-by: Luyao Zhong --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) It will be OK to just have one of these assuming each of the options

Re: [libvirt] [RFC v3 3/4] nvdimm: update qemu command-line generating for NVDIMM memory

2018-12-14 Thread Luyao Zhong
On 2018/12/14 上午9:10, John Ferlan wrote: On 12/12/18 7:53 AM, Luyao Zhong wrote: According to the result parsing from xml, add corresponding properties into QEMU command line, including 'align', 'pmem' and 'unarmed'. Signed-off-by: Luyao Zhong --- src/qemu/qemu_command.c

Re: [libvirt] [RFC v3 2/4] nvdimm: add nvdimm-related qemucapabilities check

2018-12-14 Thread Luyao Zhong
On 2018/12/14 上午9:09, John Ferlan wrote: On 12/12/18 7:52 AM, Luyao Zhong wrote: -object memory-backend-file[,align=][,pmem=] Signed-off-by: Luyao Zhong --- src/qemu/qemu_capabilities.c | 8 +++- src/qemu/qemu_capabilities.h | 4

Re: [libvirt] [RFC v3 0/4] update NVDIMM support

2018-12-14 Thread Luyao Zhong
On 2018/12/14 上午9:06, John Ferlan wrote: No need to CC developers for libvirt, we're all subscribed to the list anyways and generally are faithful in reading. Reviews are a different story. On 12/12/18 7:52 AM, Luyao Zhong wrote: Hi libvirt experts, This is the RFC v3 for updating NVDIMM

Re: [libvirt] [PATCH 0/2] Sanitize header file conditionals and layout

2018-12-14 Thread Michal Privoznik
On 12/13/18 5:26 PM, Daniel P. Berrangé wrote: > This series was inspired by the cleanup proposed by Michal in his recent > security driver work. I pointed out the mess he was cleaning up was in > fact across the entire codebase: > >