Re: [libvirt] [PATCH v2] qemu: Assign device address before qemuDomainSupportsNicdev

2019-01-16 Thread wang.yechao255
> $SUBJ: > > s/address before qemuDomainSupportsNicdev/addresses earlier in > qemuDomainAttachNetDevice/ > > > On 12/17/18 6:30 AM, Wang Yechao wrote: > > qemuDomainSupportsNicdev will check the device address type on > > aarch64. If it is invoked before device address assigned, hotadd > >

Re: [libvirt] [PATCH] qemu: Update a domain's persistent definition file if it's defined

2019-01-16 Thread John Ferlan
On 12/20/18 4:06 AM, Wang Yechao wrote: > From: Li XueLei > > During making disk snapshot in an active domain, sometimes we > should update the domain's persistent definition.We must check if > the domain is defined, before we update the persistent definition > file. > First,we create a

Re: [libvirt] [PATCH 4/5] network: regain guest network connectivity after firewalld switch to nftables

2019-01-16 Thread Laine Stump
On 1/15/19 12:54 PM, Daniel P. Berrangé wrote: On Tue, Jan 15, 2019 at 12:43:05PM -0500, Laine Stump wrote: On 1/15/19 11:39 AM, Daniel P. Berrangé wrote: On Wed, Jan 09, 2019 at 09:57:36PM -0500, Laine Stump wrote: From: Laine Stump In the past (when both libvirt and firewalld used

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Eduardo Habkost
On Wed, Jan 16, 2019 at 05:24:02PM +0100, Andrea Bolognani wrote: > On Wed, 2019-01-16 at 15:40 +, Daniel P. Berrangé wrote: > > On Wed, Jan 16, 2019 at 12:45:43PM -0200, Eduardo Habkost wrote: > > > But I don't want to create unnecessary obstacles for libvirt, so > > > if there's a real

Re: [libvirt] [PATCH v2] qemu: Assign device address before qemuDomainSupportsNicdev

2019-01-16 Thread John Ferlan
$SUBJ: s/address before qemuDomainSupportsNicdev/addresses earlier in qemuDomainAttachNetDevice/ On 12/17/18 6:30 AM, Wang Yechao wrote: > qemuDomainSupportsNicdev will check the device address type on > aarch64. If it is invoked before device address assigned, hotadd > vhostuser interface

Re: [libvirt] [PATCH v3 01/11] conf: Add some defined NFS Storage Pool mount options

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 12:47:32PM -0500, John Ferlan wrote: > On 1/16/19 7:00 AM, Daniel P. Berrangé wrote: > > Hmm, this has gone back to the "Mount options" concept from v1 > > which I don't think is appropriate. In v2 feedback I had suggested > > that we should have some more explicit XML

Re: [libvirt] [PATCH v3 01/11] conf: Add some defined NFS Storage Pool mount options

2019-01-16 Thread John Ferlan
On 1/16/19 7:00 AM, Daniel P. Berrangé wrote: > On Tue, Jan 15, 2019 at 08:09:12PM -0500, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1584663 >> >> Add the ability to parse/manage some defined NFS Storage Pool mount >> options. Keep the set of defined options limited to

Re: [libvirt] [PATCH v2] util: audit: Fix logging an error when kernel lacks audit support

2019-01-16 Thread Erik Skultety
On Wed, Jan 16, 2019 at 03:45:06PM +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 03:58:24PM +0100, Erik Skultety wrote: > > Based on an upstream discussion, reporting the errno is useful for the > > user to know why audit isn't supported. Even though having an error in > > the logs

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Andrea Bolognani
On Wed, 2019-01-16 at 15:40 +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 12:45:43PM -0200, Eduardo Habkost wrote: > > But I don't want to create unnecessary obstacles for libvirt, so > > if there's a real benefit in promising compatibility between both > > device types, we can still

Re: [libvirt] [PATCH 0/6] RFC: qemu: virtio-{non-}transitional support

2019-01-16 Thread Peter Krempa
On Wed, Jan 16, 2019 at 15:36:29 +, Daniel Berrange wrote: > On Wed, Jan 16, 2019 at 03:46:12PM +0100, Andrea Bolognani wrote: > > On Wed, 2019-01-16 at 14:19 +, Daniel P. Berrangé wrote: > > > On Wed, Jan 16, 2019 at 03:07:07PM +0100, Andrea Bolognani wrote: > > > > On Wed, 2019-01-16 at

Re: [libvirt] [PATCH v2] util: audit: Fix logging an error when kernel lacks audit support

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 03:58:24PM +0100, Erik Skultety wrote: > Based on an upstream discussion, reporting the errno is useful for the > user to know why audit isn't supported. Even though having an error in > the logs might look concerning when 'audit_log=1', it also denotes that > audit is only

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 12:45:43PM -0200, Eduardo Habkost wrote: > On Wed, Jan 16, 2019 at 02:37:22PM +, Daniel P. Berrangé wrote: > > On Wed, Jan 16, 2019 at 03:31:49PM +0100, Andrea Bolognani wrote: > > > On Wed, 2019-01-16 at 12:44 +, Daniel P. Berrangé wrote: > > > > On Wed, Jan 16,

Re: [libvirt] [PATCH 0/6] RFC: qemu: virtio-{non-}transitional support

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 03:46:12PM +0100, Andrea Bolognani wrote: > On Wed, 2019-01-16 at 14:19 +, Daniel P. Berrangé wrote: > > On Wed, Jan 16, 2019 at 03:07:07PM +0100, Andrea Bolognani wrote: > > > On Wed, 2019-01-16 at 11:13 +, Daniel P. Berrangé wrote: > > > > The enum should cover

[libvirt] [PATCH v2] util: audit: Fix logging an error when kernel lacks audit support

2019-01-16 Thread Erik Skultety
Based on an upstream discussion, reporting the errno is useful for the user to know why audit isn't supported. Even though having an error in the logs might look concerning when 'audit_log=1', it also denotes that audit is only going to be used if it's available, continuing normally if it's

Re: [libvirt] [PATCH 0/6] RFC: qemu: virtio-{non-}transitional support

2019-01-16 Thread Andrea Bolognani
On Wed, 2019-01-16 at 14:19 +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 03:07:07PM +0100, Andrea Bolognani wrote: > > On Wed, 2019-01-16 at 11:13 +, Daniel P. Berrangé wrote: > > > The enum should cover all existing reasonably expected configs. Sure I > > > imagine we might miss

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Eduardo Habkost
On Wed, Jan 16, 2019 at 02:37:22PM +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 03:31:49PM +0100, Andrea Bolognani wrote: > > On Wed, 2019-01-16 at 12:44 +, Daniel P. Berrangé wrote: > > > On Wed, Jan 16, 2019 at 01:29:13PM +0100, Andrea Bolognani wrote: > > > > On Wed,

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 03:31:49PM +0100, Andrea Bolognani wrote: > On Wed, 2019-01-16 at 12:44 +, Daniel P. Berrangé wrote: > > On Wed, Jan 16, 2019 at 01:29:13PM +0100, Andrea Bolognani wrote: > > > On Wed, 2019-01-16 at 11:39 +, Daniel P. Berrangé wrote: > > > > In the > > > > future

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Andrea Bolognani
On Wed, 2019-01-16 at 12:44 +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 01:29:13PM +0100, Andrea Bolognani wrote: > > On Wed, 2019-01-16 at 11:39 +, Daniel P. Berrangé wrote: > > > In the > > > future they may add properties to, or change the defaults on, the > > > -transitional

Re: [libvirt] [PATCH 0/6] RFC: qemu: virtio-{non-}transitional support

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 03:07:07PM +0100, Andrea Bolognani wrote: > On Wed, 2019-01-16 at 11:13 +, Daniel P. Berrangé wrote: > > On Wed, Jan 16, 2019 at 12:01:00PM +0100, Andrea Bolognani wrote: > > > Based on what I can recall from my own, more recent, attempt at > > > fixing the mess, the

Re: [libvirt] [PATCH 0/6] RFC: qemu: virtio-{non-}transitional support

2019-01-16 Thread Andrea Bolognani
On Wed, 2019-01-16 at 11:13 +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 12:01:00PM +0100, Andrea Bolognani wrote: > > Based on what I can recall from my own, more recent, attempt at > > fixing the mess, the main blocker was that in order to keep > > accepting all existing

[libvirt] [PATCH] docs: use JavaScript based PolicyKit .rules files

2019-01-16 Thread Mark McLoughlin
PolicyKit authentication rules have switched to a JavaScript based format quite some time ago. See: http://davidz25.blogspot.com/2012/06/authorization-rules-in-polkit.html While backwards compat for the old .pkla format is still available, it makes sense to point people first at the new format.

Re: [libvirt] [PATCH 4/5] network: regain guest network connectivity after firewalld switch to nftables

2019-01-16 Thread Eric Garver
On Wed, Jan 09, 2019 at 09:57:36PM -0500, Laine Stump wrote: > From: Laine Stump [..] > diff --git a/src/network/libvirt.zone b/src/network/libvirt.zone > new file mode 100644 > index 00..1750ba2f06 > --- /dev/null > +++ b/src/network/libvirt.zone > @@ -0,0 +1,14 @@ > + > + > + libvirt >

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 01:29:13PM +0100, Andrea Bolognani wrote: > On Wed, 2019-01-16 at 11:39 +, Daniel P. Berrangé wrote: > > On Wed, Jan 16, 2019 at 12:31:04PM +0100, Andrea Bolognani wrote: > > > On Tue, 2019-01-15 at 16:56 +, Daniel P. Berrangé wrote: > > > > A transitional device is

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Andrea Bolognani
On Wed, 2019-01-16 at 11:39 +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 12:31:04PM +0100, Andrea Bolognani wrote: > > On Tue, 2019-01-15 at 16:56 +, Daniel P. Berrangé wrote: > > > A transitional device is 100% identical to the existing device > > > types, so we can simply not

Re: [libvirt] [PATCH 2/2] qemu: command: Don't format image properties for empty -drive

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 01:12:01PM +0100, Peter Krempa wrote: > On Wed, Jan 16, 2019 at 09:52:42 +, Daniel Berrange wrote: > > On Wed, Jan 16, 2019 at 10:42:10AM +0100, Peter Krempa wrote: > > > If a -drive has no image, using image properties makes qemu whine that > > > they should not be

Re: [libvirt] [PATCH 2/2] qemu: command: Don't format image properties for empty -drive

2019-01-16 Thread Peter Krempa
On Wed, Jan 16, 2019 at 09:52:42 +, Daniel Berrange wrote: > On Wed, Jan 16, 2019 at 10:42:10AM +0100, Peter Krempa wrote: > > If a -drive has no image, using image properties makes qemu whine that > > they should not be used. > > > > This patch stops formating cache/readonly/... for empty

Re: [libvirt] [PATCH v3 01/11] conf: Add some defined NFS Storage Pool mount options

2019-01-16 Thread Daniel P . Berrangé
On Tue, Jan 15, 2019 at 08:09:12PM -0500, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1584663 > > Add the ability to parse/manage some defined NFS Storage Pool mount > options. Keep the set of defined options limited to noexec, nosuid, > nodev, and ro. Subsequent patches will

Re: [libvirt] [PATCH 0/6] RFC: qemu: virtio-{non-}transitional support

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 10:41:59AM +0100, Andrea Bolognani wrote: > On Tue, 2019-01-15 at 17:02 +, Daniel P. Berrangé wrote: > > On Tue, Jan 15, 2019 at 02:30:14PM +0100, Andrea Bolognani wrote: > > > Basically VirtIO 0.9 requires IO space to be available, and 1.0 did > > > away with that

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 12:31:04PM +0100, Andrea Bolognani wrote: > On Tue, 2019-01-15 at 16:56 +, Daniel P. Berrangé wrote: > > On Sun, Jan 13, 2019 at 06:12:06PM -0500, Cole Robinson wrote: > > > Add new model values for virtio transitional devices. When > > > combined with bus='virtio': >

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Andrea Bolognani
On Tue, 2019-01-15 at 16:56 +, Daniel P. Berrangé wrote: > On Sun, Jan 13, 2019 at 06:12:06PM -0500, Cole Robinson wrote: > > Add new model values for virtio transitional devices. When > > combined with bus='virtio': > > > > * "virtio-transitional" maps to qemu "virtio-blk-pci-transitional"

Re: [libvirt] [PATCH 0/6] RFC: qemu: virtio-{non-}transitional support

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 12:01:00PM +0100, Andrea Bolognani wrote: > On Tue, 2019-01-15 at 17:06 +, Daniel P. Berrangé wrote: > > virDomainNetDef is a mess because it *still* doesn't use a enum > > for the device model :-( We really must fix that rather than > > blindly allowing arbitrary

Re: [libvirt] [PATCH 0/6] RFC: qemu: virtio-{non-}transitional support

2019-01-16 Thread Andrea Bolognani
On Tue, 2019-01-15 at 17:06 +, Daniel P. Berrangé wrote: > virDomainNetDef is a mess because it *still* doesn't use a enum > for the device model :-( We really must fix that rather than > blindly allowing arbitrary passthrough of hypervisor specific > names. > > I recall Laine had patches

[libvirt] [python PATCH 1/3] travis: remove python 2.6 and 3.6 from build matrix

2019-01-16 Thread Daniel P . Berrangé
The lxml package that we download with pip no longer supports either of these versions of python. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8405bee..0e9c834 100644 --- a/.travis.yml +++ b/.travis.yml @@

[libvirt] [python PATCH 0/3] travis: misc fixes to build

2019-01-16 Thread Daniel P . Berrangé
Fix the travis build which has been broken for a while Daniel P. Berrangé (3): travis: remove python 2.6 and 3.6 from build matrix travis: switch from trusty to xenial dist travis: add testing of 5.0.0 release .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --

[libvirt] [python PATCH 2/3] travis: switch from trusty to xenial dist

2019-01-16 Thread Daniel P . Berrangé
The trusty gnutls version is too old to support modern libvirt Signed-off-by: Daniel P. Berrangé --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 0e9c834..cf192c5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,5 +1,6 @@ language: python os:

[libvirt] [python PATCH 3/3] travis: add testing of 5.0.0 release

2019-01-16 Thread Daniel P . Berrangé
Update to test against very latest release. Since we dropped two python versions, we can afford to add new libvirt version without dropping a previous one. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index

Re: [libvirt] [PATCH 2/2] qemu: command: Don't format image properties for empty -drive

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 10:42:10AM +0100, Peter Krempa wrote: > If a -drive has no image, using image properties makes qemu whine that > they should not be used. > > This patch stops formating cache/readonly/... for empty drives > for the pre-blockdev syntax. Unfortunately those parameters can't

Re: [libvirt] [PATCH 0/6] RFC: qemu: virtio-{non-}transitional support

2019-01-16 Thread Andrea Bolognani
On Tue, 2019-01-15 at 17:02 +, Daniel P. Berrangé wrote: > On Tue, Jan 15, 2019 at 02:30:14PM +0100, Andrea Bolognani wrote: > > Basically VirtIO 0.9 requires IO space to be available, and 1.0 did > > away with that requirement because PCI Express, unlike conventional > > PCI, allows devices

[libvirt] [PATCH 1/2] tests: qemuxml2argv: Add test case for empty CDROM with cache mode

2019-01-16 Thread Peter Krempa
Upcomming change will influence CDROM with cache mode so add a test case. Signed-off-by: Peter Krempa --- tests/qemuxml2argvdata/disk-cdrom.args | 4 +++- tests/qemuxml2argvdata/disk-cdrom.x86_64-2.12.0.args | 7 +-- tests/qemuxml2argvdata/disk-cdrom.x86_64-latest.args | 7

[libvirt] [PATCH 0/2] qemu: Don't format 'cache' for empty cdroms

2019-01-16 Thread Peter Krempa
See patch 2/2 for explanation. Peter Krempa (2): tests: qemuxml2argv: Add test case for empty CDROM with cache mode qemu: command: Don't format image properties for empty -drive src/qemu/qemu_command.c | 47 ++- tests/qemuxml2argvdata/disk-cdrom.args

[libvirt] [PATCH 2/2] qemu: command: Don't format image properties for empty -drive

2019-01-16 Thread Peter Krempa
If a -drive has no image, using image properties makes qemu whine that they should not be used. This patch stops formating cache/readonly/... for empty drives for the pre-blockdev syntax. Unfortunately those parameters can't be added later when inserting media, but on the other hand qemu will

Re: [libvirt] [PATCH] virt-aa-helper: generate rules for gl enabled graphics devices

2019-01-16 Thread Michal Privoznik
On 1/15/19 5:34 PM, Christian Ehrhardt wrote: > This adds the virt-aa-helper support for gl enabled graphics devices to > generate rules for the needed rendernode paths. > > Example in domain xml: > > > > > results in: > "/dev/dri" r, > "/dev/dri/bar" rw, > > Special cases are: > -

Re: [libvirt] [PATCH] docs: remove duplicate example usegae of nvdimm

2019-01-16 Thread Luyao Zhong
On 2019/1/16 下午4:16, Peter Krempa wrote: On Wed, Jan 16, 2019 at 14:58:21 +0800, Luyao Zhong wrote: original: ... ... merge two examples above into one: ... Signed-off-by: Luyao Zhong What's the benefit of the above change? We have multiple instances

Re: [libvirt] [PATCH] qemu: remove comments for qemuDomainSecret.*Destroy functions

2019-01-16 Thread Peter Krempa
On Wed, Jan 16, 2019 at 08:45:39 +0100, Ján Tomko wrote: > These all contain the same copy and pasted '@disk' error, > and only repeat the list of arguments. > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_domain.c | 15 --- > 1 file changed, 15 deletions(-) ACK signature.asc

Re: [libvirt] [PATCH] docs: remove duplicate example usegae of nvdimm

2019-01-16 Thread Peter Krempa
On Wed, Jan 16, 2019 at 14:58:21 +0800, Luyao Zhong wrote: > original: > > > ... > > > ... > > > > merge two examples above into one: > > > ... > > > > Signed-off-by: Luyao Zhong What's the benefit of the above change? We have multiple instances where we show