Re: [libvirt] [PATCH for v5.3.0 17/17] Revert "qemu: Temporary disable owner remembering"

2019-04-12 Thread Cole Robinson
On 3/28/19 11:04 AM, Michal Privoznik wrote: > This reverts commit fc3990c7e64be1da1631952d3ec384ebef50e125. > > Now that all the reported bugs are fixed let's turn the feature > back on. > > Signed-off-by: Michal Privoznik > --- > docs/news.xml | 21 +

Re: [libvirt] [PATCH for v5.3.0 10/17] security: Remember owner only for top level image

2019-04-12 Thread Cole Robinson
On 3/28/19 11:04 AM, Michal Privoznik wrote: > Here is the problem: If all disks had XATTRs (i.e. domains using > them were started with owner remembering turned on) then > refcounting implemented in XATTRs would work nicely and we could > set the whole backing chain and restore it later. But

Re: [libvirt] [Qemu-devel] [PATCH for-QEMU-4.1] Declare -realtime as deprecated

2019-04-12 Thread Eduardo Habkost
On Thu, Apr 11, 2019 at 07:53:45PM +0200, Thomas Huth wrote: > The old -realtime mlock=on|off parameter does exactly the same as the > new -overcommit mem-lock=on|off parameter. Additionally, "-realtime" > does not activate any additional "realtime" capabilities as the name > might indicate. We

Re: [libvirt] [Qemu-devel] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

2019-04-12 Thread Thomas Huth
On 12/04/2019 18.21, Philippe Mathieu-Daudé wrote: > On 4/12/19 5:26 PM, Thomas Huth wrote: >> These machines depend on the deprecated bluetooth subsystem. In case we >> finally decide to remove the bluetooth subsystem, we likely need to >> remove the n800 and n810 machines, too, so mark them now

[libvirt] [PATCH v2 0/2] network: only reload firewall after firewalld is finished restarting

2019-04-12 Thread Laine Stump
Explanation in Patch 2/2 Changes in v2: * don't (erroneously) check the fields of the message if it's a "Reload" message; only do that if it's a NameOwnerChanged Message. * merge virDBusMessageRead() and virDBusMessageDecode(), since they are now identical (new Patch 1/2) Laine Stump (2):

[libvirt] [PATCH v2 1/2] util: eliminate duplicate function virDBusMessageRead

2019-04-12 Thread Laine Stump
When virDBusMessageRead() and virDBusMessageDecode were first added in commit 834c9c94, they were identical except that virDBusMessageRead() would unref the message after decoding it. This difference was eliminated later in commit dc7f3ffc after it became apparent that unref-ing the message so

[libvirt] [PATCH v2 2/2] network: only reload firewall after firewalld is finished restarting

2019-04-12 Thread Laine Stump
The network driver used to reload the firewall rules whenever a dbus NameOwnerChanged message for org.fedoraproject.FirewallD1 was received. Presumably at some point in the past this was successful at reloading our rules after a firewalld restart. Recently though I noticed that once firewalld was

Re: [libvirt] [PATCH 0/4] qemu_hotplug: Check for duplicate drive addresses

2019-04-12 Thread Daniel Henrique Barboza
On 4/12/19 6:16 AM, Michal Privoznik wrote: On 4/11/19 8:36 PM, Daniel Henrique Barboza wrote: On 4/11/19 11:34 AM, Michal Privoznik wrote: This is an alternative approach to: https://www.redhat.com/archives/libvir-list/2019-March/msg0.html which caused regression to which a

Re: [libvirt] [PATCH 0/4] qemu_hotplug: Check for duplicate drive addresses

2019-04-12 Thread Jim Fehlig
On 4/11/19 8:34 AM, Michal Privoznik wrote: This is an alternative approach to: https://www.redhat.com/archives/libvir-list/2019-March/msg0.html which caused regression to which a proposed fix is here: https://www.redhat.com/archives/libvir-list/2019-April/msg00756.html One of the

Re: [libvirt] [PATCH 0/4] qemu_hotplug: Check for duplicate drive addresses

2019-04-12 Thread Jim Fehlig
On 4/12/19 3:16 AM, Michal Privoznik wrote: On 4/11/19 8:36 PM, Daniel Henrique Barboza wrote: On 4/11/19 11:34 AM, Michal Privoznik wrote: This is an alternative approach to: https://www.redhat.com/archives/libvir-list/2019-March/msg0.html which caused regression to which a proposed

Re: [libvirt] [Qemu-devel] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

2019-04-12 Thread Philippe Mathieu-Daudé
On 4/12/19 5:26 PM, Thomas Huth wrote: > These machines depend on the deprecated bluetooth subsystem. In case we > finally decide to remove the bluetooth subsystem, we likely need to > remove the n800 and n810 machines, too, so mark them now as deprecated. > > Signed-off-by: Thomas Huth > --- >

Re: [libvirt] [PATCH] network: only reload firewall after firewalld is finished restarting

2019-04-12 Thread Laine Stump
On 4/12/19 11:57 AM, Daniel P. Berrangé wrote: On Fri, Apr 12, 2019 at 11:35:13AM -0400, Laine Stump wrote: The network driver used to reload the firewall rules whenever a dbus NameOwnerChanged message for org.fedoraproject.FirewallD1 was received. Presumably at some point in the past this was

Re: [libvirt] [PATCH] network: clear cached error if we successfully create firewall chains

2019-04-12 Thread Laine Stump
On 4/12/19 11:56 AM, Daniel P. Berrangé wrote: Since: commit 9f4e35dc73ec9e940aa61bc7c140c2b800218ef3 Author: Daniel P. Berrangé Date: Mon Mar 18 17:31:21 2019 + network: improve error report when firewall chain creation fails We cache an error when failing to create the

Re: [libvirt] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

2019-04-12 Thread Peter Maydell
On Fri, 12 Apr 2019 at 16:26, Thomas Huth wrote: > > These machines depend on the deprecated bluetooth subsystem. In case we > finally decide to remove the bluetooth subsystem, we likely need to > remove the n800 and n810 machines, too, so mark them now as deprecated. ...we could just remove the

Re: [libvirt] [PATCH] network: only reload firewall after firewalld is finished restarting

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 11:35:13AM -0400, Laine Stump wrote: > The network driver used to reload the firewall rules whenever a dbus > NameOwnerChanged message for org.fedoraproject.FirewallD1 was > received. Presumably at some point in the past this was successful at > reloading our rules after a

[libvirt] [PATCH] network: clear cached error if we successfully create firewall chains

2019-04-12 Thread Daniel P . Berrangé
Since: commit 9f4e35dc73ec9e940aa61bc7c140c2b800218ef3 Author: Daniel P. Berrangé Date: Mon Mar 18 17:31:21 2019 + network: improve error report when firewall chain creation fails We cache an error when failing to create the top level firewall chains. This commit failed to

[libvirt] [PATCH] network: only reload firewall after firewalld is finished restarting

2019-04-12 Thread Laine Stump
The network driver used to reload the firewall rules whenever a dbus NameOwnerChanged message for org.fedoraproject.FirewallD1 was received. Presumably at some point in the past this was successful at reloading our rules after a firewalld restart. Recently though I noticed that once firewalld was

Re: [libvirt] [PATCH v5 2/2] PPC64 support for NVIDIA V100 GPU with NVLink2 passthrough

2019-04-12 Thread Daniel Henrique Barboza
On 4/12/19 11:56 AM, Erik Skultety wrote: On Thu, Apr 04, 2019 at 10:40:39AM -0300, Daniel Henrique Barboza wrote: The NVIDIA V100 GPU has an onboard RAM that is mapped into the host memory and accessible as normal RAM via an NVLink2 bridge. When passed through in a guest, QEMU puts the

[libvirt] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

2019-04-12 Thread Thomas Huth
These machines depend on the deprecated bluetooth subsystem. In case we finally decide to remove the bluetooth subsystem, we likely need to remove the n800 and n810 machines, too, so mark them now as deprecated. Signed-off-by: Thomas Huth --- hw/arm/nseries.c | 3 +++ qemu-deprecated.texi |

Re: [libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Martin Kletzander
On Fri, Apr 12, 2019 at 03:54:26PM +0100, Daniel P. Berrangé wrote: On Fri, Apr 12, 2019 at 03:32:21PM +0200, Martin Kletzander wrote: This does not cause a problem in usual scenarios thanks to us allowing CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be an issue

Re: [libvirt] [PATCH v5 2/2] PPC64 support for NVIDIA V100 GPU with NVLink2 passthrough

2019-04-12 Thread Erik Skultety
On Thu, Apr 04, 2019 at 10:40:39AM -0300, Daniel Henrique Barboza wrote: > The NVIDIA V100 GPU has an onboard RAM that is mapped into the > host memory and accessible as normal RAM via an NVLink2 bridge. When > passed through in a guest, QEMU puts the NVIDIA RAM window in a > non-contiguous area,

Re: [libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 03:32:21PM +0200, Martin Kletzander wrote: > This does not cause a problem in usual scenarios thanks to us allowing > CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be > an issue because the directory is created with mkdtemp(3) which explicitly

Re: [libvirt] [jenkins-ci PATCH 1/2] guests: Install ncurses for libvirt

2019-04-12 Thread Andrea Bolognani
On Fri, 2019-04-12 at 15:36 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 12, 2019 at 04:31:35PM +0200, Andrea Bolognani wrote: > > As of libvirt commit c98de2173e95, we use pkg-config to obtain > > CFLAGS and LIBS for readline whenever possible. However, since > > the readline.pc file contains a

Re: [libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Martin Kletzander
On Fri, Apr 12, 2019 at 02:45:32PM +0100, Daniel P. Berrangé wrote: On Fri, Apr 12, 2019 at 03:32:21PM +0200, Martin Kletzander wrote: This does not cause a problem in usual scenarios thanks to us allowing CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be an issue

Re: [libvirt] [PATCH v2] maint: Add filetype annotations to Makefile.inc.am

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 04:39:02PM +0200, Andrea Bolognani wrote: > Vim has trouble figuring out the filetype automatically because > the name doesn't follow existing conventions; annotations like > the ones we already have in Makefile.ci help it out. > > Signed-off-by: Andrea Bolognani > --- >

[libvirt] [PATCH v2] maint: Add filetype annotations to Makefile.inc.am

2019-04-12 Thread Andrea Bolognani
Vim has trouble figuring out the filetype automatically because the name doesn't follow existing conventions; annotations like the ones we already have in Makefile.ci help it out. Signed-off-by: Andrea Bolognani --- Changes from [v1]: * drop emacs annotation; * switch from filetype=make to

Re: [libvirt] [jenkins-ci PATCH 1/2] guests: Install ncurses for libvirt

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 04:31:35PM +0200, Andrea Bolognani wrote: > As of libvirt commit c98de2173e95, we use pkg-config to obtain > CFLAGS and LIBS for readline whenever possible. However, since > the readline.pc file contains a Requires.private for a module > that's shipped with ncurses (the

Re: [libvirt] [jenkins-ci PATCH 2/2] guests: Remove readline symlink kludge

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 04:31:36PM +0200, Andrea Bolognani wrote: > It's no longer needed as of libvirt commit dfe06e6202e4. > > Signed-off-by: Andrea Bolognani > --- > guests/playbooks/update/tasks/kludges.yml | 14 -- > 1 file changed, 14 deletions(-) Reviewed-by: Daniel P.

Re: [libvirt] RFC: remove qemu commandline parsing?

2019-04-12 Thread Daniel P . Berrangé
On Mon, Apr 08, 2019 at 06:16:03PM -0400, Cole Robinson wrote: > qemu/qemu_parse_command.c powers 'sudo virsh domxml-from-native > qemu-argv', parsing a qemu command line and attempting to turn it into > libvirt domain XML. Some history: > > RFE:

[libvirt] [jenkins-ci PATCH 2/2] guests: Remove readline symlink kludge

2019-04-12 Thread Andrea Bolognani
It's no longer needed as of libvirt commit dfe06e6202e4. Signed-off-by: Andrea Bolognani --- guests/playbooks/update/tasks/kludges.yml | 14 -- 1 file changed, 14 deletions(-) diff --git a/guests/playbooks/update/tasks/kludges.yml b/guests/playbooks/update/tasks/kludges.yml index

[libvirt] [jenkins-ci PATCH 1/2] guests: Install ncurses for libvirt

2019-04-12 Thread Andrea Bolognani
As of libvirt commit c98de2173e95, we use pkg-config to obtain CFLAGS and LIBS for readline whenever possible. However, since the readline.pc file contains a Requires.private for a module that's shipped with ncurses (the actual module varies based on the platform) we will end up falling back to

[libvirt] [jenkins-ci PATCH 0/2] guests: Remove readline symlink kludge

2019-04-12 Thread Andrea Bolognani
The last remaining one! \o/ Andrea Bolognani (2): guests: Install ncurses for libvirt guests: Remove readline symlink kludge guests/playbooks/update/tasks/kludges.yml | 14 -- guests/vars/mappings.yml | 8 guests/vars/projects/libvirt.yml | 1

Re: [libvirt] [PATCH] maint: Add filetype annotations to Makefile.inc.am

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 04:05:27PM +0200, Andrea Bolognani wrote: > On Fri, 2019-04-12 at 14:49 +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 12, 2019 at 02:44:04PM +0200, Andrea Bolognani wrote: > > > Both vim and emacs have trouble figuring out the filetype > > > automatically because the

Re: [libvirt] [PATCH v2 7/7] m4: readline: Add gross kludge for include path

2019-04-12 Thread Daniel P . Berrangé
On Tue, Apr 09, 2019 at 04:27:50PM +0200, Andrea Bolognani wrote: > Unfortunately the data reported by pkg-config is not completely > accurate, so until the issue has been fixed in readline we need > to work around it in libvirt. > > The good news is that we only need the fix to land in FreeBSD >

Re: [libvirt] [PATCH v2 6/7] m4: readline: Use pkg-config where possible

2019-04-12 Thread Daniel P . Berrangé
On Tue, Apr 09, 2019 at 04:27:49PM +0200, Andrea Bolognani wrote: > With the 7.0 release, readline has finally started shipping > pkg-config support in the form of a readline.pc file. > > Unfortunately, most downstreams have yet to catch up with this > change: among Linux distributions in

Re: [libvirt] [PATCH v2 5/7] m4: readline: Drop extra_LIBS machinery

2019-04-12 Thread Daniel P . Berrangé
On Tue, Apr 09, 2019 at 04:27:48PM +0200, Andrea Bolognani wrote: > The first implementation of this logic was introduced with > commit 2ec759fc58fe all the way back in 2007; looking at the > build logs from our CI environment, however, it's apparent > that none of the platforms we currently

Re: [libvirt] [PATCH v2 4/7] m4: readline: Extract code setting -D_FUNCTION_DEF

2019-04-12 Thread Daniel P . Berrangé
On Tue, Apr 09, 2019 at 04:27:47PM +0200, Andrea Bolognani wrote: > The current code is a bit awkward, and we're going to need > to share it later anyway. We can drop the call to AC_SUBST() > while we're at it, since LIBVIRT_CHECK_LIB() already marks > READLINE_CFLAGS for substitution. > > The

Re: [libvirt] [PATCH v2 3/7] m4: readline: Comment rl_completion_quote_character() check

2019-04-12 Thread Daniel P . Berrangé
On Tue, Apr 09, 2019 at 04:27:46PM +0200, Andrea Bolognani wrote: > The check was added in 74416b1d4849 without offering any > explanation outside of the commit message. Introduce a comment > to make digging through the git history unnecessary. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [PATCH] maint: Add filetype annotations to Makefile.inc.am

2019-04-12 Thread Andrea Bolognani
On Fri, 2019-04-12 at 14:49 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 12, 2019 at 02:44:04PM +0200, Andrea Bolognani wrote: > > Both vim and emacs have trouble figuring out the filetype > > automatically because the name doesn't follow existing > > conventions; annotations like the ones we

Re: [libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Martin Kletzander
On Fri, Apr 12, 2019 at 02:45:32PM +0100, Daniel P. Berrangé wrote: On Fri, Apr 12, 2019 at 03:32:21PM +0200, Martin Kletzander wrote: This does not cause a problem in usual scenarios thanks to us allowing CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be an issue

Re: [libvirt] [PATCH v2 2/7] m4: readline: Fix indentation

2019-04-12 Thread Daniel P . Berrangé
On Tue, Apr 09, 2019 at 04:27:45PM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > m4/virt-readline.m4 | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [PATCH] lib: Don't use virReportSystemError() if virCommandRun() fails

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 11:25:36AM +0200, Michal Privoznik wrote: > Firstly, virCommandRun() does report an error on failure (which > in most cases is more accurate than what we overwrite it with). > Secondly, usually errno is not set (or gets overwritten in the > cleanup code) which makes

Re: [libvirt] [PATCH v2 1/7] tools: vsh: Drop obsolete readline compatibility code

2019-04-12 Thread Daniel P . Berrangé
On Tue, Apr 09, 2019 at 04:27:44PM +0200, Andrea Bolognani wrote: > This code is needed to use readline older than 4.1, but all > our target platforms ship with at least 6.0 these days so we > can safely get rid of it. > > Signed-off-by: Andrea Bolognani > --- > tools/vsh.c | 17

Re: [libvirt] [PATCH] maint: Add filetype annotations to Makefile.inc.am

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 02:44:04PM +0200, Andrea Bolognani wrote: > Both vim and emacs have trouble figuring out the filetype > automatically because the name doesn't follow existing > conventions; annotations like the ones we already have in > Makefile.ci help them out. I don't see any problems

Re: [libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 03:32:21PM +0200, Martin Kletzander wrote: > This does not cause a problem in usual scenarios thanks to us allowing > CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be > an issue because the directory is created with mkdtemp(3) which explicitly

[libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Martin Kletzander
This does not cause a problem in usual scenarios thanks to us allowing CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be an issue because the directory is created with mkdtemp(3) which explicitly creates that with 0700 permissions and qemu running as non-root cannot

[libvirt] [PATCH v2 1/7] vbox: drop support for VirtualBox 4.x releases

2019-04-12 Thread Daniel P . Berrangé
Support for all the 4.x releases was ended by VirtualBox maintainers in Dec 2015. Even the "newest" 4.3.40 of those is only supported on old versions of Linux (Ubuntu <= 13.03, RHEL <= 6, SLES <= 11), which are all discontinued hosts from Libvirt's POV. We can thus reasonably drop all 4.x support

[libvirt] [PATCH v2 0/7] vbox: drop support for many old versions

2019-04-12 Thread Daniel P . Berrangé
Per this link: https://www.virtualbox.org/wiki/Download_Old_Builds VirtualBox 6.0 (active maintenance) VirtualBox 5.2 (active maintenance) VirtualBox 5.1 (no longer supported, support ended 2018/04) VirtualBox 5.0 (no longer supported, support ended 2017/05) VirtualBox 4.3

[libvirt] [PATCH] maint: Add filetype annotations to Makefile.inc.am

2019-04-12 Thread Andrea Bolognani
Both vim and emacs have trouble figuring out the filetype automatically because the name doesn't follow existing conventions; annotations like the ones we already have in Makefile.ci help them out. Signed-off-by: Andrea Bolognani --- src/access/Makefile.inc.am | 3 +++

[libvirt] [PATCH] conf: Fix typo enconding -> encoding

2019-04-12 Thread Andrea Bolognani
Introduced-by: e0fae78ad550 Spotted-by: Lintian Signed-off-by: Andrea Bolognani --- Pushed-as: trivial src/conf/domain_audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c index ce176f7940..de7386d4c6 100644 ---

Re: [libvirt] [PATCH for-QEMU-4.1] Declare -realtime as deprecated

2019-04-12 Thread Michal Privoznik
On 4/11/19 8:03 PM, Daniel P. Berrangé wrote: On Thu, Apr 11, 2019 at 07:53:45PM +0200, Thomas Huth wrote: The old -realtime mlock=on|off parameter does exactly the same as the new -overcommit mem-lock=on|off parameter. Additionally, "-realtime" does not activate any additional "realtime"

Re: [libvirt] [PATCH 0/7] vbox: drop support for many old versions

2019-04-12 Thread Daniel P . Berrangé
Sorry, this series fails to compile corrrectly. Will re-post. On Fri, Apr 12, 2019 at 12:05:46PM +0100, Daniel P. Berrangé wrote: > Per this link: > > https://www.virtualbox.org/wiki/Download_Old_Builds > > VirtualBox 6.0 (active maintenance) > VirtualBox 5.2 (active maintenance) >

Re: [libvirt] [PATCH 0/2] Add capability-based mlock tests

2019-04-12 Thread Ján Tomko
On Fri, Apr 12, 2019 at 01:21:55PM +0200, Michal Privoznik wrote: On 4/12/19 11:51 AM, Ján Tomko wrote: Ján Tomko (2): qemuxml2argvtest: add mlock tests for QEMU 3.0.0 qemuxml2argvtest: add mlock tests for latest QEMU .../mlock-off.x86_64-3.0.0.args | 32 +++

Re: [libvirt] [PATCH v2 0/2] qemu: Honor memory mode='strict'

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 01:15:05PM +0200, Michal Privoznik wrote: > On 4/12/19 12:11 PM, Daniel Henrique Barboza wrote: > > > > > > On 4/12/19 6:10 AM, Michal Privoznik wrote: > > > On 4/11/19 7:29 PM, Daniel Henrique Barboza wrote: > > > > > > > > > > > > On 4/11/19 11:56 AM, Michal Privoznik

Re: [libvirt] [PATCH 1/3] qemu: Always assume QEMU_CAPS_REALTIME_MLOCK

2019-04-12 Thread Michal Privoznik
On 4/12/19 12:03 PM, Ján Tomko wrote: On Fri, Apr 12, 2019 at 10:46:39AM +0200, Michal Privoznik wrote: The '-realtime mlock' cmd line argument was introduced in QEMU commit v1.5.0-rc0~190 which matches minimal QEMU version we require. Therefore, the capability will always be present.

Re: [libvirt] [PATCH 0/2] Add capability-based mlock tests

2019-04-12 Thread Michal Privoznik
On 4/12/19 11:51 AM, Ján Tomko wrote: Ján Tomko (2): qemuxml2argvtest: add mlock tests for QEMU 3.0.0 qemuxml2argvtest: add mlock tests for latest QEMU .../mlock-off.x86_64-3.0.0.args | 32 +++ .../mlock-off.x86_64-latest.args | 32

Re: [libvirt] [jenkins-ci PATCH] guests: Remove SASL symlink kludge

2019-04-12 Thread Erik Skultety
On Fri, Apr 12, 2019 at 09:18:33AM +0200, Andrea Bolognani wrote: > It's no longer needed as of libvirt commit ab6f29c6da12. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 34/36] vircpuhost: Add support for reading MSRs

2019-04-12 Thread Jiri Denemark
On Fri, Apr 12, 2019 at 11:11:38 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 12, 2019 at 11:47:15AM +0200, Jiri Denemark wrote: > > On Thu, Apr 11, 2019 at 17:13:51 +0100, Daniel P. Berrangé wrote: > > > On Mon, Apr 08, 2019 at 10:42:38AM +0200, Jiri Denemark wrote: > > > > The new

Re: [libvirt] [PATCH v2 0/2] qemu: Honor memory mode='strict'

2019-04-12 Thread Michal Privoznik
On 4/12/19 12:11 PM, Daniel Henrique Barboza wrote: On 4/12/19 6:10 AM, Michal Privoznik wrote: On 4/11/19 7:29 PM, Daniel Henrique Barboza wrote: On 4/11/19 11:56 AM, Michal Privoznik wrote: On 4/11/19 4:23 PM, Daniel Henrique Barboza wrote: Hi, I've tested these patches again, twice,

[libvirt] [PATCH 1/7] vbox: drop support for VirtualBox 4.x releases

2019-04-12 Thread Daniel P . Berrangé
Support for all the 4.x releases was ended by VirtualBox maintainers in Dec 2015. Even the "newest" 4.3.40 of those is only supported on old versions of Linux (Ubuntu <= 13.03, RHEL <= 6, SLES <= 11), which are all discontinued hosts from Libvirt's POV. We can thus reasonably drop all 4.x support

[libvirt] [PATCH 0/7] vbox: drop support for many old versions

2019-04-12 Thread Daniel P . Berrangé
Per this link: https://www.virtualbox.org/wiki/Download_Old_Builds VirtualBox 6.0 (active maintenance) VirtualBox 5.2 (active maintenance) VirtualBox 5.1 (no longer supported, support ended 2018/04) VirtualBox 5.0 (no longer supported, support ended 2017/05) VirtualBox 4.3

Re: [libvirt] [PATCH] virresctrl: fix MBA memory leak

2019-04-12 Thread Peter Krempa
On Thu, Apr 11, 2019 at 17:17:22 +0200, Pavel Hrdina wrote: > The 'bandwidths' variable is allocated using VIR_RESIZE_N so it has to > be freed as well. > > ==118315== 8 bytes in 1 blocks are definitely lost in loss record 299 of 2,401 > ==118315==at 0x4C29DAD: malloc

Re: [libvirt] [PATCH 34/36] vircpuhost: Add support for reading MSRs

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 11:47:15AM +0200, Jiri Denemark wrote: > On Thu, Apr 11, 2019 at 17:13:51 +0100, Daniel P. Berrangé wrote: > > On Mon, Apr 08, 2019 at 10:42:38AM +0200, Jiri Denemark wrote: > > > The new virHostCPUGetMSR internal API will try to read the MSR from > > > /dev/cpu/0/msr and

Re: [libvirt] [PATCH v2 0/2] qemu: Honor memory mode='strict'

2019-04-12 Thread Daniel Henrique Barboza
On 4/12/19 6:10 AM, Michal Privoznik wrote: On 4/11/19 7:29 PM, Daniel Henrique Barboza wrote: On 4/11/19 11:56 AM, Michal Privoznik wrote: On 4/11/19 4:23 PM, Daniel Henrique Barboza wrote: Hi, I've tested these patches again, twice, in similar setups like I tested the first version

Re: [libvirt] [PATCH 3/3] qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock'

2019-04-12 Thread Ján Tomko
On Fri, Apr 12, 2019 at 10:46:41AM +0200, Michal Privoznik wrote: The latter is deprecated and will be removed soon. The advised replacement is '-overcommit mem-lock=on|off'. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 11 ---

Re: [libvirt] [PATCH 2/3] qemu_capabilities: Introduce QEMU_CAPS_OVERCOMMIT

2019-04-12 Thread Ján Tomko
On Fri, Apr 12, 2019 at 10:46:40AM +0200, Michal Privoznik wrote: Added in QEMU commit of v3.0.0-rc0~48^2~9 QEMU is replacing fixed up by commit 1fdd4748711a released in 3.1.0 (or v3.1.0-rc0~119^2~37 ; this explains why it only shows up in 3.1.0 caps) '-realtime mlock' with '-overcommit

Re: [libvirt] [PATCH 1/3] qemu: Always assume QEMU_CAPS_REALTIME_MLOCK

2019-04-12 Thread Ján Tomko
On Fri, Apr 12, 2019 at 10:46:39AM +0200, Michal Privoznik wrote: The '-realtime mlock' cmd line argument was introduced in QEMU commit v1.5.0-rc0~190 which matches minimal QEMU version we require. Therefore, the capability will always be present. Apparently, nearly none of our xml2argv test

[libvirt] [PATCH 3/2] qemuxml2argvtests: remove old mlock tests

2019-04-12 Thread Ján Tomko
Now that we test with real QEMU data, remove the tests which enumerated the capabilities. Signed-off-by: Ján Tomko --- tests/qemuxml2argvdata/mlock-off.args | 27 --- tests/qemuxml2argvdata/mlock-unsupported.args | 26 --

[libvirt] [PATCH 1/2] qemuxml2argvtest: add mlock tests for QEMU 3.0.0

2019-04-12 Thread Ján Tomko
Test the memory locking command line with different QEMU versions to prepare for changing it for latest QEMU. Signed-off-by: Ján Tomko --- .../mlock-off.x86_64-3.0.0.args | 32 +++ .../mlock-on.x86_64-3.0.0.args| 32 +++

[libvirt] [PATCH 0/2] Add capability-based mlock tests

2019-04-12 Thread Ján Tomko
Ján Tomko (2): qemuxml2argvtest: add mlock tests for QEMU 3.0.0 qemuxml2argvtest: add mlock tests for latest QEMU .../mlock-off.x86_64-3.0.0.args | 32 +++ .../mlock-off.x86_64-latest.args | 32 +++ .../mlock-on.x86_64-3.0.0.args

[libvirt] [PATCH 2/2] qemuxml2argvtest: add mlock tests for latest QEMU

2019-04-12 Thread Ján Tomko
Test the memory locking command line with different QEMU versions to prepare for changing it for latest QEMU. Signed-off-by: Ján Tomko --- .../mlock-off.x86_64-latest.args | 32 +++ .../mlock-on.x86_64-latest.args | 32 +++

Re: [libvirt] [PATCH 34/36] vircpuhost: Add support for reading MSRs

2019-04-12 Thread Jiri Denemark
On Thu, Apr 11, 2019 at 17:13:51 +0100, Daniel P. Berrangé wrote: > On Mon, Apr 08, 2019 at 10:42:38AM +0200, Jiri Denemark wrote: > > The new virHostCPUGetMSR internal API will try to read the MSR from > > /dev/cpu/0/msr and if it is not possible (the device does not exist or > > libvirt is

[libvirt] [PATCH] lib: Don't use virReportSystemError() if virCommandRun() fails

2019-04-12 Thread Michal Privoznik
Firstly, virCommandRun() does report an error on failure (which in most cases is more accurate than what we overwrite it with). Secondly, usually errno is not set (or gets overwritten in the cleanup code) which makes virReportSystemError() report useless error messages. Drop all

Re: [libvirt] [PATCH 0/4] qemu_hotplug: Check for duplicate drive addresses

2019-04-12 Thread Michal Privoznik
On 4/11/19 8:36 PM, Daniel Henrique Barboza wrote: On 4/11/19 11:34 AM, Michal Privoznik wrote: This is an alternative approach to: https://www.redhat.com/archives/libvir-list/2019-March/msg0.html which caused regression to which a proposed fix is here:

Re: [libvirt] [PATCH v2 0/2] qemu: Honor memory mode='strict'

2019-04-12 Thread Michal Privoznik
On 4/11/19 7:29 PM, Daniel Henrique Barboza wrote: On 4/11/19 11:56 AM, Michal Privoznik wrote: On 4/11/19 4:23 PM, Daniel Henrique Barboza wrote: Hi, I've tested these patches again, twice, in similar setups like I tested the first version (first in a Power8, then in a Power9 server).

[libvirt] [PATCH 3/3] qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock'

2019-04-12 Thread Michal Privoznik
The latter is deprecated and will be removed soon. The advised replacement is '-overcommit mem-lock=on|off'. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 11 --- .../channel-unix-guestfwd.x86_64-latest.args | 2 +-

[libvirt] [PATCH 2/3] qemu_capabilities: Introduce QEMU_CAPS_OVERCOMMIT

2019-04-12 Thread Michal Privoznik
Added in QEMU commit of v3.0.0-rc0~48^2~9 QEMU is replacing '-realtime mlock' with '-overcommit mem-lock'. Add a capability to tell if we're dealing new new enough qemu to use the replacement. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 ++

[libvirt] [PATCH 0/3] qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock'

2019-04-12 Thread Michal Privoznik
Patches available also at: https://github.com/zippy2/libvirt/tree/qemu_mlock Inspired by the following QEMU patch: http://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg01980.html Michal Prívozník (3): qemu: Always assume QEMU_CAPS_REALTIME_MLOCK qemu_capabilities: Introduce

Re: [libvirt] [PATCH v3 0/7] extend virsh domstate to show additional information

2019-04-12 Thread Bjoern Walk
Bjoern Walk [2019-04-05, 12:35PM +0200]: > So, what's my course of action here? ping. Any advice would be much appreciated. signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5] tests: perform cross compiler builds on GitLab CI

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 09:53:14AM +0200, Peter Krempa wrote: > On Thu, Apr 11, 2019 at 18:39:53 +0100, Daniel Berrange wrote: > > GitLab CI provides some shared build runners that use Docker containers. > > This resource can usefully run cross-compiled builds since all other CI > > build testing

Re: [libvirt] [PATCH v5] tests: perform cross compiler builds on GitLab CI

2019-04-12 Thread Peter Krempa
On Thu, Apr 11, 2019 at 18:39:53 +0100, Daniel Berrange wrote: > GitLab CI provides some shared build runners that use Docker containers. > This resource can usefully run cross-compiled builds since all other CI > build testing is currently x86 only, and Travis CI is already very busy > testing

[libvirt] [jenkins-ci PATCH] guests: Remove SASL symlink kludge

2019-04-12 Thread Andrea Bolognani
It's no longer needed as of libvirt commit ab6f29c6da12. Signed-off-by: Andrea Bolognani --- guests/playbooks/update/tasks/kludges.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/guests/playbooks/update/tasks/kludges.yml b/guests/playbooks/update/tasks/kludges.yml index