Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-07 Thread Alex Williamson
On Sun, 5 May 2019 21:49:04 -0400 Yan Zhao wrote: > version attribute is used to check two mdev devices' compatibility. > > The key point of this version attribute is that it's rw. > User space has no need to understand internal of device version and no > need to compare versions by itself. > C

Re: [libvirt] [PATCH 0/2] Avoid issues due to qemu dropping osxsave and ospke

2019-05-07 Thread Daniel Henrique Barboza
On 4/25/19 9:50 AM, Christian Ehrhardt wrote: Hi, this series tries to address a drop of commandline options by qemu in regard to osxsave [1] and ospke [2]. This was already discussed in [3] late last year but got forgotten afterwards. The Ubuntu bug is at [4] and an older Fedora bug is at [5].

Re: [libvirt] [PATCH 2/2] qemuxml2argvtest: add test for remove cpu features

2019-05-07 Thread Daniel Henrique Barboza
On 4/25/19 9:50 AM, Christian Ehrhardt wrote: CPU features that always were a no-op in qemu got removed there. We no more specify them as that would trigger errors and fail to start qemu. This test ensures that those features really are not rendered into qemu command line. Without the related

Re: [libvirt] [PATCH 1/2] qemu: do not define known no-op features

2019-05-07 Thread Daniel Henrique Barboza
On 4/25/19 9:50 AM, Christian Ehrhardt wrote: Qemu dropped cpu features for osxsave and ospke [1][2]. The reason for the instant removal is that those features were never configurable as discussed in [3]. Fortunately the use cases adding those flags in the past are rare, but they exist. One t

[libvirt] [PATCH] test_driver: implement virDomainGetDiskErrors

2019-05-07 Thread Ilias Stamatis
Return the number of disks present in the configuration of the fake driver when called with @errors as NULL and @maxerrors as 0. Otherwise return 0 as the number of errors encountered. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 27 +++ 1 file changed, 27

Re: [libvirt] [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-05-07 Thread Eric Blake
On 5/7/19 4:39 AM, Daniel P. Berrangé wrote: >> JSON is terrible at interoperability, so good luck with that. >> >> If you reduce your order to "the commonly used JSON libraries we know", >> we can talk. > > I don't particularly want us to rely on semantics of small known set > of JSON libs. I re

[libvirt] [PATCH 1/2] Don't include Makefile.ci in Makefile.am

2019-05-07 Thread Martin Kletzander
The way it works now the Makefile needs to be both make valid and automake valid. That is fine for now, but if we want to use anything more advanced, like conditionals, we cannot have it like that any more. So instead forward all ci-* rules to that file. Signed-off-by: Martin Kletzander --- Ma

[libvirt] [PATCH 2/2] Add support for podman in Makefile.ci

2019-05-07 Thread Martin Kletzander
This way more users can run our CI builds locally. Signed-off-by: Martin Kletzander --- Makefile.ci | 125 ++-- 1 file changed, 93 insertions(+), 32 deletions(-) diff --git a/Makefile.ci b/Makefile.ci index 12a62167cc67..e2989ada313c 100644 --- a/

[libvirt] [PATCH 0/2] Support more container engines in Makefile.ci

2019-05-07 Thread Martin Kletzander
Maybe someone can add support for libvirt-lxc later on =) Martin Kletzander (2): Don't include Makefile.ci in Makefile.am Add support for podman in Makefile.ci Makefile.am | 4 +- Makefile.ci | 125 ++-- 2 files changed, 96 insertions(+), 33

Re: [libvirt] [PATCH 07/12] qemu: Refactor/simplify qemuDomainStorageSourceAccessRevoke

2019-05-07 Thread Ján Tomko
On Thu, Apr 18, 2019 at 04:43:02PM +0200, Peter Krempa wrote: Use qemuDomainStorageSourceAccessModify instead of the individual calls. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) Reviewed-by: Ján Tomko Jano si

Re: [libvirt] [PATCH 05/12] qemu: Convert boolean flags to enum flags in qemuDomainStorageSourceAccessModify

2019-05-07 Thread Ján Tomko
On Thu, Apr 18, 2019 at 04:43:00PM +0200, Peter Krempa wrote: Upcoming patches will add a few more flags. Add an enum to collect them so that we don't end up with multiple bools. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 23 --- 1 file changed, 16 insertions(+)

Re: [libvirt] [PATCH 06/12] qemu: Allow using qemuDomainStorageSourceAccessModify on singe images

2019-05-07 Thread Ján Tomko
On Thu, Apr 18, 2019 at 04:43:01PM +0200, Peter Krempa wrote: Add a new flag QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_CHAIN to select whether to work on single image or full chain. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 27 +-- 1 file changed, 21 insertions(+),

Re: [libvirt] [PATCH] tests: Move tools under tests/tools/

2019-05-07 Thread Peter Krempa
On Tue, May 07, 2019 at 12:15:54 +0100, Daniel Berrange wrote: > On Tue, May 07, 2019 at 12:49:18PM +0200, Michal Privoznik wrote: > > On 5/7/19 11:13 AM, Daniel P. Berrangé wrote: > > > On Mon, May 06, 2019 at 10:01:37AM +0200, Michal Privoznik wrote: > > > > There are some scripts/binaries that a

[libvirt] [jenkins-ci PATCH 0/4] guests: Introduce package_manager

2019-05-07 Thread Andrea Bolognani
As mentioned in [1] and detailed in [2], Fedora is planning to drop the 'yum' command and require users to call 'dnf' exclusively. In fact, it looks like this change has already been implemented in Rawhide, so we need to adapt sooner rather than later. The first two patches address the actual com

[libvirt] [jenkins-ci PATCH 1/4] guests: Introduce package_manager

2019-05-07 Thread Andrea Bolognani
Platforms that share the same package format might still want to use different package managers, a good example being CentOS with yum and Fedora with dnf. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-centos-7/main.yml| 1 + guests/host_vars/libvirt-debian-9/main.yml

[libvirt] [jenkins-ci PATCH 2/4] guests: Use package_manager everywhere

2019-05-07 Thread Andrea Bolognani
Instead of hardcoding the name of the package manager in commands, use the value obtained from the inventory. In some cases this is necessary, eg. when RPM-based distributions are involved; for most other cases we could get away with keepking the hardcoded names, but it's better to be completely c

[libvirt] [jenkins-ci PATCH 4/4] lcitool: Fix Dockerfile alignment

2019-05-07 Thread Andrea Bolognani
Now that we are using package_manager everywhere instead of hardcoding the names, it's finally possible to make the alignment of the resulting Dockerfiles perfect. Signed-off-by: Andrea Bolognani --- guests/lcitool | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/

[libvirt] [jenkins-ci PATCH 3/4] guests: Don't call out to the shell twice

2019-05-07 Thread Andrea Bolognani
We're already doing this for FreeBSD, so do it for CentOS and Fedora as well. Signed-off-by: Andrea Bolognani --- guests/playbooks/update/tasks/base.yml | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/guests/playbooks/update/tasks/base.yml b/guests/playbooks/upda

[libvirt] [PATCH v2] tests: Move tools under tests/tools/

2019-05-07 Thread Michal Privoznik
There are some scripts/binaries that are not tests themselves but rather fulfill support purpose. Separate them from the rest of the tests. Signed-off-by: Michal Privoznik --- diff to v1: - Found a way to generate a binary into a subdir. So no new Makefile.am is introduced .gitignore

Re: [libvirt] [PATCH] tests: Move tools under tests/tools/

2019-05-07 Thread Michal Privoznik
On 5/7/19 1:15 PM, Daniel P. Berrangé wrote: On Tue, May 07, 2019 at 12:49:18PM +0200, Michal Privoznik wrote: On 5/7/19 11:13 AM, Daniel P. Berrangé wrote: On Mon, May 06, 2019 at 10:01:37AM +0200, Michal Privoznik wrote: There are some scripts/binaries that are not tests themselves but rathe

Re: [libvirt] [PATCH 04/12] qemu: domain: Rename qemuDomainStorageSourceChainAccessPrepare

2019-05-07 Thread Ján Tomko
On Thu, Apr 18, 2019 at 04:42:59PM +0200, Peter Krempa wrote: The function will be able to deal with non-chains too so drop 'Chain' and also change the suffix to 'Modify' as it's used both for setup and teardown. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 14 +++--- 1 file

Re: [libvirt] [PATCH] tests: Move tools under tests/tools/

2019-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 12:49:18PM +0200, Michal Privoznik wrote: > On 5/7/19 11:13 AM, Daniel P. Berrangé wrote: > > On Mon, May 06, 2019 at 10:01:37AM +0200, Michal Privoznik wrote: > > > There are some scripts/binaries that are not tests themselves but > > > rather fulfill support purpose. Separ

Re: [libvirt] [PATCH] tests: Move tools under tests/tools/

2019-05-07 Thread Michal Privoznik
On 5/7/19 11:13 AM, Daniel P. Berrangé wrote: On Mon, May 06, 2019 at 10:01:37AM +0200, Michal Privoznik wrote: There are some scripts/binaries that are not tests themselves but rather fulfill support purpose. Separate them from the rest of the tests. Signed-off-by: Michal Privoznik --- .git

Re: [libvirt] [PATCH RFC] network: Delay creating private chains until starting network

2019-05-07 Thread Daniel P . Berrangé
On Tue, Apr 30, 2019 at 02:34:44PM -0600, Jim Fehlig wrote: > Automated performance tests found that network-centric workloads suffered > a 20 percent decrease when the host libvirt was updated from 5.0.0 to > 5.1.0. On the test hosts libvirtd is enabled to start at boot and the > "default" network

[libvirt] [PATCH] spec: Bump minimum supported Fedora version to 29

2019-05-07 Thread Andrea Bolognani
Fedora 30 is out, which means that Fedora 28 is going to be EOL very soon. Let's get ahead of the game and drop support for it right now. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 2 +- mingw-libvirt.spec.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [libvirt] [PATCH v6] tests: perform cross compiler builds on GitLab CI

2019-05-07 Thread Andrea Bolognani
On Tue, 2019-04-16 at 11:19 +0100, Daniel P. Berrangé wrote: > +.job_template: &job_definition > + script: > +- mkdir vpath > +- cd vpath We use build/ for CentOS CI and Travis CI builds, so let's stick with that here as well. > +- ../autogen.sh $CONFIGURE_OPTS We have some code to

Re: [libvirt] [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 10:47:06AM +0200, Markus Armbruster wrote: > > The Golang JSON parser decodes JSON numbers to float64 by default so > > will have this precision limitation too, though at least they provide > > a backdoor for custom parsing from the original serialized representation. > > >

Re: [libvirt] [PATCH v2 2/2] drm/i915/gvt: export mdev device version to sysfs for Intel vGPU

2019-05-07 Thread Cornelia Huck
On Sun, 5 May 2019 21:51:02 -0400 Yan Zhao wrote: > This feature implements the version attribute for Intel's vGPU mdev > devices. > > version attribute is rw. > It's used to check device compatibility for two mdev devices. > version string format and length are private for vendor driver. vendo

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-07 Thread Cornelia Huck
On Sun, 5 May 2019 21:49:04 -0400 Yan Zhao wrote: > version attribute is used to check two mdev devices' compatibility. > > The key point of this version attribute is that it's rw. > User space has no need to understand internal of device version and no > need to compare versions by itself. > C

Re: [libvirt] [PATCH] tests: Move tools under tests/tools/

2019-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2019 at 10:01:37AM +0200, Michal Privoznik wrote: > There are some scripts/binaries that are not tests themselves but > rather fulfill support purpose. Separate them from the rest of > the tests. > > Signed-off-by: Michal Privoznik > --- > .gitignore

Re: [libvirt] [PATCH] x86: Multi-key Total Memory Encryption (Intel)

2019-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2019 at 08:56:55PM +, Carvalho, Larkins L wrote: > Hello Peter, > > Thank you for the feedback. > I'll submit another patch series. > > I have a question regarding the test cap replies file. > We are querying Qemu to get the capability information. > The Qemu patch is not yet

Re: [libvirt] [PATCH 1/2] vfio/mdev: add version field as mandatory attribute for mdev device

2019-05-07 Thread Cornelia Huck
On Tue, 7 May 2019 01:39:13 -0400 Yan Zhao wrote: > On Tue, Apr 30, 2019 at 11:29:08PM +0800, Cornelia Huck wrote: > > If I followed the discussion correctly, I think you plan to drop this > > format, don't you? I'd be happy if a vendor driver can use a simple > > number without any prefixes if

Re: [libvirt] [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-05-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Apr 30, 2019 at 03:45:46PM +0100, Dr. David Alan Gilbert wrote: >> * Daniel P. Berrangé (berra...@redhat.com) wrote: >> > The QEMU QMP service is based on JSON which is nice because that is a >> > widely supported "standard" data format. >> > >> > ex

Re: [libvirt] [PATCH 2/3] virtestmock: Initialize symbols from stat() and its friends

2019-05-07 Thread Martin Kletzander
On Mon, May 06, 2019 at 04:34:07PM +0200, Michal Privoznik wrote: Introduced by ff376c6283c97. Previously, init_syms() was called from stat() mock and its friends. This is crucial because checkPath() might call printFile() which in turn calls real_fopen(). But if stat() or one of its friends is

Re: [libvirt] [PATCH 3/3] lib: Build sources before running 'check-access'

2019-05-07 Thread Martin Kletzander
ACK signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/3] virfilemock: Init symbols in canonicalize_file_name()

2019-05-07 Thread Martin Kletzander
ACK signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC] network: Delay creating private chains until starting network

2019-05-07 Thread Michal Privoznik
On 4/30/19 10:34 PM, Jim Fehlig wrote: Automated performance tests found that network-centric workloads suffered a 20 percent decrease when the host libvirt was updated from 5.0.0 to 5.1.0. On the test hosts libvirtd is enabled to start at boot and the "default" network is defined, but it is not

Re: [libvirt] [PATCH 4/4] tests: domaincaps: Add QEMU 4.0.0 for s390x

2019-05-07 Thread Boris Fiuczynski
On 5/6/19 2:42 PM, Andrea Bolognani wrote: On Fri, 2019-05-03 at 10:47 +0200, Boris Fiuczynski wrote: [...] +++ b/tests/domaincapstest.c @@ -453,6 +453,10 @@ mymain(void) DO_TEST_QEMU("4.0.0", "caps_4.0.0", "/usr/bin/qemu-system-x86_64", NULL, "x86_64"