Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 85 ++
1 file changed, 85 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index c14603e3af..2f4f94968b 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
Make the test driver only support the VIR_TYPED_PARAM_STRING flag for
now.
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 29 +
1 file changed, 29 insertions(+)
mode change 100644 => 100755 src/test/test_driver.c
diff --git a/src/test/test_driver.c
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 82 ++
1 file changed, 82 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 74de8f13ad..fa690e2bd6 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
I send these 2 patches together, since testConnectSupportsFeature needs
to be implemented in order for testDomainSetNumaParameters to support
string parameters.
Ilias Stamatis (2):
test_driver: implement virConnectSupportsFeature
test_driver: implement virDomainSetNumaParameters
On Tue, Jul 02, 2019 at 03:49:40PM +0200, Ilias Stamatis wrote:
> Changes since v1:
>
> - undefine the macro introduced in 1/4 when done with it's usage
> - simplified 4/4 by using the virNetDevBandwidthRate struct
>
> Ilias Stamatis (4):
> test_driver: introduce TEST_SET_PARAM macro
>
Allow using it from the tests.
Signed-off-by: Peter Krempa
---
src/conf/snapshot_conf.c | 2 +-
src/conf/snapshot_conf.h | 5 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index c7f29360e7..247d3f71b0 100644
---
QEMU allows us to create storage on certain network protocols which
allow image creation through their API. Wire up the generator for using
it with libvirt as well as for local files.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 88 +++
Tests will need to parse such a definition so it also needs to be freed.
Provide a function for it.
Signed-off-by: Peter Krempa
---
src/conf/snapshot_conf.c | 11 +++
src/conf/snapshot_conf.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/src/conf/snapshot_conf.c
To allow using -blockdev with blockjobs need to reopen files in
read-write mode when modifying the backing chain. To achieve this we
need to use 'auto-read-only' for the backing files rather than the
normal 'read-only' property. That way qemu knows that the files need to
be reopened.
Note that
Test the output against the schema and also against what we expect.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 170 ++
.../imagecreate/luks-encopts.json | 19 ++
.../imagecreate/luks-encopts.xml | 16 ++
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 9 +
src/qemu/qemu_domain.h | 5 +
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 6225ac23e2..79f18a6a7c 100644
--- a/src/qemu/qemu_domain.c
+++
'blockdev-add' allows us to use qemu to format images to our desired
format. This patch implements helpers which convert a
virStorageSourcePtr into JSON objects describing the required
configuration.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 321
Libvirt treats the JSON objects as lists thus the values appear in the
order they were added. To avoid too much changes introduce a helper
which allows to prepend a string which will allow to keep certain
outputs in order.
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 +
Add testing of the host specification part so that we can be sure that
no image/host specific data will be present.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 69 ++-
.../xml2json/block-raw-noopts-srconly.json| 4 ++
To allow reusing the formatters in the code for creating JSON properties
for 'blockdev-create' we need to create everyhing except the 'driver'
attribute.
Use the new helper virJSONValueObjectPrependString to put the driver at
the same place so that we don't change any output.
Signed-off-by:
To allow using blockdev-create we need to be able to generate the
properties for it, this series adds the necessary bits and also converts
to use 'auto-read-only' instead of 'read-only'.
Kevin, please look into the test data to see if there's something wrong
with the semantic usage. The data is
When formatting new qcow2 images we need to provide the backing store
string which should not contain any authentication or irelevant data.
Add a flag for qemuBlockStorageSourceGetBackendProps which allows to
skip the irrelevant data.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c |
On Thu, Jul 04, 2019 at 03:08:12PM +0200, Ilias Stamatis wrote:
> Right now nerrors can be used unitialized in the last for loop causing
> a bug.
>
> Signed-off-by: Ilias Stamatis
> ---
Dan already fixed it in the meantime.
Erik
--
libvir-list mailing list
libvir-list@redhat.com
There is an error path that jumps over the initialization of
nerrors, and the jump target reads the variable contents.
Signed-off-by: Daniel P. Berrangé
---
Pushed as a build fix
src/test/test_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/test_driver.c
Right now nerrors can be used unitialized in the last for loop causing
a bug.
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index ce4ff1a582..2371581f51 100644
---
On Thu, Jul 04, 2019 at 01:31:34PM +0200, Ilias Stamatis wrote:
> Zero out the user provided memory in order to avoid passing random
> pointers to VIR_FREE later.
>
> Signed-off-by: Ilias Stamatis
> ---
> src/test/test_driver.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
On Tue, Jul 02, 2019 at 03:49:44PM +0200, Ilias Stamatis wrote:
> Signed-off-by: Ilias Stamatis
> ---
> src/test/test_driver.c | 58 ++
> 1 file changed, 58 insertions(+)
>
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index
On Tue, Jul 02, 2019 at 03:49:41PM +0200, Ilias Stamatis wrote:
> This macro can be used by most or all of the DomainGetXXXParameters APIs.
Technically okay, but usually we introduce such helper macros with the first
function that needs it, solely because a patch such as this is effectively a
NOP
On Wed, Jul 03, 2019 at 02:38:06PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index ca1180d3d8..9ba53c4586 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -55,6 +55,17
On Wed, Jul 03, 2019 at 02:38:02PM +0200, Peter Krempa wrote:
It's the only place where it's used.
Signed-off-by: Peter Krempa
---
src/libvirt_xenconfig.syms | 1 -
src/xenconfig/xen_common.c | 62 ++
src/xenconfig/xen_sxpr.c | 62
On Wed, Jul 03, 2019 at 02:38:04PM +0200, Peter Krempa wrote:
The files are now completely unused. Remove them.
Signed-off-by: Peter Krempa
---
src/libvirt_xenconfig.syms| 4 ---
src/xenconfig/Makefile.inc.am | 2 --
src/xenconfig/xen_sxpr.c | 64 ---
On Wed, Jul 03, 2019 at 02:38:05PM +0200, Peter Krempa wrote:
There are no users any more.
Signed-off-by: Peter Krempa
---
po/POTFILES | 1 -
src/libvirt_private.syms | 18 --
src/util/Makefile.inc.am | 2 -
src/util/virsexpr.c | 608 ---
On Wed, Jul 03, 2019 at 02:38:03PM +0200, Peter Krempa wrote:
It's the only place where it's used.
Signed-off-by: Peter Krempa
---
src/libvirt_xenconfig.syms | 1 -
src/xenconfig/xen_common.c | 146 +
src/xenconfig/xen_sxpr.c | 146
On Wed, Jul 03, 2019 at 02:38:01PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/libvirt_xenconfig.syms | 1 -
src/xenconfig/xen_common.c | 68 ++--
src/xenconfig/xen_sxpr.c | 81 --
src/xenconfig/xen_sxpr.h | 2
On Wed, Jul 03, 2019 at 02:37:59PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/libvirt_xenconfig.syms |2 -
src/xenconfig/xen_sxpr.c | 1137
src/xenconfig/xen_sxpr.h | 13 -
3 files changed, 1152 deletions(-)
Reviewed-by: Ján
On Wed, Jul 03, 2019 at 02:38:00PM +0200, Peter Krempa wrote:
The 'error' label just returned -1. Inline it.
Signed-off-by: Peter Krempa
---
src/xenconfig/xen_sxpr.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
On Wed, Jul 03, 2019 at 01:54:18PM +0200, Ilias Stamatis wrote:
> Signed-off-by: Ilias Stamatis
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Jul 03, 2019 at 02:37:58PM +0200, Peter Krempa wrote:
Now that we no longer support sexpr conversion to the internal config we
can drop the test.
Signed-off-by: Peter Krempa
---
tests/Makefile.am | 10 +-
tests/sexpr2xmldata/sexpr2xml-boot-grub.sexpr | 6 -
On Wed, Jul 03, 2019 at 02:37:57PM +0200, Peter Krempa wrote:
We've dropped old xend support over a year ago. At this point we can
also drop support for parsing very old configs.
Signed-off-by: Peter Krempa
---
docs/drvxen.html.in | 3 +--
src/libxl/libxl_driver.c | 14 +++---
2
On Wed, Jul 03, 2019 at 02:37:56PM +0200, Peter Krempa wrote:
That's the only file using the helper function.
Signed-off-by: Peter Krempa
---
src/libvirt_xenconfig.syms | 1 -
src/xenconfig/xen_common.c | 79 ++
src/xenconfig/xen_sxpr.c | 78
On Wed, Jul 03, 2019 at 02:37:55PM +0200, Peter Krempa wrote:
Use new coding style to merge the only use of xenFormatSxprSound into
the caller.
Signed-off-by: Peter Krempa
---
src/libvirt_xenconfig.syms | 1 -
src/xenconfig/xen_common.c | 35 ++-
On Thu, Jul 04, 2019 at 01:31:34PM +0200, Ilias Stamatis wrote:
> Zero out the user provided memory in order to avoid passing random
"to a avoid potentially freeing uninitialized memory"
> pointers to VIR_FREE later.
>
> Signed-off-by: Ilias Stamatis
> ---
Reviewed-by: Erik Skultety
--
On Wed, Jul 03, 2019 at 02:37:54PM +0200, Peter Krempa wrote:
It's no longer used. Remove the dead code.
Signed-off-by: Peter Krempa
---
src/libvirt_xenconfig.syms | 4 -
src/xenconfig/xen_sxpr.c | 880 -
src/xenconfig/xen_sxpr.h | 12 -
3 files changed,
On Mon, 1 Jul 2019 at 23:29, Eduardo Habkost wrote:
>
> The following changes since commit 7d0e02405fc02a181319b1ab8681d2f72246b7c6:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2019-07-01
> 17:40:32 +0100)
>
> are available in the Git
On Wed, Jul 03, 2019 at 02:37:53PM +0200, Peter Krempa wrote:
The test was the only place calling 'xenFormatSxpr'. Drop it as there
are no other users of that code since we've dropped xend support.
commit 1dac5f06a0341e8087dc33af75c8352d77a4
CommitDate: 2018-04-09 11:38:05 -0600
Remove
On Thu, Jul 04, 2019 at 01:28:36PM +0200, Ilias Stamatis wrote:
> On Thu, Jul 4, 2019 at 12:58 PM Pavel Hrdina wrote:
> >
> > On Wed, Jun 26, 2019 at 06:36:28PM +0200, Ilias Stamatis wrote:
> > > Hello,
> > >
> > > I was thinking about how to implement the following APIs in the test
> > >
Zero out the user provided memory in order to avoid passing random
pointers to VIR_FREE later.
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index
On Thu, Jul 4, 2019 at 12:58 PM Pavel Hrdina wrote:
>
> On Wed, Jun 26, 2019 at 06:36:28PM +0200, Ilias Stamatis wrote:
> > Hello,
> >
> > I was thinking about how to implement the following APIs in the test driver:
> > -virDomainFSFreeze
> > -virDomainFSThaw
> > -virDomainFSTrim
> >
> > The
On Wed, Jun 26, 2019 at 06:36:28PM +0200, Ilias Stamatis wrote:
> Hello,
>
> I was thinking about how to implement the following APIs in the test driver:
> -virDomainFSFreeze
> -virDomainFSThaw
> -virDomainFSTrim
>
> The first two are conceptually paired. They both get a mountpoints
> argument.
On Thu, Jul 04, 2019 at 12:40:32PM +0200, Pino Toscano wrote:
> Mention libssh as possible transport in the error message of an
> unrecognized transport.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1727013
>
> Signed-off-by: Pino Toscano
> ---
> src/remote/remote_driver.c | 2 +-
> 1 file
Mention libssh as possible transport in the error message of an
unrecognized transport.
https://bugzilla.redhat.com/show_bug.cgi?id=1727013
Signed-off-by: Pino Toscano
---
src/remote/remote_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c
Signed-off-by: Sahid Orentino Ferdjaoui
---
README.md | 4
1 file changed, 4 insertions(+)
diff --git a/README.md b/README.md
index a359574..6e1ad64 100644
--- a/README.md
+++ b/README.md
@@ -76,14 +76,18 @@ at any time. The preferred submission method is to use git
send-email
to submit
The open_auth test cases were randomly failling. It seems that because
tests are executed in parallel if a sasl connection is open when an
other happen in same time from the same libvirt connection an error
happens: "Failed to start SASL negotiation: -4 (SASL(-4): no mechanism
available: No worthy
Not sure what the problem is by using 'scram-sha-1' with ubuntu:
cannot list SASL mechanisms -4 (SASL(-4): no mechanism available:
Internal Error -4 in ../../lib/server.c near line 1762)
So we currently switch the mech to digest-md5. Seems that libvirt-go
is doing same.
Signed-off-by: Sahid
Signed-off-by: Sahid Orentino Ferdjaoui
---
tests/domain.rs | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/tests/domain.rs b/tests/domain.rs
index 5a64a75..a70139e 100644
--- a/tests/domain.rs
+++ b/tests/domain.rs
@@ -89,26 +89,25 @@ fn
Signed-off-by: Sahid Orentino Ferdjaoui
---
.travis.yml | 7 +++
README.md | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index c52f745..2267a8f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -13,11 +13,10 @@ matrix:
- rust: nightly
Hello Daniel,
When you have a moment, can you please merge this serie. It fixes CI
issue, switch to bionic, and updates the tested versions.
Results:
https://travis-ci.org/sahid/libvirt-rust/builds/554170698
Thanks,
s.
Sahid Orentino Ferdjaoui (5):
fix bug integration test with rust
This reverts commit 14b6a1854fb4c02c5fb2f51679f8ff099f28f53c.
If virLXCDomainSetRunlevel returns -1 this indicates a serious
error / failure that must be propagated to the caller. We must
not carry on with other shutdown methods in this case.
If virLXCDomainSetRunlevel return 0, this indicates
On Thu, Jul 04, 2019 at 11:04:15AM +0200, Lubomir Rintel wrote:
> virInitctlSetRunLevel() returns 0 only if ended up doing nothing, 1 if it
> actually succeeded. Let's check for the error condition.
>
> Without this, a successful reboot would be treated as a failure and the
> LXC driver will
On Wed, Jul 03, 2019 at 09:07:10PM +0300, Nikolai Zhubr wrote:
> At the moment I'm running a quite outdated version 1.2.9 of libvirt, but
> because other than this issue it does its job pretty well I'd first consider
> some patching/backporting rather than totally replacing it with a new one.
>
virInitctlSetRunLevel() returns 0 only if ended up doing nothing, 1 if it
actually succeeded. Let's check for the error condition.
Without this, a successful reboot would be treated as a failure and the
LXC driver will proceed sending a TERM signal instead, effectively
cancelling the shutdown.
On Thu, Jul 04, 2019 at 09:28:01AM +0200, Peter Krempa wrote:
> On Thu, Jul 04, 2019 at 08:16:21 +0200, Fabiano Fidêncio wrote:
> > 86fbce56f27e removed the constant, but didn't actually adjust the only
> > place where the constant was used.
> >
> > Signed-off-by: Fabiano Fidêncio
> > ---
> >
On Thu, Jul 04, 2019 at 09:26:26AM +0200, Peter Krempa wrote:
> The constant is not unused and breaks the build of the remote driver.
>
> This reverts commit 86fbce56f27e06b34d63879c9f634a58a1e0a04a.
>
> Signed-off-by: Peter Krempa
> ---
>
> Pushed under the build-breaker rule.
>
>
On Thu, Jul 4, 2019 at 9:28 AM Peter Krempa wrote:
>
> On Thu, Jul 04, 2019 at 08:16:21 +0200, Fabiano Fidêncio wrote:
> > 86fbce56f27e removed the constant, but didn't actually adjust the only
> > place where the constant was used.
> >
> > Signed-off-by: Fabiano Fidêncio
> > ---
> > This patch
On Thu, Jul 04, 2019 at 08:16:21 +0200, Fabiano Fidêncio wrote:
> 86fbce56f27e removed the constant, but didn't actually adjust the only
> place where the constant was used.
>
> Signed-off-by: Fabiano Fidêncio
> ---
> This patch fixes a build breakage.
>
> It's either this, or reverting
The constant is not unused and breaks the build of the remote driver.
This reverts commit 86fbce56f27e06b34d63879c9f634a58a1e0a04a.
Signed-off-by: Peter Krempa
---
Pushed under the build-breaker rule.
src/remote/remote_driver.h | 1 +
1 file changed, 1 insertion(+)
diff --git
On Wed, Jul 3, 2019 at 6:44 PM Cole Robinson wrote:
>
> Some fedora version tweaks
>
> Cole Robinson (2):
> spec: Unconditionally build python2 on Fedora
> spec: Bump minimum supported Fedora version to 29
>
> libvirt-python.spec.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This patch is sort of incomplete since the unprivileged usage path still
shows the default path for the configuration file that this patch would
remove for the privileged path.
I think the simplest solution is to revert 86fbce56f27e.
On 7/4/19 8:16 AM, Fabiano Fidêncio wrote:
86fbce56f27e
Fabiano Fidêncio [2019-07-04, 08:16AM +0200]:
> 86fbce56f27e removed the constant, but didn't actually adjust the only
> place where the constant was used.
>
> Signed-off-by: Fabiano Fidêncio
> ---
> This patch fixes a build breakage.
>
> It's either this, or reverting 86fbce56f27e.
> ---
>
On 7/3/19 1:17 PM, Daniel P. Berrangé wrote:
> On Wed, Jul 03, 2019 at 08:56:29AM +0200, Michal Prívozník wrote:
>> On 6/20/19 2:39 PM, Michal Privoznik wrote:
>>> On 6/17/19 3:34 PM, Daniel P. Berrangé wrote:
On Mon, Jun 03, 2019 at 06:07:02PM +0200, Michal Privoznik wrote:
> On 4/25/19
On Wed, Jul 3, 2019 at 9:27 PM Radostin Stoyanov wrote:
>
> $ grep -R LIBVIRTD_CONFIGURATION_FILE .
> ./docs/news-2013.html.in: Fix LIBVIRTD_CONFIGURATION_FILE constant
> (Christophe Fergeau),
> ./src/remote/remote_daemon.c: LIBVIRTD_CONFIGURATION_FILE,
>
> and make fails with:
>
>CC
86fbce56f27e removed the constant, but didn't actually adjust the only
place where the constant was used.
Signed-off-by: Fabiano Fidêncio
---
This patch fixes a build breakage.
It's either this, or reverting 86fbce56f27e.
---
src/remote/remote_daemon.c | 4
1 file changed, 4 deletions(-)
67 matches
Mail list logo
